)]}'
{"specs/queens/approved/proactive-rca.rst":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"44173b69eda821a098afaf5bb29287664e5c9a3e","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Currently, Vitrage relies on the monitored events for root cause analysis. It"},{"line_number":21,"context_line":"may deduce alarms on virtual resources, but it is always in a confirmed state."},{"line_number":22,"context_line":"But in the real world, things could be more complicated, suppose there are two"},{"line_number":23,"context_line":"possible causes (A or B) for fault C. When fault C is monitored, it is"},{"line_number":24,"context_line":"suspicious that A or B could happen and be the root cause. We need a way to"},{"line_number":25,"context_line":"take action in such case to find the root cause more proactively."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_7e981abf","line":22,"range":{"start_line":22,"start_character":55,"end_line":22,"end_character":56},"updated":"2017-11-15 10:13:25.000000000","message":". S","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"e61630d2d9b7857b645820b5287b2502604a80ef","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Currently, Vitrage relies on the monitored events for root cause analysis. It"},{"line_number":21,"context_line":"may deduce alarms on virtual resources, but it is always in a confirmed state."},{"line_number":22,"context_line":"But in the real world, things could be more complicated, suppose there are two"},{"line_number":23,"context_line":"possible causes (A or B) for fault C. When fault C is monitored, it is"},{"line_number":24,"context_line":"suspicious that A or B could happen and be the root cause. We need a way to"},{"line_number":25,"context_line":"take action in such case to find the root cause more proactively."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_1996c940","line":22,"range":{"start_line":22,"start_character":55,"end_line":22,"end_character":56},"in_reply_to":"1f485f77_7e981abf","updated":"2017-11-16 03:41:36.000000000","message":"Done","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"44173b69eda821a098afaf5bb29287664e5c9a3e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"suspicious that A or B could happen and be the root cause. We need a way to"},{"line_number":25,"context_line":"take action in such case to find the root cause more proactively."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Fault model"},{"line_number":28,"context_line":"-----------"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The fault model is illustrated in following graph."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_de3a6e96","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":11},"updated":"2017-11-15 10:13:25.000000000","message":"I think this belongs in the proposed change section","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"e61630d2d9b7857b645820b5287b2502604a80ef","unresolved":false,"context_lines":[{"line_number":24,"context_line":"suspicious that A or B could happen and be the root cause. We need a way to"},{"line_number":25,"context_line":"take action in such case to find the root cause more proactively."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Fault model"},{"line_number":28,"context_line":"-----------"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The fault model is illustrated in following graph."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_791ffdb6","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":11},"in_reply_to":"1f485f77_de3a6e96","updated":"2017-11-16 03:41:36.000000000","message":"Done","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"44173b69eda821a098afaf5bb29287664e5c9a3e","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        }"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Deductive reasoning"},{"line_number":101,"context_line":"-------------------"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Suppose we received a series of events in the following order:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_7e749a68","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":19},"updated":"2017-11-15 10:13:25.000000000","message":"Same here, should be part of the proposed change","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"e61630d2d9b7857b645820b5287b2502604a80ef","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        }"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Deductive reasoning"},{"line_number":101,"context_line":"-------------------"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Suppose we received a series of events in the following order:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_591c41c0","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":19},"in_reply_to":"1f485f77_7e749a68","updated":"2017-11-16 03:41:36.000000000","message":"Done","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"44173b69eda821a098afaf5bb29287664e5c9a3e","unresolved":false,"context_lines":[{"line_number":106,"context_line":"#. t1: fault C active monitored"},{"line_number":107,"context_line":"    #. Vitrage deduces that fault A and fault B are active in suspect state"},{"line_number":108,"context_line":"    #. execute diagnose action to confirm suspect state, e.g. polling status of fault A and fault B proactively"},{"line_number":109,"context_line":"#. t2: fault A active and fault B inactive returned from diagnostic action"},{"line_number":110,"context_line":"    #. as a side-effect, Vitrage will deduce that fault C is active"},{"line_number":111,"context_line":"#. t3: fault C inactive monitored"},{"line_number":112,"context_line":"    #. from the fault model, we can deduce fault A and fault B are inactive"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_7ef93ac6","line":109,"range":{"start_line":109,"start_character":43,"end_line":109,"end_character":74},"updated":"2017-11-15 10:13:25.000000000","message":"Returned to where? I assume that you will use a notifier (Mistral? other?) to execute the diagnostic action. There is no point in returning the result to the notifier, as it performs no action in Vitrage. So the question is who will decide what to do next.","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"e61630d2d9b7857b645820b5287b2502604a80ef","unresolved":false,"context_lines":[{"line_number":106,"context_line":"#. t1: fault C active monitored"},{"line_number":107,"context_line":"    #. Vitrage deduces that fault A and fault B are active in suspect state"},{"line_number":108,"context_line":"    #. execute diagnose action to confirm suspect state, e.g. polling status of fault A and fault B proactively"},{"line_number":109,"context_line":"#. t2: fault A active and fault B inactive returned from diagnostic action"},{"line_number":110,"context_line":"    #. as a side-effect, Vitrage will deduce that fault C is active"},{"line_number":111,"context_line":"#. t3: fault C inactive monitored"},{"line_number":112,"context_line":"    #. from the fault model, we can deduce fault A and fault B are inactive"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_399745ef","line":109,"range":{"start_line":109,"start_character":43,"end_line":109,"end_character":74},"in_reply_to":"1f485f77_7ef93ac6","updated":"2017-11-16 03:41:36.000000000","message":"Clarified","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"44173b69eda821a098afaf5bb29287664e5c9a3e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    #. Vitrage deduces that fault A and fault B are active in suspect state"},{"line_number":108,"context_line":"    #. execute diagnose action to confirm suspect state, e.g. polling status of fault A and fault B proactively"},{"line_number":109,"context_line":"#. t2: fault A active and fault B inactive returned from diagnostic action"},{"line_number":110,"context_line":"    #. as a side-effect, Vitrage will deduce that fault C is active"},{"line_number":111,"context_line":"#. t3: fault C inactive monitored"},{"line_number":112,"context_line":"    #. from the fault model, we can deduce fault A and fault B are inactive"},{"line_number":113,"context_line":"    #. inconsistency detected between fault A deduced (inactive) and monitored (active)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_7e225a54","line":110,"range":{"start_line":110,"start_character":25,"end_line":110,"end_character":67},"updated":"2017-11-15 10:13:25.000000000","message":"Please add that this will be done in addition/in parallel to the already existing fault C from the monitor","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"e61630d2d9b7857b645820b5287b2502604a80ef","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    #. Vitrage deduces that fault A and fault B are active in suspect state"},{"line_number":108,"context_line":"    #. execute diagnose action to confirm suspect state, e.g. polling status of fault A and fault B proactively"},{"line_number":109,"context_line":"#. t2: fault A active and fault B inactive returned from diagnostic action"},{"line_number":110,"context_line":"    #. as a side-effect, Vitrage will deduce that fault C is active"},{"line_number":111,"context_line":"#. t3: fault C inactive monitored"},{"line_number":112,"context_line":"    #. from the fault model, we can deduce fault A and fault B are inactive"},{"line_number":113,"context_line":"    #. inconsistency detected between fault A deduced (inactive) and monitored (active)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_f99c0d0f","line":110,"range":{"start_line":110,"start_character":25,"end_line":110,"end_character":67},"in_reply_to":"1f485f77_7e225a54","updated":"2017-11-16 03:41:36.000000000","message":"Done","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"44173b69eda821a098afaf5bb29287664e5c9a3e","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    #. execute diagnose action to confirm suspect state, e.g. polling status of fault A and fault B proactively"},{"line_number":109,"context_line":"#. t2: fault A active and fault B inactive returned from diagnostic action"},{"line_number":110,"context_line":"    #. as a side-effect, Vitrage will deduce that fault C is active"},{"line_number":111,"context_line":"#. t3: fault C inactive monitored"},{"line_number":112,"context_line":"    #. from the fault model, we can deduce fault A and fault B are inactive"},{"line_number":113,"context_line":"    #. inconsistency detected between fault A deduced (inactive) and monitored (active)"},{"line_number":114,"context_line":"    #. execute diagnose action to resolve status inconsistency, e.g. polling status of fault A"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_7ee7fa13","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":1},"updated":"2017-11-15 10:13:25.000000000","message":"I think one step is missing: what are you going to do about faults A and B, after the diagnostics? are you going to remove the inactive suspect B? and if so, how?","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"e61630d2d9b7857b645820b5287b2502604a80ef","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    #. execute diagnose action to confirm suspect state, e.g. polling status of fault A and fault B proactively"},{"line_number":109,"context_line":"#. t2: fault A active and fault B inactive returned from diagnostic action"},{"line_number":110,"context_line":"    #. as a side-effect, Vitrage will deduce that fault C is active"},{"line_number":111,"context_line":"#. t3: fault C inactive monitored"},{"line_number":112,"context_line":"    #. from the fault model, we can deduce fault A and fault B are inactive"},{"line_number":113,"context_line":"    #. inconsistency detected between fault A deduced (inactive) and monitored (active)"},{"line_number":114,"context_line":"    #. execute diagnose action to resolve status inconsistency, e.g. polling status of fault A"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_99b0798c","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":1},"in_reply_to":"1f485f77_7ee7fa13","updated":"2017-11-16 03:41:36.000000000","message":"Clarified below, the suspect status will be removed by the deduction from new status.","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"44173b69eda821a098afaf5bb29287664e5c9a3e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"#. t2: fault A active and fault B inactive returned from diagnostic action"},{"line_number":110,"context_line":"    #. as a side-effect, Vitrage will deduce that fault C is active"},{"line_number":111,"context_line":"#. t3: fault C inactive monitored"},{"line_number":112,"context_line":"    #. from the fault model, we can deduce fault A and fault B are inactive"},{"line_number":113,"context_line":"    #. inconsistency detected between fault A deduced (inactive) and monitored (active)"},{"line_number":114,"context_line":"    #. execute diagnose action to resolve status inconsistency, e.g. polling status of fault A"},{"line_number":115,"context_line":"#. t4: fault A inactive returned from diagnostic action"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_3ead0288","line":112,"range":{"start_line":112,"start_character":7,"end_line":112,"end_character":75},"updated":"2017-11-15 10:13:25.000000000","message":"Is it always so? in this specific use case, you may say that if A or B happen then for sure C happens. But I assume that there are use cases where C may be caused by A or B; but it is also possible that A happens and C doesn\u0027t happen. We need to make sure this use case is also supported.\n\nAn example: vm high cpu *may* cause performance degradation on the application. If there is a performance degradation, we better check the vm cpu. But if the application is running fine, it does *not* mean that the vm cpu is not high.","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"25e78341635fe77a73cf7533c37af4f0851b1f55","unresolved":false,"context_lines":[{"line_number":109,"context_line":"#. t2: fault A active and fault B inactive returned from diagnostic action"},{"line_number":110,"context_line":"    #. as a side-effect, Vitrage will deduce that fault C is active"},{"line_number":111,"context_line":"#. t3: fault C inactive monitored"},{"line_number":112,"context_line":"    #. from the fault model, we can deduce fault A and fault B are inactive"},{"line_number":113,"context_line":"    #. inconsistency detected between fault A deduced (inactive) and monitored (active)"},{"line_number":114,"context_line":"    #. execute diagnose action to resolve status inconsistency, e.g. polling status of fault A"},{"line_number":115,"context_line":"#. t4: fault A inactive returned from diagnostic action"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_e2d21100","line":112,"range":{"start_line":112,"start_character":7,"end_line":112,"end_character":75},"in_reply_to":"1f485f77_3a4f336c","updated":"2017-11-16 08:36:12.000000000","message":"Ok, I agree. I actually talked about RCA and not about deduction. If you can deduce C from A, then the other direction always works. In my example, vm high cpu is the root cause for performance degradation, but we can not deduce performance degradation from the high cpu. \n\nBottom line: what you wrote is OK.","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"e61630d2d9b7857b645820b5287b2502604a80ef","unresolved":false,"context_lines":[{"line_number":109,"context_line":"#. t2: fault A active and fault B inactive returned from diagnostic action"},{"line_number":110,"context_line":"    #. as a side-effect, Vitrage will deduce that fault C is active"},{"line_number":111,"context_line":"#. t3: fault C inactive monitored"},{"line_number":112,"context_line":"    #. from the fault model, we can deduce fault A and fault B are inactive"},{"line_number":113,"context_line":"    #. inconsistency detected between fault A deduced (inactive) and monitored (active)"},{"line_number":114,"context_line":"    #. execute diagnose action to resolve status inconsistency, e.g. polling status of fault A"},{"line_number":115,"context_line":"#. t4: fault A inactive returned from diagnostic action"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_3a4f336c","line":112,"range":{"start_line":112,"start_character":7,"end_line":112,"end_character":75},"in_reply_to":"1f485f77_3ead0288","updated":"2017-11-16 03:41:36.000000000","message":"(A or B) \u003d\u003e C is equivalent to (not C) \u003d\u003e (not A) and (not B) , See  https://en.wikipedia.org/wiki/Contraposition\n\nIf A happens and C does not happen, then the fault model is wrong. The fault model proposed here is a **deterministic** inference, such as if power off, the host won\u0027t be available. If network disconnected, the instance is not reachable.\n\nIf the relationship between A and C is not determined, then we should not put it in fault model. A fuzzy fault model is much more challenge and I haven\u0027t consider the details about it yet.\n\nGet back to the \"vm high\" may cause \"application performance degradation\" example, this can be modeled in current Vitrage template which is more flexible, though a bit complex to write all the rules explicitly.","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"44173b69eda821a098afaf5bb29287664e5c9a3e","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    #. from the fault model, we can deduce fault A and fault B are inactive"},{"line_number":113,"context_line":"    #. inconsistency detected between fault A deduced (inactive) and monitored (active)"},{"line_number":114,"context_line":"    #. execute diagnose action to resolve status inconsistency, e.g. polling status of fault A"},{"line_number":115,"context_line":"#. t4: fault A inactive returned from diagnostic action"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Let\u0027s illustrate the deductive reasoning in graphs."},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_1ec1262f","line":115,"range":{"start_line":115,"start_character":24,"end_line":115,"end_character":55},"updated":"2017-11-15 10:13:25.000000000","message":"Returned where?","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"e61630d2d9b7857b645820b5287b2502604a80ef","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    #. from the fault model, we can deduce fault A and fault B are inactive"},{"line_number":113,"context_line":"    #. inconsistency detected between fault A deduced (inactive) and monitored (active)"},{"line_number":114,"context_line":"    #. execute diagnose action to resolve status inconsistency, e.g. polling status of fault A"},{"line_number":115,"context_line":"#. t4: fault A inactive returned from diagnostic action"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Let\u0027s illustrate the deductive reasoning in graphs."},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_9a3f47b3","line":115,"range":{"start_line":115,"start_character":24,"end_line":115,"end_character":55},"in_reply_to":"1f485f77_1ec1262f","updated":"2017-11-16 03:41:36.000000000","message":"Clarified","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"44173b69eda821a098afaf5bb29287664e5c9a3e","unresolved":false,"context_lines":[{"line_number":164,"context_line":"t1: downstream fault monitored, upstream fault deduced"},{"line_number":165,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"- white: fault in undefined status"},{"line_number":168,"context_line":"- red: fault in confirmed status"},{"line_number":169,"context_line":"- pink: fault in suspect status"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_be357248","line":167,"range":{"start_line":167,"start_character":2,"end_line":167,"end_character":7},"updated":"2017-11-15 10:13:25.000000000","message":"gray","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"e61630d2d9b7857b645820b5287b2502604a80ef","unresolved":false,"context_lines":[{"line_number":164,"context_line":"t1: downstream fault monitored, upstream fault deduced"},{"line_number":165,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"- white: fault in undefined status"},{"line_number":168,"context_line":"- red: fault in confirmed status"},{"line_number":169,"context_line":"- pink: fault in suspect status"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_7a480b5b","line":167,"range":{"start_line":167,"start_character":2,"end_line":167,"end_character":7},"in_reply_to":"1f485f77_be357248","updated":"2017-11-16 03:41:36.000000000","message":"Done","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"44173b69eda821a098afaf5bb29287664e5c9a3e","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    }"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"t2: diagnose action executed, upstream fault confirmed"},{"line_number":219,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"- green: recovery in confirmed status"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_3e4982cf","line":218,"range":{"start_line":218,"start_character":5,"end_line":218,"end_character":28},"updated":"2017-11-15 10:13:25.000000000","message":"Where do the \u0027diagnose\u0027 edges come from?\nAnd who changes the state of b_m to green?","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"e61630d2d9b7857b645820b5287b2502604a80ef","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    }"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"t2: diagnose action executed, upstream fault confirmed"},{"line_number":219,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"- green: recovery in confirmed status"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_dacedfb2","line":218,"range":{"start_line":218,"start_character":5,"end_line":218,"end_character":28},"in_reply_to":"1f485f77_3e4982cf","updated":"2017-11-16 03:41:36.000000000","message":"Clarified.","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"44173b69eda821a098afaf5bb29287664e5c9a3e","unresolved":false,"context_lines":[{"line_number":218,"context_line":"t2: diagnose action executed, upstream fault confirmed"},{"line_number":219,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"- green: recovery in confirmed status"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":".. graphviz::"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_1e724612","line":221,"range":{"start_line":221,"start_character":0,"end_line":221,"end_character":37},"updated":"2017-11-15 10:13:25.000000000","message":"In this diagram, C is below A and B. On the previous diagram it was on top. Is there a way to make the display consistent?","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"e61630d2d9b7857b645820b5287b2502604a80ef","unresolved":false,"context_lines":[{"line_number":218,"context_line":"t2: diagnose action executed, upstream fault confirmed"},{"line_number":219,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"- green: recovery in confirmed status"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":".. graphviz::"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_9a498732","line":221,"range":{"start_line":221,"start_character":0,"end_line":221,"end_character":37},"in_reply_to":"1f485f77_1e724612","updated":"2017-11-16 03:41:36.000000000","message":"I didn\u0027t find a smart layout engine. But there is some dirty workaround to pin them in absolute position.\n\nI will try in a separate patch.","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"44173b69eda821a098afaf5bb29287664e5c9a3e","unresolved":false,"context_lines":[{"line_number":388,"context_line":"The main change would be allowing raise alarms in suspect status which can be used to trigger a diagnostic action."},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"- Allow setting alarm in suspect status"},{"line_number":391,"context_line":"- Trigger diagnose action on suspect or inconsistent status"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"However, when we bring in proactive RCA, the entity numbers in the graph may grow a lot. We shall need to create"},{"line_number":394,"context_line":"deduced alarm for each monitored alarm and set suspect state in some condition. The relationships (edges) will also"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_fec76a11","line":391,"range":{"start_line":391,"start_character":2,"end_line":391,"end_character":59},"updated":"2017-11-15 10:13:25.000000000","message":"Please add some details about the diagnose action","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"e61630d2d9b7857b645820b5287b2502604a80ef","unresolved":false,"context_lines":[{"line_number":388,"context_line":"The main change would be allowing raise alarms in suspect status which can be used to trigger a diagnostic action."},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"- Allow setting alarm in suspect status"},{"line_number":391,"context_line":"- Trigger diagnose action on suspect or inconsistent status"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"However, when we bring in proactive RCA, the entity numbers in the graph may grow a lot. We shall need to create"},{"line_number":394,"context_line":"deduced alarm for each monitored alarm and set suspect state in some condition. The relationships (edges) will also"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f485f77_9af747d4","line":391,"range":{"start_line":391,"start_character":2,"end_line":391,"end_character":59},"in_reply_to":"1f485f77_fec76a11","updated":"2017-11-16 03:41:36.000000000","message":"It is supposed to be in a separate blueprint... Do you think it is clear enough after the modification above?","commit_id":"06b2bb07c19343774a98506bc89714c56d12b6be"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"25e78341635fe77a73cf7533c37af4f0851b1f55","unresolved":false,"context_lines":[{"line_number":224,"context_line":"t2: diagnose action executed, upstream fault confirmed"},{"line_number":225,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"#. diagnose action should send events via message bus to Vitrage like a monitor"},{"line_number":228,"context_line":"#. as a side-effect, Vitrage will deduce that fault C is active in parallel of monitored fault C"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"- green: recovery in confirmed status"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1f485f77_824a3da9","line":227,"range":{"start_line":227,"start_character":3,"end_line":227,"end_character":79},"updated":"2017-11-16 08:36:12.000000000","message":"Ok. It just means that there should be a new datasource for the diagnose tool (unless of course you will execute a zabbix test for this purpose).","commit_id":"9ed354888fd1d964715a9ba9697926addf1aea02"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"c6464ec2e4d9c9715f6fd495d16fb9325246ed19","unresolved":false,"context_lines":[{"line_number":224,"context_line":"t2: diagnose action executed, upstream fault confirmed"},{"line_number":225,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"#. diagnose action should send events via message bus to Vitrage like a monitor"},{"line_number":228,"context_line":"#. as a side-effect, Vitrage will deduce that fault C is active in parallel of monitored fault C"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"- green: recovery in confirmed status"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1f485f77_58eb1212","line":227,"range":{"start_line":227,"start_character":3,"end_line":227,"end_character":79},"in_reply_to":"1f485f77_824a3da9","updated":"2017-11-16 09:30:25.000000000","message":"Yes","commit_id":"9ed354888fd1d964715a9ba9697926addf1aea02"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"25e78341635fe77a73cf7533c37af4f0851b1f55","unresolved":false,"context_lines":[{"line_number":225,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"#. diagnose action should send events via message bus to Vitrage like a monitor"},{"line_number":228,"context_line":"#. as a side-effect, Vitrage will deduce that fault C is active in parallel of monitored fault C"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"- green: recovery in confirmed status"},{"line_number":231,"context_line":"- dotted: infers the internal link between status update and diagnose action, not a real edge in graph"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1f485f77_02a2cd4b","line":228,"range":{"start_line":228,"start_character":3,"end_line":228,"end_character":96},"updated":"2017-11-16 08:36:12.000000000","message":"But what about the fault that the monitor determines that is not active? will it remain in the graph as a suspect, or will it be cleared somehow?","commit_id":"9ed354888fd1d964715a9ba9697926addf1aea02"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"c6464ec2e4d9c9715f6fd495d16fb9325246ed19","unresolved":false,"context_lines":[{"line_number":225,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"#. diagnose action should send events via message bus to Vitrage like a monitor"},{"line_number":228,"context_line":"#. as a side-effect, Vitrage will deduce that fault C is active in parallel of monitored fault C"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"- green: recovery in confirmed status"},{"line_number":231,"context_line":"- dotted: infers the internal link between status update and diagnose action, not a real edge in graph"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1f485f77_b8c44692","line":228,"range":{"start_line":228,"start_character":3,"end_line":228,"end_character":96},"in_reply_to":"1f485f77_02a2cd4b","updated":"2017-11-16 09:30:25.000000000","message":"The status should be consistent finally. If it is contradict in the end (after diagnose action), then vitrage should warn user about a possible invalid fault model.\n\nThink further, it should be a machine learning process to create the fault model, which is amended from observed facts.","commit_id":"9ed354888fd1d964715a9ba9697926addf1aea02"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"c5c4c8f1819c50909a9c53f831d6f96ebf9574aa","unresolved":false,"context_lines":[{"line_number":225,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"#. diagnose action should send events via message bus to Vitrage like a monitor"},{"line_number":228,"context_line":"#. as a side-effect, Vitrage will deduce that fault C is active in parallel of monitored fault C"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"- green: recovery in confirmed status"},{"line_number":231,"context_line":"- dotted: infers the internal link between status update and diagnose action, not a real edge in graph"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1f485f77_5c74efce","line":228,"range":{"start_line":228,"start_character":3,"end_line":228,"end_character":96},"in_reply_to":"1f485f77_7d68fb1b","updated":"2017-11-18 03:33:13.000000000","message":"Further clarification updated.\n\nP.S. I tend to keep this proposal focused on modeling. Which relationship/entity should be represented in graph as edge/node and when to remove them is about implementation. I do have some general ideas and we may discuss it further in sub blueprints.","commit_id":"9ed354888fd1d964715a9ba9697926addf1aea02"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"34832ae5d1336182e0abf7b5d8f9c4104dbbb792","unresolved":false,"context_lines":[{"line_number":225,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"#. diagnose action should send events via message bus to Vitrage like a monitor"},{"line_number":228,"context_line":"#. as a side-effect, Vitrage will deduce that fault C is active in parallel of monitored fault C"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"- green: recovery in confirmed status"},{"line_number":231,"context_line":"- dotted: infers the internal link between status update and diagnose action, not a real edge in graph"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1f485f77_7d68fb1b","line":228,"range":{"start_line":228,"start_character":3,"end_line":228,"end_character":96},"in_reply_to":"1f485f77_b8c44692","updated":"2017-11-16 11:37:00.000000000","message":"Why should it be consistent finally? you have c_m and you raise a_v and b_v. Most chances are that one of them is incorrect. After diagnostics, you have in addition also a_m (but not b_m). Do you want to keep b_v? and if not, who can remove it and when?","commit_id":"9ed354888fd1d964715a9ba9697926addf1aea02"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c8a29e53ef3ffdddb16c082e4736f1539357f5bf","unresolved":false,"context_lines":[{"line_number":161,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"#. Vitrage deduces that fault A and fault B are active in suspect state"},{"line_number":164,"context_line":"#. aggregated fault A and fault B enter transient state"},{"line_number":165,"context_line":"#. execute diagnose action to confirm suspect state"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":".. graphviz::"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1f485f77_9b3ee4be","line":164,"range":{"start_line":164,"start_character":3,"end_line":164,"end_character":13},"updated":"2017-11-19 07:36:53.000000000","message":"Why aggregated?","commit_id":"1d122944a39fafac65c0baf4dc001b8ba742fdfe"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c8a29e53ef3ffdddb16c082e4736f1539357f5bf","unresolved":false,"context_lines":[{"line_number":161,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"#. Vitrage deduces that fault A and fault B are active in suspect state"},{"line_number":164,"context_line":"#. aggregated fault A and fault B enter transient state"},{"line_number":165,"context_line":"#. execute diagnose action to confirm suspect state"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":".. graphviz::"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1f485f77_5b34ecdd","line":164,"range":{"start_line":164,"start_character":40,"end_line":164,"end_character":49},"updated":"2017-11-19 07:36:53.000000000","message":"suspect?","commit_id":"1d122944a39fafac65c0baf4dc001b8ba742fdfe"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"9b28f86fb0eace6a42ba76bd69bc0a68c1ab440f","unresolved":false,"context_lines":[{"line_number":161,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"#. Vitrage deduces that fault A and fault B are active in suspect state"},{"line_number":164,"context_line":"#. aggregated fault A and fault B enter transient state"},{"line_number":165,"context_line":"#. execute diagnose action to confirm suspect state"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":".. graphviz::"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff82abbf_0266eaee","line":164,"range":{"start_line":164,"start_character":40,"end_line":164,"end_character":49},"in_reply_to":"1f485f77_5b34ecdd","updated":"2017-11-20 02:15:27.000000000","message":"For the aggregated fault, e.g. A\u003daggregate(a_v, a_m), the suspect state is transient. It will be confirmed once we get new updates from diagnose action. See details in changes required.\n\nFor a_v, it is always suspect according to the fault model (A or B) \u003d\u003e C","commit_id":"1d122944a39fafac65c0baf4dc001b8ba742fdfe"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"9b28f86fb0eace6a42ba76bd69bc0a68c1ab440f","unresolved":false,"context_lines":[{"line_number":161,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"#. Vitrage deduces that fault A and fault B are active in suspect state"},{"line_number":164,"context_line":"#. aggregated fault A and fault B enter transient state"},{"line_number":165,"context_line":"#. execute diagnose action to confirm suspect state"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":".. graphviz::"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff82abbf_622d7645","line":164,"range":{"start_line":164,"start_character":3,"end_line":164,"end_character":13},"in_reply_to":"1f485f77_9b3ee4be","updated":"2017-11-20 02:15:27.000000000","message":"For user view if it is requested during diagnose action.","commit_id":"1d122944a39fafac65c0baf4dc001b8ba742fdfe"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"543fac6484b4d3f129a181c7e817bb44296233e6","unresolved":false,"context_lines":[{"line_number":161,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"#. Vitrage deduces that fault A and fault B are active in suspect state"},{"line_number":164,"context_line":"#. aggregated fault A and fault B enter transient state"},{"line_number":165,"context_line":"#. execute diagnose action to confirm suspect state"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":".. graphviz::"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff82abbf_57a34e50","line":164,"range":{"start_line":164,"start_character":40,"end_line":164,"end_character":49},"in_reply_to":"ff82abbf_0266eaee","updated":"2017-11-20 09:52:58.000000000","message":"But isn\u0027t it enough to know that it is a suspect in order to change the color (if wanted)? why add also transient? or do you say that transient is for aggregated alarms and suspect is for regular alarms? \n\nAnd why do we see a_m and b_m before any monitor raised them? what is the benefit of having such alarms as \"placeholders\"\u003e what if they are never raised? I would expect to have at this stage only the suspect alarms, and the end user can see them in pink or some other suspect indication.","commit_id":"1d122944a39fafac65c0baf4dc001b8ba742fdfe"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"66111f2cc42d6c3546d35decdc4c5b0e020f97da","unresolved":false,"context_lines":[{"line_number":161,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"#. Vitrage deduces that fault A and fault B are active in suspect state"},{"line_number":164,"context_line":"#. aggregated fault A and fault B enter transient state"},{"line_number":165,"context_line":"#. execute diagnose action to confirm suspect state"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":".. graphviz::"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff82abbf_26bc4504","line":164,"range":{"start_line":164,"start_character":40,"end_line":164,"end_character":49},"in_reply_to":"ff82abbf_57a34e50","updated":"2017-11-21 02:28:10.000000000","message":"\u003e transient for aggregated alarms and suspect for regular alarms\n\nCorrect\n\n \u003e placeholder\n\nYes, it\u0027s ok to not create \"undefined\" alarms.","commit_id":"1d122944a39fafac65c0baf4dc001b8ba742fdfe"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c8a29e53ef3ffdddb16c082e4736f1539357f5bf","unresolved":false,"context_lines":[{"line_number":197,"context_line":"t2: diagnose action executed, upstream fault confirmed"},{"line_number":198,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"#. monitored states updated by diagnose action"},{"line_number":201,"context_line":"#. as a side-effect, Vitrage will deduce that fault C is active in parallel of monitored fault C"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":".. graphviz::"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1f485f77_db557cfb","line":200,"range":{"start_line":200,"start_character":3,"end_line":200,"end_character":46},"updated":"2017-11-19 07:36:53.000000000","message":"Actually, if I understand correctly, a_m and b_m should not appear in the graph at all prior to this state. Only a_v and b_v should appear.","commit_id":"1d122944a39fafac65c0baf4dc001b8ba742fdfe"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"9b28f86fb0eace6a42ba76bd69bc0a68c1ab440f","unresolved":false,"context_lines":[{"line_number":197,"context_line":"t2: diagnose action executed, upstream fault confirmed"},{"line_number":198,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"#. monitored states updated by diagnose action"},{"line_number":201,"context_line":"#. as a side-effect, Vitrage will deduce that fault C is active in parallel of monitored fault C"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":".. graphviz::"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff82abbf_e2f746d4","line":200,"range":{"start_line":200,"start_character":3,"end_line":200,"end_character":46},"in_reply_to":"1f485f77_db557cfb","updated":"2017-11-20 02:15:27.000000000","message":"Again, this is the modeling, whether we shall create the vertex in graph for \"undefined\" or \"inactive\" is about how to implement it.\n\nI am still considering to build the whole graph in low level and show only the active ones to user in front end. This will be detailed in blueprint aggregated alarms.","commit_id":"1d122944a39fafac65c0baf4dc001b8ba742fdfe"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c8a29e53ef3ffdddb16c082e4736f1539357f5bf","unresolved":false,"context_lines":[{"line_number":198,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"#. monitored states updated by diagnose action"},{"line_number":201,"context_line":"#. as a side-effect, Vitrage will deduce that fault C is active in parallel of monitored fault C"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":".. graphviz::"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"1f485f77_1b79d492","line":201,"range":{"start_line":201,"start_character":0,"end_line":201,"end_character":2},"updated":"2017-11-19 07:36:53.000000000","message":"Another step: the diagnose action will set inactive b_m. But what about the state of the aggregated b? Why it is green? until now, we always used the worst state as the aggregated state. Why do you think that the b_m should be \"stronger\"? what if it just wasn\u0027t updated yet, and will soon become red?","commit_id":"1d122944a39fafac65c0baf4dc001b8ba742fdfe"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"9b28f86fb0eace6a42ba76bd69bc0a68c1ab440f","unresolved":false,"context_lines":[{"line_number":198,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"#. monitored states updated by diagnose action"},{"line_number":201,"context_line":"#. as a side-effect, Vitrage will deduce that fault C is active in parallel of monitored fault C"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":".. graphviz::"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff82abbf_823bda9a","line":201,"range":{"start_line":201,"start_character":0,"end_line":201,"end_character":2},"in_reply_to":"1f485f77_1b79d492","updated":"2017-11-20 02:15:27.000000000","message":"suspect state means it could be active or inactive. So if we get a latest update from monitor confirms it is inactive, it is reasonable to trust the monitor. \n\nIf we define the rule explicitly, it is something like: b_m@t2 \u003e a_v.suspect@t1 \u003e b_m@t0. We need to consider the update time for priority, considering there is possible delay or message lost for monitored status.","commit_id":"1d122944a39fafac65c0baf4dc001b8ba742fdfe"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"543fac6484b4d3f129a181c7e817bb44296233e6","unresolved":false,"context_lines":[{"line_number":198,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"#. monitored states updated by diagnose action"},{"line_number":201,"context_line":"#. as a side-effect, Vitrage will deduce that fault C is active in parallel of monitored fault C"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":".. graphviz::"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff82abbf_d703de0e","line":201,"range":{"start_line":201,"start_character":0,"end_line":201,"end_character":2},"in_reply_to":"ff82abbf_823bda9a","updated":"2017-11-20 09:52:58.000000000","message":"Ok. Makes sense. I\u0027m just worried about having too many inactive alarms in the graph (at the moment most of the alarms are not passed to the graph at all, because they are inactive).","commit_id":"1d122944a39fafac65c0baf4dc001b8ba742fdfe"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"66111f2cc42d6c3546d35decdc4c5b0e020f97da","unresolved":false,"context_lines":[{"line_number":198,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"#. monitored states updated by diagnose action"},{"line_number":201,"context_line":"#. as a side-effect, Vitrage will deduce that fault C is active in parallel of monitored fault C"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":".. graphviz::"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff82abbf_e6cbbd1b","line":201,"range":{"start_line":201,"start_character":0,"end_line":201,"end_character":2},"in_reply_to":"ff82abbf_d703de0e","updated":"2017-11-21 02:28:10.000000000","message":"Agree. I think we can safely remove them once it is not **dominating** the aggregated state. The rules shall be detailed in sub blueprint.","commit_id":"1d122944a39fafac65c0baf4dc001b8ba742fdfe"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c7b8fb26662a2dfd3bbebf9330928cb0f4244caf","unresolved":false,"context_lines":[{"line_number":198,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"#. monitored states updated by diagnose action"},{"line_number":201,"context_line":"#. as a side-effect, Vitrage will deduce that fault C is active in parallel of monitored fault C"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":".. graphviz::"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff82abbf_4dac018c","line":201,"range":{"start_line":201,"start_character":0,"end_line":201,"end_character":2},"in_reply_to":"ff82abbf_e6cbbd1b","updated":"2017-11-21 08:58:46.000000000","message":"Ok.","commit_id":"1d122944a39fafac65c0baf4dc001b8ba742fdfe"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c8a29e53ef3ffdddb16c082e4736f1539357f5bf","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"#. from the fault model, we can deduce fault A and fault B are inactive"},{"line_number":243,"context_line":"#. inconsistency detected between fault A deduced (inactive) and monitored (active)"},{"line_number":244,"context_line":"#. fault A enters transient state"},{"line_number":245,"context_line":"#. execute diagnose action to resolve status inconsistency"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":".. graphviz::"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1f485f77_bb71a0aa","line":244,"range":{"start_line":244,"start_character":18,"end_line":244,"end_character":27},"updated":"2017-11-19 07:36:53.000000000","message":"What is that transient state?","commit_id":"1d122944a39fafac65c0baf4dc001b8ba742fdfe"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"9b28f86fb0eace6a42ba76bd69bc0a68c1ab440f","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"#. from the fault model, we can deduce fault A and fault B are inactive"},{"line_number":243,"context_line":"#. inconsistency detected between fault A deduced (inactive) and monitored (active)"},{"line_number":244,"context_line":"#. fault A enters transient state"},{"line_number":245,"context_line":"#. execute diagnose action to resolve status inconsistency"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":".. graphviz::"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff82abbf_e2966695","line":244,"range":{"start_line":244,"start_character":18,"end_line":244,"end_character":27},"in_reply_to":"1f485f77_bb71a0aa","updated":"2017-11-20 02:15:27.000000000","message":"Explained in L130, to indicate this is not a stable state, e.g. diagnose action is in progress.","commit_id":"1d122944a39fafac65c0baf4dc001b8ba742fdfe"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"66111f2cc42d6c3546d35decdc4c5b0e020f97da","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"#. from the fault model, we can deduce fault A and fault B are inactive"},{"line_number":243,"context_line":"#. inconsistency detected between fault A deduced (inactive) and monitored (active)"},{"line_number":244,"context_line":"#. fault A enters transient state"},{"line_number":245,"context_line":"#. execute diagnose action to resolve status inconsistency"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":".. graphviz::"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff82abbf_466ce935","line":244,"range":{"start_line":244,"start_character":18,"end_line":244,"end_character":27},"in_reply_to":"ff82abbf_a9091ede","updated":"2017-11-21 02:28:10.000000000","message":"OK. I will remove it from this proposal. It is relatively independent feature. For now, we may simply consider transient state is the same as suspect since we are not sure about the actual state.","commit_id":"1d122944a39fafac65c0baf4dc001b8ba742fdfe"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"543fac6484b4d3f129a181c7e817bb44296233e6","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"#. from the fault model, we can deduce fault A and fault B are inactive"},{"line_number":243,"context_line":"#. inconsistency detected between fault A deduced (inactive) and monitored (active)"},{"line_number":244,"context_line":"#. fault A enters transient state"},{"line_number":245,"context_line":"#. execute diagnose action to resolve status inconsistency"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":".. graphviz::"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff82abbf_a9091ede","line":244,"range":{"start_line":244,"start_character":18,"end_line":244,"end_character":27},"in_reply_to":"ff82abbf_e2966695","updated":"2017-11-20 09:52:58.000000000","message":"This transient state sounds like something that could easily break. You need to define exactly when it starts, when it ends... are you sure the benefit to the user is worth the risk of the code complexity?","commit_id":"1d122944a39fafac65c0baf4dc001b8ba742fdfe"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c8a29e53ef3ffdddb16c082e4736f1539357f5bf","unresolved":false,"context_lines":[{"line_number":319,"context_line":"The main change would be allowing raise alarms in suspect status which can be used to trigger a diagnostic action."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"- Add support for diagnose action, like:"},{"line_number":322,"context_line":"    - an immediate pull from data source"},{"line_number":323,"context_line":"    - force a push from data source"},{"line_number":324,"context_line":"    - launch external tools to get state and post events to Vitrage API"},{"line_number":325,"context_line":"- Additional states for alarm"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1f485f77_7b67a8ea","line":322,"range":{"start_line":322,"start_character":4,"end_line":322,"end_character":5},"updated":"2017-11-19 07:36:53.000000000","message":"I think there are too many spaces here. It doesn\u0027t look nice in the output html.","commit_id":"1d122944a39fafac65c0baf4dc001b8ba742fdfe"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"9b28f86fb0eace6a42ba76bd69bc0a68c1ab440f","unresolved":false,"context_lines":[{"line_number":319,"context_line":"The main change would be allowing raise alarms in suspect status which can be used to trigger a diagnostic action."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"- Add support for diagnose action, like:"},{"line_number":322,"context_line":"    - an immediate pull from data source"},{"line_number":323,"context_line":"    - force a push from data source"},{"line_number":324,"context_line":"    - launch external tools to get state and post events to Vitrage API"},{"line_number":325,"context_line":"- Additional states for alarm"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff82abbf_62757698","line":322,"range":{"start_line":322,"start_character":4,"end_line":322,"end_character":5},"in_reply_to":"1f485f77_7b67a8ea","updated":"2017-11-20 02:15:27.000000000","message":"Done","commit_id":"1d122944a39fafac65c0baf4dc001b8ba742fdfe"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c7b8fb26662a2dfd3bbebf9330928cb0f4244caf","unresolved":false,"context_lines":[{"line_number":126,"context_line":"- colors:"},{"line_number":127,"context_line":"  - lightgrey: fault in undefined state"},{"line_number":128,"context_line":"  - red: fault in confirmed state"},{"line_number":129,"context_line":"  - yellow: fault in suspect state"},{"line_number":130,"context_line":"- labels:"},{"line_number":131,"context_line":"  - ``Fault A``: aggregated"},{"line_number":132,"context_line":"  - ``a_v``: deduced by Vitrage"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ff82abbf_ed9dd559","line":129,"range":{"start_line":129,"start_character":4,"end_line":129,"end_character":10},"updated":"2017-11-21 08:58:46.000000000","message":"Currently yellow is used for alarms in warning state. Maybe purple ;-)","commit_id":"b26c9ef1fd189468e93837a950ba61d7a293c87e"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"3bbebb8d7e1ecc4eba33ecd2c73234a58a7afad5","unresolved":false,"context_lines":[{"line_number":126,"context_line":"- colors:"},{"line_number":127,"context_line":"  - lightgrey: fault in undefined state"},{"line_number":128,"context_line":"  - red: fault in confirmed state"},{"line_number":129,"context_line":"  - yellow: fault in suspect state"},{"line_number":130,"context_line":"- labels:"},{"line_number":131,"context_line":"  - ``Fault A``: aggregated"},{"line_number":132,"context_line":"  - ``a_v``: deduced by Vitrage"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ff82abbf_38a69dc3","line":129,"range":{"start_line":129,"start_character":4,"end_line":129,"end_character":10},"in_reply_to":"ff82abbf_ed9dd559","updated":"2017-11-21 09:25:40.000000000","message":"Considering suspect is an overlay attribute on alarm state, it could be better to represent it using border style.","commit_id":"b26c9ef1fd189468e93837a950ba61d7a293c87e"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c7b8fb26662a2dfd3bbebf9330928cb0f4244caf","unresolved":false,"context_lines":[{"line_number":319,"context_line":"  - force a push from data source"},{"line_number":320,"context_line":"  - launch external tools to get state and post events to Vitrage API"},{"line_number":321,"context_line":"- Suspect states for alarm"},{"line_number":322,"context_line":"  - for deduced alarm, it is suspect if the source is from downstream"},{"line_number":323,"context_line":"  - for aggregated alarm, it is suspect if inconsistency is detected among underlying alarms (deduced and monitored)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"Specially, it is not suspect if **newer** monitored state is different from **old** suspect deduced state. Because a"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ff82abbf_adf6ed8e","line":322,"range":{"start_line":322,"start_character":37,"end_line":322,"end_character":69},"updated":"2017-11-21 08:58:46.000000000","message":"\"if the source is downstream\" - this is *your* use case. But theoretically the suspect can be defined by the end user also when it is not downstream (I guess it depends how you define it in the template). Anyway, you can leave it as is.","commit_id":"b26c9ef1fd189468e93837a950ba61d7a293c87e"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"3bbebb8d7e1ecc4eba33ecd2c73234a58a7afad5","unresolved":false,"context_lines":[{"line_number":319,"context_line":"  - force a push from data source"},{"line_number":320,"context_line":"  - launch external tools to get state and post events to Vitrage API"},{"line_number":321,"context_line":"- Suspect states for alarm"},{"line_number":322,"context_line":"  - for deduced alarm, it is suspect if the source is from downstream"},{"line_number":323,"context_line":"  - for aggregated alarm, it is suspect if inconsistency is detected among underlying alarms (deduced and monitored)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"Specially, it is not suspect if **newer** monitored state is different from **old** suspect deduced state. Because a"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ff82abbf_b87aad21","line":322,"range":{"start_line":322,"start_character":37,"end_line":322,"end_character":69},"in_reply_to":"ff82abbf_adf6ed8e","updated":"2017-11-21 09:25:40.000000000","message":"Agree.","commit_id":"b26c9ef1fd189468e93837a950ba61d7a293c87e"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"69aaeff22447f65ac049872d862ac7ed4be598f8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Fault model"},{"line_number":34,"context_line":"-----------"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"The fault model is illustrated in following graph."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":".. graphviz::"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"ff82abbf_6e7aa3f1","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":50},"updated":"2017-11-27 08:11:32.000000000","message":"We think that this graph is a bit confusing. We would prefer to remove the \u0027aggregated\u0027 edges (which are not real edges, right?), and maybe also to rename \u0027fault model\u0027 to \u0027template\u0027.","commit_id":"4c5d20c669630dc6ca833ba8dd1130f5bb107b67"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"69aaeff22447f65ac049872d862ac7ed4be598f8","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"            subgraph cluster_2 {"},{"line_number":78,"context_line":"                label\u003d\"Fault A\";"},{"line_number":79,"context_line":"                a_m -\u003e a_v [label\u003d\"eq\"];"},{"line_number":80,"context_line":"            }"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            subgraph cluster_3 {"}],"source_content_type":"text/x-rst","patch_set":15,"id":"ff82abbf_2e801bbf","line":79,"range":{"start_line":79,"start_character":35,"end_line":79,"end_character":37},"updated":"2017-11-27 08:11:32.000000000","message":"This edge should be bidirectional","commit_id":"4c5d20c669630dc6ca833ba8dd1130f5bb107b67"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"46c740bd4bbd550bbcad7fccb0c09b07c04d90bc","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"            subgraph cluster_2 {"},{"line_number":78,"context_line":"                label\u003d\"Fault A\";"},{"line_number":79,"context_line":"                a_m -\u003e a_v [label\u003d\"eq\"];"},{"line_number":80,"context_line":"            }"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            subgraph cluster_3 {"}],"source_content_type":"text/x-rst","patch_set":15,"id":"ff82abbf_518502ce","line":79,"range":{"start_line":79,"start_character":35,"end_line":79,"end_character":37},"in_reply_to":"ff82abbf_2e801bbf","updated":"2017-11-27 09:02:50.000000000","message":"Done","commit_id":"4c5d20c669630dc6ca833ba8dd1130f5bb107b67"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"69aaeff22447f65ac049872d862ac7ed4be598f8","unresolved":false,"context_lines":[{"line_number":121,"context_line":"- cluster: aggregate fault"},{"line_number":122,"context_line":"- nodes: raw fault"},{"line_number":123,"context_line":"- edges:"},{"line_number":124,"context_line":"  - dashed: the target state is deduced from source state by Vitrage"},{"line_number":125,"context_line":"  - dotted: the target state is updated by diagnose action triggered by source state"},{"line_number":126,"context_line":"- border:"},{"line_number":127,"context_line":"  - dashed: suspect"},{"line_number":128,"context_line":"- colors:"}],"source_content_type":"text/x-rst","patch_set":15,"id":"ff82abbf_8e68471d","line":125,"range":{"start_line":124,"start_character":0,"end_line":125,"end_character":84},"updated":"2017-11-27 08:11:32.000000000","message":"All of these lines appear in the html as a single line. Maybe if you add blank lines in the middle it will be displayed correctly.","commit_id":"4c5d20c669630dc6ca833ba8dd1130f5bb107b67"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"46c740bd4bbd550bbcad7fccb0c09b07c04d90bc","unresolved":false,"context_lines":[{"line_number":121,"context_line":"- cluster: aggregate fault"},{"line_number":122,"context_line":"- nodes: raw fault"},{"line_number":123,"context_line":"- edges:"},{"line_number":124,"context_line":"  - dashed: the target state is deduced from source state by Vitrage"},{"line_number":125,"context_line":"  - dotted: the target state is updated by diagnose action triggered by source state"},{"line_number":126,"context_line":"- border:"},{"line_number":127,"context_line":"  - dashed: suspect"},{"line_number":128,"context_line":"- colors:"}],"source_content_type":"text/x-rst","patch_set":15,"id":"ff82abbf_11ca1a4d","line":125,"range":{"start_line":124,"start_character":0,"end_line":125,"end_character":84},"in_reply_to":"ff82abbf_8e68471d","updated":"2017-11-27 09:02:50.000000000","message":"Done","commit_id":"4c5d20c669630dc6ca833ba8dd1130f5bb107b67"}]}
