)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"2d07f52732c5e1b07c0335b8e90d1c8db6152b8f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Niv Oppenhaim \u003cniv.oppenhaim@nokia.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-01-03 14:38:41 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Webhook doc fix and move to implemented"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie6f0bfc3131ed0024aa75f96a1e8f8739e7e0e71"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f91af0f_d25e4011","line":7,"range":{"start_line":7,"start_character":28,"end_line":7,"end_character":39},"updated":"2018-01-04 09:25:57.000000000","message":"queens/implemented\n(because you moved it from pike)","commit_id":"4f12e55a893b4bde8eb2382e8440fbeed8309000"}],"specs/queens/implemented/webhooks.rst":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"2d07f52732c5e1b07c0335b8e90d1c8db6152b8f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"determine that an alarm should be created, deleted or otherwise updated."},{"line_number":16,"context_line":"Other components are notified of such changes by the Vitrage Notifier service."},{"line_number":17,"context_line":"Among others, Vitrage Notifier is responsible for sending http post"},{"line_number":18,"context_line":"notifications on Vitrage deduced alarms."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This blueprint describes the implementation of Vitrage Notifier for"},{"line_number":21,"context_line":"webhooks on Vitrage alarms."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f91af0f_327e8c6b","line":18,"range":{"start_line":18,"start_character":14,"end_line":18,"end_character":39},"updated":"2018-01-04 09:25:57.000000000","message":"Only on vitrage deduced alarms? what about other alarms?\nAccording to the problem description, there are notifications also on states and RCA","commit_id":"4f12e55a893b4bde8eb2382e8440fbeed8309000"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"2d07f52732c5e1b07c0335b8e90d1c8db6152b8f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"sent to that recipient."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Proposed change"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Needed definitions in Vitrage config file::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f91af0f_f2f90480","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":15},"updated":"2018-01-04 09:25:57.000000000","message":"What about the configuration that was suggested in httppost-notifications.rst? is it irrelevant?","commit_id":"4f12e55a893b4bde8eb2382e8440fbeed8309000"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"2d07f52732c5e1b07c0335b8e90d1c8db6152b8f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Vitrage listener will get the alarm events from the message bus and the webhook"},{"line_number":43,"context_line":"notifier will send http post notifications on raised deduced alarms and deleted deduced alarms."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"The filtered notifications will be sent to destinations in the database, which"},{"line_number":46,"context_line":" can be updated via API requests."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"The notifications will be sent only on alarms which meet the regex filter specified in the"},{"line_number":49,"context_line":"webhook specification. This section will be specified in a different spec."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f91af0f_12c10881","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":33},"updated":"2018-01-04 09:25:57.000000000","message":"This is not clear. How about:\n\nThe filtered notifications will be sent to the destinations that are written in the database, as configured via API requests.","commit_id":"4f12e55a893b4bde8eb2382e8440fbeed8309000"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"2d07f52732c5e1b07c0335b8e90d1c8db6152b8f","unresolved":false,"context_lines":[{"line_number":46,"context_line":" can be updated via API requests."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"The notifications will be sent only on alarms which meet the regex filter specified in the"},{"line_number":49,"context_line":"webhook specification. This section will be specified in a different spec."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"The format of sent notifications will be hard coded."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f91af0f_923af895","line":49,"range":{"start_line":49,"start_character":23,"end_line":49,"end_character":74},"updated":"2018-01-04 09:25:57.000000000","message":"Delete this sentence? you united the two specs.","commit_id":"4f12e55a893b4bde8eb2382e8440fbeed8309000"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"2d07f52732c5e1b07c0335b8e90d1c8db6152b8f","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"The format of sent notifications will be hard coded."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"The webhook notifier is pluggable, you can implement your own webhook plugin"},{"line_number":54,"context_line":" and use it (it must inherit from the base class), when there is a default"},{"line_number":55,"context_line":" implementation."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f91af0f_b254dccb","line":55,"range":{"start_line":53,"start_character":0,"end_line":55,"end_character":16},"updated":"2018-01-04 09:25:57.000000000","message":"Really? is it something that we want the user to do?\nIf so, then I would write:\n\nAs Vitrage notifiers are pluggable, you can write your own notifier and use it. Specifically in this case, you can inherit the webhook base class and implement your own webhook notifier.","commit_id":"4f12e55a893b4bde8eb2382e8440fbeed8309000"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"2d07f52732c5e1b07c0335b8e90d1c8db6152b8f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"REST API impact"},{"line_number":81,"context_line":"---------------"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"None"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Versioning impact"},{"line_number":86,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f91af0f_32dd2c42","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":4},"updated":"2018-01-04 09:25:57.000000000","message":"You added new REST API :-) please write it here.","commit_id":"4f12e55a893b4bde8eb2382e8440fbeed8309000"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"2d07f52732c5e1b07c0335b8e90d1c8db6152b8f","unresolved":false,"context_lines":[{"line_number":105,"context_line":"Horizon impact"},{"line_number":106,"context_line":"--------------"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"None"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Implementation"},{"line_number":111,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f91af0f_92bf58cf","line":108,"range":{"start_line":108,"start_character":0,"end_line":108,"end_character":4},"updated":"2018-01-04 09:25:57.000000000","message":"We would like to support adding webhooks in Horizon, but that\u0027s a future task with lower priority.","commit_id":"4f12e55a893b4bde8eb2382e8440fbeed8309000"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"2d07f52732c5e1b07c0335b8e90d1c8db6152b8f","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Primary assignee:"},{"line_number":117,"context_line":"  nivo"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Work Items"},{"line_number":120,"context_line":"----------"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Dependencies"},{"line_number":123,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f91af0f_d272c049","line":120,"range":{"start_line":119,"start_character":0,"end_line":120,"end_character":10},"updated":"2018-01-04 09:25:57.000000000","message":"Please specify the work items:\n\n- add DB table\n- add API\n- implement the notifier\n- update the documentation\n- tests","commit_id":"4f12e55a893b4bde8eb2382e8440fbeed8309000"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"2d07f52732c5e1b07c0335b8e90d1c8db6152b8f","unresolved":false,"context_lines":[{"line_number":127,"context_line":"Testing"},{"line_number":128,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"This blueprint requires tempest tests."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Documentation Impact"},{"line_number":133,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f91af0f_529c705c","line":130,"range":{"start_line":130,"start_character":24,"end_line":130,"end_character":37},"updated":"2018-01-04 09:25:57.000000000","message":"unit tests and tempest tests","commit_id":"4f12e55a893b4bde8eb2382e8440fbeed8309000"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"2d07f52732c5e1b07c0335b8e90d1c8db6152b8f","unresolved":false,"context_lines":[{"line_number":138,"context_line":"References"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Example on http post notifications in AODH"},{"line_number":142,"context_line":"`http post request \u003chttps://github.com/openstack/aodh/blob/master/aodh/notifier/rest.py#L60-L109\u003e`_"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f91af0f_f2cb4450","line":142,"range":{"start_line":141,"start_character":0,"end_line":142,"end_character":99},"updated":"2018-01-04 09:25:57.000000000","message":"I\u0027m not sure if this example is relevant","commit_id":"4f12e55a893b4bde8eb2382e8440fbeed8309000"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"be9efade643662623bfd85641054bab331f8bbc0","unresolved":false,"context_lines":[{"line_number":79,"context_line":"REST API impact"},{"line_number":80,"context_line":"---------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"-An API which supports adding, removing and listing webhooks"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Versioning impact"},{"line_number":85,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f91af0f_86ddd515","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":60},"updated":"2018-01-04 16:59:37.000000000","message":"No need for a - in the beginning","commit_id":"ba941d2c2c4f6f6615b504e4dce693a1b4a34c4b"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"be9efade643662623bfd85641054bab331f8bbc0","unresolved":false,"context_lines":[{"line_number":104,"context_line":"Horizon impact"},{"line_number":105,"context_line":"--------------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"-Future support for webhooks in Horizon"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Implementation"},{"line_number":110,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f91af0f_a692594a","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":7},"updated":"2018-01-04 16:59:37.000000000","message":"No need for a - in the beginning","commit_id":"ba941d2c2c4f6f6615b504e4dce693a1b4a34c4b"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"be9efade643662623bfd85641054bab331f8bbc0","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Work Items"},{"line_number":119,"context_line":"----------"},{"line_number":120,"context_line":"-Add DB table"},{"line_number":121,"context_line":"-Add API"},{"line_number":122,"context_line":"-Implement notifier"},{"line_number":123,"context_line":"-Update docs"},{"line_number":124,"context_line":"-Tests"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Dependencies"},{"line_number":127,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f91af0f_e6c0612d","line":124,"range":{"start_line":120,"start_character":0,"end_line":124,"end_character":6},"updated":"2018-01-04 16:59:37.000000000","message":"Please add a space after each - so it will be displayed as a bullet list","commit_id":"ba941d2c2c4f6f6615b504e4dce693a1b4a34c4b"}]}