)]}'
{"specs/queens/approved/proactive-rca.rst":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"e5bd699740722e653d651e682e27d7c7cb29b8be","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\r"},{"line_number":16,"context_line":"\r"},{"line_number":17,"context_line":"When the current and new status of alarm are respectively monitored and\r"},{"line_number":18,"context_line":"deduced, we prescribed rules for alarm merging, even if the state of these\r"},{"line_number":19,"context_line":"two status are conflict. We can use diagnose action to further confirm\r"},{"line_number":20,"context_line":"alarm in environment when the conflict happens.\r"},{"line_number":21,"context_line":"\r"},{"line_number":22,"context_line":"\r"},{"line_number":23,"context_line":"Proposed change\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f9dbf25_b7562f06","line":20,"range":{"start_line":18,"start_character":8,"end_line":20,"end_character":47},"updated":"2018-03-01 13:01:26.000000000","message":"I think that this is part of the solution, not the problem.\nThe problem is that there might be two alarms with a conflict.","commit_id":"76ac2c1afeb0202e4148499674422d0ca2ecb162"},{"author":{"_account_id":24667,"name":"Jia Peiyuan","email":"jia.peiyuan@zte.com.cn","username":"jiapeiyuan"},"change_message_id":"3939a253d4918d53ced8021214c67db504ee53ca","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\r"},{"line_number":16,"context_line":"\r"},{"line_number":17,"context_line":"When the current and new status of alarm are respectively monitored and\r"},{"line_number":18,"context_line":"deduced, we prescribed rules for alarm merging, even if the state of these\r"},{"line_number":19,"context_line":"two status are conflict. We can use diagnose action to further confirm\r"},{"line_number":20,"context_line":"alarm in environment when the conflict happens.\r"},{"line_number":21,"context_line":"\r"},{"line_number":22,"context_line":"\r"},{"line_number":23,"context_line":"Proposed change\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f9dbf25_504b152a","line":20,"range":{"start_line":18,"start_character":8,"end_line":20,"end_character":47},"in_reply_to":"1f9dbf25_b7562f06","updated":"2018-03-03 10:28:28.000000000","message":"OK, we will amend it","commit_id":"76ac2c1afeb0202e4148499674422d0ca2ecb162"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"e5bd699740722e653d651e682e27d7c7cb29b8be","unresolved":false,"context_lines":[{"line_number":26,"context_line":"order to avoid triggering diagnose action repeatedly, we compare the consistency\r"},{"line_number":27,"context_line":"of state property of current and new alarms only when evaluator deduces it again.\r"},{"line_number":28,"context_line":"\r"},{"line_number":29,"context_line":"The following is scenarios for triggering diagnose action,which is an expansion\r"},{"line_number":30,"context_line":"of alarm merge scenario, by adding \"status_consistent\" column. Blank value of\r"},{"line_number":31,"context_line":"this column means not comparing consistency of current and new status; value\r"},{"line_number":32,"context_line":"\u0027Y\u0027 means the states of current and new alarms are consistent and diagnose action\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f9dbf25_77974792","line":29,"range":{"start_line":29,"start_character":17,"end_line":29,"end_character":26},"updated":"2018-03-01 13:01:26.000000000","message":"It might be better to use \u0027use cases\u0027, because the term \u0027scenario\u0027 is already used in Vitrage templates with a different meaning","commit_id":"76ac2c1afeb0202e4148499674422d0ca2ecb162"},{"author":{"_account_id":24667,"name":"Jia Peiyuan","email":"jia.peiyuan@zte.com.cn","username":"jiapeiyuan"},"change_message_id":"3939a253d4918d53ced8021214c67db504ee53ca","unresolved":false,"context_lines":[{"line_number":26,"context_line":"order to avoid triggering diagnose action repeatedly, we compare the consistency\r"},{"line_number":27,"context_line":"of state property of current and new alarms only when evaluator deduces it again.\r"},{"line_number":28,"context_line":"\r"},{"line_number":29,"context_line":"The following is scenarios for triggering diagnose action,which is an expansion\r"},{"line_number":30,"context_line":"of alarm merge scenario, by adding \"status_consistent\" column. Blank value of\r"},{"line_number":31,"context_line":"this column means not comparing consistency of current and new status; value\r"},{"line_number":32,"context_line":"\u0027Y\u0027 means the states of current and new alarms are consistent and diagnose action\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f9dbf25_90419d0e","line":29,"range":{"start_line":29,"start_character":17,"end_line":29,"end_character":26},"in_reply_to":"1f9dbf25_77974792","updated":"2018-03-03 10:28:28.000000000","message":"OK","commit_id":"76ac2c1afeb0202e4148499674422d0ca2ecb162"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"e5bd699740722e653d651e682e27d7c7cb29b8be","unresolved":false,"context_lines":[{"line_number":38,"context_line":"::\r"},{"line_number":39,"context_line":"\r"},{"line_number":40,"context_line":"   +------------+------------+------------+------------+-------------------+\r"},{"line_number":41,"context_line":"   | Line Number| Current    | New        | Final      | status_consistent |\r"},{"line_number":42,"context_line":"   +------------+------------+------------+------------+-------------------+\r"},{"line_number":43,"context_line":"   |     1      | None       | Report(T)  | Report(T)  |                   |\r"},{"line_number":44,"context_line":"   |     2      | None       | Report(F)  | Report(F)  |                   |\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f9dbf25_f7e83717","line":41,"range":{"start_line":41,"start_character":57,"end_line":41,"end_character":74},"updated":"2018-03-01 13:01:26.000000000","message":"Why not call it Status Consistent? like the other columns","commit_id":"76ac2c1afeb0202e4148499674422d0ca2ecb162"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"e5bd699740722e653d651e682e27d7c7cb29b8be","unresolved":false,"context_lines":[{"line_number":42,"context_line":"   +------------+------------+------------+------------+-------------------+\r"},{"line_number":43,"context_line":"   |     1      | None       | Report(T)  | Report(T)  |                   |\r"},{"line_number":44,"context_line":"   |     2      | None       | Report(F)  | Report(F)  |                   |\r"},{"line_number":45,"context_line":"   |     3      | None       | Deduce(T)  | Deduce(T)  |         N         |\r"},{"line_number":46,"context_line":"   |     4      | None       | Deduce(F)  | Deduce(F)  |         Y         |\r"},{"line_number":47,"context_line":"   |     5      | Report(T)  | Deduce(T)  | Report(T)  |         Y         |\r"},{"line_number":48,"context_line":"   |     6      | Report(T)  | Deduce(F)  | Report(T)  |         N         |\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f9dbf25_b7cb8fa3","line":45,"range":{"start_line":45,"start_character":65,"end_line":45,"end_character":66},"updated":"2018-03-01 13:01:26.000000000","message":"Why is it N? according to the alarm deduction mechanism, there is an alarm. And no monitor says otherwise. Maybe there isn\u0027t a monitor for this alarm? \n\nI actually think that the terminology is confusing. How about you call the column \u0027Should run diagnose action\u0027? and explain why in a comment column. It might be more clear.","commit_id":"76ac2c1afeb0202e4148499674422d0ca2ecb162"},{"author":{"_account_id":24667,"name":"Jia Peiyuan","email":"jia.peiyuan@zte.com.cn","username":"jiapeiyuan"},"change_message_id":"3939a253d4918d53ced8021214c67db504ee53ca","unresolved":false,"context_lines":[{"line_number":42,"context_line":"   +------------+------------+------------+------------+-------------------+\r"},{"line_number":43,"context_line":"   |     1      | None       | Report(T)  | Report(T)  |                   |\r"},{"line_number":44,"context_line":"   |     2      | None       | Report(F)  | Report(F)  |                   |\r"},{"line_number":45,"context_line":"   |     3      | None       | Deduce(T)  | Deduce(T)  |         N         |\r"},{"line_number":46,"context_line":"   |     4      | None       | Deduce(F)  | Deduce(F)  |         Y         |\r"},{"line_number":47,"context_line":"   |     5      | Report(T)  | Deduce(T)  | Report(T)  |         Y         |\r"},{"line_number":48,"context_line":"   |     6      | Report(T)  | Deduce(F)  | Report(T)  |         N         |\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f9dbf25_f0eca12a","line":45,"range":{"start_line":45,"start_character":65,"end_line":45,"end_character":66},"in_reply_to":"1f9dbf25_b7cb8fa3","updated":"2018-03-03 10:28:28.000000000","message":"\u0027Should run diagnose action\u0027 is OK.\nActually, we argued the name for this property internally.\nSo, it\u0027s no problem for it","commit_id":"76ac2c1afeb0202e4148499674422d0ca2ecb162"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"e5bd699740722e653d651e682e27d7c7cb29b8be","unresolved":false,"context_lines":[{"line_number":68,"context_line":"to add support for diagnose action, like:\r"},{"line_number":69,"context_line":"\r"},{"line_number":70,"context_line":"  - an immediate pull from data source\r"},{"line_number":71,"context_line":"  - force a push from data source\r"},{"line_number":72,"context_line":"  - launch external tools to get state and post events to Vitrage API\r"},{"line_number":73,"context_line":"\r"},{"line_number":74,"context_line":"Backward compatibility\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f9dbf25_b7406f09","line":71,"range":{"start_line":71,"start_character":4,"end_line":71,"end_character":33},"updated":"2018-03-01 13:01:26.000000000","message":"I guess you mean force a push from the source, which is not Vitrage. I\u0027m not sure how this can be done. Can vitrage-graph process call Zabbix and ask it to refresh a certain alarm?...","commit_id":"76ac2c1afeb0202e4148499674422d0ca2ecb162"},{"author":{"_account_id":24667,"name":"Jia Peiyuan","email":"jia.peiyuan@zte.com.cn","username":"jiapeiyuan"},"change_message_id":"3939a253d4918d53ced8021214c67db504ee53ca","unresolved":false,"context_lines":[{"line_number":68,"context_line":"to add support for diagnose action, like:\r"},{"line_number":69,"context_line":"\r"},{"line_number":70,"context_line":"  - an immediate pull from data source\r"},{"line_number":71,"context_line":"  - force a push from data source\r"},{"line_number":72,"context_line":"  - launch external tools to get state and post events to Vitrage API\r"},{"line_number":73,"context_line":"\r"},{"line_number":74,"context_line":"Backward compatibility\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f9dbf25_f03a6196","line":71,"range":{"start_line":71,"start_character":4,"end_line":71,"end_character":33},"in_reply_to":"1f9dbf25_b7406f09","updated":"2018-03-03 10:28:28.000000000","message":"There may be some confusion in our expression.\nActually, we mean that there are three options for helping vitrage to finish diagnose action.\nThat\u0027s not mean we will implement it by ourselves.\nIt\u0027s better for monitor to provide some API for us if possibe","commit_id":"76ac2c1afeb0202e4148499674422d0ca2ecb162"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"e5bd699740722e653d651e682e27d7c7cb29b8be","unresolved":false,"context_lines":[{"line_number":69,"context_line":"\r"},{"line_number":70,"context_line":"  - an immediate pull from data source\r"},{"line_number":71,"context_line":"  - force a push from data source\r"},{"line_number":72,"context_line":"  - launch external tools to get state and post events to Vitrage API\r"},{"line_number":73,"context_line":"\r"},{"line_number":74,"context_line":"Backward compatibility\r"},{"line_number":75,"context_line":"----------------------\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f9dbf25_d75e5be5","line":72,"range":{"start_line":72,"start_character":4,"end_line":72,"end_character":69},"updated":"2018-03-01 13:01:26.000000000","message":"But then, how these events will be identified as the original monitor alarm?\nBTW, currently the event API was tested only for Doctor format. If you want to use another format, it might require small changes.","commit_id":"76ac2c1afeb0202e4148499674422d0ca2ecb162"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"e5bd699740722e653d651e682e27d7c7cb29b8be","unresolved":false,"context_lines":[{"line_number":81,"context_line":"For example, if there is no diagnose action for confirming Fault A, the deductive reasoning will still continue once\r"},{"line_number":82,"context_line":"the status of Fault A get updated passively from monitor.\r"},{"line_number":83,"context_line":"\r"},{"line_number":84,"context_line":"If there is no monitor for Fault A, then it will stay in a specific status after merging. But the \u0027status_consistent\u0027\r"},{"line_number":85,"context_line":"result helps the user to narrow down the scope of root cause to make manual investigation easier.\r"},{"line_number":86,"context_line":"\r"},{"line_number":87,"context_line":"Implementation\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f9dbf25_371bff1b","line":84,"range":{"start_line":84,"start_character":98,"end_line":84,"end_character":117},"updated":"2018-03-01 13:01:26.000000000","message":"If I understand correctly, the status_consistent is used only in this spec to help the reader understand the logic. Is it a property that you intend to also keep on the vertex? if so, why?","commit_id":"76ac2c1afeb0202e4148499674422d0ca2ecb162"},{"author":{"_account_id":24667,"name":"Jia Peiyuan","email":"jia.peiyuan@zte.com.cn","username":"jiapeiyuan"},"change_message_id":"3939a253d4918d53ced8021214c67db504ee53ca","unresolved":false,"context_lines":[{"line_number":81,"context_line":"For example, if there is no diagnose action for confirming Fault A, the deductive reasoning will still continue once\r"},{"line_number":82,"context_line":"the status of Fault A get updated passively from monitor.\r"},{"line_number":83,"context_line":"\r"},{"line_number":84,"context_line":"If there is no monitor for Fault A, then it will stay in a specific status after merging. But the \u0027status_consistent\u0027\r"},{"line_number":85,"context_line":"result helps the user to narrow down the scope of root cause to make manual investigation easier.\r"},{"line_number":86,"context_line":"\r"},{"line_number":87,"context_line":"Implementation\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f9dbf25_30e20931","line":84,"range":{"start_line":84,"start_character":98,"end_line":84,"end_character":117},"in_reply_to":"1f9dbf25_371bff1b","updated":"2018-03-03 10:28:28.000000000","message":"Yes, it\u0027s just a hint.\nWe don\u0027t want to add this property on the vertex","commit_id":"76ac2c1afeb0202e4148499674422d0ca2ecb162"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"e5bd699740722e653d651e682e27d7c7cb29b8be","unresolved":false,"context_lines":[{"line_number":99,"context_line":"Work Items\r"},{"line_number":100,"context_line":"----------\r"},{"line_number":101,"context_line":"\r"},{"line_number":102,"context_line":"See dependent blueprints.\r"},{"line_number":103,"context_line":"\r"},{"line_number":104,"context_line":"\r"},{"line_number":105,"context_line":"Dependencies\r"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f9dbf25_17d84351","line":102,"range":{"start_line":102,"start_character":0,"end_line":102,"end_character":25},"updated":"2018-03-01 13:01:26.000000000","message":"Are there work items other than the once of alarm-merge-rule?","commit_id":"76ac2c1afeb0202e4148499674422d0ca2ecb162"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"b81b89d439db4c86286fd5e54131c6152e95d492","unresolved":false,"context_lines":[{"line_number":28,"context_line":"order to avoid triggering diagnose action repeatedly, we compare the consistency\r"},{"line_number":29,"context_line":"of state property of current and new alarms *only when evaluator deduces it*.\r"},{"line_number":30,"context_line":"\r"},{"line_number":31,"context_line":"The following is use cases for triggering diagnose action,which is an expansion\r"},{"line_number":32,"context_line":"of alarm merge scenario, by adding \"Diagnose\" column. \"Diagnose\" means we should\r"},{"line_number":33,"context_line":"run diagnose action or not.\r"},{"line_number":34,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff6b8bd7_a874ae9a","line":31,"range":{"start_line":31,"start_character":14,"end_line":31,"end_character":16},"updated":"2018-03-06 13:52:13.000000000","message":"are","commit_id":"a084ede38f8bab6d9dd06f0504e144054baa14eb"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"b81b89d439db4c86286fd5e54131c6152e95d492","unresolved":false,"context_lines":[{"line_number":28,"context_line":"order to avoid triggering diagnose action repeatedly, we compare the consistency\r"},{"line_number":29,"context_line":"of state property of current and new alarms *only when evaluator deduces it*.\r"},{"line_number":30,"context_line":"\r"},{"line_number":31,"context_line":"The following is use cases for triggering diagnose action,which is an expansion\r"},{"line_number":32,"context_line":"of alarm merge scenario, by adding \"Diagnose\" column. \"Diagnose\" means we should\r"},{"line_number":33,"context_line":"run diagnose action or not.\r"},{"line_number":34,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff6b8bd7_08635ade","line":31,"range":{"start_line":31,"start_character":58,"end_line":31,"end_character":63},"updated":"2018-03-06 13:52:13.000000000","message":"missing space after the comma","commit_id":"a084ede38f8bab6d9dd06f0504e144054baa14eb"},{"author":{"_account_id":25301,"name":"xupeipei","email":"xu.peipei1@zte.com.cn","username":"xupeipei"},"change_message_id":"7f5f45c579a7fa7330116d2e4d1cdadcbfd9578e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"order to avoid triggering diagnose action repeatedly, we compare the consistency\r"},{"line_number":29,"context_line":"of state property of current and new alarms *only when evaluator deduces it*.\r"},{"line_number":30,"context_line":"\r"},{"line_number":31,"context_line":"The following is use cases for triggering diagnose action,which is an expansion\r"},{"line_number":32,"context_line":"of alarm merge scenario, by adding \"Diagnose\" column. \"Diagnose\" means we should\r"},{"line_number":33,"context_line":"run diagnose action or not.\r"},{"line_number":34,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df7087c5_bf2abf8d","line":31,"range":{"start_line":31,"start_character":14,"end_line":31,"end_character":16},"in_reply_to":"ff6b8bd7_a874ae9a","updated":"2018-03-07 02:30:09.000000000","message":"Done","commit_id":"a084ede38f8bab6d9dd06f0504e144054baa14eb"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"b81b89d439db4c86286fd5e54131c6152e95d492","unresolved":false,"context_lines":[{"line_number":39,"context_line":"   +------------+------------+------------+------------+----------+----------------------------------+\r"},{"line_number":40,"context_line":"   | Line Number| Current    | New        | Final      | Diagnose |   Comment                        |\r"},{"line_number":41,"context_line":"   +------------+------------+------------+------------+----------+----------------------------------+\r"},{"line_number":42,"context_line":"   |     1      | None       | Report(T)  | Report(T)  |          |not compare                       |\r"},{"line_number":43,"context_line":"   |     2      | None       | Report(F)  | Report(F)  |          |not compare                       |\r"},{"line_number":44,"context_line":"   |     3      | None       | Deduce(T)  | Deduce(T)  |    Yes   |Current and new status conflict   |\r"},{"line_number":45,"context_line":"   |     4      | None       | Deduce(F)  | Deduce(F)  |    No    |Current and new status consistent |\r"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff6b8bd7_08b83a28","line":42,"range":{"start_line":42,"start_character":67,"end_line":42,"end_character":78},"updated":"2018-03-06 13:52:13.000000000","message":"Nothing to compare","commit_id":"a084ede38f8bab6d9dd06f0504e144054baa14eb"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"f71d7ff9995d1e4f1b77d2eef2b59d02fa531189","unresolved":false,"context_lines":[{"line_number":39,"context_line":"   +------------+------------+------------+------------+----------+----------------------------------+\r"},{"line_number":40,"context_line":"   | Line Number| Current    | New        | Final      | Diagnose |   Comment                        |\r"},{"line_number":41,"context_line":"   +------------+------------+------------+------------+----------+----------------------------------+\r"},{"line_number":42,"context_line":"   |     1      | None       | Report(T)  | Report(T)  |          |not compare                       |\r"},{"line_number":43,"context_line":"   |     2      | None       | Report(F)  | Report(F)  |          |not compare                       |\r"},{"line_number":44,"context_line":"   |     3      | None       | Deduce(T)  | Deduce(T)  |    Yes   |Current and new status conflict   |\r"},{"line_number":45,"context_line":"   |     4      | None       | Deduce(F)  | Deduce(F)  |    No    |Current and new status consistent |\r"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df7087c5_5bd04e51","line":42,"range":{"start_line":42,"start_character":67,"end_line":42,"end_character":78},"in_reply_to":"df7087c5_3f3f8fd7","updated":"2018-03-07 10:15:32.000000000","message":"I understood that, my comment was just about renaming \"not compare\" to \"Nothing to compare\" :-)","commit_id":"a084ede38f8bab6d9dd06f0504e144054baa14eb"},{"author":{"_account_id":25301,"name":"xupeipei","email":"xu.peipei1@zte.com.cn","username":"xupeipei"},"change_message_id":"7f5f45c579a7fa7330116d2e4d1cdadcbfd9578e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"   +------------+------------+------------+------------+----------+----------------------------------+\r"},{"line_number":40,"context_line":"   | Line Number| Current    | New        | Final      | Diagnose |   Comment                        |\r"},{"line_number":41,"context_line":"   +------------+------------+------------+------------+----------+----------------------------------+\r"},{"line_number":42,"context_line":"   |     1      | None       | Report(T)  | Report(T)  |          |not compare                       |\r"},{"line_number":43,"context_line":"   |     2      | None       | Report(F)  | Report(F)  |          |not compare                       |\r"},{"line_number":44,"context_line":"   |     3      | None       | Deduce(T)  | Deduce(T)  |    Yes   |Current and new status conflict   |\r"},{"line_number":45,"context_line":"   |     4      | None       | Deduce(F)  | Deduce(F)  |    No    |Current and new status consistent |\r"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df7087c5_3f3f8fd7","line":42,"range":{"start_line":42,"start_character":67,"end_line":42,"end_character":78},"in_reply_to":"ff6b8bd7_08b83a28","updated":"2018-03-07 02:30:09.000000000","message":"To avoid comparing current and new status repeatedly, we prescribe that compare status only when new status is Deduce(line 28 of the rst). And I think there is also no need to compare when current and new status are respectively Report/Report, Deduce/Deduce.\nWhat do you think about this preconditions  of comparison?","commit_id":"a084ede38f8bab6d9dd06f0504e144054baa14eb"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"b81b89d439db4c86286fd5e54131c6152e95d492","unresolved":false,"context_lines":[{"line_number":41,"context_line":"   +------------+------------+------------+------------+----------+----------------------------------+\r"},{"line_number":42,"context_line":"   |     1      | None       | Report(T)  | Report(T)  |          |not compare                       |\r"},{"line_number":43,"context_line":"   |     2      | None       | Report(F)  | Report(F)  |          |not compare                       |\r"},{"line_number":44,"context_line":"   |     3      | None       | Deduce(T)  | Deduce(T)  |    Yes   |Current and new status conflict   |\r"},{"line_number":45,"context_line":"   |     4      | None       | Deduce(F)  | Deduce(F)  |    No    |Current and new status consistent |\r"},{"line_number":46,"context_line":"   |     5      | Report(T)  | Deduce(T)  | Report(T)  |    No    |Current and new status consistent |\r"},{"line_number":47,"context_line":"   |     6      | Report(T)  | Deduce(F)  | Report(T)  |    Yes   |Current and new status conflict   |\r"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff6b8bd7_48dcf273","line":44,"range":{"start_line":44,"start_character":67,"end_line":44,"end_character":98},"updated":"2018-03-06 13:52:13.000000000","message":"Why? what if this alarm is never reported, and is only deduced?\nI agree that you should try to run diagnose action, but the comment is confusing.","commit_id":"a084ede38f8bab6d9dd06f0504e144054baa14eb"},{"author":{"_account_id":25301,"name":"xupeipei","email":"xu.peipei1@zte.com.cn","username":"xupeipei"},"change_message_id":"7f5f45c579a7fa7330116d2e4d1cdadcbfd9578e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"   +------------+------------+------------+------------+----------+----------------------------------+\r"},{"line_number":42,"context_line":"   |     1      | None       | Report(T)  | Report(T)  |          |not compare                       |\r"},{"line_number":43,"context_line":"   |     2      | None       | Report(F)  | Report(F)  |          |not compare                       |\r"},{"line_number":44,"context_line":"   |     3      | None       | Deduce(T)  | Deduce(T)  |    Yes   |Current and new status conflict   |\r"},{"line_number":45,"context_line":"   |     4      | None       | Deduce(F)  | Deduce(F)  |    No    |Current and new status consistent |\r"},{"line_number":46,"context_line":"   |     5      | Report(T)  | Deduce(T)  | Report(T)  |    No    |Current and new status consistent |\r"},{"line_number":47,"context_line":"   |     6      | Report(T)  | Deduce(F)  | Report(T)  |    Yes   |Current and new status conflict   |\r"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df7087c5_62056c7a","line":44,"range":{"start_line":44,"start_character":67,"end_line":44,"end_character":98},"in_reply_to":"ff6b8bd7_48dcf273","updated":"2018-03-07 02:30:09.000000000","message":"The purpose here is to trigger a diagnose action.\nI\u0027ll modify the comment here.","commit_id":"a084ede38f8bab6d9dd06f0504e144054baa14eb"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"b81b89d439db4c86286fd5e54131c6152e95d492","unresolved":false,"context_lines":[{"line_number":47,"context_line":"   |     6      | Report(T)  | Deduce(F)  | Report(T)  |    Yes   |Current and new status conflict   |\r"},{"line_number":48,"context_line":"   |     7      | Report(F)  | Deduce(T)  | Report(F)  |    Yes   |Current and new status conflict   |\r"},{"line_number":49,"context_line":"   |     8      | Report(F)  | Deduce(F)  | Report(F)  |    No    |Current and new status consistent |\r"},{"line_number":50,"context_line":"   |     9      | Deduce(T)  | Report(T)  | Report(T)  |          |not compare                       |\r"},{"line_number":51,"context_line":"   |     10     | Deduce(T)  | Report(F)  | Report(F)  |          |not compare                       |\r"},{"line_number":52,"context_line":"   |     11     | Deduce(F)  | Report(T)  | Report(T)  |          |not compare                       |\r"},{"line_number":53,"context_line":"   |     12     | Deduce(F)  | Report(F)  | Report(F)  |          |not compare                       |\r"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff6b8bd7_48971292","line":50,"range":{"start_line":50,"start_character":67,"end_line":50,"end_character":78},"updated":"2018-03-06 13:52:13.000000000","message":"Why not say \"Current and new status consistent\"?","commit_id":"a084ede38f8bab6d9dd06f0504e144054baa14eb"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"f71d7ff9995d1e4f1b77d2eef2b59d02fa531189","unresolved":false,"context_lines":[{"line_number":47,"context_line":"   |     6      | Report(T)  | Deduce(F)  | Report(T)  |    Yes   |Current and new status conflict   |\r"},{"line_number":48,"context_line":"   |     7      | Report(F)  | Deduce(T)  | Report(F)  |    Yes   |Current and new status conflict   |\r"},{"line_number":49,"context_line":"   |     8      | Report(F)  | Deduce(F)  | Report(F)  |    No    |Current and new status consistent |\r"},{"line_number":50,"context_line":"   |     9      | Deduce(T)  | Report(T)  | Report(T)  |          |not compare                       |\r"},{"line_number":51,"context_line":"   |     10     | Deduce(T)  | Report(F)  | Report(F)  |          |not compare                       |\r"},{"line_number":52,"context_line":"   |     11     | Deduce(F)  | Report(T)  | Report(T)  |          |not compare                       |\r"},{"line_number":53,"context_line":"   |     12     | Deduce(F)  | Report(F)  | Report(F)  |          |not compare                       |\r"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df7087c5_5b136e0e","line":50,"range":{"start_line":50,"start_character":67,"end_line":50,"end_character":78},"in_reply_to":"df7087c5_c250f8d7","updated":"2018-03-07 10:15:32.000000000","message":"It\u0027s not exactly the same. In line 1 there is only Report(T), so there is nothing to compare. Here there is also Deduce, but since the current and new status are the same there is no need to run diagnose action.\n\nIn both cases I agree that there is no need to run the diagnose action, I just think the comments should be slightly different.","commit_id":"a084ede38f8bab6d9dd06f0504e144054baa14eb"},{"author":{"_account_id":25301,"name":"xupeipei","email":"xu.peipei1@zte.com.cn","username":"xupeipei"},"change_message_id":"7f5f45c579a7fa7330116d2e4d1cdadcbfd9578e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"   |     6      | Report(T)  | Deduce(F)  | Report(T)  |    Yes   |Current and new status conflict   |\r"},{"line_number":48,"context_line":"   |     7      | Report(F)  | Deduce(T)  | Report(F)  |    Yes   |Current and new status conflict   |\r"},{"line_number":49,"context_line":"   |     8      | Report(F)  | Deduce(F)  | Report(F)  |    No    |Current and new status consistent |\r"},{"line_number":50,"context_line":"   |     9      | Deduce(T)  | Report(T)  | Report(T)  |          |not compare                       |\r"},{"line_number":51,"context_line":"   |     10     | Deduce(T)  | Report(F)  | Report(F)  |          |not compare                       |\r"},{"line_number":52,"context_line":"   |     11     | Deduce(F)  | Report(T)  | Report(T)  |          |not compare                       |\r"},{"line_number":53,"context_line":"   |     12     | Deduce(F)  | Report(F)  | Report(F)  |          |not compare                       |\r"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df7087c5_c250f8d7","line":50,"range":{"start_line":50,"start_character":67,"end_line":50,"end_character":78},"in_reply_to":"ff6b8bd7_48971292","updated":"2018-03-07 02:30:09.000000000","message":"Same as line 1 in table","commit_id":"a084ede38f8bab6d9dd06f0504e144054baa14eb"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"b81b89d439db4c86286fd5e54131c6152e95d492","unresolved":false,"context_lines":[{"line_number":48,"context_line":"   |     7      | Report(F)  | Deduce(T)  | Report(F)  |    Yes   |Current and new status conflict   |\r"},{"line_number":49,"context_line":"   |     8      | Report(F)  | Deduce(F)  | Report(F)  |    No    |Current and new status consistent |\r"},{"line_number":50,"context_line":"   |     9      | Deduce(T)  | Report(T)  | Report(T)  |          |not compare                       |\r"},{"line_number":51,"context_line":"   |     10     | Deduce(T)  | Report(F)  | Report(F)  |          |not compare                       |\r"},{"line_number":52,"context_line":"   |     11     | Deduce(F)  | Report(T)  | Report(T)  |          |not compare                       |\r"},{"line_number":53,"context_line":"   |     12     | Deduce(F)  | Report(F)  | Report(F)  |          |not compare                       |\r"},{"line_number":54,"context_line":"   +------------+------------+------------+------------+----------+----------------------------------+\r"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff6b8bd7_08911a9a","line":51,"range":{"start_line":51,"start_character":67,"end_line":51,"end_character":78},"updated":"2018-03-06 13:52:13.000000000","message":"I would say \"Trust the up-to-date report\"","commit_id":"a084ede38f8bab6d9dd06f0504e144054baa14eb"},{"author":{"_account_id":25301,"name":"xupeipei","email":"xu.peipei1@zte.com.cn","username":"xupeipei"},"change_message_id":"7f5f45c579a7fa7330116d2e4d1cdadcbfd9578e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"   |     7      | Report(F)  | Deduce(T)  | Report(F)  |    Yes   |Current and new status conflict   |\r"},{"line_number":49,"context_line":"   |     8      | Report(F)  | Deduce(F)  | Report(F)  |    No    |Current and new status consistent |\r"},{"line_number":50,"context_line":"   |     9      | Deduce(T)  | Report(T)  | Report(T)  |          |not compare                       |\r"},{"line_number":51,"context_line":"   |     10     | Deduce(T)  | Report(F)  | Report(F)  |          |not compare                       |\r"},{"line_number":52,"context_line":"   |     11     | Deduce(F)  | Report(T)  | Report(T)  |          |not compare                       |\r"},{"line_number":53,"context_line":"   |     12     | Deduce(F)  | Report(F)  | Report(F)  |          |not compare                       |\r"},{"line_number":54,"context_line":"   +------------+------------+------------+------------+----------+----------------------------------+\r"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df7087c5_826440bb","line":51,"range":{"start_line":51,"start_character":67,"end_line":51,"end_character":78},"in_reply_to":"ff6b8bd7_08911a9a","updated":"2018-03-07 02:30:09.000000000","message":"Same as line 1 in table.","commit_id":"a084ede38f8bab6d9dd06f0504e144054baa14eb"}]}
