)]}'
{"vitrage_tempest_plugin/tests/common/aodh_utils.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"93529b815872ed4e16c7682f48e063e08f081280","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from vitrage.datasources.aodh.properties import AodhProperties as AodhProps"},{"line_number":17,"context_line":"from vitrage_tempest_plugin.tests.common.tempest_clients import TempestClients"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ID \u003d \u0027id\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def create_aodh_alarm(resource_id\u003dNone, name\u003dNone, unic\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_f3e97519","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":9},"updated":"2018-06-13 11:02:51.000000000","message":"I think it should be defined in constants.py","commit_id":"97c7d501995df9f39cf0da41d7869ebcb3d67eb2"},{"author":{"_account_id":26464,"name":"Niv Oppenhaim","email":"niv.oppenhaim@nokia.com","username":"nivolas"},"change_message_id":"a96f31b6de8bdb741a8a12d2a74e9633f0b93cdf","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from vitrage.datasources.aodh.properties import AodhProperties as AodhProps"},{"line_number":17,"context_line":"from vitrage_tempest_plugin.tests.common.tempest_clients import TempestClients"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ID \u003d \u0027id\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def create_aodh_alarm(resource_id\u003dNone, name\u003dNone, unic\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_2ea9c07a","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":9},"in_reply_to":"5f7c97a3_f3e97519","updated":"2018-06-13 11:59:12.000000000","message":"Done","commit_id":"97c7d501995df9f39cf0da41d7869ebcb3d67eb2"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"93529b815872ed4e16c7682f48e063e08f081280","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    elif unic:"},{"line_number":26,"context_line":"        name \u003d \u0027%s-%s\u0027 % (name, random.randrange(0, 100000, 1))"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    aodh_request \u003d _aodh_request(u\u0027event\u0027,"},{"line_number":29,"context_line":"                                 resource_id\u003dresource_id,"},{"line_number":30,"context_line":"                                 name\u003dname)"},{"line_number":31,"context_line":"    TempestClients.aodh().alarm.create(aodh_request)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b3c8dda7","line":28,"range":{"start_line":28,"start_character":33,"end_line":28,"end_character":34},"updated":"2018-06-13 11:02:51.000000000","message":"Is the u important (here and below)?","commit_id":"97c7d501995df9f39cf0da41d7869ebcb3d67eb2"},{"author":{"_account_id":26464,"name":"Niv Oppenhaim","email":"niv.oppenhaim@nokia.com","username":"nivolas"},"change_message_id":"a96f31b6de8bdb741a8a12d2a74e9633f0b93cdf","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    elif unic:"},{"line_number":26,"context_line":"        name \u003d \u0027%s-%s\u0027 % (name, random.randrange(0, 100000, 1))"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    aodh_request \u003d _aodh_request(u\u0027event\u0027,"},{"line_number":29,"context_line":"                                 resource_id\u003dresource_id,"},{"line_number":30,"context_line":"                                 name\u003dname)"},{"line_number":31,"context_line":"    TempestClients.aodh().alarm.create(aodh_request)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_4e13dc01","line":28,"range":{"start_line":28,"start_character":33,"end_line":28,"end_character":34},"in_reply_to":"5f7c97a3_b3c8dda7","updated":"2018-06-13 11:59:12.000000000","message":"Not really. Done","commit_id":"97c7d501995df9f39cf0da41d7869ebcb3d67eb2"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"93529b815872ed4e16c7682f48e063e08f081280","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                                 name\u003dname,"},{"line_number":54,"context_line":"                                 rule\u003drule)"},{"line_number":55,"context_line":"    TempestClients.aodh().alarm.create(aodh_request)"},{"line_number":56,"context_line":"    time.sleep(20)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def create_aodh_resources_threshold_alarm(resource_id\u003dNone, name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_734b252a","line":56,"range":{"start_line":56,"start_character":15,"end_line":56,"end_character":17},"updated":"2018-06-13 11:02:51.000000000","message":"I understand that you wait 20 seconds (which is a lot) because you want to make sure the alarm is created in Vitrage? there should be immediate notifications from Aodh to Vitrage, I hope they are configured in the tempest tests. If so, you should wait only 1-2 seconds.","commit_id":"97c7d501995df9f39cf0da41d7869ebcb3d67eb2"},{"author":{"_account_id":26464,"name":"Niv Oppenhaim","email":"niv.oppenhaim@nokia.com","username":"nivolas"},"change_message_id":"a96f31b6de8bdb741a8a12d2a74e9633f0b93cdf","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                                 name\u003dname,"},{"line_number":54,"context_line":"                                 rule\u003drule)"},{"line_number":55,"context_line":"    TempestClients.aodh().alarm.create(aodh_request)"},{"line_number":56,"context_line":"    time.sleep(20)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def create_aodh_resources_threshold_alarm(resource_id\u003dNone, name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_2ebc6004","line":56,"range":{"start_line":56,"start_character":15,"end_line":56,"end_character":17},"in_reply_to":"5f7c97a3_734b252a","updated":"2018-06-13 11:59:12.000000000","message":"Good question, I actually changed it from 45 in the previous version as that seemed too much. Also changed the delete from 2 minutes to 30 seconds. I will check","commit_id":"97c7d501995df9f39cf0da41d7869ebcb3d67eb2"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"53bd4f54eee7fce87d2edbf7208a067de36cfcbf","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    AodhProps"},{"line_number":19,"context_line":"from vitrage_tempest_plugin.tests.common.tempest_clients import TempestClients"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"RESOURCES_THRESHOLD_RULE \u003d \u0027gnocchi_aggregation_by_resources_threshold_rule\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def create_aodh_alarm(resource_id\u003dNone, name\u003dNone, unic\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_de1035f7","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":24},"updated":"2018-07-18 07:12:06.000000000","message":"Why not add it to AodhProps?","commit_id":"2a4dec191184d5e1968c3bf7e6cae36859d45c0a"},{"author":{"_account_id":26464,"name":"Niv Oppenhaim","email":"niv.oppenhaim@nokia.com","username":"nivolas"},"change_message_id":"2a37b32d1d106aca2bfcd0ebcca1642f14408ab1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    AodhProps"},{"line_number":19,"context_line":"from vitrage_tempest_plugin.tests.common.tempest_clients import TempestClients"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"RESOURCES_THRESHOLD_RULE \u003d \u0027gnocchi_aggregation_by_resources_threshold_rule\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def create_aodh_alarm(resource_id\u003dNone, name\u003dNone, unic\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_8814be43","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":24},"in_reply_to":"5f7c97a3_de1035f7","updated":"2018-07-18 08:52:29.000000000","message":"Done","commit_id":"2a4dec191184d5e1968c3bf7e6cae36859d45c0a"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"53bd4f54eee7fce87d2edbf7208a067de36cfcbf","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    time.sleep(10)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def create_aodh_resources_threshold_alarm(resource_id, name\u003dNone):"},{"line_number":62,"context_line":"    if not name:"},{"line_number":63,"context_line":"        name \u003d \u0027%s-%s\u0027 % (\u0027test_\u0027, random.randrange(0, 100000, 1))"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_1ef22de4","line":61,"range":{"start_line":61,"start_character":42,"end_line":61,"end_character":53},"updated":"2018-07-18 07:12:06.000000000","message":"What is the relation between resource_id and gnocchi_resource?","commit_id":"2a4dec191184d5e1968c3bf7e6cae36859d45c0a"},{"author":{"_account_id":26464,"name":"Niv Oppenhaim","email":"niv.oppenhaim@nokia.com","username":"nivolas"},"change_message_id":"2a37b32d1d106aca2bfcd0ebcca1642f14408ab1","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    time.sleep(10)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def create_aodh_resources_threshold_alarm(resource_id, name\u003dNone):"},{"line_number":62,"context_line":"    if not name:"},{"line_number":63,"context_line":"        name \u003d \u0027%s-%s\u0027 % (\u0027test_\u0027, random.randrange(0, 100000, 1))"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_084f4e69","line":61,"range":{"start_line":61,"start_character":42,"end_line":61,"end_character":53},"in_reply_to":"5f7c97a3_1ef22de4","updated":"2018-07-18 08:52:29.000000000","message":"the resource_id is the resource to raise the alarm on. The gnocchi_resource is the resource which the metric is specified on (they are not necessarily the same)","commit_id":"2a4dec191184d5e1968c3bf7e6cae36859d45c0a"}],"vitrage_tempest_plugin/tests/datasources/test_aodh.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"93529b815872ed4e16c7682f48e063e08f081280","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            api_graph \u003d self.vitrage_client.topology.get(all_tenants\u003dTrue)"},{"line_number":81,"context_line":"            graph \u003d self._create_graph_from_graph_dictionary(api_graph)"},{"line_number":82,"context_line":"            entities \u003d self._entities_validation_data("},{"line_number":83,"context_line":"                host_entities\u003d1,"},{"line_number":84,"context_line":"                host_edges\u003d1 + self.NUM_INSTANCE,"},{"line_number":85,"context_line":"                instance_entities\u003dself.NUM_INSTANCE,"},{"line_number":86,"context_line":"                instance_edges\u003d2 * self.NUM_INSTANCE,"},{"line_number":87,"context_line":"                aodh_entities\u003dself.NUM_ALARM,"},{"line_number":88,"context_line":"                aodh_edges\u003d0)"},{"line_number":89,"context_line":"            num_entities \u003d self.num_default_entities + \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_737ec519","line":86,"range":{"start_line":83,"start_character":16,"end_line":86,"end_character":53},"updated":"2018-06-13 11:02:51.000000000","message":"I\u0027m not sure that you need to check the hosts and instances. They are checked in many other tests, and are not relevant to your aodh test","commit_id":"97c7d501995df9f39cf0da41d7869ebcb3d67eb2"},{"author":{"_account_id":26464,"name":"Niv Oppenhaim","email":"niv.oppenhaim@nokia.com","username":"nivolas"},"change_message_id":"a96f31b6de8bdb741a8a12d2a74e9633f0b93cdf","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            api_graph \u003d self.vitrage_client.topology.get(all_tenants\u003dTrue)"},{"line_number":81,"context_line":"            graph \u003d self._create_graph_from_graph_dictionary(api_graph)"},{"line_number":82,"context_line":"            entities \u003d self._entities_validation_data("},{"line_number":83,"context_line":"                host_entities\u003d1,"},{"line_number":84,"context_line":"                host_edges\u003d1 + self.NUM_INSTANCE,"},{"line_number":85,"context_line":"                instance_entities\u003dself.NUM_INSTANCE,"},{"line_number":86,"context_line":"                instance_edges\u003d2 * self.NUM_INSTANCE,"},{"line_number":87,"context_line":"                aodh_entities\u003dself.NUM_ALARM,"},{"line_number":88,"context_line":"                aodh_edges\u003d0)"},{"line_number":89,"context_line":"            num_entities \u003d self.num_default_entities + \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_8ef494d0","line":86,"range":{"start_line":83,"start_character":16,"end_line":86,"end_character":53},"in_reply_to":"5f7c97a3_737ec519","updated":"2018-06-13 11:59:12.000000000","message":"More like a sanity test to check that adding an alarm doesn\u0027t add random nodes/edges. Should I remove it?","commit_id":"97c7d501995df9f39cf0da41d7869ebcb3d67eb2"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"93529b815872ed4e16c7682f48e063e08f081280","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                instance_entities\u003dself.NUM_INSTANCE,"},{"line_number":86,"context_line":"                instance_edges\u003d2 * self.NUM_INSTANCE,"},{"line_number":87,"context_line":"                aodh_entities\u003dself.NUM_ALARM,"},{"line_number":88,"context_line":"                aodh_edges\u003d0)"},{"line_number":89,"context_line":"            num_entities \u003d self.num_default_entities + \\"},{"line_number":90,"context_line":"                2 * self.NUM_INSTANCE + self.NUM_ALARM + \\"},{"line_number":91,"context_line":"                self.num_default_networks + self.num_default_ports"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_5396294b","line":88,"range":{"start_line":88,"start_character":16,"end_line":88,"end_character":26},"updated":"2018-06-13 11:02:51.000000000","message":"What does it mean? why 0?","commit_id":"97c7d501995df9f39cf0da41d7869ebcb3d67eb2"},{"author":{"_account_id":26464,"name":"Niv Oppenhaim","email":"niv.oppenhaim@nokia.com","username":"nivolas"},"change_message_id":"a96f31b6de8bdb741a8a12d2a74e9633f0b93cdf","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                instance_entities\u003dself.NUM_INSTANCE,"},{"line_number":86,"context_line":"                instance_edges\u003d2 * self.NUM_INSTANCE,"},{"line_number":87,"context_line":"                aodh_entities\u003dself.NUM_ALARM,"},{"line_number":88,"context_line":"                aodh_edges\u003d0)"},{"line_number":89,"context_line":"            num_entities \u003d self.num_default_entities + \\"},{"line_number":90,"context_line":"                2 * self.NUM_INSTANCE + self.NUM_ALARM + \\"},{"line_number":91,"context_line":"                self.num_default_networks + self.num_default_ports"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_ee0508c3","line":88,"range":{"start_line":88,"start_character":16,"end_line":88,"end_character":26},"in_reply_to":"5f7c97a3_5396294b","updated":"2018-06-13 11:59:12.000000000","message":"It is the same as in the test below (\"test_without_resource_id\"). The alarm here is not connected to any resources, therefore 0 alarm edges.","commit_id":"97c7d501995df9f39cf0da41d7869ebcb3d67eb2"}]}