)]}'
{"vitrage_tempest_tests/tests/api/alarms/base.py":[{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"d52e711d42debc8f9cebcca45e10aa2686c09a43","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        super(BaseAlarmsTest, cls).setUpClass()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @staticmethod"},{"line_number":34,"context_line":"    def copy_alarms_templates_files():"},{"line_number":35,"context_line":"        utils.run_from_terminal("},{"line_number":36,"context_line":"            \"cp \" +"},{"line_number":37,"context_line":"            \"vitrage_tempest_tests/tests/resources/templates/\""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_06bd11d7","line":34,"updated":"2016-05-15 13:29:01.000000000","message":"is this method being used? if not, should we erase it?","commit_id":"261b45b163c14f523684e9996fb150a72a6738e9"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"d52e711d42debc8f9cebcca45e10aa2686c09a43","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            + \"*_alarm* /etc/vitrage/templates/.\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @staticmethod"},{"line_number":41,"context_line":"    def delete_alarms_templates_files():"},{"line_number":42,"context_line":"        utils.run_from_terminal("},{"line_number":43,"context_line":"            \"rm /etc/vitrage/templates/*_alarm*\")"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_26bad5e1","line":41,"updated":"2016-05-15 13:29:01.000000000","message":"is this method being used? if not, should we erase it?","commit_id":"261b45b163c14f523684e9996fb150a72a6738e9"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"d52e711d42debc8f9cebcca45e10aa2686c09a43","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            \"rm /etc/vitrage/templates/*_alarm*\")"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @staticmethod"},{"line_number":46,"context_line":"    def _filter_alarms_by_resource_id(alarms_list, resource_id):"},{"line_number":47,"context_line":"        filtered_alarms_list \u003d []"},{"line_number":48,"context_line":"        for item in alarms_list:"},{"line_number":49,"context_line":"            if item[\"category\"] \u003d\u003d \"ALARM\" \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_46b719f5","line":46,"updated":"2016-05-15 13:29:01.000000000","message":"is this method being used? if not, should we erase it?","commit_id":"261b45b163c14f523684e9996fb150a72a6738e9"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"d52e711d42debc8f9cebcca45e10aa2686c09a43","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def _filter_alarms_by_resource_id(alarms_list, resource_id):"},{"line_number":47,"context_line":"        filtered_alarms_list \u003d []"},{"line_number":48,"context_line":"        for item in alarms_list:"},{"line_number":49,"context_line":"            if item[\"category\"] \u003d\u003d \"ALARM\" \\"},{"line_number":50,"context_line":"                    and item[\"resource_id\"] \u003d\u003d resource_id:"},{"line_number":51,"context_line":"                filtered_alarms_list.append(item)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_068b511f","line":49,"updated":"2016-05-15 13:29:01.000000000","message":"if this method is staying, please use the constants file for \"category\", \"ALARM\", \"resource_type\"","commit_id":"261b45b163c14f523684e9996fb150a72a6738e9"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"d52e711d42debc8f9cebcca45e10aa2686c09a43","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        return filtered_alarms_list"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @staticmethod"},{"line_number":56,"context_line":"    def _filter_alarms_by_resource_type(alarms_list, alarm_type):"},{"line_number":57,"context_line":"        filtered_alarms_list \u003d []"},{"line_number":58,"context_line":"        for item in alarms_list:"},{"line_number":59,"context_line":"            if item[\"category\"] \u003d\u003d \"ALARM\" \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_a6cec580","line":56,"updated":"2016-05-15 13:29:01.000000000","message":"is this method being used? if not, should we erase it?","commit_id":"261b45b163c14f523684e9996fb150a72a6738e9"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"d52e711d42debc8f9cebcca45e10aa2686c09a43","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def _filter_alarms_by_resource_type(alarms_list, alarm_type):"},{"line_number":57,"context_line":"        filtered_alarms_list \u003d []"},{"line_number":58,"context_line":"        for item in alarms_list:"},{"line_number":59,"context_line":"            if item[\"category\"] \u003d\u003d \"ALARM\" \\"},{"line_number":60,"context_line":"                    and item[\"resource_type\"] \u003d\u003d alarm_type:"},{"line_number":61,"context_line":"                filtered_alarms_list.append(item)"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_c69ae96d","line":59,"updated":"2016-05-15 13:29:01.000000000","message":"if this method is staying, please use the constants file for \"category\", \"ALARM\", \"resource_type\"","commit_id":"261b45b163c14f523684e9996fb150a72a6738e9"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"d52e711d42debc8f9cebcca45e10aa2686c09a43","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        return filtered_alarms_list"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @staticmethod"},{"line_number":66,"context_line":"    def _filter_alarms_by_type(alarms_list, alarm_type):"},{"line_number":67,"context_line":"        filtered_alarms_list \u003d []"},{"line_number":68,"context_line":"        for item in alarms_list:"},{"line_number":69,"context_line":"            if item[\"category\"] \u003d\u003d \"ALARM\" \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_c6c30956","line":66,"updated":"2016-05-15 13:29:01.000000000","message":"is this method being used? if not, should we erase it?","commit_id":"261b45b163c14f523684e9996fb150a72a6738e9"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"d52e711d42debc8f9cebcca45e10aa2686c09a43","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    def _filter_alarms_by_type(alarms_list, alarm_type):"},{"line_number":67,"context_line":"        filtered_alarms_list \u003d []"},{"line_number":68,"context_line":"        for item in alarms_list:"},{"line_number":69,"context_line":"            if item[\"category\"] \u003d\u003d \"ALARM\" \\"},{"line_number":70,"context_line":"                    and item[\"type\"] \u003d\u003d alarm_type:"},{"line_number":71,"context_line":"                filtered_alarms_list.append(item)"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_a6952541","line":69,"updated":"2016-05-15 13:29:01.000000000","message":"if this method is staying, please use the constants file for \"category\", \"ALARM\", \"type\"","commit_id":"261b45b163c14f523684e9996fb150a72a6738e9"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"8df7292270b28f506f9eea382eca4e03a1bdf1c2","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"CATEGORY_ALARM \u003d \u0027ALARM\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class BaseAlarmsTest(BaseApiTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_9c745bcf","line":26,"updated":"2016-05-17 11:43:48.000000000","message":"you need to take it from: \nvitrage/common/EntityCategory","commit_id":"d9bac57a4a754635a06be61abadb543b7a656764"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"8df7292270b28f506f9eea382eca4e03a1bdf1c2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def _filter_alarms_by_resource_id(alarms_list, resource_id):"},{"line_number":51,"context_line":"        filtered_alarms_list \u003d []"},{"line_number":52,"context_line":"        for item in alarms_list:"},{"line_number":53,"context_line":"            if item[\"category\"] \u003d\u003d CATEGORY_ALARM \\"},{"line_number":54,"context_line":"                    and item[\"resource_id\"] \u003d\u003d resource_id:"},{"line_number":55,"context_line":"                filtered_alarms_list.append(item)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_fc564728","line":53,"updated":"2016-05-17 11:43:48.000000000","message":"you need to take it from: \nvitrage/common/VertexProperties","commit_id":"d9bac57a4a754635a06be61abadb543b7a656764"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"7793a0402c2290647acb4f37ea77d2f8f84fb220","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        if len(self.ceilometer_client.alarms.list()) !\u003d num_alarms:"},{"line_number":120,"context_line":"            return False"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        return all(alarm.__dict__[\u0027state\u0027].upper() \u003d\u003d state.upper()"},{"line_number":123,"context_line":"                   for alarm in self.ceilometer_client.alarms.list())"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_d938fed5","line":122,"range":{"start_line":122,"start_character":19,"end_line":122,"end_character":42},"updated":"2016-05-16 08:22:38.000000000","message":"why using __dict__ ?","commit_id":"d9bac57a4a754635a06be61abadb543b7a656764"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"8df7292270b28f506f9eea382eca4e03a1bdf1c2","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        if len(self.ceilometer_client.alarms.list()) !\u003d num_alarms:"},{"line_number":120,"context_line":"            return False"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        return all(alarm.__dict__[\u0027state\u0027].upper() \u003d\u003d state.upper()"},{"line_number":123,"context_line":"                   for alarm in self.ceilometer_client.alarms.list())"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_bc279fc8","line":122,"range":{"start_line":122,"start_character":19,"end_line":122,"end_character":42},"in_reply_to":"dab17558_d938fed5","updated":"2016-05-17 11:43:48.000000000","message":"change this to alarm.state","commit_id":"d9bac57a4a754635a06be61abadb543b7a656764"}],"vitrage_tempest_tests/tests/api/alarms/test_alarms.py":[{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"d52e711d42debc8f9cebcca45e10aa2686c09a43","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                                      name\u003d\u0027tempest_aodh_test_\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        api_alarms \u003d self.vitrage_client.alarms.list(vitrage_id\u003dNone)"},{"line_number":39,"context_line":"        cli_alarms \u003d utils.run_vitrage_command_with_params("},{"line_number":40,"context_line":"            command\u003d\u0027vitrage alarms list\u0027, auth_url\u003dself.auth_url,"},{"line_number":41,"context_line":"            user\u003d\u0027admin\u0027, password\u003d\u0027password\u0027, project_name\u003d\u0027admin\u0027)"},{"line_number":42,"context_line":"        self.assertEqual(True, self._compare_alarms_lists("}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_66997d6e","line":39,"updated":"2016-05-15 13:29:01.000000000","message":"use run_vitrage_command and pass it only the command you want to run","commit_id":"261b45b163c14f523684e9996fb150a72a6738e9"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"d52e711d42debc8f9cebcca45e10aa2686c09a43","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        cli_alarms \u003d utils.run_vitrage_command_with_params("},{"line_number":40,"context_line":"            command\u003d\u0027vitrage alarms list\u0027, auth_url\u003dself.auth_url,"},{"line_number":41,"context_line":"            user\u003d\u0027admin\u0027, password\u003d\u0027password\u0027, project_name\u003d\u0027admin\u0027)"},{"line_number":42,"context_line":"        self.assertEqual(True, self._compare_alarms_lists("},{"line_number":43,"context_line":"            api_alarms, cli_alarms, \u0027aodh\u0027, resources[0].id))"},{"line_number":44,"context_line":"        self._delete_instances()"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_c6714946","line":42,"updated":"2016-05-15 13:29:01.000000000","message":"use assertTrue","commit_id":"261b45b163c14f523684e9996fb150a72a6738e9"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"d52e711d42debc8f9cebcca45e10aa2686c09a43","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            command\u003d\u0027vitrage alarms list\u0027, auth_url\u003dself.auth_url,"},{"line_number":41,"context_line":"            user\u003d\u0027admin\u0027, password\u003d\u0027password\u0027, project_name\u003d\u0027admin\u0027)"},{"line_number":42,"context_line":"        self.assertEqual(True, self._compare_alarms_lists("},{"line_number":43,"context_line":"            api_alarms, cli_alarms, \u0027aodh\u0027, resources[0].id))"},{"line_number":44,"context_line":"        self._delete_instances()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _compare_alarms_lists(self, api_alarms, cli_alarms,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_469c395d","line":43,"updated":"2016-05-15 13:29:01.000000000","message":"take \"aodh\" from the constant AODH_DATASOURCE","commit_id":"261b45b163c14f523684e9996fb150a72a6738e9"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"d52e711d42debc8f9cebcca45e10aa2686c09a43","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        api_by_id \u003d self._filter_alarms_by_resource_id("},{"line_number":67,"context_line":"            api_alarms, resoure_id)"},{"line_number":68,"context_line":"        cli_by_id \u003d cli_alarms.count(resoure_id)"},{"line_number":69,"context_line":"        return (len(cli_items) - 4 \u003d\u003d len(api_alarms) and"},{"line_number":70,"context_line":"                cli_by_type \u003d\u003d len(api_by_type) and"},{"line_number":71,"context_line":"                cli_by_id \u003d\u003d len(api_by_id))"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_46b399e9","line":69,"updated":"2016-05-15 13:29:01.000000000","message":"I dont quite understand what you are trying to check here.\nFrom my prespective, we need to check here that the amount of alarms in cli and api is the same, and for each alarm in api there is the same alarm in cli.","commit_id":"261b45b163c14f523684e9996fb150a72a6738e9"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"8df7292270b28f506f9eea382eca4e03a1bdf1c2","unresolved":false,"context_lines":[{"line_number":14,"context_line":"import json"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":"from vitrage.datasources import AODH_DATASOURCE"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from vitrage_tempest_tests.tests.api.alarms.base import BaseAlarmsTest"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_fc4767b9","line":17,"updated":"2016-05-17 11:43:48.000000000","message":"that is not what i meant.\nyou need to take it from:\n/opt/stack/vitrage/vitrage/datasources/aodh/AODH_DATASOURCE","commit_id":"d9bac57a4a754635a06be61abadb543b7a656764"}],"vitrage_tempest_tests/tests/api/base.py":[{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"d52e711d42debc8f9cebcca45e10aa2686c09a43","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from vitrage.graph import NXGraph"},{"line_number":31,"context_line":"from vitrage.graph import Vertex"},{"line_number":32,"context_line":"from vitrage import keystone_client"},{"line_number":33,"context_line":"from vitrage_tempest_tests.tests import OPTS"},{"line_number":34,"context_line":"from vitrageclient import client as v_client"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"import vitrage_tempest_tests.tests.utils as utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_6b6dc603","line":33,"updated":"2016-05-15 13:29:01.000000000","message":"Please do revert to all of the changes in this file.\nYou have done a wrong merge after polling this file.\nYou have to check every change you take from the merge carefully!","commit_id":"261b45b163c14f523684e9996fb150a72a6738e9"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"d52e711d42debc8f9cebcca45e10aa2686c09a43","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        super(BaseApiTest, cls).setUpClass()"},{"line_number":52,"context_line":"        cls.conf \u003d utils.get_conf()"},{"line_number":53,"context_line":"        cls.conf.register_opts(list(OPTS), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":54,"context_line":"        cls.auth_url \u003d cls.conf.keystone_authtoken.auth_url"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        cls.vitrage_client \u003d \\"},{"line_number":57,"context_line":"            v_client.Client(\u00271\u0027, session\u003dkeystone_client.get_session(cls.conf))"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_861bc11b","line":54,"updated":"2016-05-15 13:29:01.000000000","message":"there is no need for auth_url to be here because no one is using it here.","commit_id":"261b45b163c14f523684e9996fb150a72a6738e9"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"d52e711d42debc8f9cebcca45e10aa2686c09a43","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            v_client.Client(\u00271\u0027, session\u003dkeystone_client.get_session(cls.conf))"},{"line_number":58,"context_line":"        cls.nova_client \u003d clients.nova_client(cls.conf)"},{"line_number":59,"context_line":"        cls.cinder_client \u003d clients.cinder_client(cls.conf)"},{"line_number":60,"context_line":"        cls.ceilometer_client \u003d clients.ceilometer_client(cls.conf)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _create_volume_and_attach(self, name, size, instance_id, mount_point):"},{"line_number":63,"context_line":"        volume \u003d self.cinder_client.volumes.create(display_name\u003dname,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_e61a8d16","line":60,"updated":"2016-05-15 13:29:01.000000000","message":"there is no need for ceilometer client to be here because no one is using it here.","commit_id":"261b45b163c14f523684e9996fb150a72a6738e9"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"8df7292270b28f506f9eea382eca4e03a1bdf1c2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        super(BaseApiTest, cls).setUpClass()"},{"line_number":52,"context_line":"        cls.conf \u003d utils.get_conf()"},{"line_number":53,"context_line":"        cls.conf.register_opts(list(OPTS), group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":54,"context_line":"        # cls.auth_url \u003d cls.conf.keystone_authtoken.auth_url"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        cls.vitrage_client \u003d \\"},{"line_number":57,"context_line":"            v_client.Client(\u00271\u0027, session\u003dkeystone_client.get_session(cls.conf))"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_1cf34b74","line":54,"updated":"2016-05-17 11:43:48.000000000","message":"please erase the comment","commit_id":"d9bac57a4a754635a06be61abadb543b7a656764"}]}