)]}'
{"vitrage/evaluator/template_validation/template_syntax_validator.py":[{"author":{"_account_id":19233,"name":"Elisha Rosensweig","email":"elisha@chorus.ai","username":"elisha.rosensweig"},"change_message_id":"0fc46fbaa238eb9f0ea2b206a3e17eed9d5e6977","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    result \u003d validate_template_sections(template_conf)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    if result.is_valid:"},{"line_number":43,"context_line":"        metadata \u003d template_conf[TemplateFields.METADATA]"},{"line_number":44,"context_line":"        result \u003d validate_metadata_section(metadata)"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_d351b163","line":42,"updated":"2016-05-17 12:24:54.000000000","message":"you can take these three \"if... then...\" and put them into a loop","commit_id":"067c19b06ea2430bcb965f2fc4ab70ad4303b6c7"},{"author":{"_account_id":19209,"name":"Liat","email":"liat.har-tal@nokia.com","username":"liat"},"change_message_id":"03031c42cd73c15206ff2fc69ea154b45bce73fe","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    result \u003d validate_template_sections(template_conf)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    if result.is_valid:"},{"line_number":43,"context_line":"        metadata \u003d template_conf[TemplateFields.METADATA]"},{"line_number":44,"context_line":"        result \u003d validate_metadata_section(metadata)"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_a9dbda4d","line":42,"in_reply_to":"dab17558_d351b163","updated":"2016-05-17 12:38:16.000000000","message":"Each if do validate diffrent part of the template","commit_id":"067c19b06ea2430bcb965f2fc4ab70ad4303b6c7"},{"author":{"_account_id":19233,"name":"Elisha Rosensweig","email":"elisha@chorus.ai","username":"elisha.rosensweig"},"change_message_id":"0fc46fbaa238eb9f0ea2b206a3e17eed9d5e6977","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            result \u003d validate_entity_dict(entity[TemplateFields.ENTITY])"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if not result.is_valid:"},{"line_number":124,"context_line":"            return result"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    return result"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_b3106d5a","line":124,"updated":"2016-05-17 12:24:54.000000000","message":"change to \"break\" - the external return will return the result anyway","commit_id":"067c19b06ea2430bcb965f2fc4ab70ad4303b6c7"},{"author":{"_account_id":19209,"name":"Liat","email":"liat.har-tal@nokia.com","username":"liat"},"change_message_id":"03031c42cd73c15206ff2fc69ea154b45bce73fe","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            result \u003d validate_entity_dict(entity[TemplateFields.ENTITY])"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if not result.is_valid:"},{"line_number":124,"context_line":"            return result"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    return result"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_e9a5e2a1","line":124,"in_reply_to":"dab17558_b3106d5a","updated":"2016-05-17 12:38:16.000000000","message":"your comment is programming style.. I better to return the value when you can and not necessarily at the end of the method","commit_id":"067c19b06ea2430bcb965f2fc4ab70ad4303b6c7"},{"author":{"_account_id":19233,"name":"Elisha Rosensweig","email":"elisha@chorus.ai","username":"elisha.rosensweig"},"change_message_id":"0fc46fbaa238eb9f0ea2b206a3e17eed9d5e6977","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            result \u003d validate_relationship_dict(relationship_dict)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"            if not result.is_valid:"},{"line_number":160,"context_line":"                return result"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    return result"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_860a451e","line":160,"updated":"2016-05-17 12:24:54.000000000","message":"change to \"break\" - the external return will return the result anyway","commit_id":"067c19b06ea2430bcb965f2fc4ab70ad4303b6c7"},{"author":{"_account_id":19233,"name":"Elisha Rosensweig","email":"elisha@chorus.ai","username":"elisha.rosensweig"},"change_message_id":"0fc46fbaa238eb9f0ea2b206a3e17eed9d5e6977","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            result \u003d validate_scenario(scenario[TemplateFields.SCENARIO])"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"            if not result.is_valid:"},{"line_number":203,"context_line":"                return result"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    return result"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_06177545","line":203,"updated":"2016-05-17 12:24:54.000000000","message":"change to \"break\" - the external return will return the result anyway","commit_id":"067c19b06ea2430bcb965f2fc4ab70ad4303b6c7"},{"author":{"_account_id":19233,"name":"Elisha Rosensweig","email":"elisha@chorus.ai","username":"elisha.rosensweig"},"change_message_id":"0fc46fbaa238eb9f0ea2b206a3e17eed9d5e6977","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            result \u003d validate_action_schema(action[TemplateFields.ACTION])"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        if not result.is_valid:"},{"line_number":246,"context_line":"            return result"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    return result"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_e63cf1c9","line":246,"updated":"2016-05-17 12:24:54.000000000","message":"change to \"break\" - the external return will return the result anyway","commit_id":"067c19b06ea2430bcb965f2fc4ab70ad4303b6c7"}]}