)]}'
{"vitrage/evaluator/actions/recipes/mark_down.py":[{"author":{"_account_id":19209,"name":"Liat","email":"liat.har-tal@nokia.com","username":"liat"},"change_message_id":"ff09a5da3b0e415deade95e169949c617de041d3","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        update_vertex_step \u003d MarkDown._get_update_vertex_step("},{"line_number":46,"context_line":"            action_spec.targets[TFields.TARGET].vertex_id,"},{"line_number":47,"context_line":"            None)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        return [update_vertex_step]"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_1c6e1d2f","line":47,"range":{"start_line":47,"start_character":12,"end_line":47,"end_character":16},"updated":"2016-07-11 10:12:47.000000000","message":"why None and not False?\nI think it strange that the field value is True or None","commit_id":"befb7c85d71c42a336aa8d4a1e0bc1ab58853c98"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"c641ab0a8714fcb42684874d0c94087e13b20f10","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        update_vertex_step \u003d MarkDown._get_update_vertex_step("},{"line_number":46,"context_line":"            action_spec.targets[TFields.TARGET].vertex_id,"},{"line_number":47,"context_line":"            None)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        return [update_vertex_step]"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_c6d683c2","line":47,"range":{"start_line":47,"start_character":12,"end_line":47,"end_character":16},"in_reply_to":"1aa78d24_1c6e1d2f","updated":"2016-07-11 11:04:27.000000000","message":"Done","commit_id":"befb7c85d71c42a336aa8d4a1e0bc1ab58853c98"}],"vitrage/evaluator/template_validation/template_content_validator.py":[{"author":{"_account_id":19233,"name":"Elisha Rosensweig","email":"elisha@chorus.ai","username":"elisha.rosensweig"},"change_message_id":"a8d6ed2535aff44519aa4163dfafd9af78726666","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        return validate_set_state_action(action, entities_ids)"},{"line_number":176,"context_line":"    elif action_type \u003d\u003d ActionType.ADD_CAUSAL_RELATIONSHIP:"},{"line_number":177,"context_line":"        return validate_add_causal_relationship_action(action, entities_ids)"},{"line_number":178,"context_line":"    elif action_type \u003d\u003d ActionType.MARK_DOWN:"},{"line_number":179,"context_line":"        return validate_mark_down_action(action, entities_ids)"},{"line_number":180,"context_line":"    else:"},{"line_number":181,"context_line":"        LOG.error(\u0027%s status code: %s\u0027 % (status_msgs[120], 120))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_337867f2","line":178,"updated":"2016-07-11 10:46:55.000000000","message":"since we have several actions, better to change this to a function dictionary to avoid all these \"ifs\"","commit_id":"befb7c85d71c42a336aa8d4a1e0bc1ab58853c98"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"c641ab0a8714fcb42684874d0c94087e13b20f10","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        return validate_set_state_action(action, entities_ids)"},{"line_number":176,"context_line":"    elif action_type \u003d\u003d ActionType.ADD_CAUSAL_RELATIONSHIP:"},{"line_number":177,"context_line":"        return validate_add_causal_relationship_action(action, entities_ids)"},{"line_number":178,"context_line":"    elif action_type \u003d\u003d ActionType.MARK_DOWN:"},{"line_number":179,"context_line":"        return validate_mark_down_action(action, entities_ids)"},{"line_number":180,"context_line":"    else:"},{"line_number":181,"context_line":"        LOG.error(\u0027%s status code: %s\u0027 % (status_msgs[120], 120))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_66c7cf12","line":178,"in_reply_to":"1aa78d24_337867f2","updated":"2016-07-11 11:04:27.000000000","message":"Done","commit_id":"befb7c85d71c42a336aa8d4a1e0bc1ab58853c98"},{"author":{"_account_id":19209,"name":"Liat","email":"liat.har-tal@nokia.com","username":"liat"},"change_message_id":"ff09a5da3b0e415deade95e169949c617de041d3","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    return _validate_template_id(entities_ids, source)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"def validate_mark_down_action(action, entities_ids):"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    action_target \u003d action[TemplateFields.ACTION_TARGET]"},{"line_number":248,"context_line":"    if TemplateFields.TARGET not in action_target:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_b0ca8d9f","line":245,"range":{"start_line":245,"start_character":4,"end_line":245,"end_character":29},"updated":"2016-07-11 10:12:47.000000000","message":"You don\u0027t check if the is_marked_down field in action properties exsits - you should add this test","commit_id":"befb7c85d71c42a336aa8d4a1e0bc1ab58853c98"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"3b52ef3bbb5d793cb40e4421525fcf7c0067560f","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    return _validate_template_id(entities_ids, source)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"def validate_mark_down_action(action, entities_ids):"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    action_target \u003d action[TemplateFields.ACTION_TARGET]"},{"line_number":248,"context_line":"    if TemplateFields.TARGET not in action_target:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_b358d7fb","line":245,"range":{"start_line":245,"start_character":4,"end_line":245,"end_character":29},"in_reply_to":"1aa78d24_b0ca8d9f","updated":"2016-07-11 10:35:50.000000000","message":"This is field is not in the action or template, only a target should be specified","commit_id":"befb7c85d71c42a336aa8d4a1e0bc1ab58853c98"},{"author":{"_account_id":19209,"name":"Liat","email":"liat.har-tal@nokia.com","username":"liat"},"change_message_id":"a78ad9d30afb1c6e91945249f2f7f0ec439eaba8","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    return _validate_template_id(entities_ids, source)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"def validate_mark_down_action(action, entities_ids):"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    action_target \u003d action[TemplateFields.ACTION_TARGET]"},{"line_number":248,"context_line":"    if TemplateFields.TARGET not in action_target:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_b38297fe","line":245,"range":{"start_line":245,"start_character":4,"end_line":245,"end_character":29},"in_reply_to":"1aa78d24_b358d7fb","updated":"2016-07-11 10:40:16.000000000","message":"Is the action valid without this field?","commit_id":"befb7c85d71c42a336aa8d4a1e0bc1ab58853c98"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"78a6474597c478a83b5180d8d3b09b2757fc3004","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    return _validate_template_id(entities_ids, source)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"def validate_mark_down_action(action, entities_ids):"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    action_target \u003d action[TemplateFields.ACTION_TARGET]"},{"line_number":248,"context_line":"    if TemplateFields.TARGET not in action_target:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_b383b7cb","line":245,"range":{"start_line":245,"start_character":4,"end_line":245,"end_character":29},"in_reply_to":"1aa78d24_b38297fe","updated":"2016-07-11 11:03:17.000000000","message":"Yes, this field is not part of the action at all","commit_id":"befb7c85d71c42a336aa8d4a1e0bc1ab58853c98"}],"vitrage/tests/unit/evaluator/recipes/test_mark_down.py":[{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"8d83a06da121766acad7a25db3dcf8b5257d5242","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.assertEqual(2, len(update_vertex_step_params))"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        is_marked_down \u003d update_vertex_step_params[VProps.IS_MARKED_DOWN]"},{"line_number":75,"context_line":"        self.assertEqual(False, is_marked_down)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        vitrage_id \u003d update_vertex_step_params[VProps.VITRAGE_ID]"},{"line_number":78,"context_line":"        self.assertEqual(self.target_vertex.vertex_id, vitrage_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_295638d2","line":75,"range":{"start_line":75,"start_character":13,"end_line":75,"end_character":24},"updated":"2016-07-11 11:13:11.000000000","message":"use assertFalse","commit_id":"36d7b585ebfa63d47273f62b5b4c494427431c91"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"77a0b1feace3e24a673126cf4256a1cc705cba05","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.assertEqual(2, len(update_vertex_step_params))"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        is_marked_down \u003d update_vertex_step_params[VProps.IS_MARKED_DOWN]"},{"line_number":75,"context_line":"        self.assertEqual(False, is_marked_down)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        vitrage_id \u003d update_vertex_step_params[VProps.VITRAGE_ID]"},{"line_number":78,"context_line":"        self.assertEqual(self.target_vertex.vertex_id, vitrage_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_c9e21401","line":75,"range":{"start_line":75,"start_character":13,"end_line":75,"end_character":24},"in_reply_to":"1aa78d24_295638d2","updated":"2016-07-11 11:14:47.000000000","message":"Done","commit_id":"36d7b585ebfa63d47273f62b5b4c494427431c91"}]}
