)]}'
{"vitrage/datasources/transformer_base.py":[{"author":{"_account_id":19209,"name":"Liat","email":"liat.har-tal@nokia.com","username":"liat"},"change_message_id":"c3e04ea40cb620a59c9db744e31e6526142d1a17","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    def _create_entity_vertex(self, entity_event):"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        if is_update_event(entity_event):"},{"line_number":132,"context_line":"            if self.get_type() in self.conf and \\"},{"line_number":133,"context_line":"                    \u0027update_method\u0027 in self.conf[self.get_type()]:"},{"line_number":134,"context_line":"                if self.conf[self.get_type()].update_method.lower() \u003d\u003d \\"},{"line_number":135,"context_line":"                        UpdateMethod.PUSH:"},{"line_number":136,"context_line":"                    return self._create_update_entity_vertex(entity_event)"},{"line_number":137,"context_line":"                elif self.conf[self.get_type()].update_method.lower() \u003d\u003d\\"},{"line_number":138,"context_line":"                        UpdateMethod.PULL:"},{"line_number":139,"context_line":"                    return self._create_snapshot_entity_vertex(entity_event)"},{"line_number":140,"context_line":"                else:"},{"line_number":141,"context_line":"                    LOG.error(\u0027Update event arrived for dataresource that is \u0027"},{"line_number":142,"context_line":"                              \u0027defined without updates\u0027)"},{"line_number":143,"context_line":"            else:"},{"line_number":144,"context_line":"                return self._create_snapshot_entity_vertex(entity_event)"},{"line_number":145,"context_line":"        else:"},{"line_number":146,"context_line":"            return self._create_snapshot_entity_vertex(entity_event)"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_2ea27c4b","line":144,"range":{"start_line":132,"start_character":12,"end_line":144,"end_character":72},"updated":"2016-08-11 08:10:31.000000000","message":"I think it might be more readable:\n\nif self.get_type() in self.conf:\n\t\n\tds_type \u003d self.get_type()\n\tds_conf \u003d self.conf[self.get_type()]\n\t\n\tif \u0027update_method\u0027 in ds_conf:\n\t\tds_update_method \u003d self.conf[self.get_type()].update_method.lower()\n\t\t\n\t\tif ds_update_method \u003d\u003d UpdateMethod.PUSH:\n            return self._create_update_entity_vertex(entity_event)\n        elif ds_update_method \u003d\u003d UpdateMethod.PULL:\n            return self._create_snapshot_entity_vertex(entity_event)\n\t\telse:\n\t\t\tLOG.error(\u0027Update event arrived for dataresource that is \u0027\n\t\t\t\t\t  \u0027defined without updates\u0027)\n\t\nreturn self._create_snapshot_entity_vertex(entity_event)","commit_id":"03b9ca5b0bd20299ea09e03ec53f6e254aed976c"},{"author":{"_account_id":20667,"name":"Noam Bloom","email":"noam00bloom@gmail.com","username":"nbloom"},"change_message_id":"db7e0c4d12aa416c26aaeb48876863c72d340e1d","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    def _create_entity_vertex(self, entity_event):"},{"line_number":130,"context_line":"        if is_update_event(entity_event) and \\"},{"line_number":131,"context_line":"                self.get_type() in self.conf and \\"},{"line_number":132,"context_line":"                \u0027update_method\u0027 in self.conf[self.get_type()]:"},{"line_number":133,"context_line":"            update_method \u003d self.conf[self.get_type()].update_method.lower()"},{"line_number":134,"context_line":"            if update_method \u003d\u003d UpdateMethod.PUSH:"},{"line_number":135,"context_line":"                return self._create_update_entity_vertex(entity_event)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_6725b707","line":132,"range":{"start_line":132,"start_character":16,"end_line":132,"end_character":62},"updated":"2016-08-11 08:58:00.000000000","message":"Consider using utils.opt_exists(self.conf[self.get_type()], \u0027update_method\u0027)","commit_id":"e8201f16c8e60d19cb0de8719b947d04c5f627a2"},{"author":{"_account_id":20667,"name":"Noam Bloom","email":"noam00bloom@gmail.com","username":"nbloom"},"change_message_id":"db7e0c4d12aa416c26aaeb48876863c72d340e1d","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                return self._create_update_entity_vertex(entity_event)"},{"line_number":136,"context_line":"            elif update_method \u003d\u003d UpdateMethod.PULL:"},{"line_number":137,"context_line":"                return self._create_snapshot_entity_vertex(entity_event)"},{"line_number":138,"context_line":"            else:"},{"line_number":139,"context_line":"                LOG.error(\u0027Update event arrived for dataresource that is \u0027"},{"line_number":140,"context_line":"                          \u0027defined without updates\u0027)"},{"line_number":141,"context_line":"        else:"},{"line_number":142,"context_line":"            return self._create_snapshot_entity_vertex(entity_event)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_87dd4be2","line":140,"range":{"start_line":138,"start_character":11,"end_line":140,"end_character":52},"updated":"2016-08-11 08:58:00.000000000","message":"Should also check for UpdateMethod.NONE. Otherwise, we should remove it as a possibility altogether.","commit_id":"e8201f16c8e60d19cb0de8719b947d04c5f627a2"}]}