)]}'
{"vitrage/tests/unit/datasources/nagios/test_nagios_transformer.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"a7a89195f053eacbc080509193dd710226004a4f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        nagios_alarms \u003d mock_sync.generate_sequential_events_list(spec_list)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        for alarm in nagios_alarms:"},{"line_number":90,"context_line":"            if alarm[NagiosProperties.STATUS] \u003d\u003d NagiosTestStatus.OK:"},{"line_number":91,"context_line":"                alarm[DSProps.EVENT_TYPE] \u003d GraphAction.DELETE_ENTITY"},{"line_number":92,"context_line":"            # Test action"},{"line_number":93,"context_line":"            wrapper \u003d NagiosTransformer(self.transformers, self.conf).\\"},{"line_number":94,"context_line":"                transform(alarm)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_2ce46eaa","line":91,"range":{"start_line":90,"start_character":0,"end_line":91,"end_character":69},"updated":"2016-12-05 15:26:11.000000000","message":"I finally understood what happened. \n\nThe ok-\u003edelete logic was part of the transformer, and you moved it to the driver. This is a transformer test, so there is no use in checking it here any longer. You actually add the DELETE_ENTITY here, and check that it exists a few lines below - of course it will exist, you just added it.\n\nThe ok-\u003edelete test should be moved to the driver test. Unfortunately, test_nagios_driver is written using a different mock... but it does contain a lot of tests that verify that alarms are being added and deleted at the right time according to their status. \n\nBottom line - I think you should remove the test from this file after all (sorry for changing my mind :-)). It might be a good idea to copy-paste only the \"OK\" part to the driver test file, but not if it is too complicated.","commit_id":"75c1942eb936e1ae517f236cf03b9b8609884466"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"17e4a87a17fb9300038948f0d9e3159fe70e1b0a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        nagios_alarms \u003d mock_sync.generate_sequential_events_list(spec_list)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        for alarm in nagios_alarms:"},{"line_number":90,"context_line":"            if alarm[NagiosProperties.STATUS] \u003d\u003d NagiosTestStatus.OK:"},{"line_number":91,"context_line":"                alarm[DSProps.EVENT_TYPE] \u003d GraphAction.DELETE_ENTITY"},{"line_number":92,"context_line":"            # Test action"},{"line_number":93,"context_line":"            wrapper \u003d NagiosTransformer(self.transformers, self.conf).\\"},{"line_number":94,"context_line":"                transform(alarm)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_f41302b6","line":91,"range":{"start_line":90,"start_character":0,"end_line":91,"end_character":69},"in_reply_to":"3a71b18c_2ce46eaa","updated":"2016-12-06 02:03:18.000000000","message":"You are right.I\u0027ll try to fix it in the driver, thanks.","commit_id":"75c1942eb936e1ae517f236cf03b9b8609884466"}]}