)]}'
{"vitrage/evaluator/scenario_evaluator.py":[{"author":{"_account_id":19233,"name":"Elisha Rosensweig","email":"elisha@chorus.ai","username":"elisha.rosensweig"},"change_message_id":"4284ed7d3026154f5ff14dc66300dbea6a0af0d3","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                edge_query_dict\u003d{\u0027!\u003d\u0027: {NEG_CONDITION: True}})"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"            is_switch_mode \u003d \\"},{"line_number":273,"context_line":"                connected_component.get_vertex(scenario_vertex.vertex_id)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"            if is_switch_mode:"},{"line_number":276,"context_line":"                initial_map \u003d Mapping(scenario_vertex, vertex, True)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f013ff3_87cbfca3","line":273,"updated":"2017-05-15 07:15:41.000000000","message":"A complete solution to \"OR\" clauses needs to account also for the fact that the different components of this condition can match the trigger vertex for different reasons. So looking at the vertex_id is not sufficient.\n\nThe best solution is to have the scenario repo index each of the components of an \"OR\" condition separately. This would solve it for both vertex and edge in a straightforward and elegant way","commit_id":"c15d47ff0dcfe7f0d753e5b298e4fe7ce35009f3"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"be688bc284c4ac6bfe2672c63efbab7080742f40","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                edge_query_dict\u003d{\u0027!\u003d\u0027: {NEG_CONDITION: True}})"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"            is_switch_mode \u003d \\"},{"line_number":273,"context_line":"                connected_component.get_vertex(scenario_vertex.vertex_id)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"            if is_switch_mode:"},{"line_number":276,"context_line":"                initial_map \u003d Mapping(scenario_vertex, vertex, True)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_48f5f2ca","line":273,"in_reply_to":"1f013ff3_87cbfca3","updated":"2017-05-18 02:55:12.000000000","message":"Not sure if this is the same issue I have encountered in https://review.openstack.org/#/c/462533/11/vitrage/tests/unit/evaluator/test_template_data.py@a62\n\nHowever, before the best solution is agreed, I think this patch resolves a potential crash issue, doesn\u0027t it?\n\nThat is why I have given +1 to it.","commit_id":"c15d47ff0dcfe7f0d753e5b298e4fe7ce35009f3"}],"vitrage/tests/functional/evaluator/test_scenario_evaluator.py":[{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"d9bc7300001dd0164bf7fbe49f9b650679bb6cea","unresolved":false,"context_lines":[{"line_number":1106,"context_line":"        self.assertEqual(\u0027AVAILABLE\u0027, host_v[VProps.AGGREGATED_STATE],"},{"line_number":1107,"context_line":"                         \u0027host should be AVAILABLE when starting\u0027)"},{"line_number":1108,"context_line":""},{"line_number":1109,"context_line":"        # generate nagios alarm1 to trigger，raise alarm3"},{"line_number":1110,"context_line":"        test_vals \u003d {\u0027status\u0027: \u0027WARNING\u0027,"},{"line_number":1111,"context_line":"                     \u0027service\u0027: \u0027alarm1\u0027}"},{"line_number":1112,"context_line":"        test_vals.update(_NAGIOS_TEST_INFO)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_92a5b7a4","line":1109,"range":{"start_line":1109,"start_character":43,"end_line":1109,"end_character":44},"updated":"2017-04-30 00:33:27.000000000","message":"Is it a comma in Chinese ? It seems to be the cause of py27 failure.","commit_id":"d75cb4c2faac83f26c86bc0988161d8f096ed29b"}]}