)]}'
{"vitrage/evaluator/scenario_evaluator.py":[{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"e63bcc7603176108f0d64308c51dfabdbd94024a","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                actions_to_perform[key] \u003d new_dominant"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        # filter the same action"},{"line_number":250,"context_line":"        final_actions \u003d {}"},{"line_number":251,"context_line":"        for action in actions_to_perform.values():"},{"line_number":252,"context_line":"            action_id \u003d ScenarioEvaluator._generate_action_id(action.specs)"},{"line_number":253,"context_line":"            final_actions[action_id] \u003d action"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        return final_actions.values()"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def _find_vertex_subgraph_matching(self,"},{"line_number":258,"context_line":"                                       subgraphs,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_8c6509e4","line":255,"range":{"start_line":250,"start_character":8,"end_line":255,"end_character":37},"updated":"2017-05-21 11:50:46.000000000","message":"What is the difference between calculating the action_id here instead of calculating it like it was before?","commit_id":"f6acfbd9b42f6bc83f6893195bb2bfd598daeb7d"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"1f9b5b7395164890ba189c0396b6c73d06b98cf3","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                actions_to_perform[key] \u003d new_dominant"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        # filter the same action"},{"line_number":250,"context_line":"        final_actions \u003d {}"},{"line_number":251,"context_line":"        for action in actions_to_perform.values():"},{"line_number":252,"context_line":"            action_id \u003d ScenarioEvaluator._generate_action_id(action.specs)"},{"line_number":253,"context_line":"            final_actions[action_id] \u003d action"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        return final_actions.values()"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def _find_vertex_subgraph_matching(self,"},{"line_number":258,"context_line":"                                       subgraphs,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_a90c1041","line":255,"range":{"start_line":250,"start_character":8,"end_line":255,"end_character":37},"in_reply_to":"ff0f0b1f_80094832","updated":"2017-05-23 05:19:18.000000000","message":"you meant that \"Calculating the action_id here: _action_tracker has only one action(Two conditions(alarm_a and alarm_c, alarm_b and alarm_c) are merged into one action by action_id).\" is what the previous code did, right? (not the new one)","commit_id":"f6acfbd9b42f6bc83f6893195bb2bfd598daeb7d"},{"author":{"_account_id":24666,"name":"wang weiya","email":"wang.weiya@zte.com.cn","username":"wang.weiya"},"change_message_id":"c804f1f0286d347eec46d9340aeaf65f6ec2220d","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                actions_to_perform[key] \u003d new_dominant"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        # filter the same action"},{"line_number":250,"context_line":"        final_actions \u003d {}"},{"line_number":251,"context_line":"        for action in actions_to_perform.values():"},{"line_number":252,"context_line":"            action_id \u003d ScenarioEvaluator._generate_action_id(action.specs)"},{"line_number":253,"context_line":"            final_actions[action_id] \u003d action"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        return final_actions.values()"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def _find_vertex_subgraph_matching(self,"},{"line_number":258,"context_line":"                                       subgraphs,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_80094832","line":255,"range":{"start_line":250,"start_character":8,"end_line":255,"end_character":37},"in_reply_to":"ff0f0b1f_8c6509e4","updated":"2017-05-22 06:15:23.000000000","message":"Calculating the action_id here: _action_tracker has two\nactions(1. alarm_a and alarm_c match 2.alarm_b and alarm_c\nmatch).\nCalculating the action_id here:  _action_tracker has only\none action(Two conditions(alarm_a and alarm_c, alarm_b and alarm_c) are merged into one action by action_id).","commit_id":"f6acfbd9b42f6bc83f6893195bb2bfd598daeb7d"},{"author":{"_account_id":24666,"name":"wang weiya","email":"wang.weiya@zte.com.cn","username":"wang.weiya"},"change_message_id":"87a4c4e24f5cefd6df5a2b3d5b2603cf3a76565e","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                actions_to_perform[key] \u003d new_dominant"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        # filter the same action"},{"line_number":250,"context_line":"        final_actions \u003d {}"},{"line_number":251,"context_line":"        for action in actions_to_perform.values():"},{"line_number":252,"context_line":"            action_id \u003d ScenarioEvaluator._generate_action_id(action.specs)"},{"line_number":253,"context_line":"            final_actions[action_id] \u003d action"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        return final_actions.values()"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def _find_vertex_subgraph_matching(self,"},{"line_number":258,"context_line":"                                       subgraphs,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_64e17d2a","line":255,"range":{"start_line":250,"start_character":8,"end_line":255,"end_character":37},"in_reply_to":"ff0f0b1f_a90c1041","updated":"2017-05-23 05:43:22.000000000","message":"Right.","commit_id":"f6acfbd9b42f6bc83f6893195bb2bfd598daeb7d"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"4697746aa3363e048774011b69f5011c550e2e87","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                actions_to_perform[key] \u003d new_dominant"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        # filter the same action"},{"line_number":250,"context_line":"        final_actions \u003d {}"},{"line_number":251,"context_line":"        for action in actions_to_perform.values():"},{"line_number":252,"context_line":"            action_id \u003d ScenarioEvaluator._generate_action_id(action.specs)"},{"line_number":253,"context_line":"            final_actions[action_id] \u003d action"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        return final_actions.values()"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def _find_vertex_subgraph_matching(self,"},{"line_number":258,"context_line":"                                       subgraphs,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_68f36475","line":255,"range":{"start_line":250,"start_character":0,"end_line":255,"end_character":37},"updated":"2017-05-24 08:50:11.000000000","message":"I think you can write it in a shorter way:\nreturn {ScenarioEvaluator._generate_action_id(action.specs):action for action in actions_to_perform.values()}","commit_id":"7de93205041390e04aaed76a442694ac5e20c767"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"cfcea37322a46164e9264531a7212390b683dc15","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                actions_to_perform[key] \u003d new_dominant"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        # filter the same action"},{"line_number":250,"context_line":"        final_actions \u003d {}"},{"line_number":251,"context_line":"        for action in actions_to_perform.values():"},{"line_number":252,"context_line":"            action_id \u003d ScenarioEvaluator._generate_action_id(action.specs)"},{"line_number":253,"context_line":"            final_actions[action_id] \u003d action"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        return final_actions.values()"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def _find_vertex_subgraph_matching(self,"},{"line_number":258,"context_line":"                                       subgraphs,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_2327cd66","line":255,"range":{"start_line":250,"start_character":0,"end_line":255,"end_character":37},"in_reply_to":"ff0f0b1f_63870564","updated":"2017-05-24 09:04:21.000000000","message":"I must admit that I didn\u0027t test it... but you can still do:\nfinal_actions \u003d  {ScenarioEvaluator._generate_action_id(action.specs):action for action in actions_to_perform.values()}\nreturn final_actions.values()\n\nRight?","commit_id":"7de93205041390e04aaed76a442694ac5e20c767"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"0489d64b6fbba27d66732886218170f511c13f7a","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                actions_to_perform[key] \u003d new_dominant"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        # filter the same action"},{"line_number":250,"context_line":"        final_actions \u003d {}"},{"line_number":251,"context_line":"        for action in actions_to_perform.values():"},{"line_number":252,"context_line":"            action_id \u003d ScenarioEvaluator._generate_action_id(action.specs)"},{"line_number":253,"context_line":"            final_actions[action_id] \u003d action"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        return final_actions.values()"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def _find_vertex_subgraph_matching(self,"},{"line_number":258,"context_line":"                                       subgraphs,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_63870564","line":255,"range":{"start_line":250,"start_character":0,"end_line":255,"end_character":37},"in_reply_to":"ff0f0b1f_68f36475","updated":"2017-05-24 08:59:30.000000000","message":"I think .values() returns a **list** and you are suggesting a **dict** comprehension, is that so?","commit_id":"7de93205041390e04aaed76a442694ac5e20c767"}],"vitrage/tests/functional/evaluator/test_scenario_evaluator.py":[{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"e63bcc7603176108f0d64308c51dfabdbd94024a","unresolved":false,"context_lines":[{"line_number":1177,"context_line":"        host_v \u003d self.get_host_after_event(event_queue, alarm_a_test,"},{"line_number":1178,"context_line":"                                           processor, _TARGET_HOST)"},{"line_number":1179,"context_line":"        alarms \u003d self._get_alarms_on_host(host_v, processor.entity_graph)"},{"line_number":1180,"context_line":"        self.assertEqual(1, len(alarms))"},{"line_number":1181,"context_line":""},{"line_number":1182,"context_line":"        # generate nagios alarm_b to trigger"},{"line_number":1183,"context_line":"        test_vals \u003d {\u0027status\u0027: \u0027WARNING\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_eca5a505","line":1180,"updated":"2017-05-21 11:50:46.000000000","message":"please add assertion that also checks the total number of vertices and edges in the graph. (should be +1 vertices, +1 edges)","commit_id":"f6acfbd9b42f6bc83f6893195bb2bfd598daeb7d"},{"author":{"_account_id":24666,"name":"wang weiya","email":"wang.weiya@zte.com.cn","username":"wang.weiya"},"change_message_id":"c804f1f0286d347eec46d9340aeaf65f6ec2220d","unresolved":false,"context_lines":[{"line_number":1177,"context_line":"        host_v \u003d self.get_host_after_event(event_queue, alarm_a_test,"},{"line_number":1178,"context_line":"                                           processor, _TARGET_HOST)"},{"line_number":1179,"context_line":"        alarms \u003d self._get_alarms_on_host(host_v, processor.entity_graph)"},{"line_number":1180,"context_line":"        self.assertEqual(1, len(alarms))"},{"line_number":1181,"context_line":""},{"line_number":1182,"context_line":"        # generate nagios alarm_b to trigger"},{"line_number":1183,"context_line":"        test_vals \u003d {\u0027status\u0027: \u0027WARNING\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_96c62f9a","line":1180,"in_reply_to":"ff0f0b1f_eca5a505","updated":"2017-05-22 06:15:23.000000000","message":"Done","commit_id":"f6acfbd9b42f6bc83f6893195bb2bfd598daeb7d"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"e63bcc7603176108f0d64308c51dfabdbd94024a","unresolved":false,"context_lines":[{"line_number":1189,"context_line":"        host_v \u003d self.get_host_after_event(event_queue, alarm_b_test,"},{"line_number":1190,"context_line":"                                           processor, _TARGET_HOST)"},{"line_number":1191,"context_line":"        alarms \u003d self._get_alarms_on_host(host_v, processor.entity_graph)"},{"line_number":1192,"context_line":"        self.assertEqual(2, len(alarms))"},{"line_number":1193,"context_line":""},{"line_number":1194,"context_line":"        # generate nagios alarm_c to trigger, alarm_d is raised"},{"line_number":1195,"context_line":"        test_vals \u003d {\u0027status\u0027: \u0027WARNING\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_cca8a1dc","line":1192,"updated":"2017-05-21 11:50:46.000000000","message":"please add assertion that also checks the total number of vertices and edges in the graph. (should be +2 vertices, +2 edges)","commit_id":"f6acfbd9b42f6bc83f6893195bb2bfd598daeb7d"},{"author":{"_account_id":24666,"name":"wang weiya","email":"wang.weiya@zte.com.cn","username":"wang.weiya"},"change_message_id":"c804f1f0286d347eec46d9340aeaf65f6ec2220d","unresolved":false,"context_lines":[{"line_number":1189,"context_line":"        host_v \u003d self.get_host_after_event(event_queue, alarm_b_test,"},{"line_number":1190,"context_line":"                                           processor, _TARGET_HOST)"},{"line_number":1191,"context_line":"        alarms \u003d self._get_alarms_on_host(host_v, processor.entity_graph)"},{"line_number":1192,"context_line":"        self.assertEqual(2, len(alarms))"},{"line_number":1193,"context_line":""},{"line_number":1194,"context_line":"        # generate nagios alarm_c to trigger, alarm_d is raised"},{"line_number":1195,"context_line":"        test_vals \u003d {\u0027status\u0027: \u0027WARNING\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_76c15b80","line":1192,"in_reply_to":"ff0f0b1f_cca8a1dc","updated":"2017-05-22 06:15:23.000000000","message":"Done","commit_id":"f6acfbd9b42f6bc83f6893195bb2bfd598daeb7d"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"e63bcc7603176108f0d64308c51dfabdbd94024a","unresolved":false,"context_lines":[{"line_number":1201,"context_line":"        host_v \u003d self.get_host_after_event(event_queue, alarm_c_test,"},{"line_number":1202,"context_line":"                                           processor, _TARGET_HOST)"},{"line_number":1203,"context_line":"        alarms \u003d self._get_alarms_on_host(host_v, processor.entity_graph)"},{"line_number":1204,"context_line":"        self.assertEqual(4, len(alarms))"},{"line_number":1205,"context_line":""},{"line_number":1206,"context_line":"        # remove nagios alarm_b, alarm_d should not be removed"},{"line_number":1207,"context_line":"        test_vals \u003d {\u0027status\u0027: \u0027OK\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_acafade1","line":1204,"updated":"2017-05-21 11:50:46.000000000","message":"please add assertion that also checks the total number of vertices and edges in the graph. (should be +4 vertices, +4 edges)","commit_id":"f6acfbd9b42f6bc83f6893195bb2bfd598daeb7d"},{"author":{"_account_id":24666,"name":"wang weiya","email":"wang.weiya@zte.com.cn","username":"wang.weiya"},"change_message_id":"c804f1f0286d347eec46d9340aeaf65f6ec2220d","unresolved":false,"context_lines":[{"line_number":1201,"context_line":"        host_v \u003d self.get_host_after_event(event_queue, alarm_c_test,"},{"line_number":1202,"context_line":"                                           processor, _TARGET_HOST)"},{"line_number":1203,"context_line":"        alarms \u003d self._get_alarms_on_host(host_v, processor.entity_graph)"},{"line_number":1204,"context_line":"        self.assertEqual(4, len(alarms))"},{"line_number":1205,"context_line":""},{"line_number":1206,"context_line":"        # remove nagios alarm_b, alarm_d should not be removed"},{"line_number":1207,"context_line":"        test_vals \u003d {\u0027status\u0027: \u0027OK\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_36bbe30e","line":1204,"in_reply_to":"ff0f0b1f_acafade1","updated":"2017-05-22 06:15:23.000000000","message":"Done","commit_id":"f6acfbd9b42f6bc83f6893195bb2bfd598daeb7d"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"e63bcc7603176108f0d64308c51dfabdbd94024a","unresolved":false,"context_lines":[{"line_number":1213,"context_line":"        host_v \u003d self.get_host_after_event(event_queue, alarm_b_ok,"},{"line_number":1214,"context_line":"                                           processor, _TARGET_HOST)"},{"line_number":1215,"context_line":"        alarms \u003d self._get_alarms_on_host(host_v, processor.entity_graph)"},{"line_number":1216,"context_line":"        self.assertEqual(3, len(alarms))"},{"line_number":1217,"context_line":""},{"line_number":1218,"context_line":"    def get_host_after_event(self, event_queue, nagios_event,"},{"line_number":1219,"context_line":"                             processor, target_host):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_8caaa9cf","line":1216,"updated":"2017-05-21 11:50:46.000000000","message":"please add assertion that also checks the total number of vertices and edges in the graph. (should be +3 vertices, +3 edges)","commit_id":"f6acfbd9b42f6bc83f6893195bb2bfd598daeb7d"},{"author":{"_account_id":24666,"name":"wang weiya","email":"wang.weiya@zte.com.cn","username":"wang.weiya"},"change_message_id":"c804f1f0286d347eec46d9340aeaf65f6ec2220d","unresolved":false,"context_lines":[{"line_number":1213,"context_line":"        host_v \u003d self.get_host_after_event(event_queue, alarm_b_ok,"},{"line_number":1214,"context_line":"                                           processor, _TARGET_HOST)"},{"line_number":1215,"context_line":"        alarms \u003d self._get_alarms_on_host(host_v, processor.entity_graph)"},{"line_number":1216,"context_line":"        self.assertEqual(3, len(alarms))"},{"line_number":1217,"context_line":""},{"line_number":1218,"context_line":"    def get_host_after_event(self, event_queue, nagios_event,"},{"line_number":1219,"context_line":"                             processor, target_host):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_f63a0b96","line":1216,"in_reply_to":"ff0f0b1f_8caaa9cf","updated":"2017-05-22 06:15:23.000000000","message":"Done","commit_id":"f6acfbd9b42f6bc83f6893195bb2bfd598daeb7d"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"e63bcc7603176108f0d64308c51dfabdbd94024a","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"                                           processor, _TARGET_HOST)"},{"line_number":1215,"context_line":"        alarms \u003d self._get_alarms_on_host(host_v, processor.entity_graph)"},{"line_number":1216,"context_line":"        self.assertEqual(3, len(alarms))"},{"line_number":1217,"context_line":""},{"line_number":1218,"context_line":"    def get_host_after_event(self, event_queue, nagios_event,"},{"line_number":1219,"context_line":"                             processor, target_host):"},{"line_number":1220,"context_line":"        processor.process_event(nagios_event)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_4cb49135","line":1217,"updated":"2017-05-21 11:50:46.000000000","message":"please add also another step that removes alarm_a and see that only 1 vertex and 1 edges are added.","commit_id":"f6acfbd9b42f6bc83f6893195bb2bfd598daeb7d"},{"author":{"_account_id":24666,"name":"wang weiya","email":"wang.weiya@zte.com.cn","username":"wang.weiya"},"change_message_id":"c804f1f0286d347eec46d9340aeaf65f6ec2220d","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"                                           processor, _TARGET_HOST)"},{"line_number":1215,"context_line":"        alarms \u003d self._get_alarms_on_host(host_v, processor.entity_graph)"},{"line_number":1216,"context_line":"        self.assertEqual(3, len(alarms))"},{"line_number":1217,"context_line":""},{"line_number":1218,"context_line":"    def get_host_after_event(self, event_queue, nagios_event,"},{"line_number":1219,"context_line":"                             processor, target_host):"},{"line_number":1220,"context_line":"        processor.process_event(nagios_event)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_b644931c","line":1217,"in_reply_to":"ff0f0b1f_4cb49135","updated":"2017-05-22 06:15:23.000000000","message":"Done","commit_id":"f6acfbd9b42f6bc83f6893195bb2bfd598daeb7d"}],"vitrage/tests/resources/templates/evaluator/complex_and_or_operator_deduced_alarm.yaml":[{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"e63bcc7603176108f0d64308c51dfabdbd94024a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"     target: host"},{"line_number":42,"context_line":"     template_id : alarm_c_on_host"},{"line_number":43,"context_line":"scenarios:"},{"line_number":44,"context_line":" - scenario:"},{"line_number":45,"context_line":"    condition: alarm_a_on_host and alarm_c_on_host"},{"line_number":46,"context_line":"    actions:"},{"line_number":47,"context_line":"     - action:"},{"line_number":48,"context_line":"        action_type: raise_alarm"},{"line_number":49,"context_line":"        properties:"},{"line_number":50,"context_line":"         alarm_name: alarm_d"},{"line_number":51,"context_line":"         severity: WARNING"},{"line_number":52,"context_line":"        action_target:"},{"line_number":53,"context_line":"         target: host"},{"line_number":54,"context_line":" - scenario:"},{"line_number":55,"context_line":"    condition: alarm_b_on_host and alarm_c_on_host"},{"line_number":56,"context_line":"    actions:"},{"line_number":57,"context_line":"     - action:"},{"line_number":58,"context_line":"        action_type: raise_alarm"},{"line_number":59,"context_line":"        properties:"},{"line_number":60,"context_line":"         alarm_name: alarm_d"},{"line_number":61,"context_line":"         severity: WARNING"},{"line_number":62,"context_line":"        action_target:"},{"line_number":63,"context_line":"         target: host"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff0f0b1f_0c9fb9b4","line":63,"range":{"start_line":44,"start_character":0,"end_line":63,"end_character":21},"updated":"2017-05-21 11:50:46.000000000","message":"The condition is not the same as described in the test (in one liner). Thats true it is the same logically, but still.\nDoes this test work with previous code?","commit_id":"f6acfbd9b42f6bc83f6893195bb2bfd598daeb7d"},{"author":{"_account_id":24666,"name":"wang weiya","email":"wang.weiya@zte.com.cn","username":"wang.weiya"},"change_message_id":"c804f1f0286d347eec46d9340aeaf65f6ec2220d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"     target: host"},{"line_number":42,"context_line":"     template_id : alarm_c_on_host"},{"line_number":43,"context_line":"scenarios:"},{"line_number":44,"context_line":" - scenario:"},{"line_number":45,"context_line":"    condition: alarm_a_on_host and alarm_c_on_host"},{"line_number":46,"context_line":"    actions:"},{"line_number":47,"context_line":"     - action:"},{"line_number":48,"context_line":"        action_type: raise_alarm"},{"line_number":49,"context_line":"        properties:"},{"line_number":50,"context_line":"         alarm_name: alarm_d"},{"line_number":51,"context_line":"         severity: WARNING"},{"line_number":52,"context_line":"        action_target:"},{"line_number":53,"context_line":"         target: host"},{"line_number":54,"context_line":" - scenario:"},{"line_number":55,"context_line":"    condition: alarm_b_on_host and alarm_c_on_host"},{"line_number":56,"context_line":"    actions:"},{"line_number":57,"context_line":"     - action:"},{"line_number":58,"context_line":"        action_type: raise_alarm"},{"line_number":59,"context_line":"        properties:"},{"line_number":60,"context_line":"         alarm_name: alarm_d"},{"line_number":61,"context_line":"         severity: WARNING"},{"line_number":62,"context_line":"        action_target:"},{"line_number":63,"context_line":"         target: host"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff0f0b1f_1b9c8dbe","line":63,"range":{"start_line":44,"start_character":0,"end_line":63,"end_character":21},"in_reply_to":"ff0f0b1f_0c9fb9b4","updated":"2017-05-22 06:15:23.000000000","message":"Writing the condition in one line will trigger the problem we already solved: https://review.openstack.org/#/c/460410/\n\nWriting condition in one scenario or two scenarios have the same problem with _action_tracker.","commit_id":"f6acfbd9b42f6bc83f6893195bb2bfd598daeb7d"},{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"1f9b5b7395164890ba189c0396b6c73d06b98cf3","unresolved":false,"context_lines":[{"line_number":41,"context_line":"     target: host"},{"line_number":42,"context_line":"     template_id : alarm_c_on_host"},{"line_number":43,"context_line":"scenarios:"},{"line_number":44,"context_line":" - scenario:"},{"line_number":45,"context_line":"    condition: alarm_a_on_host and alarm_c_on_host"},{"line_number":46,"context_line":"    actions:"},{"line_number":47,"context_line":"     - action:"},{"line_number":48,"context_line":"        action_type: raise_alarm"},{"line_number":49,"context_line":"        properties:"},{"line_number":50,"context_line":"         alarm_name: alarm_d"},{"line_number":51,"context_line":"         severity: WARNING"},{"line_number":52,"context_line":"        action_target:"},{"line_number":53,"context_line":"         target: host"},{"line_number":54,"context_line":" - scenario:"},{"line_number":55,"context_line":"    condition: alarm_b_on_host and alarm_c_on_host"},{"line_number":56,"context_line":"    actions:"},{"line_number":57,"context_line":"     - action:"},{"line_number":58,"context_line":"        action_type: raise_alarm"},{"line_number":59,"context_line":"        properties:"},{"line_number":60,"context_line":"         alarm_name: alarm_d"},{"line_number":61,"context_line":"         severity: WARNING"},{"line_number":62,"context_line":"        action_target:"},{"line_number":63,"context_line":"         target: host"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff0f0b1f_242f058f","line":63,"range":{"start_line":44,"start_character":0,"end_line":63,"end_character":21},"in_reply_to":"ff0f0b1f_1b9c8dbe","updated":"2017-05-23 05:19:18.000000000","message":"I see what you mean, But the purpose of the test is to see that the problem is solved, and thus you should write the condition in one liner.","commit_id":"f6acfbd9b42f6bc83f6893195bb2bfd598daeb7d"},{"author":{"_account_id":24666,"name":"wang weiya","email":"wang.weiya@zte.com.cn","username":"wang.weiya"},"change_message_id":"87a4c4e24f5cefd6df5a2b3d5b2603cf3a76565e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"     target: host"},{"line_number":42,"context_line":"     template_id : alarm_c_on_host"},{"line_number":43,"context_line":"scenarios:"},{"line_number":44,"context_line":" - scenario:"},{"line_number":45,"context_line":"    condition: alarm_a_on_host and alarm_c_on_host"},{"line_number":46,"context_line":"    actions:"},{"line_number":47,"context_line":"     - action:"},{"line_number":48,"context_line":"        action_type: raise_alarm"},{"line_number":49,"context_line":"        properties:"},{"line_number":50,"context_line":"         alarm_name: alarm_d"},{"line_number":51,"context_line":"         severity: WARNING"},{"line_number":52,"context_line":"        action_target:"},{"line_number":53,"context_line":"         target: host"},{"line_number":54,"context_line":" - scenario:"},{"line_number":55,"context_line":"    condition: alarm_b_on_host and alarm_c_on_host"},{"line_number":56,"context_line":"    actions:"},{"line_number":57,"context_line":"     - action:"},{"line_number":58,"context_line":"        action_type: raise_alarm"},{"line_number":59,"context_line":"        properties:"},{"line_number":60,"context_line":"         alarm_name: alarm_d"},{"line_number":61,"context_line":"         severity: WARNING"},{"line_number":62,"context_line":"        action_target:"},{"line_number":63,"context_line":"         target: host"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff0f0b1f_04a9a18e","line":63,"range":{"start_line":44,"start_character":0,"end_line":63,"end_character":21},"in_reply_to":"ff0f0b1f_242f058f","updated":"2017-05-23 05:43:22.000000000","message":"Done","commit_id":"f6acfbd9b42f6bc83f6893195bb2bfd598daeb7d"}]}