)]}' {"doc/source/alarm-severity-config.rst":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"8e6e36272734ea55fa50e71cbfc8e55c21ae6ff7","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":".. code:: yaml"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":" vitrage_category: ALARM"},{"line_number":76,"context_line":" values:"},{"line_number":77,"context_line":" - aggregated values:"},{"line_number":78,"context_line":" priority: \u003cAlarm severity priority - an integer\u003e"}],"source_content_type":"text/x-rst","patch_set":14,"id":"7f231b9d_10596359","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":12},"updated":"2017-06-12 07:47:13.000000000","message":"Remove the vitrage_","commit_id":"b60681f4d8c7b0c24d43794fce5927c47ab2c816"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"8e6e36272734ea55fa50e71cbfc8e55c21ae6ff7","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":".. code:: yaml"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":" vitrage_category: ALARM"},{"line_number":103,"context_line":" values:"},{"line_number":104,"context_line":" - aggregated values:"},{"line_number":105,"context_line":" priority: 40"}],"source_content_type":"text/x-rst","patch_set":14,"id":"7f231b9d_3021ffb5","line":102,"range":{"start_line":102,"start_character":4,"end_line":102,"end_character":12},"updated":"2017-06-12 07:47:13.000000000","message":"Same here","commit_id":"b60681f4d8c7b0c24d43794fce5927c47ab2c816"}],"doc/source/host_high_memory_consumption.yaml":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"definitions:"},{"line_number":4,"context_line":" entities:"},{"line_number":5,"context_line":" - entity:"},{"line_number":6,"context_line":" vitrage_category: ALARM"},{"line_number":7,"context_line":" vitrage_type: nagios"},{"line_number":8,"context_line":" name: \u0027Memory used\u0027"},{"line_number":9,"context_line":" template_id: host_alarm"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"df140735_959d8abd","line":6,"updated":"2017-06-06 14:53:22.000000000","message":"Back to category ... Same with the following entities","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":4,"context_line":" entities:"},{"line_number":5,"context_line":" - entity:"},{"line_number":6,"context_line":" vitrage_category: ALARM"},{"line_number":7,"context_line":" vitrage_type: nagios"},{"line_number":8,"context_line":" name: \u0027Memory used\u0027"},{"line_number":9,"context_line":" template_id: host_alarm"},{"line_number":10,"context_line":" - entity:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"df140735_75a0b6f4","line":7,"updated":"2017-06-06 14:53:22.000000000","message":"Back to type - Same with the following entities","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}],"doc/source/nagios-config.rst":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"8e6e36272734ea55fa50e71cbfc8e55c21ae6ff7","unresolved":false,"context_lines":[{"line_number":47,"context_line":"Nagios tests are defined in a table with columns: Host, Service, Status, Last"},{"line_number":48,"context_line":"Check, etc."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"A Nagios \"host\" is not necessarily a resource of vitrage_type \"nova.host\". It can also"},{"line_number":51,"context_line":"be an instance, switch, or other resource types. **nagios_conf.yaml** is used"},{"line_number":52,"context_line":"to map each Nagios host to a Vitrage resource."},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"7f231b9d_102e03a5","line":50,"range":{"start_line":50,"start_character":49,"end_line":50,"end_character":57},"updated":"2017-06-12 07:47:13.000000000","message":"Remove the vitrage_?","commit_id":"b60681f4d8c7b0c24d43794fce5927c47ab2c816"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"8e6e36272734ea55fa50e71cbfc8e55c21ae6ff7","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"The following file will"},{"line_number":96,"context_line":" - map all Nagios hosts named ``host-\u003csome_suffix\u003e`` or ``\u003csome_prefix\u003e-devstack``"},{"line_number":97,"context_line":" to resources of vitrage_type ``nova.host`` with the same name."},{"line_number":98,"context_line":" - map all Nagios hosts named ``instance-\u003csome_suffix\u003e`` to ``nova.instance``"},{"line_number":99,"context_line":" resources."},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"7f231b9d_f02a678e","line":97,"range":{"start_line":97,"start_character":19,"end_line":97,"end_character":27},"updated":"2017-06-12 07:47:13.000000000","message":"Remove the vitrage_?","commit_id":"b60681f4d8c7b0c24d43794fce5927c47ab2c816"}],"doc/source/not_operator_support.rst":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":77,"context_line":" definitions:"},{"line_number":78,"context_line":" entities:"},{"line_number":79,"context_line":" - entity:"},{"line_number":80,"context_line":" vitrage_category: ALARM"},{"line_number":81,"context_line":" vitrage_type: instance_mem_performance_problem"},{"line_number":82,"context_line":" template_id: instance_alarm # some string"},{"line_number":83,"context_line":" - entity:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"df140735_f547261c","line":80,"updated":"2017-06-06 14:53:22.000000000","message":"Back to category - same with all other entities in this rst","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":78,"context_line":" entities:"},{"line_number":79,"context_line":" - entity:"},{"line_number":80,"context_line":" vitrage_category: ALARM"},{"line_number":81,"context_line":" vitrage_type: instance_mem_performance_problem"},{"line_number":82,"context_line":" template_id: instance_alarm # some string"},{"line_number":83,"context_line":" - entity:"},{"line_number":84,"context_line":" vitrage_category: RESOURCE"}],"source_content_type":"text/x-rst","patch_set":11,"id":"df140735_756556b4","line":81,"updated":"2017-06-06 14:53:22.000000000","message":"back to \"type\". Same with all other entities in this rst","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}],"doc/source/static-config.rst":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":61,"context_line":" definitions:"},{"line_number":62,"context_line":" entities: # list of resources, note that alarms can not be defined for contrast with Vitrage template"},{"line_number":63,"context_line":" - static_id: s1 # unique ID in static datasource, it will be referred in relationship definition"},{"line_number":64,"context_line":" vitrage_type: switch # resource type, could be any string, not limited to the type from existing datasource."},{"line_number":65,"context_line":" id: 12345 # resource ID, used together with ``vitrage_type`` to refer a resource in real world"},{"line_number":66,"context_line":" name: switch-1 # name, state and other properties are considered as metadata of the resource"},{"line_number":67,"context_line":" state: active # the state of the resource"}],"source_content_type":"text/x-rst","patch_set":11,"id":"df140735_c4bd9102","line":64,"updated":"2017-06-06 14:53:22.000000000","message":"Back to \"type\"","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":62,"context_line":" entities: # list of resources, note that alarms can not be defined for contrast with Vitrage template"},{"line_number":63,"context_line":" - static_id: s1 # unique ID in static datasource, it will be referred in relationship definition"},{"line_number":64,"context_line":" vitrage_type: switch # resource type, could be any string, not limited to the type from existing datasource."},{"line_number":65,"context_line":" id: 12345 # resource ID, used together with ``vitrage_type`` to refer a resource in real world"},{"line_number":66,"context_line":" name: switch-1 # name, state and other properties are considered as metadata of the resource"},{"line_number":67,"context_line":" state: active # the state of the resource"},{"line_number":68,"context_line":" ..."}],"source_content_type":"text/x-rst","patch_set":11,"id":"df140735_24420d10","line":65,"updated":"2017-06-06 14:53:22.000000000","message":"Back to \"type\"","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":67,"context_line":" state: active # the state of the resource"},{"line_number":68,"context_line":" ..."},{"line_number":69,"context_line":" - static_id: h1"},{"line_number":70,"context_line":" vitrage_type: nova.host # resource type could be from existing datasource"},{"line_number":71,"context_line":" id: 1 # resource ID, used together with ``vitrage_type`` to refer a resource in corresponding datasource"},{"line_number":72,"context_line":" state: active # the state of the resource"},{"line_number":73,"context_line":" purpose: CI # additional properties could be defined - if from existing datasource, it could be updated"}],"source_content_type":"text/x-rst","patch_set":11,"id":"df140735_a4b85d10","line":70,"updated":"2017-06-06 14:53:22.000000000","message":"Back to \"type\"","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":68,"context_line":" ..."},{"line_number":69,"context_line":" - static_id: h1"},{"line_number":70,"context_line":" vitrage_type: nova.host # resource type could be from existing datasource"},{"line_number":71,"context_line":" id: 1 # resource ID, used together with ``vitrage_type`` to refer a resource in corresponding datasource"},{"line_number":72,"context_line":" state: active # the state of the resource"},{"line_number":73,"context_line":" purpose: CI # additional properties could be defined - if from existing datasource, it could be updated"},{"line_number":74,"context_line":" ..."}],"source_content_type":"text/x-rst","patch_set":11,"id":"df140735_8439d9a4","line":71,"updated":"2017-06-06 14:53:22.000000000","message":"Back to \"type\"","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"8e6e36272734ea55fa50e71cbfc8e55c21ae6ff7","unresolved":false,"context_lines":[{"line_number":61,"context_line":" definitions:"},{"line_number":62,"context_line":" entities: # list of resources, note that alarms can not be defined for contrast with Vitrage template"},{"line_number":63,"context_line":" - static_id: s1 # unique ID in static datasource, it will be referred in relationship definition"},{"line_number":64,"context_line":" type: switch # resource vitrage type, could be any string, not limited to the type from existing datasource."},{"line_number":65,"context_line":" id: 12345 # resource ID, used together with ``vitrage_type`` to refer a resource in real world"},{"line_number":66,"context_line":" name: switch-1 # name, state and other properties are considered as metadata of the resource"},{"line_number":67,"context_line":" state: active # the state of the resource"}],"source_content_type":"text/x-rst","patch_set":14,"id":"7f231b9d_ba0ded38","line":64,"range":{"start_line":64,"start_character":39,"end_line":64,"end_character":46},"updated":"2017-06-12 07:47:13.000000000","message":"Remove the vitrage?","commit_id":"b60681f4d8c7b0c24d43794fce5927c47ab2c816"}],"doc/source/static-physical-config.rst":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":50,"context_line":" entities:"},{"line_number":51,"context_line":" - name: \u003cPhysical entity name as appears in configuration\u003e"},{"line_number":52,"context_line":" id: \u003cPhysical entity id as appears in configuration\u003e"},{"line_number":53,"context_line":" vitrage_type: \u003cPhysical entity type - see below for details\u003e"},{"line_number":54,"context_line":" state: \u003cdefault resource state\u003e"},{"line_number":55,"context_line":" relationships:"},{"line_number":56,"context_line":" - vitrage_type: \u003cPhysical entity type it is connected to - see below for details\u003e"}],"source_content_type":"text/x-rst","patch_set":11,"id":"df140735_044dc93c","line":53,"updated":"2017-06-06 14:53:22.000000000","message":"Back to \"type\"","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":53,"context_line":" vitrage_type: \u003cPhysical entity type - see below for details\u003e"},{"line_number":54,"context_line":" state: \u003cdefault resource state\u003e"},{"line_number":55,"context_line":" relationships:"},{"line_number":56,"context_line":" - vitrage_type: \u003cPhysical entity type it is connected to - see below for details\u003e"},{"line_number":57,"context_line":" name: \u003cName of physical entity as appears in configuration\u003e"},{"line_number":58,"context_line":" id: \u003cId of physical entity as appears in configuration\u003e"},{"line_number":59,"context_line":" relation_type: \u003cRelation name\u003e"}],"source_content_type":"text/x-rst","patch_set":11,"id":"df140735_e447751c","line":56,"updated":"2017-06-06 14:53:22.000000000","message":"Back to \"type\"","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":57,"context_line":" name: \u003cName of physical entity as appears in configuration\u003e"},{"line_number":58,"context_line":" id: \u003cId of physical entity as appears in configuration\u003e"},{"line_number":59,"context_line":" relation_type: \u003cRelation name\u003e"},{"line_number":60,"context_line":" - vitrage_type: ..."},{"line_number":61,"context_line":" ..."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"df140735_c45231de","line":60,"updated":"2017-06-06 14:53:22.000000000","message":"Back to \"type\"","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Notes:"},{"line_number":65,"context_line":" - The \"vitrage_type\" key must match the name of a type from an existing datasource."},{"line_number":66,"context_line":" - Type names appear, for each datasource, in its __init__.py file."},{"line_number":67,"context_line":" - For example see */workspace/dev/vitrage/vitrage/datasources/nova/host/__init__.py*"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"df140735_a44dfd3b","line":65,"updated":"2017-06-06 14:53:22.000000000","message":"Back to \"type\"","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":76,"context_line":".. code::"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":" entities:"},{"line_number":79,"context_line":" - vitrage_type: switch"},{"line_number":80,"context_line":" name: switch-1"},{"line_number":81,"context_line":" id: switch-1 # should be same as name"},{"line_number":82,"context_line":" state: available"}],"source_content_type":"text/x-rst","patch_set":11,"id":"df140735_8462f9ac","line":79,"updated":"2017-06-06 14:53:22.000000000","message":"Back to \"type\"","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":81,"context_line":" id: switch-1 # should be same as name"},{"line_number":82,"context_line":" state: available"},{"line_number":83,"context_line":" relationships:"},{"line_number":84,"context_line":" - vitrage_type: nova.host"},{"line_number":85,"context_line":" name: host-1"},{"line_number":86,"context_line":" id: host-1 # should be same as name"},{"line_number":87,"context_line":" relation_type: attached"}],"source_content_type":"text/x-rst","patch_set":11,"id":"df140735_6465a5b4","line":84,"updated":"2017-06-06 14:53:22.000000000","message":"Back to \"type\"","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":85,"context_line":" name: host-1"},{"line_number":86,"context_line":" id: host-1 # should be same as name"},{"line_number":87,"context_line":" relation_type: attached"},{"line_number":88,"context_line":" - vitrage_type: switch"},{"line_number":89,"context_line":" name: switch-2"},{"line_number":90,"context_line":" id: switch-2 # should be same as name"},{"line_number":91,"context_line":" relation_type: backup"}],"source_content_type":"text/x-rst","patch_set":11,"id":"df140735_445861f8","line":88,"updated":"2017-06-06 14:53:22.000000000","message":"Back to \"type\"","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}],"doc/source/template_validation_status_code.rst":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":30,"context_line":"+------------------+---------------------------------------------------------+-------------------------------+"},{"line_number":31,"context_line":"| 41 | Entity definition must contain template_id field | syntax |"},{"line_number":32,"context_line":"+------------------+---------------------------------------------------------+-------------------------------+"},{"line_number":33,"context_line":"| 42 | Entity definition must contain vitrage_category field | syntax |"},{"line_number":34,"context_line":"+------------------+---------------------------------------------------------+-------------------------------+"},{"line_number":35,"context_line":"| 43 | At least one entity must be defined | syntax |"},{"line_number":36,"context_line":"+------------------+---------------------------------------------------------+-------------------------------+"}],"source_content_type":"text/x-rst","patch_set":11,"id":"df140735_550c9292","line":33,"updated":"2017-06-06 14:53:22.000000000","message":"Think if you want to leave it his way","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"+------------------+---------------------------------------------------------+-------------------------------+"},{"line_number":35,"context_line":"| 43 | At least one entity must be defined | syntax |"},{"line_number":36,"context_line":"+------------------+---------------------------------------------------------+-------------------------------+"},{"line_number":37,"context_line":"| 45 | Invalid entity vitrage_category. Category must be from | syntax |"},{"line_number":38,"context_line":"| | types: [entities_categories] | |"},{"line_number":39,"context_line":"+------------------+---------------------------------------------------------+-------------------------------+"},{"line_number":40,"context_line":"| 46 | Entity field is required | syntax |"}],"source_content_type":"text/x-rst","patch_set":11,"id":"df140735_7519d6d4","line":37,"updated":"2017-06-06 14:53:22.000000000","message":"Think if you want to leave it his way","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}],"doc/source/vitrage-template-format.rst":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"df140735_353c7edf","updated":"2017-06-06 14:53:22.000000000","message":"Revert all changes to this file","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}],"vitrage/datasources/alarm_driver_base.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"8e6e36272734ea55fa50e71cbfc8e55c21ae6ff7","unresolved":false,"context_lines":[{"line_number":27,"context_line":" super(DriverBase, self).__init__()"},{"line_number":28,"context_line":" self.cache \u003d dict()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":" def _entity_vitrage_type(self):"},{"line_number":31,"context_line":" \"\"\"Return the vitrage_type of the datasource \"\"\""},{"line_number":32,"context_line":" pass"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_9a4a3125","line":30,"range":{"start_line":30,"start_character":8,"end_line":30,"end_character":28},"updated":"2017-06-12 07:47:13.000000000","message":"In transformer.py you renamed it to vitrage_type (without the entity). I think it is better.","commit_id":"b60681f4d8c7b0c24d43794fce5927c47ab2c816"}],"vitrage/datasources/collectd/driver.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"8e6e36272734ea55fa50e71cbfc8e55c21ae6ff7","unresolved":false,"context_lines":[{"line_number":37,"context_line":" CollectdDriver.conf_map \u003d \\"},{"line_number":38,"context_line":" CollectdDriver._configuration_mapping(conf)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":" def _entity_vitrage_type(self):"},{"line_number":41,"context_line":" return COLLECTD_DATASOURCE"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":" def _alarm_key(self, alarm):"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_1a0501c3","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":28},"updated":"2017-06-12 07:47:13.000000000","message":"Can be renamed to _vitrage_type?","commit_id":"b60681f4d8c7b0c24d43794fce5927c47ab2c816"}],"vitrage/datasources/doctor/driver.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"8e6e36272734ea55fa50e71cbfc8e55c21ae6ff7","unresolved":false,"context_lines":[{"line_number":37,"context_line":" self.conf \u003d conf"},{"line_number":38,"context_line":" self._client \u003d None"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":" def _entity_vitrage_type(self):"},{"line_number":41,"context_line":" return DOCTOR_DATASOURCE"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":" def _alarm_key(self, alarm):"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_9af8f1c4","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":28},"updated":"2017-06-12 07:47:13.000000000","message":"_vitrage_type?","commit_id":"b60681f4d8c7b0c24d43794fce5927c47ab2c816"}],"vitrage/datasources/nagios/config.py":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"NAGIOS_HOST \u003d \u0027nagios_host\u0027"},{"line_number":24,"context_line":"NAGIOS \u003d \u0027nagios\u0027"},{"line_number":25,"context_line":"HOST \u003d \u0027host\u0027"},{"line_number":26,"context_line":"VITRAGE_TYPE \u003d \u0027vitrage_type\u0027"},{"line_number":27,"context_line":"NAME \u003d \u0027name\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_701fa46b","line":26,"updated":"2017-06-06 14:53:22.000000000","message":"Why not from \"constants\" ?","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":42,"context_line":" @staticmethod"},{"line_number":43,"context_line":" def _create_mapping(config):"},{"line_number":44,"context_line":" return NagiosHostMapping(config[NAGIOS_HOST],"},{"line_number":45,"context_line":" config[VITRAGE_TYPE],"},{"line_number":46,"context_line":" config[NAME])"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":" def get_vitrage_resource(self, nagios_host):"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_10106856","line":45,"updated":"2017-06-06 14:53:22.000000000","message":"Why not from \"constants\" ?","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}],"vitrage/entity_graph/consistency/consistency_enforcer.py":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":96,"context_line":" \u0027Error in deleting vertices from entity_graph: %s\u0027, e)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":" def _find_stale_entities(self):"},{"line_number":99,"context_line":" sample_timestamp \u003d str(utcnow() - timedelta("},{"line_number":100,"context_line":" seconds\u003d2 * self.conf.datasources.snapshots_interval))"},{"line_number":101,"context_line":" query \u003d {"},{"line_number":102,"context_line":" \u0027and\u0027: ["}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_a4f61d5c","line":99,"updated":"2017-06-06 14:53:22.000000000","message":"sample_timestamp -\u003e vitrage_sample_timestamp (same as you did in the transformers)","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":101,"context_line":" query \u003d {"},{"line_number":102,"context_line":" \u0027and\u0027: ["},{"line_number":103,"context_line":" {\u0027!\u003d\u0027: {VProps.VITRAGE_TYPE: VITRAGE_TYPE}},"},{"line_number":104,"context_line":" {\u0027\u003c\u0027: {VProps.VITRAGE_SAMPLE_TIMESTAMP: sample_timestamp}},"},{"line_number":105,"context_line":" {\u0027\u003d\u003d\u0027: {VProps.VITRAGE_IS_DELETED: False}}"},{"line_number":106,"context_line":" ]"},{"line_number":107,"context_line":" }"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_649a4514","line":104,"updated":"2017-06-06 14:53:22.000000000","message":"sample_timestamp -\u003e vitrage_sample_timestamp (same as you did in the transformers)","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":111,"context_line":" return set(self._filter_vertices_to_be_deleted(vertices))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":" def _find_old_deleted_entities(self):"},{"line_number":114,"context_line":" sample_timestamp \u003d str(utcnow() - timedelta("},{"line_number":115,"context_line":" seconds\u003dself.conf.consistency.min_time_to_delete))"},{"line_number":116,"context_line":" query \u003d {"},{"line_number":117,"context_line":" \u0027and\u0027: ["}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_a715ff3e","line":114,"updated":"2017-06-06 14:53:22.000000000","message":"sample_timestamp -\u003e vitrage_sample_timestamp (same as you did in the transformers)","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":116,"context_line":" query \u003d {"},{"line_number":117,"context_line":" \u0027and\u0027: ["},{"line_number":118,"context_line":" {\u0027\u003d\u003d\u0027: {VProps.VITRAGE_IS_DELETED: True}},"},{"line_number":119,"context_line":" {\u0027\u003c\u0027: {VProps.VITRAGE_SAMPLE_TIMESTAMP: sample_timestamp}}"},{"line_number":120,"context_line":" ]"},{"line_number":121,"context_line":" }"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_872afb7b","line":119,"updated":"2017-06-06 14:53:22.000000000","message":"sample_timestamp -\u003e vitrage_sample_timestamp (same as you did in the transformers)","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"8e6e36272734ea55fa50e71cbfc8e55c21ae6ff7","unresolved":false,"context_lines":[{"line_number":97,"context_line":" \u0027Error in deleting vertices from entity_graph: %s\u0027, e)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":" def _find_stale_entities(self):"},{"line_number":100,"context_line":" vitrage_sample_tsmtp \u003d str(utcnow() - timedelta("},{"line_number":101,"context_line":" seconds\u003d2 * self.conf.datasources.snapshots_interval))"},{"line_number":102,"context_line":" query \u003d {"},{"line_number":103,"context_line":" \u0027and\u0027: ["}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_9aa2319a","line":100,"range":{"start_line":100,"start_character":23,"end_line":100,"end_character":28},"updated":"2017-06-12 07:47:13.000000000","message":"I prefer timestamp. But if not then it should be tstmp and not tsmtp :-)","commit_id":"b60681f4d8c7b0c24d43794fce5927c47ab2c816"}],"vitrage/entity_graph/mappings/datasource_info_mapper.py":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":63,"context_line":" value_properties \u003d \\"},{"line_number":64,"context_line":" self.category_normalizer[vitrage_category].value_properties()"},{"line_number":65,"context_line":" vitrage_operational_state, vitrage_aggregated_state, state_priority \u003d \\"},{"line_number":66,"context_line":" self._find_operational_state_and_priority(new_vertex,"},{"line_number":67,"context_line":" graph_vertex,"},{"line_number":68,"context_line":" value_properties[0],"},{"line_number":69,"context_line":" datasource_name)"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_c75233de","line":66,"updated":"2017-06-06 14:53:22.000000000","message":"Maybe _find_vitrage_operational_state_and_priority ?\nYou changed everywhere else in this class","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":" for property_ in value_properties:"},{"line_number":73,"context_line":" t_operational_state, t_aggregated_state, t_state_priority \u003d \\"},{"line_number":74,"context_line":" self._find_operational_state_and_priority(new_vertex,"},{"line_number":75,"context_line":" graph_vertex,"},{"line_number":76,"context_line":" property_,"},{"line_number":77,"context_line":" datasource_name)"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_a74dff3b","line":74,"updated":"2017-06-06 14:53:22.000000000","message":"Maybe _find_vitrage_operational_state_and_priority ?\nYou changed everywhere else in this class","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":197,"context_line":" LOG.error(\u0027Exception in datasource: %s\u0027, datasource_name)"},{"line_number":198,"context_line":" raise"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":" def _find_operational_state_and_priority(self,"},{"line_number":201,"context_line":" new_vertex,"},{"line_number":202,"context_line":" graph_vertex,"},{"line_number":203,"context_line":" property_,"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_67eec722","line":200,"updated":"2017-06-06 14:53:22.000000000","message":"maybe _find_vitrage_operational_state_and_priority?\nYou changed everywhere else in this class....","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}],"vitrage/evaluator/actions/priority_tools.py":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":53,"context_line":" def get_score(self, action_info):"},{"line_number":54,"context_line":" state \u003d action_info.specs.properties[TemplateFields.STATE].upper()"},{"line_number":55,"context_line":" target_resource \u003d action_info.specs.targets[TemplateFields.TARGET]"},{"line_number":56,"context_line":" target_type \u003d target_resource[VProps.VITRAGE_TYPE]"},{"line_number":57,"context_line":" score_name \u003d \\"},{"line_number":58,"context_line":" target_type if target_type in self.scores else DEFAULT_INFO_MAPPER"},{"line_number":59,"context_line":" return self.scores[score_name].get(state, 0)"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_7a865e68","line":56,"updated":"2017-06-06 14:53:22.000000000","message":"target_vitrage_type ?","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":55,"context_line":" target_resource \u003d action_info.specs.targets[TemplateFields.TARGET]"},{"line_number":56,"context_line":" target_type \u003d target_resource[VProps.VITRAGE_TYPE]"},{"line_number":57,"context_line":" score_name \u003d \\"},{"line_number":58,"context_line":" target_type if target_type in self.scores else DEFAULT_INFO_MAPPER"},{"line_number":59,"context_line":" return self.scores[score_name].get(state, 0)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":" @staticmethod"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_1a7f6266","line":58,"updated":"2017-06-06 14:53:22.000000000","message":"target_vitrage_type ?","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}],"vitrage/evaluator/equivalence_data.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"8e6e36272734ea55fa50e71cbfc8e55c21ae6ff7","unresolved":false,"context_lines":[{"line_number":38,"context_line":" return self._equivalences"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":" @staticmethod"},{"line_number":41,"context_line":" def _convert_props(properties):"},{"line_number":42,"context_line":" converted_properties \u003d set()"},{"line_number":43,"context_line":" for key, value in properties:"},{"line_number":44,"context_line":" new_key \u003d TemplateData.PROPS_CONVERSION[key] if key in \\"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_1a7981fb","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":22},"updated":"2017-06-12 07:47:13.000000000","message":"push it to template_data class","commit_id":"b60681f4d8c7b0c24d43794fce5927c47ab2c816"}],"vitrage/evaluator/scenario_evaluator.py":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":310,"context_line":""},{"line_number":311,"context_line":" connected_component \u003d self.get_connected_component(subgraph,"},{"line_number":312,"context_line":" action_target)"},{"line_number":313,"context_line":" # change the is_deleted and negative_condition props to false when"},{"line_number":314,"context_line":" # is_switch_mode\u003dtrue so that when we have an event on a"},{"line_number":315,"context_line":" # negative_condition\u003dtrue edge it will find the correct subgraph"},{"line_number":316,"context_line":" self._switch_edge_negative_props(is_switch_mode, scenario_edge,"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_fa238e54","line":313,"updated":"2017-06-06 14:53:22.000000000","message":"\"vitrage_is_deleted\" ?","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}],"vitrage/evaluator/template_data.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"8e6e36272734ea55fa50e71cbfc8e55c21ae6ff7","unresolved":false,"context_lines":[{"line_number":158,"context_line":" if key not in ignore_ids)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":" @staticmethod"},{"line_number":161,"context_line":" def _convert_properties(properties):"},{"line_number":162,"context_line":" converted_properties \u003d {}"},{"line_number":163,"context_line":" for key, value in properties.items():"},{"line_number":164,"context_line":" new_key \u003d TemplateData.PROPS_CONVERSION[key] if key in \\"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_7a52b569","line":161,"range":{"start_line":161,"start_character":8,"end_line":161,"end_character":27},"updated":"2017-06-12 07:47:13.000000000","message":"Should be a utility function that can be used also by EquivalenceData (instead of copy\u0026pasting it)","commit_id":"b60681f4d8c7b0c24d43794fce5927c47ab2c816"}],"vitrage/evaluator/template_validation/template_content_validator.py":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":316,"context_line":" return get_correct_result(RESULT_DESCRIPTION)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"def _validate_entity_category(entity_to_check, vitrage_cat):"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":" if TemplateFields.CATEGORY not in entity_to_check \\"},{"line_number":322,"context_line":" or entity_to_check[TemplateFields.CATEGORY] !\u003d vitrage_cat:"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_dacd6a5d","line":319,"updated":"2017-06-06 14:53:22.000000000","message":"Add \"egory\" ?\nI don\u0027t think we have a cat... yet","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":319,"context_line":"def _validate_entity_category(entity_to_check, vitrage_cat):"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":" if TemplateFields.CATEGORY not in entity_to_check \\"},{"line_number":322,"context_line":" or entity_to_check[TemplateFields.CATEGORY] !\u003d vitrage_cat:"},{"line_number":323,"context_line":" msg \u003d status_msgs[132] + \u0027 expect %s to be %s\u0027 \\"},{"line_number":324,"context_line":" % (entity_to_check, vitrage_cat)"},{"line_number":325,"context_line":" LOG.error(\u0027%s status code: %s\u0027 % (msg, 132))"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_bad8761d","line":322,"updated":"2017-06-06 14:53:22.000000000","message":"Add \"egory\" ?\nI don\u0027t think we have a cat... yet","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":321,"context_line":" if TemplateFields.CATEGORY not in entity_to_check \\"},{"line_number":322,"context_line":" or entity_to_check[TemplateFields.CATEGORY] !\u003d vitrage_cat:"},{"line_number":323,"context_line":" msg \u003d status_msgs[132] + \u0027 expect %s to be %s\u0027 \\"},{"line_number":324,"context_line":" % (entity_to_check, vitrage_cat)"},{"line_number":325,"context_line":" LOG.error(\u0027%s status code: %s\u0027 % (msg, 132))"},{"line_number":326,"context_line":" return get_fault_result(RESULT_DESCRIPTION, 132, msg)"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_9ad37201","line":324,"updated":"2017-06-06 14:53:22.000000000","message":"Add \"egory\" ?\nI don\u0027t think we have a cat... yet","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}],"vitrage/graph/query.py":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":42,"context_line":" --------------"},{"line_number":43,"context_line":" query_dict \u003d {"},{"line_number":44,"context_line":" \u0027and\u0027: ["},{"line_number":45,"context_line":" {\u0027\u003d\u003d\u0027: {\u0027TYPE\u0027: \u0027ALARM\u0027}},"},{"line_number":46,"context_line":" {\u0027or\u0027: ["},{"line_number":47,"context_line":" {\u0027\u003e\u0027: {\u0027TIME\u0027: 150}},"},{"line_number":48,"context_line":" {\u0027\u003d\u003d\u0027: {\u0027VITRAGE_IS_DELETED\u0027: True}}"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_3ab6a68b","line":45,"updated":"2017-06-06 14:53:22.000000000","message":"\u0027TYPE\u0027 WTF ??","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":" Example Output:"},{"line_number":54,"context_line":" --------------"},{"line_number":55,"context_line":" lambda item: ((item[\u0027TYPE\u0027]\u003d\u003d \u0027ALARM\u0027) and"},{"line_number":56,"context_line":" ((item[\u0027TIME\u0027]\u003e 150) or (item[\u0027VITRAGE_IS_DELETED\u0027]\u003d\u003d True)))"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":" Example Usage:"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_9aa4924c","line":55,"updated":"2017-06-06 14:53:22.000000000","message":"\u0027TYPE\u0027 WTF ??","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}],"vitrage/graph/utils.py":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"ef3f5ba5942463e4ce1ad81844006344db61f9c5","unresolved":false,"context_lines":[{"line_number":80,"context_line":"def create_edge(source_id,"},{"line_number":81,"context_line":" target_id,"},{"line_number":82,"context_line":" relationship_type,"},{"line_number":83,"context_line":" is_deleted\u003dFalse,"},{"line_number":84,"context_line":" update_timestamp\u003dNone,"},{"line_number":85,"context_line":" metadata\u003dNone):"},{"line_number":86,"context_line":" \"\"\"A builder to create an edge"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_9a27f2c7","line":83,"updated":"2017-06-06 14:53:22.000000000","message":"maybe change to \"vitrage_is_deleted\" and fix any place that calls this method ?","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}],"vitrage/tests/functional/entity_graph/states/test_datasource_info_mapper.py":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":60,"context_line":" datasource_action\u003dDSAction.INIT_SNAPSHOT)"},{"line_number":61,"context_line":" self.assertEqual(2, processor.entity_graph.num_vertices())"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":" neighbors[0].vertex[VProps.STATE] \u003d \u0027available\u0027"},{"line_number":64,"context_line":" neighbors[0].vertex[VProps.VITRAGE_IS_PLACEHOLDER] \u003d False"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":" # action"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_b6bab8de","line":63,"updated":"2017-06-07 11:25:43.000000000","message":"Disappointing...","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":69,"context_line":" # test assertions"},{"line_number":70,"context_line":" neighbor_vertex \u003d processor.entity_graph.get_vertex("},{"line_number":71,"context_line":" neighbors[0].vertex.vertex_id)"},{"line_number":72,"context_line":" self.assertEqual(\u0027AVAILABLE\u0027,"},{"line_number":73,"context_line":" neighbor_vertex[VProps.VITRAGE_AGGREGATED_STATE])"},{"line_number":74,"context_line":" self.assertEqual(OperationalResourceState.OK,"},{"line_number":75,"context_line":" neighbor_vertex[VProps.VITRAGE_OPERATIONAL_STATE])"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_36e5880b","line":72,"updated":"2017-06-07 11:25:43.000000000","message":"Disappointing...","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}],"vitrage/tests/functional/evaluator/test_action_executor.py":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":308,"context_line":" \u0027vitrage_entity_type\u0027: \u0027vitrage\u0027,"},{"line_number":309,"context_line":" \u0027severity\u0027: \u0027CRITICAL\u0027,"},{"line_number":310,"context_line":" \u0027vitrage_id\u0027: \u0027mock_vitrage_id\u0027,"},{"line_number":311,"context_line":" \u0027vitrage_category\u0027: \u0027RESOURCE\u0027,"},{"line_number":312,"context_line":" \u0027vitrage_sample_timestamp\u0027: \u00272016-03-17 11:33:32.443002+00:00\u0027}"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_1679642e","line":311,"updated":"2017-06-07 11:25:43.000000000","message":"Constants...","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":309,"context_line":" \u0027severity\u0027: \u0027CRITICAL\u0027,"},{"line_number":310,"context_line":" \u0027vitrage_id\u0027: \u0027mock_vitrage_id\u0027,"},{"line_number":311,"context_line":" \u0027vitrage_category\u0027: \u0027RESOURCE\u0027,"},{"line_number":312,"context_line":" \u0027vitrage_sample_timestamp\u0027: \u00272016-03-17 11:33:32.443002+00:00\u0027}"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_b68d182c","line":312,"updated":"2017-06-07 11:25:43.000000000","message":"Constants....","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"8e6e36272734ea55fa50e71cbfc8e55c21ae6ff7","unresolved":false,"context_lines":[{"line_number":318,"context_line":" DSProp.DATASOURCE_ACTION: DatasourceAction.UPDATE,"},{"line_number":319,"context_line":" TFields.ALARM_NAME: alarm_name,"},{"line_number":320,"context_line":" VProps.STATE: \u0027Active\u0027,"},{"line_number":321,"context_line":" \u0027type\u0027: ADD_VERTEX,"},{"line_number":322,"context_line":" DSProp.ENTITY_TYPE: VITRAGE_DATASOURCE,"},{"line_number":323,"context_line":" VProps.SEVERITY: OperationalAlarmSeverity.CRITICAL,"},{"line_number":324,"context_line":" VProps.VITRAGE_ID: \u0027mock_vitrage_id\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_ba3f2dd5","line":321,"range":{"start_line":321,"start_character":16,"end_line":321,"end_character":22},"updated":"2017-06-12 07:47:13.000000000","message":"No const for that?","commit_id":"b60681f4d8c7b0c24d43794fce5927c47ab2c816"}],"vitrage/tests/functional/evaluator/test_scenario_evaluator.py":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"df140735_01b7dc3c","updated":"2017-06-07 11:25:43.000000000","message":"Could you use constants wherever you fixed hard coded values ?\nI marked a few. There are many more.","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":391,"context_line":" \u0027id\u0027: \u002712345\u0027,"},{"line_number":392,"context_line":" \u0027vitrage_entity_type\u0027: \u0027neutron.network\u0027,"},{"line_number":393,"context_line":" \u0027vitrage_datasource_action\u0027: \u0027snapshot\u0027,"},{"line_number":394,"context_line":" \u0027vitrage_sample_date\u0027: \u00272015-12-01T12:46:41Z\u0027,"},{"line_number":395,"context_line":" }"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":" # update port"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_81208c9d","line":394,"updated":"2017-06-07 11:25:43.000000000","message":"Constants","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":401,"context_line":" \u0027updated_at\u0027: \u00272015-12-01T12:46:41Z\u0027,"},{"line_number":402,"context_line":" \u0027status\u0027: \u0027active\u0027,"},{"line_number":403,"context_line":" \u0027id\u0027: \u002754321\u0027,"},{"line_number":404,"context_line":" \u0027vitrage_entity_type\u0027: \u0027neutron.port\u0027,"},{"line_number":405,"context_line":" \u0027vitrage_datasource_action\u0027: \u0027snapshot\u0027,"},{"line_number":406,"context_line":" \u0027vitrage_sample_date\u0027: \u00272015-12-01T12:46:41Z\u0027,"},{"line_number":407,"context_line":" \u0027network_id\u0027: \u002712345\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_612578ab","line":404,"updated":"2017-06-07 11:25:43.000000000","message":"Constants","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":403,"context_line":" \u0027id\u0027: \u002754321\u0027,"},{"line_number":404,"context_line":" \u0027vitrage_entity_type\u0027: \u0027neutron.port\u0027,"},{"line_number":405,"context_line":" \u0027vitrage_datasource_action\u0027: \u0027snapshot\u0027,"},{"line_number":406,"context_line":" \u0027vitrage_sample_date\u0027: \u00272015-12-01T12:46:41Z\u0027,"},{"line_number":407,"context_line":" \u0027network_id\u0027: \u002712345\u0027,"},{"line_number":408,"context_line":" \u0027device_id\u0027: instance_ver.get(VProps.ID),"},{"line_number":409,"context_line":" \u0027device_owner\u0027: \u0027compute:nova\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_213780e6","line":406,"updated":"2017-06-07 11:25:43.000000000","message":"Constants","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}],"vitrage/tests/resources/nagios/nagios_conf.yaml":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":1,"context_line":"nagios:"},{"line_number":2,"context_line":" - nagios_host: compute-1"},{"line_number":3,"context_line":" vitrage_type: nova.host"},{"line_number":4,"context_line":" name: compute-1"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":" - nagios_host: compute-2"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"df140735_0106bc21","line":3,"updated":"2017-06-07 11:25:43.000000000","message":"Rollback","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":4,"context_line":" name: compute-1"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":" - nagios_host: compute-2"},{"line_number":7,"context_line":" vitrage_type: nova.host"},{"line_number":8,"context_line":" name: host2"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":" - nagios_host: compute-(.*)"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"df140735_e102a80b","line":7,"updated":"2017-06-07 11:25:43.000000000","message":"Rollback","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":8,"context_line":" name: host2"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":" - nagios_host: compute-(.*)"},{"line_number":11,"context_line":" vitrage_type: nova.host"},{"line_number":12,"context_line":" name: ${nagios_host}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":" - nagios_host: instance-(.*)"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"df140735_9c023309","line":11,"updated":"2017-06-07 11:25:43.000000000","message":"Rollback","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":12,"context_line":" name: ${nagios_host}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":" - nagios_host: instance-(.*)"},{"line_number":15,"context_line":" vitrage_type: nova.instance"},{"line_number":16,"context_line":" name: ${nagios_host}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"df140735_3c11e754","line":15,"updated":"2017-06-07 11:25:43.000000000","message":"Rollback","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}],"vitrage/tests/resources/snmp_notifier/oid_tree_without_severity_mapping.yaml":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"8e6e36272734ea55fa50e71cbfc8e55c21ae6ff7","unresolved":false,"context_lines":[{"line_number":11,"context_line":" next:"},{"line_number":12,"context_line":" name:"},{"line_number":13,"context_line":" oid: 1"},{"line_number":14,"context_line":" vitrage_is_deleted:"},{"line_number":15,"context_line":" oid: 2"},{"line_number":16,"context_line":" vitrage_operational_severity:"},{"line_number":17,"context_line":" oid: 3"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7f231b9d_dd566307","line":14,"range":{"start_line":14,"start_character":14,"end_line":14,"end_character":22},"updated":"2017-06-12 07:47:13.000000000","message":"Are we going to change what is being sent to SNMP?","commit_id":"b60681f4d8c7b0c24d43794fce5927c47ab2c816"}],"vitrage/tests/unit/entity_graph/processor/base.py":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":" @staticmethod"},{"line_number":35,"context_line":" def _update_vertex_to_graph(entity_graph, vitrage_category, vitrage_type,"},{"line_number":36,"context_line":" id_, vitrage_is_deleted, is_placeholder_data,"},{"line_number":37,"context_line":" additional_prop):"},{"line_number":38,"context_line":" # create vertex properties"},{"line_number":39,"context_line":" prop \u003d {key: value for key, value in additional_prop.items()}"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_53f489cf","line":36,"updated":"2017-06-07 11:25:43.000000000","message":"instead of \"is_placeholder_date\", use vitrage_is_placeholder. You changed the field (name) that is set from this parameter, there is no reason why you shouldn\u0027t change the parameter name too.\nCurrent methods calling this method don\u0027t use this parameter by name, so it\u0027s only a local change.","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}],"vitrage/tests/unit/evaluator/test_template_data.py":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":" expected_entities \u003d {"},{"line_number":60,"context_line":" \u0027alarm\u0027: Vertex(vertex_id\u003d\u0027alarm\u0027,"},{"line_number":61,"context_line":" properties\u003d{VProps.VITRAGE_CATEGORY: \u0027ALARM\u0027,"},{"line_number":62,"context_line":" VProps.VITRAGE_TYPE: \u0027nagios\u0027,"},{"line_number":63,"context_line":" VProps.NAME: \u0027host_problem\u0027"},{"line_number":64,"context_line":" }),"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_c4656d47","line":61,"updated":"2017-06-07 11:25:43.000000000","message":"from vitrage.common.constants import EntityCategory\nThen use it","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":63,"context_line":" VProps.NAME: \u0027host_problem\u0027"},{"line_number":64,"context_line":" }),"},{"line_number":65,"context_line":" \u0027resource\u0027: Vertex(vertex_id\u003d\u0027resource\u0027,"},{"line_number":66,"context_line":" properties\u003d{VProps.VITRAGE_CATEGORY: \u0027RESOURCE\u0027,"},{"line_number":67,"context_line":" VProps.VITRAGE_TYPE: \u0027nova.host\u0027"},{"line_number":68,"context_line":" })"},{"line_number":69,"context_line":" }"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_a45a7980","line":66,"updated":"2017-06-07 11:25:43.000000000","message":"from vitrage.common.constants import EntityCategory\nThen use it","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"8e6e36272734ea55fa50e71cbfc8e55c21ae6ff7","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":" # Assertions"},{"line_number":50,"context_line":" for definition in definitions[TFields.ENTITIES]:"},{"line_number":51,"context_line":" for key, value in definition[\u0027entity\u0027].items():"},{"line_number":52,"context_line":" new_key \u003d TemplateData.PROPS_CONVERSION[key] if key in \\"},{"line_number":53,"context_line":" TemplateData.PROPS_CONVERSION else key"},{"line_number":54,"context_line":" del definition[\u0027entity\u0027][key]"},{"line_number":55,"context_line":" definition[\u0027entity\u0027][new_key] \u003d value"},{"line_number":56,"context_line":" self._validate_entities(entities, definitions[TFields.ENTITIES])"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":" relate_def \u003d definitions[TFields.RELATIONSHIPS]"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_fded9f25","line":55,"range":{"start_line":51,"start_character":0,"end_line":55,"end_character":53},"updated":"2017-06-12 07:47:13.000000000","message":"Call a utility conversion function","commit_id":"b60681f4d8c7b0c24d43794fce5927c47ab2c816"}],"vitrage/tests/unit/graph/test_graph_algo.py":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":183,"context_line":" instance_edges \u003d self.entity_graph.get_edges(instances[0].vertex_id)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":" for edge in instance_edges:"},{"line_number":186,"context_line":" if \u0027nova.host\u0027 in edge.source_id:"},{"line_number":187,"context_line":" host_instance_edge \u003d edge"},{"line_number":188,"context_line":" host_instance_edge[VProps.VITRAGE_IS_DELETED] \u003d True"},{"line_number":189,"context_line":" self.entity_graph.update_edge(host_instance_edge)"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_5f024840","line":186,"updated":"2017-06-07 11:25:43.000000000","message":"Constant ?\n(hint : you are even using this constant at line 246)","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":188,"context_line":" host_instance_edge[VProps.VITRAGE_IS_DELETED] \u003d True"},{"line_number":189,"context_line":" self.entity_graph.update_edge(host_instance_edge)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":" edges_query \u003d {\u0027relationship_type\u0027: \u0027contains\u0027,"},{"line_number":192,"context_line":" \u0027vitrage_is_deleted\u0027: False}"},{"line_number":193,"context_line":" if host_instance_edge.source_id !\u003d hosts[0].vertex_id:"},{"line_number":194,"context_line":" new_edge \u003d Edge(hosts[0].vertex_id, instances[0].vertex_id,"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_1ffcd03c","line":191,"updated":"2017-06-07 11:25:43.000000000","message":"Constants?","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}],"vitrage/tests/unit/notifier/snmp_notifier/common.py":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"false_ \u003d \u0027False\u0027"},{"line_number":19,"context_line":"name_ \u003d \u0027VM network problem\u0027"},{"line_number":20,"context_line":"vitrage_category_ \u003d \u0027ALARM\u0027"},{"line_number":21,"context_line":"critical_ \u003d \u0027CRITICAL\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"GENERAL_OID \u003d \u00271.3.6.1.4.1\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_9aca2e9f","line":20,"updated":"2017-06-07 11:25:43.000000000","message":"Use constants, but do not delete the definition itself.\nvitrage_category_ \u003d ....","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}],"vitrage/tests/unit/notifier/test_notifier.py":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"host \u003d Vertex(\u0027123\u0027, {"},{"line_number":70,"context_line":" VProps.VITRAGE_CATEGORY: EntityCategory.RESOURCE,"},{"line_number":71,"context_line":" VProps.VITRAGE_TYPE: \u0027nova.host\u0027,"},{"line_number":72,"context_line":" VProps.VITRAGE_IS_DELETED: False,"},{"line_number":73,"context_line":" VProps.VITRAGE_IS_PLACEHOLDER: False,"},{"line_number":74,"context_line":" })"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_ba097296","line":71,"updated":"2017-06-07 11:25:43.000000000","message":"Constant","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"forced_down_host \u003d Vertex(\u0027123\u0027, {"},{"line_number":77,"context_line":" VProps.VITRAGE_CATEGORY: EntityCategory.RESOURCE,"},{"line_number":78,"context_line":" VProps.VITRAGE_TYPE: \u0027nova.host\u0027,"},{"line_number":79,"context_line":" VProps.VITRAGE_IS_DELETED: False,"},{"line_number":80,"context_line":" VProps.VITRAGE_IS_PLACEHOLDER: False,"},{"line_number":81,"context_line":" VProps.IS_MARKED_DOWN: True,"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_fad5aae6","line":78,"updated":"2017-06-07 11:25:43.000000000","message":"Constant","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}],"vitrage_tempest_tests/tests/api/rca/base.py":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":" list_alarms \u003d self.vitrage_client.alarm.list(vitrage_id\u003dNone)"},{"line_number":52,"context_line":" expected_alarm \u003d self._filter_list_by_pairs_parameters("},{"line_number":53,"context_line":" list_alarms, [\u0027resource_id\u0027, VProps.VITRAGE_TYPE],"},{"line_number":54,"context_line":" [resource_id, AODH_DATASOURCE])"},{"line_number":55,"context_line":" if not expected_alarm:"},{"line_number":56,"context_line":" return None"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_9acfce28","line":53,"updated":"2017-06-07 11:25:43.000000000","message":"constants - vertex properties - resource id","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":" deduce_alarms_1 \u003d self._filter_list_by_pairs_parameters("},{"line_number":94,"context_line":" alarms,"},{"line_number":95,"context_line":" [VProps.VITRAGE_TYPE, VProps.NAME, \u0027resource_type\u0027, \u0027resource_id\u0027],"},{"line_number":96,"context_line":" [VITRAGE_TYPE, VITRAGE_ALARM_NAME,"},{"line_number":97,"context_line":" NOVA_INSTANCE_DATASOURCE,"},{"line_number":98,"context_line":" utils.uni2str(instances[0].id)])"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_1a917ef2","line":95,"updated":"2017-06-07 11:25:43.000000000","message":"Why don\u0027t we have \u0027resource_type\u0027 in constants ?\nconstants - vertex properties - resource id","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":" deduce_alarms_2 \u003d self._filter_list_by_pairs_parameters("},{"line_number":101,"context_line":" alarms,"},{"line_number":102,"context_line":" [VProps.VITRAGE_TYPE, VProps.NAME, \u0027resource_type\u0027, \u0027resource_id\u0027],"},{"line_number":103,"context_line":" [VITRAGE_TYPE, VITRAGE_ALARM_NAME,"},{"line_number":104,"context_line":" NOVA_INSTANCE_DATASOURCE,"},{"line_number":105,"context_line":" utils.uni2str(instances[1].id)])"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_3aad6231","line":102,"updated":"2017-06-07 11:25:43.000000000","message":"Why don\u0027t we have \u0027resource_type\u0027 in constants ?\nconstants - vertex properties - resource id","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}],"vitrage_tempest_tests/tests/api/topology/base.py":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"df140735_9a446e76","updated":"2017-06-07 11:25:43.000000000","message":"All of this class misses constants (!!)","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}],"vitrage_tempest_tests/tests/api/topology/test_topology.py":[{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":"NOVA_QUERY \u003d \u0027{\"and\": [{\"\u003d\u003d\": {\"vitrage_category\": \"RESOURCE\"}},\u0027 \\"},{"line_number":28,"context_line":" \u0027{\"\u003d\u003d\": {\"vitrage_is_deleted\": false}},\u0027 \\"},{"line_number":29,"context_line":" \u0027{\"\u003d\u003d\": {\"vitrage_is_placeholder\": false}},\u0027 \\"},{"line_number":30,"context_line":" \u0027{\"or\": [{\"\u003d\u003d\": {\"vitrage_type\": \"openstack.cluster\"}},\u0027 \\"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_7a499a89","line":27,"updated":"2017-06-07 11:25:43.000000000","message":"change everything with constants (!!)","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}],"vitrage_tempest_tests/tests/resources/static_physical/static_physical_configuration.yaml":[{"author":{"_account_id":19122,"name":"Alexey Weyl","email":"aloshaweyl@gmail.com","username":"alexey_weyl"},"change_message_id":"617b2c6850ed55d661b819f17ac1b9be36d5970f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"entities:"},{"line_number":2,"context_line":" - vitrage_type: switch"},{"line_number":3,"context_line":" name: switch-1"},{"line_number":4,"context_line":" id: 12345"},{"line_number":5,"context_line":" state: available"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"df140735_2e5d3be9","line":2,"range":{"start_line":2,"start_character":3,"end_line":2,"end_character":12},"updated":"2017-06-06 20:26:20.000000000","message":"remove vitrage prefix","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":3,"context_line":" name: switch-1"},{"line_number":4,"context_line":" id: 12345"},{"line_number":5,"context_line":" state: available"},{"line_number":6,"context_line":" relationships:"},{"line_number":7,"context_line":" - vitrage_type: nova.host"},{"line_number":8,"context_line":" name: tmp-devstack"},{"line_number":9,"context_line":" id: tmp-devstack"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"df140735_ba34d2fc","line":6,"updated":"2017-06-07 11:25:43.000000000","message":"fix","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":8,"context_line":" name: tmp-devstack"},{"line_number":9,"context_line":" id: tmp-devstack"},{"line_number":10,"context_line":" relation_type: attached"},{"line_number":11,"context_line":" - vitrage_type: switch"},{"line_number":12,"context_line":" name: switch-2"},{"line_number":13,"context_line":" id: 23456"},{"line_number":14,"context_line":" state: available"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"df140735_9a390ef4","line":11,"updated":"2017-06-07 11:25:43.000000000","message":"fix","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"f264013a668d976809aead91cd3e3d7b81628843","unresolved":false,"context_lines":[{"line_number":13,"context_line":" id: 23456"},{"line_number":14,"context_line":" state: available"},{"line_number":15,"context_line":" relationships:"},{"line_number":16,"context_line":" - vitrage_type: nova.host"},{"line_number":17,"context_line":" name: tmp-devstack"},{"line_number":18,"context_line":" id: tmp-devstack"},{"line_number":19,"context_line":" relation_type: attached"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"df140735_7a3e3adb","line":16,"updated":"2017-06-07 11:25:43.000000000","message":"fix","commit_id":"44ac687663c5753c06017d3eb3d4277c63a81067"}]}