)]}'
{"vitrage_tempest_tests/tests/api/event/test_events.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"a60d9038b39406f5bd3db7fc6f70d66b7aed8b4b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self._test_send_doctor_event(details)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def test_send_doctor_event_without_resource_id_v2(self):"},{"line_number":56,"context_line":"        \"\"\"Sending and event in Doctor format should result in an alarm\"\"\""},{"line_number":57,"context_line":"        details2 \u003d {"},{"line_number":58,"context_line":"            \u0027hostname\u0027: \u0027host457\u0027,"},{"line_number":59,"context_line":"            \u0027source\u0027: \u0027sample_monitor\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_1bbe63fe","line":56,"range":{"start_line":56,"start_character":19,"end_line":56,"end_character":22},"updated":"2017-06-18 13:50:10.000000000","message":"an","commit_id":"7712809960d70d4192214e04832101ef9459031d"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"a60d9038b39406f5bd3db7fc6f70d66b7aed8b4b","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def test_send_doctor_event_without_resource_id_v2(self):"},{"line_number":56,"context_line":"        \"\"\"Sending and event in Doctor format should result in an alarm\"\"\""},{"line_number":57,"context_line":"        details2 \u003d {"},{"line_number":58,"context_line":"            \u0027hostname\u0027: \u0027host457\u0027,"},{"line_number":59,"context_line":"            \u0027source\u0027: \u0027sample_monitor\u0027,"},{"line_number":60,"context_line":"            \u0027cause\u0027: \u0027another alarm\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_db390ba4","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":16},"updated":"2017-06-18 13:50:10.000000000","message":"Why details2? why not just details?","commit_id":"7712809960d70d4192214e04832101ef9459031d"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"a60d9038b39406f5bd3db7fc6f70d66b7aed8b4b","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    @staticmethod"},{"line_number":116,"context_line":"    def _wait_for_answer(max_waiting, time_between_attempts, func, **kwargs):"},{"line_number":117,"context_line":"        \"\"\"time_between_attempts should be in range of 0 to 1\"\"\""},{"line_number":118,"context_line":"        count \u003d 0"},{"line_number":119,"context_line":"        status, res \u003d False, None"},{"line_number":120,"context_line":"        while count \u003c max_waiting:"},{"line_number":121,"context_line":"            time.sleep(time_between_attempts)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_fb4de73a","line":118,"range":{"start_line":118,"start_character":8,"end_line":118,"end_character":13},"updated":"2017-06-18 13:50:10.000000000","message":"count is usually used for integer values. I would rename it to passed_time or something like that","commit_id":"7712809960d70d4192214e04832101ef9459031d"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"a60d9038b39406f5bd3db7fc6f70d66b7aed8b4b","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        status, res \u003d False, None"},{"line_number":120,"context_line":"        while count \u003c max_waiting:"},{"line_number":121,"context_line":"            time.sleep(time_between_attempts)"},{"line_number":122,"context_line":"            start_time \u003d time.time()"},{"line_number":123,"context_line":"            status, res \u003d func(**kwargs)"},{"line_number":124,"context_line":"            if status:"},{"line_number":125,"context_line":"                return res"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_db07cbc9","line":122,"range":{"start_line":122,"start_character":12,"end_line":122,"end_character":22},"updated":"2017-06-18 13:50:10.000000000","message":"You can put start_time before the while, end then do: \nwhile (time.time() - start_time \u003c max_waiting)\nAnd remove run_time and count.","commit_id":"7712809960d70d4192214e04832101ef9459031d"}],"vitrage_tempest_tests/tests/utils.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"a60d9038b39406f5bd3db7fc6f70d66b7aed8b4b","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    return func_name_print_func"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"def wait_for_answer(max_waiting, time_between_attempts, func, **kwargs):"},{"line_number":132,"context_line":"        \"\"\"time_between_attempts should be in range of 0 to 1\"\"\""},{"line_number":133,"context_line":"        count \u003d 0"},{"line_number":134,"context_line":"        status, res \u003d False, None"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_7b10b700","line":131,"range":{"start_line":131,"start_character":4,"end_line":131,"end_character":19},"updated":"2017-06-18 13:50:10.000000000","message":"Is it the same function as in the other file?","commit_id":"7712809960d70d4192214e04832101ef9459031d"}]}