)]}'
{"vitrage/datasources/collectd/transformer.py":[{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"f05bdad349a5f07b65c7a7645f767ef90e06b893","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    def _create_collectd_neighbors(self, entity_event):"},{"line_number":76,"context_line":"        graph_neighbors \u003d entity_event.get(self.QUERY_RESULT, [])"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        result \u003d []"},{"line_number":79,"context_line":"        for graph_neighbor in graph_neighbors:"},{"line_number":80,"context_line":"            neighbor \u003d self._create_neighbor("},{"line_number":81,"context_line":"                entity_event,"},{"line_number":82,"context_line":"                graph_neighbor[VProps.ID],"},{"line_number":83,"context_line":"                graph_neighbor[VProps.VITRAGE_TYPE],"},{"line_number":84,"context_line":"                EdgeLabel.ON,"},{"line_number":85,"context_line":"                neighbor_category\u003dEntityCategory.RESOURCE)"},{"line_number":86,"context_line":"            result.append(neighbor)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        return result"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _ok_status(self, entity_event):"},{"line_number":91,"context_line":"        return entity_event[CProps.SEVERITY] \u003d\u003d \u0027OK\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_171c8bbf","line":88,"range":{"start_line":78,"start_character":8,"end_line":88,"end_character":21},"updated":"2017-07-11 06:45:18.000000000","message":"why not use comprehension list","commit_id":"54b1879011cbb05b97e4afa45f49d6eaace26273"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"f05bdad349a5f07b65c7a7645f767ef90e06b893","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @staticmethod"},{"line_number":113,"context_line":"    def get_enrich_query(event):"},{"line_number":114,"context_line":"        resource_name \u003d event.get(CProps.RESOURCE_NAME, None)"},{"line_number":115,"context_line":"        if not resource_name:"},{"line_number":116,"context_line":"            return None"},{"line_number":117,"context_line":"        return {VProps.NAME: resource_name}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_5767a352","line":114,"range":{"start_line":114,"start_character":7,"end_line":114,"end_character":61},"updated":"2017-07-11 06:45:18.000000000","message":"the default returns None","commit_id":"54b1879011cbb05b97e4afa45f49d6eaace26273"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"f05bdad349a5f07b65c7a7645f767ef90e06b893","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    @staticmethod"},{"line_number":113,"context_line":"    def get_enrich_query(event):"},{"line_number":114,"context_line":"        resource_name \u003d event.get(CProps.RESOURCE_NAME, None)"},{"line_number":115,"context_line":"        if not resource_name:"},{"line_number":116,"context_line":"            return None"},{"line_number":117,"context_line":"        return {VProps.NAME: resource_name}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_17f80b47","line":117,"range":{"start_line":115,"start_character":7,"end_line":117,"end_character":43},"updated":"2017-07-11 06:45:18.000000000","message":"I think more clearer is\n\nreturn {VProps.NAME: resource_name} if resource_name else None","commit_id":"54b1879011cbb05b97e4afa45f49d6eaace26273"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"00da6273c06e41c65d9f0168d32ddef0d773f337","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        graph_neighbors \u003d entity_event.get(self.QUERY_RESULT, [])"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        return [self._create_neighbor(entity_event,"},{"line_number":79,"context_line":"                graph_neighbor[VProps.ID],"},{"line_number":80,"context_line":"                graph_neighbor[VProps.VITRAGE_TYPE],"},{"line_number":81,"context_line":"                EdgeLabel.ON,"},{"line_number":82,"context_line":"                neighbor_category\u003dEntityCategory.RESOURCE)"},{"line_number":83,"context_line":"                for graph_neighbor in graph_neighbors]"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def _ok_status(self, entity_event):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_b2e6e215","line":82,"range":{"start_line":79,"start_character":0,"end_line":82,"end_character":58},"updated":"2017-07-12 01:28:20.000000000","message":"Should this indent be aligned with \u0027(\u0027 instead of \u0027[\u0027?","commit_id":"99d515e2c2ba9ad0272ed9b019ab7ee1aa081189"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"491d879edf8268c8e8a52c4e6c14666f6addca4c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        graph_neighbors \u003d entity_event.get(self.QUERY_RESULT, [])"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        return [self._create_neighbor(entity_event,"},{"line_number":79,"context_line":"                graph_neighbor[VProps.ID],"},{"line_number":80,"context_line":"                graph_neighbor[VProps.VITRAGE_TYPE],"},{"line_number":81,"context_line":"                EdgeLabel.ON,"},{"line_number":82,"context_line":"                neighbor_category\u003dEntityCategory.RESOURCE)"},{"line_number":83,"context_line":"                for graph_neighbor in graph_neighbors]"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def _ok_status(self, entity_event):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_6e3fa5d6","line":82,"range":{"start_line":79,"start_character":0,"end_line":82,"end_character":58},"in_reply_to":"3f1d235d_b2e6e215","updated":"2017-07-12 16:34:04.000000000","message":"Right, I\u0027ll fix it","commit_id":"99d515e2c2ba9ad0272ed9b019ab7ee1aa081189"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"ed1837c7993a72289c971ca081525f430e7235dc","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @staticmethod"},{"line_number":108,"context_line":"    def get_enrich_query(event):"},{"line_number":109,"context_line":"        resource_name \u003d event.get(CProps.RESOURCE_NAME)"},{"line_number":110,"context_line":"        return {VProps.NAME: resource_name} if resource_name else None"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_b20e05e3","line":110,"range":{"start_line":109,"start_character":8,"end_line":110,"end_character":70},"updated":"2017-07-11 07:04:25.000000000","message":"maybe this is better what do you think ?\n\ntry:\n return event[CProps.RESOURCE_NAME]\nexcept KeyError:\n   return None","commit_id":"99d515e2c2ba9ad0272ed9b019ab7ee1aa081189"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"00da6273c06e41c65d9f0168d32ddef0d773f337","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @staticmethod"},{"line_number":108,"context_line":"    def get_enrich_query(event):"},{"line_number":109,"context_line":"        resource_name \u003d event.get(CProps.RESOURCE_NAME)"},{"line_number":110,"context_line":"        return {VProps.NAME: resource_name} if resource_name else None"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_f2aa1a83","line":110,"range":{"start_line":109,"start_character":8,"end_line":110,"end_character":70},"in_reply_to":"3f1d235d_b20e05e3","updated":"2017-07-12 01:28:20.000000000","message":"@Eyal you suggest a different return value comparing to original design. I suppose your are suggesting `return {VProps.NAME, event[CProps.RESOURCE_NAME]}`","commit_id":"99d515e2c2ba9ad0272ed9b019ab7ee1aa081189"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"491d879edf8268c8e8a52c4e6c14666f6addca4c","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @staticmethod"},{"line_number":108,"context_line":"    def get_enrich_query(event):"},{"line_number":109,"context_line":"        resource_name \u003d event.get(CProps.RESOURCE_NAME)"},{"line_number":110,"context_line":"        return {VProps.NAME: resource_name} if resource_name else None"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_8e132167","line":110,"range":{"start_line":109,"start_character":8,"end_line":110,"end_character":70},"in_reply_to":"3f1d235d_f2aa1a83","updated":"2017-07-12 16:34:04.000000000","message":"Yes, that\u0027s what Eyal meant. But I\u0027m in favor of the original code, as we use it in many places in Vitrage. Also, I don\u0027t think that doing try-except when it is not necessary is a good practice.","commit_id":"99d515e2c2ba9ad0272ed9b019ab7ee1aa081189"}]}