)]}'
{"vitrage/evaluator/scenario_repository.py":[{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"32764b4e32daf80eff058408785029365d019c36","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        hashable_items \u003d dict()"},{"line_number":162,"context_line":"        for key, val in entity.properties.items():"},{"line_number":163,"context_line":"            if isinstance(val, list):"},{"line_number":164,"context_line":"                LOG.warning(\u0027Unexpected - list key %s - val %s\u0027, str(key),"},{"line_number":165,"context_line":"                            str(val))"},{"line_number":166,"context_line":"            else:"},{"line_number":167,"context_line":"                hashable_items[key] \u003d val"},{"line_number":168,"context_line":"        return hashable_items"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_d904a01a","line":165,"range":{"start_line":164,"start_character":0,"end_line":165,"end_character":37},"updated":"2017-07-27 13:26:03.000000000","message":"In which case will the val be list? Just want to make sure it is safe to ignore it.","commit_id":"529d42f4e5c887c6817778fff5be9efdbe0aee16"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"cc769f88088b48dd0217a5dba305e9a13cd6f26c","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        hashable_items \u003d dict()"},{"line_number":162,"context_line":"        for key, val in entity.properties.items():"},{"line_number":163,"context_line":"            if isinstance(val, list):"},{"line_number":164,"context_line":"                LOG.warning(\u0027Unexpected - list key %s - val %s\u0027, str(key),"},{"line_number":165,"context_line":"                            str(val))"},{"line_number":166,"context_line":"            else:"},{"line_number":167,"context_line":"                hashable_items[key] \u003d val"},{"line_number":168,"context_line":"        return hashable_items"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_fd784590","line":165,"range":{"start_line":164,"start_character":0,"end_line":165,"end_character":37},"in_reply_to":"ff346bd7_6ac4b0f5","updated":"2017-07-28 14:22:51.000000000","message":"Would it be better we leave such clarification in code as comment? It is not a usual implementation. There could be other value that is not hashable.","commit_id":"529d42f4e5c887c6817778fff5be9efdbe0aee16"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"b9183f2f233b255b8aec2be83dd36b7c2118f3f8","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        hashable_items \u003d dict()"},{"line_number":162,"context_line":"        for key, val in entity.properties.items():"},{"line_number":163,"context_line":"            if isinstance(val, list):"},{"line_number":164,"context_line":"                LOG.warning(\u0027Unexpected - list key %s - val %s\u0027, str(key),"},{"line_number":165,"context_line":"                            str(val))"},{"line_number":166,"context_line":"            else:"},{"line_number":167,"context_line":"                hashable_items[key] \u003d val"},{"line_number":168,"context_line":"        return hashable_items"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_6ac4b0f5","line":165,"range":{"start_line":164,"start_character":0,"end_line":165,"end_character":37},"in_reply_to":"ff346bd7_d904a01a","updated":"2017-07-27 14:45:05.000000000","message":"Actually - we have no idea, that\u0027s why we added the warning here...\n\nOur tempest tests fail quite oftenwith an exception  in this function that a list is not hashable. We don\u0027t understand what this list could be, so we hope that this change will help us figure it out.","commit_id":"529d42f4e5c887c6817778fff5be9efdbe0aee16"}]}