)]}'
{"vitrage/api_handler/apis/topology.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"77151809ab921040e0fadff4e3a88409c58a9836","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        if not tmp_vertices:"},{"line_number":228,"context_line":"            LOG.debug(\"No root vertex found\")"},{"line_number":229,"context_line":"            return None"},{"line_number":230,"context_line":"        root_vertex \u003d tmp_vertices[0]"},{"line_number":231,"context_line":"        return root_vertex"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f2577a7_a73471fc","line":230,"range":{"start_line":230,"start_character":8,"end_line":230,"end_character":37},"updated":"2017-09-12 21:14:06.000000000","message":"What if there is more than one?","commit_id":"ae3eaefffaa5cc4ccfe6b4696379d6a41305d7fd"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"900fbad3d9266859ca60c89f437c7f4374f16810","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        if not tmp_vertices:"},{"line_number":228,"context_line":"            LOG.debug(\"No root vertex found\")"},{"line_number":229,"context_line":"            return None"},{"line_number":230,"context_line":"        root_vertex \u003d tmp_vertices[0]"},{"line_number":231,"context_line":"        return root_vertex"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f2577a7_89773503","line":230,"range":{"start_line":230,"start_character":8,"end_line":230,"end_character":37},"in_reply_to":"5f2577a7_a73471fc","updated":"2017-09-13 11:45:23.000000000","message":"Done","commit_id":"ae3eaefffaa5cc4ccfe6b4696379d6a41305d7fd"}],"vitrage/datasources/aodh/transformer.py":[{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"0c861904aee3dbdc8f03f4562f188608760d69f1","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            \u0027alarm_type\u0027: entity_event[AodhProps.TYPE]"},{"line_number":63,"context_line":"        }"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        # TODO(annarez): convert EVENT_TYPE to tuple"},{"line_number":66,"context_line":"        if entity_event[AodhProps.TYPE] \u003d\u003d AodhProps.EVENT:"},{"line_number":67,"context_line":"            metadata[AodhProps.EVENT_TYPE] \u003d entity_event[AodhProps.EVENT_TYPE]"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f2577a7_7702c9b6","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":52},"updated":"2017-09-12 13:39:43.000000000","message":"Please do","commit_id":"b5f6b36e1837e6f2ab934f25aee7cbdd473b1521"}],"vitrage/datasources/transformer_base.py":[{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"0c861904aee3dbdc8f03f4562f188608760d69f1","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            vertex \u003d self._create_snapshot_entity_vertex(entity_event)"},{"line_number":160,"context_line":"            if not vertex:"},{"line_number":161,"context_line":"                return"},{"line_number":162,"context_line":"            # if vertex.get(VProps.IS_REAL_VITRAGE_ID):"},{"line_number":163,"context_line":"            #     return vertex"},{"line_number":164,"context_line":"            return self.update_uuid_in_vertex(vertex)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def update_uuid_in_vertex(self, vertex):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f2577a7_372b21ec","line":163,"range":{"start_line":162,"start_character":0,"end_line":163,"end_character":31},"updated":"2017-09-12 13:39:43.000000000","message":"please remove","commit_id":"b5f6b36e1837e6f2ab934f25aee7cbdd473b1521"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"a65b250a0895a5250bd39a575ecd9a0f125e4cfc","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            vertex \u003d self._create_snapshot_entity_vertex(entity_event)"},{"line_number":160,"context_line":"            if not vertex:"},{"line_number":161,"context_line":"                return"},{"line_number":162,"context_line":"            # if vertex.get(VProps.IS_REAL_VITRAGE_ID):"},{"line_number":163,"context_line":"            #     return vertex"},{"line_number":164,"context_line":"            return self.update_uuid_in_vertex(vertex)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def update_uuid_in_vertex(self, vertex):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f2577a7_128f132b","line":163,"range":{"start_line":162,"start_character":0,"end_line":163,"end_character":31},"in_reply_to":"5f2577a7_372b21ec","updated":"2017-09-12 14:23:48.000000000","message":"Done","commit_id":"b5f6b36e1837e6f2ab934f25aee7cbdd473b1521"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"0c861904aee3dbdc8f03f4562f188608760d69f1","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            return self.update_uuid_in_vertex(vertex)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def update_uuid_in_vertex(self, vertex):"},{"line_number":167,"context_line":"        if vertex.get(VProps.IS_REAL_VITRAGE_ID):"},{"line_number":168,"context_line":"            return vertex"},{"line_number":169,"context_line":"        new_uuid \u003d self.replace_uuid(vertex.vertex_id)"},{"line_number":170,"context_line":"        vertex.vertex_id \u003d new_uuid"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f2577a7_b77dd11d","line":167,"range":{"start_line":167,"start_character":29,"end_line":167,"end_character":47},"updated":"2017-09-12 13:39:43.000000000","message":"Is this field required?","commit_id":"b5f6b36e1837e6f2ab934f25aee7cbdd473b1521"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"a65b250a0895a5250bd39a575ecd9a0f125e4cfc","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            return self.update_uuid_in_vertex(vertex)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def update_uuid_in_vertex(self, vertex):"},{"line_number":167,"context_line":"        if vertex.get(VProps.IS_REAL_VITRAGE_ID):"},{"line_number":168,"context_line":"            return vertex"},{"line_number":169,"context_line":"        new_uuid \u003d self.replace_uuid(vertex.vertex_id)"},{"line_number":170,"context_line":"        vertex.vertex_id \u003d new_uuid"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f2577a7_52747b35","line":167,"range":{"start_line":167,"start_character":29,"end_line":167,"end_character":47},"in_reply_to":"5f2577a7_b77dd11d","updated":"2017-09-12 14:23:48.000000000","message":"yes, for now.\nwill be removed in future commit","commit_id":"b5f6b36e1837e6f2ab934f25aee7cbdd473b1521"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"0c861904aee3dbdc8f03f4562f188608760d69f1","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        vertex.properties[VProps.VITRAGE_ID] \u003d new_uuid"},{"line_number":172,"context_line":"        return vertex"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def replace_uuid(self, old_vitrage_id):"},{"line_number":175,"context_line":"        old_uuid_hash \u003d hash(old_vitrage_id)"},{"line_number":176,"context_line":"        new_uuid \u003d self.uuid_cache.get(old_uuid_hash, None)"},{"line_number":177,"context_line":"        if not new_uuid:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f2577a7_378a011b","line":174,"range":{"start_line":174,"start_character":8,"end_line":174,"end_character":20},"updated":"2017-09-12 13:39:43.000000000","message":"can rename to uuid_from_deprecated_vitrage_id or something more clear","commit_id":"b5f6b36e1837e6f2ab934f25aee7cbdd473b1521"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"a65b250a0895a5250bd39a575ecd9a0f125e4cfc","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        vertex.properties[VProps.VITRAGE_ID] \u003d new_uuid"},{"line_number":172,"context_line":"        return vertex"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def replace_uuid(self, old_vitrage_id):"},{"line_number":175,"context_line":"        old_uuid_hash \u003d hash(old_vitrage_id)"},{"line_number":176,"context_line":"        new_uuid \u003d self.uuid_cache.get(old_uuid_hash, None)"},{"line_number":177,"context_line":"        if not new_uuid:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f2577a7_b27ddf1d","line":174,"range":{"start_line":174,"start_character":8,"end_line":174,"end_character":20},"in_reply_to":"5f2577a7_378a011b","updated":"2017-09-12 14:23:48.000000000","message":"Done","commit_id":"b5f6b36e1837e6f2ab934f25aee7cbdd473b1521"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"77151809ab921040e0fadff4e3a88409c58a9836","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                          \u0027defined without updates\u0027)"},{"line_number":158,"context_line":"        else:"},{"line_number":159,"context_line":"            vertex \u003d self._create_snapshot_entity_vertex(entity_event)"},{"line_number":160,"context_line":"            if not vertex:"},{"line_number":161,"context_line":"                return"},{"line_number":162,"context_line":"            return self.update_uuid_in_vertex(vertex)"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5f2577a7_470eed3b","line":160,"range":{"start_line":160,"start_character":12,"end_line":160,"end_character":26},"updated":"2017-09-12 21:14:06.000000000","message":"Why do you check \u0027if not vertex\u0027 here but not in the other places above?","commit_id":"ae3eaefffaa5cc4ccfe6b4696379d6a41305d7fd"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"900fbad3d9266859ca60c89f437c7f4374f16810","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                          \u0027defined without updates\u0027)"},{"line_number":158,"context_line":"        else:"},{"line_number":159,"context_line":"            vertex \u003d self._create_snapshot_entity_vertex(entity_event)"},{"line_number":160,"context_line":"            if not vertex:"},{"line_number":161,"context_line":"                return"},{"line_number":162,"context_line":"            return self.update_uuid_in_vertex(vertex)"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5f2577a7_d5f3999d","line":160,"range":{"start_line":160,"start_character":12,"end_line":160,"end_character":26},"in_reply_to":"5f2577a7_470eed3b","updated":"2017-09-13 11:45:23.000000000","message":"Done","commit_id":"ae3eaefffaa5cc4ccfe6b4696379d6a41305d7fd"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"77151809ab921040e0fadff4e3a88409c58a9836","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            return self.update_uuid_in_vertex(vertex)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def update_uuid_in_vertex(self, vertex):"},{"line_number":165,"context_line":"        if vertex.get(VProps.IS_REAL_VITRAGE_ID):"},{"line_number":166,"context_line":"            return vertex"},{"line_number":167,"context_line":"        new_uuid \u003d self.uuid_from_deprecated_vitrage_id(vertex.vertex_id)"},{"line_number":168,"context_line":"        vertex.vertex_id \u003d new_uuid"},{"line_number":169,"context_line":"        vertex.properties[VProps.VITRAGE_ID] \u003d new_uuid"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f2577a7_423c9bbe","line":166,"range":{"start_line":165,"start_character":0,"end_line":166,"end_character":25},"updated":"2017-09-12 21:14:06.000000000","message":"Why use this flag here? Is it still needed? You are not updating it after you assign a UUID to the vertex.","commit_id":"ae3eaefffaa5cc4ccfe6b4696379d6a41305d7fd"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"900fbad3d9266859ca60c89f437c7f4374f16810","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            return self.update_uuid_in_vertex(vertex)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def update_uuid_in_vertex(self, vertex):"},{"line_number":165,"context_line":"        if vertex.get(VProps.IS_REAL_VITRAGE_ID):"},{"line_number":166,"context_line":"            return vertex"},{"line_number":167,"context_line":"        new_uuid \u003d self.uuid_from_deprecated_vitrage_id(vertex.vertex_id)"},{"line_number":168,"context_line":"        vertex.vertex_id \u003d new_uuid"},{"line_number":169,"context_line":"        vertex.properties[VProps.VITRAGE_ID] \u003d new_uuid"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f2577a7_75e065cd","line":166,"range":{"start_line":165,"start_character":0,"end_line":166,"end_character":25},"in_reply_to":"5f2577a7_423c9bbe","updated":"2017-09-13 11:45:23.000000000","message":"it is used only for the evaluator_event_transformer, I will change it after this commit is merged, removing this field adds lots of changes","commit_id":"ae3eaefffaa5cc4ccfe6b4696379d6a41305d7fd"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"a3c2a6d874dfabe991ab909b1b44e210dcbf484a","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            return self.update_uuid_in_vertex(vertex)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def update_uuid_in_vertex(self, vertex):"},{"line_number":165,"context_line":"        if vertex.get(VProps.IS_REAL_VITRAGE_ID):"},{"line_number":166,"context_line":"            return vertex"},{"line_number":167,"context_line":"        new_uuid \u003d self.uuid_from_deprecated_vitrage_id(vertex.vertex_id)"},{"line_number":168,"context_line":"        vertex.vertex_id \u003d new_uuid"},{"line_number":169,"context_line":"        vertex.properties[VProps.VITRAGE_ID] \u003d new_uuid"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f2577a7_3c2f5440","line":166,"range":{"start_line":165,"start_character":0,"end_line":166,"end_character":25},"in_reply_to":"5f2577a7_75e065cd","updated":"2017-09-24 07:51:52.000000000","message":"OK","commit_id":"ae3eaefffaa5cc4ccfe6b4696379d6a41305d7fd"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"77151809ab921040e0fadff4e3a88409c58a9836","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        vertex.properties[VProps.VITRAGE_ID] \u003d new_uuid"},{"line_number":170,"context_line":"        return vertex"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def uuid_from_deprecated_vitrage_id(self, old_vitrage_id):"},{"line_number":173,"context_line":"        old_uuid_hash \u003d hash(old_vitrage_id)"},{"line_number":174,"context_line":"        new_uuid \u003d self.uuid_cache.get(old_uuid_hash, None)"},{"line_number":175,"context_line":"        if not new_uuid:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f2577a7_22fe2f37","line":172,"range":{"start_line":172,"start_character":8,"end_line":172,"end_character":39},"updated":"2017-09-12 21:14:06.000000000","message":"I\u0027m not sure that this method belongs in the TransformerBase. A few reasons:\n- Why hold a separate cache per transformer? Why not have one common cache for all?\n- The logic of the UUID creation has nothing to do with the other roles of the transformer.\n- In each test, you create a specific transformer in order to call this method. There is no real reason to do this.","commit_id":"ae3eaefffaa5cc4ccfe6b4696379d6a41305d7fd"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"900fbad3d9266859ca60c89f437c7f4374f16810","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        vertex.properties[VProps.VITRAGE_ID] \u003d new_uuid"},{"line_number":170,"context_line":"        return vertex"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def uuid_from_deprecated_vitrage_id(self, old_vitrage_id):"},{"line_number":173,"context_line":"        old_uuid_hash \u003d hash(old_vitrage_id)"},{"line_number":174,"context_line":"        new_uuid \u003d self.uuid_cache.get(old_uuid_hash, None)"},{"line_number":175,"context_line":"        if not new_uuid:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f2577a7_29e161d1","line":172,"range":{"start_line":172,"start_character":8,"end_line":172,"end_character":39},"in_reply_to":"5f2577a7_22fe2f37","updated":"2017-09-13 11:45:23.000000000","message":"Done","commit_id":"ae3eaefffaa5cc4ccfe6b4696379d6a41305d7fd"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"26caf502d38faba73bd770b66d58066fe57b4f70","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    @classmethod"},{"line_number":174,"context_line":"    def uuid_from_deprecated_vitrage_id(cls, old_vitrage_id):"},{"line_number":175,"context_line":"        old_uuid_hash \u003d hash(old_vitrage_id)"},{"line_number":176,"context_line":"        new_uuid \u003d cls.uuid_cache.get(old_uuid_hash, None)"},{"line_number":177,"context_line":"        if not new_uuid:"},{"line_number":178,"context_line":"            new_uuid \u003d uuidutils.generate_uuid()"},{"line_number":179,"context_line":"            cls.uuid_cache[old_uuid_hash] \u003d new_uuid"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f2577a7_09b90579","line":176,"range":{"start_line":176,"start_character":8,"end_line":176,"end_character":58},"updated":"2017-09-13 12:00:50.000000000","message":"get returns None as default","commit_id":"8c2c694daaa9bd99ad5bc1ccbeafc378c785e1bd"}],"vitrage/entity_graph/processor/processor.py":[{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"0c861904aee3dbdc8f03f4562f188608760d69f1","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                self.entity_graph.update_edge(neighbor.edge)"},{"line_number":150,"context_line":"            return"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # TODO(doffek): check if we need here the update_vertex because the"},{"line_number":153,"context_line":"        # purpose of this method is to update the relationship"},{"line_number":154,"context_line":"        self.entity_graph.update_vertex(entity_vertex)"},{"line_number":155,"context_line":"        for neighbor in neighbors:"},{"line_number":156,"context_line":"            self._find_and_fix_relationship(entity_vertex, neighbor)"},{"line_number":157,"context_line":"            self.entity_graph.update_edge(neighbor.edge)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def delete_relationship(self, updated_vertex, neighbors):"},{"line_number":160,"context_line":"        LOG.debug(\u0027Delete relationship from entity graph:\\n%s\u0027, neighbors)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f2577a7_f2cb67a2","line":157,"range":{"start_line":152,"start_character":0,"end_line":157,"end_character":56},"updated":"2017-09-12 13:39:43.000000000","message":"this can probably be removed as well","commit_id":"b5f6b36e1837e6f2ab934f25aee7cbdd473b1521"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"0c861904aee3dbdc8f03f4562f188608760d69f1","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"            return"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        # TODO(doffek): check if we need here the update_vertex because the"},{"line_number":174,"context_line":"        # purpose of this method is to update the relationship"},{"line_number":175,"context_line":"        self.entity_graph.update_vertex(updated_vertex)"},{"line_number":176,"context_line":"        for neighbor in neighbors:"},{"line_number":177,"context_line":"            self._find_and_fix_relationship(updated_vertex, neighbor)"},{"line_number":178,"context_line":"            graph_edge \u003d self.entity_graph.get_edge(neighbor.edge.source_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f2577a7_171f056d","line":175,"range":{"start_line":173,"start_character":0,"end_line":175,"end_character":55},"updated":"2017-09-12 13:39:43.000000000","message":"This can probably be removed","commit_id":"b5f6b36e1837e6f2ab934f25aee7cbdd473b1521"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"0c861904aee3dbdc8f03f4562f188608760d69f1","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        # purpose of this method is to update the relationship"},{"line_number":175,"context_line":"        self.entity_graph.update_vertex(updated_vertex)"},{"line_number":176,"context_line":"        for neighbor in neighbors:"},{"line_number":177,"context_line":"            self._find_and_fix_relationship(updated_vertex, neighbor)"},{"line_number":178,"context_line":"            graph_edge \u003d self.entity_graph.get_edge(neighbor.edge.source_id,"},{"line_number":179,"context_line":"                                                    neighbor.edge.target_id,"},{"line_number":180,"context_line":"                                                    neighbor.edge.label)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f2577a7_b24a7f24","line":177,"range":{"start_line":177,"start_character":12,"end_line":177,"end_character":69},"updated":"2017-09-12 13:39:43.000000000","message":"and this removed","commit_id":"b5f6b36e1837e6f2ab934f25aee7cbdd473b1521"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"a65b250a0895a5250bd39a575ecd9a0f125e4cfc","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        # purpose of this method is to update the relationship"},{"line_number":175,"context_line":"        self.entity_graph.update_vertex(updated_vertex)"},{"line_number":176,"context_line":"        for neighbor in neighbors:"},{"line_number":177,"context_line":"            self._find_and_fix_relationship(updated_vertex, neighbor)"},{"line_number":178,"context_line":"            graph_edge \u003d self.entity_graph.get_edge(neighbor.edge.source_id,"},{"line_number":179,"context_line":"                                                    neighbor.edge.target_id,"},{"line_number":180,"context_line":"                                                    neighbor.edge.label)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f2577a7_0d65b2b5","line":177,"range":{"start_line":177,"start_character":12,"end_line":177,"end_character":69},"in_reply_to":"5f2577a7_b24a7f24","updated":"2017-09-12 14:23:48.000000000","message":"Done","commit_id":"b5f6b36e1837e6f2ab934f25aee7cbdd473b1521"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"0c861904aee3dbdc8f03f4562f188608760d69f1","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        result \u003d self.entity_graph.get_vertices(attr)"},{"line_number":349,"context_line":"        event[TransformerBase.QUERY_RESULT] \u003d result"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    def _find_and_fix_relationship(self, vertex, neighbor):"},{"line_number":352,"context_line":"        prev_neighbor_id \u003d neighbor.vertex[VProps.VITRAGE_ID]"},{"line_number":353,"context_line":"        if neighbor.edge.source_id \u003d\u003d prev_neighbor_id:"},{"line_number":354,"context_line":"            neighbor.edge.source_id \u003d neighbor.vertex.vertex_id"},{"line_number":355,"context_line":"            neighbor.edge.target_id \u003d vertex.vertex_id"},{"line_number":356,"context_line":"        else:"},{"line_number":357,"context_line":"            neighbor.edge.target_id \u003d neighbor.vertex.vertex_id"},{"line_number":358,"context_line":"            neighbor.edge.source_id \u003d vertex.vertex_id"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    @staticmethod"},{"line_number":361,"context_line":"    def _add_resource_details_to_alarm(vertex, neighbors):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f2577a7_32e9ef19","line":358,"range":{"start_line":351,"start_character":0,"end_line":358,"end_character":54},"updated":"2017-09-12 13:39:43.000000000","message":"This can probably be removed","commit_id":"b5f6b36e1837e6f2ab934f25aee7cbdd473b1521"}],"vitrage/tests/functional/evaluator/test_scenario_evaluator.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"77151809ab921040e0fadff4e3a88409c58a9836","unresolved":false,"context_lines":[{"line_number":526,"context_line":""},{"line_number":527,"context_line":"        # test asserts"},{"line_number":528,"context_line":"        self.assertEqual(num_orig_vertices + num_added_vertices +"},{"line_number":529,"context_line":"                         num_deduced_vertices + num_nagios_alarm_vertices,"},{"line_number":530,"context_line":"                         entity_graph.num_vertices())"},{"line_number":531,"context_line":"        self.assertEqual(num_orig_edges + num_added_edges + num_deduced_edges +"},{"line_number":532,"context_line":"                         num_nagios_alarm_edges, entity_graph.num_edges())"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f2577a7_02ec53f1","line":529,"range":{"start_line":529,"start_character":25,"end_line":529,"end_character":74},"updated":"2017-09-12 21:14:06.000000000","message":"Why did you remove the +1 the Dany added? I didn\u0027t fully understand his comment, I just wonder what has changed","commit_id":"ae3eaefffaa5cc4ccfe6b4696379d6a41305d7fd"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"900fbad3d9266859ca60c89f437c7f4374f16810","unresolved":false,"context_lines":[{"line_number":526,"context_line":""},{"line_number":527,"context_line":"        # test asserts"},{"line_number":528,"context_line":"        self.assertEqual(num_orig_vertices + num_added_vertices +"},{"line_number":529,"context_line":"                         num_deduced_vertices + num_nagios_alarm_vertices,"},{"line_number":530,"context_line":"                         entity_graph.num_vertices())"},{"line_number":531,"context_line":"        self.assertEqual(num_orig_edges + num_added_edges + num_deduced_edges +"},{"line_number":532,"context_line":"                         num_nagios_alarm_edges, entity_graph.num_edges())"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f2577a7_95a191ac","line":529,"range":{"start_line":529,"start_character":25,"end_line":529,"end_character":74},"in_reply_to":"5f2577a7_02ec53f1","updated":"2017-09-13 11:45:23.000000000","message":"In Dany\u0027s solution he added different uuid for every new vertex, that\u0027s why when an alarm that existed in the past was raised again, both of the alarms: the old one and the new one, were in the graph. After my change it\u0027s no longer the situation, I give the same uuid both to old vertex and the new one, so we have one vertex less, as it was before Dany\u0027s change.","commit_id":"ae3eaefffaa5cc4ccfe6b4696379d6a41305d7fd"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"a3c2a6d874dfabe991ab909b1b44e210dcbf484a","unresolved":false,"context_lines":[{"line_number":526,"context_line":""},{"line_number":527,"context_line":"        # test asserts"},{"line_number":528,"context_line":"        self.assertEqual(num_orig_vertices + num_added_vertices +"},{"line_number":529,"context_line":"                         num_deduced_vertices + num_nagios_alarm_vertices,"},{"line_number":530,"context_line":"                         entity_graph.num_vertices())"},{"line_number":531,"context_line":"        self.assertEqual(num_orig_edges + num_added_edges + num_deduced_edges +"},{"line_number":532,"context_line":"                         num_nagios_alarm_edges, entity_graph.num_edges())"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f2577a7_fc28ac34","line":529,"range":{"start_line":529,"start_character":25,"end_line":529,"end_character":74},"in_reply_to":"5f2577a7_95a191ac","updated":"2017-09-24 07:51:52.000000000","message":"OK","commit_id":"ae3eaefffaa5cc4ccfe6b4696379d6a41305d7fd"}],"vitrage/tests/unit/datasources/collectd/test_collectd_transformer.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"77151809ab921040e0fadff4e3a88409c58a9836","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        transformer \u003d self.transformers[COLLECTD_DATASOURCE]"},{"line_number":65,"context_line":"        wrapper \u003d transformer.transform(event)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        entity_key \u003d transformer._create_entity_key(event)"},{"line_number":68,"context_line":"        entity_uuid \u003d transformer.uuid_from_deprecated_vitrage_id(entity_key)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # Test assertions"},{"line_number":71,"context_line":"        self._validate_vertex_props(wrapper.vertex, event)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f2577a7_22786f28","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":77},"updated":"2017-09-12 21:14:06.000000000","message":"Where are the entity_key and entity_uuid used? \nI think you have these two lines duplicated below","commit_id":"ae3eaefffaa5cc4ccfe6b4696379d6a41305d7fd"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"900fbad3d9266859ca60c89f437c7f4374f16810","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        transformer \u003d self.transformers[COLLECTD_DATASOURCE]"},{"line_number":65,"context_line":"        wrapper \u003d transformer.transform(event)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        entity_key \u003d transformer._create_entity_key(event)"},{"line_number":68,"context_line":"        entity_uuid \u003d transformer.uuid_from_deprecated_vitrage_id(entity_key)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # Test assertions"},{"line_number":71,"context_line":"        self._validate_vertex_props(wrapper.vertex, event)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f2577a7_f58fb52b","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":77},"in_reply_to":"5f2577a7_22786f28","updated":"2017-09-13 11:45:23.000000000","message":"Done","commit_id":"ae3eaefffaa5cc4ccfe6b4696379d6a41305d7fd"}]}