)]}'
{"vitrage/datasources/driver_base.py":[{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"0297a67d428c0943679997765a3273a29106bc2d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        pass"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @classmethod"},{"line_number":54,"context_line":"    def make_pickleable(cls, entities, entity_type, datasource_action, *args):"},{"line_number":55,"context_line":"        pickleable_entities \u003d cls.prepare_entities(entities, entity_type,"},{"line_number":56,"context_line":"                                                   datasource_action, args)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if datasource_action \u003d\u003d DatasourceAction.INIT_SNAPSHOT:"},{"line_number":59,"context_line":"            pickleable_entities.append(cls._get_end_message(entity_type))"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        return pickleable_entities"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @classmethod"},{"line_number":64,"context_line":"    def make_pickleable_without_end_msg(cls, entities, entity_type,"},{"line_number":65,"context_line":"                                        datasource_action, *args):"},{"line_number":66,"context_line":"        pickleable_entities \u003d cls.prepare_entities(entities, entity_type,"},{"line_number":67,"context_line":"                                                   datasource_action, args)"},{"line_number":68,"context_line":"        return pickleable_entities"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def prepare_entities(cls, entities, entity_type, datasource_action, args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_adbdfa02","line":68,"range":{"start_line":54,"start_character":0,"end_line":68,"end_character":34},"updated":"2017-11-06 07:22:09.000000000","message":"The two method are almost the same. Is there a way to implement both in one method with optional arguments?\n\nAnother option is to implement it as a decorator.","commit_id":"d3c2193e3d4c3a60c58976e84fa308ca8cc8a0b5"},{"author":{"_account_id":23760,"name":"Idan Narotzki","email":"idan.narotzki@nokia.com","username":"idanaroz"},"change_message_id":"2c1c6549ca935c222eb3d3ca031beee346d21b2f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        pass"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @classmethod"},{"line_number":54,"context_line":"    def make_pickleable(cls, entities, entity_type, datasource_action, *args):"},{"line_number":55,"context_line":"        pickleable_entities \u003d cls.prepare_entities(entities, entity_type,"},{"line_number":56,"context_line":"                                                   datasource_action, args)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if datasource_action \u003d\u003d DatasourceAction.INIT_SNAPSHOT:"},{"line_number":59,"context_line":"            pickleable_entities.append(cls._get_end_message(entity_type))"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        return pickleable_entities"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @classmethod"},{"line_number":64,"context_line":"    def make_pickleable_without_end_msg(cls, entities, entity_type,"},{"line_number":65,"context_line":"                                        datasource_action, *args):"},{"line_number":66,"context_line":"        pickleable_entities \u003d cls.prepare_entities(entities, entity_type,"},{"line_number":67,"context_line":"                                                   datasource_action, args)"},{"line_number":68,"context_line":"        return pickleable_entities"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def prepare_entities(cls, entities, entity_type, datasource_action, args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_cdaef62c","line":68,"range":{"start_line":54,"start_character":0,"end_line":68,"end_character":34},"in_reply_to":"3f4b6375_adbdfa02","updated":"2017-11-06 07:56:08.000000000","message":"Adding optional argument to make_pickleable might be a problematic, because of the \"*args\":\nDrivers that pass extra params to make_pickleable won\u0027t behave as expected.","commit_id":"d3c2193e3d4c3a60c58976e84fa308ca8cc8a0b5"}]}