)]}'
{"vitrage/evaluator/evaluator_service.py":[{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"964c00e72519db92fb52a5a18360041a51d97d2d","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def start(self):"},{"line_number":115,"context_line":"        super(EvaluatorWorker, self).start()"},{"line_number":116,"context_line":"        self._entity_graph.notifier._subscriptions \u003d []  # Quick n dirty"},{"line_number":117,"context_line":"        self._evaluator \u003d ScenarioEvaluator("},{"line_number":118,"context_line":"            self._conf,"},{"line_number":119,"context_line":"            self._entity_graph,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_437aa688","line":116,"range":{"start_line":116,"start_character":8,"end_line":116,"end_character":56},"updated":"2017-11-09 06:43:00.000000000","message":"Sorry, I don\u0027t understand. Why you change the order it can be works? It will be clear the subscription from process.\nsee:\nhttps://git.openstack.org/cgit/openstack/vitrage/tree/vitrage/entity_graph/processor/processor.py?h\u003drefs/heads/master#n193","commit_id":"5d94cc253f398ba6667fdf000d6f8fec60f240b4"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"7c51d6008d1dc04258dfda4b7fe0e2aa461a9506","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def start(self):"},{"line_number":115,"context_line":"        super(EvaluatorWorker, self).start()"},{"line_number":116,"context_line":"        self._entity_graph.notifier._subscriptions \u003d []  # Quick n dirty"},{"line_number":117,"context_line":"        self._evaluator \u003d ScenarioEvaluator("},{"line_number":118,"context_line":"            self._conf,"},{"line_number":119,"context_line":"            self._entity_graph,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_639a42c6","line":116,"range":{"start_line":116,"start_character":8,"end_line":116,"end_character":56},"in_reply_to":"1f485f77_437aa688","updated":"2017-11-09 06:44:04.000000000","message":"clear-\u003eclean","commit_id":"5d94cc253f398ba6667fdf000d6f8fec60f240b4"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"8cb9cdd6f261453a529c04c179343484a281be68","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def start(self):"},{"line_number":115,"context_line":"        super(EvaluatorWorker, self).start()"},{"line_number":116,"context_line":"        self._entity_graph.notifier._subscriptions \u003d []  # Quick n dirty"},{"line_number":117,"context_line":"        self._evaluator \u003d ScenarioEvaluator("},{"line_number":118,"context_line":"            self._conf,"},{"line_number":119,"context_line":"            self._entity_graph,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_c6d8e480","line":116,"range":{"start_line":116,"start_character":8,"end_line":116,"end_character":56},"in_reply_to":"1f485f77_639a42c6","updated":"2017-11-09 07:46:19.000000000","message":"Graph subscriptions in the manager, should be two:\n * GraphNotifier.notify_when_applicable - For the notifier\n * EvaluatorManager._notify_all - To notify all the workers of each change\n\nGraph subscriptions in each worker should be one: \n * ScenarioEvaluator.process_event - so every event is processed in it\u0027s evaluator\n\n\nSo the parent process is the manager, and when creating a subprocess worker, it contains the cloned memory of the graph and subscriptions. The worker does not need these subscriptions, it needs only the Evaluator.","commit_id":"5d94cc253f398ba6667fdf000d6f8fec60f240b4"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"f9d74b73cc84c37b3c2a7eb414bffb5d0ce8d8ef","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def start(self):"},{"line_number":115,"context_line":"        super(EvaluatorWorker, self).start()"},{"line_number":116,"context_line":"        self._entity_graph.notifier._subscriptions \u003d []  # Quick n dirty"},{"line_number":117,"context_line":"        self._evaluator \u003d ScenarioEvaluator("},{"line_number":118,"context_line":"            self._conf,"},{"line_number":119,"context_line":"            self._entity_graph,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_89e2fd2e","line":116,"range":{"start_line":116,"start_character":8,"end_line":116,"end_character":56},"in_reply_to":"1f485f77_660490c7","updated":"2017-11-09 08:48:53.000000000","message":"OK,understood.Thanks~","commit_id":"5d94cc253f398ba6667fdf000d6f8fec60f240b4"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"ca0f2df169d7407075950b58558fafdcd5a2f526","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def start(self):"},{"line_number":115,"context_line":"        super(EvaluatorWorker, self).start()"},{"line_number":116,"context_line":"        self._entity_graph.notifier._subscriptions \u003d []  # Quick n dirty"},{"line_number":117,"context_line":"        self._evaluator \u003d ScenarioEvaluator("},{"line_number":118,"context_line":"            self._conf,"},{"line_number":119,"context_line":"            self._entity_graph,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_660490c7","line":116,"range":{"start_line":116,"start_character":8,"end_line":116,"end_character":56},"in_reply_to":"1f485f77_c6d8e480","updated":"2017-11-09 07:51:33.000000000","message":"The bug was that the subscriptions were deleted in the parent process instead of in the subprocess","commit_id":"5d94cc253f398ba6667fdf000d6f8fec60f240b4"}]}