)]}'
{"vitrage/notifier/plugins/nova/nova_notifier.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"58e5ee9a905d6437a71cb5515778598d9cff7e78","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def process_event(self, data, event_type):"},{"line_number":41,"context_line":"        if data and data.get(VProps.VITRAGE_TYPE) in self.actions:"},{"line_number":42,"context_line":"            action \u003d self.actions[data.get(VProps.VITRAGE_TYPE)]"},{"line_number":43,"context_line":"            if event_type \u003d\u003d NotifierEventTypes.ACTIVATE_MARK_DOWN_EVENT:"},{"line_number":44,"context_line":"                action(data.get(VProps.ID), True)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_cd6fb1c3","line":41,"range":{"start_line":41,"start_character":16,"end_line":41,"end_character":65},"updated":"2017-11-21 08:47:24.000000000","message":"Maybe it\u0027s worth to write a warning to the log if mark-down is set for another resource type","commit_id":"1511f4c3ef6971e94afb064a0d2fc8d7209dcb1c"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"93c96358b483c57986b339a58d10532dab9a81d9","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def process_event(self, data, event_type):"},{"line_number":41,"context_line":"        if data and data.get(VProps.VITRAGE_TYPE) in self.actions:"},{"line_number":42,"context_line":"            action \u003d self.actions[data.get(VProps.VITRAGE_TYPE)]"},{"line_number":43,"context_line":"            if event_type \u003d\u003d NotifierEventTypes.ACTIVATE_MARK_DOWN_EVENT:"},{"line_number":44,"context_line":"                action(data.get(VProps.ID), True)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_7dd71eef","line":41,"range":{"start_line":41,"start_character":16,"end_line":41,"end_character":65},"in_reply_to":"ff82abbf_cd6fb1c3","updated":"2017-11-22 00:51:49.000000000","message":"Done","commit_id":"1511f4c3ef6971e94afb064a0d2fc8d7209dcb1c"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"58e5ee9a905d6437a71cb5515778598d9cff7e78","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            LOG.exception(\u0027Failed to services.force_down - %s\u0027, e)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _reset_instance_state(self, server_id, is_down):"},{"line_number":59,"context_line":"        state \u003d \u0027error\u0027 if is_down else \u0027active\u0027"},{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            LOG.info(\u0027Nova servers.reset_state - server: %s, state: %s\u0027,"},{"line_number":62,"context_line":"                     str(server_id), str(state))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_cd7d716f","line":59,"range":{"start_line":59,"start_character":16,"end_line":59,"end_character":23},"updated":"2017-11-21 08:47:24.000000000","message":"Please define \u0027error\u0027 and \u0027active\u0027 as constants","commit_id":"1511f4c3ef6971e94afb064a0d2fc8d7209dcb1c"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"93c96358b483c57986b339a58d10532dab9a81d9","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            LOG.exception(\u0027Failed to services.force_down - %s\u0027, e)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _reset_instance_state(self, server_id, is_down):"},{"line_number":59,"context_line":"        state \u003d \u0027error\u0027 if is_down else \u0027active\u0027"},{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            LOG.info(\u0027Nova servers.reset_state - server: %s, state: %s\u0027,"},{"line_number":62,"context_line":"                     str(server_id), str(state))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_1d061288","line":59,"range":{"start_line":59,"start_character":16,"end_line":59,"end_character":23},"in_reply_to":"ff82abbf_cd7d716f","updated":"2017-11-22 00:51:49.000000000","message":"Done","commit_id":"1511f4c3ef6971e94afb064a0d2fc8d7209dcb1c"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"b69e4306e1bb396ca0f74e667762a91fc90e9db1","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            elif event_type \u003d\u003d NotifierEventTypes.DEACTIVATE_MARK_DOWN_EVENT:"},{"line_number":47,"context_line":"                action(data.get(VProps.ID), False)"},{"line_number":48,"context_line":"        elif data:"},{"line_number":49,"context_line":"            LOG.warning(\u0027Unsupport datasource type %s\u0027,"},{"line_number":50,"context_line":"                        data.get(VProps.VITRAGE_TYPE))"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _mark_host_down(self, host_id, is_down):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_90143950","line":49,"range":{"start_line":49,"start_character":25,"end_line":49,"end_character":50},"updated":"2017-11-22 11:30:36.000000000","message":"Please write a more concrete message, like: mark-down action is not supported for resource type %s.\n\nI don\u0027t want the user to mistakenly understand that there is a general problem with the datasource... the problem is only in mark-down","commit_id":"e9f172b0b5aa8a962dcca583b46b22ad65a12a66"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"f04d0f2755e3c9ca74b75cc1adff7fade0b488a4","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            elif event_type \u003d\u003d NotifierEventTypes.DEACTIVATE_MARK_DOWN_EVENT:"},{"line_number":47,"context_line":"                action(data.get(VProps.ID), False)"},{"line_number":48,"context_line":"        elif data:"},{"line_number":49,"context_line":"            LOG.warning(\u0027Unsupport datasource type %s\u0027,"},{"line_number":50,"context_line":"                        data.get(VProps.VITRAGE_TYPE))"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _mark_host_down(self, host_id, is_down):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_998d337d","line":49,"range":{"start_line":49,"start_character":25,"end_line":49,"end_character":50},"in_reply_to":"ff82abbf_90143950","updated":"2017-11-23 00:49:09.000000000","message":"You\u0027re right. Fix it. Thanks~","commit_id":"e9f172b0b5aa8a962dcca583b46b22ad65a12a66"}]}