)]}'
{"vitrage_tempest_tests/tests/common/general_utils.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"186081b2e804d0498379d9ee0066d4f0a3f9c88f","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def is_subset(subset, full):"},{"line_number":32,"context_line":"    if not subset:"},{"line_number":33,"context_line":"        return full"},{"line_number":34,"context_line":"    return six.viewitems(subset) \u003c\u003d six.viewitems(full)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_17020a3e","line":33,"range":{"start_line":33,"start_character":15,"end_line":33,"end_character":19},"updated":"2017-11-27 10:58:21.000000000","message":"Why not return true?","commit_id":"8cb9777b5318353bc15a35f6a29d826375a49864"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"c2a8daa482a21ef1dbb4cf13eb4b174e4b74fdc0","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def is_subset(subset, full):"},{"line_number":32,"context_line":"    if not subset:"},{"line_number":33,"context_line":"        return full"},{"line_number":34,"context_line":"    return six.viewitems(subset) \u003c\u003d six.viewitems(full)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_fdaf47e0","line":33,"range":{"start_line":33,"start_character":15,"end_line":33,"end_character":19},"in_reply_to":"ff82abbf_17020a3e","updated":"2017-11-27 15:28:15.000000000","message":"done","commit_id":"8cb9777b5318353bc15a35f6a29d826375a49864"}],"vitrage_tempest_tests/tests/common/nova_utils.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"186081b2e804d0498379d9ee0066d4f0a3f9c88f","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def delete_all_instances(_id\u003dNone):"},{"line_number":44,"context_line":"    orig_items \u003d TempestClients.nova().servers.list()"},{"line_number":45,"context_line":"    items \u003d g_utils.get_all_matches(orig_items, id\u003d_id)"},{"line_number":46,"context_line":"    for item in items:"},{"line_number":47,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_57bad26d","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":14},"updated":"2017-11-27 10:58:21.000000000","message":"Why items instead of instances?","commit_id":"8cb9777b5318353bc15a35f6a29d826375a49864"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"c2a8daa482a21ef1dbb4cf13eb4b174e4b74fdc0","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def delete_all_instances(_id\u003dNone):"},{"line_number":44,"context_line":"    orig_items \u003d TempestClients.nova().servers.list()"},{"line_number":45,"context_line":"    items \u003d g_utils.get_all_matches(orig_items, id\u003d_id)"},{"line_number":46,"context_line":"    for item in items:"},{"line_number":47,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_fd98a7c0","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":14},"in_reply_to":"ff82abbf_57bad26d","updated":"2017-11-27 15:28:15.000000000","message":"done","commit_id":"8cb9777b5318353bc15a35f6a29d826375a49864"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"186081b2e804d0498379d9ee0066d4f0a3f9c88f","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def delete_all_instances(_id\u003dNone):"},{"line_number":44,"context_line":"    orig_items \u003d TempestClients.nova().servers.list()"},{"line_number":45,"context_line":"    items \u003d g_utils.get_all_matches(orig_items, id\u003d_id)"},{"line_number":46,"context_line":"    for item in items:"},{"line_number":47,"context_line":"        try:"},{"line_number":48,"context_line":"            TempestClients.nova().servers.delete(item)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_77bfd660","line":45,"range":{"start_line":45,"start_character":4,"end_line":45,"end_character":9},"updated":"2017-11-27 10:58:21.000000000","message":"Maybe rename it to \u0027items_to_delete\u0027","commit_id":"8cb9777b5318353bc15a35f6a29d826375a49864"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"c2a8daa482a21ef1dbb4cf13eb4b174e4b74fdc0","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def delete_all_instances(_id\u003dNone):"},{"line_number":44,"context_line":"    orig_items \u003d TempestClients.nova().servers.list()"},{"line_number":45,"context_line":"    items \u003d g_utils.get_all_matches(orig_items, id\u003d_id)"},{"line_number":46,"context_line":"    for item in items:"},{"line_number":47,"context_line":"        try:"},{"line_number":48,"context_line":"            TempestClients.nova().servers.delete(item)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_1d96ab94","line":45,"range":{"start_line":45,"start_character":4,"end_line":45,"end_character":9},"in_reply_to":"ff82abbf_77bfd660","updated":"2017-11-27 15:28:15.000000000","message":"done","commit_id":"8cb9777b5318353bc15a35f6a29d826375a49864"}],"vitrage_tempest_tests/tests/e2e/test_basic_actions.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"186081b2e804d0498379d9ee0066d4f0a3f9c88f","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            alarms \u003d TempestClients.vitrage().alarm.list("},{"line_number":174,"context_line":"                vitrage_id\u003dself.orig_host.get(VProps.VITRAGE_ID),"},{"line_number":175,"context_line":"                all_tenants\u003dTrue)"},{"line_number":176,"context_line":"            self.assertEqual(True, len(alarms) \u003e\u003d 2, \u0027alarms %s\u0027 % str(alarms))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"            deduced \u003d g_utils.get_first_match(alarms, **DEDUCED_PROPS)"},{"line_number":179,"context_line":"            trigger \u003d g_utils.get_first_match(alarms, **TRIGGER_ALARM_2_PROPS)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_42576ecb","line":176,"range":{"start_line":176,"start_character":35,"end_line":176,"end_character":51},"updated":"2017-11-27 10:58:21.000000000","message":"Why do you check \u003e\u003d and not \u003d ?","commit_id":"8cb9777b5318353bc15a35f6a29d826375a49864"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"c2a8daa482a21ef1dbb4cf13eb4b174e4b74fdc0","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            alarms \u003d TempestClients.vitrage().alarm.list("},{"line_number":174,"context_line":"                vitrage_id\u003dself.orig_host.get(VProps.VITRAGE_ID),"},{"line_number":175,"context_line":"                all_tenants\u003dTrue)"},{"line_number":176,"context_line":"            self.assertEqual(True, len(alarms) \u003e\u003d 2, \u0027alarms %s\u0027 % str(alarms))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"            deduced \u003d g_utils.get_first_match(alarms, **DEDUCED_PROPS)"},{"line_number":179,"context_line":"            trigger \u003d g_utils.get_first_match(alarms, **TRIGGER_ALARM_2_PROPS)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_5d80b346","line":176,"range":{"start_line":176,"start_character":35,"end_line":176,"end_character":51},"in_reply_to":"ff82abbf_42576ecb","updated":"2017-11-27 15:28:15.000000000","message":"Perhaps the system contains other alarms.\nIn the next line we check the 2 expected alarms exist.","commit_id":"8cb9777b5318353bc15a35f6a29d826375a49864"}],"vitrage_tempest_tests/tests/e2e/test_overlapping_actions.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"186081b2e804d0498379d9ee0066d4f0a3f9c88f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            self._trigger_undo_action(TRIGGER_ALARM_2)"},{"line_number":82,"context_line":"            curr_host \u003d vitrage_utils.get_first_host()"},{"line_number":83,"context_line":"            self.assertEqual("},{"line_number":84,"context_line":"                self.orig_host.get(VProps.VITRAGE_AGGREGATED_STATE),"},{"line_number":85,"context_line":"                curr_host.get(VProps.VITRAGE_AGGREGATED_STATE),"},{"line_number":86,"context_line":"                \u0027state should change after undo set_state action\u0027)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_e2fc82b6","line":84,"range":{"start_line":84,"start_character":16,"end_line":84,"end_character":67},"updated":"2017-11-27 10:58:21.000000000","message":"What if the original state of the host was ERROR? this test won\u0027t actually check anything","commit_id":"8cb9777b5318353bc15a35f6a29d826375a49864"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"c2a8daa482a21ef1dbb4cf13eb4b174e4b74fdc0","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            self._trigger_undo_action(TRIGGER_ALARM_2)"},{"line_number":82,"context_line":"            curr_host \u003d vitrage_utils.get_first_host()"},{"line_number":83,"context_line":"            self.assertEqual("},{"line_number":84,"context_line":"                self.orig_host.get(VProps.VITRAGE_AGGREGATED_STATE),"},{"line_number":85,"context_line":"                curr_host.get(VProps.VITRAGE_AGGREGATED_STATE),"},{"line_number":86,"context_line":"                \u0027state should change after undo set_state action\u0027)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_3df04ffd","line":84,"range":{"start_line":84,"start_character":16,"end_line":84,"end_character":67},"in_reply_to":"ff82abbf_e2fc82b6","updated":"2017-11-27 15:28:15.000000000","message":"During setupUpClass method (in the base class) before the tests run, we check the initial host status is AVAILABLE","commit_id":"8cb9777b5318353bc15a35f6a29d826375a49864"}]}