)]}'
{"vitrage/storage/impl_sqlalchemy.py":[{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"0a2ce1f4bb5204e884542ef86c04f6956f8482e3","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            is_deleted\u003dis_deleted,"},{"line_number":124,"context_line":"            template_type\u003dtemplate_type,"},{"line_number":125,"context_line":"            )"},{"line_number":126,"context_line":"        return query.order_by(desc(Template.created_at)).all()"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def delete(self, name\u003dNone, file_content\u003dNone,"},{"line_number":129,"context_line":"               uuid\u003dNone, status\u003dNone, status_details\u003dNone, is_deleted\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_b4fc163f","line":126,"range":{"start_line":126,"start_character":15,"end_line":126,"end_character":62},"updated":"2017-12-28 12:42:13.000000000","message":"should this be sorted here?","commit_id":"050e4a0bfaa4dd230edd998514d968d1fc2e615a"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"893aa313860e0e17a628f3841e606a321dc428d1","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        with session.begin():"},{"line_number":106,"context_line":"            session.add(template)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def update(self, uuid, var, value):"},{"line_number":109,"context_line":"        session \u003d self._engine_facade.get_session()"},{"line_number":110,"context_line":"        with session.begin():"},{"line_number":111,"context_line":"            session.query(Template).filter_by(uuid\u003duuid).update({var: value})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_7091a752","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":14},"updated":"2017-12-31 07:06:38.000000000","message":"Are we going to use it in this version?","commit_id":"714dddbb4d5ccb37dd4d6fb26a7e4918ddda2762"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"893aa313860e0e17a628f3841e606a321dc428d1","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        with session.begin():"},{"line_number":111,"context_line":"            session.query(Template).filter_by(uuid\u003duuid).update({var: value})"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def query(self, name\u003dNone, file_content\u003dNone,"},{"line_number":114,"context_line":"              uuid\u003dNone, status\u003dNone, status_details\u003dNone, is_deleted\u003dNone,"},{"line_number":115,"context_line":"              template_type\u003dNone):"},{"line_number":116,"context_line":"        query \u003d self.query_filter("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_109e1b63","line":113,"range":{"start_line":113,"start_character":8,"end_line":113,"end_character":13},"updated":"2017-12-31 07:06:38.000000000","message":"Same question","commit_id":"714dddbb4d5ccb37dd4d6fb26a7e4918ddda2762"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"893aa313860e0e17a628f3841e606a321dc428d1","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            )"},{"line_number":126,"context_line":"        return query.all()"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def delete(self, name\u003dNone, file_content\u003dNone,"},{"line_number":129,"context_line":"               uuid\u003dNone, status\u003dNone, status_details\u003dNone, is_deleted\u003dNone,"},{"line_number":130,"context_line":"               template_type\u003dNone):"},{"line_number":131,"context_line":"        query \u003d self.query_filter("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_309b1f73","line":128,"range":{"start_line":128,"start_character":8,"end_line":128,"end_character":14},"updated":"2017-12-31 07:06:38.000000000","message":"I don\u0027t think we should support deletion by these parameters. Will you ever want to delete all templates with specific status_details? I think we should delete only by name or id. And maybe we should also verify that the query returns a single result.","commit_id":"714dddbb4d5ccb37dd4d6fb26a7e4918ddda2762"}],"vitrage/storage/sqlalchemy/models.py":[{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"0a2ce1f4bb5204e884542ef86c04f6956f8482e3","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    __tablename__ \u003d \u0027templates\u0027"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    uuid \u003d Column(\"id\", String(64), primary_key\u003dTrue, nullable\u003dFalse)"},{"line_number":134,"context_line":"    status \u003d Column(String(16), primary_key\u003dTrue)"},{"line_number":135,"context_line":"    status_details \u003d Column(String(128))"},{"line_number":136,"context_line":"    name \u003d Column(String(128), primary_key\u003dTrue, nullable\u003dFalse)"},{"line_number":137,"context_line":"    file_content \u003d Column(MagicJSON, nullable\u003dFalse)"},{"line_number":138,"context_line":"    is_deleted \u003d Column(Boolean, nullable\u003dFalse, default\u003dFalse)"},{"line_number":139,"context_line":"    template_type \u003d Column(\"type\", String(64), primary_key\u003dTrue,"},{"line_number":140,"context_line":"                           default\u003d\u0027standard\u0027)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def __repr__(self):"},{"line_number":143,"context_line":"        return \"\u003cTemplate(id\u003d\u0027%s\u0027, name\u003d\u0027%s\u0027, created_at\u003d\u0027%s\u0027,\" \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_74c68e19","line":140,"range":{"start_line":134,"start_character":0,"end_line":140,"end_character":46},"updated":"2017-12-28 12:42:13.000000000","message":"only uuid should be the primary key","commit_id":"050e4a0bfaa4dd230edd998514d968d1fc2e615a"}]}
