)]}'
{"vitrage/datasources/static/driver.py":[{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"2d1f3473b44f3db3e3767b1d81b12949e87ee478","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        return list(reduce(chain, [self._get_entities_from_file(path)"},{"line_number":71,"context_line":"                                   for path in files], []))"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def _get_and_cache_changed_entities(self):"},{"line_number":74,"context_line":"        changed_entities \u003d []"},{"line_number":75,"context_line":"        new_entities \u003d self._get_all_entities()"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e0346295","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":39},"updated":"2018-05-13 10:35:57.000000000","message":"so this example maybe this is better:\n\ndef dict_diff(left, right):\n    diff \u003d dict()\n    diff[\u0027left_only\u0027] \u003d set(left) - set(right)\n    diff[\u0027right_only\u0027] \u003d set(right) - set(left)\n    diff[\u0027different\u0027] \u003d {k for k in set(left) \u0026 set(right) if left[k]!\u003dright[k]}\n    return diff\n\n\u003e\u003e\u003e d1 \u003d dict(a\u003d1, b\u003d20, c\u003d30, e\u003d50)\n\u003e\u003e\u003e d2 \u003d dict(a\u003d1, b\u003d200, d\u003d400, e\u003d500)\n\u003e\u003e\u003e dict_diff(d1, d2)\n{\u0027different\u0027: {\u0027b\u0027, \u0027e\u0027}, \u0027left_only\u0027: {\u0027c\u0027}, \u0027right_only\u0027: {\u0027d\u0027}}","commit_id":"ff19f33aaacf3eb31e629a40919b6bdfb2cd382f"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"b728d5951ce66e82c04f4417e4d08edac19cbd38","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        return list(reduce(chain, [self._get_entities_from_file(path)"},{"line_number":71,"context_line":"                                   for path in files], []))"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def _get_and_cache_changed_entities(self):"},{"line_number":74,"context_line":"        changed_entities \u003d []"},{"line_number":75,"context_line":"        new_entities \u003d self._get_all_entities()"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_16c131e5","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":39},"in_reply_to":"5f7c97a3_e0346295","updated":"2018-06-05 15:43:30.000000000","message":"Theoretically your solution looks more elegant, but when I tried to use it it became more complex because: I get a list, need to convert it to a dict, then subtract sets, then get the full entities again, and at the end convert back to a list... \n\nAre you sure it\u0027s worth it?","commit_id":"ff19f33aaacf3eb31e629a40919b6bdfb2cd382f"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"2acef7b2d5545679f7bf541c84e2bef60393a56b","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                    and entity[StaticFields.ID] \u003d\u003d \\"},{"line_number":178,"context_line":"                    search_entity[StaticFields.ID]:"},{"line_number":179,"context_line":"                return entity"},{"line_number":180,"context_line":"        return None"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @staticmethod"},{"line_number":183,"context_line":"    def _equal_entities(old_entity, new_entity):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_14ed52ef","line":180,"updated":"2018-05-25 04:46:43.000000000","message":"We can omit \u0027return None\u0027 here. Method will return None by default","commit_id":"1e95fb60d0851a3961aa828d7ee32e5b5848adce"}]}
