)]}'
{".zuul.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0b0ba736a29ae426591f7f59208332ba5749ae17","unresolved":false,"context_lines":[{"line_number":129,"context_line":"- job:"},{"line_number":130,"context_line":"    name: grenade-vitrage"},{"line_number":131,"context_line":"    parent: legacy-dsvm-base"},{"line_number":132,"context_line":"    nodeset: ubuntu-xenial"},{"line_number":133,"context_line":"    run: playbooks/legacy/vitrage-grenade/run.yaml"},{"line_number":134,"context_line":"    timeout: 7800"},{"line_number":135,"context_line":"    required-projects:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_7e9665f2","line":132,"range":{"start_line":132,"start_character":4,"end_line":132,"end_character":26},"updated":"2018-06-14 18:25:21.000000000","message":"You likely don\u0027t need to set this and can just get it for free from legacy-dsvm-base.","commit_id":"96e912cc1a1ab0cb939e1648e1ca835985947d37"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"87a1767e07204f629125e0993b9771336f8c68b7","unresolved":false,"context_lines":[{"line_number":129,"context_line":"- job:"},{"line_number":130,"context_line":"    name: grenade-vitrage"},{"line_number":131,"context_line":"    parent: legacy-dsvm-base"},{"line_number":132,"context_line":"    run: playbooks/legacy/vitrage-grenade/run.yaml"},{"line_number":133,"context_line":"    timeout: 7800"},{"line_number":134,"context_line":"    required-projects:"},{"line_number":135,"context_line":"      - openstack-dev/grenade"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5f7c97a3_ca27afc7","line":132,"updated":"2018-06-14 21:54:10.000000000","message":"You need to define a post run for log collection:\n\nhttps://git.openstack.org/cgit/openstack/neutron/tree/.zuul.yaml#n282\n\nhttps://git.openstack.org/cgit/openstack/neutron/tree/playbooks/legacy/neutron-grenade/post.yaml","commit_id":"5efe3df455a9b76813b31bfc680c4e977a8e5288"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"6b449071d829cd66578a00af6ef0be301611afe9","unresolved":false,"context_lines":[{"line_number":129,"context_line":"- job:"},{"line_number":130,"context_line":"    name: grenade-vitrage"},{"line_number":131,"context_line":"    parent: legacy-dsvm-base"},{"line_number":132,"context_line":"    run: playbooks/legacy/vitrage-grenade/run.yaml"},{"line_number":133,"context_line":"    timeout: 7800"},{"line_number":134,"context_line":"    required-projects:"},{"line_number":135,"context_line":"      - openstack-dev/grenade"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5f7c97a3_83719cab","line":132,"in_reply_to":"5f7c97a3_ca27afc7","updated":"2018-06-15 07:19:46.000000000","message":"Thanks!","commit_id":"5efe3df455a9b76813b31bfc680c4e977a8e5288"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"4a47be9b7f9e3cc1940ed33ef95fc6a0ee5c39a9","unresolved":false,"context_lines":[{"line_number":129,"context_line":"- job:"},{"line_number":130,"context_line":"    name: grenade-vitrage"},{"line_number":131,"context_line":"    parent: legacy-dsvm-base"},{"line_number":132,"context_line":"    run: playbooks/legacy/vitrage-grenade/run.yaml"},{"line_number":133,"context_line":"    post-run: playbooks/legacy/vitrage-grenade/post.yaml"},{"line_number":134,"context_line":"    timeout: 7800"},{"line_number":135,"context_line":"    required-projects:"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"5f7c97a3_1a18bdca","line":132,"range":{"start_line":132,"start_character":19,"end_line":132,"end_character":25},"updated":"2018-06-26 14:11:22.000000000","message":"Any reason this is placed under legacy?","commit_id":"bbaf885878ade52fb318a9c938aca33e5d6f13e8"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"f02a6bb3675271ebe2e3e8d7795292f73886919c","unresolved":false,"context_lines":[{"line_number":129,"context_line":"- job:"},{"line_number":130,"context_line":"    name: grenade-vitrage"},{"line_number":131,"context_line":"    parent: legacy-dsvm-base"},{"line_number":132,"context_line":"    run: playbooks/legacy/vitrage-grenade/run.yaml"},{"line_number":133,"context_line":"    post-run: playbooks/legacy/vitrage-grenade/post.yaml"},{"line_number":134,"context_line":"    timeout: 7800"},{"line_number":135,"context_line":"    required-projects:"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"5f7c97a3_da332512","line":132,"range":{"start_line":132,"start_character":19,"end_line":132,"end_character":25},"in_reply_to":"5f7c97a3_1a18bdca","updated":"2018-06-26 14:16:38.000000000","message":"Because it uses a legacy style of job definition. AFAIK, there is now ansible-based roles for grenade:(","commit_id":"bbaf885878ade52fb318a9c938aca33e5d6f13e8"}],"devstack/upgrade/settings":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"4a47be9b7f9e3cc1940ed33ef95fc6a0ee5c39a9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VITRAGE_DIR\u003d$TOP_DIR/../../new/vitrage"},{"line_number":8,"context_line":"source $VITRAGE_BASE_DEVSTACK_DIR/settings"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"devstack_localrc base enable_service vitrage-collector vitrage-graph vitrage-notifier vitrage-ml vitrage-persistor vitrage-snmp-parsing"},{"line_number":11,"context_line":"devstack_localrc target enable_service vitrage-collector vitrage-graph vitrage-notifier vitrage-ml vitrage-persistor vitrage-snmp-parsing"},{"line_number":12,"context_line":"BASE_RUN_SMOKE\u003dFalse"},{"line_number":13,"context_line":"TARGET_RUN_SMOKE\u003dFalse"}],"source_content_type":"application/octet-stream","patch_set":31,"id":"5f7c97a3_9a5a8d7f","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":135},"updated":"2018-06-26 14:11:22.000000000","message":"Missing vitrage-api?","commit_id":"bbaf885878ade52fb318a9c938aca33e5d6f13e8"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"f02a6bb3675271ebe2e3e8d7795292f73886919c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VITRAGE_DIR\u003d$TOP_DIR/../../new/vitrage"},{"line_number":8,"context_line":"source $VITRAGE_BASE_DEVSTACK_DIR/settings"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"devstack_localrc base enable_service vitrage-collector vitrage-graph vitrage-notifier vitrage-ml vitrage-persistor vitrage-snmp-parsing"},{"line_number":11,"context_line":"devstack_localrc target enable_service vitrage-collector vitrage-graph vitrage-notifier vitrage-ml vitrage-persistor vitrage-snmp-parsing"},{"line_number":12,"context_line":"BASE_RUN_SMOKE\u003dFalse"},{"line_number":13,"context_line":"TARGET_RUN_SMOKE\u003dFalse"}],"source_content_type":"application/octet-stream","patch_set":31,"id":"5f7c97a3_3a2499c5","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":135},"in_reply_to":"5f7c97a3_9a5a8d7f","updated":"2018-06-26 14:16:38.000000000","message":"Yes, I forgot about it. Will add it in the ext patch","commit_id":"bbaf885878ade52fb318a9c938aca33e5d6f13e8"}],"devstack/upgrade/shutdhown.sh":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"63bb0141c767e9d3a111c5b9c214b66980410eee","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"stop_vitrage"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"SERVICES_DOWN\u003d\"vitrage-collector vitrage-graph vitrage-notifier vitrage-ml vitrage-persistor vitrage-snmp-parsing\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# sanity check that services are actually down"},{"line_number":35,"context_line":"ensure_services_stopped $SERVICES_DOWN"}],"source_content_type":"text/x-sh","patch_set":29,"id":"5f7c97a3_78412ba6","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":114},"updated":"2018-06-20 12:00:11.000000000","message":"What about API changes? don\u0027t you need to shutdown apache2?","commit_id":"bcedd6d38b6ddb185fd62d32d181d4081d158b6f"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"92f1ca25d9c7b647a0b0147132332511e81db493","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"stop_vitrage"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"SERVICES_DOWN\u003d\"vitrage-collector vitrage-graph vitrage-notifier vitrage-ml vitrage-persistor vitrage-snmp-parsing\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# sanity check that services are actually down"},{"line_number":35,"context_line":"ensure_services_stopped $SERVICES_DOWN"}],"source_content_type":"text/x-sh","patch_set":29,"id":"5f7c97a3_0da189a9","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":114},"in_reply_to":"5f7c97a3_78412ba6","updated":"2018-06-25 09:07:31.000000000","message":"Good catch, I\u0027ll add it","commit_id":"bcedd6d38b6ddb185fd62d32d181d4081d158b6f"}],"devstack/upgrade/upgrade.sh":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"63bb0141c767e9d3a111c5b9c214b66980410eee","unresolved":false,"context_lines":[{"line_number":46,"context_line":"set -o errexit"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Upgrade Vitrage"},{"line_number":49,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# Locate vitrage devstack plugin, the directory above the"},{"line_number":52,"context_line":"# grenade plugin."}],"source_content_type":"text/x-sh","patch_set":29,"id":"5f7c97a3_781a8bc6","line":49,"range":{"start_line":49,"start_character":2,"end_line":49,"end_character":14},"updated":"2018-06-20 12:00:11.000000000","message":"Missing \u003d\u003d","commit_id":"bcedd6d38b6ddb185fd62d32d181d4081d158b6f"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"92f1ca25d9c7b647a0b0147132332511e81db493","unresolved":false,"context_lines":[{"line_number":46,"context_line":"set -o errexit"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Upgrade Vitrage"},{"line_number":49,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# Locate vitrage devstack plugin, the directory above the"},{"line_number":52,"context_line":"# grenade plugin."}],"source_content_type":"text/x-sh","patch_set":29,"id":"5f7c97a3_eda9ad8e","line":49,"range":{"start_line":49,"start_character":2,"end_line":49,"end_character":14},"in_reply_to":"5f7c97a3_781a8bc6","updated":"2018-06-25 09:07:31.000000000","message":"Done","commit_id":"bcedd6d38b6ddb185fd62d32d181d4081d158b6f"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"4a47be9b7f9e3cc1940ed33ef95fc6a0ee5c39a9","unresolved":false,"context_lines":[{"line_number":72,"context_line":"# Install the target vitrage"},{"line_number":73,"context_line":"source $VITRAGE_DEVSTACK_DIR/plugin.sh stack install"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# calls upgrade-vitragefor specific release"},{"line_number":76,"context_line":"upgrade_project vitrage $RUN_DIR $BASE_DEVSTACK_BRANCH $TARGET_DEVSTACK_BRANCH"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Simulate init_vitrage()"}],"source_content_type":"text/x-sh","patch_set":31,"id":"5f7c97a3_5afe3538","line":75,"range":{"start_line":75,"start_character":16,"end_line":75,"end_character":26},"updated":"2018-06-26 14:11:22.000000000","message":"Missing white space before \u0027for\u0027","commit_id":"bbaf885878ade52fb318a9c938aca33e5d6f13e8"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"f02a6bb3675271ebe2e3e8d7795292f73886919c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"# Install the target vitrage"},{"line_number":73,"context_line":"source $VITRAGE_DEVSTACK_DIR/plugin.sh stack install"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# calls upgrade-vitragefor specific release"},{"line_number":76,"context_line":"upgrade_project vitrage $RUN_DIR $BASE_DEVSTACK_BRANCH $TARGET_DEVSTACK_BRANCH"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Simulate init_vitrage()"}],"source_content_type":"text/x-sh","patch_set":31,"id":"5f7c97a3_da1c8578","line":75,"range":{"start_line":75,"start_character":16,"end_line":75,"end_character":26},"in_reply_to":"5f7c97a3_5afe3538","updated":"2018-06-26 14:16:38.000000000","message":"Done","commit_id":"bbaf885878ade52fb318a9c938aca33e5d6f13e8"}],"playbooks/legacy/vitrage-grenade/run.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2486c8f2320f255362679579e212cd8f469a281d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- hosts: primary"},{"line_number":2,"context_line":"  name: job for grenade-vitrage"},{"line_number":3,"context_line":"  tasks:"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_1ee651b2","line":1,"range":{"start_line":1,"start_character":9,"end_line":1,"end_character":16},"updated":"2018-06-14 18:24:04.000000000","message":"Not sure if it makes a difference, but this might need to be \"all\" for a single node job.","commit_id":"96e912cc1a1ab0cb939e1648e1ca835985947d37"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"63bb0141c767e9d3a111c5b9c214b66980410eee","unresolved":false,"context_lines":[{"line_number":43,"context_line":"          export PROJECTS\u003d\"openstack-dev/grenade $PROJECTS\""},{"line_number":44,"context_line":"          export PROJECTS\u003d\"openstack/vitrage $PROJECTS\""},{"line_number":45,"context_line":"          export PROJECTS\u003d\"openstack/python-vitrageclient $PROJECTS\""},{"line_number":46,"context_line":"          # export PROJECTS\u003d\"openstack/vitrage-tempest-plugin $PROJECTS\""},{"line_number":47,"context_line":"          export PYTHONUNBUFFERED\u003dtrue"},{"line_number":48,"context_line":"          export GRENADE_PLUGINRC\u003d\"enable_grenade_plugin vitrage https://git.openstack.org/openstack/vitrage\""},{"line_number":49,"context_line":"          export DEVSTACK_GATE_TEMPEST\u003d1"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"5f7c97a3_b865834b","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":72},"updated":"2018-06-20 12:00:11.000000000","message":"Can it be deleted?","commit_id":"bcedd6d38b6ddb185fd62d32d181d4081d158b6f"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"92f1ca25d9c7b647a0b0147132332511e81db493","unresolved":false,"context_lines":[{"line_number":43,"context_line":"          export PROJECTS\u003d\"openstack-dev/grenade $PROJECTS\""},{"line_number":44,"context_line":"          export PROJECTS\u003d\"openstack/vitrage $PROJECTS\""},{"line_number":45,"context_line":"          export PROJECTS\u003d\"openstack/python-vitrageclient $PROJECTS\""},{"line_number":46,"context_line":"          # export PROJECTS\u003d\"openstack/vitrage-tempest-plugin $PROJECTS\""},{"line_number":47,"context_line":"          export PYTHONUNBUFFERED\u003dtrue"},{"line_number":48,"context_line":"          export GRENADE_PLUGINRC\u003d\"enable_grenade_plugin vitrage https://git.openstack.org/openstack/vitrage\""},{"line_number":49,"context_line":"          export DEVSTACK_GATE_TEMPEST\u003d1"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"5f7c97a3_8d94b945","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":72},"in_reply_to":"5f7c97a3_b865834b","updated":"2018-06-25 09:07:31.000000000","message":"Done. I\u0027ll re-add it in a following patch with tests implementation","commit_id":"bcedd6d38b6ddb185fd62d32d181d4081d158b6f"}]}