)]}'
{"tools/load_generator/load_generator.py":[{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"2fb4c4958a388c57c4c49945372899eea53d6481","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def main():"},{"line_number":146,"context_line":"    sm \u003d cotyledon.ServiceManager()"},{"line_number":147,"context_line":"    sm.add(StressNotificationsService)"},{"line_number":148,"context_line":"    sm.run()"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"if __name__ \u003d\u003d \"__main__\":"}],"source_content_type":"text/x-python","patch_set":20,"id":"9fb8cfa7_e5100dab","line":148,"range":{"start_line":146,"start_character":3,"end_line":148,"end_character":12},"updated":"2019-06-10 14:23:31.000000000","message":"prepare service initialise the configuration where do you do it here ?","commit_id":"0c77d3a3c8a922cccecce2b29f42b1323db216ce"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b0b12b38bec941a4ff7bd31e0d5fa9f9839464ac","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def main():"},{"line_number":146,"context_line":"    sm \u003d cotyledon.ServiceManager()"},{"line_number":147,"context_line":"    sm.add(StressNotificationsService)"},{"line_number":148,"context_line":"    sm.run()"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"if __name__ \u003d\u003d \"__main__\":"}],"source_content_type":"text/x-python","patch_set":20,"id":"9fb8cfa7_5310b0a8","line":148,"range":{"start_line":146,"start_character":3,"end_line":148,"end_character":12},"in_reply_to":"9fb8cfa7_e5100dab","updated":"2019-06-11 07:31:08.000000000","message":"You\u0027re right. I\u0027ll add it back","commit_id":"0c77d3a3c8a922cccecce2b29f42b1323db216ce"}],"tox.ini":[{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"029713a1deffb6172b9bf2eee797d49442722007","unresolved":false,"context_lines":[{"line_number":12,"context_line":"deps \u003d -r{toxinidir}/test-requirements.txt"},{"line_number":13,"context_line":"commands \u003d"},{"line_number":14,"context_line":"    stestr run --serial {posargs}"},{"line_number":15,"context_line":"    stestr slowest"},{"line_number":16,"context_line":"#    oslo-config-generator --config-file\u003detc/vitrage/vitrage-config-generator.conf"},{"line_number":17,"context_line":"    find . -type f -name \"test-*.db\" -delete"},{"line_number":18,"context_line":"passenv \u003d http_proxy HTTP_PROXY https_proxy HTTPS_PROXY no_proxy NO_PROXY"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-properties","patch_set":15,"id":"9fb8cfa7_c3bbcec1","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":81},"updated":"2019-06-05 12:05:29.000000000","message":"why ?","commit_id":"a65863d9909a0f0aa7cf6c16d2549ece49eb2f2d"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"4feb4ef11ac14bfe7359092738386d4cfe64f826","unresolved":false,"context_lines":[{"line_number":12,"context_line":"deps \u003d -r{toxinidir}/test-requirements.txt"},{"line_number":13,"context_line":"commands \u003d"},{"line_number":14,"context_line":"    stestr run --serial {posargs}"},{"line_number":15,"context_line":"    stestr slowest"},{"line_number":16,"context_line":"#    oslo-config-generator --config-file\u003detc/vitrage/vitrage-config-generator.conf"},{"line_number":17,"context_line":"    find . -type f -name \"test-*.db\" -delete"},{"line_number":18,"context_line":"passenv \u003d http_proxy HTTP_PROXY https_proxy HTTPS_PROXY no_proxy NO_PROXY"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-properties","patch_set":15,"id":"9fb8cfa7_697e816c","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":81},"in_reply_to":"9fb8cfa7_c3bbcec1","updated":"2019-06-05 13:26:05.000000000","message":"My bad, I disabled it during debugging","commit_id":"a65863d9909a0f0aa7cf6c16d2549ece49eb2f2d"}],"vitrage/api_handler/apis/resource.py":[{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"2fb4c4958a388c57c4c49945372899eea53d6481","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"@profiler.trace_cls(\"resource apis\","},{"line_number":31,"context_line":"                    info\u003d{}, hide_args\u003dFalse, trace_private\u003dFalse)"},{"line_number":32,"context_line":"class ResourceApis(base.EntityGraphApisBase):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @timed_method(log_results\u003dTrue)"},{"line_number":35,"context_line":"    @base.lock_graph"}],"source_content_type":"text/x-python","patch_set":20,"id":"9fb8cfa7_8557d158","line":32,"range":{"start_line":32,"start_character":6,"end_line":32,"end_character":21},"updated":"2019-06-10 14:23:31.000000000","message":"why did you remove the super call it holds the db and api lock","commit_id":"0c77d3a3c8a922cccecce2b29f42b1323db216ce"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"493f3f66adf0d526421b2511d7d767ff0c0746c4","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"@profiler.trace_cls(\"resource apis\","},{"line_number":31,"context_line":"                    info\u003d{}, hide_args\u003dFalse, trace_private\u003dFalse)"},{"line_number":32,"context_line":"class ResourceApis(base.EntityGraphApisBase):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @timed_method(log_results\u003dTrue)"},{"line_number":35,"context_line":"    @base.lock_graph"}],"source_content_type":"text/x-python","patch_set":20,"id":"9fb8cfa7_56241eaf","line":32,"range":{"start_line":32,"start_character":6,"end_line":32,"end_character":21},"in_reply_to":"9fb8cfa7_1326b816","updated":"2019-06-11 07:52:42.000000000","message":"the parnet __init__ method takes the api_lock and entity_graph\nand saves it as a member of the class\nsee https://github.com/openstack/vitrage/blob/master/vitrage/api_handler/apis/base.py#L79-L83","commit_id":"0c77d3a3c8a922cccecce2b29f42b1323db216ce"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"c375549f4109866f59cfba584fe6704668d40974","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"@profiler.trace_cls(\"resource apis\","},{"line_number":31,"context_line":"                    info\u003d{}, hide_args\u003dFalse, trace_private\u003dFalse)"},{"line_number":32,"context_line":"class ResourceApis(base.EntityGraphApisBase):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @timed_method(log_results\u003dTrue)"},{"line_number":35,"context_line":"    @base.lock_graph"}],"source_content_type":"text/x-python","patch_set":20,"id":"9fb8cfa7_f6d192fc","line":32,"range":{"start_line":32,"start_character":6,"end_line":32,"end_character":21},"in_reply_to":"9fb8cfa7_56241eaf","updated":"2019-06-11 08:17:37.000000000","message":"Yes, and with this change, it works in the same way","commit_id":"0c77d3a3c8a922cccecce2b29f42b1323db216ce"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b0b12b38bec941a4ff7bd31e0d5fa9f9839464ac","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"@profiler.trace_cls(\"resource apis\","},{"line_number":31,"context_line":"                    info\u003d{}, hide_args\u003dFalse, trace_private\u003dFalse)"},{"line_number":32,"context_line":"class ResourceApis(base.EntityGraphApisBase):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @timed_method(log_results\u003dTrue)"},{"line_number":35,"context_line":"    @base.lock_graph"}],"source_content_type":"text/x-python","patch_set":20,"id":"9fb8cfa7_1326b816","line":32,"range":{"start_line":32,"start_character":6,"end_line":32,"end_character":21},"in_reply_to":"9fb8cfa7_8557d158","updated":"2019-06-11 07:31:08.000000000","message":"Sorry, I didn\u0027t get your point. This method is useless because it just calls a parent one.","commit_id":"0c77d3a3c8a922cccecce2b29f42b1323db216ce"}],"vitrage/common/config.py":[{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"7a9579cb84dbecb8004d95bdfecad57435c08912","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"9fb8cfa7_e3c93278","updated":"2019-06-05 12:02:22.000000000","message":"where is the set_defaults() that was defined in service.py ?","commit_id":"a65863d9909a0f0aa7cf6c16d2549ece49eb2f2d"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"4feb4ef11ac14bfe7359092738386d4cfe64f826","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"9fb8cfa7_89a895db","in_reply_to":"9fb8cfa7_e3c93278","updated":"2019-06-05 13:26:05.000000000","message":"I missed it, will add back in a next patch","commit_id":"a65863d9909a0f0aa7cf6c16d2549ece49eb2f2d"}],"vitrage/datasources/alarm_transformer_base.py":[{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"2fb4c4958a388c57c4c49945372899eea53d6481","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from vitrage.datasources import transformer_base as tbase"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class AlarmTransformerBase(tbase.TransformerBase):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def _ok_status(self, entity_event):"},{"line_number":26,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":20,"id":"9fb8cfa7_259ce50d","line":23,"range":{"start_line":23,"start_character":33,"end_line":23,"end_character":48},"updated":"2019-06-10 14:23:31.000000000","message":"why did you remove the call for super it holds the transformers","commit_id":"0c77d3a3c8a922cccecce2b29f42b1323db216ce"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b0b12b38bec941a4ff7bd31e0d5fa9f9839464ac","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from vitrage.datasources import transformer_base as tbase"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class AlarmTransformerBase(tbase.TransformerBase):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def _ok_status(self, entity_event):"},{"line_number":26,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":20,"id":"9fb8cfa7_d31b40c7","line":23,"range":{"start_line":23,"start_character":33,"end_line":23,"end_character":48},"in_reply_to":"9fb8cfa7_259ce50d","updated":"2019-06-11 07:31:08.000000000","message":"Sorry, I didn\u0027t get your point. This method is useless because it just calls a parent one.","commit_id":"0c77d3a3c8a922cccecce2b29f42b1323db216ce"}],"vitrage/notifier/plugins/mistral/mistral_notifier.py":[{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"2fb4c4958a388c57c4c49945372899eea53d6481","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class MistralNotifier(NotifierBase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def __init__(self):"},{"line_number":29,"context_line":"        super(MistralNotifier, self).__init__()"},{"line_number":30,"context_line":"        self._client \u003d None"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":20,"id":"9fb8cfa7_a55e9541","line":29,"range":{"start_line":28,"start_character":23,"end_line":29,"end_character":8},"updated":"2019-06-10 14:23:31.000000000","message":"no need to call super here","commit_id":"0c77d3a3c8a922cccecce2b29f42b1323db216ce"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"493f3f66adf0d526421b2511d7d767ff0c0746c4","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class MistralNotifier(NotifierBase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def __init__(self):"},{"line_number":29,"context_line":"        super(MistralNotifier, self).__init__()"},{"line_number":30,"context_line":"        self._client \u003d None"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":20,"id":"9fb8cfa7_967cd683","line":29,"range":{"start_line":28,"start_character":23,"end_line":29,"end_character":8},"in_reply_to":"9fb8cfa7_73637443","updated":"2019-06-11 07:52:42.000000000","message":"no look at https://github.com/openstack/vitrage/blob/master/vitrage/notifier/plugins/base.py#L22-L23","commit_id":"0c77d3a3c8a922cccecce2b29f42b1323db216ce"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"a78efaac3000fc5607a5e0beb4addc212f7e3294","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class MistralNotifier(NotifierBase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def __init__(self):"},{"line_number":29,"context_line":"        super(MistralNotifier, self).__init__()"},{"line_number":30,"context_line":"        self._client \u003d None"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":20,"id":"9fb8cfa7_9668561d","line":29,"range":{"start_line":28,"start_character":23,"end_line":29,"end_character":8},"in_reply_to":"9fb8cfa7_967cd683","updated":"2019-06-11 08:26:13.000000000","message":"I know you removed the conf that\u0027s why __init__ does nothing\nand the client is stored here in line 30","commit_id":"0c77d3a3c8a922cccecce2b29f42b1323db216ce"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"c375549f4109866f59cfba584fe6704668d40974","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class MistralNotifier(NotifierBase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def __init__(self):"},{"line_number":29,"context_line":"        super(MistralNotifier, self).__init__()"},{"line_number":30,"context_line":"        self._client \u003d None"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":20,"id":"9fb8cfa7_36fdea6d","line":29,"range":{"start_line":28,"start_character":23,"end_line":29,"end_character":8},"in_reply_to":"9fb8cfa7_967cd683","updated":"2019-06-11 08:17:37.000000000","message":"it\u0027s conf, not client. I remove \u0027conf\u0027 argument and we still need to store _client","commit_id":"0c77d3a3c8a922cccecce2b29f42b1323db216ce"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b0b12b38bec941a4ff7bd31e0d5fa9f9839464ac","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class MistralNotifier(NotifierBase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def __init__(self):"},{"line_number":29,"context_line":"        super(MistralNotifier, self).__init__()"},{"line_number":30,"context_line":"        self._client \u003d None"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":20,"id":"9fb8cfa7_73637443","line":29,"range":{"start_line":28,"start_character":23,"end_line":29,"end_character":8},"in_reply_to":"9fb8cfa7_a55e9541","updated":"2019-06-11 07:31:08.000000000","message":"It set\u0027s self._client \u003d None","commit_id":"0c77d3a3c8a922cccecce2b29f42b1323db216ce"}],"vitrage/tests/functional/api/__init__.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"9dcdca29dd72cd5e38c149e65080ba3b72ab1b72","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from vitrage.tests import base"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONF \u003d cfg.CONF"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class FunctionalTest(base.BaseTest):"}],"source_content_type":"text/x-python","patch_set":22,"id":"9fb8cfa7_ae4fcd68","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":15},"updated":"2019-07-03 15:21:06.000000000","message":"is it needed?","commit_id":"f3833aa37456ee22883ce52a83c87273c0b20f2a"}],"vitrage/tests/functional/api_handler/test_apis.py":[{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"2fb4c4958a388c57c4c49945372899eea53d6481","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"class TestApis(TestEntityGraphUnitBase, TestConfiguration):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def setUp(self):"},{"line_number":51,"context_line":"        super(TestApis, self).setUp()"},{"line_number":52,"context_line":"        self.add_db()"},{"line_number":53,"context_line":"        self.api_lock \u003d threading.RLock()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def test_get_alarms_with_admin_project(self):"},{"line_number":56,"context_line":"        # Setup"}],"source_content_type":"text/x-python","patch_set":20,"id":"9fb8cfa7_498b336d","line":53,"range":{"start_line":50,"start_character":3,"end_line":53,"end_character":41},"updated":"2019-06-10 14:23:31.000000000","message":"why did you remove classmethod ? it makes sure it is run only once in the TestApi and not every test method","commit_id":"0c77d3a3c8a922cccecce2b29f42b1323db216ce"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b0b12b38bec941a4ff7bd31e0d5fa9f9839464ac","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"class TestApis(TestEntityGraphUnitBase, TestConfiguration):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def setUp(self):"},{"line_number":51,"context_line":"        super(TestApis, self).setUp()"},{"line_number":52,"context_line":"        self.add_db()"},{"line_number":53,"context_line":"        self.api_lock \u003d threading.RLock()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def test_get_alarms_with_admin_project(self):"},{"line_number":56,"context_line":"        # Setup"}],"source_content_type":"text/x-python","patch_set":20,"id":"9fb8cfa7_b34c8cc8","line":53,"range":{"start_line":50,"start_character":3,"end_line":53,"end_character":41},"in_reply_to":"9fb8cfa7_498b336d","updated":"2019-06-11 07:31:08.000000000","message":"It allows to schedule each test on a saparate process if needed.","commit_id":"0c77d3a3c8a922cccecce2b29f42b1323db216ce"}],"vitrage/tests/functional/evaluator/test_action_executor.py":[{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"2fb4c4958a388c57c4c49945372899eea53d6481","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def setUp(self):"},{"line_number":51,"context_line":"        super(TestActionExecutor, self).setUp()"},{"line_number":52,"context_line":"        self.add_db()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        for datasource_name in self.conf.datasources.types:"},{"line_number":55,"context_line":"            register_opts(datasource_name, self.conf.datasources.path)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _init_executer(self):"}],"source_content_type":"text/x-python","patch_set":20,"id":"9fb8cfa7_29d4bf47","line":54,"range":{"start_line":52,"start_character":7,"end_line":54,"end_character":19},"updated":"2019-06-10 14:23:31.000000000","message":"why did you remove the register_opts for PROCESSOR_OPTS and DATASOURCES_OPTS","commit_id":"0c77d3a3c8a922cccecce2b29f42b1323db216ce"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b0b12b38bec941a4ff7bd31e0d5fa9f9839464ac","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def setUp(self):"},{"line_number":51,"context_line":"        super(TestActionExecutor, self).setUp()"},{"line_number":52,"context_line":"        self.add_db()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        for datasource_name in self.conf.datasources.types:"},{"line_number":55,"context_line":"            register_opts(datasource_name, self.conf.datasources.path)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _init_executer(self):"}],"source_content_type":"text/x-python","patch_set":20,"id":"9fb8cfa7_33ce5c2d","line":54,"range":{"start_line":52,"start_character":7,"end_line":54,"end_character":19},"in_reply_to":"9fb8cfa7_29d4bf47","updated":"2019-06-11 07:31:08.000000000","message":"Looks like I missed it during rebase. Will double check it before publishing the next patch","commit_id":"0c77d3a3c8a922cccecce2b29f42b1323db216ce"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"c832a68932552ab78dfab996fa28a338067720e9","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def setUp(self):"},{"line_number":51,"context_line":"        super(TestActionExecutor, self).setUp()"},{"line_number":52,"context_line":"        self.add_db()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        for datasource_name in self.conf.datasources.types:"},{"line_number":55,"context_line":"            register_opts(datasource_name, self.conf.datasources.path)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _init_executer(self):"}],"source_content_type":"text/x-python","patch_set":20,"id":"9fb8cfa7_ff1f1e05","line":54,"range":{"start_line":52,"start_character":7,"end_line":54,"end_character":19},"in_reply_to":"9fb8cfa7_33ce5c2d","updated":"2019-06-11 14:51:14.000000000","message":"We don\u0027t need these lines because it\u0027s already done in TestEntityGraphUnitBase","commit_id":"0c77d3a3c8a922cccecce2b29f42b1323db216ce"}],"vitrage/tests/functional/evaluator/test_scenario_evaluator.py":[{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"9c277e64cb0e988746e81e7211c7a9c6c261ce5b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.load_datasources()"},{"line_number":82,"context_line":"        self.scenario_repository \u003d ScenarioRepository()"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    # noinspection PyPep8Naming"},{"line_number":85,"context_line":"    # @classmethod"},{"line_number":86,"context_line":"    # def setUpClass(cls):"},{"line_number":87,"context_line":"    #     super(TestScenarioEvaluator, cls).setUpClass()"},{"line_number":88,"context_line":"    #     cls.conf \u003d cfg.ConfigOpts()"},{"line_number":89,"context_line":"    #     cls.conf.register_opts(cls.PROCESSOR_OPTS, group\u003d\u0027entity_graph\u0027)"},{"line_number":90,"context_line":"    #     cls.conf.register_opts(cls.EVALUATOR_OPTS, group\u003d\u0027evaluator\u0027)"},{"line_number":91,"context_line":"    #     cls.conf.register_opts(cls.DATASOURCES_OPTS, group\u003d\u0027datasources\u0027)"},{"line_number":92,"context_line":"    #     cls.add_db(cls.conf)"},{"line_number":93,"context_line":"    #     cls.add_templates(cls.conf.evaluator.templates_dir)"},{"line_number":94,"context_line":"    #     TestScenarioEvaluator.load_datasources(cls.conf)"},{"line_number":95,"context_line":"    #     cls.scenario_repository \u003d ScenarioRepository()"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def test_deduced_state(self):"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"9fb8cfa7_767922fa","line":95,"range":{"start_line":84,"start_character":4,"end_line":95,"end_character":56},"updated":"2019-06-26 08:51:53.000000000","message":"can you please delete this","commit_id":"b219e4997902f8ebe5c4bcd69a7cf6b1e095a473"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"9dcdca29dd72cd5e38c149e65080ba3b72ab1b72","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def setUp(self):"},{"line_number":75,"context_line":"        super(TestScenarioEvaluator, self).setUp()"},{"line_number":76,"context_line":"        self.conf.register_opts(self.EVALUATOR_OPTS, group\u003d\u0027evaluator\u0027)"},{"line_number":77,"context_line":"        templates_dir \u003d utils.get_resources_dir() + \\"},{"line_number":78,"context_line":"            \u0027/templates/evaluator\u0027"},{"line_number":79,"context_line":"        self.add_db()"}],"source_content_type":"text/x-python","patch_set":22,"id":"9fb8cfa7_ee8b8565","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":71},"updated":"2019-07-03 15:21:06.000000000","message":"why keep this line and remove the entity_graph and datasources opts registration?","commit_id":"f3833aa37456ee22883ce52a83c87273c0b20f2a"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"a10da7bda6efaa513a6d541ab3bfcf78b64600eb","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def setUp(self):"},{"line_number":75,"context_line":"        super(TestScenarioEvaluator, self).setUp()"},{"line_number":76,"context_line":"        self.conf.register_opts(self.EVALUATOR_OPTS, group\u003d\u0027evaluator\u0027)"},{"line_number":77,"context_line":"        templates_dir \u003d utils.get_resources_dir() + \\"},{"line_number":78,"context_line":"            \u0027/templates/evaluator\u0027"},{"line_number":79,"context_line":"        self.add_db()"}],"source_content_type":"text/x-python","patch_set":22,"id":"7faddb67_8d4f8291","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":71},"in_reply_to":"9fb8cfa7_ee8b8565","updated":"2019-07-22 12:09:40.000000000","message":"`entity_graph` and `datasources` opts are registered in a base class TestEntityGraphUnitBase","commit_id":"f3833aa37456ee22883ce52a83c87273c0b20f2a"}],"vitrage/tests/unit/datasources/collectd/test_collectd_transformer.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"9dcdca29dd72cd5e38c149e65080ba3b72ab1b72","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def setUp(self):"},{"line_number":45,"context_line":"        super(TestCollectdTransformer, self).setUp()"},{"line_number":46,"context_line":"        # self.conf.register_opts(self.OPTS, group\u003dCOLLECTD_DATASOURCE)"},{"line_number":47,"context_line":"        self.transformers \u003d {}"},{"line_number":48,"context_line":"        self.transformers[COLLECTD_DATASOURCE] \u003d \\"},{"line_number":49,"context_line":"            CollectdTransformer(self.transformers)"}],"source_content_type":"text/x-python","patch_set":22,"id":"9fb8cfa7_0eda9978","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":71},"updated":"2019-07-03 15:21:06.000000000","message":"can it be deleted?","commit_id":"f3833aa37456ee22883ce52a83c87273c0b20f2a"}],"vitrage/tests/unit/datasources/doctor/test_doctor_transformer.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"9dcdca29dd72cd5e38c149e65080ba3b72ab1b72","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def setUp(self):"},{"line_number":45,"context_line":"        super(DoctorTransformerTest, self).setUp()"},{"line_number":46,"context_line":"        self.conf_reregister_opts(self.OPTS, group\u003dDOCTOR_DATASOURCE)"},{"line_number":47,"context_line":"        self.transformers \u003d {}"},{"line_number":48,"context_line":"        self.transformers[DOCTOR_DATASOURCE] \u003d \\"},{"line_number":49,"context_line":"            DoctorTransformer(self.transformers)"}],"source_content_type":"text/x-python","patch_set":22,"id":"9fb8cfa7_6eceb5b5","line":46,"range":{"start_line":46,"start_character":8,"end_line":46,"end_character":69},"updated":"2019-07-03 15:21:06.000000000","message":"why did you keep this line, but removed a similar line in the Collectd datasource?","commit_id":"f3833aa37456ee22883ce52a83c87273c0b20f2a"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"a10da7bda6efaa513a6d541ab3bfcf78b64600eb","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def setUp(self):"},{"line_number":45,"context_line":"        super(DoctorTransformerTest, self).setUp()"},{"line_number":46,"context_line":"        self.conf_reregister_opts(self.OPTS, group\u003dDOCTOR_DATASOURCE)"},{"line_number":47,"context_line":"        self.transformers \u003d {}"},{"line_number":48,"context_line":"        self.transformers[DOCTOR_DATASOURCE] \u003d \\"},{"line_number":49,"context_line":"            DoctorTransformer(self.transformers)"}],"source_content_type":"text/x-python","patch_set":22,"id":"7faddb67_ed5dd648","line":46,"range":{"start_line":46,"start_character":8,"end_line":46,"end_character":69},"in_reply_to":"9fb8cfa7_6eceb5b5","updated":"2019-07-22 12:09:40.000000000","message":"it depends on class ingeritance","commit_id":"f3833aa37456ee22883ce52a83c87273c0b20f2a"}]}