)]}'
{"doc/source/contributor/vitrage-api.rst":[{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"356ddbe70c8075ea8d63f2b2c3fbdeb22e536d7c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"#TODO: add here!"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Vitrage API"},{"line_number":18,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_3c231e59","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":16},"updated":"2018-08-02 11:31:34.000000000","message":"???","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"d27c55991e5db32c717b16c3404adf0ac442f743","unresolved":false,"context_lines":[{"line_number":511,"context_line":""},{"line_number":512,"context_line":"- limit - (int) maximum number of items to return, if limit\u003d0 the method will return all matched items in alarms table."},{"line_number":513,"context_line":"- sort_by - (array of string(255)) array of attributes by which results should be sorted."},{"line_number":514,"context_line":"- sort_dirs - (array of string(255)) per-column array of sort_dirs,corresponding to sort_keys (\u0027asc\u0027 or \u0027desc\u0027)."},{"line_number":515,"context_line":"- filter_by - (array of string(255)) array of attributes by which results will be filtered"},{"line_number":516,"context_line":"- filter_vals - (array of string(255)) per-column array of filter values corresponding to filter_by."},{"line_number":517,"context_line":"- next_page - (bool) if True will return next page when marker is given, if False will return previous page when marker is given, otherwise, returns first page if no marker was given."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_d505ef7b","line":514,"range":{"start_line":514,"start_character":66,"end_line":514,"end_character":67},"updated":"2018-08-07 05:58:10.000000000","message":"Missing space","commit_id":"09a5b16fccb95149af1bfb954b96680a53df0bb3"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"d27c55991e5db32c717b16c3404adf0ac442f743","unresolved":false,"context_lines":[{"line_number":514,"context_line":"- sort_dirs - (array of string(255)) per-column array of sort_dirs,corresponding to sort_keys (\u0027asc\u0027 or \u0027desc\u0027)."},{"line_number":515,"context_line":"- filter_by - (array of string(255)) array of attributes by which results will be filtered"},{"line_number":516,"context_line":"- filter_vals - (array of string(255)) per-column array of filter values corresponding to filter_by."},{"line_number":517,"context_line":"- next_page - (bool) if True will return next page when marker is given, if False will return previous page when marker is given, otherwise, returns first page if no marker was given."},{"line_number":518,"context_line":"- marker - ((string(255)) if None returns first page, else if vitrage_id is given and next_page is True, return next #limit results after marker, else, if next page is False, return #limit results before marker."},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"Request Body"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_55f9df7d","line":517,"range":{"start_line":517,"start_character":173,"end_line":517,"end_character":176},"updated":"2018-08-07 05:58:10.000000000","message":"is","commit_id":"09a5b16fccb95149af1bfb954b96680a53df0bb3"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"d27c55991e5db32c717b16c3404adf0ac442f743","unresolved":false,"context_lines":[{"line_number":514,"context_line":"- sort_dirs - (array of string(255)) per-column array of sort_dirs,corresponding to sort_keys (\u0027asc\u0027 or \u0027desc\u0027)."},{"line_number":515,"context_line":"- filter_by - (array of string(255)) array of attributes by which results will be filtered"},{"line_number":516,"context_line":"- filter_vals - (array of string(255)) per-column array of filter values corresponding to filter_by."},{"line_number":517,"context_line":"- next_page - (bool) if True will return next page when marker is given, if False will return previous page when marker is given, otherwise, returns first page if no marker was given."},{"line_number":518,"context_line":"- marker - ((string(255)) if None returns first page, else if vitrage_id is given and next_page is True, return next #limit results after marker, else, if next page is False, return #limit results before marker."},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"Request Body"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_75f65b92","line":517,"range":{"start_line":517,"start_character":141,"end_line":517,"end_character":148},"updated":"2018-08-07 05:58:10.000000000","message":"will return","commit_id":"09a5b16fccb95149af1bfb954b96680a53df0bb3"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"d27c55991e5db32c717b16c3404adf0ac442f743","unresolved":false,"context_lines":[{"line_number":515,"context_line":"- filter_by - (array of string(255)) array of attributes by which results will be filtered"},{"line_number":516,"context_line":"- filter_vals - (array of string(255)) per-column array of filter values corresponding to filter_by."},{"line_number":517,"context_line":"- next_page - (bool) if True will return next page when marker is given, if False will return previous page when marker is given, otherwise, returns first page if no marker was given."},{"line_number":518,"context_line":"- marker - ((string(255)) if None returns first page, else if vitrage_id is given and next_page is True, return next #limit results after marker, else, if next page is False, return #limit results before marker."},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"Request Body"},{"line_number":521,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_d52acfe5","line":518,"range":{"start_line":518,"start_character":0,"end_line":518,"end_character":211},"updated":"2018-08-07 05:58:10.000000000","message":"Complex...","commit_id":"09a5b16fccb95149af1bfb954b96680a53df0bb3"}],"vitrage/api/controllers/v1/alarm_base.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"bc24fdd3d7ad43f100a4fa9402d7b2cdc161f759","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            enforce(\"list alarms\", pecan.request.headers,"},{"line_number":54,"context_line":"                    pecan.request.enforcer, {})"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        LOG.info(\u0027returns list alarms with vitrage id %s\u0027, vitrage_id)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        alarms_json \u003d \\"},{"line_number":59,"context_line":"            pecan.request.client.call(pecan.request.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9789ed70","line":56,"range":{"start_line":56,"start_character":18,"end_line":56,"end_character":53},"updated":"2018-08-02 12:21:03.000000000","message":"Is the same message logged also for the alarm history?","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"decf55f5a5f5f94d9c8a8e00107e4182ddf5474e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            enforce(\"list alarms\", pecan.request.headers,"},{"line_number":54,"context_line":"                    pecan.request.enforcer, {})"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        LOG.info(\u0027returns list alarms with vitrage id %s\u0027, vitrage_id)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        alarms_json \u003d \\"},{"line_number":59,"context_line":"            pecan.request.client.call(pecan.request.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e5f9794d","line":56,"range":{"start_line":56,"start_character":18,"end_line":56,"end_character":53},"in_reply_to":"5f7c97a3_9789ed70","updated":"2018-08-05 11:37:33.000000000","message":"yes.. I will change it","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"bc24fdd3d7ad43f100a4fa9402d7b2cdc161f759","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            return alarms_list"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        except Exception:"},{"line_number":81,"context_line":"            LOG.exception(\u0027Failed to open file.\u0027)"},{"line_number":82,"context_line":"            abort(404, \u0027Failed to get alarms\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d7d8c580","line":81,"range":{"start_line":81,"start_character":27,"end_line":81,"end_character":46},"updated":"2018-08-02 12:21:03.000000000","message":"Failed to get alarms","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"decf55f5a5f5f94d9c8a8e00107e4182ddf5474e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            return alarms_list"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        except Exception:"},{"line_number":81,"context_line":"            LOG.exception(\u0027Failed to open file.\u0027)"},{"line_number":82,"context_line":"            abort(404, \u0027Failed to get alarms\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c5fc7d40","line":81,"range":{"start_line":81,"start_character":27,"end_line":81,"end_character":46},"in_reply_to":"5f7c97a3_d7d8c580","updated":"2018-08-05 11:37:33.000000000","message":"Done","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"}],"vitrage/api/controllers/v1/history.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"bc24fdd3d7ad43f100a4fa9402d7b2cdc161f759","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_573355c4","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":73},"updated":"2018-08-02 12:21:03.000000000","message":"I think you should add the Nokia copyright in the beginning","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"decf55f5a5f5f94d9c8a8e00107e4182ddf5474e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_859445ea","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":73},"in_reply_to":"5f7c97a3_573355c4","updated":"2018-08-05 11:37:33.000000000","message":"Done","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"bc24fdd3d7ad43f100a4fa9402d7b2cdc161f759","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    @pecan.expose(\u0027json\u0027)"},{"line_number":27,"context_line":"    def get_all(self, **kwargs):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        LOG.info(\u0027returns history alarms\u0027)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        try:"},{"line_number":32,"context_line":"            return self._get_alarms(**kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_974c8d40","line":29,"range":{"start_line":29,"start_character":18,"end_line":29,"end_character":25},"updated":"2018-08-02 12:21:03.000000000","message":"Return \n\nShould it be an info message? or maybe debug?","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"decf55f5a5f5f94d9c8a8e00107e4182ddf5474e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    @pecan.expose(\u0027json\u0027)"},{"line_number":27,"context_line":"    def get_all(self, **kwargs):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        LOG.info(\u0027returns history alarms\u0027)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        try:"},{"line_number":32,"context_line":"            return self._get_alarms(**kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c591ddf3","line":29,"range":{"start_line":29,"start_character":18,"end_line":29,"end_character":25},"in_reply_to":"5f7c97a3_974c8d40","updated":"2018-08-05 11:37:33.000000000","message":"It was info in alarm list... so I think we should leave it that way and keep the convention","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"bc24fdd3d7ad43f100a4fa9402d7b2cdc161f759","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        try:"},{"line_number":32,"context_line":"            return self._get_alarms(**kwargs)"},{"line_number":33,"context_line":"        except Exception:"},{"line_number":34,"context_line":"            LOG.exception(\u0027Failed to get alarms.\u0027)"},{"line_number":35,"context_line":"            abort(404, \u0027Failed to get alarms.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d76f6590","line":35,"range":{"start_line":33,"start_character":8,"end_line":35,"end_character":47},"updated":"2018-08-02 12:21:03.000000000","message":"Not sure if we need it both here and in the base class","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"decf55f5a5f5f94d9c8a8e00107e4182ddf5474e","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        try:"},{"line_number":32,"context_line":"            return self._get_alarms(**kwargs)"},{"line_number":33,"context_line":"        except Exception:"},{"line_number":34,"context_line":"            LOG.exception(\u0027Failed to get alarms.\u0027)"},{"line_number":35,"context_line":"            abort(404, \u0027Failed to get alarms.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e58e59cf","line":35,"range":{"start_line":33,"start_character":8,"end_line":35,"end_character":47},"in_reply_to":"5f7c97a3_d76f6590","updated":"2018-08-05 11:37:33.000000000","message":"Done","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"}],"vitrage/api_handler/apis/alarm.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"bc24fdd3d7ad43f100a4fa9402d7b2cdc161f759","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        alarms \u003d self._get_alarms(*args, **kwargs)"},{"line_number":55,"context_line":"        return json.dumps({\u0027alarms\u0027: [v.payload for v in alarms]})"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    # TODO(annarez): add db support"},{"line_number":58,"context_line":"    def show_alarm(self, ctx, vitrage_id):"},{"line_number":59,"context_line":"        LOG.debug(\u0027Show alarm with vitrage_id: %s\u0027, vitrage_id)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_97fa4db8","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":35},"updated":"2018-08-02 12:21:03.000000000","message":"Is it still TODO?","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"decf55f5a5f5f94d9c8a8e00107e4182ddf5474e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        alarms \u003d self._get_alarms(*args, **kwargs)"},{"line_number":55,"context_line":"        return json.dumps({\u0027alarms\u0027: [v.payload for v in alarms]})"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    # TODO(annarez): add db support"},{"line_number":58,"context_line":"    def show_alarm(self, ctx, vitrage_id):"},{"line_number":59,"context_line":"        LOG.debug(\u0027Show alarm with vitrage_id: %s\u0027, vitrage_id)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a5c2a1e8","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":35},"in_reply_to":"5f7c97a3_97fa4db8","updated":"2018-08-05 11:37:33.000000000","message":"yes","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"bc24fdd3d7ad43f100a4fa9402d7b2cdc161f759","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        :rtype: list"},{"line_number":98,"context_line":"        \"\"\""},{"line_number":99,"context_line":"        alarms \u003d self.db.history_facade.get_alarms(*args, **kwargs)"},{"line_number":100,"context_line":"        if not kwargs.get(\u0027only_active_alarms\u0027):"},{"line_number":101,"context_line":"            for alarm in alarms:"},{"line_number":102,"context_line":"                # TODO(annarez): in next version use \u0027state\u0027"},{"line_number":103,"context_line":"                if alarm.end_timestamp \u003c\u003d db_time():"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f718611f","line":100,"range":{"start_line":100,"start_character":26,"end_line":100,"end_character":46},"updated":"2018-08-02 12:21:03.000000000","message":"Should be a constant, as well as start_timestamp and end_timestamp","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"decf55f5a5f5f94d9c8a8e00107e4182ddf5474e","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        :rtype: list"},{"line_number":98,"context_line":"        \"\"\""},{"line_number":99,"context_line":"        alarms \u003d self.db.history_facade.get_alarms(*args, **kwargs)"},{"line_number":100,"context_line":"        if not kwargs.get(\u0027only_active_alarms\u0027):"},{"line_number":101,"context_line":"            for alarm in alarms:"},{"line_number":102,"context_line":"                # TODO(annarez): in next version use \u0027state\u0027"},{"line_number":103,"context_line":"                if alarm.end_timestamp \u003c\u003d db_time():"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_65bc8969","line":100,"range":{"start_line":100,"start_character":26,"end_line":100,"end_character":46},"in_reply_to":"5f7c97a3_f718611f","updated":"2018-08-05 11:37:33.000000000","message":"not sure where I should define it... it\u0027s only used in the api","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"bc24fdd3d7ad43f100a4fa9402d7b2cdc161f759","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            for alarm in alarms:"},{"line_number":102,"context_line":"                # TODO(annarez): in next version use \u0027state\u0027"},{"line_number":103,"context_line":"                if alarm.end_timestamp \u003c\u003d db_time():"},{"line_number":104,"context_line":"                    alarm.payload[VProps.VITRAGE_OPERATIONAL_SEVERITY] \u003d \\"},{"line_number":105,"context_line":"                        OperationalAlarmSeverity.OK"},{"line_number":106,"context_line":"        for alarm in alarms:"},{"line_number":107,"context_line":"            alarm.payload[\u0027start_timestamp\u0027] \u003d str(alarm.start_timestamp)"},{"line_number":108,"context_line":"            if alarm.end_timestamp \u003c\u003d db_time():"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_17d5dd19","line":105,"range":{"start_line":104,"start_character":20,"end_line":105,"end_character":51},"updated":"2018-08-02 12:21:03.000000000","message":"Please add a comment why you do that (it took me some time to understand)","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"293c6707979cf0eda22f03be61b5a4e8b376b312","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            for alarm in alarms:"},{"line_number":102,"context_line":"                # TODO(annarez): in next version use \u0027state\u0027"},{"line_number":103,"context_line":"                if alarm.end_timestamp \u003c\u003d db_time():"},{"line_number":104,"context_line":"                    alarm.payload[VProps.VITRAGE_OPERATIONAL_SEVERITY] \u003d \\"},{"line_number":105,"context_line":"                        OperationalAlarmSeverity.OK"},{"line_number":106,"context_line":"        for alarm in alarms:"},{"line_number":107,"context_line":"            alarm.payload[\u0027start_timestamp\u0027] \u003d str(alarm.start_timestamp)"},{"line_number":108,"context_line":"            if alarm.end_timestamp \u003c\u003d db_time():"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_207aff23","line":105,"range":{"start_line":104,"start_character":20,"end_line":105,"end_character":51},"in_reply_to":"5f7c97a3_17d5dd19","updated":"2018-08-05 12:37:56.000000000","message":"Done","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"}],"vitrage/common/constants.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"bc24fdd3d7ad43f100a4fa9402d7b2cdc161f759","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    ACTIVATE_MARK_DOWN_EVENT \u003d \u0027vitrage.mark_down.activate\u0027"},{"line_number":127,"context_line":"    DEACTIVATE_MARK_DOWN_EVENT \u003d \u0027vitrage.mark_down.deactivate\u0027"},{"line_number":128,"context_line":"    EXECUTE_EXTERNAL_ACTION \u003d \u0027vitrage.execute_external_action\u0027"},{"line_number":129,"context_line":"    ACTIVATE_CAUSAL_RELATION \u003d \u0027vitrage.causal_relationship.activate\u0027"},{"line_number":130,"context_line":"    DEACTIVATE_CAUSAL_RELATION \u003d \u0027vitrage.causal_relationship.deactivate\u0027"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f78b811e","line":129,"range":{"start_line":129,"start_character":4,"end_line":129,"end_character":12},"updated":"2018-08-02 12:21:03.000000000","message":"Why ACTIVATE and not ADD?","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"decf55f5a5f5f94d9c8a8e00107e4182ddf5474e","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    ACTIVATE_MARK_DOWN_EVENT \u003d \u0027vitrage.mark_down.activate\u0027"},{"line_number":127,"context_line":"    DEACTIVATE_MARK_DOWN_EVENT \u003d \u0027vitrage.mark_down.deactivate\u0027"},{"line_number":128,"context_line":"    EXECUTE_EXTERNAL_ACTION \u003d \u0027vitrage.execute_external_action\u0027"},{"line_number":129,"context_line":"    ACTIVATE_CAUSAL_RELATION \u003d \u0027vitrage.causal_relationship.activate\u0027"},{"line_number":130,"context_line":"    DEACTIVATE_CAUSAL_RELATION \u003d \u0027vitrage.causal_relationship.deactivate\u0027"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_25ae912e","line":129,"range":{"start_line":129,"start_character":4,"end_line":129,"end_character":12},"in_reply_to":"5f7c97a3_f78b811e","updated":"2018-08-05 11:37:33.000000000","message":"convention","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"}],"vitrage/entity_graph/graph_init.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"bc24fdd3d7ad43f100a4fa9402d7b2cdc161f759","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.persist.replay_events(self.graph, graph_snapshot.event_id)"},{"line_number":69,"context_line":"        self._recreate_transformers_id_cache()"},{"line_number":70,"context_line":"        LOG.info(\"%s vertices loaded\", self.graph.num_vertices())"},{"line_number":71,"context_line":"        self.subscribe_presist_notifier()"},{"line_number":72,"context_line":"        spawn(self._start_all_workers, is_snapshot\u003dTrue)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _start_from_scratch(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_177cfd1f","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":41},"updated":"2018-08-02 12:21:03.000000000","message":"Is it related to your change?","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"decf55f5a5f5f94d9c8a8e00107e4182ddf5474e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.persist.replay_events(self.graph, graph_snapshot.event_id)"},{"line_number":69,"context_line":"        self._recreate_transformers_id_cache()"},{"line_number":70,"context_line":"        LOG.info(\"%s vertices loaded\", self.graph.num_vertices())"},{"line_number":71,"context_line":"        self.subscribe_presist_notifier()"},{"line_number":72,"context_line":"        spawn(self._start_all_workers, is_snapshot\u003dTrue)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _start_from_scratch(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c5aa3d18","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":41},"in_reply_to":"5f7c97a3_177cfd1f","updated":"2018-08-05 11:37:33.000000000","message":"yes, this is the new notifier for persisting history","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"}],"vitrage/entity_graph/processor/notifier.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"bc24fdd3d7ad43f100a4fa9402d7b2cdc161f759","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        return topics"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def notify_when_applicable(self, before, current, is_vertex, graph):"},{"line_number":71,"context_line":"        curr \u003d current"},{"line_number":72,"context_line":"        notification_types \u003d \\"},{"line_number":73,"context_line":"            self._get_notification_type(before, curr, is_vertex)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d79e8553","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":30},"updated":"2018-08-02 12:21:03.000000000","message":"Why did you delete the comment?","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"decf55f5a5f5f94d9c8a8e00107e4182ddf5474e","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        return topics"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def notify_when_applicable(self, before, current, is_vertex, graph):"},{"line_number":71,"context_line":"        curr \u003d current"},{"line_number":72,"context_line":"        notification_types \u003d \\"},{"line_number":73,"context_line":"            self._get_notification_type(before, curr, is_vertex)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_456ced07","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":30},"in_reply_to":"5f7c97a3_d79e8553","updated":"2018-08-05 11:37:33.000000000","message":"Done","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"bc24fdd3d7ad43f100a4fa9402d7b2cdc161f759","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            curr.properties[EProps.SOURCE_ID] \u003d curr.source_id"},{"line_number":143,"context_line":"            curr.properties[EProps.TARGET_ID] \u003d curr.target_id"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        LOG.info(\u0027persist_notification_types : %s\u0027, str(notification_types))"},{"line_number":146,"context_line":"        LOG.info(\u0027persist_notification properties : %s\u0027, curr.properties)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        for notification_type in notification_types:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f7c2a134","line":145,"range":{"start_line":145,"start_character":12,"end_line":145,"end_character":16},"updated":"2018-08-02 12:21:03.000000000","message":"Should it be info?","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"decf55f5a5f5f94d9c8a8e00107e4182ddf5474e","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            curr.properties[EProps.SOURCE_ID] \u003d curr.source_id"},{"line_number":143,"context_line":"            curr.properties[EProps.TARGET_ID] \u003d curr.target_id"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        LOG.info(\u0027persist_notification_types : %s\u0027, str(notification_types))"},{"line_number":146,"context_line":"        LOG.info(\u0027persist_notification properties : %s\u0027, curr.properties)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        for notification_type in notification_types:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a5670126","line":145,"range":{"start_line":145,"start_character":12,"end_line":145,"end_character":16},"in_reply_to":"5f7c97a3_f7c2a134","updated":"2018-08-05 11:37:33.000000000","message":"Done","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"bc24fdd3d7ad43f100a4fa9402d7b2cdc161f759","unresolved":false,"context_lines":[{"line_number":221,"context_line":"def _is_active_causes_edge(entity):"},{"line_number":222,"context_line":"    if not entity:"},{"line_number":223,"context_line":"        return False"},{"line_number":224,"context_line":"    if not entity.get(EProps.RELATIONSHIP_TYPE) \u003d\u003d ELabel.CAUSES or not entity:"},{"line_number":225,"context_line":"        return False"},{"line_number":226,"context_line":"    return not entity.get(EProps.VITRAGE_IS_DELETED)"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_57027573","line":224,"range":{"start_line":224,"start_character":65,"end_line":224,"end_character":78},"updated":"2018-08-02 12:21:03.000000000","message":"Already checked","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"decf55f5a5f5f94d9c8a8e00107e4182ddf5474e","unresolved":false,"context_lines":[{"line_number":221,"context_line":"def _is_active_causes_edge(entity):"},{"line_number":222,"context_line":"    if not entity:"},{"line_number":223,"context_line":"        return False"},{"line_number":224,"context_line":"    if not entity.get(EProps.RELATIONSHIP_TYPE) \u003d\u003d ELabel.CAUSES or not entity:"},{"line_number":225,"context_line":"        return False"},{"line_number":226,"context_line":"    return not entity.get(EProps.VITRAGE_IS_DELETED)"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e5a7394f","line":224,"range":{"start_line":224,"start_character":65,"end_line":224,"end_character":78},"in_reply_to":"5f7c97a3_57027573","updated":"2018-08-05 11:37:33.000000000","message":"Done","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"}],"vitrage/entity_graph/processor/processor.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"bc24fdd3d7ad43f100a4fa9402d7b2cdc161f759","unresolved":false,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        if vertex.get(VProps.VITRAGE_CATEGORY) \u003d\u003d ECategory.ALARM:"},{"line_number":330,"context_line":"            alarms \u003d [vertex]"},{"line_number":331,"context_line":"            for neighbor in neighbors:"},{"line_number":332,"context_line":"                if neighbor.vertex.get(VProps.VITRAGE_CATEGORY) \u003d\u003d\\"},{"line_number":333,"context_line":"                        ECategory.RESOURCE:"},{"line_number":334,"context_line":"                    resource \u003d neighbor.vertex"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_7761b137","line":331,"range":{"start_line":331,"start_character":12,"end_line":331,"end_character":38},"updated":"2018-08-02 12:21:03.000000000","message":"You assume there is always one neighbor?","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"decf55f5a5f5f94d9c8a8e00107e4182ddf5474e","unresolved":false,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        if vertex.get(VProps.VITRAGE_CATEGORY) \u003d\u003d ECategory.ALARM:"},{"line_number":330,"context_line":"            alarms \u003d [vertex]"},{"line_number":331,"context_line":"            for neighbor in neighbors:"},{"line_number":332,"context_line":"                if neighbor.vertex.get(VProps.VITRAGE_CATEGORY) \u003d\u003d\\"},{"line_number":333,"context_line":"                        ECategory.RESOURCE:"},{"line_number":334,"context_line":"                    resource \u003d neighbor.vertex"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c57f9da9","line":331,"range":{"start_line":331,"start_character":12,"end_line":331,"end_character":38},"in_reply_to":"5f7c97a3_7761b137","updated":"2018-08-05 11:37:33.000000000","message":"no... I check it in the first row of the method","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"}],"vitrage/persistency/service.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"ed2e75c461e3905b9dd2d97b5be8c3b3478a9c23","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        event_timestamp \u003d self.event_time(data)"},{"line_number":137,"context_line":"        source_id \u003d data.get(EProps.SOURCE_ID)"},{"line_number":138,"context_line":"        target_id \u003d data.get(EProps.TARGET_ID)"},{"line_number":139,"context_line":"        self.db.edges.update(source_id, target_id, event_timestamp)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def _persist_change(self, event_type, data):"},{"line_number":142,"context_line":"        event_timestamp \u003d self.event_time(data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a0884f71","line":139,"range":{"start_line":139,"start_character":51,"end_line":139,"end_character":66},"updated":"2018-08-05 10:59:21.000000000","message":"It will be more clear if you write:\nend_timestamp \u003d event_timestamp\n\nThe way it is now, it is not clear that the edge is deactivated","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"a239e83d9dbc86b8b9e1dca63d7c04a3f36efc49","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        event_timestamp \u003d self.event_time(data)"},{"line_number":137,"context_line":"        source_id \u003d data.get(EProps.SOURCE_ID)"},{"line_number":138,"context_line":"        target_id \u003d data.get(EProps.TARGET_ID)"},{"line_number":139,"context_line":"        self.db.edges.update(source_id, target_id, event_timestamp)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def _persist_change(self, event_type, data):"},{"line_number":142,"context_line":"        event_timestamp \u003d self.event_time(data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e0c5e75c","line":139,"range":{"start_line":139,"start_character":51,"end_line":139,"end_character":66},"in_reply_to":"3f79a3b5_a0884f71","updated":"2018-08-05 12:19:14.000000000","message":"Done","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"ed2e75c461e3905b9dd2d97b5be8c3b3478a9c23","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            models.Change("},{"line_number":145,"context_line":"                vitrage_id\u003ddata.get(VProps.VITRAGE_ID),"},{"line_number":146,"context_line":"                timestamp\u003devent_timestamp,"},{"line_number":147,"context_line":"                severity\u003ddata.get(VProps.VITRAGE_AGGREGATED_SEVERITY),"},{"line_number":148,"context_line":"                payload\u003ddata)"},{"line_number":149,"context_line":"        self.db.changes.create(change_row)"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_407dbb6c","line":147,"range":{"start_line":147,"start_character":16,"end_line":147,"end_character":69},"updated":"2018-08-05 10:59:21.000000000","message":"Why do you always store the severity?","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"a239e83d9dbc86b8b9e1dca63d7c04a3f36efc49","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            models.Change("},{"line_number":145,"context_line":"                vitrage_id\u003ddata.get(VProps.VITRAGE_ID),"},{"line_number":146,"context_line":"                timestamp\u003devent_timestamp,"},{"line_number":147,"context_line":"                severity\u003ddata.get(VProps.VITRAGE_AGGREGATED_SEVERITY),"},{"line_number":148,"context_line":"                payload\u003ddata)"},{"line_number":149,"context_line":"        self.db.changes.create(change_row)"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_80a0b3a7","line":147,"range":{"start_line":147,"start_character":16,"end_line":147,"end_character":69},"in_reply_to":"3f79a3b5_407dbb6c","updated":"2018-08-05 12:19:14.000000000","message":"because it\u0027s the only property that can be changed","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"}],"vitrage/storage/history_facade.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"ed2e75c461e3905b9dd2d97b5be8c3b3478a9c23","unresolved":false,"context_lines":[{"line_number":34,"context_line":"ASC \u003d \u0027asc\u0027"},{"line_number":35,"context_line":"DESC \u003d \u0027desc\u0027"},{"line_number":36,"context_line":"START_TIMESTAMP \u003d \u0027start_timestamp\u0027"},{"line_number":37,"context_line":"VITRAGE_ID \u003d \u0027vitrage_id\u0027"},{"line_number":38,"context_line":"SOURCE_ID \u003d \u0027source_id\u0027"},{"line_number":39,"context_line":"TARGET_ID \u003d \u0027target_id\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class HistoryFacadeConnection(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e08de77b","line":39,"range":{"start_line":37,"start_character":0,"end_line":39,"end_character":23},"updated":"2018-08-05 10:59:21.000000000","message":"Don\u0027t we already have constants for these?","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"a239e83d9dbc86b8b9e1dca63d7c04a3f36efc49","unresolved":false,"context_lines":[{"line_number":34,"context_line":"ASC \u003d \u0027asc\u0027"},{"line_number":35,"context_line":"DESC \u003d \u0027desc\u0027"},{"line_number":36,"context_line":"START_TIMESTAMP \u003d \u0027start_timestamp\u0027"},{"line_number":37,"context_line":"VITRAGE_ID \u003d \u0027vitrage_id\u0027"},{"line_number":38,"context_line":"SOURCE_ID \u003d \u0027source_id\u0027"},{"line_number":39,"context_line":"TARGET_ID \u003d \u0027target_id\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class HistoryFacadeConnection(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c09d4b67","line":39,"range":{"start_line":37,"start_character":0,"end_line":39,"end_character":23},"in_reply_to":"3f79a3b5_e08de77b","updated":"2018-08-05 12:19:14.000000000","message":"only in common.constants and I can\u0027t use them here","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"d27c55991e5db32c717b16c3404adf0ac442f743","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        start and end arguments gives the time frame for required alarms."},{"line_number":115,"context_line":"        Required format is the format that can be parsed by timeutils library."},{"line_number":116,"context_line":"        If both arguments are given, returned alarms are the alarms that"},{"line_number":117,"context_line":"        where active sometime during given time frame"},{"line_number":118,"context_line":"        (including active and inactive alarms):"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        1.  start_ts------------end_ts"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_154847ca","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":13},"updated":"2018-08-07 05:58:10.000000000","message":"were","commit_id":"09a5b16fccb95149af1bfb954b96680a53df0bb3"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"d27c55991e5db32c717b16c3404adf0ac442f743","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            which will be evaluated to:"},{"line_number":150,"context_line":"                Alarm.vitrage_type like \u0027%zabbix%\u0027"},{"line_number":151,"context_line":"                and Alarm.vitrage_resource_type like \u0027%nova%\u0027"},{"line_number":152,"context_line":"            Tthe filtering will be done so the query returns all the alarms"},{"line_number":153,"context_line":"            in the DB with vitrage type containing the string \u0027zabbix\u0027"},{"line_number":154,"context_line":"            and vitrage resource type containing the string \u0027nova\u0027"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_d513afb7","line":152,"range":{"start_line":152,"start_character":12,"end_line":152,"end_character":16},"updated":"2018-08-07 05:58:10.000000000","message":"The","commit_id":"09a5b16fccb95149af1bfb954b96680a53df0bb3"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"d27c55991e5db32c717b16c3404adf0ac442f743","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                and Alarm.vitrage_resource_type like \u0027%123%\u0027"},{"line_number":162,"context_line":"                    or like \u0027%456%\u0027"},{"line_number":163,"context_line":"                    or like \u0027%789%\u0027"},{"line_number":164,"context_line":"            Tthe filtering will be done so the query returns all the alarms"},{"line_number":165,"context_line":"            in the DB with vitrage type containing the string \u0027zabbix\u0027"},{"line_number":166,"context_line":"            and with one of vitrage_ids that are in the list in filter_vals[1]"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_950d3792","line":164,"range":{"start_line":164,"start_character":12,"end_line":164,"end_character":16},"updated":"2018-08-07 05:58:10.000000000","message":"The","commit_id":"09a5b16fccb95149af1bfb954b96680a53df0bb3"}],"vitrage/storage/impl_sqlalchemy.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"ed2e75c461e3905b9dd2d97b5be8c3b3478a9c23","unresolved":false,"context_lines":[{"line_number":475,"context_line":"                models.Change("},{"line_number":476,"context_line":"                    vitrage_id\u003did,"},{"line_number":477,"context_line":"                    timestamp\u003dend_time,"},{"line_number":478,"context_line":"                    severity\u003d\u0027OK\u0027,"},{"line_number":479,"context_line":"                    payload\u003dchange.payload)"},{"line_number":480,"context_line":"            self.create(change_row)"},{"line_number":481,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c090eb98","line":478,"range":{"start_line":478,"start_character":29,"end_line":478,"end_character":33},"updated":"2018-08-05 10:59:21.000000000","message":"Please use a constant","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"a239e83d9dbc86b8b9e1dca63d7c04a3f36efc49","unresolved":false,"context_lines":[{"line_number":475,"context_line":"                models.Change("},{"line_number":476,"context_line":"                    vitrage_id\u003did,"},{"line_number":477,"context_line":"                    timestamp\u003dend_time,"},{"line_number":478,"context_line":"                    severity\u003d\u0027OK\u0027,"},{"line_number":479,"context_line":"                    payload\u003dchange.payload)"},{"line_number":480,"context_line":"            self.create(change_row)"},{"line_number":481,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_40aa9b85","line":478,"range":{"start_line":478,"start_character":29,"end_line":478,"end_character":33},"in_reply_to":"3f79a3b5_c090eb98","updated":"2018-08-05 12:19:14.000000000","message":"Done","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"}],"vitrage/tests/functional/api_handler/test_apis.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"bc24fdd3d7ad43f100a4fa9402d7b2cdc161f759","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        # Action"},{"line_number":62,"context_line":"        alarms \u003d apis.get_alarms(ctx, vitrage_id\u003d\u0027all\u0027, all_tenants\u003dFalse,"},{"line_number":63,"context_line":"                                 start\u003dNone,"},{"line_number":64,"context_line":"                                 end\u003dNone,"},{"line_number":65,"context_line":"                                 limit\u003d10000,"},{"line_number":66,"context_line":"                                 sort_by\u003d[\u0027start_timestamp\u0027, \u0027vitrage_id\u0027],"},{"line_number":67,"context_line":"                                 sort_dirs\u003d[\u0027asc\u0027, \u0027asc\u0027],"},{"line_number":68,"context_line":"                                 filter_by\u003dNone,"},{"line_number":69,"context_line":"                                 filter_vals\u003dNone,"},{"line_number":70,"context_line":"                                 next_page\u003dTrue,"},{"line_number":71,"context_line":"                                 marker\u003dNone)"},{"line_number":72,"context_line":"        alarms \u003d json.loads(alarms)[\u0027alarms\u0027]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # Test assertions"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_379a5911","line":71,"range":{"start_line":63,"start_character":33,"end_line":71,"end_character":44},"updated":"2018-08-02 12:21:03.000000000","message":"Aren\u0027t these the default values?","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"decf55f5a5f5f94d9c8a8e00107e4182ddf5474e","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        # Action"},{"line_number":62,"context_line":"        alarms \u003d apis.get_alarms(ctx, vitrage_id\u003d\u0027all\u0027, all_tenants\u003dFalse,"},{"line_number":63,"context_line":"                                 start\u003dNone,"},{"line_number":64,"context_line":"                                 end\u003dNone,"},{"line_number":65,"context_line":"                                 limit\u003d10000,"},{"line_number":66,"context_line":"                                 sort_by\u003d[\u0027start_timestamp\u0027, \u0027vitrage_id\u0027],"},{"line_number":67,"context_line":"                                 sort_dirs\u003d[\u0027asc\u0027, \u0027asc\u0027],"},{"line_number":68,"context_line":"                                 filter_by\u003dNone,"},{"line_number":69,"context_line":"                                 filter_vals\u003dNone,"},{"line_number":70,"context_line":"                                 next_page\u003dTrue,"},{"line_number":71,"context_line":"                                 marker\u003dNone)"},{"line_number":72,"context_line":"        alarms \u003d json.loads(alarms)[\u0027alarms\u0027]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # Test assertions"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e52ad98e","line":71,"range":{"start_line":63,"start_character":33,"end_line":71,"end_character":44},"in_reply_to":"5f7c97a3_379a5911","updated":"2018-08-05 11:37:33.000000000","message":"Done","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"356ddbe70c8075ea8d63f2b2c3fbdeb22e536d7c","unresolved":false,"context_lines":[{"line_number":568,"context_line":"            instance_1_vertex.vertex_id,"},{"line_number":569,"context_line":"            EdgeLabel.CONTAINS,"},{"line_number":570,"context_line":"            update_timestamp\u003dstr(utcnow())))"},{"line_number":571,"context_line":"        edges.append(graph_utils.create_edge("},{"line_number":572,"context_line":"            host_vertex.vertex_id,"},{"line_number":573,"context_line":"            instance_2_vertex.vertex_id,"},{"line_number":574,"context_line":"            EdgeLabel.CONTAINS,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_3cad5e82","line":571,"range":{"start_line":571,"start_character":33,"end_line":571,"end_character":44},"updated":"2018-08-02 11:31:34.000000000","message":"cant you add default value for update_timestamp to be now","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"c6af7ead7b22089d9f1fd62935c2b4af8e0c1803","unresolved":false,"context_lines":[{"line_number":568,"context_line":"            instance_1_vertex.vertex_id,"},{"line_number":569,"context_line":"            EdgeLabel.CONTAINS,"},{"line_number":570,"context_line":"            update_timestamp\u003dstr(utcnow())))"},{"line_number":571,"context_line":"        edges.append(graph_utils.create_edge("},{"line_number":572,"context_line":"            host_vertex.vertex_id,"},{"line_number":573,"context_line":"            instance_2_vertex.vertex_id,"},{"line_number":574,"context_line":"            EdgeLabel.CONTAINS,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_cf93374f","line":571,"range":{"start_line":571,"start_character":33,"end_line":571,"end_character":44},"in_reply_to":"5f7c97a3_3cad5e82","updated":"2018-08-06 05:36:40.000000000","message":"I don\u0027t think it\u0027s right to do so","commit_id":"c8052f2476eb0a1acc28efac2e1ed17c0f03e240"}]}
