)]}'
{"vitrage/api/controllers/v1/alarm_base.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"a3310d80b89eb6f2c5ad9072a03ffd9bce11ae17","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                                      )"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        try:"},{"line_number":73,"context_line":"            alarms_list \u003d decompress_obj(alarms)[\u0027alarms\u0027]"},{"line_number":74,"context_line":"            return alarms_list"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_203cee8f","line":73,"range":{"start_line":73,"start_character":26,"end_line":73,"end_character":40},"updated":"2018-12-04 11:13:11.000000000","message":"Does it require a change in python-vitrageclient?","commit_id":"6baa7e0d0a086cb089e7ef061cc6b1138a73bf70"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"a56266eea899f3d7b0e4007c569aee4a7020a43a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                                      )"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        try:"},{"line_number":73,"context_line":"            alarms_list \u003d decompress_obj(alarms)[\u0027alarms\u0027]"},{"line_number":74,"context_line":"            return alarms_list"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_fe89981c","line":73,"range":{"start_line":73,"start_character":26,"end_line":73,"end_character":40},"in_reply_to":"3f79a3b5_203cee8f","updated":"2018-12-05 12:26:41.000000000","message":"Nope, it is decompressed to be the same list as before this change","commit_id":"6baa7e0d0a086cb089e7ef061cc6b1138a73bf70"}],"vitrage/api/controllers/v1/topology.py":[{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"c4721adfb80fa0a50e651f31970eea91ef26afb1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                    info\u003d{}, hide_args\u003dFalse, trace_private\u003dFalse)"},{"line_number":40,"context_line":"class TopologyController(RootRestController):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    gc.set_threshold(1, 1, 1)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @pecan.expose(\u0027json\u0027)"},{"line_number":45,"context_line":"    def post(self, depth\u003dNone, graph_type\u003d\u0027graph\u0027, query\u003dNone, root\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_3fadeea3","line":42,"range":{"start_line":42,"start_character":4,"end_line":42,"end_character":29},"updated":"2018-12-04 10:56:09.000000000","message":"need to find a better place for that","commit_id":"6baa7e0d0a086cb089e7ef061cc6b1138a73bf70"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"a56266eea899f3d7b0e4007c569aee4a7020a43a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                    info\u003d{}, hide_args\u003dFalse, trace_private\u003dFalse)"},{"line_number":40,"context_line":"class TopologyController(RootRestController):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    gc.set_threshold(1, 1, 1)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @pecan.expose(\u0027json\u0027)"},{"line_number":45,"context_line":"    def post(self, depth\u003dNone, graph_type\u003d\u0027graph\u0027, query\u003dNone, root\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_d8caada1","line":42,"range":{"start_line":42,"start_character":4,"end_line":42,"end_character":29},"in_reply_to":"3f79a3b5_3fadeea3","updated":"2018-12-05 12:26:41.000000000","message":"Done","commit_id":"6baa7e0d0a086cb089e7ef061cc6b1138a73bf70"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"c4721adfb80fa0a50e651f31970eea91ef26afb1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                                   root\u003droot,"},{"line_number":82,"context_line":"                                                   all_tenants\u003dall_tenants)"},{"line_number":83,"context_line":"            graph \u003d decompress_obj(graph_data)"},{"line_number":84,"context_line":"            del graph_data"},{"line_number":85,"context_line":"            if graph_type \u003d\u003d \u0027graph\u0027:"},{"line_number":86,"context_line":"                return graph"},{"line_number":87,"context_line":"            if graph_type \u003d\u003d \u0027tree\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_7fb3660d","line":84,"range":{"start_line":84,"start_character":12,"end_line":84,"end_character":26},"updated":"2018-12-04 10:56:09.000000000","message":"no need for this","commit_id":"6baa7e0d0a086cb089e7ef061cc6b1138a73bf70"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"a56266eea899f3d7b0e4007c569aee4a7020a43a","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                                   root\u003droot,"},{"line_number":82,"context_line":"                                                   all_tenants\u003dall_tenants)"},{"line_number":83,"context_line":"            graph \u003d decompress_obj(graph_data)"},{"line_number":84,"context_line":"            del graph_data"},{"line_number":85,"context_line":"            if graph_type \u003d\u003d \u0027graph\u0027:"},{"line_number":86,"context_line":"                return graph"},{"line_number":87,"context_line":"            if graph_type \u003d\u003d \u0027tree\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_f8cf69af","line":84,"range":{"start_line":84,"start_character":12,"end_line":84,"end_character":26},"in_reply_to":"3f79a3b5_7fb3660d","updated":"2018-12-05 12:26:41.000000000","message":"Done","commit_id":"6baa7e0d0a086cb089e7ef061cc6b1138a73bf70"}],"vitrage/api_handler/apis/topology.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"a3310d80b89eb6f2c5ad9072a03ffd9bce11ae17","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        tmp_graph \u003d ga.create_graph_from_matching_vertices(query_dict\u003dq)"},{"line_number":126,"context_line":"        vertices_ids \u003d self._all_paths_from_node(self.entity_graph, tmp_graph,"},{"line_number":127,"context_line":"                                                 root)"},{"line_number":128,"context_line":"        graph \u003d ga.subgraph(vertices_ids).copy()"},{"line_number":129,"context_line":"        edge_query \u003d {EProps.VITRAGE_IS_DELETED: False}"},{"line_number":130,"context_line":"        self._remove_unnecessary_elements(ga,"},{"line_number":131,"context_line":"                                          graph,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_80c14252","line":128,"range":{"start_line":128,"start_character":16,"end_line":128,"end_character":18},"updated":"2018-12-04 11:13:11.000000000","message":"It\u0027s not part of your change, but I would rename \u0027ga\u0027 to something more clear","commit_id":"6baa7e0d0a086cb089e7ef061cc6b1138a73bf70"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"a56266eea899f3d7b0e4007c569aee4a7020a43a","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        tmp_graph \u003d ga.create_graph_from_matching_vertices(query_dict\u003dq)"},{"line_number":126,"context_line":"        vertices_ids \u003d self._all_paths_from_node(self.entity_graph, tmp_graph,"},{"line_number":127,"context_line":"                                                 root)"},{"line_number":128,"context_line":"        graph \u003d ga.subgraph(vertices_ids).copy()"},{"line_number":129,"context_line":"        edge_query \u003d {EProps.VITRAGE_IS_DELETED: False}"},{"line_number":130,"context_line":"        self._remove_unnecessary_elements(ga,"},{"line_number":131,"context_line":"                                          graph,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_3e3b9036","line":128,"range":{"start_line":128,"start_character":16,"end_line":128,"end_character":18},"in_reply_to":"3f79a3b5_80c14252","updated":"2018-12-05 12:26:41.000000000","message":"NP, I removed all occurrences of this name.","commit_id":"6baa7e0d0a086cb089e7ef061cc6b1138a73bf70"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"a3310d80b89eb6f2c5ad9072a03ffd9bce11ae17","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                        graph.remove_vertex(alarm)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @staticmethod"},{"line_number":183,"context_line":"    def _all_paths_from_node(e_graph, result_graph, node):"},{"line_number":184,"context_line":"        \"\"\"Find all paths to result graph connected components"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        Return all the node ids that are either in the results graph"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_4087aa0b","line":183,"range":{"start_line":183,"start_character":29,"end_line":183,"end_character":36},"updated":"2018-12-04 11:13:11.000000000","message":"What is e_graph?","commit_id":"6baa7e0d0a086cb089e7ef061cc6b1138a73bf70"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"a56266eea899f3d7b0e4007c569aee4a7020a43a","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                        graph.remove_vertex(alarm)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @staticmethod"},{"line_number":183,"context_line":"    def _all_paths_from_node(e_graph, result_graph, node):"},{"line_number":184,"context_line":"        \"\"\"Find all paths to result graph connected components"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        Return all the node ids that are either in the results graph"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_be08007f","line":183,"range":{"start_line":183,"start_character":29,"end_line":183,"end_character":36},"in_reply_to":"3f79a3b5_4087aa0b","updated":"2018-12-05 12:26:41.000000000","message":"Thanks i rewrote this part, to be clearer","commit_id":"6baa7e0d0a086cb089e7ef061cc6b1138a73bf70"}],"vitrage/graph/driver/networkx_graph.py":[{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"c4721adfb80fa0a50e651f31970eea91ef26afb1","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        vertices_ids \u003d set()"},{"line_number":258,"context_line":"        match_func \u003d create_predicate(query_dict)"},{"line_number":259,"context_line":"        for node, node_data in list(self._g.nodes(data\u003dTrue)):"},{"line_number":260,"context_line":"            if match_func(node_data):"},{"line_number":261,"context_line":"                vertices_ids.add(node)"},{"line_number":262,"context_line":"        return vertices_ids"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_e0a116f6","line":259,"range":{"start_line":259,"start_character":31,"end_line":259,"end_character":36},"updated":"2018-12-04 10:56:09.000000000","message":"why creating a list ?","commit_id":"6baa7e0d0a086cb089e7ef061cc6b1138a73bf70"},{"author":{"_account_id":19184,"name":"Idan Hefetz","email":"idan.hefetz@nokia.com","username":"idan-hefetz"},"change_message_id":"a56266eea899f3d7b0e4007c569aee4a7020a43a","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        vertices_ids \u003d set()"},{"line_number":258,"context_line":"        match_func \u003d create_predicate(query_dict)"},{"line_number":259,"context_line":"        for node, node_data in list(self._g.nodes(data\u003dTrue)):"},{"line_number":260,"context_line":"            if match_func(node_data):"},{"line_number":261,"context_line":"                vertices_ids.add(node)"},{"line_number":262,"context_line":"        return vertices_ids"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_18db457b","line":259,"range":{"start_line":259,"start_character":31,"end_line":259,"end_character":36},"in_reply_to":"3f79a3b5_e0a116f6","updated":"2018-12-05 12:26:41.000000000","message":"Thanks, removed it","commit_id":"6baa7e0d0a086cb089e7ef061cc6b1138a73bf70"}]}