)]}'
{"vitrage/datasources/static/driver.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"001f0890ad88954cdd993cc7a91562a3114f92c4","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            validate(config, STATIC_SCHEMA)"},{"line_number":48,"context_line":"            return True"},{"line_number":49,"context_line":"        except Exception as e:"},{"line_number":50,"context_line":"            msg \u003d \"invalid config file, because of %s\" % e"},{"line_number":51,"context_line":"            LOG.exception(msg)"},{"line_number":52,"context_line":"            return False"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_a17360b4","line":50,"range":{"start_line":50,"start_character":19,"end_line":50,"end_character":26},"updated":"2019-02-19 08:01:47.000000000","message":"Invalid. And please also print the file path (if you know it here)","commit_id":"ba2ae253b25d05c25d89d7f69cb70a146f4abb00"},{"author":{"_account_id":29383,"name":"hewei","email":"hewei@cmss.chinamobile.com","username":"hewei"},"change_message_id":"2dc088f5f15a5b630b123b908ce8ddda0afe056b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            validate(config, STATIC_SCHEMA)"},{"line_number":48,"context_line":"            return True"},{"line_number":49,"context_line":"        except Exception as e:"},{"line_number":50,"context_line":"            msg \u003d \"invalid config file, because of %s\" % e"},{"line_number":51,"context_line":"            LOG.exception(msg)"},{"line_number":52,"context_line":"            return False"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_8702ec6e","line":50,"range":{"start_line":50,"start_character":19,"end_line":50,"end_character":26},"in_reply_to":"9fdfeff1_a17360b4","updated":"2019-02-19 09:55:51.000000000","message":"Done. And also print the file path.\nI has learned the new template version 3, and it looks much nicer.Thanks for reminding.","commit_id":"ba2ae253b25d05c25d89d7f69cb70a146f4abb00"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"57bd17925117251d2a76670f0cd47cc11bb4d8c8","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        config \u003d file_utils.load_yaml_file(path)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        if not cls._is_valid_config(config, path):"},{"line_number":114,"context_line":"            LOG.warning(\"Skipped invalid config (possible obsoleted): {}\""},{"line_number":115,"context_line":"                        .format(path))"},{"line_number":116,"context_line":"            return []"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        definitions \u003d config[StaticFields.DEFINITIONS]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_08bfd2d0","line":115,"range":{"start_line":114,"start_character":0,"end_line":115,"end_character":38},"updated":"2019-02-20 08:33:38.000000000","message":"This warning should be deleted. We used to have two datasources: static_physical and static. Their files were in the same folder, and the warning happened when the static datasource tried to read files of static_physical format.\n\nThe static_physical no longer exists. And you just added a clear message if validation failed in _is_valid_config(). So I think that this warning is no longer needed.","commit_id":"5010e1acf9e560398c2fbf363882f6668b8e37ec"},{"author":{"_account_id":29383,"name":"hewei","email":"hewei@cmss.chinamobile.com","username":"hewei"},"change_message_id":"8db4ac1133aaec5810356daf9eae6e6427b2e487","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        config \u003d file_utils.load_yaml_file(path)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        if not cls._is_valid_config(config, path):"},{"line_number":114,"context_line":"            LOG.warning(\"Skipped invalid config (possible obsoleted): {}\""},{"line_number":115,"context_line":"                        .format(path))"},{"line_number":116,"context_line":"            return []"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        definitions \u003d config[StaticFields.DEFINITIONS]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_c83d4ade","line":115,"range":{"start_line":114,"start_character":0,"end_line":115,"end_character":38},"in_reply_to":"9fdfeff1_08bfd2d0","updated":"2019-02-20 09:03:54.000000000","message":"Done.\nI agree with you. This log is deleted, and is not needed.","commit_id":"5010e1acf9e560398c2fbf363882f6668b8e37ec"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"9023afe8a762a1ada19ea97d2978cda789b1a158","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from itertools import chain"},{"line_number":16,"context_line":"from jsonschema import validate"},{"line_number":17,"context_line":"from six.moves import reduce"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_1d862ddd","line":16,"updated":"2019-02-20 12:40:21.000000000","message":"Please, add jsonschema to requirements.txt","commit_id":"676a5ab5f741a5ab8c33634bfba3100b45649241"},{"author":{"_account_id":29383,"name":"hewei","email":"hewei@cmss.chinamobile.com","username":"hewei"},"change_message_id":"15c60c000c012279e75d65aa071f9c20fcbf966d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from itertools import chain"},{"line_number":16,"context_line":"from jsonschema import validate"},{"line_number":17,"context_line":"from six.moves import reduce"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_ab5a2e4d","line":16,"in_reply_to":"9fdfeff1_1d862ddd","updated":"2019-02-21 01:50:26.000000000","message":"Done.","commit_id":"676a5ab5f741a5ab8c33634bfba3100b45649241"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"9023afe8a762a1ada19ea97d2978cda789b1a158","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            validate(config, STATIC_SCHEMA)"},{"line_number":48,"context_line":"            return True"},{"line_number":49,"context_line":"        except Exception as e:"},{"line_number":50,"context_line":"            msg \u003d \"Invalid config file: %s, because of %s\" % (path, e)"},{"line_number":51,"context_line":"            LOG.exception(msg)"},{"line_number":52,"context_line":"            return False"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_5d7cb5ea","line":50,"range":{"start_line":50,"start_character":66,"end_line":50,"end_character":69},"updated":"2019-02-20 12:40:21.000000000","message":"We don\u0027t need to add exception instance to logger manually [1]\n\n[1] https://docs.python.org/3/library/logging.html#logging.Logger.exception","commit_id":"676a5ab5f741a5ab8c33634bfba3100b45649241"},{"author":{"_account_id":29383,"name":"hewei","email":"hewei@cmss.chinamobile.com","username":"hewei"},"change_message_id":"15c60c000c012279e75d65aa071f9c20fcbf966d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            validate(config, STATIC_SCHEMA)"},{"line_number":48,"context_line":"            return True"},{"line_number":49,"context_line":"        except Exception as e:"},{"line_number":50,"context_line":"            msg \u003d \"Invalid config file: %s, because of %s\" % (path, e)"},{"line_number":51,"context_line":"            LOG.exception(msg)"},{"line_number":52,"context_line":"            return False"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_4b570228","line":50,"range":{"start_line":50,"start_character":66,"end_line":50,"end_character":69},"in_reply_to":"9fdfeff1_5d7cb5ea","updated":"2019-02-21 01:50:26.000000000","message":"Done.\nI have remove it.","commit_id":"676a5ab5f741a5ab8c33634bfba3100b45649241"}]}