)]}'
{"vitrage/entity_graph/mappings/datasource_info_mapper.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"4a9f4f522dfde2db379f6d430c9749faa358d362","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        vitrage_type \u003d new_vertex[VProps.VITRAGE_TYPE] if \\"},{"line_number":58,"context_line":"            VProps.VITRAGE_TYPE in new_vertex.properties else \\"},{"line_number":59,"context_line":"            extract_field_value(graph_vertex, VProps.VITRAGE_TYPE)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        vitrage_category \u003d new_vertex[VProps.VITRAGE_CATEGORY] if \\"},{"line_number":62,"context_line":"            VProps.VITRAGE_CATEGORY in new_vertex.properties else \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_f66428bb","line":59,"range":{"start_line":59,"start_character":12,"end_line":59,"end_character":31},"updated":"2019-02-27 07:42:28.000000000","message":"The category and type should always exist. If they don\u0027t, other things won\u0027t work. Do you have a real case that you get None for category or type? if so, please share because it\u0027s probably a bug.\n\nIn addition, there is no need to call extract_field_value. A simple graph_vertex.get() would do the job. But again, I don\u0027t think this is needed.","commit_id":"ea97b0eaf1f02c29ad3247488592dfc81b7ab2ca"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"fa4e847b9c0c7235b93dc354d87d48310f3237bd","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        vitrage_type \u003d new_vertex[VProps.VITRAGE_TYPE] if \\"},{"line_number":58,"context_line":"            VProps.VITRAGE_TYPE in new_vertex.properties else \\"},{"line_number":59,"context_line":"            extract_field_value(graph_vertex, VProps.VITRAGE_TYPE)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        vitrage_category \u003d new_vertex[VProps.VITRAGE_CATEGORY] if \\"},{"line_number":62,"context_line":"            VProps.VITRAGE_CATEGORY in new_vertex.properties else \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_76f6f891","line":59,"range":{"start_line":59,"start_character":12,"end_line":59,"end_character":31},"in_reply_to":"9fdfeff1_76911852","updated":"2019-02-27 08:02:16.000000000","message":"There was already an attempt to fix this issue: https://review.openstack.org/#/c/627951/\n\nThe person who submitted that change had an invalid vertex. I asked him to try and figure out why but got no response, so I don\u0027t know what the real problem was. \n\nIn any case, I think that if something like this happens we should figure out why we got an invalid vertex. Even if you add a None check in here, Vitrage will fail later on. The category and type are mandatory.","commit_id":"ea97b0eaf1f02c29ad3247488592dfc81b7ab2ca"},{"author":{"_account_id":29383,"name":"hewei","email":"hewei@cmss.chinamobile.com","username":"hewei"},"change_message_id":"997e58e6765a33204f40da4cef49487d6b184a5a","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        vitrage_type \u003d new_vertex[VProps.VITRAGE_TYPE] if \\"},{"line_number":58,"context_line":"            VProps.VITRAGE_TYPE in new_vertex.properties else \\"},{"line_number":59,"context_line":"            extract_field_value(graph_vertex, VProps.VITRAGE_TYPE)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        vitrage_category \u003d new_vertex[VProps.VITRAGE_CATEGORY] if \\"},{"line_number":62,"context_line":"            VProps.VITRAGE_CATEGORY in new_vertex.properties else \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_76911852","line":59,"range":{"start_line":59,"start_character":12,"end_line":59,"end_character":31},"in_reply_to":"9fdfeff1_f66428bb","updated":"2019-02-27 07:49:44.000000000","message":"I see this problem in [1] 2004689，maybe exist condition that graph_vertex is None.\n\n[1]https://storyboard.openstack.org/#!/project/openstack/vitrage","commit_id":"ea97b0eaf1f02c29ad3247488592dfc81b7ab2ca"}]}