)]}'
{"vitrage/snmp_parsing/service.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"b9a97747f298f9646440353f429617999d7e1cfb","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        super(SnmpParsingService, self).__init__(worker_id, conf)"},{"line_number":43,"context_line":"        self.conf \u003d conf"},{"line_number":44,"context_line":"        self.listening_port \u003d conf.snmp_parsing.snmp_listening_port"},{"line_number":45,"context_line":"        self.alarm_mapping \u003d \\"},{"line_number":46,"context_line":"            load_yaml_file(self.conf.snmp.alarm_oid_mapping, True)"},{"line_number":47,"context_line":"        self._init_oslo_notifier()"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def run(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_787b3e7a","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":66},"updated":"2019-03-14 13:01:40.000000000","message":"Moving it here has the advantage of loading the file only once. On the other hand, it means that changes in the file will require restart of the service.","commit_id":"795d3f67f94523e6500507f5309ee2f248271129"},{"author":{"_account_id":29383,"name":"hewei","email":"hewei@cmss.chinamobile.com","username":"hewei"},"change_message_id":"962f6dd20e0567a6b2e60c5220ff379ba40fa005","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        super(SnmpParsingService, self).__init__(worker_id, conf)"},{"line_number":43,"context_line":"        self.conf \u003d conf"},{"line_number":44,"context_line":"        self.listening_port \u003d conf.snmp_parsing.snmp_listening_port"},{"line_number":45,"context_line":"        self.alarm_mapping \u003d \\"},{"line_number":46,"context_line":"            load_yaml_file(self.conf.snmp.alarm_oid_mapping, True)"},{"line_number":47,"context_line":"        self._init_oslo_notifier()"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def run(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_57c2bf5a","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":66},"in_reply_to":"5fc1f717_787b3e7a","updated":"2019-03-15 08:23:30.000000000","message":"When alarm system send much alarms, it will be better only loading file once. \nIn general, the oid file should be prepared before starting the service.","commit_id":"795d3f67f94523e6500507f5309ee2f248271129"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"b9a97747f298f9646440353f429617999d7e1cfb","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        except Exception:"},{"line_number":128,"context_line":"            LOG.exception(\u0027Failed to initialize oslo notifier\u0027)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def _send_snmp_to_queue(self, snmp_trap):"},{"line_number":131,"context_line":"        try:"},{"line_number":132,"context_line":"            event_type \u003d self._get_event_type(snmp_trap)"},{"line_number":133,"context_line":"            if not event_type:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_389936c3","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":45},"updated":"2019-03-14 13:01:40.000000000","message":"Why did you delete the json load? I\u0027m sure there was a reason for this code","commit_id":"795d3f67f94523e6500507f5309ee2f248271129"},{"author":{"_account_id":29383,"name":"hewei","email":"hewei@cmss.chinamobile.com","username":"hewei"},"change_message_id":"962f6dd20e0567a6b2e60c5220ff379ba40fa005","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        except Exception:"},{"line_number":128,"context_line":"            LOG.exception(\u0027Failed to initialize oslo notifier\u0027)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def _send_snmp_to_queue(self, snmp_trap):"},{"line_number":131,"context_line":"        try:"},{"line_number":132,"context_line":"            event_type \u003d self._get_event_type(snmp_trap)"},{"line_number":133,"context_line":"            if not event_type:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_378db331","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":45},"in_reply_to":"5fc1f717_389936c3","updated":"2019-03-15 08:23:30.000000000","message":"snmp_trap should be only dict, it will not be string in snmp_service, it is redundant.","commit_id":"795d3f67f94523e6500507f5309ee2f248271129"}],"vitrage/tests/unit/snmp_parsing/test_snmp_parsing.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"b9a97747f298f9646440353f429617999d7e1cfb","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    OPTS \u003d ["},{"line_number":113,"context_line":"        cfg.IntOpt(\u0027snmp_listening_port\u0027, default\u003d8162,"},{"line_number":114,"context_line":"                   help\u003d\u0027The listening port of snmp_parsing service\u0027),"},{"line_number":115,"context_line":"        cfg.StrOpt(\u0027alarm_oid_mapping\u0027,"},{"line_number":116,"context_line":"                   default\u003d\u0027vitrage/tests/resources/snmp_parsing/\u0027"},{"line_number":117,"context_line":"                           \u0027snmp_parsing_conf.yaml\u0027,"},{"line_number":118,"context_line":"                   help\u003d\u0027The default path of oid_mapping yaml file\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_386b76b7","line":115,"range":{"start_line":115,"start_character":20,"end_line":115,"end_character":37},"updated":"2019-03-14 13:01:40.000000000","message":"Renaming a configuration option is problematic, users might have existing vitrage.conf files that will stop working","commit_id":"795d3f67f94523e6500507f5309ee2f248271129"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3fc3528622be3069c32aea32711e5e8e095199e9","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    OPTS \u003d ["},{"line_number":113,"context_line":"        cfg.IntOpt(\u0027snmp_listening_port\u0027, default\u003d8162,"},{"line_number":114,"context_line":"                   help\u003d\u0027The listening port of snmp_parsing service\u0027),"},{"line_number":115,"context_line":"        cfg.StrOpt(\u0027alarm_oid_mapping\u0027,"},{"line_number":116,"context_line":"                   default\u003d\u0027vitrage/tests/resources/snmp_parsing/\u0027"},{"line_number":117,"context_line":"                           \u0027snmp_parsing_conf.yaml\u0027,"},{"line_number":118,"context_line":"                   help\u003d\u0027The default path of oid_mapping yaml file\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_8ee900b8","line":115,"range":{"start_line":115,"start_character":20,"end_line":115,"end_character":37},"in_reply_to":"5fc1f717_386b76b7","updated":"2019-03-14 14:28:24.000000000","message":"Please, follow a deprecation guide form oslo.config https://docs.openstack.org/oslo.config/latest/reference/deprecating.html. Also, we need a release note for such change","commit_id":"795d3f67f94523e6500507f5309ee2f248271129"},{"author":{"_account_id":29383,"name":"hewei","email":"hewei@cmss.chinamobile.com","username":"hewei"},"change_message_id":"962f6dd20e0567a6b2e60c5220ff379ba40fa005","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    OPTS \u003d ["},{"line_number":113,"context_line":"        cfg.IntOpt(\u0027snmp_listening_port\u0027, default\u003d8162,"},{"line_number":114,"context_line":"                   help\u003d\u0027The listening port of snmp_parsing service\u0027),"},{"line_number":115,"context_line":"        cfg.StrOpt(\u0027alarm_oid_mapping\u0027,"},{"line_number":116,"context_line":"                   default\u003d\u0027vitrage/tests/resources/snmp_parsing/\u0027"},{"line_number":117,"context_line":"                           \u0027snmp_parsing_conf.yaml\u0027,"},{"line_number":118,"context_line":"                   help\u003d\u0027The default path of oid_mapping yaml file\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_f7972b39","line":115,"range":{"start_line":115,"start_character":20,"end_line":115,"end_character":37},"in_reply_to":"5fc1f717_386b76b7","updated":"2019-03-15 08:23:30.000000000","message":"it should not be modified, it\u0027s my mistack.","commit_id":"795d3f67f94523e6500507f5309ee2f248271129"},{"author":{"_account_id":29383,"name":"hewei","email":"hewei@cmss.chinamobile.com","username":"hewei"},"change_message_id":"962f6dd20e0567a6b2e60c5220ff379ba40fa005","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    OPTS \u003d ["},{"line_number":113,"context_line":"        cfg.IntOpt(\u0027snmp_listening_port\u0027, default\u003d8162,"},{"line_number":114,"context_line":"                   help\u003d\u0027The listening port of snmp_parsing service\u0027),"},{"line_number":115,"context_line":"        cfg.StrOpt(\u0027alarm_oid_mapping\u0027,"},{"line_number":116,"context_line":"                   default\u003d\u0027vitrage/tests/resources/snmp_parsing/\u0027"},{"line_number":117,"context_line":"                           \u0027snmp_parsing_conf.yaml\u0027,"},{"line_number":118,"context_line":"                   help\u003d\u0027The default path of oid_mapping yaml file\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_179bd765","line":115,"range":{"start_line":115,"start_character":20,"end_line":115,"end_character":37},"in_reply_to":"5fc1f717_8ee900b8","updated":"2019-03-15 08:23:30.000000000","message":"it should not be modified, it\u0027s my mistack.","commit_id":"795d3f67f94523e6500507f5309ee2f248271129"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"b9a97747f298f9646440353f429617999d7e1cfb","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        super(TestSnmpParsing, cls).setUpClass()"},{"line_number":125,"context_line":"        cls.conf \u003d cfg.ConfigOpts()"},{"line_number":126,"context_line":"        cls.conf.register_opts(cls.OPTS, group\u003d\u0027snmp_parsing\u0027)"},{"line_number":127,"context_line":"        cls.conf.register_opts(cls.OPTS, group\u003d\u0027snmp\u0027)"},{"line_number":128,"context_line":"        cls.conf.register_opt("},{"line_number":129,"context_line":"            cfg.StrOpt(\u0027backend_url\u0027, default\u003d\u0027zake://\u0027), group\u003d\u0027coordination\u0027"},{"line_number":130,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_5868c2b7","line":127,"range":{"start_line":127,"start_character":8,"end_line":127,"end_character":54},"updated":"2019-03-14 13:01:40.000000000","message":"Why did you add this line?","commit_id":"795d3f67f94523e6500507f5309ee2f248271129"}]}