)]}'
{"vitrage/evaluator/scenario_evaluator.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"a7b9571ee1bdd1ea3b5a191adffe92caf44ce467","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"            for match in matches:"},{"line_number":230,"context_line":"                match_action_spec \u003d self._get_action_spec(action_spec, match)"},{"line_number":231,"context_line":"                match_action_spec_mirror \u003d copy.deepcopy(match_action_spec)"},{"line_number":232,"context_line":"                items_ids \u003d \\"},{"line_number":233,"context_line":"                    [match_item[1].vertex_id for match_item in match.items()]"},{"line_number":234,"context_line":"                match_hash \u003d md5(tuple(sorted(items_ids)))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_0fcd1884","line":231,"range":{"start_line":231,"start_character":43,"end_line":231,"end_character":75},"updated":"2019-03-26 09:10:12.000000000","message":"I think that this is not the right place for copying. The function _get_action_specs creates a *new* action spec. The problem is that inside the function, the new action spec is created with the properties of the original action spec. Try to copy the properties inside the function and see if it solves the bug.","commit_id":"7021afef3572d8b16b1a1fb27a17c32d1ac08111"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"b8384c2ac86678930e21eea098127636e91b9df4","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                items_ids \u003d \\"},{"line_number":232,"context_line":"                    [match_item[1].vertex_id for match_item in match.items()]"},{"line_number":233,"context_line":"                match_hash \u003d md5(tuple(sorted(items_ids)))"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"                self._evaluate_property_functions("},{"line_number":236,"context_line":"                    template_schema,"},{"line_number":237,"context_line":"                    match,"},{"line_number":238,"context_line":"                    match_action_spec.properties)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"                actions.append(ActionInfo(match_action_spec,"},{"line_number":241,"context_line":"                                          new_mode,"},{"line_number":242,"context_line":"                                          match_action_spec.id,"},{"line_number":243,"context_line":"                                          match_hash))"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        return actions"},{"line_number":246,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_a11ac1c2","line":243,"range":{"start_line":234,"start_character":0,"end_line":243,"end_character":54},"updated":"2019-03-27 07:47:39.000000000","message":"can you please undo this change? it is just a matter of indentation, right?","commit_id":"f6aee7d9618ccd162b8517d9700737c501893724"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"b8384c2ac86678930e21eea098127636e91b9df4","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        real_items \u003d {"},{"line_number":296,"context_line":"            target: match[target_id] for target, target_id in targets.items()"},{"line_number":297,"context_line":"        }"},{"line_number":298,"context_line":"        properties \u003d copy.deepcopy(action_spec.properties)"},{"line_number":299,"context_line":"        return ActionSpecs(action_spec.id,"},{"line_number":300,"context_line":"                           action_spec.type,"},{"line_number":301,"context_line":"                           real_items,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_a1dde1dd","line":298,"range":{"start_line":298,"start_character":21,"end_line":298,"end_character":58},"updated":"2019-03-27 07:47:39.000000000","message":"you can also write it in the ActionSpecs creation code, there is no need to define a temporary properties variable","commit_id":"f6aee7d9618ccd162b8517d9700737c501893724"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"b8384c2ac86678930e21eea098127636e91b9df4","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        if not db_actions:"},{"line_number":620,"context_line":"            return True"},{"line_number":621,"context_line":"        highest_score_action \u003d min("},{"line_number":622,"context_line":"            db_actions, key\u003dlambda action: (-action.score, action.created_at or"},{"line_number":623,"context_line":"                                            utcnow(False)))"},{"line_number":624,"context_line":"        return highest_score_action.trigger \u003d\u003d action_info.trigger_id and \\"},{"line_number":625,"context_line":"            highest_score_action.action_id \u003d\u003d action_info.action_id"},{"line_number":626,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_61f5b956","line":623,"range":{"start_line":622,"start_character":0,"end_line":623,"end_character":59},"updated":"2019-03-27 07:47:39.000000000","message":"why did you change it?","commit_id":"f6aee7d9618ccd162b8517d9700737c501893724"}]}
