)]}'
{"vitrage/api/controllers/v1/template.py":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c3bad4237f8250775c451500d743f277da10d6ab","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                t.uuid"},{"line_number":213,"context_line":"                for t in templates"},{"line_number":214,"context_line":"                if t.status !\u003d TStatus.DELETED"},{"line_number":215,"context_line":"                ][0]"},{"line_number":216,"context_line":"        return identifier"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_84ba6c07","line":215,"range":{"start_line":215,"start_character":17,"end_line":215,"end_character":20},"updated":"2019-05-26 14:40:51.000000000","message":"you are referencing the first item in a list that theoretically could be empty","commit_id":"caaedda735fbc96c411a0794266c69aaec0964d6"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"f2dc40048665f31bf50cb738467c049eead562c2","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                t.uuid"},{"line_number":213,"context_line":"                for t in templates"},{"line_number":214,"context_line":"                if t.status !\u003d TStatus.DELETED"},{"line_number":215,"context_line":"                ][0]"},{"line_number":216,"context_line":"        return identifier"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_87a90b25","line":215,"range":{"start_line":215,"start_character":17,"end_line":215,"end_character":20},"in_reply_to":"bfb3d3c7_84ba6c07","updated":"2019-05-27 07:36:30.000000000","message":"I check it in the if statement if it is empty","commit_id":"caaedda735fbc96c411a0794266c69aaec0964d6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"42888450965e8155a37598c0dc97ac93c5bfd3f4","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            return ["},{"line_number":215,"context_line":"                t.uuid"},{"line_number":216,"context_line":"                for t in templates"},{"line_number":217,"context_line":"                if t.status !\u003d TStatus.DELETED"},{"line_number":218,"context_line":"                ][0]"},{"line_number":219,"context_line":"        return identifier"},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_a54a07a9","line":217,"range":{"start_line":217,"start_character":16,"end_line":217,"end_character":46},"updated":"2019-05-27 09:36:22.000000000","message":"Let\u0027s filter deleted templates on DB side","commit_id":"2ffc3a0d00d06e9316bdca35cbe59d6d3671495d"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"989e72733427ef82cb294808ddbfbffea995718d","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            return ["},{"line_number":215,"context_line":"                t.uuid"},{"line_number":216,"context_line":"                for t in templates"},{"line_number":217,"context_line":"                if t.status !\u003d TStatus.DELETED"},{"line_number":218,"context_line":"                ][0]"},{"line_number":219,"context_line":"        return identifier"},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_2017e553","line":217,"range":{"start_line":217,"start_character":16,"end_line":217,"end_character":46},"in_reply_to":"bfb3d3c7_a54a07a9","updated":"2019-05-27 11:33:58.000000000","message":"Done","commit_id":"2ffc3a0d00d06e9316bdca35cbe59d6d3671495d"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"42888450965e8155a37598c0dc97ac93c5bfd3f4","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    @staticmethod"},{"line_number":222,"context_line":"    def _is_uuid(identifier):"},{"line_number":223,"context_line":"        if type(identifier) is list:"},{"line_number":224,"context_line":"            identifier, \u003d identifier"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        uuid_regex \u003d \u0027^[a-z0-9]{8}-[a-z0-9]{4}-[a-z0-9]\u0027 \\"},{"line_number":227,"context_line":"                     \u0027{4}-[a-z0-9]{4}-[a-z0-9]{12}$\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_854d83c5","line":224,"range":{"start_line":224,"start_character":12,"end_line":224,"end_character":23},"updated":"2019-05-27 09:36:22.000000000","message":"How it\u0027s supposed to work?","commit_id":"2ffc3a0d00d06e9316bdca35cbe59d6d3671495d"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"7bf48088c0c07542b8d82eca565e6133b0dd2d63","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    @staticmethod"},{"line_number":222,"context_line":"    def _is_uuid(identifier):"},{"line_number":223,"context_line":"        if type(identifier) is list:"},{"line_number":224,"context_line":"            identifier, \u003d identifier"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        uuid_regex \u003d \u0027^[a-z0-9]{8}-[a-z0-9]{4}-[a-z0-9]\u0027 \\"},{"line_number":227,"context_line":"                     \u0027{4}-[a-z0-9]{4}-[a-z0-9]{12}$\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_857ee3ac","line":224,"range":{"start_line":224,"start_character":12,"end_line":224,"end_character":23},"in_reply_to":"bfb3d3c7_854d83c5","updated":"2019-05-27 09:48:45.000000000","message":"it unpacks the first element of a list with one element\nsame as identifier[0] but also check there is one element only\ni can write \n\n[identifier] \u003d identifier \n\nalso if it is more readable","commit_id":"2ffc3a0d00d06e9316bdca35cbe59d6d3671495d"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"42888450965e8155a37598c0dc97ac93c5bfd3f4","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        if type(identifier) is list:"},{"line_number":224,"context_line":"            identifier, \u003d identifier"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        uuid_regex \u003d \u0027^[a-z0-9]{8}-[a-z0-9]{4}-[a-z0-9]\u0027 \\"},{"line_number":227,"context_line":"                     \u0027{4}-[a-z0-9]{4}-[a-z0-9]{12}$\u0027"},{"line_number":228,"context_line":"        if re.match(uuid_regex, identifier):"},{"line_number":229,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_e5547f55","line":226,"updated":"2019-05-27 09:36:22.000000000","message":"We can use oslo_utils,uuidutils [1] here\n\n[1] https://github.com/openstack/oslo.utils/blob/master/oslo_utils/uuidutils.py#L45","commit_id":"2ffc3a0d00d06e9316bdca35cbe59d6d3671495d"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"989e72733427ef82cb294808ddbfbffea995718d","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        if type(identifier) is list:"},{"line_number":224,"context_line":"            identifier, \u003d identifier"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        uuid_regex \u003d \u0027^[a-z0-9]{8}-[a-z0-9]{4}-[a-z0-9]\u0027 \\"},{"line_number":227,"context_line":"                     \u0027{4}-[a-z0-9]{4}-[a-z0-9]{12}$\u0027"},{"line_number":228,"context_line":"        if re.match(uuid_regex, identifier):"},{"line_number":229,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_60215db0","line":226,"in_reply_to":"bfb3d3c7_e5547f55","updated":"2019-05-27 11:33:58.000000000","message":"Done","commit_id":"2ffc3a0d00d06e9316bdca35cbe59d6d3671495d"}]}