)]}'
{"id":"openstack%2Fvitrage~753476","triplet_id":"openstack%2Fvitrage~master~I15c10d33464427a414a0c2ac2b7c076878ec0515","project":"openstack/vitrage","branch":"master","topic":"tmfapi639-test","hashtags":[],"change_id":"I15c10d33464427a414a0c2ac2b7c076878ec0515","subject":"Update tmfapi639-unit-test","status":"MERGED","created":"2020-09-23 00:44:18.000000000","updated":"2020-09-24 07:10:53.000000000","submitted":"2020-09-24 07:07:34.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"753476-1600931254645-276e733d","meta_rev_id":"05e8dc5ffa5f25810ac32dd5a47fbcb1622709d4","_number":753476,"virtual_id_number":753476,"owner":{"_account_id":30408,"name":"Qitao","email":"qihongtao@inspur.com","username":"qihongtao"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":30408,"name":"Qitao","email":"qihongtao@inspur.com","username":"qihongtao"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-09-24 07:07:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"all":[{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":30408,"name":"Qitao","email":"qihongtao@inspur.com","username":"qihongtao"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-09-24 05:57:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"all":[{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":30408,"name":"Qitao","email":"qihongtao@inspur.com","username":"qihongtao"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-09-24 05:57:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30408,"name":"Qitao","email":"qihongtao@inspur.com","username":"qihongtao"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-23 09:01:04.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2020-09-24 05:57:16.000000000","updated_by":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"reviewer":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"state":"REVIEWER"},{"updated":"2020-09-24 07:07:34.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"abfad74f63e241279821222f5804ade98892310b","author":{"_account_id":30408,"name":"Qitao","email":"qihongtao@inspur.com","username":"qihongtao"},"date":"2020-09-23 00:44:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"48783bff2b39715f38e73a920210920d1b5c1ed0","author":{"_account_id":30408,"name":"Qitao","email":"qihongtao@inspur.com","username":"qihongtao"},"date":"2020-09-23 01:00:15.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7dcf058fa260dd5d2e4fac58d1ca16f207711c91","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-23 02:04:52.000000000","message":"Patch Set 2: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/76e2a0ea9214401484eee9c9379ac614 : FAILURE in 5m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1369b419ae4f4e60ade6af315c5883c4 : FAILURE in 3m 56s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/38f55df7a9394491b2d91b2f1de9425a : POST_FAILURE in 9m 29s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2bc0744fc19b459299e8f6fdf7cb756c : POST_FAILURE in 5m 18s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b3e16f6c76764eb19f29e6d6e0d84738 : SUCCESS in 4m 29s\n- vitrage-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/8b1a681be5f544acbe24b0479f597997 : SUCCESS in 45m 18s\n- vitrage-tempest-plugin-api-ipv6-only https://zuul.opendev.org/t/openstack/build/399422b5563a45edb281f6a079067c36 : SUCCESS in 50m 53s\n- vitrage-tempest-plugin-datasources https://zuul.opendev.org/t/openstack/build/349703f40f714db4a8b35ac9db844746 : SUCCESS in 58m 30s\n- vitrage-tempest-plugin-mock https://zuul.opendev.org/t/openstack/build/bbc31f094e6f4026a25013bc4299d277 : SUCCESS in 46m 33s\n- vitrage-grenade https://zuul.opendev.org/t/openstack/build/6a3150a3627f414fb9a36143646ea947 : SUCCESS in 46m 35s","accounts_in_message":[],"_revision_number":2},{"id":"22837e00020d0c927e8892df852c567bec40505a","author":{"_account_id":30408,"name":"Qitao","email":"qihongtao@inspur.com","username":"qihongtao"},"date":"2020-09-23 02:26:09.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"7d127d46a56e4a2878a813d4f8ebe7e3e280d494","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-23 03:31:57.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/cd3727677a53464da6130808f168521f : SUCCESS in 6m 05s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a8ca7e35895c4696845075a4d503372a : SUCCESS in 3m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d0aa579f3810405490886091f0420a00 : POST_FAILURE in 6m 06s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/49a8fac02d6a4c6bb97efa0c8a84da19 : SUCCESS in 4m 43s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fc39cb60acbb450894e6573c0d651599 : SUCCESS in 4m 27s\n- vitrage-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/916cb3bbcdc04662b87b00fb24117eef : SUCCESS in 41m 48s\n- vitrage-tempest-plugin-api-ipv6-only https://zuul.opendev.org/t/openstack/build/99c719c422584aa49829ba3313717205 : SUCCESS in 48m 37s\n- vitrage-tempest-plugin-datasources https://zuul.opendev.org/t/openstack/build/9c1caaac2d8d467281a985e2f1944798 : POST_FAILURE in 1h 04m 09s\n- vitrage-tempest-plugin-mock https://zuul.opendev.org/t/openstack/build/d5716cf4e60440c184e97d85741695b9 : SUCCESS in 55m 04s\n- vitrage-grenade https://zuul.opendev.org/t/openstack/build/4127e73c0e1340008f333672d7a2021b : SUCCESS in 54m 57s","accounts_in_message":[],"_revision_number":3},{"id":"3e419665ec29e534d5847cab61b2ea69587d2951","author":{"_account_id":30408,"name":"Qitao","email":"qihongtao@inspur.com","username":"qihongtao"},"date":"2020-09-23 05:40:25.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"ab66b31eb8d8076405d5e5026a4d84be2572ff94","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-23 06:59:50.000000000","message":"Patch Set 3:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7b52a79e30534c3e8ff5c38b3e0a2943 : SUCCESS in 5m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0ecbe30197a24709b3aa270d2caf72ac : SUCCESS in 2m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/636b250176c94603a3e248bc7dd99ee2 : SUCCESS in 5m 17s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/69ab498c02a94fc59ec2150135cff408 : SUCCESS in 4m 08s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d0e43405ab5647cfbbe93ef06379df0b : SUCCESS in 3m 40s\n- vitrage-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/9619b7570f5e45c6943636ad1724ce34 : SUCCESS in 43m 12s\n- vitrage-tempest-plugin-api-ipv6-only https://zuul.opendev.org/t/openstack/build/66024d586a4e41a4b2897d434b845eec : SUCCESS in 41m 09s\n- vitrage-tempest-plugin-datasources https://zuul.opendev.org/t/openstack/build/cd4b0222417c456d8c9b27dc997dd98d : FAILURE in 1h 17m 13s\n- vitrage-tempest-plugin-mock https://zuul.opendev.org/t/openstack/build/21924ec2556f430ca8a1622ce8d134a1 : SUCCESS in 59m 15s\n- vitrage-grenade https://zuul.opendev.org/t/openstack/build/57accc151472450a9d45a602096197ae : SUCCESS in 51m 19s","accounts_in_message":[],"_revision_number":3},{"id":"d117830cc6437d92a525f23727bc5a27b382e8d4","author":{"_account_id":30408,"name":"Qitao","email":"qihongtao@inspur.com","username":"qihongtao"},"date":"2020-09-23 07:04:19.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"34650ef81b7ca658da876f7f6e823fa0e1301e16","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-23 08:35:12.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/62fa8c7e64cb4dcd9b852c90fb3d1e80 : SUCCESS in 11m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/18e1f46c1dc54f1daaf7491b4a7a234b : SUCCESS in 4m 22s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9e6d56f51183411a879c490d03ddd023 : SUCCESS in 5m 53s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/807c35b8821f49d7b151b456cfb827fa : SUCCESS in 6m 36s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/40e8eb874a5144f184189862c9c8e1df : SUCCESS in 5m 43s\n- vitrage-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/3a7f1134e1e541179ac92950963a4f5d : SUCCESS in 49m 21s\n- vitrage-tempest-plugin-api-ipv6-only https://zuul.opendev.org/t/openstack/build/b22b04f2e7e745f6aa5d5f563aaa1d2a : SUCCESS in 40m 40s\n- vitrage-tempest-plugin-datasources https://zuul.opendev.org/t/openstack/build/a054cd95db5b4ab691acfaeadd17185a : SUCCESS in 1h 16m 29s\n- vitrage-tempest-plugin-mock https://zuul.opendev.org/t/openstack/build/e6048f945ac3447c962c72cca95090d6 : SUCCESS in 48m 50s\n- vitrage-grenade https://zuul.opendev.org/t/openstack/build/255ee007f1a74a3881cf90dcdc141911 : SUCCESS in 50m 29s","accounts_in_message":[],"_revision_number":3},{"id":"1c36b672d6cc894fe378b9dc42585baf54ca275c","author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"date":"2020-09-23 08:37:29.000000000","message":"Patch Set 3: Code-Review-1\n\nwhy ?","accounts_in_message":[],"_revision_number":3},{"id":"74ba5c5e888f04e22b7b28297b7abde1de97da4d","author":{"_account_id":30408,"name":"Qitao","email":"qihongtao@inspur.com","username":"qihongtao"},"date":"2020-09-23 08:47:01.000000000","message":"Patch Set 3:\n\n\u003e why ?\n\nI feel that the resource class data source inherits the named AlarmTransformer...  it seems there is a little mismatch","accounts_in_message":[],"_revision_number":3},{"id":"ce9f364502a72f79764063c9dfafb783325ff2c6","author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"date":"2020-09-23 08:50:07.000000000","message":"Patch Set 3:\n\n\u003e \u003e why ?\n \u003e \n \u003e I feel that the resource class data source inherits the named\n \u003e AlarmTransformer...  it seems there is a little mismatch\n\nBut all alarm transformers test class use this base class it has methods that are used in child class","accounts_in_message":[],"_revision_number":3},{"id":"4aa9bd45d07f4cc092df9bf7952449140d2eae12","author":{"_account_id":30408,"name":"Qitao","email":"qihongtao@inspur.com","username":"qihongtao"},"date":"2020-09-23 08:56:03.000000000","message":"Patch Set 3:\n\n\u003e \u003e \u003e why ?\n \u003e \u003e\n \u003e \u003e I feel that the resource class data source inherits the named\n \u003e \u003e AlarmTransformer...  it seems there is a little mismatch\n \u003e \n \u003e But all alarm transformers test class use this base class it has\n \u003e methods that are used in child class\n\nYes, so I added an internal method instead. The commit message is not accurate, I should use update instead of fix. If necessary, i will make changes","accounts_in_message":[],"_revision_number":3},{"id":"2a2169db7bca0420b4469d864038b4d51b5a1595","author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"date":"2020-09-23 09:00:48.000000000","message":"Patch Set 3:\n\n\u003e \u003e \u003e \u003e why ?\n \u003e \u003e \u003e\n \u003e \u003e \u003e I feel that the resource class data source inherits the named\n \u003e \u003e \u003e AlarmTransformer...  it seems there is a little mismatch\n \u003e \u003e\n \u003e \u003e But all alarm transformers test class use this base class it has\n \u003e \u003e methods that are used in child class\n \u003e \n \u003e Yes, so I added an internal method instead. The commit message is\n \u003e not accurate, I should use update instead of fix. If necessary, i\n \u003e will make changes\n\nthe base class BaseAlarmTransformerTest was created as a base class with utility methods for testing alarm transformers to avoid duplication\nthats why ALL the alrqam transformer test classes use it (e.g doctor,collectd, prometeus ) what you did is duplicated the method that is on the base class which is wrong we want to reuse and duplicate","accounts_in_message":[],"_revision_number":3},{"id":"3bd9b7e373ffbee1c955b7f10f807fa24964d903","author":{"_account_id":30408,"name":"Qitao","email":"qihongtao@inspur.com","username":"qihongtao"},"date":"2020-09-23 09:04:17.000000000","message":"Patch Set 3:\n\n\u003e \u003e \u003e \u003e \u003e why ?\n \u003e \u003e \u003e \u003e\n \u003e \u003e \u003e \u003e I feel that the resource class data source inherits the named\n \u003e \u003e \u003e \u003e AlarmTransformer...  it seems there is a little mismatch\n \u003e \u003e \u003e\n \u003e \u003e \u003e But all alarm transformers test class use this base class it\n \u003e has\n \u003e \u003e \u003e methods that are used in child class\n \u003e \u003e\n \u003e \u003e Yes, so I added an internal method instead. The commit message is\n \u003e \u003e not accurate, I should use update instead of fix. If necessary, i\n \u003e \u003e will make changes\n \u003e \n \u003e the base class BaseAlarmTransformerTest was created as a base class\n \u003e with utility methods for testing alarm transformers to avoid\n \u003e duplication\n \u003e thats why ALL the alrqam transformer test classes use it (e.g\n \u003e doctor,collectd, prometeus ) what you did is duplicated the method\n \u003e that is on the base class which is wrong we want to reuse and\n \u003e duplicate\n\nOkay, I see. If the test method has not been modified, I should not do this operation.","accounts_in_message":[],"_revision_number":3},{"id":"7c95edcc95a269edfc5e2b9518938f51ce15b235","author":{"_account_id":30408,"name":"Qitao","email":"qihongtao@inspur.com","username":"qihongtao"},"date":"2020-09-23 09:36:09.000000000","message":"Patch Set 3:\n\nTmfapi639 belongs to resource transform, BaseAlarmTransformerTest was created for testing alarm transformers.","accounts_in_message":[],"_revision_number":3},{"id":"b2e6d70b233ce2b12921a7e1d9550184174ff3bf","author":{"_account_id":30408,"name":"Qitao","email":"qihongtao@inspur.com","username":"qihongtao"},"date":"2020-09-24 01:28:14.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"83fc21f725c5e7c22376fa8667a3f5a61be5536e","author":{"_account_id":30408,"name":"Qitao","email":"qihongtao@inspur.com","username":"qihongtao"},"date":"2020-09-24 01:34:09.000000000","message":"Uploaded patch set 5: Commit message was updated.","accounts_in_message":[],"_revision_number":5},{"id":"0e5ab04a2fbc8f05f3b1dc97cc89b1db0f884f0c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-24 02:33:28.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a6cd610d24744d57bb492268e2711e11 : SUCCESS in 5m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/47499528b7414478a5c2560775986e63 : SUCCESS in 3m 33s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/043d155d2af44936ac48ee54e3d334a4 : SUCCESS in 5m 25s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ce1ca1a8eb4f433a9d42571ada7fa8e9 : SUCCESS in 5m 10s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/07cf2c3633454dad8b9bf8a46fed4ae2 : SUCCESS in 4m 11s\n- vitrage-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/b92dbd04fd6842ebbe1a62c5aa9e4b2e : SUCCESS in 40m 51s\n- vitrage-tempest-plugin-api-ipv6-only https://zuul.opendev.org/t/openstack/build/17c41aefac9e44b7a8710e4e8b831605 : SUCCESS in 40m 59s\n- vitrage-tempest-plugin-datasources https://zuul.opendev.org/t/openstack/build/17d340922a7c4930b70a7a5f9396a853 : SUCCESS in 57m 25s\n- vitrage-tempest-plugin-mock https://zuul.opendev.org/t/openstack/build/1a35b462aa814d88bdb401831550b61b : SUCCESS in 47m 16s\n- vitrage-grenade https://zuul.opendev.org/t/openstack/build/22cfbf35c1de4e12b0beaa7d2385dcf8 : SUCCESS in 46m 03s","accounts_in_message":[],"_revision_number":5},{"id":"d7af015a72c0611a6d5871e1f57f8cee22cb2858","author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"date":"2020-09-24 05:57:16.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":5},{"id":"b8514e2521446aa7c00680a18d6667c52340c678","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-24 05:59:02.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"7f011ca1331ac434d7a0a77db34daa296381b470","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-24 07:07:34.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":5},{"id":"6e9279e165032c9072b65893eb6004c76b408269","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-24 07:07:34.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/116962abd05b4e928e96d6f5ea4e64c0 : SUCCESS in 5m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d48c87f4875f42d18151dc5780e1183b : SUCCESS in 4m 02s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/018bbbb9813a44bd821529a3f044c577 : SUCCESS in 6m 09s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1d60c3b8e68c409784e345f7b3c1a3e6 : SUCCESS in 6m 20s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b4ada7e039aa417f922f1d1ff6f788d8 : SUCCESS in 4m 58s\n- vitrage-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/4d782299e3444603b2250cdc9d4d5912 : SUCCESS in 1h 00m 55s\n- vitrage-tempest-plugin-api-ipv6-only https://zuul.opendev.org/t/openstack/build/4492aba3c0934aca945fcec23d95c847 : SUCCESS in 42m 32s\n- vitrage-tempest-plugin-datasources https://zuul.opendev.org/t/openstack/build/95baaf00259f4ff3bc0b72382c1d1c53 : SUCCESS in 1h 03m 55s\n- vitrage-grenade https://zuul.opendev.org/t/openstack/build/a26e7c0b5bc14a75b87412b6d48facd5 : SUCCESS in 48m 09s","accounts_in_message":[],"_revision_number":5},{"id":"93423a66dd36b3bc7462c27f087ce596d7b2ecd9","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-24 07:10:53.000000000","message":"Patch Set 5:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a918844d72d94d8b853bee06faf8d8fa : SUCCESS in 2m 11s","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"9f9b7194acb80c36418c457b3f83cf44bb195ce1","revisions":{"a256e6a3052fafb14130934fb16570463b78e5e9":{"kind":"REWORK","_number":1,"created":"2020-09-23 00:44:18.000000000","uploader":{"_account_id":30408,"name":"Qitao","email":"qihongtao@inspur.com","username":"qihongtao"},"ref":"refs/changes/76/753476/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/vitrage","ref":"refs/changes/76/753476/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/vitrage refs/changes/76/753476/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/vitrage refs/changes/76/753476/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/vitrage refs/changes/76/753476/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/vitrage refs/changes/76/753476/1"}}},"commit":{"parents":[{"commit":"38da3437ed995e901915476851d3c068b1f7d6d9","subject":"Merge \"Remove CPickle\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/vitrage/commit/38da3437ed995e901915476851d3c068b1f7d6d9"}]}],"author":{"name":"Q.hongtao","email":"qihongtao@inspur.com","date":"2020-09-18 08:23:54.000000000","tz":480},"committer":{"name":"Q.hongtao","email":"qihongtao@inspur.com","date":"2020-09-21 08:20:07.000000000","tz":480},"subject":"Fix tmfapi639-unit-test","message":"Fix tmfapi639-unit-test\n\nResource datasource should not inherit AlarmTransformerTest\n\nChange-Id: I15c10d33464427a414a0c2ac2b7c076878ec0515\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/vitrage/commit/a256e6a3052fafb14130934fb16570463b78e5e9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/vitrage/commit/a256e6a3052fafb14130934fb16570463b78e5e9"}]},"branch":"refs/heads/master"},"f9980282df6695e3765ef0e485a078be4824b7df":{"kind":"REWORK","_number":2,"created":"2020-09-23 01:00:15.000000000","uploader":{"_account_id":30408,"name":"Qitao","email":"qihongtao@inspur.com","username":"qihongtao"},"ref":"refs/changes/76/753476/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/vitrage","ref":"refs/changes/76/753476/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/vitrage refs/changes/76/753476/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/vitrage refs/changes/76/753476/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/vitrage refs/changes/76/753476/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/vitrage refs/changes/76/753476/2"}}},"commit":{"parents":[{"commit":"38da3437ed995e901915476851d3c068b1f7d6d9","subject":"Merge \"Remove CPickle\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/vitrage/commit/38da3437ed995e901915476851d3c068b1f7d6d9"}]}],"author":{"name":"Q.hongtao","email":"qihongtao@inspur.com","date":"2020-09-18 08:23:54.000000000","tz":480},"committer":{"name":"Q.hongtao","email":"qihongtao@inspur.com","date":"2020-09-23 01:00:03.000000000","tz":480},"subject":"Fix tmfapi639-unit-test","message":"Fix tmfapi639-unit-test\n\nResource datasource should not inherit AlarmTransformerTest\n\nChange-Id: I15c10d33464427a414a0c2ac2b7c076878ec0515\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/vitrage/commit/f9980282df6695e3765ef0e485a078be4824b7df"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/vitrage/commit/f9980282df6695e3765ef0e485a078be4824b7df"}]},"branch":"refs/heads/master"},"c067ced0659359efa9a1db50eb749d2415cc74cf":{"kind":"REWORK","_number":3,"created":"2020-09-23 02:26:09.000000000","uploader":{"_account_id":30408,"name":"Qitao","email":"qihongtao@inspur.com","username":"qihongtao"},"ref":"refs/changes/76/753476/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/vitrage","ref":"refs/changes/76/753476/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/vitrage refs/changes/76/753476/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/vitrage refs/changes/76/753476/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/vitrage refs/changes/76/753476/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/vitrage refs/changes/76/753476/3"}}},"commit":{"parents":[{"commit":"38da3437ed995e901915476851d3c068b1f7d6d9","subject":"Merge \"Remove CPickle\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/vitrage/commit/38da3437ed995e901915476851d3c068b1f7d6d9"}]}],"author":{"name":"Q.hongtao","email":"qihongtao@inspur.com","date":"2020-09-18 08:23:54.000000000","tz":480},"committer":{"name":"Q.hongtao","email":"qihongtao@inspur.com","date":"2020-09-23 02:25:38.000000000","tz":480},"subject":"Fix tmfapi639-unit-test","message":"Fix tmfapi639-unit-test\n\nResource datasource should not inherit AlarmTransformerTest\n\nChange-Id: I15c10d33464427a414a0c2ac2b7c076878ec0515\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/vitrage/commit/c067ced0659359efa9a1db50eb749d2415cc74cf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/vitrage/commit/c067ced0659359efa9a1db50eb749d2415cc74cf"}]},"branch":"refs/heads/master"},"0a160f53d1cc28b81e7fa6b24e66b49d40fe42b7":{"kind":"REWORK","_number":4,"created":"2020-09-24 01:28:14.000000000","uploader":{"_account_id":30408,"name":"Qitao","email":"qihongtao@inspur.com","username":"qihongtao"},"ref":"refs/changes/76/753476/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/vitrage","ref":"refs/changes/76/753476/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/vitrage refs/changes/76/753476/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/vitrage refs/changes/76/753476/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/vitrage refs/changes/76/753476/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/vitrage refs/changes/76/753476/4"}}},"commit":{"parents":[{"commit":"b78913d9c52c27af33651ef25c57ef23ebcffc81","subject":"Fix kapacitor datasource_value","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/vitrage/commit/b78913d9c52c27af33651ef25c57ef23ebcffc81"}]}],"author":{"name":"Q.hongtao","email":"qihongtao@inspur.com","date":"2020-09-18 08:23:54.000000000","tz":480},"committer":{"name":"Q.hongtao","email":"qihongtao@inspur.com","date":"2020-09-24 01:22:03.000000000","tz":480},"subject":"Update tmfapi639-unit-test","message":"Update tmfapi639-unit-test\n\nTmfapi639 belongs to resource transform, BaseAlarmTransformerTest was\ncreated for testing alarm transformers.\nSo update tmfapi639 to inherit the base class BaseTransformerTest.\n\nChange-Id: I15c10d33464427a414a0c2ac2b7c076878ec0515\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/vitrage/commit/0a160f53d1cc28b81e7fa6b24e66b49d40fe42b7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/vitrage/commit/0a160f53d1cc28b81e7fa6b24e66b49d40fe42b7"}]},"branch":"refs/heads/master"},"9f9b7194acb80c36418c457b3f83cf44bb195ce1":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2020-09-24 01:34:09.000000000","uploader":{"_account_id":30408,"name":"Qitao","email":"qihongtao@inspur.com","username":"qihongtao"},"ref":"refs/changes/76/753476/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/vitrage","ref":"refs/changes/76/753476/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/vitrage refs/changes/76/753476/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/vitrage refs/changes/76/753476/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/vitrage refs/changes/76/753476/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/vitrage refs/changes/76/753476/5"}}},"commit":{"parents":[{"commit":"b78913d9c52c27af33651ef25c57ef23ebcffc81","subject":"Fix kapacitor datasource_value","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/vitrage/commit/b78913d9c52c27af33651ef25c57ef23ebcffc81"}]}],"author":{"name":"Q.hongtao","email":"qihongtao@inspur.com","date":"2020-09-18 08:23:54.000000000","tz":480},"committer":{"name":"Q.hongtao","email":"qihongtao@inspur.com","date":"2020-09-24 01:33:55.000000000","tz":480},"subject":"Update tmfapi639-unit-test","message":"Update tmfapi639-unit-test\n\nTmfapi639 belongs to resource transform, BaseAlarmTransformerTest was\ncreated for testing alarm transformers.\nUpdate tmfapi639 to inherit the base class BaseTransformerTest.\n\nChange-Id: I15c10d33464427a414a0c2ac2b7c076878ec0515\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/vitrage/commit/9f9b7194acb80c36418c457b3f83cf44bb195ce1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/vitrage/commit/9f9b7194acb80c36418c457b3f83cf44bb195ce1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
