)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"ae057e7c4091e898ce57af0f4b0bdbc1e6b1bf6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1be78d0d_6049f69c","updated":"2024-03-12 10:20:30.000000000","message":"Somehow, this does not work at all. But it\u0027s weird, I don\u0027t see any issues with access to DB through epdb.\n\nI\u0027ve added epdb on L161, and what I saw while running `vitrage.tests.unit.evaluator.test_scenario_repository.RegExTemplateTest.test_basic_regex` was:\n\n```\n(Epdb) session.connection().engine\nEngine(sqlite:///test-RegExTemplateTest-3.db)\n(Epdb) session.connection().info\n{\u0027pid\u0027: 59868, \u0027in_transaction\u0027: True}\n(Epdb) session.connection().get_transaction().connection.engine\nEngine(sqlite:///test-RegExTemplateTest-3.db)\n(Epdb) session.connection().get_transaction().commit()\n(Epdb) session.connection().info\n{\u0027pid\u0027: 59868}\n(Epdb)\n```\n\nSo there\u0027s obviously a mistake somewhere in the patch, but I really don\u0027t see it so far 😞","commit_id":"38a9c4cba56aea008265fd78e57307c40650a585"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5d82faafd1a45af1671b2b71221cb21cb99aab49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"526a1dcf_3ab44c96","updated":"2024-03-12 10:25:53.000000000","message":"oh, ok, I guess I do see now 😄","commit_id":"38a9c4cba56aea008265fd78e57307c40650a585"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"aac60947b7596acde8b46c8f438603934a7e9d24","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"26c6269a_12353e08","in_reply_to":"1be78d0d_6049f69c","updated":"2024-03-12 11:13:26.000000000","message":"Ok, I\u0027m not in fact.\n\nBut that\u0027s crazy. I\u0027m 100% sure, that test_basic_regex test fails exactly on L161, once _session_for_write() should be closed.\n\nBut I don\u0027t really see any issue with that on my own, as again - with epdb I can commit and having totally valid session.\n\nMoreover, I also tried to get data after commit with a success:\n\n```\n(Epdb) session.query(text(\u0027name from templates\u0027)).all()\n[(\u0027basic_regex_for_fail\u0027,)]\n(Epdb)\n```\n\nSo really, what\u0027s going wrong when `_session_for_write()` is getting closed...","commit_id":"38a9c4cba56aea008265fd78e57307c40650a585"}]}