)]}'
{"id":"openstack%2Fvitrage~962658","triplet_id":"openstack%2Fvitrage~stable%2F2025.2~If629023052aa2c067c419bba10837f77bcc3e59c","project":"openstack/vitrage","branch":"stable/2025.2","hashtags":[],"change_id":"If629023052aa2c067c419bba10837f77bcc3e59c","subject":"Replace eval with function matching","status":"MERGED","created":"2025-10-01 10:47:16.000000000","updated":"2025-10-01 12:29:05.000000000","submitted":"2025-10-01 12:28:09.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"962658","cherry_pick_of_change":962617,"cherry_pick_of_patch_set":4,"meta_rev_id":"cf23f2d06b4e6ccd29d90d4718d15afb53d81aa2","_number":962658,"virtual_id_number":962658,"owner":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-10-01 12:28:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2025-10-01 11:43:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2025-10-01 11:43:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-01 11:40:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"46dd0b24a347b104b0e140f9cdf0e4782488eea5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2025-10-01 10:47:16.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"c7ba59e4255cb281bf1dd925575f4710a121ead3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-10-01 11:40:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/4ec9bb350f7f4a2e98832435223fcb49\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/87d46bee3e9d422d9ace80bc9ddad065 : SUCCESS in 3m 26s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/65d01d101f5348efb39cfb4d4a622912 : SUCCESS in 4m 15s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/4691a16d5c41456fb1e7be26f74de85a : SUCCESS in 4m 42s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/0c650bd7467248018d46f42b9a3b809c : SUCCESS in 7m 10s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f765fe11d75245958e77d9d37f9fde18 : SUCCESS in 3m 42s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/254e77b376bc4140a61c45ccffbc17ab : SUCCESS in 2m 48s\n- vitrage-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/77823375b346434293d6753ebe3ae8fc : FAILURE in 39m 06s (non-voting)\n- vitrage-tempest-plugin-api-ipv6-only https://zuul.opendev.org/t/openstack/build/14bff2fdfe7145e891c497bcdb483388 : FAILURE in 48m 04s (non-voting)\n- vitrage-tempest-plugin-datasources https://zuul.opendev.org/t/openstack/build/8b2a8a84c25046ea9d048fb0b1384720 : FAILURE in 38m 30s (non-voting)\n- vitrage-grenade https://zuul.opendev.org/t/openstack/build/cdd841cd22544b768a4e32560e9fc4af : SUCCESS in 39m 14s","accounts_in_message":[],"_revision_number":1},{"id":"d8ca4ff97c8624a8e2ec4f9587f6222dbcde879f","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2025-10-01 11:43:42.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"8965dc8fe00b8d93996a36b7f3e45f3d5f57905a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-10-01 11:44:05.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"131d17fd1b06ead6fba023445a3df7cfb225b127","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-10-01 12:28:09.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9ca1a1bcdc9e42a9a581fc63e8f60e5c\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3a3f4797d9a644d7a86544d750536ea7 : SUCCESS in 4m 12s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/578857bb6ba24414b7bfbc0f5c9a43d8 : SUCCESS in 6m 05s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/4366f172cbfe41b9adf4029e9c5daf3e : SUCCESS in 4m 49s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/82295faae48448f2a412b2ec47028f03 : SUCCESS in 3m 51s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/42e770bdcfb34d47b74792932bf09773 : SUCCESS in 2m 43s\n- vitrage-grenade https://zuul.opendev.org/t/openstack/build/d59107b831ff43afa3ca1c04ee327cb8 : SUCCESS in 43m 06s","accounts_in_message":[],"_revision_number":1},{"id":"fb02c4b3907146183d38d8b70df05d2d081c7213","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-10-01 12:28:09.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"cf23f2d06b4e6ccd29d90d4718d15afb53d81aa2","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-10-01 12:29:05.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/62b86ca2f8d443c68afa7dcdc608b16e\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/effd9f8667e2413cb30fa39ffe256e69 : SUCCESS in 37s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/8890385bc3af46e1866d705e8c12551d : SUCCESS in 40s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"89df4bd2ffda1a5ddea66cd828438a6a171a3b11","revisions":{"89df4bd2ffda1a5ddea66cd828438a6a171a3b11":{"kind":"REWORK","_number":1,"created":"2025-10-01 10:47:16.000000000","uploader":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"ref":"refs/changes/58/962658/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/vitrage","ref":"refs/changes/58/962658/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/vitrage refs/changes/58/962658/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/vitrage refs/changes/58/962658/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/vitrage refs/changes/58/962658/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/vitrage refs/changes/58/962658/1"}}},"commit":{"parents":[{"commit":"a0ca4f8a553e4f0200aac410feb982b0811714a1","subject":"Add unit testing for graph.query","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/vitrage/commit/a0ca4f8a553e4f0200aac410feb982b0811714a1"}]}],"author":{"name":"Dmitriy Rabotyagov","email":"dmitriy@adria-cloud.com","date":"2025-09-30 18:46:39.000000000","tz":120},"committer":{"name":"Dmitriy Rabotyagov","email":"dmitriy@adria-cloud.com","date":"2025-10-01 10:47:16.000000000","tz":0},"subject":"Replace eval with function matching","message":"Replace eval with function matching\n\nUsing eval in code is not safe and may lead to security\nrisks, especially given that query itself is supplied by a user.\n\nThis refactors the code making is presumably safe\nand prone to code injections, which are possible with eval.\n\nStory: 2011539\nTask: 52866\nChange-Id: If629023052aa2c067c419bba10837f77bcc3e59c\nSigned-off-by: Dmitriy Rabotyagov \u003cdmitriy@adria-cloud.com\u003e\n(cherry picked from commit 5b57e2b32a6d02992a28d9a671ebba5e308fd141)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/vitrage/commit/89df4bd2ffda1a5ddea66cd828438a6a171a3b11"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/vitrage/commit/89df4bd2ffda1a5ddea66cd828438a6a171a3b11"}]},"branch":"refs/heads/stable/2025.2"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}