)]}'
{"id":"openstack%2Fwatcher-dashboard~794367","triplet_id":"openstack%2Fwatcher-dashboard~master~Id18945b881d150f972dbbd5522010be0157fba17","project":"openstack/watcher-dashboard","branch":"master","topic":"fix_create_audit","hashtags":[],"change_id":"Id18945b881d150f972dbbd5522010be0157fba17","subject":"Fix create audit fail from audit_template","status":"MERGED","created":"2021-06-03 02:37:33.000000000","updated":"2021-07-05 13:47:29.000000000","submitted":"2021-07-05 13:46:10.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"794367-fix_create_audit","meta_rev_id":"a4422bbff2beb0354341e2bfebc96fe18043876a","_number":794367,"virtual_id_number":794367,"owner":{"_account_id":31455,"name":"Min Li","email":"limin.lc@inspur.com","username":"limin0801"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-07-05 13:46:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"all":[{"value":2,"date":"2021-07-01 13:24:51.000000000","_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"all":[{"value":1,"date":"2021-07-05 13:34:47.000000000","_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}],"reviewers":{"CC":[{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-03 02:49:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-07-01 08:28:30.000000000","updated_by":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"reviewer":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"state":"REVIEWER"},{"updated":"2021-07-01 11:38:46.000000000","updated_by":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"reviewer":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"state":"CC"},{"updated":"2021-07-01 11:38:46.000000000","updated_by":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"reviewer":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"state":"REVIEWER"}],"messages":[{"id":"6451748545b86774267573722dbf2bbf35c2774a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31455,"name":"Min Li","email":"limin.lc@inspur.com","username":"limin0801"},"date":"2021-06-03 02:37:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e6fcf02fa2aedf9bc6032899396919136e2f2682","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-03 02:49:44.000000000","message":"Patch Set 1: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/8877ff9a270c49b0b7b94b9003fc2d6a : FAILURE in 4m 53s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/84fdab08b3344ffdb3c0f62021421272 : FAILURE in 4m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9a6bafc5e84543c5a24ac2eaef7db832 : FAILURE in 5m 17s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/79eeee94586842f4a2c19a9750b78668 : FAILURE in 5m 18s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/46f6311168a1479381deae004bf6d886 : SUCCESS in 6m 00s","accounts_in_message":[],"_revision_number":1},{"id":"9ebc663061524379d19f1043e24db2911d5335dc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31455,"name":"Min Li","email":"limin.lc@inspur.com","username":"limin0801"},"date":"2021-06-03 02:59:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c115affc3dc254994bc66b8241d6c9216b166aef","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-03 03:11:10.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9c389126a02749d283d0f3bf57193aaf : FAILURE in 4m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0b10c16499f8490e958e199fc1fd2a86 : SUCCESS in 4m 30s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2cca9184a99a47208141bc6e19380890 : FAILURE in 5m 08s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/442ff8fd567c4f1b873300d75ae4a562 : FAILURE in 4m 38s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/95e42690d8224393848c00e8d5a3a4c7 : SUCCESS in 5m 12s","accounts_in_message":[],"_revision_number":2},{"id":"f938a04dba7ed71a2809f1f0aac83f5bee89a7d2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31455,"name":"Min Li","email":"limin.lc@inspur.com","username":"limin0801"},"date":"2021-06-03 03:25:57.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"1c59fac5d8b8159bffccd5745725ac1ff4538aa3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-03 03:36:22.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/10e9658339d54e28b1162f37505fb94c : SUCCESS in 4m 39s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/94b69533a48e40ad86ffeeb35ba1d090 : SUCCESS in 4m 30s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e4e78f7c28c7457898f35f5e368483a5 : SUCCESS in 4m 52s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ac807d06c8bc408fad125a4f72ce7c54 : SUCCESS in 4m 39s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8cba5b541acf4b0a810630aea2782620 : SUCCESS in 5m 05s","accounts_in_message":[],"_revision_number":3},{"id":"971c1f6f93bcac7bd651385ac0c476b650649ad0","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2021-07-01 11:40:05.000000000","message":"Patch Set 3:\n\nI need to verify that our API actually treats name as optional argument / attribute. It could also be that the call from watcher-dashboard is simply wrong because name is required argument / attribute. Investigating this will take some time.","accounts_in_message":[],"_revision_number":3},{"id":"bad35e131af78a025ef38feddce4d950ed86e3ae","author":{"_account_id":31455,"name":"Min Li","email":"limin.lc@inspur.com","username":"limin0801"},"date":"2021-07-01 12:07:05.000000000","message":"Patch Set 3:\n\n\u003e Patch Set 3:\n\u003e \n\u003e I need to verify that our API actually treats name as optional argument / attribute. It could also be that the call from watcher-dashboard is simply wrong because name is required argument / attribute. Investigating this will take some time.\n\nThanks for your review.\nIn fact, the position to call the method watcher_dashboard/api/watcher.Audit.create is https://opendev.org/openstack/watcher-dashboard/src/branch/master/watcher_dashboard/content/audit_templates/tables.py#L66, params only passes audit_type and auto_trigger, but the method requires a positional parameter, name.\nIn addition, name is not a required argument when creating audit. API documentation: https://docs.openstack.org/api-ref/resource-optimization/?expanded\u003dcreate-audit-detail#create-audit","accounts_in_message":[],"_revision_number":3},{"id":"2b7ddd0d67048d0d52d7344819e44b55e17e18ae","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2021-07-01 13:24:51.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"37923829bfd41a5530d99ddceafdef9a023d2206","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2021-07-05 13:34:47.000000000","message":"Patch Set 3: Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"d549b74b1a311fbe0a41fdd428d513f0588da2a7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-05 13:35:02.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"86d3581df6720bcb7a1ca892220419dd583f7e60","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-05 13:46:09.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c0217bb4c3314d5d829e9c58b5af86a5 : SUCCESS in 4m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/af0cb9ad27ab423d84239d435eaf877b : SUCCESS in 4m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/abe55e9bb44347bf867aea835e8a98dd : SUCCESS in 5m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/77dbfd3b593743e68bd327d41637b83c : SUCCESS in 5m 52s","accounts_in_message":[],"_revision_number":3},{"id":"6e96e82e97418d88df9fb715e9b1d4045ad1f98c","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-05 13:46:10.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"a4422bbff2beb0354341e2bfebc96fe18043876a","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-05 13:47:29.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3489328224e44e21a259f9765313a7e0 : SUCCESS in 59s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"2ee3c6015c5347c75727f5afd2059e4060a1da1f","revisions":{"b4a8a2ebe3930b2cf161d784f6413a3c1466e785":{"kind":"REWORK","_number":1,"created":"2021-06-03 02:37:33.000000000","uploader":{"_account_id":31455,"name":"Min Li","email":"limin.lc@inspur.com","username":"limin0801"},"ref":"refs/changes/67/794367/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher-dashboard","ref":"refs/changes/67/794367/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher-dashboard refs/changes/67/794367/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher-dashboard refs/changes/67/794367/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher-dashboard refs/changes/67/794367/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher-dashboard refs/changes/67/794367/1"}}},"commit":{"parents":[{"commit":"427afe1f75665592c53b8597d46b9e25078627fa","subject":"Dropping lower constraints testing","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-dashboard/commit/427afe1f75665592c53b8597d46b9e25078627fa"}]}],"author":{"name":"limin.lc","email":"limin.lc@inspur.com","date":"2021-06-03 02:32:49.000000000","tz":480},"committer":{"name":"limin.lc","email":"limin.lc@inspur.com","date":"2021-06-03 02:32:49.000000000","tz":480},"subject":"Fix create audit fail from audit_template","message":"Fix create audit fail from audit_template\n\nThe name is a positional parameter in create() of audit,\nbut this parameter is not defined when calling from the\naudit template. This patch fix it.\n\nRelated Bug: #1930565\nChange-Id: Id18945b881d150f972dbbd5522010be0157fba17\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-dashboard/commit/b4a8a2ebe3930b2cf161d784f6413a3c1466e785"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-dashboard/commit/b4a8a2ebe3930b2cf161d784f6413a3c1466e785"}]},"branch":"refs/heads/master"},"b3e198622814f41342db5bb0b79985876eedc16b":{"kind":"REWORK","_number":2,"created":"2021-06-03 02:59:52.000000000","uploader":{"_account_id":31455,"name":"Min Li","email":"limin.lc@inspur.com","username":"limin0801"},"ref":"refs/changes/67/794367/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher-dashboard","ref":"refs/changes/67/794367/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher-dashboard refs/changes/67/794367/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher-dashboard refs/changes/67/794367/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher-dashboard refs/changes/67/794367/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher-dashboard refs/changes/67/794367/2"}}},"commit":{"parents":[{"commit":"427afe1f75665592c53b8597d46b9e25078627fa","subject":"Dropping lower constraints testing","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-dashboard/commit/427afe1f75665592c53b8597d46b9e25078627fa"}]}],"author":{"name":"limin.lc","email":"limin.lc@inspur.com","date":"2021-06-03 02:32:49.000000000","tz":480},"committer":{"name":"limin.lc","email":"limin.lc@inspur.com","date":"2021-06-03 02:59:33.000000000","tz":480},"subject":"Fix create audit fail from audit_template","message":"Fix create audit fail from audit_template\n\nThe name is a positional parameter in create() of audit,\nbut this parameter is not defined when calling from the\naudit template. This patch fix it.\n\nRelated Bug: #1930565\nChange-Id: Id18945b881d150f972dbbd5522010be0157fba17\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-dashboard/commit/b3e198622814f41342db5bb0b79985876eedc16b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-dashboard/commit/b3e198622814f41342db5bb0b79985876eedc16b"}]},"branch":"refs/heads/master"},"2ee3c6015c5347c75727f5afd2059e4060a1da1f":{"kind":"REWORK","_number":3,"created":"2021-06-03 03:25:57.000000000","uploader":{"_account_id":31455,"name":"Min Li","email":"limin.lc@inspur.com","username":"limin0801"},"ref":"refs/changes/67/794367/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher-dashboard","ref":"refs/changes/67/794367/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher-dashboard refs/changes/67/794367/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher-dashboard refs/changes/67/794367/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher-dashboard refs/changes/67/794367/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher-dashboard refs/changes/67/794367/3"}}},"commit":{"parents":[{"commit":"427afe1f75665592c53b8597d46b9e25078627fa","subject":"Dropping lower constraints testing","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-dashboard/commit/427afe1f75665592c53b8597d46b9e25078627fa"}]}],"author":{"name":"limin.lc","email":"limin.lc@inspur.com","date":"2021-06-03 02:32:49.000000000","tz":480},"committer":{"name":"limin0801","email":"limin.lc@inspur.com","date":"2021-06-03 03:25:44.000000000","tz":480},"subject":"Fix create audit fail from audit_template","message":"Fix create audit fail from audit_template\n\nThe name is a positional parameter in create() of audit,\nbut this parameter is not defined when calling from the\naudit template. This patch fix it.\n\nRelated Bug: #1930565\nChange-Id: Id18945b881d150f972dbbd5522010be0157fba17\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-dashboard/commit/2ee3c6015c5347c75727f5afd2059e4060a1da1f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-dashboard/commit/2ee3c6015c5347c75727f5afd2059e4060a1da1f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}