)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"10d458583c23b5d3be19499d36f6454d79826043","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"25a98b18_79d42628","updated":"2025-09-10 11:35:22.000000000","message":"Below is the screenshot for before this fix: https://i.imgur.com/IaIyesx.png and after fix https://i.imgur.com/w8RPkPp.png","commit_id":"fc96050b416764a859cbb3216559f4e2c4b44ccd"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"db6981c86b7e6babb54d31b80606677c1d2bdc2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fc8a7c9c_d5c574c7","updated":"2025-09-17 15:20:35.000000000","message":"This is cool!. Tested locally.","commit_id":"27f8d9d47035fdc391094d1769d55779c602ecd4"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"dda9c66e9b29b2cc8167260d1a65022e097b22e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d8a3c61c_f63aaf60","updated":"2025-09-22 11:42:11.000000000","message":"Thanks for this improvements, lgtm","commit_id":"aba1f0773509498c5c18a34af15d74fc79fcf5a7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d3d094a85f38636c413c45f02e5d717c95267fc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fea40042_a6db57b7","updated":"2025-09-19 17:39:12.000000000","message":"as a short term solution this is ok but im not really happy with this general approach to problems like this.\n\ni woudl prefer ot either not suprpot this at all or use a lightweight lib like htmx to entirely remove the need for us to maintain JavaScript event handlers our selves. \n\nhttps://github.com/bigskysoftware/htmx/tree/v2.0.7\n\nthat willl be a lot more testable and less error prone in the long run","commit_id":"aba1f0773509498c5c18a34af15d74fc79fcf5a7"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9e4614cd5f50f6379a34356f4f2811820d8f0506","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"aa30a15b_b9f131de","in_reply_to":"fea40042_a6db57b7","updated":"2025-09-23 04:55:42.000000000","message":"Using htmx to remove javascript event handler sounds good. Let me add a topic in ptg to discuss about the same.","commit_id":"aba1f0773509498c5c18a34af15d74fc79fcf5a7"}],"watcher_dashboard/content/audit_templates/forms.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d3d094a85f38636c413c45f02e5d717c95267fc4","unresolved":true,"context_lines":[{"line_number":142,"context_line":"        choices \u003d ["},{"line_number":143,"context_line":"            ("},{"line_number":144,"context_line":"                strategy.uuid,"},{"line_number":145,"context_line":"                getattr(strategy, \u0027display_name\u0027, None) or"},{"line_number":146,"context_line":"                getattr(strategy, \u0027name\u0027, \u0027\u0027)"},{"line_number":147,"context_line":"            )"},{"line_number":148,"context_line":"            for strategy in strategies"}],"source_content_type":"text/x-python","patch_set":6,"id":"094a8e61_b80be703","line":145,"range":{"start_line":145,"start_character":16,"end_line":145,"end_character":23},"updated":"2025-09-19 17:39:12.000000000","message":"at sompoint i will start reating using this as a hard error and stop calling it out as a nit.\n\nwe should not use hasattr or getatter or setatter in new code we write unless there is no other way to do it.\n\nit is almost always incorrect to use getattr with a hard coded attribute name\n\nis shoudl be used only when the atibute is dynmaic and even then its still a code smell.\n\nwe shoudl plan ot have a singel patch or small series of patches to clean this up across teh code base.","commit_id":"27f8d9d47035fdc391094d1769d55779c602ecd4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d3d094a85f38636c413c45f02e5d717c95267fc4","unresolved":true,"context_lines":[{"line_number":142,"context_line":"        choices \u003d ["},{"line_number":143,"context_line":"            ("},{"line_number":144,"context_line":"                strategy.uuid,"},{"line_number":145,"context_line":"                getattr(strategy, \u0027display_name\u0027, None) or"},{"line_number":146,"context_line":"                getattr(strategy, \u0027name\u0027, \u0027\u0027)"},{"line_number":147,"context_line":"            )"},{"line_number":148,"context_line":"            for strategy in strategies"}],"source_content_type":"text/x-python","patch_set":7,"id":"ddb69ff4_4a0049b6","line":145,"updated":"2025-09-19 17:39:12.000000000","message":"...\n\nyou really shoudl stop using hasattr and getattr in new code you write.\n\nbut we can clean this up hoslisticly after this.","commit_id":"aba1f0773509498c5c18a34af15d74fc79fcf5a7"}],"watcher_dashboard/templates/infra_optim/audit_templates/_create.html":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d3d094a85f38636c413c45f02e5d717c95267fc4","unresolved":true,"context_lines":[{"line_number":112,"context_line":"      }"},{"line_number":113,"context_line":"    })();"},{"line_number":114,"context_line":"  \u003c/script\u003e"},{"line_number":115,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":6,"id":"e6f2d593_2ab8d361","line":115,"updated":"2025-09-19 17:39:12.000000000","message":"this is ok for now but longterm we shudl not keep adding one of Javascript blocks like this to the dashbaord.\n\nlets discuss this in the ptg or separately but i would like use ot remove all Javascript blocks like this and replace them with htmx in the future.\n\nwe espcially hsoudl not be manually wrign fallbacks for environment where jquary si not aviable\n\nfor oen it will alwasy be aviableable in horizon since it internally uses it but beyond that we do not whant ot have to keep implementing all functionality twice like this espcially without test coverage for it.","commit_id":"27f8d9d47035fdc391094d1769d55779c602ecd4"}]}