)]}'
{"watcher_dashboard/api/watcher.py":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"9004be4407332d6feef01fe7efa828478f404efd","unresolved":true,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def insert_watcher_policy_file():"},{"line_number":44,"context_line":"    policy_files \u003d watcher_settings.POLICY_FILES.copy()"},{"line_number":45,"context_line":"    policy_files[\u0027infra-optim\u0027] \u003d \u0027watcher_policy.json\u0027"},{"line_number":46,"context_line":"    settings.POLICY_FILES \u003d policy_files"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ccc7d258_88b523c8","line":44,"updated":"2025-10-10 11:31:31.000000000","message":"is there any why to configure the policy files? if this function is the only place it\u0027s modified we could simply hardcode it\n\n```suggestion\n    setttings.POLICY_FILES \u003d {\u0027infra-optim\u0027: \u0027watcher_policy\u0027}\n```","commit_id":"0f07a4d5fd546869eba3a5d184fd6f35ffb8fbad"}],"watcher_dashboard/settings.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f1fa8caca30c836be399ca8f73831b4bdf11c85e","unresolved":true,"context_lines":[{"line_number":14,"context_line":"Watcher Dashboard settings defaults."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This module provides default configuration values for the Watcher Dashboard"},{"line_number":17,"context_line":"following Django/Horizon patterns. Instead of using getattr() with hardcoded"},{"line_number":18,"context_line":"attribute names, these constants provide proper defaults."},{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Policy files configuration"}],"source_content_type":"text/x-python","patch_set":3,"id":"f28b0964_61755963","line":18,"range":{"start_line":17,"start_character":35,"end_line":18,"end_character":57},"updated":"2025-12-11 14:47:48.000000000","message":"Doesn\u0027t this hide all values configured in local_settings.py (or any files under local_settings.d) ? IIUC that\u0027s why it attempts to look up these options from django.conf.settings.","commit_id":"0f07a4d5fd546869eba3a5d184fd6f35ffb8fbad"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5bec83b55995f35ccb854647adcbcf9b97e317f5","unresolved":true,"context_lines":[{"line_number":14,"context_line":"Watcher Dashboard settings defaults."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This module provides default configuration values for the Watcher Dashboard"},{"line_number":17,"context_line":"following Django/Horizon patterns. Instead of using getattr() with hardcoded"},{"line_number":18,"context_line":"attribute names, these constants provide proper defaults."},{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Policy files configuration"}],"source_content_type":"text/x-python","patch_set":3,"id":"811258ec_9c2a5836","line":18,"range":{"start_line":17,"start_character":35,"end_line":18,"end_character":57},"in_reply_to":"f28b0964_61755963","updated":"2025-12-17 11:49:23.000000000","message":"This is not impelmtin gthe patter i proposed correctly\n\nso yes this version will but the pattern i proposed in the spec wont.\n\nThis is the detailed implemenmtaion plan for doing this properly.\n\nhttps://gist.github.com/SeanMooney/f56c7fd6f55ac48958a5c549e1701b6c#phase-3-centralized-configuration-module\n\ni orgianly intenede to pull mroe fo that into the spec itself\n\nhttps://specs.openstack.org/openstack/watcher-specs/specs/2026.1/approved/testing-and-codequality.html#proposed-change\n\nbut i linked  to this detail implementation plan in the spec.\n\norgianlly i had planned to work on thsi but cahndan started on it but obviously not with out the detailed context of why i propsoed it the way i did.\n\nits a slightly refined veriosn fo \n\nhttps://opendev.org/openstack/manila-ui/src/branch/master/manila_ui/features.py\n\nwith added type hinting and validation\n\ni.e. if its and enuma then w eshoudl assert that its in the allowed set ectra.","commit_id":"0f07a4d5fd546869eba3a5d184fd6f35ffb8fbad"}]}