)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"c94ce35e983959b7912f61e9f8305a6ca7c89c9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4a9b789b_584853fe","updated":"2025-10-13 10:31:42.000000000","message":"Here is the previous screenshot: https://i.imgur.com/fJyWYru.png and screenshot after the fix adding scrollbar to the right coulumn of create Audit form: https://i.imgur.com/vRBQzrf.png","commit_id":"ffccdafec28e883fec629593857ffed4ff37bcb4"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"c9f1aafccb8605c81b88d4b216e6f6601ef690bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6f2cfa19_e8e20781","updated":"2025-10-13 10:28:16.000000000","message":"Here is the previous screenshot: https://i.imgur.com/fJyWYru.png and screenshot after the fix adding scrollbar to the right coulumn of create Audit form: https://i.imgur.com/vRBQzrf.png","commit_id":"ffccdafec28e883fec629593857ffed4ff37bcb4"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"e082daed54677d342f85a08af1328d841ee1e432","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"48ad3730_dda78254","updated":"2025-10-14 10:44:48.000000000","message":"Here is the updated screenshot with text wrap and scrolling: https://i.imgur.com/R2ATF7C.png","commit_id":"aee8567c124081331ca547f9393565fed5490c31"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"679386cbd2c77c6a57072cff1ede43fadf0a268d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a5356356_a81bc4bd","updated":"2025-10-22 13:07:21.000000000","message":"Tested locally, thanks!","commit_id":"fc029b3242cc34e06df5420877c39931d6daafee"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"cf11f231229d4ca10b74b97fc09c98c0602d41c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b91df438_525f49cd","updated":"2025-11-05 19:18:13.000000000","message":"Thank you for proposing this.","commit_id":"fc029b3242cc34e06df5420877c39931d6daafee"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"cf11f231229d4ca10b74b97fc09c98c0602d41c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"030328c8_ecf46970","in_reply_to":"a5356356_a81bc4bd","updated":"2025-11-05 19:18:13.000000000","message":"TY for testing Alfredo!","commit_id":"fc029b3242cc34e06df5420877c39931d6daafee"}],"watcher_dashboard/templates/infra_optim/audits/_create.html":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"9a2797e7c971b9bcde4b574131c6fbe4a7d534a8","unresolved":true,"context_lines":[{"line_number":13,"context_line":"  \u003ch3\u003e{% trans \"Strategy Parameters (JSON):\" %}\u003c/h3\u003e"},{"line_number":14,"context_line":"  \u003cp\u003e{% trans \"Strategy parameters control how the optimization strategy behaves during audit execution.\" %}\u003c/p\u003e"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  \u003cdiv id\u003d\"strategy-info\" class\u003d\"watcher-strategy-info\" style\u003d\"display: none; margin: 10px 0; padding: 10px; background: #e8f4fd; border-left: 4px solid #0088cc; border-radius: 4px;\"\u003e"},{"line_number":17,"context_line":"    \u003ch4 id\u003d\"strategy-name\" style\u003d\"margin: 0 0 10px 0; color: #0088cc;\"\u003e\u003c/h4\u003e"},{"line_number":18,"context_line":"    \u003cdiv id\u003d\"parameters-list\"\u003e\u003c/div\u003e"},{"line_number":19,"context_line":"  \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"bc918623_8fb8b2a6","line":16,"range":{"start_line":16,"start_character":56,"end_line":16,"end_character":182},"updated":"2025-10-13 08:36:50.000000000","message":"given that we are using inline style here, I would keep consistent with it and would include new style parameters in this list.","commit_id":"3060d4e7905e46d72aeee1a363db6bff2eb40c8c"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"739a1cd4e454f5d722c9ff65aed347e908234b7d","unresolved":true,"context_lines":[{"line_number":13,"context_line":"  \u003ch3\u003e{% trans \"Strategy Parameters (JSON):\" %}\u003c/h3\u003e"},{"line_number":14,"context_line":"  \u003cp\u003e{% trans \"Strategy parameters control how the optimization strategy behaves during audit execution.\" %}\u003c/p\u003e"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  \u003cdiv id\u003d\"strategy-info\" class\u003d\"watcher-strategy-info\" style\u003d\"display: none; margin: 10px 0; padding: 10px; background: #e8f4fd; border-left: 4px solid #0088cc; border-radius: 4px;\"\u003e"},{"line_number":17,"context_line":"    \u003ch4 id\u003d\"strategy-name\" style\u003d\"margin: 0 0 10px 0; color: #0088cc;\"\u003e\u003c/h4\u003e"},{"line_number":18,"context_line":"    \u003cdiv id\u003d\"parameters-list\"\u003e\u003c/div\u003e"},{"line_number":19,"context_line":"  \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"8ae40387_09faedd2","line":16,"range":{"start_line":16,"start_character":56,"end_line":16,"end_character":182},"in_reply_to":"bc918623_8fb8b2a6","updated":"2025-10-13 10:30:07.000000000","message":"Yes , make sense!","commit_id":"3060d4e7905e46d72aeee1a363db6bff2eb40c8c"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"9a2797e7c971b9bcde4b574131c6fbe4a7d534a8","unresolved":true,"context_lines":[{"line_number":46,"context_line":"      var strategyName \u003d $(\u0027#strategy-name\u0027);"},{"line_number":47,"context_line":"      var parametersList \u003d $(\u0027#parameters-list\u0027);"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"      // Keep modal footer visible by capping body height via CSS."},{"line_number":50,"context_line":"      function constrainModalBody() {"},{"line_number":51,"context_line":"        var modal \u003d strategyInfo.closest(\u0027.modal\u0027);"},{"line_number":52,"context_line":"        if (!modal.length) { return; }"},{"line_number":53,"context_line":"        modal.find(\u0027.modal-body\u0027).css({\u0027max-height\u0027: \u002780vh\u0027, \u0027overflow-y\u0027: \u0027auto\u0027});"},{"line_number":54,"context_line":"      }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"      function loadStrategyParameters(auditTemplateUuid) {"},{"line_number":57,"context_line":"        if (!auditTemplateUuid) {"},{"line_number":58,"context_line":"          strategyInfo.hide();"}],"source_content_type":"text/html","patch_set":1,"id":"d940ca53_19b0c722","line":55,"range":{"start_line":49,"start_character":0,"end_line":55,"end_character":1},"updated":"2025-10-13 08:36:50.000000000","message":"To limit the body height, wouldn\u0027t be easier to simply add a `\u003cdiv style\u003d\"max-height: 80vh; overflow-y: auto;\"\u003e` as top level section in the block modal-body-right ? i think that\u0027s be easier and would provide the same functionality.","commit_id":"3060d4e7905e46d72aeee1a363db6bff2eb40c8c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2c557da5b9467a1156420571c4c5b56cc4d17c2c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"      var strategyName \u003d $(\u0027#strategy-name\u0027);"},{"line_number":47,"context_line":"      var parametersList \u003d $(\u0027#parameters-list\u0027);"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"      // Keep modal footer visible by capping body height via CSS."},{"line_number":50,"context_line":"      function constrainModalBody() {"},{"line_number":51,"context_line":"        var modal \u003d strategyInfo.closest(\u0027.modal\u0027);"},{"line_number":52,"context_line":"        if (!modal.length) { return; }"},{"line_number":53,"context_line":"        modal.find(\u0027.modal-body\u0027).css({\u0027max-height\u0027: \u002780vh\u0027, \u0027overflow-y\u0027: \u0027auto\u0027});"},{"line_number":54,"context_line":"      }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"      function loadStrategyParameters(auditTemplateUuid) {"},{"line_number":57,"context_line":"        if (!auditTemplateUuid) {"},{"line_number":58,"context_line":"          strategyInfo.hide();"}],"source_content_type":"text/html","patch_set":1,"id":"2883b3eb_421e6c01","line":55,"range":{"start_line":49,"start_character":0,"end_line":55,"end_character":1},"in_reply_to":"d940ca53_19b0c722","updated":"2025-10-14 11:11:18.000000000","message":"Done","commit_id":"3060d4e7905e46d72aeee1a363db6bff2eb40c8c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"da667bf961b02ae6b3f090e4e450883d5c6ef02a","unresolved":true,"context_lines":[{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block modal-body-right %}"},{"line_number":5,"context_line":"  \u003cdiv style\u003d\"max-height: 80vh; overflow-y: auto;\"\u003e"},{"line_number":6,"context_line":"  \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":7,"context_line":"  \u003cp\u003e{% trans \"Creates a audit with specified parameters.\" %}\u003c/p\u003e"},{"line_number":8,"context_line":"  \u003cp\u003e{% trans \"If you check \u0027Auto Trigger\u0027 option, the action plan, recommended by the audit, will be automatically started.\" %}\u003c/p\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"d881a98a_9dd1c566","line":5,"updated":"2025-10-13 16:04:00.000000000","message":"this is a solution but it woudl also be better to fix the over with of the model\n\ncurrenlty its harcoded to 768xp i think we really shoudl set the with of the model to 80%\n\nhttps://imgur.com/a/NFtJY7u\n\nthe reason the dialog is so long is because we are not actually using a reasonable amount of the aviable screen space.\n\nill also not athat you are not properly wrappign the text of the parmaters\n\nif we look at \nhttps://github.com/openstack/horizon/blob/4b81bd78fc22b846c82b18fc70bec5b49163f514/horizon/templates/horizon/client_side/_loading_modal.html#L8\n\nwe can see an example seting addtional classes.\n\n \u003cdiv class\u003d\"modal-dialog modal-xs\"\u003e\n \nmodal-xl woudl set the modal with to 95% of the window with\n \n https://github.com/openstack/horizon/blob/4b81bd78fc22b846c82b18fc70bec5b49163f514/openstack_dashboard/static/dashboard/scss/_bootstrap_helpers.scss#L18\n \nof couse we coudl also just  apply an inline style if we needed too but i think\n\n \u003cdiv class\u003d\"modal-dialog modal-xl\"\u003e\n\nwould improve things significantly","commit_id":"ffccdafec28e883fec629593857ffed4ff37bcb4"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"97cef9c2f862b73b2a2dbfbe614950e62b443d71","unresolved":true,"context_lines":[{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block modal-body-right %}"},{"line_number":5,"context_line":"  \u003cdiv style\u003d\"max-height: 80vh; overflow-y: auto;\"\u003e"},{"line_number":6,"context_line":"  \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":7,"context_line":"  \u003cp\u003e{% trans \"Creates a audit with specified parameters.\" %}\u003c/p\u003e"},{"line_number":8,"context_line":"  \u003cp\u003e{% trans \"If you check \u0027Auto Trigger\u0027 option, the action plan, recommended by the audit, will be automatically started.\" %}\u003c/p\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"e9be3886_92533924","line":5,"in_reply_to":"666f2598_2e4bac9b","updated":"2025-10-14 10:30:13.000000000","message":"Thank you @smooney@redhat.com for the valuable feedback and linking back to horizon codebase. It makes things clear.\n\nI\u0027ve applied your suggestions:\n- Added modal-xl class for 95% modal width\n- Used Horizon\u0027s word-wrap CSS class instead of inline styles","commit_id":"ffccdafec28e883fec629593857ffed4ff37bcb4"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"9a2633c62e58dd977264ce0b4c9128a83c8120db","unresolved":true,"context_lines":[{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block modal-body-right %}"},{"line_number":5,"context_line":"  \u003cdiv style\u003d\"max-height: 80vh; overflow-y: auto;\"\u003e"},{"line_number":6,"context_line":"  \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":7,"context_line":"  \u003cp\u003e{% trans \"Creates a audit with specified parameters.\" %}\u003c/p\u003e"},{"line_number":8,"context_line":"  \u003cp\u003e{% trans \"If you check \u0027Auto Trigger\u0027 option, the action plan, recommended by the audit, will be automatically started.\" %}\u003c/p\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"666f2598_2e4bac9b","line":5,"in_reply_to":"d881a98a_9dd1c566","updated":"2025-10-14 06:18:35.000000000","message":"I like the idea of increasing the width, good point. We will still want to limit the hight, but making it wider improves it.","commit_id":"ffccdafec28e883fec629593857ffed4ff37bcb4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"da667bf961b02ae6b3f090e4e450883d5c6ef02a","unresolved":true,"context_lines":[{"line_number":10,"context_line":"  \u003ch3\u003e{% trans \"Strategy Parameters (JSON):\" %}\u003c/h3\u003e"},{"line_number":11,"context_line":"  \u003cp\u003e{% trans \"Strategy parameters control how the optimization strategy behaves during audit execution.\" %}\u003c/p\u003e"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  \u003cdiv id\u003d\"strategy-info\" style\u003d\"display: none; margin: 10px 0; padding: 10px; background: #e8f4fd; border-left: 4px solid #0088cc; border-radius: 4px;\"\u003e"},{"line_number":14,"context_line":"    \u003ch4 id\u003d\"strategy-name\" style\u003d\"margin: 0 0 10px 0; color: #0088cc;\"\u003e\u003c/h4\u003e"},{"line_number":15,"context_line":"    \u003cdiv id\u003d\"parameters-list\"\u003e\u003c/div\u003e"},{"line_number":16,"context_line":"  \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"f715eede_243b0be3","line":13,"range":{"start_line":13,"start_character":25,"end_line":13,"end_character":151},"updated":"2025-10-13 16:04:00.000000000","message":"by the way i dont think we are really ment ot use a lot of inline styles in the plugins\n\nwith that sadi wehre we reneder the parmaer i think we shoudl be addeing the work-wrap class\n\nhttps://github.com/openstack/horizon/commit/b45de686a29b371853093da4e0e4b3b87f7ebe5a","commit_id":"ffccdafec28e883fec629593857ffed4ff37bcb4"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"97cef9c2f862b73b2a2dbfbe614950e62b443d71","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  \u003ch3\u003e{% trans \"Strategy Parameters (JSON):\" %}\u003c/h3\u003e"},{"line_number":11,"context_line":"  \u003cp\u003e{% trans \"Strategy parameters control how the optimization strategy behaves during audit execution.\" %}\u003c/p\u003e"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  \u003cdiv id\u003d\"strategy-info\" style\u003d\"display: none; margin: 10px 0; padding: 10px; background: #e8f4fd; border-left: 4px solid #0088cc; border-radius: 4px;\"\u003e"},{"line_number":14,"context_line":"    \u003ch4 id\u003d\"strategy-name\" style\u003d\"margin: 0 0 10px 0; color: #0088cc;\"\u003e\u003c/h4\u003e"},{"line_number":15,"context_line":"    \u003cdiv id\u003d\"parameters-list\"\u003e\u003c/div\u003e"},{"line_number":16,"context_line":"  \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"55967a23_7c8e7967","line":13,"range":{"start_line":13,"start_character":25,"end_line":13,"end_character":151},"in_reply_to":"f715eede_243b0be3","updated":"2025-10-14 10:30:13.000000000","message":"Done","commit_id":"ffccdafec28e883fec629593857ffed4ff37bcb4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2c557da5b9467a1156420571c4c5b56cc4d17c2c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{% extends \"horizon/common/_modal_form.html\" %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block modal-dialog-class %}modal-xl{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block modal-body-right %}"},{"line_number":7,"context_line":"  \u003cdiv style\u003d\"max-height: 80vh; overflow-y: auto;\"\u003e"}],"source_content_type":"text/html","patch_set":4,"id":"d47a0355_e1b8994e","line":4,"updated":"2025-10-14 11:11:18.000000000","message":"as far as i can tell this is not a valid extention point\n\nmodal_class is \n\nhttps://github.com/openstack/horizon/blob/master/horizon/templates/horizon/common/_modal.html#L4\n\nbut we need to set this class on \n\nhttps://github.com/openstack/horizon/blob/master/horizon/templates/horizon/common/_modal.html#L5\n\nas class\u003d\"modal-dialog modal-xl\"\n\nto make this change you are goign to have to write this tempelat to no use \n\n{% extends \"horizon/common/_modal_form.html\" %}\n\n\nand either swap to using client side tempelates here\n\nhttps://github.com/openstack/horizon/blob/master/horizon/templates/horizon/client_side/_modal.html\nand defiening it your self or keep with the sever side templateate which i think is bettrer but you will need to fully define you own modal\n\na better solution woudl be to modify horizon \n\nto add the ablity to set the modal class here https://github.com/openstack/horizon/blob/master/horizon/templates/horizon/common/_modal.html#L5\n\nvia a block so actrully make {% block extra_modal-dialog-class %}modal-xl{% endblock %} work like this\n\n```\n \u003cdiv class\u003d\"{% if hide %}modal-dialog {% block extra_modal_dialog_classes %}{% endblock %}{% endif %}\"\u003e\n```\nhere https://github.com/openstack/horizon/blob/master/horizon/templates/horizon/common/_modal.html#L5\n\ni think doing the horizon change is the cleanest way but failign that we can vendor the modal templated entirely here but you would also have to vendor the conten form \n\nhttps://github.com/openstack/horizon/blob/master/horizon/templates/horizon/common/_modal_form.html if you do that.","commit_id":"aee8567c124081331ca547f9393565fed5490c31"}]}