)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"81800e0fce66d890a36e7020a4b5de2ab26ef8a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bf2cfe5c_ce357533","updated":"2026-04-16 14:56:09.000000000","message":"looks good, but we agreed that it will be a new PS to rename api_tests to api","commit_id":"6971cd7afab1bdbaef4de5b272d6e5b0a194714b"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"e6bfb96d005cb3c902356e2afa86074048e65c58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3914f7c7_dd1dac30","updated":"2026-05-06 18:06:46.000000000","message":"lgtm thanks","commit_id":"9794f6af7c0a875ec5f8cd72054aa3a507ed7713"}],"watcher_dashboard/test/local_fixtures/fixtures.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a4a3dbca2ce01c6dcc4607d71764fcd9d7d83566","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fd833f95_acee776f","updated":"2026-02-28 13:42:53.000000000","message":"Can you just call this directory `fixtures`? We\u0027re in Python 3 now so we don\u0027t need to worry about the module name clashing, and it\u0027s already obvious that these are local (since they\u0027re in the `watcher_dashboard.test` module and not `watcher_dashboard`). This also aligns with what other projects like nova do.","commit_id":"c7a6145ff804db0d391fdd195b566c0c3d046d16"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f5001e56c5b5ec2bd46fd9ca791c6d59f9f2b164","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4a91d1ae_37774e9c","in_reply_to":"00fcc2ee_8780f878","updated":"2026-03-01 13:21:04.000000000","message":"https://review.opendev.org/c/openstack/nova/+/978346\n\n```\n      {\n          \"python.testing.unittestArgs\": [\n              \"-v\",\n              \"-s\", \"./nova/tests/.\",\n              \"-t\", \".\",\n              \"-p\", \"test_*.py\"\n          ],\n          \"python.envFile\": \"${workspaceFolder}/.vscode/.env\",\n          \"python.testing.pytestEnabled\": false,\n          \"python.testing.unittestEnabled\": true\n      }\n\n```\n\nworks but only when the fixutres module is renamed","commit_id":"c7a6145ff804db0d391fdd195b566c0c3d046d16"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f3be43bf309db38360f0cb11b6df3082ed8e9455","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"00fcc2ee_8780f878","in_reply_to":"eccbcd9c_31066354","updated":"2026-02-28 21:04:22.000000000","message":"```\nFailed to import test module: tests.unit.virt.test_virt_drivers\nTraceback (most recent call last):\n  File \"/home/smooney/.local/share/uv/python/cpython-3.12.12-linux-x86_64-gnu/lib/python3.12/unittest/loader.py\", line 396, in _find_test_path\n    module \u003d self._get_module_from_name(name)\n             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/home/smooney/.local/share/uv/python/cpython-3.12.12-linux-x86_64-gnu/lib/python3.12/unittest/loader.py\", line 339, in _get_module_from_name\n    __import__(name)\n  File \"/home/smooney/repos/nova/nova/tests/unit/virt/test_virt_drivers.py\", line 21, in \u003cmodule\u003e\n    import fixtures\n  File \"/home/smooney/repos/nova/.tox/functional/lib/python3.12/site-packages/fixtures/__init__.py\", line 66, in \u003cmodule\u003e\n    from fixtures.fixture import (  # noqa: E402\n  File \"/home/smooney/repos/nova/.tox/functional/lib/python3.12/site-packages/fixtures/fixture.py\", line 36, in \u003cmodule\u003e\n    from fixtures.callmany import (\n  File \"/home/smooney/repos/nova/.tox/functional/lib/python3.12/site-packages/fixtures/callmany.py\", line 29, in \u003cmodule\u003e\n    from testtools import MultipleExceptions\n  File \"/home/smooney/repos/nova/.tox/functional/lib/python3.12/site-packages/testtools/__init__.py\", line 53, in \u003cmodule\u003e\n    from testtools.testcase import (\n  File \"/home/smooney/repos/nova/.tox/functional/lib/python3.12/site-packages/testtools/testcase.py\", line 34, in \u003cmodule\u003e\n    from testtools.matchers import (\n  File \"/home/smooney/repos/nova/.tox/functional/lib/python3.12/site-packages/testtools/matchers/__init__.py\", line 96, in \u003cmodule\u003e\n    from ._doctest import (\n  File \"/home/smooney/repos/nova/.tox/functional/lib/python3.12/site-packages/testtools/matchers/_doctest.py\", line 7, in \u003cmodule\u003e\n    import doctest\n  File \"/home/smooney/.local/share/uv/python/cpython-3.12.12-linux-x86_64-gnu/lib/python3.12/doctest.py\", line 100, in \u003cmodule\u003e\n    import pdb\n  File \"/home/smooney/.local/share/uv/python/cpython-3.12.12-linux-x86_64-gnu/lib/python3.12/pdb.py\", line 215, in \u003cmodule\u003e\n    class Pdb(bdb.Bdb, cmd.Cmd):\n                       ^^^^^^^\nAttributeError: module \u0027cmd\u0027 has no attribute \u0027Cmd\u0027\n```\n\nfixtgure also conflict but apprently i cna fix it by changin the pytyhon path\n\n\n```\n{\n    \"python.testing.unittestArgs\": [\n        \"-v\",\n        \"-s\", \"./nova/tests\",\n        \"-t\", \".\",\n        \"-p\", \"test_*.py\"\n    ],\n    \"python.testing.pytestEnabled\": false,\n    \"python.testing.unittestEnabled\": true\n}\n```\n\n```\"-t\", \".\",```\n\nappreas to be the fix so if that works here as well ill revert this to just fixtgures\n\ni have foudn the config driven approch to be fragile in the past but if it avoid having to rename things that proably just better to document.","commit_id":"c7a6145ff804db0d391fdd195b566c0c3d046d16"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"532284c9fae88cbffa0e85b9e18dfbe1239b37ca","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eccbcd9c_31066354","in_reply_to":"fd833f95_acee776f","updated":"2026-02-28 20:13:10.000000000","message":"no that breaks things\n\nits internally not called that because fo the way test discovery worksin in many ids work where it add the local workspace/project first in the project path\n\ncalling it fixtures conflicts with the fixtures lib.\nit causes problems every time i try to use vscode and other ides to debug nova tests so after year of working around that im avoiding this since the name collsion is still very much a thing.\n\nit actully has got worse of late as its they pydev server that vscode ships that is causing the conflict with how it manilulates the pythonpath and more tools have started adopting there soltuion","commit_id":"c7a6145ff804db0d391fdd195b566c0c3d046d16"}],"watcher_dashboard/test/unit/api_tests/__init__.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a4a3dbca2ce01c6dcc4607d71764fcd9d7d83566","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cac2705c_fdfd82ad","updated":"2026-02-28 13:42:53.000000000","message":"While you\u0027re moving this, how about `s/api_tests/api/`? We can already infer these these are unit tests from the parent module patch. Renaming it will give you a shorter module path to boot.","commit_id":"c7a6145ff804db0d391fdd195b566c0c3d046d16"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"532284c9fae88cbffa0e85b9e18dfbe1239b37ca","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d11dfec9_63878322","in_reply_to":"cac2705c_fdfd82ad","updated":"2026-02-28 20:13:10.000000000","message":"sure","commit_id":"c7a6145ff804db0d391fdd195b566c0c3d046d16"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"63eb310a50e6add6ebef4a3bdd81d73e6b5cbb9c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8b3d04de_cb20936a","in_reply_to":"d11dfec9_63878322","updated":"2026-04-16 10:46:29.000000000","message":"Apparently this was forgotten in next PSs.","commit_id":"c7a6145ff804db0d391fdd195b566c0c3d046d16"}]}
