)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"eb2bfeb7337f3fc52355d2f17c71700be0d57f62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fd2e2611_c1e0dcf4","updated":"2026-04-16 14:55:36.000000000","message":"lgtm","commit_id":"fda67923d3bf463212c470060803ebeda521a094"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"b34a763e1daa2cacd1e3d43f5d50eb9eea19fde9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ab3a08a7_d67f3736","updated":"2026-04-28 09:16:09.000000000","message":"lgtm, thank you for cleaning it up.","commit_id":"fda67923d3bf463212c470060803ebeda521a094"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"0eb8f384915c9b473acfbf467f368109badf8701","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"427a54e3_c3f87dd4","updated":"2026-05-06 18:18:13.000000000","message":"-1: i think that we should fix run_tests.sh","commit_id":"cc795235172303fb03f89d00a1c0d8d4c0140e1c"}],"run_tests.sh":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"0eb8f384915c9b473acfbf467f368109badf8701","unresolved":true,"context_lines":[{"line_number":171,"context_line":"  fi"},{"line_number":172,"context_line":"}"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"function run_pep8 {"},{"line_number":175,"context_line":"  echo \"Running flake8 ...\""},{"line_number":176,"context_line":"  warn_on_flake8_without_venv"},{"line_number":177,"context_line":"  DJANGO_SETTINGS_MODULE\u003dwatcher_dashboard.test.settings ${command_wrapper} flake8"}],"source_content_type":"text/x-sh","patch_set":5,"id":"e70ea54d_36bcca88","line":174,"in_reply_to":"814d2227_219e85f7","updated":"2026-05-06 18:18:13.000000000","message":"\u003e run_tests.sh references watcher_dashboard.test.settings (singular) but the actual package directory is watcher_dashboard/tests (plural). This will cause ImportError and break all test execution via run_tests.sh.\n\u003e \n\u003e **Severity**: CRITICAL | **Confidence**: 1.0\n\u003e \n\u003e **Risk**: Every invocation of run_tests.sh that calls run_pep8, run_pep8_changed, run_sphinx, or run_tests_all will fail with ModuleNotFoundError: No module named \u0027watcher_dashboard.test\u0027.\n\u003e \n\u003e **Priority**: Before merge\n\u003e **Why This Matters**: The dependent change 978257 renamed test/ to tests/ (plural). This change (978304) then updated run_tests.sh from the correct watcher_dashboard.tests.settings to the incorrect watcher_dashboard.test.settings, creating a path mismatch that breaks the script entirely.\n\u003e \n\u003e **Recommendation**:\n\u003e Revert all four occurrences of watcher_dashboard.test.settings back to watcher_dashboard.tests.settings in run_tests.sh (lines 174, 190, 196, 353 in the current file). The directory is named tests/ (plural) and tox.ini correctly uses the plural form.\n\nPlease fix.\nIt is reverting previous changes made at\nhttps://review.opendev.org/c/openstack/watcher-dashboard/+/978257/6/run_tests.sh","commit_id":"cc795235172303fb03f89d00a1c0d8d4c0140e1c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"25d95223dbb7fa9d941c9117b6e139800d1d9ae2","unresolved":true,"context_lines":[{"line_number":171,"context_line":"  fi"},{"line_number":172,"context_line":"}"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"function run_pep8 {"},{"line_number":175,"context_line":"  echo \"Running flake8 ...\""},{"line_number":176,"context_line":"  warn_on_flake8_without_venv"},{"line_number":177,"context_line":"  DJANGO_SETTINGS_MODULE\u003dwatcher_dashboard.test.settings ${command_wrapper} flake8"}],"source_content_type":"text/x-sh","patch_set":5,"id":"393311f9_de70d6a0","line":174,"in_reply_to":"e70ea54d_36bcca88","updated":"2026-05-06 18:35:27.000000000","message":"ah yep so it is.\n\nas an aside it si entirly possobe for use to complete remove this file eventually and optional manage.py  and justuse tox/stestr eventualy\n\nhttps://review.opendev.org/c/openstack/grian-ui/+/950343\n\nwe realy dont needd this legacy tooling but its also not that imporant to remove it.","commit_id":"cc795235172303fb03f89d00a1c0d8d4c0140e1c"}]}
