)]}'
{"babel-django.cfg":[{"robot_id":"zuul","robot_run_id":"4a380c72cddb4dd585d09251dbd05e97","url":"https://zuul.teim.app/t/main/buildset/4a380c72cddb4dd585d09251dbd05e97","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"1a74b0245653b02ff3beeab6a4910dece726d2f3","patch_set":2,"id":"57be8c36_8f50944d","line":3,"updated":"2026-05-06 14:27:13.000000000","message":"The commit message body only contains a mailing list URL and provides no inline explanation of why the extractors are being re-added after commit 549bcc0 explicitly removed them.\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: Reviewers cannot determine from the commit alone whether the prior removal was incorrect or whether circumstances have changed. The mailing list thread may explain this, but the commit body should be self-contained per OpenStack conventions.\n\n**Suggestion**:\nAdd a paragraph to the commit body explaining why the extractors were removed in 549bcc0 and why they are now needed again. For example, note whether the entry-point-based registration approach was insufficient, or whether a Horizon change now requires explicit extractor declarations.","commit_id":"857ef83a79343f28be2f7f033a52f6b7a93c8a3f"},{"robot_id":"zuul","robot_run_id":"4a380c72cddb4dd585d09251dbd05e97","url":"https://zuul.teim.app/t/main/buildset/4a380c72cddb4dd585d09251dbd05e97","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"1a74b0245653b02ff3beeab6a4910dece726d2f3","patch_set":2,"id":"74a4d07b_4795eb01","line":3,"updated":"2026-05-06 14:27:13.000000000","message":"The extractor name in babel-django.cfg is \u0027django\u0027 but the mapping method line uses \u0027[django: ...]\u0027. Babel documentation states the extractor name in [extractors] must match the method name used in the mapping sections. This works here, but consider using a more explicit name to avoid confusion with Babel\u0027s built-in \u0027django\u0027 extractor.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Avoids potential ambiguity between Babel\u0027s built-in Django extractor and Horizon\u0027s custom extractor, making the configuration more self-documenting.\n\n**Recommendation**:\nThe current configuration is technically correct because Babel resolves extractor names from [extractors] before falling back to built-in names. No change is required, but if issues arise, verify that the custom extractor is being used by running: pybabel extract -F babel-django.cfg -o /dev/null .","commit_id":"857ef83a79343f28be2f7f033a52f6b7a93c8a3f"},{"robot_id":"zuul","robot_run_id":"4a380c72cddb4dd585d09251dbd05e97","url":"https://zuul.teim.app/t/main/buildset/4a380c72cddb4dd585d09251dbd05e97","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"1a74b0245653b02ff3beeab6a4910dece726d2f3","patch_set":2,"id":"ad54844a_97b45f89","line":4,"updated":"2026-05-06 14:27:13.000000000","message":"The previous extractor (removed in commit 549bcc0) used \u0027django_babel.extract:extract_django\u0027 while this commit uses \u0027horizon.utils.babel_extract_django:extract_django\u0027. The commit should clarify why the extractor source changed.\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: Provides traceability for the change in extractor implementation and helps future maintainers understand the dependency on Horizon\u0027s extractor.\n\n**Recommendation**:\nAdd a comment in the commit body noting that the extractors now reference Horizon\u0027s implementations rather than the previously used django_babel package, and explain why this switch is appropriate.","commit_id":"857ef83a79343f28be2f7f033a52f6b7a93c8a3f"}]}
