)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"b3f3612990fa7701992ad7330fa48d0f08096fc8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     815ed72b (Merge \"Add 2027.1 spec structure\")"},{"line_number":2,"context_line":"Author:     Douglas Viroel \u003cviroel@gmail.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2026-09-29 08:55:05 -0300"},{"line_number":4,"context_line":"Commit:     Douglas Viroel \u003cviroel@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"2ba59f58_8a76a93c","line":1,"updated":"2026-11-03 13:45:27.000000000","message":"The commit message of 3fd0f7a describes compute_nodes as gaining \u0027skip_pinned_instances and disable_source_nodes\u0027 and states that an instance whose pin conflicts with the destination \u0027is migrated with a new repin_availability_zone parameter ... by default\u0027. The spec defines the per-entry flag as repin_az_pinned_instances (no parameter named skip_pinned_instances appears anywhere in the document), its default is false, and the specified default behavior is the opposite: a pin-conflicting instance is skipped at Migrate execution time, not migrated. The permanent change history therefore misstates both the parameter name and the default semantics of the feature it introduces.\n\n**Severity**: WARNING | **Confidence**: 0.95\n\n**Impact**: The misdescription is permanent history: future readers of git log will look for a skip_pinned_instances parameter that does not exist and will believe pin-conflicting instances are migrated by default, when the spec skips them. Implementers and reviewers validating the message against the code would treat the wrong contract as the requirement.\n\n**Suggestion**:\nAmend the commit message to name repin_az_pinned_instances and state the actual default: with repin_az_pinned_instances false (the default) a pin-conflicting instance is skipped at Migrate execution time; setting it true migrates via the unpin/move/re-pin repin_availability_zone path.","commit_id":"3fd0f7ad46f55a87045a9cab93086b38765f8cdb"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"2e58dea1244a91ca75fb5e7e02450cc9058e34ef","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     55a31f08 (Update Audit Pipeline for 2027.1 cycle)"},{"line_number":2,"context_line":"Author:     Douglas Viroel \u003cviroel@gmail.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2026-09-29 08:55:05 -0300"},{"line_number":4,"context_line":"Commit:     Douglas Viroel \u003cviroel@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"c5b25710_7304679f","line":1,"updated":"2026-11-09 18:55:37.000000000","message":"The commit body states that compute_nodes \"gains two per-entry booleans: skip_pinned_instances and disable_source_nodes\". The spec under review consistently defines the parameter as skip_az_pinned_instances: in the Proposed Change overview, the Input Schema definition, the Pinned Instances section, the worked example, the Work Items list, and the Documentation Impact list. The name in the permanent change record therefore does not match the name the change actually specifies.\n\n**Severity**: WARNING | **Confidence**: 0.95\n\n**Impact**: Future readers searching history, Gerrit, or blueprint references for the documented parameter name skip_az_pinned_instances will not find this commit, and anyone implementing or scripting from the commit summary could use the wrong schema key in audit templates.\n\n**Suggestion**:\nAmend the commit message before merge so the parameter is named skip_az_pinned_instances, matching the spec text.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"08f84cdb1e81d7e7c6fc0c36b8291033d574235b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     55a31f08 (Update Audit Pipeline for 2027.1 cycle)"},{"line_number":2,"context_line":"Author:     Douglas Viroel \u003cviroel@gmail.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2026-09-29 08:55:05 -0300"},{"line_number":4,"context_line":"Commit:     Douglas Viroel \u003cviroel@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"c1f4f776_93fde10a","line":1,"updated":"2026-11-11 22:28:20.000000000","message":"The commit message names the three per-entry configurations as include_pinned_instances, disable_source_nodes and availability_zone_pinning_policy, but the spec defines them as include_az_pinned_instances and disable_source_services (only the third name matches). The message also states unconditionally that \"An instance whose pin conflicts with the destination is migrated\", while the spec\u0027s default include_az_pinned_instances: false excludes such instances from the action plan unless the operator opts in.\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: The merged history permanently records parameter names that do not exist in the design and a behavior claim opposite to the specified default. Future readers (and searches of reviewer tools) relying on the message will reference wrong option names or assume pin-conflicting instances are always migrated.\n\n**Suggestion**:\nAmend the commit message (or fold the correction into the next patchset\u0027s commit message) to use include_az_pinned_instances and disable_source_services, and qualify the pin statement with \"when include_az_pinned_instances is true\".","commit_id":"1c986b45723dbafe1fe8a34b518c97474ebf11ad"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"603821cec00cbf1b6cd3751637b3f1d7223369a7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     55a31f08 (Update Audit Pipeline for 2027.1 cycle)"},{"line_number":2,"context_line":"Author:     Douglas Viroel \u003cviroel@gmail.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2026-09-29 08:55:05 -0300"},{"line_number":4,"context_line":"Commit:     Douglas Viroel \u003cviroel@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"f5322679_4ac11804","line":1,"updated":"2026-11-12 13:18:32.000000000","message":"The commit message says compute_nodes gains \u0027include_pinned_instances, disable_source_nodes\u0027, but the spec defines the options as include_az_pinned_instances and disable_source_services (spec lines 195-212). It also states \u0027An instance whose pin conflicts with the destination is migrated\u0027, while the spec\u0027s default include_az_pinned_instances\u003dfalse excludes pin-conflicting instances from the action plan entirely (spec lines 400-403); they are migrated only when the option is explicitly enabled (lines 405-408).\n\n**Severity**: WARNING | **Confidence**: 0.95\n\n**Impact**: Future contributors searching history for the documented parameter names will find nothing, and the unconditional \u0027is migrated\u0027 claim misrepresents the deliberate safety default (conflicting pins are excluded) that operators must understand when choosing whether to enable the option.\n\n**Suggestion**:\nAmend the commit message to use the spec\u0027s names (include_az_pinned_instances, disable_source_services) and to state that pin-conflicting instances are excluded by default and become migrate candidates with policy-defined pin handling only when include_az_pinned_instances is true.","commit_id":"d4ba36336a48983470f8421f703b26844c91eed4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"282700bdb3b7a5286ece1974a914a8b42f5523fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f9b93c46_96c5e320","updated":"2026-10-01 17:50:39.000000000","message":"Thanks for all the feedbacks! i\u0027m working in a new version of the spec considering your concerns!","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"50826b3761aa2ed8a4a98984a766b23208818787","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"33a923f2_b811a3d3","updated":"2026-10-08 21:14:10.000000000","message":"Still reviewing but wanted to leave these comments for now.","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"e281f70de334c5b12585f268e90571d292c5c218","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7608f6d2_48bcd681","updated":"2026-10-09 21:04:37.000000000","message":"There\u0027s a lot of long threads in this spec. Some of them have been addressed by the second patch set so I propose we resolve those that have so make the overall review easier. I\u0027ve suggested reasons for resolution below (disclosure: I had some AI help). If you agree then please resolve. Thanks.","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"6058b51da35bcd803c0b27251146b14f6123de9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2472a538_b9dcf770","updated":"2026-10-29 16:26:39.000000000","message":"I\u0027m fine with the spec. I just left some questions or suggestions to be considered but none of them is a blocker or challenges any fundamental part of the spec","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9242e8924af520be65b667b63aa6e11b0c35cd32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"06a629de_1b0debcd","updated":"2026-10-29 19:20:05.000000000","message":"im have not compelted my review yet im just quickly goign to push a few of my comment and ill contin for anouther bit and pick it up tomorrow","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"34d0017c_068197b8","updated":"2026-11-03 13:27:47.000000000","message":"Thanks all for your reviews. Not sure if updating the spec is worst for those that are still reviewing it, but some important change in the repin logic is now proposed. PTAL. The spec is getting bigger as we add more details about specific changes, I appreciate the time that you all had reviewing it.","commit_id":"3fd0f7ad46f55a87045a9cab93086b38765f8cdb"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"ddb1685599f31b14862e66ef77277d7f68ebb8f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fc3d795a_5f30ae73","updated":"2026-11-10 14:31:58.000000000","message":"I think current version of the spec is fine, it\u0027s clear and contains all the required design information required to implement it.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4f9e9bdf_5267bada","updated":"2026-11-11 22:10:40.000000000","message":"Thanks for the reviews, please review the changes made from last ps when time permits.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"}],"specs/2027.1/approved/zone-migration-az-drain.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"77b0d7124ce6d8897ce66bd09ff7eadd3dbf7c69","unresolved":true,"context_lines":[{"line_number":14,"context_line":"every workload out of it — both instances and their volumes — before the zone"},{"line_number":15,"context_line":"can be taken down. Watcher\u0027s ``zone_migration`` strategy already drains"},{"line_number":16,"context_line":"operator-named compute nodes and storage pools, but it has no concept of an"},{"line_number":17,"context_line":"OpenStack availability zone: the operator must enumerate every source host and"},{"line_number":18,"context_line":"every source pool by hand, and nothing keeps the workload inside the intended"},{"line_number":19,"context_line":"destination zone. This spec adds an AZ-to-AZ mode to ``zone_migration``."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"11fc6bec_1bc8ccd7","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":27},"updated":"2026-09-30 22:57:10.000000000","message":"There is not really a single OpenStack-wide concept of an availability\nzone.\n\nNova, Cinder, and Neutron each expose independently defined AZs with\ndifferent semantics and APIs. We therefore cannot assume that an AZ\nname identifies the same location or failure domain across services.\n\nIn Nova, an AZ is effectively a named host aggregate used as a\nscheduling domain. A compute host may belong to multiple host\naggregates, but only one Nova AZ. Importantly, a Nova AZ is not\ninherently a fault domain or physical location; an operator is free to\nuse AZs to model whatever grouping is useful for scheduling.\n\nCinder has a separate AZ concept associated with storage backends. A\nvolume has its own Cinder AZ independently of the Nova AZ of the server\nto which it is attached.\n\nNeutron has another AZ concept used for placement of networking\nservices such as L3 routing and DHCP. Nova passes the selected compute\nhost via `binding:host_id`, while Nova-owned ports use the `compute:`\n`device_owner` namespace (normally `compute:nova`). Neither establishes\nan equivalence between the Nova and Neutron AZ namespaces.\n\nAn operator could therefore legitimately have a workload using:\n\n    Nova AZ:       amd-compute\n    Cinder AZ:     nvme-storage\n    Neutron AZ:    comcast-edge\n\nAlternatively, an operator may choose to use a common name such as\n`us-east-dc1` across all three services. That alignment is an operator\nconvention, not an OpenStack invariant.\n\nThis is also quite different from the AWS meaning of \"availability\nzone\". An AWS AZ is explicitly an isolated physical infrastructure\nlocation and fault-isolation boundary within a region. OpenStack AZs do\nnot have that guarantee.\n\nOperationally, an AWS AZ is therefore often closer to an independently\ndeployed OpenStack cloud or Keystone region than to a Nova, Cinder, or\nNeutron AZ, although the concepts are not API-equivalent.\n\nThis matters for Watcher because AZ awareness needs to be modeled\nseparately for each service. In particular, we cannot assume that:\n\n    compute_az \u003d\u003d storage_az \u003d\u003d network_az\n\nor that all volumes attached to an instance are in the same Cinder AZ.\n\nFor example, if an instance has:\n\n    volume-a -\u003e storage_az_1\n    volume-b -\u003e storage_az_2\n\nthen draining `storage_az_1` should allow Watcher to migrate only\n`volume-a` to a backend in, for example, `storage_az_3`, without moving\nthe instance or `volume-b`.\n\nLikewise, draining a Nova AZ should not implicitly mean draining a\nCinder or Neutron AZ with the same name.\n\nSo I think the spec should avoid referring to \"an OpenStack\navailability zone\" as though it were one cross-service object. It\nwould be clearer to talk explicitly about Nova/compute AZs,\nCinder/storage AZs, and, where relevant, Neutron/network AZs.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"282700bdb3b7a5286ece1974a914a8b42f5523fd","unresolved":true,"context_lines":[{"line_number":14,"context_line":"every workload out of it — both instances and their volumes — before the zone"},{"line_number":15,"context_line":"can be taken down. Watcher\u0027s ``zone_migration`` strategy already drains"},{"line_number":16,"context_line":"operator-named compute nodes and storage pools, but it has no concept of an"},{"line_number":17,"context_line":"OpenStack availability zone: the operator must enumerate every source host and"},{"line_number":18,"context_line":"every source pool by hand, and nothing keeps the workload inside the intended"},{"line_number":19,"context_line":"destination zone. This spec adds an AZ-to-AZ mode to ``zone_migration``."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"95f97bb7_4341a9da","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":27},"in_reply_to":"11fc6bec_1bc8ccd7","updated":"2026-10-01 17:50:39.000000000","message":"Ack, it needs to be clear about that point (differences between AZs  from services pov and that there is no unique OpenStack AZ). I would say that next PS will move towards nova/compute AZs while storage continue to be pool/type oriented (looks more aligned with current implementation and usage).","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"7619739401ee2a979f8b9a5523717591bd9bb2cf","unresolved":true,"context_lines":[{"line_number":14,"context_line":"every workload out of it — both instances and their volumes — before the zone"},{"line_number":15,"context_line":"can be taken down. Watcher\u0027s ``zone_migration`` strategy already drains"},{"line_number":16,"context_line":"operator-named compute nodes and storage pools, but it has no concept of an"},{"line_number":17,"context_line":"OpenStack availability zone: the operator must enumerate every source host and"},{"line_number":18,"context_line":"every source pool by hand, and nothing keeps the workload inside the intended"},{"line_number":19,"context_line":"destination zone. This spec adds an AZ-to-AZ mode to ``zone_migration``."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"6faedcf2_b4049cb8","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":27},"in_reply_to":"4b110775_99a60c48","updated":"2026-10-08 22:36:12.000000000","message":"I said `Move all cinder volumes in AZ1 to AZ2` and wanted say it would have that effect but be done by volume migration (or retype -- if you had a type for each AZ) which Watcher can do already. I\u0027m assuming someone would combine something like what is below with the new AZ migration described in this spec.\n\n```\nopenstack optimize audit create -a at1 \\\n  -p storage_pools\u003d\u0027[{\"src_pool\": \"hostA@ceph#ceph\", \"dst_pool\": \"hostB@ceph2#ceph2\"]\u0027\n```\n\nHere\u0027s some background on mapping the pools to the AZs. For example I can do this:\n```\n  openstack volume migrate \\\n    --host cinder-83701-volume-ceph-az1-0@ceph-az1#ceph-az1 \\\n    01b2f026-96ba-4a75-95e4-8114d3bb5a19\n```\nWhere the --host option is one of my pools:\n```\nsh-5.2$ openstack volume backend pool list\n+--------------------------------------------------+\n| Name                                             |\n+--------------------------------------------------+\n| cinder-83701-volume-ceph-az1-0@ceph-az1#ceph-az1 |\n| cinder-83701-volume-ceph-az2-0@ceph-az2#ceph-az2 |\n| cinder-83701-volume-ceph-az0-0@ceph-az0#ceph-az0 |\n+--------------------------------------------------+\nsh-5.2$\n```\nand the pools map to a separate cinder-volume service with its own ceph backend in each AZ:\n```\nsh-5.2$  openstack volume service list | grep cinder-volume\n| cinder-volume    | cinder-83701-volume-ceph-az1-0@ceph-az1 | az1  | enabled | up    | 2026-10-08T22:09:52.000000 | None    | None          |\n| cinder-volume    | cinder-83701-volume-ceph-az2-0@ceph-az2 | az2  | enabled | up    | 2026-10-08T22:09:50.000000 | None    | None          |\n| cinder-volume    | cinder-83701-volume-ceph-az0-0@ceph-az0 | az0  | enabled | up    | 2026-10-08T22:09:52.000000 | None    | None          |\nsh-5.2$ \n```\nSo the volume is moved between AZs but isn\u0027t exactly using AZ language.\n\nNot everyone follows this convention, but if someone does then the feature described here would be useful.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"e281f70de334c5b12585f268e90571d292c5c218","unresolved":true,"context_lines":[{"line_number":14,"context_line":"every workload out of it — both instances and their volumes — before the zone"},{"line_number":15,"context_line":"can be taken down. Watcher\u0027s ``zone_migration`` strategy already drains"},{"line_number":16,"context_line":"operator-named compute nodes and storage pools, but it has no concept of an"},{"line_number":17,"context_line":"OpenStack availability zone: the operator must enumerate every source host and"},{"line_number":18,"context_line":"every source pool by hand, and nothing keeps the workload inside the intended"},{"line_number":19,"context_line":"destination zone. This spec adds an AZ-to-AZ mode to ``zone_migration``."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"763ae062_e4b2ccba","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":27},"in_reply_to":"6faedcf2_b4049cb8","updated":"2026-10-09 21:04:37.000000000","message":"I think what Sean asked for here is now addressed in patch set 2.\n\nThe spec now says there is no single OpenStack-wide AZ, explains that Nova, Cinder, and Neutron define separate AZ namespaces, and treats any naming alignment as an operator convention (lines 36–49). Douglas framed the feature as a Nova/compute AZ drain.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"every workload out of it — both instances and their volumes — before the zone"},{"line_number":15,"context_line":"can be taken down. Watcher\u0027s ``zone_migration`` strategy already drains"},{"line_number":16,"context_line":"operator-named compute nodes and storage pools, but it has no concept of an"},{"line_number":17,"context_line":"OpenStack availability zone: the operator must enumerate every source host and"},{"line_number":18,"context_line":"every source pool by hand, and nothing keeps the workload inside the intended"},{"line_number":19,"context_line":"destination zone. This spec adds an AZ-to-AZ mode to ``zone_migration``."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"4b1a3a45_0f7bba9f","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":27},"in_reply_to":"763ae062_e4b2ccba","updated":"2026-10-19 21:37:29.000000000","message":"We can close this thread since new PS focus on Compute AZ. Please open it again if needed.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"50826b3761aa2ed8a4a98984a766b23208818787","unresolved":true,"context_lines":[{"line_number":14,"context_line":"every workload out of it — both instances and their volumes — before the zone"},{"line_number":15,"context_line":"can be taken down. Watcher\u0027s ``zone_migration`` strategy already drains"},{"line_number":16,"context_line":"operator-named compute nodes and storage pools, but it has no concept of an"},{"line_number":17,"context_line":"OpenStack availability zone: the operator must enumerate every source host and"},{"line_number":18,"context_line":"every source pool by hand, and nothing keeps the workload inside the intended"},{"line_number":19,"context_line":"destination zone. This spec adds an AZ-to-AZ mode to ``zone_migration``."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"4b110775_99a60c48","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":27},"in_reply_to":"95f97bb7_4341a9da","updated":"2026-10-08 21:14:10.000000000","message":"I agree with Sean that \"AZ awareness needs to be modeled separately for each service\"\nI also want this spec to result in the ability to affect all services which use the same AZ name.\nI think we can have both if we are able to tell watcher something like:\n\n- Move all nova servers in AZ1 to AZ2\n- Move all cinder volumes in AZ1 to AZ2\n\nThe user would need express both of the above, and we cannot assume the first statement implies the second.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"77b0d7124ce6d8897ce66bd09ff7eadd3dbf7c69","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"No AZ awareness anywhere"},{"line_number":36,"context_line":"------------------------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* The compute cluster data model has no ``availability_zone`` on"},{"line_number":39,"context_line":"  ``ComputeNode``. Nova\u0027s host-to-zone data is already fetched during model"},{"line_number":40,"context_line":"  build via ``nova_helper.get_service_list()`` (``Service.zone``) and then"},{"line_number":41,"context_line":"  discarded — the zone is used to select hostnames for AZ-scoped audits and"},{"line_number":42,"context_line":"  never stored."},{"line_number":43,"context_line":"* The storage model is better off: ``StorageNode`` already carries ``zone``,"},{"line_number":44,"context_line":"  populated from ``StorageService.availability_zone``. But ``Volume`` has no"},{"line_number":45,"context_line":"  AZ field, and nothing correlates a Cinder AZ with a Nova AZ."}],"source_content_type":"text/x-rst","patch_set":1,"id":"a372b0a6_9faf36cb","line":42,"range":{"start_line":37,"start_character":0,"end_line":42,"end_character":15},"updated":"2026-09-30 22:57:10.000000000","message":"This is also where we start running into problems with drivers such as\nIronic, and potentially VMware.\n\nWith the Ironic virt driver there is a 1:N relationship between a\n`nova-compute` service and the `ComputeNode` records it manages. In\nfact, Ironic is currently the only Nova driver where one compute\nservice can represent multiple compute nodes.\n\nHistorically those Ironic nodes could also move between compute\nservices. More generally, Nova AZs are defined in terms of hosts/host\naggregates, while Ironic\u0027s own resource partitioning is based on\nconcepts such as conductor groups and shards. Nova\u0027s AZ model therefore\ndoes not map particularly cleanly onto individual Ironic bare metal\nnodes.\n\nWe should probably call this out explicitly. Either AZ migration is\nunsupported for compute nodes whose `hypervisor_type` is not one of the\ndrivers we know can support the required move operation, or we need to\ndefine what the expected behaviour is for those drivers.\n\nIronic is particularly interesting here because an Ironic-backed server\ncannot be live migrated, but it can have Cinder-backed storage. So even\nif the compute part of an AZ evacuation is unsupported, the storage\nportion may still be actionable independently.\n\nThere is a second issue on the Nova side: the AZ of the compute host is\nonly half of the information we need.\n\nNova exposes both:\n```\n    availability_zone\n        -\u003e the AZ of the host where the instance currently resides\n\n    pinned_availability_zone\n        -\u003e the AZ constraint applied to the instance\n```\nThese are deliberately separate. Since microversion 2.96 Nova exposes\n`pinned_availability_zone`, and from microversion 2.104 the pin can also\nbe explicitly changed or removed.\n\nAn instance can therefore currently reside on a compute host in an AZ\nwithout necessarily being pinned to that AZ. Conversely, an instance\ncan be pinned because:\n\n* it was created with an explicit AZ;\n* `default_schedule_zone` applied;\n* it was unshelved into a specified AZ; or\n* Nova pinned it to a volume AZ when `cinder.cross_az_attach\u003dFalse`.\n\n\nSo checking only the compute node/service AZ is not sufficient when\nbuilding an AZ migration action plan. We also need to inspect\n`pinned_availability_zone` for each instance.\n\nFor example, if Watcher is draining `az1` and wants to move an instance\nto `az2`:\n```\n    host AZ                  \u003d az1\n    pinned_availability_zone \u003d null\n```\nthen moving it to `az2` is compatible with the instance\u0027s current\nplacement policy.\n\nHowever:\n```\n    host AZ                  \u003d az1\n    pinned_availability_zone \u003d az1\n```\nmeans that moving it to `az2` would require overriding an explicit or\nimplicit placement constraint.\n\nI think we need to define that behaviour in the spec.\n\nThe two obvious choices are:\n\n1. Exclude pinned instances from the action plan when the destination\n   AZ differs from `pinned_availability_zone`.\n\n2. Explicitly unpin the instance as part of the action plan and then\n   move it, changing the placement policy originally requested for that\n   workload.\n\nMy initial preference would be (1). It is the safer default because\nWatcher should not silently override an end user\u0027s AZ constraint, which\nmay encode HA, locality, compliance, or some other placement\nrequirement.\n\nIf we want to support (2), I think it should be an explicit,\nconfigurable policy rather than an implicit side effect of AZ\nmigration.\n\nThis also means that retaining only `Service.zone` during model\nconstruction is insufficient. We need both the placement AZ of the\ncompute resource and the instance-level `pinned_availability_zone`\nconstraint in the model used by the strategy.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"No AZ awareness anywhere"},{"line_number":36,"context_line":"------------------------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* The compute cluster data model has no ``availability_zone`` on"},{"line_number":39,"context_line":"  ``ComputeNode``. Nova\u0027s host-to-zone data is already fetched during model"},{"line_number":40,"context_line":"  build via ``nova_helper.get_service_list()`` (``Service.zone``) and then"},{"line_number":41,"context_line":"  discarded — the zone is used to select hostnames for AZ-scoped audits and"},{"line_number":42,"context_line":"  never stored."},{"line_number":43,"context_line":"* The storage model is better off: ``StorageNode`` already carries ``zone``,"},{"line_number":44,"context_line":"  populated from ``StorageService.availability_zone``. But ``Volume`` has no"},{"line_number":45,"context_line":"  AZ field, and nothing correlates a Cinder AZ with a Nova AZ."}],"source_content_type":"text/x-rst","patch_set":1,"id":"8af316c3_0bc6e148","line":42,"range":{"start_line":37,"start_character":0,"end_line":42,"end_character":15},"in_reply_to":"0094a3f2_c6b4f199","updated":"2026-10-19 21:37:29.000000000","message":"Closing this thread: We already call out that issue with Ironic drivers but would be fixed in a more generic filtering other than in zone_migration. Please open it again if needed.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"e281f70de334c5b12585f268e90571d292c5c218","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"No AZ awareness anywhere"},{"line_number":36,"context_line":"------------------------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* The compute cluster data model has no ``availability_zone`` on"},{"line_number":39,"context_line":"  ``ComputeNode``. Nova\u0027s host-to-zone data is already fetched during model"},{"line_number":40,"context_line":"  build via ``nova_helper.get_service_list()`` (``Service.zone``) and then"},{"line_number":41,"context_line":"  discarded — the zone is used to select hostnames for AZ-scoped audits and"},{"line_number":42,"context_line":"  never stored."},{"line_number":43,"context_line":"* The storage model is better off: ``StorageNode`` already carries ``zone``,"},{"line_number":44,"context_line":"  populated from ``StorageService.availability_zone``. But ``Volume`` has no"},{"line_number":45,"context_line":"  AZ field, and nothing correlates a Cinder AZ with a Nova AZ."}],"source_content_type":"text/x-rst","patch_set":1,"id":"0094a3f2_c6b4f199","line":42,"range":{"start_line":37,"start_character":0,"end_line":42,"end_character":15},"in_reply_to":"22d980cc_35e9cd93","updated":"2026-10-09 21:04:37.000000000","message":"Patchset 2 now calls out Ironic\u0027s one-to-many relationship between a\nnova-compute service and ComputeNode records, and says to exclude bare metal\nnodes because their AZ migration behavior is not defined here (lines 213–219\nand 512–513). It also models the instance\u0027s pinned AZ separately from the\ncompute host AZ, defines the default skip behavior and the explicit unpin/move/\nrepin behavior, and notes the required Nova microversion floors (lines 324–361\nand 504–507).\n\nMaybe this comment can be resolved?","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"282700bdb3b7a5286ece1974a914a8b42f5523fd","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"No AZ awareness anywhere"},{"line_number":36,"context_line":"------------------------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* The compute cluster data model has no ``availability_zone`` on"},{"line_number":39,"context_line":"  ``ComputeNode``. Nova\u0027s host-to-zone data is already fetched during model"},{"line_number":40,"context_line":"  build via ``nova_helper.get_service_list()`` (``Service.zone``) and then"},{"line_number":41,"context_line":"  discarded — the zone is used to select hostnames for AZ-scoped audits and"},{"line_number":42,"context_line":"  never stored."},{"line_number":43,"context_line":"* The storage model is better off: ``StorageNode`` already carries ``zone``,"},{"line_number":44,"context_line":"  populated from ``StorageService.availability_zone``. But ``Volume`` has no"},{"line_number":45,"context_line":"  AZ field, and nothing correlates a Cinder AZ with a Nova AZ."}],"source_content_type":"text/x-rst","patch_set":1,"id":"c5dc8ecb_66680218","line":42,"range":{"start_line":37,"start_character":0,"end_line":42,"end_character":15},"in_reply_to":"a372b0a6_9faf36cb","updated":"2026-10-01 17:50:39.000000000","message":"ACK, so the hypervisor_type part using ironic, we may want to discuss more, may at PTG.\nWRT pinned_availability_zone, the model already supports it (extended attributes).\nSo we can go with 1 or 2. The spec mentions bellow the approch 2 already, but i would say that can be a different spec and an isolated functionallity added in this cycle or in the following one. I agree that this should require a configuration so users would be able to choose between migrating them or not.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"50826b3761aa2ed8a4a98984a766b23208818787","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"No AZ awareness anywhere"},{"line_number":36,"context_line":"------------------------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* The compute cluster data model has no ``availability_zone`` on"},{"line_number":39,"context_line":"  ``ComputeNode``. Nova\u0027s host-to-zone data is already fetched during model"},{"line_number":40,"context_line":"  build via ``nova_helper.get_service_list()`` (``Service.zone``) and then"},{"line_number":41,"context_line":"  discarded — the zone is used to select hostnames for AZ-scoped audits and"},{"line_number":42,"context_line":"  never stored."},{"line_number":43,"context_line":"* The storage model is better off: ``StorageNode`` already carries ``zone``,"},{"line_number":44,"context_line":"  populated from ``StorageService.availability_zone``. But ``Volume`` has no"},{"line_number":45,"context_line":"  AZ field, and nothing correlates a Cinder AZ with a Nova AZ."}],"source_content_type":"text/x-rst","patch_set":1,"id":"db4763f3_e1e63017","line":42,"range":{"start_line":37,"start_character":0,"end_line":42,"end_character":15},"in_reply_to":"c5dc8ecb_66680218","updated":"2026-10-08 21:14:10.000000000","message":"If a user scheduled a Nova instance in AZ1, its `pinned_availability_zone\u003dAZ1`. \n\nIt should still be possible to have Watcher move it to AZ2. Thus, Watcher should be able to unpin AZ1 as part of the proposed workflow.\n\nIf we don\u0027t want that to be the default behavior that\u0027s fine but there should be an option to let the person configuring Watcher do that. Without that ability the proposed change won\u0027t be as useful as the cloud admin would need to do unpinning outside of watcher.\n\nThe scenario is one where cloud users schedule workloads in AZ1 because that\u0027s a currently active zone but they have an understanding that the cloud admin may migrate their instance to another AZ if AZ1 needs to be taken offline for maintenance.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"82de505c9a36eadc8d771ce197bb711c810a8b85","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"No AZ awareness anywhere"},{"line_number":36,"context_line":"------------------------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* The compute cluster data model has no ``availability_zone`` on"},{"line_number":39,"context_line":"  ``ComputeNode``. Nova\u0027s host-to-zone data is already fetched during model"},{"line_number":40,"context_line":"  build via ``nova_helper.get_service_list()`` (``Service.zone``) and then"},{"line_number":41,"context_line":"  discarded — the zone is used to select hostnames for AZ-scoped audits and"},{"line_number":42,"context_line":"  never stored."},{"line_number":43,"context_line":"* The storage model is better off: ``StorageNode`` already carries ``zone``,"},{"line_number":44,"context_line":"  populated from ``StorageService.availability_zone``. But ``Volume`` has no"},{"line_number":45,"context_line":"  AZ field, and nothing correlates a Cinder AZ with a Nova AZ."}],"source_content_type":"text/x-rst","patch_set":1,"id":"22d980cc_35e9cd93","line":42,"range":{"start_line":37,"start_character":0,"end_line":42,"end_character":15},"in_reply_to":"db4763f3_e1e63017","updated":"2026-10-09 00:15:44.000000000","message":"WRT drivers, maybe we should just scope this spec to libvirt.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"77b0d7124ce6d8897ce66bd09ff7eadd3dbf7c69","unresolved":true,"context_lines":[{"line_number":42,"context_line":"  never stored."},{"line_number":43,"context_line":"* The storage model is better off: ``StorageNode`` already carries ``zone``,"},{"line_number":44,"context_line":"  populated from ``StorageService.availability_zone``. But ``Volume`` has no"},{"line_number":45,"context_line":"  AZ field, and nothing correlates a Cinder AZ with a Nova AZ."},{"line_number":46,"context_line":"* Consequently an operator cannot say \"drain az-a into az-b\". They must"},{"line_number":47,"context_line":"  enumerate hosts, and there is no validation that the hosts they name are"},{"line_number":48,"context_line":"  actually in the zones they think."}],"source_content_type":"text/x-rst","patch_set":1,"id":"f4dd03d8_a13da86f","line":45,"range":{"start_line":45,"start_character":16,"end_line":45,"end_character":62},"updated":"2026-09-30 22:57:10.000000000","message":"right because the are not corralated\n\nthe may share the saem name but even then that is not a guarentee that that storage systrem is usabel by hosts in that nova az.\n\nits likely but they are not genrally the saem.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"adeb8dbebe14aa2cd3f2d44e1ad37d5491561eeb","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  never stored."},{"line_number":43,"context_line":"* The storage model is better off: ``StorageNode`` already carries ``zone``,"},{"line_number":44,"context_line":"  populated from ``StorageService.availability_zone``. But ``Volume`` has no"},{"line_number":45,"context_line":"  AZ field, and nothing correlates a Cinder AZ with a Nova AZ."},{"line_number":46,"context_line":"* Consequently an operator cannot say \"drain az-a into az-b\". They must"},{"line_number":47,"context_line":"  enumerate hosts, and there is no validation that the hosts they name are"},{"line_number":48,"context_line":"  actually in the zones they think."}],"source_content_type":"text/x-rst","patch_set":1,"id":"b638cd91_6edd30f9","line":45,"range":{"start_line":45,"start_character":16,"end_line":45,"end_character":62},"in_reply_to":"f4dd03d8_a13da86f","updated":"2026-10-02 17:57:50.000000000","message":"Acknowledged","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"086f6c27b0f6c775700f27587c73e7d9bcdbf3ee","unresolved":true,"context_lines":[{"line_number":55,"context_line":"  zone, with the source compute services disabled so the scheduler does not"},{"line_number":56,"context_line":"  refill them mid-drain."},{"line_number":57,"context_line":"* **Deployer** migrates only the block storage of a zone — retyping volumes"},{"line_number":58,"context_line":"  onto backends in the destination zone — while leaving compute in place, or"},{"line_number":59,"context_line":"  the reverse."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Proposed Change"},{"line_number":62,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"f92099c6_af362b15","line":60,"range":{"start_line":58,"start_character":75,"end_line":60,"end_character":1},"updated":"2026-09-29 15:52:23.000000000","message":"To avoid any missunderstanding, \"or the reverse\" in this context means \"migrating only the instances while leaving volumes in the original availability zone\", right?","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"e281f70de334c5b12585f268e90571d292c5c218","unresolved":true,"context_lines":[{"line_number":55,"context_line":"  zone, with the source compute services disabled so the scheduler does not"},{"line_number":56,"context_line":"  refill them mid-drain."},{"line_number":57,"context_line":"* **Deployer** migrates only the block storage of a zone — retyping volumes"},{"line_number":58,"context_line":"  onto backends in the destination zone — while leaving compute in place, or"},{"line_number":59,"context_line":"  the reverse."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Proposed Change"},{"line_number":62,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"e7f48087_76c9bc71","line":60,"range":{"start_line":58,"start_character":75,"end_line":60,"end_character":1},"in_reply_to":"060fd35e_ac7b1607","updated":"2026-10-09 21:04:37.000000000","message":"Patchset 2 now distinguishes moving a volume to a pool while retaining\nits type from changing its type with a retype (lines 169–180). The volume flow\nmaps those to Cinder\u0027s migrate and retype operations and explains that\nmigration takes a host while retype takes a type (lines 246–261). This keeps\nbackend movement and type changes as separate choices. \n\nMaybe this comment can be resolved?","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"adeb8dbebe14aa2cd3f2d44e1ad37d5491561eeb","unresolved":true,"context_lines":[{"line_number":55,"context_line":"  zone, with the source compute services disabled so the scheduler does not"},{"line_number":56,"context_line":"  refill them mid-drain."},{"line_number":57,"context_line":"* **Deployer** migrates only the block storage of a zone — retyping volumes"},{"line_number":58,"context_line":"  onto backends in the destination zone — while leaving compute in place, or"},{"line_number":59,"context_line":"  the reverse."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Proposed Change"},{"line_number":62,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"f1295fcc_a379af8b","line":60,"range":{"start_line":58,"start_character":75,"end_line":60,"end_character":1},"in_reply_to":"230ff1de_3bf069e4","updated":"2026-10-02 17:57:50.000000000","message":"The new PS now handles volumes as volume migrations to different pools or retypes, so there is no correlation with compute or storage AZs. Checking storage AZ is out of the scope for now, since Cinder has no/and may have no plans to accept destination az as a migrations option.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"77b0d7124ce6d8897ce66bd09ff7eadd3dbf7c69","unresolved":true,"context_lines":[{"line_number":55,"context_line":"  zone, with the source compute services disabled so the scheduler does not"},{"line_number":56,"context_line":"  refill them mid-drain."},{"line_number":57,"context_line":"* **Deployer** migrates only the block storage of a zone — retyping volumes"},{"line_number":58,"context_line":"  onto backends in the destination zone — while leaving compute in place, or"},{"line_number":59,"context_line":"  the reverse."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Proposed Change"},{"line_number":62,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"230ff1de_3bf069e4","line":60,"range":{"start_line":58,"start_character":75,"end_line":60,"end_character":1},"in_reply_to":"ac1b1abf_afb1bd38","updated":"2026-09-30 22:57:10.000000000","message":"`retyping volumes onto backends in the destination zone`\n\nis not quite correct.\n\nWe need to distinguish between a Cinder volume\u0027s volume type, the\nstorage backend on which it is currently placed, and the availability\nzone of that backend. These are related, but they do not have a 1:1:1\nmapping.\n\nVolume types are roughly analogous to Nova flavors. A volume has a\nvolume type, and that type can be supported by multiple storage\nbackends, potentially across multiple Cinder AZs. Cinder also allows a\nvolume type to constrain the AZs in which it is valid using\n`RESKEY:availability_zones`.\n\nFor example, a `prod` volume type could be available in both:\n\n    mass_storage_replica_2\n        -\u003e Ceph backend\n\n    performance_replica_3\n        -\u003e Fibre Channel NVMe array\n\nThe physical storage implementation and performance characteristics\ncan therefore differ between backends while the user-visible volume\ntype remains `prod`.\n\nSimilarly, a single backend can be exposed through multiple volume\ntypes. For example, the same Ceph backend might support:\n\n    ceph_fast -\u003e QoS policy allowing 1000 IOPS\n    ceph_slow -\u003e QoS policy allowing 100 IOPS\n\nThe volume type is therefore not an identifier for either a backend or\nan AZ.\n\nThere are also two different Cinder operations that matter here.\n\nA volume migration moves a volume to a specified storage backend or\npool. This can be done while retaining the same volume type.\n\nA retype changes the volume type. The driver may be able to perform the\nretype on the existing backend. If satisfying the new type requires a\nmigration, Cinder can perform one as part of the retype operation.\nRetyping therefore does not inherently mean moving the volume to a\ndifferent backend or AZ.\n\nWatcher reflects this distinction in its existing `volume_migrate`\naction:\n\n    migration_type\u003dmigrate\n        -\u003e destination_node\n        -\u003e move to another backend/pool with the same volume type\n\n    migration_type\u003dretype\n        -\u003e destination_type\n        -\u003e change the volume type\n\n\nFor the AZ use case we therefore need to be able to express at least\nthese independently:\n```\n1. Move the VM from one Nova AZ to another while leaving its volumes\n   in place.\n\n2. Move a volume from a backend in one Cinder AZ to a backend in\n   another Cinder AZ while retaining its existing volume type.\n\n3. Move both, for example:\n\n       VM:\n           az_ups_backup\n               -\u003e az_diesel_backup\n\n       volume:\n           mass_storage_replica_2\n               -\u003e performance_replica_3\n\n4. Potentially migrate the volume to a different backend/AZ and also\n   change its volume type.\n```\nThe important point for Watcher is that it cannot infer a destination\nvolume type from the destination AZ. A volume type may be valid in\nmultiple AZs, and multiple backends in an AZ may support that same\ntype.\n\nSo I think we should describe this as migrating the volume to a\nsuitable backend in the destination Cinder AZ, preserving the existing\nvolume type unless a separate retype is explicitly requested.\n\nThat keeps backend/AZ migration and volume-type changes as independent\ndecisions instead of assuming that crossing an AZ boundary implies a\nretype.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  zone, with the source compute services disabled so the scheduler does not"},{"line_number":56,"context_line":"  refill them mid-drain."},{"line_number":57,"context_line":"* **Deployer** migrates only the block storage of a zone — retyping volumes"},{"line_number":58,"context_line":"  onto backends in the destination zone — while leaving compute in place, or"},{"line_number":59,"context_line":"  the reverse."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Proposed Change"},{"line_number":62,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"284db36e_4c557df5","line":60,"range":{"start_line":58,"start_character":75,"end_line":60,"end_character":1},"in_reply_to":"e7f48087_76c9bc71","updated":"2026-10-19 21:37:29.000000000","message":"I think that pool/retype migrations are properlu covered here, no storage AZ mentioned for those. Closing this thread for now.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"82de505c9a36eadc8d771ce197bb711c810a8b85","unresolved":true,"context_lines":[{"line_number":55,"context_line":"  zone, with the source compute services disabled so the scheduler does not"},{"line_number":56,"context_line":"  refill them mid-drain."},{"line_number":57,"context_line":"* **Deployer** migrates only the block storage of a zone — retyping volumes"},{"line_number":58,"context_line":"  onto backends in the destination zone — while leaving compute in place, or"},{"line_number":59,"context_line":"  the reverse."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Proposed Change"},{"line_number":62,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"060fd35e_ac7b1607","line":60,"range":{"start_line":58,"start_character":75,"end_line":60,"end_character":1},"in_reply_to":"f1295fcc_a379af8b","updated":"2026-10-09 00:15:44.000000000","message":"I think that\u0027s fine. The existing volume migrate or volume retype in watch should be sufficient.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4c4d921219c2022d940e5f5e7e7a7703e87e26da","unresolved":true,"context_lines":[{"line_number":55,"context_line":"  zone, with the source compute services disabled so the scheduler does not"},{"line_number":56,"context_line":"  refill them mid-drain."},{"line_number":57,"context_line":"* **Deployer** migrates only the block storage of a zone — retyping volumes"},{"line_number":58,"context_line":"  onto backends in the destination zone — while leaving compute in place, or"},{"line_number":59,"context_line":"  the reverse."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Proposed Change"},{"line_number":62,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ac1b1abf_afb1bd38","line":60,"range":{"start_line":58,"start_character":75,"end_line":60,"end_character":1},"in_reply_to":"f92099c6_af362b15","updated":"2026-09-29 20:37:58.000000000","message":"Correct, it can be improved in the next ps.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"4f879a777d2dd912827f1b41b2e5c8e9b216139b","unresolved":true,"context_lines":[{"line_number":61,"context_line":"Proposed Change"},{"line_number":62,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Add two optional input parameters to ``zone_migration`` that, together,"},{"line_number":65,"context_line":"express an AZ drain."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"``availability_zones`` is **mutually exclusive** with the existing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2bce5d39_68b05b7d","line":64,"updated":"2026-10-01 15:15:38.000000000","message":"wondering what are everyone thoughts on the possibility of adding this functionality to a new strategy instead of adding more complexity to the existing zone migration. The new strategy could ideally share most of the code with zone migration, with the advantage of having a much simpler user interface","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"282700bdb3b7a5286ece1974a914a8b42f5523fd","unresolved":true,"context_lines":[{"line_number":61,"context_line":"Proposed Change"},{"line_number":62,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Add two optional input parameters to ``zone_migration`` that, together,"},{"line_number":65,"context_line":"express an AZ drain."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"``availability_zones`` is **mutually exclusive** with the existing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"aac49df8_bc717d41","line":64,"in_reply_to":"2bce5d39_68b05b7d","updated":"2026-10-01 17:50:39.000000000","message":"I think that after we agreed on a workflow we can decide about that, but it seems that the current storage approach fits well for our proposal, so I would still keep with zone_migration.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"e281f70de334c5b12585f268e90571d292c5c218","unresolved":true,"context_lines":[{"line_number":61,"context_line":"Proposed Change"},{"line_number":62,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Add two optional input parameters to ``zone_migration`` that, together,"},{"line_number":65,"context_line":"express an AZ drain."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"``availability_zones`` is **mutually exclusive** with the existing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bc65a21e_d90263d5","line":64,"in_reply_to":"9eb8a81b_7522668b","updated":"2026-10-09 21:04:37.000000000","message":"Looks like this can be resolved.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"7d31f265858318c5cd3e7ed1e7b31f2ce2e6f3e4","unresolved":true,"context_lines":[{"line_number":61,"context_line":"Proposed Change"},{"line_number":62,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Add two optional input parameters to ``zone_migration`` that, together,"},{"line_number":65,"context_line":"express an AZ drain."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"``availability_zones`` is **mutually exclusive** with the existing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9eb8a81b_7522668b","line":64,"in_reply_to":"aac49df8_bc717d41","updated":"2026-10-06 14:26:08.000000000","message":"ack yes, the second patchset simplies a bit the changes to the strategy","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f7804ce4bb692e288eb6da54cc76fbc4af7b8c23","unresolved":false,"context_lines":[{"line_number":61,"context_line":"Proposed Change"},{"line_number":62,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Add two optional input parameters to ``zone_migration`` that, together,"},{"line_number":65,"context_line":"express an AZ drain."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"``availability_zones`` is **mutually exclusive** with the existing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2c0b6ff4_37053a83","line":64,"in_reply_to":"bc65a21e_d90263d5","updated":"2026-10-13 17:25:30.000000000","message":"Done","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"086f6c27b0f6c775700f27587c73e7d9bcdbf3ee","unresolved":true,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Two new top-level properties, both optional. The schema already sets"},{"line_number":94,"context_line":"``additionalProperties: False`` at the top level::"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    {"},{"line_number":97,"context_line":"      \"availability_zones\": ["},{"line_number":98,"context_line":"        {\"src_az\": \"az-a\","},{"line_number":99,"context_line":"         \"dst_az\": \"az-b\","},{"line_number":100,"context_line":"         \"resource_types\": [\"instance\", \"volume\"],"},{"line_number":101,"context_line":"         \"volume_types\": ["},{"line_number":102,"context_line":"           {\"src_type\": \"ceph-a\", \"dst_type\": \"ceph-b\"}"},{"line_number":103,"context_line":"         ]}"},{"line_number":104,"context_line":"      ],"},{"line_number":105,"context_line":"      \"disable_source_nodes\": false"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"``availability_zones``"},{"line_number":109,"context_line":"  Array of ``{src_az, dst_az, resource_types, volume_types}``,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"cfaddd16_3dda6625","line":106,"range":{"start_line":95,"start_character":1,"end_line":106,"end_character":5},"updated":"2026-09-29 15:52:23.000000000","message":"Why not something like:\n\n```\n{\n    \"compute_nodes\": [{\"src_az\": \"az-a\", \"dst_az\": \"az-b\"}],\n    \"storage_pools\": [{\"src_type\": \"ceph-a\", \"dst_type\": \"ceph-b\"}]\n}\n```\n\nIMO this is more aligned to the fact that we are not filtering volumes by AZ and would be simpler.\n\nnote we are currently always requiring src_pool in storage_pools, so we\u0027d need to discuss that. Actually, given that a pool is tied to a availability_zone, we may be able to restrict volumes in a type by using it (as a type may have volumes in multiple AZs iiuc).","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4c4d921219c2022d940e5f5e7e7a7703e87e26da","unresolved":true,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Two new top-level properties, both optional. The schema already sets"},{"line_number":94,"context_line":"``additionalProperties: False`` at the top level::"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    {"},{"line_number":97,"context_line":"      \"availability_zones\": ["},{"line_number":98,"context_line":"        {\"src_az\": \"az-a\","},{"line_number":99,"context_line":"         \"dst_az\": \"az-b\","},{"line_number":100,"context_line":"         \"resource_types\": [\"instance\", \"volume\"],"},{"line_number":101,"context_line":"         \"volume_types\": ["},{"line_number":102,"context_line":"           {\"src_type\": \"ceph-a\", \"dst_type\": \"ceph-b\"}"},{"line_number":103,"context_line":"         ]}"},{"line_number":104,"context_line":"      ],"},{"line_number":105,"context_line":"      \"disable_source_nodes\": false"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"``availability_zones``"},{"line_number":109,"context_line":"  Array of ``{src_az, dst_az, resource_types, volume_types}``,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ab1f1f8d_6b1e8d66","line":106,"range":{"start_line":95,"start_character":1,"end_line":106,"end_character":5},"in_reply_to":"07008d4d_98b872d3","updated":"2026-09-29 20:37:58.000000000","message":"s/\u0027while dest_pool will always be\u0027/\u0027while dest_type will always be\u0027","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"039df4a026370beb929eb7b52d0e576208c2c1d8","unresolved":true,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Two new top-level properties, both optional. The schema already sets"},{"line_number":94,"context_line":"``additionalProperties: False`` at the top level::"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    {"},{"line_number":97,"context_line":"      \"availability_zones\": ["},{"line_number":98,"context_line":"        {\"src_az\": \"az-a\","},{"line_number":99,"context_line":"         \"dst_az\": \"az-b\","},{"line_number":100,"context_line":"         \"resource_types\": [\"instance\", \"volume\"],"},{"line_number":101,"context_line":"         \"volume_types\": ["},{"line_number":102,"context_line":"           {\"src_type\": \"ceph-a\", \"dst_type\": \"ceph-b\"}"},{"line_number":103,"context_line":"         ]}"},{"line_number":104,"context_line":"      ],"},{"line_number":105,"context_line":"      \"disable_source_nodes\": false"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"``availability_zones``"},{"line_number":109,"context_line":"  Array of ``{src_az, dst_az, resource_types, volume_types}``,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff3ede39_70d09367","line":106,"range":{"start_line":95,"start_character":1,"end_line":106,"end_character":5},"in_reply_to":"4516842e_db37075f","updated":"2026-09-30 12:19:11.000000000","message":"Yeah, I am starting to think that would be better like that too. The original idea on keeping a top-level \"availability_zones\" property was to allow exclusive properties for this kind of migration, but it may not be needed in the end","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Two new top-level properties, both optional. The schema already sets"},{"line_number":94,"context_line":"``additionalProperties: False`` at the top level::"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    {"},{"line_number":97,"context_line":"      \"availability_zones\": ["},{"line_number":98,"context_line":"        {\"src_az\": \"az-a\","},{"line_number":99,"context_line":"         \"dst_az\": \"az-b\","},{"line_number":100,"context_line":"         \"resource_types\": [\"instance\", \"volume\"],"},{"line_number":101,"context_line":"         \"volume_types\": ["},{"line_number":102,"context_line":"           {\"src_type\": \"ceph-a\", \"dst_type\": \"ceph-b\"}"},{"line_number":103,"context_line":"         ]}"},{"line_number":104,"context_line":"      ],"},{"line_number":105,"context_line":"      \"disable_source_nodes\": false"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"``availability_zones``"},{"line_number":109,"context_line":"  Array of ``{src_az, dst_az, resource_types, volume_types}``,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4b5adc3f_654dbc12","line":106,"range":{"start_line":95,"start_character":1,"end_line":106,"end_character":5},"in_reply_to":"aace6b21_358a23f1","updated":"2026-10-19 21:37:29.000000000","message":"closing this since most of us agree with current (PS2) paramters modeling.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"598241d080a8dd767860c48abaf29230c51c7dbe","unresolved":true,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Two new top-level properties, both optional. The schema already sets"},{"line_number":94,"context_line":"``additionalProperties: False`` at the top level::"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    {"},{"line_number":97,"context_line":"      \"availability_zones\": ["},{"line_number":98,"context_line":"        {\"src_az\": \"az-a\","},{"line_number":99,"context_line":"         \"dst_az\": \"az-b\","},{"line_number":100,"context_line":"         \"resource_types\": [\"instance\", \"volume\"],"},{"line_number":101,"context_line":"         \"volume_types\": ["},{"line_number":102,"context_line":"           {\"src_type\": \"ceph-a\", \"dst_type\": \"ceph-b\"}"},{"line_number":103,"context_line":"         ]}"},{"line_number":104,"context_line":"      ],"},{"line_number":105,"context_line":"      \"disable_source_nodes\": false"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"``availability_zones``"},{"line_number":109,"context_line":"  Array of ``{src_az, dst_az, resource_types, volume_types}``,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4516842e_db37075f","line":106,"range":{"start_line":95,"start_character":1,"end_line":106,"end_character":5},"in_reply_to":"ab1f1f8d_6b1e8d66","updated":"2026-09-30 09:41:51.000000000","message":"In my proposal, there is not `resource_types` parameters at all. Presence of `storage_pools` means volume migrations is required as defined by the parameters, while no `storage_pools`\u003d\u003d no volumes_migration at all.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"4f879a777d2dd912827f1b41b2e5c8e9b216139b","unresolved":true,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Two new top-level properties, both optional. The schema already sets"},{"line_number":94,"context_line":"``additionalProperties: False`` at the top level::"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    {"},{"line_number":97,"context_line":"      \"availability_zones\": ["},{"line_number":98,"context_line":"        {\"src_az\": \"az-a\","},{"line_number":99,"context_line":"         \"dst_az\": \"az-b\","},{"line_number":100,"context_line":"         \"resource_types\": [\"instance\", \"volume\"],"},{"line_number":101,"context_line":"         \"volume_types\": ["},{"line_number":102,"context_line":"           {\"src_type\": \"ceph-a\", \"dst_type\": \"ceph-b\"}"},{"line_number":103,"context_line":"         ]}"},{"line_number":104,"context_line":"      ],"},{"line_number":105,"context_line":"      \"disable_source_nodes\": false"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"``availability_zones``"},{"line_number":109,"context_line":"  Array of ``{src_az, dst_az, resource_types, volume_types}``,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"f9bc816c_459b1134","line":106,"range":{"start_line":95,"start_character":1,"end_line":106,"end_character":5},"in_reply_to":"ab1f1f8d_6b1e8d66","updated":"2026-10-01 15:15:38.000000000","message":"at first glance I think I prefer a separate `availability_zones` parameter. It seems simpler to reason about. With this addition, I think we\u0027re past the point where schema validation is feasible and we should move to validate using python code instead. Even if it\u0027s technically possible to use shcema validation it\u0027ll be too hard imo.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"137046ab661eb7609883e3f39736a4df042749c8","unresolved":true,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Two new top-level properties, both optional. The schema already sets"},{"line_number":94,"context_line":"``additionalProperties: False`` at the top level::"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    {"},{"line_number":97,"context_line":"      \"availability_zones\": ["},{"line_number":98,"context_line":"        {\"src_az\": \"az-a\","},{"line_number":99,"context_line":"         \"dst_az\": \"az-b\","},{"line_number":100,"context_line":"         \"resource_types\": [\"instance\", \"volume\"],"},{"line_number":101,"context_line":"         \"volume_types\": ["},{"line_number":102,"context_line":"           {\"src_type\": \"ceph-a\", \"dst_type\": \"ceph-b\"}"},{"line_number":103,"context_line":"         ]}"},{"line_number":104,"context_line":"      ],"},{"line_number":105,"context_line":"      \"disable_source_nodes\": false"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"``availability_zones``"},{"line_number":109,"context_line":"  Array of ``{src_az, dst_az, resource_types, volume_types}``,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"07008d4d_98b872d3","line":106,"range":{"start_line":95,"start_character":1,"end_line":106,"end_character":5},"in_reply_to":"cfaddd16_3dda6625","updated":"2026-09-29 17:11:58.000000000","message":"It is an option. The complexity that I see will be in the schema. When providing a src_az and dst_az, the optional and mandatory parameters changes: src_pool is not mandatory, while dest_pool will always be if resource_types has [\u0027volumes\u0027], dst_node turns an invalid option, etc. In my understanding it adds more logic to existing parameters that increases its complexity and to know what would be the right combination, and which ones are valid/supported. Below I mention the usage of scope in order to restrict resources, which seems to be the right way (outside the strategy).","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"e281f70de334c5b12585f268e90571d292c5c218","unresolved":true,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Two new top-level properties, both optional. The schema already sets"},{"line_number":94,"context_line":"``additionalProperties: False`` at the top level::"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    {"},{"line_number":97,"context_line":"      \"availability_zones\": ["},{"line_number":98,"context_line":"        {\"src_az\": \"az-a\","},{"line_number":99,"context_line":"         \"dst_az\": \"az-b\","},{"line_number":100,"context_line":"         \"resource_types\": [\"instance\", \"volume\"],"},{"line_number":101,"context_line":"         \"volume_types\": ["},{"line_number":102,"context_line":"           {\"src_type\": \"ceph-a\", \"dst_type\": \"ceph-b\"}"},{"line_number":103,"context_line":"         ]}"},{"line_number":104,"context_line":"      ],"},{"line_number":105,"context_line":"      \"disable_source_nodes\": false"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"``availability_zones``"},{"line_number":109,"context_line":"  Array of ``{src_az, dst_az, resource_types, volume_types}``,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"aace6b21_358a23f1","line":106,"range":{"start_line":95,"start_character":1,"end_line":106,"end_character":5},"in_reply_to":"f33de0eb_bb4debb1","updated":"2026-10-09 21:04:37.000000000","message":"Patchset 2 makes the service-local AZ distinction explicit and keeps the compute AZ parameters separate from operator-specified storage pool and type destinations (lines 39–49 and 169–180). It does not add a separate Cinder src_az/dst_az mapping: the spec is scoped to compute AZ drains, and the Cinder flow uses the destination pool or type because Cinder migration takes a host and retype takes a type (lines 246–267). Patchset 2 explains why a storage AZ pair would require Watcher to select a backend (lines 452–459).\n\nGiven the above, maybe this comment can be resolved?","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"282700bdb3b7a5286ece1974a914a8b42f5523fd","unresolved":true,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Two new top-level properties, both optional. The schema already sets"},{"line_number":94,"context_line":"``additionalProperties: False`` at the top level::"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    {"},{"line_number":97,"context_line":"      \"availability_zones\": ["},{"line_number":98,"context_line":"        {\"src_az\": \"az-a\","},{"line_number":99,"context_line":"         \"dst_az\": \"az-b\","},{"line_number":100,"context_line":"         \"resource_types\": [\"instance\", \"volume\"],"},{"line_number":101,"context_line":"         \"volume_types\": ["},{"line_number":102,"context_line":"           {\"src_type\": \"ceph-a\", \"dst_type\": \"ceph-b\"}"},{"line_number":103,"context_line":"         ]}"},{"line_number":104,"context_line":"      ],"},{"line_number":105,"context_line":"      \"disable_source_nodes\": false"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"``availability_zones``"},{"line_number":109,"context_line":"  Array of ``{src_az, dst_az, resource_types, volume_types}``,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"f33de0eb_bb4debb1","line":106,"range":{"start_line":95,"start_character":1,"end_line":106,"end_character":5},"in_reply_to":"f9bc816c_459b1134","updated":"2026-10-01 17:50:39.000000000","message":"It could be separated parameter but now I see that it makes more sense to be inside `compute_nodes` since we plan to use destination_az only when migrating instances. For volumes, user will still need to provide src_pools/dest_pools/dest_types mapping. If we decide go with a `availability_zones` it would be a compute_src_az and compute_dest_az parameters.\nAbout the validation, IITC today we only have schema validation at the API, so users get a earlier error when creating an audit, and we have some validations at strategy pre_execute which is too late from my pov (only the ones that are not possible to validate with an schema).","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"77b0d7124ce6d8897ce66bd09ff7eadd3dbf7c69","unresolved":true,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Two new top-level properties, both optional. The schema already sets"},{"line_number":94,"context_line":"``additionalProperties: False`` at the top level::"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    {"},{"line_number":97,"context_line":"      \"availability_zones\": ["},{"line_number":98,"context_line":"        {\"src_az\": \"az-a\","},{"line_number":99,"context_line":"         \"dst_az\": \"az-b\","},{"line_number":100,"context_line":"         \"resource_types\": [\"instance\", \"volume\"],"},{"line_number":101,"context_line":"         \"volume_types\": ["},{"line_number":102,"context_line":"           {\"src_type\": \"ceph-a\", \"dst_type\": \"ceph-b\"}"},{"line_number":103,"context_line":"         ]}"},{"line_number":104,"context_line":"      ],"},{"line_number":105,"context_line":"      \"disable_source_nodes\": false"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"``availability_zones``"},{"line_number":109,"context_line":"  Array of ``{src_az, dst_az, resource_types, volume_types}``,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0640bbb9_cca1b427","line":106,"range":{"start_line":95,"start_character":1,"end_line":106,"end_character":5},"in_reply_to":"ff3ede39_70d09367","updated":"2026-09-30 22:57:10.000000000","message":"Fundamentally, you cannot and should not assume that an AZ name is\naligned between different OpenStack services.\n\nYou also should not assume that volume types, storage backends, and\nAZs have a 1:1:1 relationship.\n\nFor example, the same volume type can be available in multiple AZs,\nand multiple storage backends can satisfy the same volume type within\nthe same or different AZs.\n\nThe mapping between Nova, Cinder, and Neutron is roughly:\n```\nNova\n-----------------------------------------------------------------------\nprovider resource        compute node\n\nscheduling policy        flavor\n                         + extra specs\n\ntenant resource          server\n\nAZ placement domain      host aggregate\n                         with AZ metadata\n\nAZ selected on           server\n                         availability_zone\n\n\nCinder\n-----------------------------------------------------------------------\nprovider resource        storage backend\n\nscheduling policy        volume type\n                         + extra specs\n\ntenant resource          volume\n\nAZ placement domain      backend AZ\n                         configuration\n\nAZ selected on           volume\n                         availability_zone\n\n\nNeutron\n-----------------------------------------------------------------------\nprovider resource        network node / agent / chassis\n\nscheduling policy        network/router attributes\n                         + AZ hints / flavor\n\ntenant resource          network / router\n                         (ports indirectly)\n\nAZ placement domain      agent/chassis AZ\n\nAZ selected on           network / router\n                         availability_zone_hints\n\n```\nNeutron also has a flavor framework:\nhttps://wiki.openstack.org/wiki/Neutron/FlavorFramework\n\n\nConceptually:\n```\nNova:\n    AZ primarily constrains WHERE a server is placed.\n    Flavor primarily constrains WHAT compute capabilities can\n    satisfy it.\n\nCinder:\n    AZ primarily constrains WHERE a volume is placed.\n    Volume type primarily constrains WHAT storage capabilities\n    can satisfy it, but a volume type can additionally constrain\n    WHERE via RESKEY:availability_zones.\n\nNeutron:\n    AZ constrains WHERE service functions for a network or router\n    are placed.\n```\n\nFor Nova:\n```\nhost aggregate\n    |\n    +-- metadata: availability_zone\u003daz1\n    |\n    +-- compute-01\n    +-- compute-02\n\nserver --availability-zone az1\n           |\n           v\nNova scheduler chooses one of those compute nodes\n```\n\nFor Neutron:\n```\nDHCP agent / L3 agent\n      |\n      +-- availability_zone\u003daz1\n      |\nnetwork / router\n      |\n      +-- availability_zone_hints\u003d[az1]\n```\n\nFor Cinder:\n```\n                         explicit AZ\nvolume create ------------------------------------+\n  --availability-zone az1                        |\n                                                  v\n                                           requested AZ set\n                                                  |\nvolume type                                       |\n  +-- RESKEY:availability_zones\u003daz1,az2 ----------+\n                                                  |\n                                                  v\n                                      AvailabilityZoneFilter\n                                                  |\n                                                  v\n                                  candidate storage backends\n                                                  |\n                                                  v\n                                  other filters and weighers\n                                                  |\n                                                  v\n                                       selected backend\n\n\nFor example:\n\nvolume type: fast\n    |\n    +-- RESKEY:availability_zones\u003daz1,az2\n    |\n    +-----------------------------+\n                                  |\nvolume --availability-zone az1    |\n    |                             |\n    +-------------+---------------+\n                  |\n                  v\n        acceptable AZ \u003d az1\n                  |\n                  v\n        backend-a  az1\n        backend-b  az1\n        backend-c  az2\n                  |\n                  v\n      scheduler selects an az1\n      backend that also satisfies\n      the volume type and other\n      scheduler constraints\n```\n\n\nThe important point is that an availability zone is a service-local\nscheduling domain.\n\nAn AZ called \"az1\" in Nova is not inherently the same thing as \"az1\"\nin Cinder or Neutron. Operators may deliberately align the names and\nunderlying failure domains, but OpenStack does not require that\nalignment.\n\nthat a very long way to say this shoudl looks more like this\n```\n{\n  \"compute\": [\n    {\n      \"src_az\": \"compute-a\",\n      \"dst_az\": \"compute-b\",\n      \"pinned_instances\": \"exclude\"\n    }\n  ],\n\n  \"storage\": [\n    {\n      \"src_az\": \"storage-a\",\n      \"dst_az\": \"storage-b\",\n      \"volume_type_mappings\": [\n        {\n          \"src_type\": \"ceph-fast\",\n          \"dst_type\": \"nvme-fast\"\n        },\n        {\n          \"src_type\": \"ceph-slow\",\n          \"dst_type\": \"nvme-slow\"\n        }\n      ]\n    }\n  ],\n\n  \"disable_source_nodes\": false\n}\n```\n\nstorage AZ migration always means:\n\n    move volumes from a backend in src_az\n    to a suitable backend in dst_az\n\nvolume_type_mappings optionally means:\n\n    if the volume\u0027s current type matches src_type,\n    also retype it to dst_type\n\nif no mapping matches:\n\n    preserve the existing volume type","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"77b0d7124ce6d8897ce66bd09ff7eadd3dbf7c69","unresolved":true,"context_lines":[{"line_number":105,"context_line":"      \"disable_source_nodes\": false"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"``availability_zones``"},{"line_number":109,"context_line":"  Array of ``{src_az, dst_az, resource_types, volume_types}``,"},{"line_number":110,"context_line":"  ``additionalProperties: False``. Everything one zone pair needs is"},{"line_number":111,"context_line":"  self-contained in its own entry, so a single audit can drain several pairs"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0e30b432_4509ea38","line":108,"updated":"2026-09-30 22:57:10.000000000","message":"i got as far as here tonight.\n\nalso if it snot obviousl i had ai rewrote/spellehck my commetn above and create the diagrams.\n\nteh feed back is still ming but the amoutn of typos was excessive even for me\nso i got it to clean it up a bit.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"282700bdb3b7a5286ece1974a914a8b42f5523fd","unresolved":true,"context_lines":[{"line_number":105,"context_line":"      \"disable_source_nodes\": false"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"``availability_zones``"},{"line_number":109,"context_line":"  Array of ``{src_az, dst_az, resource_types, volume_types}``,"},{"line_number":110,"context_line":"  ``additionalProperties: False``. Everything one zone pair needs is"},{"line_number":111,"context_line":"  self-contained in its own entry, so a single audit can drain several pairs"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9baf2690_38a94e07","line":108,"in_reply_to":"0e30b432_4509ea38","updated":"2026-10-01 17:50:39.000000000","message":"ack, you didn\u0027t reach the \u0027AZ-pinned instances\u0027 section, but mentioned that case above. I will likely rewrite it too, and maybe you get a new version.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":false,"context_lines":[{"line_number":105,"context_line":"      \"disable_source_nodes\": false"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"``availability_zones``"},{"line_number":109,"context_line":"  Array of ``{src_az, dst_az, resource_types, volume_types}``,"},{"line_number":110,"context_line":"  ``additionalProperties: False``. Everything one zone pair needs is"},{"line_number":111,"context_line":"  self-contained in its own entry, so a single audit can drain several pairs"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6a1d6e9b_91a5f00c","line":108,"in_reply_to":"9baf2690_38a94e07","updated":"2026-10-19 21:37:29.000000000","message":"Done","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"086f6c27b0f6c775700f27587c73e7d9bcdbf3ee","unresolved":true,"context_lines":[{"line_number":119,"context_line":"  \"volume\"]``, ``uniqueItems: true``, ``minItems: 1``, default"},{"line_number":120,"context_line":"  ``[\"instance\", \"volume\"]``. It scopes what a single AZ entry drains."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  ``[\"instance\"]`` does *not* suppress retyping of volumes attached to a"},{"line_number":123,"context_line":"  migrating instance. A cross-AZ instance move without the retype leaves the"},{"line_number":124,"context_line":"  instance reading from a source-zone backend, so the coupled retype is a"},{"line_number":125,"context_line":"  correctness requirement, not a user preference. This asymmetry must be"},{"line_number":126,"context_line":"  documented prominently."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  ``volume_types`` is an array of ``{src_type, dst_type}``, both required,"},{"line_number":129,"context_line":"  ``additionalProperties: False``. It serves two purposes within its entry:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b595f890_90b78085","line":126,"range":{"start_line":122,"start_character":0,"end_line":126,"end_character":25},"updated":"2026-09-29 15:52:23.000000000","message":"I think that\u0027s not always true. Cloud operators may have unaligned cinder and nova availability zones and enable cross-AZ in some cases. IMO, a cloud operator setting `\"resource_types\": [\"instance\"]` should only get the instances migrated and volumes shouldn keep as-is. While the 1:1 for AZs between nova and cinder may be common or even recommended there are cases where that may not be the case iiuc.\n\nIf the cloud admin wants to move the volumes, they should also add it to `resources_types` explicitely imo.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"de20bbd143d1674ff9ab75378b94212f4987dc6d","unresolved":true,"context_lines":[{"line_number":119,"context_line":"  \"volume\"]``, ``uniqueItems: true``, ``minItems: 1``, default"},{"line_number":120,"context_line":"  ``[\"instance\", \"volume\"]``. It scopes what a single AZ entry drains."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  ``[\"instance\"]`` does *not* suppress retyping of volumes attached to a"},{"line_number":123,"context_line":"  migrating instance. A cross-AZ instance move without the retype leaves the"},{"line_number":124,"context_line":"  instance reading from a source-zone backend, so the coupled retype is a"},{"line_number":125,"context_line":"  correctness requirement, not a user preference. This asymmetry must be"},{"line_number":126,"context_line":"  documented prominently."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  ``volume_types`` is an array of ``{src_type, dst_type}``, both required,"},{"line_number":129,"context_line":"  ``additionalProperties: False``. It serves two purposes within its entry:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d5a32960_811d58b4","line":126,"range":{"start_line":122,"start_character":0,"end_line":126,"end_character":25},"in_reply_to":"276dec08_4b0ccb46","updated":"2026-09-30 13:10:22.000000000","message":"I fully agree, the actual behaviour of the existing `with_attached_volume` is missleading and I even have doubts if it\u0027s useful. We may reconsider if it\u0027s good to maintain, remove or rename. I\u0027m not sure how useful it is, tbh.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"adeb8dbebe14aa2cd3f2d44e1ad37d5491561eeb","unresolved":true,"context_lines":[{"line_number":119,"context_line":"  \"volume\"]``, ``uniqueItems: true``, ``minItems: 1``, default"},{"line_number":120,"context_line":"  ``[\"instance\", \"volume\"]``. It scopes what a single AZ entry drains."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  ``[\"instance\"]`` does *not* suppress retyping of volumes attached to a"},{"line_number":123,"context_line":"  migrating instance. A cross-AZ instance move without the retype leaves the"},{"line_number":124,"context_line":"  instance reading from a source-zone backend, so the coupled retype is a"},{"line_number":125,"context_line":"  correctness requirement, not a user preference. This asymmetry must be"},{"line_number":126,"context_line":"  documented prominently."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  ``volume_types`` is an array of ``{src_type, dst_type}``, both required,"},{"line_number":129,"context_line":"  ``additionalProperties: False``. It serves two purposes within its entry:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d93c2738_6af4b5e4","line":126,"range":{"start_line":122,"start_character":0,"end_line":126,"end_character":25},"in_reply_to":"76be45fe_7cc62d74","updated":"2026-10-02 17:57:50.000000000","message":"`with_attached_volume` should be deprecated IMHO, it changes only the order of the actions, which can afterwards changed again in the planner phase, so it is confusing","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"137046ab661eb7609883e3f39736a4df042749c8","unresolved":true,"context_lines":[{"line_number":119,"context_line":"  \"volume\"]``, ``uniqueItems: true``, ``minItems: 1``, default"},{"line_number":120,"context_line":"  ``[\"instance\", \"volume\"]``. It scopes what a single AZ entry drains."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  ``[\"instance\"]`` does *not* suppress retyping of volumes attached to a"},{"line_number":123,"context_line":"  migrating instance. A cross-AZ instance move without the retype leaves the"},{"line_number":124,"context_line":"  instance reading from a source-zone backend, so the coupled retype is a"},{"line_number":125,"context_line":"  correctness requirement, not a user preference. This asymmetry must be"},{"line_number":126,"context_line":"  documented prominently."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  ``volume_types`` is an array of ``{src_type, dst_type}``, both required,"},{"line_number":129,"context_line":"  ``additionalProperties: False``. It serves two purposes within its entry:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bb949d55_944cdbe2","line":126,"range":{"start_line":122,"start_character":0,"end_line":126,"end_character":25},"in_reply_to":"b595f890_90b78085","updated":"2026-09-29 17:11:58.000000000","message":"So there are 3 possibilities and 2 configurations proposed. 1) instances only, 2) instances + attached volumes and 3) available volumes. So in the end, ideally we could have those 3. So we could extend the resource_typesto volumes an attached_volumes_only. But I agree that looks weird that volumes are migrates when \"volumes\" is removed from resource_types. But, it should be possible to have the option to only migrate \"instances with attached volumes\" and skip the \"available\"volumes. I always see that scope could be helpfull here instead of new configurations, but it is today limited to projects/volumes(uuids)/pools (we could exclude volumes per status for example, but that is another discussion I guess)","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"4f879a777d2dd912827f1b41b2e5c8e9b216139b","unresolved":true,"context_lines":[{"line_number":119,"context_line":"  \"volume\"]``, ``uniqueItems: true``, ``minItems: 1``, default"},{"line_number":120,"context_line":"  ``[\"instance\", \"volume\"]``. It scopes what a single AZ entry drains."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  ``[\"instance\"]`` does *not* suppress retyping of volumes attached to a"},{"line_number":123,"context_line":"  migrating instance. A cross-AZ instance move without the retype leaves the"},{"line_number":124,"context_line":"  instance reading from a source-zone backend, so the coupled retype is a"},{"line_number":125,"context_line":"  correctness requirement, not a user preference. This asymmetry must be"},{"line_number":126,"context_line":"  documented prominently."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  ``volume_types`` is an array of ``{src_type, dst_type}``, both required,"},{"line_number":129,"context_line":"  ``additionalProperties: False``. It serves two purposes within its entry:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"76be45fe_7cc62d74","line":126,"range":{"start_line":122,"start_character":0,"end_line":126,"end_character":25},"in_reply_to":"bb949d55_944cdbe2","updated":"2026-10-01 15:15:38.000000000","message":"I agree with Alfredo here, from UX, migrating volumes when the user has apparently requested not to seems unexpected. What I\u0027m not sure, is what could happen if we do not touch the volumes after migrating  the attached instances. Would that always work? Would it cause any problem for Nova and fail the action?","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"598241d080a8dd767860c48abaf29230c51c7dbe","unresolved":true,"context_lines":[{"line_number":119,"context_line":"  \"volume\"]``, ``uniqueItems: true``, ``minItems: 1``, default"},{"line_number":120,"context_line":"  ``[\"instance\", \"volume\"]``. It scopes what a single AZ entry drains."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  ``[\"instance\"]`` does *not* suppress retyping of volumes attached to a"},{"line_number":123,"context_line":"  migrating instance. A cross-AZ instance move without the retype leaves the"},{"line_number":124,"context_line":"  instance reading from a source-zone backend, so the coupled retype is a"},{"line_number":125,"context_line":"  correctness requirement, not a user preference. This asymmetry must be"},{"line_number":126,"context_line":"  documented prominently."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  ``volume_types`` is an array of ``{src_type, dst_type}``, both required,"},{"line_number":129,"context_line":"  ``additionalProperties: False``. It serves two purposes within its entry:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"f8a875c8_a75c624c","line":126,"range":{"start_line":122,"start_character":0,"end_line":126,"end_character":25},"in_reply_to":"bb949d55_944cdbe2","updated":"2026-09-30 09:41:51.000000000","message":"I don\u0027t think we need to cover the `instances + attached volumes only` case. We currently don\u0027t support it. As my understanding the cases to cover are:\n1. instances only (as defined in `compute_nodes` parameter)\n2. volumes only (as defined in `storage_pools` parameter)\n3. instances + *all* volumens (as defined in `compute_nodes` + `storage_pools` parameter)\n\nMy understanding is that `instances + attached volumes only` has not been requested and I\u0027m not sure if it\u0027s a critical case to cover (there may be cases but if a cloud admin is wanting to totally drain an AZ or a storage pool, i think that includes unattached volumes in most cases, as they may want to attach them at a later time). If we want to cover that case, we may add a new top level parameter or even a parameter on each element in  storage_pools.\n\n```\n{\n    \"compute_nodes\": [{\"src_az\": \"az-a\", \"dst_az\": \"az-b\"}],\n    \"storage_pools\": [{\"src_type\": \"ceph-a\", \"dst_type\": \"ceph-b\", \"attached_only\": true}]\n}\n```\n\nIn that case we\u0027d need to define if attach means \"volumes with any attachment\" or \"volumes with an attachment to a vm that is going to be migrated\"","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":false,"context_lines":[{"line_number":119,"context_line":"  \"volume\"]``, ``uniqueItems: true``, ``minItems: 1``, default"},{"line_number":120,"context_line":"  ``[\"instance\", \"volume\"]``. It scopes what a single AZ entry drains."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  ``[\"instance\"]`` does *not* suppress retyping of volumes attached to a"},{"line_number":123,"context_line":"  migrating instance. A cross-AZ instance move without the retype leaves the"},{"line_number":124,"context_line":"  instance reading from a source-zone backend, so the coupled retype is a"},{"line_number":125,"context_line":"  correctness requirement, not a user preference. This asymmetry must be"},{"line_number":126,"context_line":"  documented prominently."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  ``volume_types`` is an array of ``{src_type, dst_type}``, both required,"},{"line_number":129,"context_line":"  ``additionalProperties: False``. It serves two purposes within its entry:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bbadacbd_e5c3eb8b","line":126,"range":{"start_line":122,"start_character":0,"end_line":126,"end_character":25},"in_reply_to":"d93c2738_6af4b5e4","updated":"2026-10-19 21:37:29.000000000","message":"We would only properly document `with_attached_volume` behavior for now. No deprecation for now and we may deprecate/remove it in future.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"039df4a026370beb929eb7b52d0e576208c2c1d8","unresolved":true,"context_lines":[{"line_number":119,"context_line":"  \"volume\"]``, ``uniqueItems: true``, ``minItems: 1``, default"},{"line_number":120,"context_line":"  ``[\"instance\", \"volume\"]``. It scopes what a single AZ entry drains."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  ``[\"instance\"]`` does *not* suppress retyping of volumes attached to a"},{"line_number":123,"context_line":"  migrating instance. A cross-AZ instance move without the retype leaves the"},{"line_number":124,"context_line":"  instance reading from a source-zone backend, so the coupled retype is a"},{"line_number":125,"context_line":"  correctness requirement, not a user preference. This asymmetry must be"},{"line_number":126,"context_line":"  documented prominently."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  ``volume_types`` is an array of ``{src_type, dst_type}``, both required,"},{"line_number":129,"context_line":"  ``additionalProperties: False``. It serves two purposes within its entry:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"276dec08_4b0ccb46","line":126,"range":{"start_line":122,"start_character":0,"end_line":126,"end_character":25},"in_reply_to":"f8a875c8_a75c624c","updated":"2026-09-30 12:19:11.000000000","message":"I think that since we are here, we could cover the 3, even without a clear requirement for it, it may be useful. I don\u0027t see this stratetegy usage as a single audit run, instead I think that it would be used to Drain workloads in multiple steps for big deployments, and having different options might help on that.\nThe issue that I see is with `with_attached_volume` top level property which is confusing and we may need to rename it.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"086f6c27b0f6c775700f27587c73e7d9bcdbf3ee","unresolved":true,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  ``volume_types`` is an array of ``{src_type, dst_type}``, both required,"},{"line_number":129,"context_line":"  ``additionalProperties: False``. It serves two purposes within its entry:"},{"line_number":130,"context_line":"  it selects standalone volumes to retype, and it is the lookup table used to"},{"line_number":131,"context_line":"  retype volumes attached to a migrating instance. ``dst_type`` is required"},{"line_number":132,"context_line":"  because crossing an AZ boundary always implies a retype, and a retype has"},{"line_number":133,"context_line":"  no meaning without a target type. It is required whenever"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5ae7a563_ef84cd4c","line":130,"range":{"start_line":130,"start_character":13,"end_line":130,"end_character":23},"updated":"2026-09-29 15:52:23.000000000","message":"in this context, standalone means \"unattached\"?","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"adeb8dbebe14aa2cd3f2d44e1ad37d5491561eeb","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  ``volume_types`` is an array of ``{src_type, dst_type}``, both required,"},{"line_number":129,"context_line":"  ``additionalProperties: False``. It serves two purposes within its entry:"},{"line_number":130,"context_line":"  it selects standalone volumes to retype, and it is the lookup table used to"},{"line_number":131,"context_line":"  retype volumes attached to a migrating instance. ``dst_type`` is required"},{"line_number":132,"context_line":"  because crossing an AZ boundary always implies a retype, and a retype has"},{"line_number":133,"context_line":"  no meaning without a target type. It is required whenever"}],"source_content_type":"text/x-rst","patch_set":1,"id":"618f0369_7003800b","line":130,"range":{"start_line":130,"start_character":13,"end_line":130,"end_character":23},"in_reply_to":"3ceea12a_ddf33787","updated":"2026-10-02 17:57:50.000000000","message":"this is now ommited. There is only a mention to attached volumes selection, if the team agree with that option too. It should be possible to migrate available volumes when providing only the storage_pools entries.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"137046ab661eb7609883e3f39736a4df042749c8","unresolved":true,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  ``volume_types`` is an array of ``{src_type, dst_type}``, both required,"},{"line_number":129,"context_line":"  ``additionalProperties: False``. It serves two purposes within its entry:"},{"line_number":130,"context_line":"  it selects standalone volumes to retype, and it is the lookup table used to"},{"line_number":131,"context_line":"  retype volumes attached to a migrating instance. ``dst_type`` is required"},{"line_number":132,"context_line":"  because crossing an AZ boundary always implies a retype, and a retype has"},{"line_number":133,"context_line":"  no meaning without a target type. It is required whenever"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ceea12a_ddf33787","line":130,"range":{"start_line":130,"start_character":13,"end_line":130,"end_character":23},"in_reply_to":"5ae7a563_ef84cd4c","updated":"2026-09-29 17:11:58.000000000","message":"yeah, the correct status is \"available\" IIRC. Needs update","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"086f6c27b0f6c775700f27587c73e7d9bcdbf3ee","unresolved":true,"context_lines":[{"line_number":135,"context_line":"  expresses; the attached-volume case is enforced at run time by the skip"},{"line_number":136,"context_line":"  rule below."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  Selection is purely by volume type. The strategy queries no external"},{"line_number":139,"context_line":"  service and does not consult ``StorageNode.zone``; the operator\u0027s mapping"},{"line_number":140,"context_line":"  *is* the declaration of which type belongs to which zone. This is"},{"line_number":141,"context_line":"  deliberate — it keeps the decision engine\u0027s inputs explicit and auditable."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"``disable_source_nodes``"},{"line_number":144,"context_line":"  Boolean, default ``false``."}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7394f7_da1e4216","line":141,"range":{"start_line":138,"start_character":0,"end_line":141,"end_character":76},"updated":"2026-09-29 15:52:23.000000000","message":"This makes having the volumes_types inside availability_zones confusing IMO. I think this schema seems to say \"migrate the volumes which are in the AZ az-a *and* type ceph-a to be retype to ceph-b\". But as you said, this is actually not filtering by zone, only by types. Otherwise, i think we should apply the filter based on the zone of the StorageNode where the volume is running.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":false,"context_lines":[{"line_number":135,"context_line":"  expresses; the attached-volume case is enforced at run time by the skip"},{"line_number":136,"context_line":"  rule below."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  Selection is purely by volume type. The strategy queries no external"},{"line_number":139,"context_line":"  service and does not consult ``StorageNode.zone``; the operator\u0027s mapping"},{"line_number":140,"context_line":"  *is* the declaration of which type belongs to which zone. This is"},{"line_number":141,"context_line":"  deliberate — it keeps the decision engine\u0027s inputs explicit and auditable."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"``disable_source_nodes``"},{"line_number":144,"context_line":"  Boolean, default ``false``."}],"source_content_type":"text/x-rst","patch_set":1,"id":"6318350f_5ad3eb73","line":141,"range":{"start_line":138,"start_character":0,"end_line":141,"end_character":76},"in_reply_to":"74a4eabd_ff9e4208","updated":"2026-10-19 21:37:29.000000000","message":"Done","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"adeb8dbebe14aa2cd3f2d44e1ad37d5491561eeb","unresolved":true,"context_lines":[{"line_number":135,"context_line":"  expresses; the attached-volume case is enforced at run time by the skip"},{"line_number":136,"context_line":"  rule below."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  Selection is purely by volume type. The strategy queries no external"},{"line_number":139,"context_line":"  service and does not consult ``StorageNode.zone``; the operator\u0027s mapping"},{"line_number":140,"context_line":"  *is* the declaration of which type belongs to which zone. This is"},{"line_number":141,"context_line":"  deliberate — it keeps the decision engine\u0027s inputs explicit and auditable."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"``disable_source_nodes``"},{"line_number":144,"context_line":"  Boolean, default ``false``."}],"source_content_type":"text/x-rst","patch_set":1,"id":"87135e91_892e446b","line":141,"range":{"start_line":138,"start_character":0,"end_line":141,"end_character":76},"in_reply_to":"7581f3c5_3bdc223b","updated":"2026-10-02 17:57:50.000000000","message":"So for now, we keep the storage part similar to current implementation, we would extend to also filter by src_type -\u003e dest_type (which can be combined with scope today)","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"e281f70de334c5b12585f268e90571d292c5c218","unresolved":true,"context_lines":[{"line_number":135,"context_line":"  expresses; the attached-volume case is enforced at run time by the skip"},{"line_number":136,"context_line":"  rule below."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  Selection is purely by volume type. The strategy queries no external"},{"line_number":139,"context_line":"  service and does not consult ``StorageNode.zone``; the operator\u0027s mapping"},{"line_number":140,"context_line":"  *is* the declaration of which type belongs to which zone. This is"},{"line_number":141,"context_line":"  deliberate — it keeps the decision engine\u0027s inputs explicit and auditable."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"``disable_source_nodes``"},{"line_number":144,"context_line":"  Boolean, default ``false``."}],"source_content_type":"text/x-rst","patch_set":1,"id":"74a4eabd_ff9e4208","line":141,"range":{"start_line":138,"start_character":0,"end_line":141,"end_character":76},"in_reply_to":"87135e91_892e446b","updated":"2026-10-09 21:04:37.000000000","message":"ack","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"137046ab661eb7609883e3f39736a4df042749c8","unresolved":true,"context_lines":[{"line_number":135,"context_line":"  expresses; the attached-volume case is enforced at run time by the skip"},{"line_number":136,"context_line":"  rule below."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  Selection is purely by volume type. The strategy queries no external"},{"line_number":139,"context_line":"  service and does not consult ``StorageNode.zone``; the operator\u0027s mapping"},{"line_number":140,"context_line":"  *is* the declaration of which type belongs to which zone. This is"},{"line_number":141,"context_line":"  deliberate — it keeps the decision engine\u0027s inputs explicit and auditable."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"``disable_source_nodes``"},{"line_number":144,"context_line":"  Boolean, default ``false``."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7581f3c5_3bdc223b","line":141,"range":{"start_line":138,"start_character":0,"end_line":141,"end_character":76},"in_reply_to":"df7394f7_da1e4216","updated":"2026-09-29 17:11:58.000000000","message":"Right, for the \"available\" volumes we can filter per availability zone yes, but it would still require the mapping src_type -\u003e dest_type, unless we allow user to provide a fallback/default volume type.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"086f6c27b0f6c775700f27587c73e7d9bcdbf3ee","unresolved":true,"context_lines":[{"line_number":174,"context_line":"``microversion_parse``."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"The ``Migrate`` action gains a ``destination_az`` input parameter, mutually"},{"line_number":177,"context_line":"exclusive with ``destination_node``. Its ``pre_condition`` already guards the"},{"line_number":178,"context_line":"destination-node existence and enabled checks behind ``if"},{"line_number":179,"context_line":"self.destination_node:``, so the AZ path bypasses them naturally."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Volume flow"},{"line_number":182,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"779fc3a0_805b532c","line":179,"range":{"start_line":177,"start_character":36,"end_line":179,"end_character":65},"updated":"2026-09-29 15:52:23.000000000","message":"we should add another check to pre_condition to check that destination_az exists (fail otherwise) and that the instance is not running in it (skip).","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"137046ab661eb7609883e3f39736a4df042749c8","unresolved":true,"context_lines":[{"line_number":174,"context_line":"``microversion_parse``."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"The ``Migrate`` action gains a ``destination_az`` input parameter, mutually"},{"line_number":177,"context_line":"exclusive with ``destination_node``. Its ``pre_condition`` already guards the"},{"line_number":178,"context_line":"destination-node existence and enabled checks behind ``if"},{"line_number":179,"context_line":"self.destination_node:``, so the AZ path bypasses them naturally."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Volume flow"},{"line_number":182,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c56ef142_fd8c83c1","line":179,"range":{"start_line":177,"start_character":36,"end_line":179,"end_character":65},"in_reply_to":"779fc3a0_805b532c","updated":"2026-09-29 17:11:58.000000000","message":"+1 agree","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"adeb8dbebe14aa2cd3f2d44e1ad37d5491561eeb","unresolved":false,"context_lines":[{"line_number":174,"context_line":"``microversion_parse``."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"The ``Migrate`` action gains a ``destination_az`` input parameter, mutually"},{"line_number":177,"context_line":"exclusive with ``destination_node``. Its ``pre_condition`` already guards the"},{"line_number":178,"context_line":"destination-node existence and enabled checks behind ``if"},{"line_number":179,"context_line":"self.destination_node:``, so the AZ path bypasses them naturally."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Volume flow"},{"line_number":182,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4021625c_4ec53c81","line":179,"range":{"start_line":177,"start_character":36,"end_line":179,"end_character":65},"in_reply_to":"c56ef142_fd8c83c1","updated":"2026-10-02 17:57:50.000000000","message":"Added","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"086f6c27b0f6c775700f27587c73e7d9bcdbf3ee","unresolved":true,"context_lines":[{"line_number":181,"context_line":"Volume flow"},{"line_number":182,"context_line":"-----------"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Both paths below emit the existing ``volume_migrate`` action with"},{"line_number":185,"context_line":"``migration_type: \"retype\"``, which routes to ``cinder_helper.retype()`` with"},{"line_number":186,"context_line":"``migration_policy\u003d\"on-demand\"``."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"**Standalone volumes**, gated by the entry\u0027s ``resource_types`` containing"},{"line_number":189,"context_line":"``\"volume\"``: a volume is a target when it has no attachments and its"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3d7ed605_130bc01a","line":186,"range":{"start_line":184,"start_character":0,"end_line":186,"end_character":33},"updated":"2026-09-29 15:52:23.000000000","message":"while this is the usual case, zone_migrate currently supports the option to use the os  os-migrate_volume cinder api (https://docs.openstack.org/api-ref/block-storage/v3/#migrate-a-volume), and i think we can keep it as an option (currently it\u0027s used when a user uses `{\"storage_pools\": [{\"src_pool\": \"pool-a\", \"src_type\": \"type-a\", \"dst_pool\": \"pool-b\"}]]` i.e.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"598241d080a8dd767860c48abaf29230c51c7dbe","unresolved":true,"context_lines":[{"line_number":181,"context_line":"Volume flow"},{"line_number":182,"context_line":"-----------"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Both paths below emit the existing ``volume_migrate`` action with"},{"line_number":185,"context_line":"``migration_type: \"retype\"``, which routes to ``cinder_helper.retype()`` with"},{"line_number":186,"context_line":"``migration_policy\u003d\"on-demand\"``."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"**Standalone volumes**, gated by the entry\u0027s ``resource_types`` containing"},{"line_number":189,"context_line":"``\"volume\"``: a volume is a target when it has no attachments and its"}],"source_content_type":"text/x-rst","patch_set":1,"id":"db856548_a09fbc42","line":186,"range":{"start_line":184,"start_character":0,"end_line":186,"end_character":33},"in_reply_to":"119d5346_db56edb8","updated":"2026-09-30 09:41:51.000000000","message":"The need of a retype is a convention (and maybe good practice, that\u0027d be question for cinder sme) but afaik, cinder supports this topology:\n\n- AZ-1: has a pool `pool-az-1` which has volume_backend_name `multiaz`\n- AZ-2: has a pool `pool-az-2` which has volume_backend_name `multiaz`\n- volume type `volumes` with volume_backend_name `multiaz`\n\nIn that case user would create the volumes with parameters `volume_type\u003dmultiaz` and `availability_zone\u003d[AZ1|AZ2]` so that volumes would be created in the right AZ. In that case, moving data from AZ1 to AZ2 could be done currently with zone_migration config `{\"storage_pools\": [{\"src_pool\": \"pool-az-1\", \"src_type\": \"multiaz\", \"dst_pool\": \"pool-az-2\"}]]`. While this is not the case described by the user, this is a case currently supported in zone_migration and can be useful for some cases.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":false,"context_lines":[{"line_number":181,"context_line":"Volume flow"},{"line_number":182,"context_line":"-----------"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Both paths below emit the existing ``volume_migrate`` action with"},{"line_number":185,"context_line":"``migration_type: \"retype\"``, which routes to ``cinder_helper.retype()`` with"},{"line_number":186,"context_line":"``migration_policy\u003d\"on-demand\"``."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"**Standalone volumes**, gated by the entry\u0027s ``resource_types`` containing"},{"line_number":189,"context_line":"``\"volume\"``: a volume is a target when it has no attachments and its"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fdfe7f5_f7f1ac7c","line":186,"range":{"start_line":184,"start_character":0,"end_line":186,"end_character":33},"in_reply_to":"35784bc0_14ce2380","updated":"2026-10-19 21:37:29.000000000","message":"Closing this thread based on content provided in PS2. Please reopen it if you think that is still relevant.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"adeb8dbebe14aa2cd3f2d44e1ad37d5491561eeb","unresolved":true,"context_lines":[{"line_number":181,"context_line":"Volume flow"},{"line_number":182,"context_line":"-----------"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Both paths below emit the existing ``volume_migrate`` action with"},{"line_number":185,"context_line":"``migration_type: \"retype\"``, which routes to ``cinder_helper.retype()`` with"},{"line_number":186,"context_line":"``migration_policy\u003d\"on-demand\"``."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"**Standalone volumes**, gated by the entry\u0027s ``resource_types`` containing"},{"line_number":189,"context_line":"``\"volume\"``: a volume is a target when it has no attachments and its"}],"source_content_type":"text/x-rst","patch_set":1,"id":"35784bc0_14ce2380","line":186,"range":{"start_line":184,"start_character":0,"end_line":186,"end_character":33},"in_reply_to":"3ad5de15_39829d17","updated":"2026-10-02 17:57:50.000000000","message":"So for now we will stop correlate Compute AZs with storage AZs. It seems more viable to keep pools and types as options for migrating them from different compute zones, when needed.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"137046ab661eb7609883e3f39736a4df042749c8","unresolved":true,"context_lines":[{"line_number":181,"context_line":"Volume flow"},{"line_number":182,"context_line":"-----------"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Both paths below emit the existing ``volume_migrate`` action with"},{"line_number":185,"context_line":"``migration_type: \"retype\"``, which routes to ``cinder_helper.retype()`` with"},{"line_number":186,"context_line":"``migration_policy\u003d\"on-demand\"``."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"**Standalone volumes**, gated by the entry\u0027s ``resource_types`` containing"},{"line_number":189,"context_line":"``\"volume\"``: a volume is a target when it has no attachments and its"}],"source_content_type":"text/x-rst","patch_set":1,"id":"119d5346_db56edb8","line":186,"range":{"start_line":184,"start_character":0,"end_line":186,"end_character":33},"in_reply_to":"3d7ed605_130bc01a","updated":"2026-09-29 17:11:58.000000000","message":"The volume flow in this spec is covering only the AZs move, from an AZ-a to an AZ-b, which for volumes will always be a retype (unless they are already in the destination AZ - but that would not match the src_type:dest_type mapping and will be ignored?)","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"795634ee4a80674f3a0972d3bfabcd255551c394","unresolved":true,"context_lines":[{"line_number":181,"context_line":"Volume flow"},{"line_number":182,"context_line":"-----------"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Both paths below emit the existing ``volume_migrate`` action with"},{"line_number":185,"context_line":"``migration_type: \"retype\"``, which routes to ``cinder_helper.retype()`` with"},{"line_number":186,"context_line":"``migration_policy\u003d\"on-demand\"``."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"**Standalone volumes**, gated by the entry\u0027s ``resource_types`` containing"},{"line_number":189,"context_line":"``\"volume\"``: a volume is a target when it has no attachments and its"}],"source_content_type":"text/x-rst","patch_set":1,"id":"eb2ed4d6_606e301c","line":186,"range":{"start_line":184,"start_character":0,"end_line":186,"end_character":33},"in_reply_to":"db856548_a09fbc42","updated":"2026-09-30 09:56:24.000000000","message":"Correcting myself:\n\nThe need of a retype is a convention (and maybe good practice, that\u0027d be question for cinder sme) but afaik, cinder supports this topology:\n\n- AZ-1: has a pool `pool-az-1` which has volume_backend_name `multiaz`\n- AZ-2: has a pool `pool-az-2` which has volume_backend_name `multiaz`\n- volume type `multiaz` with volume_backend_name `multiaz`\n\nIn that case user would create the volumes with parameters `volume_type\u003dmultiaz` and `availability_zone\u003d[AZ1|AZ2]` so that volumes would be created in the right AZ. In that case, moving data from AZ1 to AZ2 could be done currently with zone_migration config `{\"storage_pools\": [{\"src_pool\": \"pool-az-1\", \"src_type\": \"multiaz\", \"dst_pool\": \"pool-az-2\"}]}`.\nWhile this is not the case described by the user, this is a case currently supported in zone_migration and can be useful for some cases.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"039df4a026370beb929eb7b52d0e576208c2c1d8","unresolved":true,"context_lines":[{"line_number":181,"context_line":"Volume flow"},{"line_number":182,"context_line":"-----------"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Both paths below emit the existing ``volume_migrate`` action with"},{"line_number":185,"context_line":"``migration_type: \"retype\"``, which routes to ``cinder_helper.retype()`` with"},{"line_number":186,"context_line":"``migration_policy\u003d\"on-demand\"``."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"**Standalone volumes**, gated by the entry\u0027s ``resource_types`` containing"},{"line_number":189,"context_line":"``\"volume\"``: a volume is a target when it has no attachments and its"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ad5de15_39829d17","line":186,"range":{"start_line":184,"start_character":0,"end_line":186,"end_character":33},"in_reply_to":"eb2ed4d6_606e301c","updated":"2026-09-30 12:19:11.000000000","message":"I think that you are correct, the current evaluated scenario is that cross-AZ would always trigger a rytype, but in case that the same volume-type is used in multiple AZs it may require just the move.\nFor this scenarios would be good to rely in the src_pool/dest_pool.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"4f879a777d2dd912827f1b41b2e5c8e9b216139b","unresolved":true,"context_lines":[{"line_number":185,"context_line":"``migration_type: \"retype\"``, which routes to ``cinder_helper.retype()`` with"},{"line_number":186,"context_line":"``migration_policy\u003d\"on-demand\"``."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"**Standalone volumes**, gated by the entry\u0027s ``resource_types`` containing"},{"line_number":189,"context_line":"``\"volume\"``: a volume is a target when it has no attachments and its"},{"line_number":190,"context_line":"``volume_type`` equals some ``src_type`` in that entry\u0027s ``volume_types``."},{"line_number":191,"context_line":"Emit a retype to the mapped ``dst_type``. Restricting this pass to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bcad3e70_5b99619e","line":188,"updated":"2026-10-01 15:15:38.000000000","message":"I don\u0027t have any experience working with AZs, just want to make sure my understanding is correct. This assumes that Cinder\u0027s and Nova\u0027s AZ names are equal and match `src_az` right? I\u0027m not sure that is guaranteed, if not we should document well this assumption","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":false,"context_lines":[{"line_number":185,"context_line":"``migration_type: \"retype\"``, which routes to ``cinder_helper.retype()`` with"},{"line_number":186,"context_line":"``migration_policy\u003d\"on-demand\"``."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"**Standalone volumes**, gated by the entry\u0027s ``resource_types`` containing"},{"line_number":189,"context_line":"``\"volume\"``: a volume is a target when it has no attachments and its"},{"line_number":190,"context_line":"``volume_type`` equals some ``src_type`` in that entry\u0027s ``volume_types``."},{"line_number":191,"context_line":"Emit a retype to the mapped ``dst_type``. Restricting this pass to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4e5d3e90_c624fe6f","line":188,"in_reply_to":"6d8d198e_3fc4fef1","updated":"2026-10-19 21:37:29.000000000","message":"Done","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"282700bdb3b7a5286ece1974a914a8b42f5523fd","unresolved":true,"context_lines":[{"line_number":185,"context_line":"``migration_type: \"retype\"``, which routes to ``cinder_helper.retype()`` with"},{"line_number":186,"context_line":"``migration_policy\u003d\"on-demand\"``."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"**Standalone volumes**, gated by the entry\u0027s ``resource_types`` containing"},{"line_number":189,"context_line":"``\"volume\"``: a volume is a target when it has no attachments and its"},{"line_number":190,"context_line":"``volume_type`` equals some ``src_type`` in that entry\u0027s ``volume_types``."},{"line_number":191,"context_line":"Emit a retype to the mapped ``dst_type``. Restricting this pass to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6d8d198e_3fc4fef1","line":188,"in_reply_to":"bcad3e70_5b99619e","updated":"2026-10-01 17:50:39.000000000","message":"Not really, it would still rely on parameters provided by user: src_pool, src_type and migrate them, without matching any Cinder AZ I think.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"086f6c27b0f6c775700f27587c73e7d9bcdbf3ee","unresolved":true,"context_lines":[{"line_number":194,"context_line":"that is not moving — either because it lives outside the drained zone or"},{"line_number":195,"context_line":"because it was skipped by the rule below."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"**Volumes attached to a migrating instance**: for each instance selected"},{"line_number":198,"context_line":"for an AZ-targeted move, find its attached volumes and retype each to the"},{"line_number":199,"context_line":"``dst_type`` mapped by the same AZ entry that selected the instance."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"The cluster data model has no instance-to-volume edge. The only link is"},{"line_number":202,"context_line":"``Volume.attachments[].server_id``, and the collector prunes each attachment"}],"source_content_type":"text/x-rst","patch_set":1,"id":"39376410_39ca820a","line":199,"range":{"start_line":197,"start_character":0,"end_line":199,"end_character":68},"updated":"2026-09-29 15:52:23.000000000","message":"As mentioned before, i don\u0027t think there is a reason to *always* force volume retypes for attached instances. That should be up to the cluster admin.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"adeb8dbebe14aa2cd3f2d44e1ad37d5491561eeb","unresolved":true,"context_lines":[{"line_number":194,"context_line":"that is not moving — either because it lives outside the drained zone or"},{"line_number":195,"context_line":"because it was skipped by the rule below."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"**Volumes attached to a migrating instance**: for each instance selected"},{"line_number":198,"context_line":"for an AZ-targeted move, find its attached volumes and retype each to the"},{"line_number":199,"context_line":"``dst_type`` mapped by the same AZ entry that selected the instance."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"The cluster data model has no instance-to-volume edge. The only link is"},{"line_number":202,"context_line":"``Volume.attachments[].server_id``, and the collector prunes each attachment"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2e6e64f0_cd78fd23","line":199,"range":{"start_line":197,"start_character":0,"end_line":199,"end_character":68},"in_reply_to":"1ce16fc9_1e9dc92a","updated":"2026-10-02 17:57:50.000000000","message":"That was the initial assumption based on the use case provided, where volumes types would be mapped to a single AZ, an the retype would: update their AZ and move to another compatible backend. I am removing this part and we would keep the operator\u0027s driven migration between pools and retype based on input parameters.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"598241d080a8dd767860c48abaf29230c51c7dbe","unresolved":true,"context_lines":[{"line_number":194,"context_line":"that is not moving — either because it lives outside the drained zone or"},{"line_number":195,"context_line":"because it was skipped by the rule below."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"**Volumes attached to a migrating instance**: for each instance selected"},{"line_number":198,"context_line":"for an AZ-targeted move, find its attached volumes and retype each to the"},{"line_number":199,"context_line":"``dst_type`` mapped by the same AZ entry that selected the instance."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"The cluster data model has no instance-to-volume edge. The only link is"},{"line_number":202,"context_line":"``Volume.attachments[].server_id``, and the collector prunes each attachment"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ce16fc9_1e9dc92a","line":199,"range":{"start_line":197,"start_character":0,"end_line":199,"end_character":68},"in_reply_to":"1d4ee2d1_a0cba4e2","updated":"2026-09-30 09:41:51.000000000","message":"see my previous comment for potential non-retype cases (that we support today).","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":false,"context_lines":[{"line_number":194,"context_line":"that is not moving — either because it lives outside the drained zone or"},{"line_number":195,"context_line":"because it was skipped by the rule below."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"**Volumes attached to a migrating instance**: for each instance selected"},{"line_number":198,"context_line":"for an AZ-targeted move, find its attached volumes and retype each to the"},{"line_number":199,"context_line":"``dst_type`` mapped by the same AZ entry that selected the instance."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"The cluster data model has no instance-to-volume edge. The only link is"},{"line_number":202,"context_line":"``Volume.attachments[].server_id``, and the collector prunes each attachment"}],"source_content_type":"text/x-rst","patch_set":1,"id":"336b3ef0_23bf125e","line":199,"range":{"start_line":197,"start_character":0,"end_line":199,"end_character":68},"in_reply_to":"2e6e64f0_cd78fd23","updated":"2026-10-19 21:37:29.000000000","message":"Closing this thread since we already agree in the approach to follow.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"137046ab661eb7609883e3f39736a4df042749c8","unresolved":true,"context_lines":[{"line_number":194,"context_line":"that is not moving — either because it lives outside the drained zone or"},{"line_number":195,"context_line":"because it was skipped by the rule below."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"**Volumes attached to a migrating instance**: for each instance selected"},{"line_number":198,"context_line":"for an AZ-targeted move, find its attached volumes and retype each to the"},{"line_number":199,"context_line":"``dst_type`` mapped by the same AZ entry that selected the instance."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"The cluster data model has no instance-to-volume edge. The only link is"},{"line_number":202,"context_line":"``Volume.attachments[].server_id``, and the collector prunes each attachment"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1d4ee2d1_a0cba4e2","line":199,"range":{"start_line":197,"start_character":0,"end_line":199,"end_character":68},"in_reply_to":"39376410_39ca820a","updated":"2026-09-29 17:11:58.000000000","message":"If the volume is going to be moved together with the instance, it must be a retype. I think htat you are mentioning the case that volumes stay in their original backend/pool/zone, but this is not covered here.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"4f879a777d2dd912827f1b41b2e5c8e9b216139b","unresolved":true,"context_lines":[{"line_number":217,"context_line":"Disabling source nodes"},{"line_number":218,"context_line":"----------------------"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"When ``disable_source_nodes`` is true, emit one"},{"line_number":221,"context_line":"``change_nova_service_state`` action per source node, ordered before the"},{"line_number":222,"context_line":"migrations, with the same parameters ``host_maintenance`` already uses::"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6e4826_bd30f972","line":220,"updated":"2026-10-01 15:15:38.000000000","message":"I think we might need a bit more detail here. My understanding of the current version is that all the nodes which have at least one instance being migrated will be migrated, correct?\n\nThat seems right to me for the no AZ use case, but when draining an AZ, should we disable all the nodes belonging to it? For example, when draining an AZ with 3 nodes that only has instances in nodes 1 and 2, should we also disable node 3?","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"a16771b88453a05fd0f1403b7f3795dc25ad1536","unresolved":true,"context_lines":[{"line_number":217,"context_line":"Disabling source nodes"},{"line_number":218,"context_line":"----------------------"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"When ``disable_source_nodes`` is true, emit one"},{"line_number":221,"context_line":"``change_nova_service_state`` action per source node, ordered before the"},{"line_number":222,"context_line":"migrations, with the same parameters ``host_maintenance`` already uses::"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"2f791506_ad443ff0","line":220,"in_reply_to":"29714c77_d56d7d7f","updated":"2026-10-02 09:39:15.000000000","message":"There is a detail to be considered wrt disabling nodes. The zone_migration strategy has parameters to set the max number of actions executed in an audit execution. That means, that not all the hosts may be drained in an audit execution. i.e. we have a cluster with 10 nodes and 200 vms, but only 20 vms are migrated from 4 hosts. Which hosts should be disabled in that run? all of them (10) or only the ones where the 20 vms were running (4)?. I\u0027m not sure tbh, but i think it\u0027s fair to consider.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"adeb8dbebe14aa2cd3f2d44e1ad37d5491561eeb","unresolved":true,"context_lines":[{"line_number":217,"context_line":"Disabling source nodes"},{"line_number":218,"context_line":"----------------------"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"When ``disable_source_nodes`` is true, emit one"},{"line_number":221,"context_line":"``change_nova_service_state`` action per source node, ordered before the"},{"line_number":222,"context_line":"migrations, with the same parameters ``host_maintenance`` already uses::"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"cf59c2e7_f0c06a6e","line":220,"in_reply_to":"2f791506_ad443ff0","updated":"2026-10-02 17:57:50.000000000","message":"The idea behind the source disabling nodes is that no new instances would be scheduled to these nodes, since they are being drained. So in theory this would be the step 0 for any az-drain, in all nodes, no? I would still keep disabling all source nodes that belong to the src_az. Operators can still do: filter nodes using audit scope (if they plan to drain a set of nodes first) or skip disabling a node in the resulted action plan. By having alternatives to not disable the node makes me think that is better to consider all. The opposite is not possible, unless the operator uses another strategy just to disable the, then, skipped nodes.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b0a040dab5818cdf0d1ed7629552e8709e523f24","unresolved":true,"context_lines":[{"line_number":217,"context_line":"Disabling source nodes"},{"line_number":218,"context_line":"----------------------"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"When ``disable_source_nodes`` is true, emit one"},{"line_number":221,"context_line":"``change_nova_service_state`` action per source node, ordered before the"},{"line_number":222,"context_line":"migrations, with the same parameters ``host_maintenance`` already uses::"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"8333afdd_83208163","line":220,"in_reply_to":"4d561768_782c3e97","updated":"2026-10-30 15:14:52.000000000","message":"Ack, that looks like a good approach.\nI alreadyu started the work on passing -1 as unlimited to the existing parameters:\nhttps://review.opendev.org/c/openstack/watcher/+/1012707","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":true,"context_lines":[{"line_number":217,"context_line":"Disabling source nodes"},{"line_number":218,"context_line":"----------------------"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"When ``disable_source_nodes`` is true, emit one"},{"line_number":221,"context_line":"``change_nova_service_state`` action per source node, ordered before the"},{"line_number":222,"context_line":"migrations, with the same parameters ``host_maintenance`` already uses::"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"e409c152_6038e833","line":220,"in_reply_to":"598c071c_8cad2d1e","updated":"2026-10-19 21:37:29.000000000","message":"There is no intention of continuing adding more maximum number of specific actions or to include disabling nodes to the existing one. To continue with zone_migration this spec will propose deprecating these parameters and changing their defaults as also providing better documentation around them.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":217,"context_line":"Disabling source nodes"},{"line_number":218,"context_line":"----------------------"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"When ``disable_source_nodes`` is true, emit one"},{"line_number":221,"context_line":"``change_nova_service_state`` action per source node, ordered before the"},{"line_number":222,"context_line":"migrations, with the same parameters ``host_maintenance`` already uses::"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"8ed71dcc_3b115685","line":220,"in_reply_to":"8333afdd_83208163","updated":"2026-11-03 13:27:47.000000000","message":"Done","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"7d31f265858318c5cd3e7ed1e7b31f2ce2e6f3e4","unresolved":true,"context_lines":[{"line_number":217,"context_line":"Disabling source nodes"},{"line_number":218,"context_line":"----------------------"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"When ``disable_source_nodes`` is true, emit one"},{"line_number":221,"context_line":"``change_nova_service_state`` action per source node, ordered before the"},{"line_number":222,"context_line":"migrations, with the same parameters ``host_maintenance`` already uses::"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"598c071c_8cad2d1e","line":220,"in_reply_to":"cf59c2e7_f0c06a6e","updated":"2026-10-06 14:26:08.000000000","message":"I think we should disable all nodes for all AZs in the input, even for those that would not be migrated in the current action plan. The limiting option makes most sense in a continuous audit, and in that context disabling all the relevant nodes makes sense (and I also think it should not count towards any of the limits)","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"282700bdb3b7a5286ece1974a914a8b42f5523fd","unresolved":true,"context_lines":[{"line_number":217,"context_line":"Disabling source nodes"},{"line_number":218,"context_line":"----------------------"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"When ``disable_source_nodes`` is true, emit one"},{"line_number":221,"context_line":"``change_nova_service_state`` action per source node, ordered before the"},{"line_number":222,"context_line":"migrations, with the same parameters ``host_maintenance`` already uses::"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"29714c77_d56d7d7f","line":220,"in_reply_to":"da6e4826_bd30f972","updated":"2026-10-01 17:50:39.000000000","message":"I do think so, if the idea is to drain the AZ, all nodes should be disabled there, including the empty ones, so no more instances are scheduled in any. Note that we also have some tools that help us here: audit scope (to exclude nodes) and Skip Actions, which gives operators more flexibility.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9242e8924af520be65b667b63aa6e11b0c35cd32","unresolved":true,"context_lines":[{"line_number":217,"context_line":"Disabling source nodes"},{"line_number":218,"context_line":"----------------------"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"When ``disable_source_nodes`` is true, emit one"},{"line_number":221,"context_line":"``change_nova_service_state`` action per source node, ordered before the"},{"line_number":222,"context_line":"migrations, with the same parameters ``host_maintenance`` already uses::"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"4d561768_782c3e97","line":220,"in_reply_to":"e409c152_6038e833","updated":"2026-10-29 19:20:05.000000000","message":"right if we decied to create a new stragey instead of extend the exsitn gone i woudl specificly explode intoducing limit on the action form the parmater of that new stragy\n\ni chated to doug sepreatly and basicly suggested we do this in 3 phases.\n\nfirst add teh ablity to pass -1 for unlimited mimicing the keyton qutoa behvior\nsecond im plement https://review.opendev.org/c/openstack/watcher-specs/+/1012696\ni have not review that bu thtat alfredos spec for how we can fix upstrades\nthird once that is in place we can change the default wihtout impacting existing audit that relied on the limits\n\nthat get use to the point where you can use a onesot audit to drain an az instead of requriing a continus audit to do it.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"086f6c27b0f6c775700f27587c73e7d9bcdbf3ee","unresolved":true,"context_lines":[{"line_number":243,"context_line":"into a different zone, and Nova rejects it. The pin must therefore be cleared"},{"line_number":244,"context_line":"before the migrate and set after it, using Nova\u0027s unpin-az API."},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"Since the weight planner layers strictly by action *type*, a single type"},{"line_number":247,"context_line":"cannot sit both before and after ``migrate``. This needs two action types:"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"``unpin_instance_az``"}],"source_content_type":"text/x-rst","patch_set":1,"id":"72bc91e8_21f47f96","line":246,"range":{"start_line":246,"start_character":0,"end_line":246,"end_character":2},"updated":"2026-09-29 15:52:23.000000000","message":"ftr, i was planning to add the option to set the order based in action parameter in addition to type in https://review.opendev.org/c/openstack/watcher-specs/+/994607 but there is not point in depending on it.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":243,"context_line":"into a different zone, and Nova rejects it. The pin must therefore be cleared"},{"line_number":244,"context_line":"before the migrate and set after it, using Nova\u0027s unpin-az API."},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"Since the weight planner layers strictly by action *type*, a single type"},{"line_number":247,"context_line":"cannot sit both before and after ``migrate``. This needs two action types:"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"``unpin_instance_az``"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bcdb71ad_d66c92da","line":246,"range":{"start_line":246,"start_character":0,"end_line":246,"end_character":2},"in_reply_to":"4d7212e5_c36a2cc2","updated":"2026-11-03 13:27:47.000000000","message":"Done","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"137046ab661eb7609883e3f39736a4df042749c8","unresolved":true,"context_lines":[{"line_number":243,"context_line":"into a different zone, and Nova rejects it. The pin must therefore be cleared"},{"line_number":244,"context_line":"before the migrate and set after it, using Nova\u0027s unpin-az API."},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"Since the weight planner layers strictly by action *type*, a single type"},{"line_number":247,"context_line":"cannot sit both before and after ``migrate``. This needs two action types:"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"``unpin_instance_az``"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b35d90e6_78cc91e2","line":246,"range":{"start_line":246,"start_character":0,"end_line":246,"end_character":2},"in_reply_to":"72bc91e8_21f47f96","updated":"2026-09-29 17:11:58.000000000","message":"Yeah, the planner piece still needs more brainstorm and we shold sync about that. This is a simple extension of the existing behavior.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"adeb8dbebe14aa2cd3f2d44e1ad37d5491561eeb","unresolved":true,"context_lines":[{"line_number":243,"context_line":"into a different zone, and Nova rejects it. The pin must therefore be cleared"},{"line_number":244,"context_line":"before the migrate and set after it, using Nova\u0027s unpin-az API."},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"Since the weight planner layers strictly by action *type*, a single type"},{"line_number":247,"context_line":"cannot sit both before and after ``migrate``. This needs two action types:"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"``unpin_instance_az``"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4d7212e5_c36a2cc2","line":246,"range":{"start_line":246,"start_character":0,"end_line":246,"end_character":2},"in_reply_to":"b35d90e6_78cc91e2","updated":"2026-10-02 17:57:50.000000000","message":"Note that by adding pin and unpin to the existing Migrate action would not touch anything on planner side. This will be the next approach proposed here.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"086f6c27b0f6c775700f27587c73e7d9bcdbf3ee","unresolved":true,"context_lines":[{"line_number":246,"context_line":"Since the weight planner layers strictly by action *type*, a single type"},{"line_number":247,"context_line":"cannot sit both before and after ``migrate``. This needs two action types:"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"``unpin_instance_az``"},{"line_number":250,"context_line":"  Parameters ``{resource_id, resource_name}``; clears the pin."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"``pin_instance_az``"},{"line_number":253,"context_line":"  Parameters ``{resource_id, resource_name, availability_zone}``; sets the"},{"line_number":254,"context_line":"  pin to the destination zone."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"Both live in one new module sharing a base class. ``revert()`` is"},{"line_number":257,"context_line":"unsupported; ``pre_condition`` skips when the pin already holds the target"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2fe18cdb_f463b669","line":254,"range":{"start_line":249,"start_character":0,"end_line":254,"end_character":30},"updated":"2026-09-29 15:52:23.000000000","message":"May we include this as part of the migrate actions when `destination_az` is passed instead of adding new action types? I think migrations are the only use case for unpin/pìn.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"137046ab661eb7609883e3f39736a4df042749c8","unresolved":true,"context_lines":[{"line_number":246,"context_line":"Since the weight planner layers strictly by action *type*, a single type"},{"line_number":247,"context_line":"cannot sit both before and after ``migrate``. This needs two action types:"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"``unpin_instance_az``"},{"line_number":250,"context_line":"  Parameters ``{resource_id, resource_name}``; clears the pin."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"``pin_instance_az``"},{"line_number":253,"context_line":"  Parameters ``{resource_id, resource_name, availability_zone}``; sets the"},{"line_number":254,"context_line":"  pin to the destination zone."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"Both live in one new module sharing a base class. ``revert()`` is"},{"line_number":257,"context_line":"unsupported; ``pre_condition`` skips when the pin already holds the target"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8d9e630f_d648ad15","line":254,"range":{"start_line":249,"start_character":0,"end_line":254,"end_character":30},"in_reply_to":"2fe18cdb_f463b669","updated":"2026-09-29 17:11:58.000000000","message":"I thought about that too! I was considering make this part of the Migrate Action too + do the rollback of the unpin in case the migration fails. In the current proposal, if the migration fails, the instance will remain unpinned.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"adeb8dbebe14aa2cd3f2d44e1ad37d5491561eeb","unresolved":true,"context_lines":[{"line_number":246,"context_line":"Since the weight planner layers strictly by action *type*, a single type"},{"line_number":247,"context_line":"cannot sit both before and after ``migrate``. This needs two action types:"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"``unpin_instance_az``"},{"line_number":250,"context_line":"  Parameters ``{resource_id, resource_name}``; clears the pin."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"``pin_instance_az``"},{"line_number":253,"context_line":"  Parameters ``{resource_id, resource_name, availability_zone}``; sets the"},{"line_number":254,"context_line":"  pin to the destination zone."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"Both live in one new module sharing a base class. ``revert()`` is"},{"line_number":257,"context_line":"unsupported; ``pre_condition`` skips when the pin already holds the target"}],"source_content_type":"text/x-rst","patch_set":1,"id":"abffff14_85833e85","line":254,"range":{"start_line":249,"start_character":0,"end_line":254,"end_character":30},"in_reply_to":"7bef2366_1ae6078f","updated":"2026-10-02 17:57:50.000000000","message":"It adds more logic to a single action, and doesn\u0027t allow strategies to only use the pin/unpin (not a requirement for now). But I also think that it would increase the number of actions and make it harder for users to skip and correlated with a specific migration. There are pros and cons in either proposals. I would stick with all inside Migrate for now, not because we would rollback the pin, but because they should be executed together. If a planner order the actions to unpin all instances, then start migrating them and one fails, we will end up in a worst scenario: lots of unpinned instances, some instances migrated but not pinned again..\nThe rollback of a pin, after a migrations fails is also questionable, since the operator may want to force/fix the migration instead of get it pinned again, or we may even fail to unpin depending on the current state of the instance..","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"598241d080a8dd767860c48abaf29230c51c7dbe","unresolved":true,"context_lines":[{"line_number":246,"context_line":"Since the weight planner layers strictly by action *type*, a single type"},{"line_number":247,"context_line":"cannot sit both before and after ``migrate``. This needs two action types:"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"``unpin_instance_az``"},{"line_number":250,"context_line":"  Parameters ``{resource_id, resource_name}``; clears the pin."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"``pin_instance_az``"},{"line_number":253,"context_line":"  Parameters ``{resource_id, resource_name, availability_zone}``; sets the"},{"line_number":254,"context_line":"  pin to the destination zone."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"Both live in one new module sharing a base class. ``revert()`` is"},{"line_number":257,"context_line":"unsupported; ``pre_condition`` skips when the pin already holds the target"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7bef2366_1ae6078f","line":254,"range":{"start_line":249,"start_character":0,"end_line":254,"end_character":30},"in_reply_to":"8d9e630f_d648ad15","updated":"2026-09-30 09:41:51.000000000","message":"actually, that seems a valid reason to incorporate in the migrate action, right?","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":246,"context_line":"Since the weight planner layers strictly by action *type*, a single type"},{"line_number":247,"context_line":"cannot sit both before and after ``migrate``. This needs two action types:"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"``unpin_instance_az``"},{"line_number":250,"context_line":"  Parameters ``{resource_id, resource_name}``; clears the pin."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"``pin_instance_az``"},{"line_number":253,"context_line":"  Parameters ``{resource_id, resource_name, availability_zone}``; sets the"},{"line_number":254,"context_line":"  pin to the destination zone."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"Both live in one new module sharing a base class. ``revert()`` is"},{"line_number":257,"context_line":"unsupported; ``pre_condition`` skips when the pin already holds the target"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b2eafd53_ad3f4219","line":254,"range":{"start_line":249,"start_character":0,"end_line":254,"end_character":30},"in_reply_to":"abffff14_85833e85","updated":"2026-11-03 13:27:47.000000000","message":"Done","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"086f6c27b0f6c775700f27587c73e7d9bcdbf3ee","unresolved":true,"context_lines":[{"line_number":394,"context_line":"placement constraing that could produce migrations that are likely to fail at"},{"line_number":395,"context_line":"execution time."},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"**Keep ``availability_zones`` but reuse the existing parameters for the"},{"line_number":398,"context_line":"rest.** ``storage_pools`` would carry the ``src_type``/``dst_type`` mapping"},{"line_number":399,"context_line":"it already accepts, and ``compute_nodes`` would narrow the drain to an"},{"line_number":400,"context_line":"include or exclude list of nodes within the source zone, so no nested"},{"line_number":401,"context_line":"``volume_types`` or ``resource_types`` would be needed. Rejected on"},{"line_number":402,"context_line":"complexity: the allowed combinations across the three lists become the"},{"line_number":403,"context_line":"interface, with nothing tying a given type mapping to a given zone pair, and"},{"line_number":404,"context_line":"each combination is another precedence rule to implement and test."},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"**Derive the volume type mapping from Cinder.** Watcher could inspect volume"},{"line_number":407,"context_line":"types and their backends to work out which type belongs to which zone. This"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2ece7a09_640b373d","line":404,"range":{"start_line":397,"start_character":0,"end_line":404,"end_character":66},"updated":"2026-09-29 15:52:23.000000000","message":"I don\u0027t think this adds complexity *if* we untied instance and volume migrations (see my comments before), and acutally allows more cases that we currently support.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"adeb8dbebe14aa2cd3f2d44e1ad37d5491561eeb","unresolved":false,"context_lines":[{"line_number":394,"context_line":"placement constraing that could produce migrations that are likely to fail at"},{"line_number":395,"context_line":"execution time."},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"**Keep ``availability_zones`` but reuse the existing parameters for the"},{"line_number":398,"context_line":"rest.** ``storage_pools`` would carry the ``src_type``/``dst_type`` mapping"},{"line_number":399,"context_line":"it already accepts, and ``compute_nodes`` would narrow the drain to an"},{"line_number":400,"context_line":"include or exclude list of nodes within the source zone, so no nested"},{"line_number":401,"context_line":"``volume_types`` or ``resource_types`` would be needed. Rejected on"},{"line_number":402,"context_line":"complexity: the allowed combinations across the three lists become the"},{"line_number":403,"context_line":"interface, with nothing tying a given type mapping to a given zone pair, and"},{"line_number":404,"context_line":"each combination is another precedence rule to implement and test."},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"**Derive the volume type mapping from Cinder.** Watcher could inspect volume"},{"line_number":407,"context_line":"types and their backends to work out which type belongs to which zone. This"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ccf1c2bf_0951dd1d","line":404,"range":{"start_line":397,"start_character":0,"end_line":404,"end_character":66},"in_reply_to":"2211fe05_b6920ea7","updated":"2026-10-02 17:57:50.000000000","message":"this is now removed.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"137046ab661eb7609883e3f39736a4df042749c8","unresolved":true,"context_lines":[{"line_number":394,"context_line":"placement constraing that could produce migrations that are likely to fail at"},{"line_number":395,"context_line":"execution time."},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"**Keep ``availability_zones`` but reuse the existing parameters for the"},{"line_number":398,"context_line":"rest.** ``storage_pools`` would carry the ``src_type``/``dst_type`` mapping"},{"line_number":399,"context_line":"it already accepts, and ``compute_nodes`` would narrow the drain to an"},{"line_number":400,"context_line":"include or exclude list of nodes within the source zone, so no nested"},{"line_number":401,"context_line":"``volume_types`` or ``resource_types`` would be needed. Rejected on"},{"line_number":402,"context_line":"complexity: the allowed combinations across the three lists become the"},{"line_number":403,"context_line":"interface, with nothing tying a given type mapping to a given zone pair, and"},{"line_number":404,"context_line":"each combination is another precedence rule to implement and test."},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"**Derive the volume type mapping from Cinder.** Watcher could inspect volume"},{"line_number":407,"context_line":"types and their backends to work out which type belongs to which zone. This"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2211fe05_b6920ea7","line":404,"range":{"start_line":397,"start_character":0,"end_line":404,"end_character":66},"in_reply_to":"2ece7a09_640b373d","updated":"2026-09-29 17:11:58.000000000","message":"Yeah, I already answered that there.","commit_id":"f46153f34e924f5b2bc4ffc866d54d00b5e141b5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"8eb612ec2bd1bc8eb82275e6f4ec9c64f1c1e74e","unresolved":true,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/watcher/+spec/zone-migration-az-drain"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Operators performing maintenance on a whole compute availability zone need to"},{"line_number":14,"context_line":"move every workload out of it — the instances, and the volumes those instances"},{"line_number":15,"context_line":"depend on — before the zone can be taken down. Watcher\u0027s ``zone_migration``"},{"line_number":16,"context_line":"strategy already drains operator-named compute nodes and storage pools, but it"},{"line_number":17,"context_line":"has no concept of a Nova availability zone: the operator must enumerate every"},{"line_number":18,"context_line":"source host by hand, and nothing keeps the instances inside the intended"}],"source_content_type":"text/x-rst","patch_set":2,"id":"12fd544e_629639cb","line":15,"range":{"start_line":14,"start_character":47,"end_line":15,"end_character":9},"updated":"2026-10-07 16:19:29.000000000","message":"Actually, i think this should be \"the instances and the volumes\".","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"82de505c9a36eadc8d771ce197bb711c810a8b85","unresolved":true,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/watcher/+spec/zone-migration-az-drain"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Operators performing maintenance on a whole compute availability zone need to"},{"line_number":14,"context_line":"move every workload out of it — the instances, and the volumes those instances"},{"line_number":15,"context_line":"depend on — before the zone can be taken down. Watcher\u0027s ``zone_migration``"},{"line_number":16,"context_line":"strategy already drains operator-named compute nodes and storage pools, but it"},{"line_number":17,"context_line":"has no concept of a Nova availability zone: the operator must enumerate every"},{"line_number":18,"context_line":"source host by hand, and nothing keeps the instances inside the intended"}],"source_content_type":"text/x-rst","patch_set":2,"id":"16bcffe8_ff0c816f","line":15,"range":{"start_line":14,"start_character":47,"end_line":15,"end_character":9},"in_reply_to":"12fd544e_629639cb","updated":"2026-10-09 00:15:44.000000000","message":"FWIW: I\u0027m fine with that change.","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/watcher/+spec/zone-migration-az-drain"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Operators performing maintenance on a whole compute availability zone need to"},{"line_number":14,"context_line":"move every workload out of it — the instances, and the volumes those instances"},{"line_number":15,"context_line":"depend on — before the zone can be taken down. Watcher\u0027s ``zone_migration``"},{"line_number":16,"context_line":"strategy already drains operator-named compute nodes and storage pools, but it"},{"line_number":17,"context_line":"has no concept of a Nova availability zone: the operator must enumerate every"},{"line_number":18,"context_line":"source host by hand, and nothing keeps the instances inside the intended"}],"source_content_type":"text/x-rst","patch_set":2,"id":"950e163c_0f6294db","line":15,"range":{"start_line":14,"start_character":47,"end_line":15,"end_character":9},"in_reply_to":"16bcffe8_ff0c816f","updated":"2026-10-19 21:37:29.000000000","message":"Done","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"82de505c9a36eadc8d771ce197bb711c810a8b85","unresolved":true,"context_lines":[{"line_number":46,"context_line":"are Nova AZs throughout. Watcher reads no Cinder AZ, correlates none,"},{"line_number":47,"context_line":"and never derives a volume destination from a compute zone. Where"},{"line_number":48,"context_line":"volumes go is stated by the operator, by pool or by volume type, which is how"},{"line_number":49,"context_line":"``zone_migration`` already works today."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"No compute AZ awareness"},{"line_number":52,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e3818e45_293cc69d","line":49,"updated":"2026-10-09 00:15:44.000000000","message":"The above change (lines 39-49) LGTM.","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":false,"context_lines":[{"line_number":46,"context_line":"are Nova AZs throughout. Watcher reads no Cinder AZ, correlates none,"},{"line_number":47,"context_line":"and never derives a volume destination from a compute zone. Where"},{"line_number":48,"context_line":"volumes go is stated by the operator, by pool or by volume type, which is how"},{"line_number":49,"context_line":"``zone_migration`` already works today."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"No compute AZ awareness"},{"line_number":52,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"75baa333_2e7cf9c8","line":49,"in_reply_to":"e3818e45_293cc69d","updated":"2026-10-19 21:37:29.000000000","message":"Acknowledged","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"82de505c9a36eadc8d771ce197bb711c810a8b85","unresolved":true,"context_lines":[{"line_number":59,"context_line":"* The zone of an instance\u0027s host is only half the picture. Nova also exposes"},{"line_number":60,"context_line":"  ``pinned_availability_zone``, the zone constraint the instance itself"},{"line_number":61,"context_line":"  can carries. ``Instance.pinned_az`` exists in the compute model but is"},{"line_number":62,"context_line":"  populated only when extended attributes are collected."},{"line_number":63,"context_line":"* The storage model carries ``StorageNode.zone``, populated from"},{"line_number":64,"context_line":"  ``StorageService.availability_zone``. That is a Cinder AZ; this spec does"},{"line_number":65,"context_line":"  not use it."}],"source_content_type":"text/x-rst","patch_set":2,"id":"2234e608_0f042e04","line":62,"updated":"2026-10-09 00:15:44.000000000","message":"If you schedule a VM like this, then it\u0027s pinned AZ will be set. So, if you have \u003e1 AZ (like the user of the outcome of this spec), it\u0027s likely that most VMs will have this parameter set.\n\n`openstack server create --availability-zone AZ1 ... `","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* The zone of an instance\u0027s host is only half the picture. Nova also exposes"},{"line_number":60,"context_line":"  ``pinned_availability_zone``, the zone constraint the instance itself"},{"line_number":61,"context_line":"  can carries. ``Instance.pinned_az`` exists in the compute model but is"},{"line_number":62,"context_line":"  populated only when extended attributes are collected."},{"line_number":63,"context_line":"* The storage model carries ``StorageNode.zone``, populated from"},{"line_number":64,"context_line":"  ``StorageService.availability_zone``. That is a Cinder AZ; this spec does"},{"line_number":65,"context_line":"  not use it."}],"source_content_type":"text/x-rst","patch_set":2,"id":"30f3bdd1_52ce03ac","line":62,"in_reply_to":"2234e608_0f042e04","updated":"2026-10-19 21:37:29.000000000","message":"Ack, the spec will cover the pinned instances and provide de unpin - migrate - pin workflow.","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"82de505c9a36eadc8d771ce197bb711c810a8b85","unresolved":true,"context_lines":[{"line_number":79,"context_line":"  they are."},{"line_number":80,"context_line":"* **Deployer** moves only the instances, leaving their volumes untouched,"},{"line_number":81,"context_line":"  because the storage behind them is reachable from both compute zones."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Proposed Change"},{"line_number":84,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"22ba328b_77da265e","line":82,"updated":"2026-10-09 00:15:44.000000000","message":"LGTM","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":false,"context_lines":[{"line_number":79,"context_line":"  they are."},{"line_number":80,"context_line":"* **Deployer** moves only the instances, leaving their volumes untouched,"},{"line_number":81,"context_line":"  because the storage behind them is reachable from both compute zones."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Proposed Change"},{"line_number":84,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"6f71792b_f79e6a54","line":82,"in_reply_to":"22ba328b_77da265e","updated":"2026-10-19 21:37:29.000000000","message":"Done","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"82de505c9a36eadc8d771ce197bb711c810a8b85","unresolved":true,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"``compute_nodes`` accepts a second kind of entry, ``{src_az, dst_az}``,"},{"line_number":90,"context_line":"beside ``{src_node, dst_node}``, and gains two per-entry booleans:"},{"line_number":91,"context_line":"``skip_pinned_instances``, deciding what happens to instances carrying a zone"},{"line_number":92,"context_line":"pin, and ``disable_source_nodes``, disabling the entry\u0027s source nodes before"},{"line_number":93,"context_line":"the drain. ``storage_pools`` accepts a type-only entry, ``{src_type,"},{"line_number":94,"context_line":"dst_type}``, beside its pool-anchored entries, and an optional per-entry"}],"source_content_type":"text/x-rst","patch_set":2,"id":"63f5646f_33dbfd78","line":91,"updated":"2026-10-09 00:15:44.000000000","message":"OK, so I can set `skip_pinned_instances: false` and I assume watcher will remove the pin as enabled by these:\n\n- https://review.opendev.org/c/openstack/nova/+/990682\n- https://review.opendev.org/c/openstack/nova/+/992469","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"``compute_nodes`` accepts a second kind of entry, ``{src_az, dst_az}``,"},{"line_number":90,"context_line":"beside ``{src_node, dst_node}``, and gains two per-entry booleans:"},{"line_number":91,"context_line":"``skip_pinned_instances``, deciding what happens to instances carrying a zone"},{"line_number":92,"context_line":"pin, and ``disable_source_nodes``, disabling the entry\u0027s source nodes before"},{"line_number":93,"context_line":"the drain. ``storage_pools`` accepts a type-only entry, ``{src_type,"},{"line_number":94,"context_line":"dst_type}``, beside its pool-anchored entries, and an optional per-entry"}],"source_content_type":"text/x-rst","patch_set":2,"id":"eea10dc4_51428328","line":91,"in_reply_to":"63f5646f_33dbfd78","updated":"2026-10-19 21:37:29.000000000","message":"Correct, this fuunctionality is ready to be used","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"82de505c9a36eadc8d771ce197bb711c810a8b85","unresolved":true,"context_lines":[{"line_number":90,"context_line":"beside ``{src_node, dst_node}``, and gains two per-entry booleans:"},{"line_number":91,"context_line":"``skip_pinned_instances``, deciding what happens to instances carrying a zone"},{"line_number":92,"context_line":"pin, and ``disable_source_nodes``, disabling the entry\u0027s source nodes before"},{"line_number":93,"context_line":"the drain. ``storage_pools`` accepts a type-only entry, ``{src_type,"},{"line_number":94,"context_line":"dst_type}``, beside its pool-anchored entries, and an optional per-entry"},{"line_number":95,"context_line":"``attached_only`` flag."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Every new option is per entry. One audit can therefore drain two zones under"}],"source_content_type":"text/x-rst","patch_set":2,"id":"d1b1545a_e6e4f2c4","line":94,"range":{"start_line":93,"start_character":11,"end_line":94,"end_character":46},"updated":"2026-10-09 00:15:44.000000000","message":"`storage_pools accepts a type-only entry, {src_type, dst_type}`\n\nWait, I think we want the user to have the ability to specify the src_pool and dst_pool and not always have to set the type. I think they can do this already by doing this:\n```\nstorage_pools\u003d\u0027[{\"src_pool\": \"hostA@ceph#ceph\", \"dst_pool\": \"hostB@ceph2#ceph2\"]\u0027\n```\nAre you saying that I won\u0027t be able to do the above in a single audit if I\u0027m using the new AZ feature drain? That could be OK, but then I\u0027d have to use two audits. \n\nIt would be better if I could do it all in a single audit if possible.","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"df067a2b5525129ac933829d85967581a1420252","unresolved":false,"context_lines":[{"line_number":90,"context_line":"beside ``{src_node, dst_node}``, and gains two per-entry booleans:"},{"line_number":91,"context_line":"``skip_pinned_instances``, deciding what happens to instances carrying a zone"},{"line_number":92,"context_line":"pin, and ``disable_source_nodes``, disabling the entry\u0027s source nodes before"},{"line_number":93,"context_line":"the drain. ``storage_pools`` accepts a type-only entry, ``{src_type,"},{"line_number":94,"context_line":"dst_type}``, beside its pool-anchored entries, and an optional per-entry"},{"line_number":95,"context_line":"``attached_only`` flag."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Every new option is per entry. One audit can therefore drain two zones under"}],"source_content_type":"text/x-rst","patch_set":2,"id":"2dc2bef2_b6fa068a","line":94,"range":{"start_line":93,"start_character":11,"end_line":94,"end_character":46},"in_reply_to":"bd1d7917_9843e08f","updated":"2026-10-14 19:33:48.000000000","message":"OK. Accepting the additional type entry in the storage pools is good since it might be needed (e.g. if they type has to be changed to something when migrating pools).","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f7804ce4bb692e288eb6da54cc76fbc4af7b8c23","unresolved":true,"context_lines":[{"line_number":90,"context_line":"beside ``{src_node, dst_node}``, and gains two per-entry booleans:"},{"line_number":91,"context_line":"``skip_pinned_instances``, deciding what happens to instances carrying a zone"},{"line_number":92,"context_line":"pin, and ``disable_source_nodes``, disabling the entry\u0027s source nodes before"},{"line_number":93,"context_line":"the drain. ``storage_pools`` accepts a type-only entry, ``{src_type,"},{"line_number":94,"context_line":"dst_type}``, beside its pool-anchored entries, and an optional per-entry"},{"line_number":95,"context_line":"``attached_only`` flag."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Every new option is per entry. One audit can therefore drain two zones under"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bd1d7917_9843e08f","line":94,"range":{"start_line":93,"start_character":11,"end_line":94,"end_character":46},"in_reply_to":"d1b1545a_e6e4f2c4","updated":"2026-10-13 17:25:30.000000000","message":"No, this is saying that we would now accept an additional type-only entry ` {src_type, dst_type}` in storage_pools (currently this strategy acepts a pool-only entry and a {`src_pool, dst_type`} entry. storage_pools is a list of entries, so it would support different entries in the same audit. When we have a volume that maps to more than one entry, we pick the pool one first (maybe we need to clarify this selection in the spec too?)","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"34c35952684015b1d3148dc1a90d798e66758606","unresolved":true,"context_lines":[{"line_number":120,"context_line":"them: a volume type is not an identifier for a backend or for a zone — one"},{"line_number":121,"context_line":"type can be served by several backends in several Cinder AZs, and one backend"},{"line_number":122,"context_line":"can be exposed through several types — so a destination volume type is not"},{"line_number":123,"context_line":"derivable from a compute zone, and neither is a destination pool."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Narrowing a drain is the **audit scope**\u0027s job. The scope is applied before"},{"line_number":126,"context_line":"the strategy sees the cluster data model, so a node excluded there yields no"}],"source_content_type":"text/x-rst","patch_set":2,"id":"c3157fa9_ed4f9c3e","line":123,"updated":"2026-10-09 00:25:34.000000000","message":"Agree. As long as cloud admins can create audits which include nova migrating all VMs from AZ1 to AZ2 (src and dst AZ) and migrating [1] all volumes from pool1 (which happens to be in AZ1) to pool2 (which happens to be in AZ2). I think your example on line 140 covers that.\n\n[1] https://docs.openstack.org/cinder/latest/admin/volume-migration.html","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":false,"context_lines":[{"line_number":120,"context_line":"them: a volume type is not an identifier for a backend or for a zone — one"},{"line_number":121,"context_line":"type can be served by several backends in several Cinder AZs, and one backend"},{"line_number":122,"context_line":"can be exposed through several types — so a destination volume type is not"},{"line_number":123,"context_line":"derivable from a compute zone, and neither is a destination pool."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Narrowing a drain is the **audit scope**\u0027s job. The scope is applied before"},{"line_number":126,"context_line":"the strategy sees the cluster data model, so a node excluded there yields no"}],"source_content_type":"text/x-rst","patch_set":2,"id":"08e365de_51a54da1","line":123,"in_reply_to":"c3157fa9_ed4f9c3e","updated":"2026-10-19 21:37:29.000000000","message":"Acknowledged","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"8eb612ec2bd1bc8eb82275e6f4ec9c64f1c1e74e","unresolved":true,"context_lines":[{"line_number":181,"context_line":"  Where a volume matches both a pool-anchored and a type-only entry, the"},{"line_number":182,"context_line":"  pool-anchored entry wins."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  ``attached_only`` is an optional boolean, default ``false``, valid on any"},{"line_number":185,"context_line":"  entry. When true the entry selects only those volumes attached to an"},{"line_number":186,"context_line":"  instance **this audit is migrating**. It therefore requires"},{"line_number":187,"context_line":"  ``compute_nodes``: without it nothing is migrating, the entry selects"},{"line_number":188,"context_line":"  nothing, and the audit is a silent no-op."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"Everything expressible against the parameters alone is a schema error at"},{"line_number":191,"context_line":"audit creation. Keeping these rules in the schema is deliberate — it is the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7975d2c1_531b7018","line":188,"range":{"start_line":184,"start_character":0,"end_line":188,"end_character":43},"updated":"2026-10-07 16:19:29.000000000","message":"Thanks for the explicit explanation, I think it\u0027s good and clear.","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f7804ce4bb692e288eb6da54cc76fbc4af7b8c23","unresolved":false,"context_lines":[{"line_number":181,"context_line":"  Where a volume matches both a pool-anchored and a type-only entry, the"},{"line_number":182,"context_line":"  pool-anchored entry wins."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  ``attached_only`` is an optional boolean, default ``false``, valid on any"},{"line_number":185,"context_line":"  entry. When true the entry selects only those volumes attached to an"},{"line_number":186,"context_line":"  instance **this audit is migrating**. It therefore requires"},{"line_number":187,"context_line":"  ``compute_nodes``: without it nothing is migrating, the entry selects"},{"line_number":188,"context_line":"  nothing, and the audit is a silent no-op."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"Everything expressible against the parameters alone is a schema error at"},{"line_number":191,"context_line":"audit creation. Keeping these rules in the schema is deliberate — it is the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"965770e7_8dd1784b","line":188,"range":{"start_line":184,"start_character":0,"end_line":188,"end_character":43},"in_reply_to":"7975d2c1_531b7018","updated":"2026-10-13 17:25:30.000000000","message":"Done","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"7d31f265858318c5cd3e7ed1e7b31f2ce2e6f3e4","unresolved":true,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"A zone pair expands to every node in the compute model whose"},{"line_number":205,"context_line":"``availability_zone`` equals ``src_az`` and whose state is online, with status"},{"line_number":206,"context_line":"either enabled or disabled. A ``src_az`` matching no node fails the audit."},{"line_number":207,"context_line":"Every instance found on those nodes gets a ``migrate`` carrying"},{"line_number":208,"context_line":"``destination_az`` set to that entry\u0027s ``dst_az``."},{"line_number":209,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"62515265_3721de76","line":206,"updated":"2026-10-06 14:26:08.000000000","message":"```\nA ``src_az`` matching no node fails the audit.\n```\nDoes this mean that the audit fails if the AZ set in `src_az` does not exist or if the AZ exists but is empty? The latter is a strange case but could happen I think, and IMO does not need a failure state","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":true,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"A zone pair expands to every node in the compute model whose"},{"line_number":205,"context_line":"``availability_zone`` equals ``src_az`` and whose state is online, with status"},{"line_number":206,"context_line":"either enabled or disabled. A ``src_az`` matching no node fails the audit."},{"line_number":207,"context_line":"Every instance found on those nodes gets a ``migrate`` carrying"},{"line_number":208,"context_line":"``destination_az`` set to that entry\u0027s ``dst_az``."},{"line_number":209,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"f0f5ce5f_d923877b","line":206,"in_reply_to":"62515265_3721de76","updated":"2026-10-19 21:37:29.000000000","message":"Correct, and at strategy level it is hard to identify both use cases, since the AZ may not exist or the model (maybe after a scope applied) has no node associated with the provided AZ.","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"A zone pair expands to every node in the compute model whose"},{"line_number":205,"context_line":"``availability_zone`` equals ``src_az`` and whose state is online, with status"},{"line_number":206,"context_line":"either enabled or disabled. A ``src_az`` matching no node fails the audit."},{"line_number":207,"context_line":"Every instance found on those nodes gets a ``migrate`` carrying"},{"line_number":208,"context_line":"``destination_az`` set to that entry\u0027s ``dst_az``."},{"line_number":209,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"db99b7b0_2447460a","line":206,"in_reply_to":"f0f5ce5f_d923877b","updated":"2026-11-03 13:27:47.000000000","message":"Done","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"8eb612ec2bd1bc8eb82275e6f4ec9c64f1c1e74e","unresolved":true,"context_lines":[{"line_number":204,"context_line":"A zone pair expands to every node in the compute model whose"},{"line_number":205,"context_line":"``availability_zone`` equals ``src_az`` and whose state is online, with status"},{"line_number":206,"context_line":"either enabled or disabled. A ``src_az`` matching no node fails the audit."},{"line_number":207,"context_line":"Every instance found on those nodes gets a ``migrate`` carrying"},{"line_number":208,"context_line":"``destination_az`` set to that entry\u0027s ``dst_az``."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"An instance that carries a zone pin conflicting with ``dst_az`` is handled"},{"line_number":211,"context_line":"according to the entry\u0027s ``skip_pinned_instances``; see `Pinned instances`_."}],"source_content_type":"text/x-rst","patch_set":2,"id":"74420475_36fdb512","line":208,"range":{"start_line":207,"start_character":0,"end_line":208,"end_character":50},"updated":"2026-10-07 16:19:29.000000000","message":"Currently, if the instance is Active, it does live migration, if it\u0027s Shutdown it does cold migration. I assume the same is valid for migration to dest_az, right? do cold-migration support AZ destination parameter or will need also to be added?","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f7804ce4bb692e288eb6da54cc76fbc4af7b8c23","unresolved":true,"context_lines":[{"line_number":204,"context_line":"A zone pair expands to every node in the compute model whose"},{"line_number":205,"context_line":"``availability_zone`` equals ``src_az`` and whose state is online, with status"},{"line_number":206,"context_line":"either enabled or disabled. A ``src_az`` matching no node fails the audit."},{"line_number":207,"context_line":"Every instance found on those nodes gets a ``migrate`` carrying"},{"line_number":208,"context_line":"``destination_az`` set to that entry\u0027s ``dst_az``."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"An instance that carries a zone pin conflicting with ``dst_az`` is handled"},{"line_number":211,"context_line":"according to the entry\u0027s ``skip_pinned_instances``; see `Pinned instances`_."}],"source_content_type":"text/x-rst","patch_set":2,"id":"b11099d9_a505228d","line":208,"range":{"start_line":207,"start_character":0,"end_line":208,"end_character":50},"in_reply_to":"74420475_36fdb512","updated":"2026-10-13 17:25:30.000000000","message":"It is expected to be added too, but the spec (os specs) are still in progress and it seems that Nova team would like to have it working on both, so I would expected in cold-migration too.","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":204,"context_line":"A zone pair expands to every node in the compute model whose"},{"line_number":205,"context_line":"``availability_zone`` equals ``src_az`` and whose state is online, with status"},{"line_number":206,"context_line":"either enabled or disabled. A ``src_az`` matching no node fails the audit."},{"line_number":207,"context_line":"Every instance found on those nodes gets a ``migrate`` carrying"},{"line_number":208,"context_line":"``destination_az`` set to that entry\u0027s ``dst_az``."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"An instance that carries a zone pin conflicting with ``dst_az`` is handled"},{"line_number":211,"context_line":"according to the entry\u0027s ``skip_pinned_instances``; see `Pinned instances`_."}],"source_content_type":"text/x-rst","patch_set":2,"id":"b7a0e2d0_82a567ee","line":208,"range":{"start_line":207,"start_character":0,"end_line":208,"end_character":50},"in_reply_to":"b11099d9_a505228d","updated":"2026-11-03 13:27:47.000000000","message":"Done","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"8eb612ec2bd1bc8eb82275e6f4ec9c64f1c1e74e","unresolved":true,"context_lines":[{"line_number":210,"context_line":"An instance that carries a zone pin conflicting with ``dst_az`` is handled"},{"line_number":211,"context_line":"according to the entry\u0027s ``skip_pinned_instances``; see `Pinned instances`_."},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"Expanding a zone to its nodes says nothing about whether those nodes can"},{"line_number":214,"context_line":"actually move an instance. Ironic is the clear case: one ``nova-compute``"},{"line_number":215,"context_line":"service fronts many compute nodes, and a bare metal instance cannot be live"},{"line_number":216,"context_line":"migrated at all. This spec targets the drivers ``zone_migration`` already"},{"line_number":217,"context_line":"works with, and offers no per-driver behaviour; exclude bare metal nodes with"},{"line_number":218,"context_line":"the audit scope. Defining what an AZ drain should mean for Ironic is left to"},{"line_number":219,"context_line":"a follow-up."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"If a zone pair is supplied and the configured Nova API microversion is below"},{"line_number":222,"context_line":"the one that accepts an AZ destination, the strategy raises ``StrategyError``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"50801f9a_952c3685","line":219,"range":{"start_line":213,"start_character":0,"end_line":219,"end_character":12},"updated":"2026-10-07 16:19:29.000000000","message":"I understood were already excluding ironic nodes from the model https://github.com/openstack/watcher/blob/master/watcher/decision_engine/model/collector/nova.py#L259-L261 ? isn\u0027t that correct?","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8d075c183196b9ab994402e124145550b50d5e14","unresolved":true,"context_lines":[{"line_number":210,"context_line":"An instance that carries a zone pin conflicting with ``dst_az`` is handled"},{"line_number":211,"context_line":"according to the entry\u0027s ``skip_pinned_instances``; see `Pinned instances`_."},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"Expanding a zone to its nodes says nothing about whether those nodes can"},{"line_number":214,"context_line":"actually move an instance. Ironic is the clear case: one ``nova-compute``"},{"line_number":215,"context_line":"service fronts many compute nodes, and a bare metal instance cannot be live"},{"line_number":216,"context_line":"migrated at all. This spec targets the drivers ``zone_migration`` already"},{"line_number":217,"context_line":"works with, and offers no per-driver behaviour; exclude bare metal nodes with"},{"line_number":218,"context_line":"the audit scope. Defining what an AZ drain should mean for Ironic is left to"},{"line_number":219,"context_line":"a follow-up."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"If a zone pair is supplied and the configured Nova API microversion is below"},{"line_number":222,"context_line":"the one that accepts an AZ destination, the strategy raises ``StrategyError``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7ce5723c_7f27870d","line":219,"range":{"start_line":213,"start_character":0,"end_line":219,"end_character":12},"in_reply_to":"0b014a08_7dbe7141","updated":"2026-10-14 20:06:07.000000000","message":"This might be the case for filtering in a base strategy method, like the proposal in https://review.opendev.org/c/openstack/watcher-specs/+/994807","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"50970c6dc44e140afc9f6bd8faef9aaade056b0d","unresolved":true,"context_lines":[{"line_number":210,"context_line":"An instance that carries a zone pin conflicting with ``dst_az`` is handled"},{"line_number":211,"context_line":"according to the entry\u0027s ``skip_pinned_instances``; see `Pinned instances`_."},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"Expanding a zone to its nodes says nothing about whether those nodes can"},{"line_number":214,"context_line":"actually move an instance. Ironic is the clear case: one ``nova-compute``"},{"line_number":215,"context_line":"service fronts many compute nodes, and a bare metal instance cannot be live"},{"line_number":216,"context_line":"migrated at all. This spec targets the drivers ``zone_migration`` already"},{"line_number":217,"context_line":"works with, and offers no per-driver behaviour; exclude bare metal nodes with"},{"line_number":218,"context_line":"the audit scope. Defining what an AZ drain should mean for Ironic is left to"},{"line_number":219,"context_line":"a follow-up."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"If a zone pair is supplied and the configured Nova API microversion is below"},{"line_number":222,"context_line":"the one that accepts an AZ destination, the strategy raises ``StrategyError``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"0b014a08_7dbe7141","line":219,"range":{"start_line":213,"start_character":0,"end_line":219,"end_character":12},"in_reply_to":"50801f9a_952c3685","updated":"2026-10-07 16:47:22.000000000","message":"we are excludign but the exclude itself is incorrect\n\nwe shoudl not be treating ironic novs instnace diffently form libvirt nova instnace at the model level in genreal\n\na thte stragey level its valid as they are not movable but they are premetbale via deleteion and there cidner voluems which they can have are movable.\n\nso this is kind of garded agaisn via a previosu design desion which itslef is arguably a bug i just wanted to be clear. on what is and is not suproted.","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":210,"context_line":"An instance that carries a zone pin conflicting with ``dst_az`` is handled"},{"line_number":211,"context_line":"according to the entry\u0027s ``skip_pinned_instances``; see `Pinned instances`_."},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"Expanding a zone to its nodes says nothing about whether those nodes can"},{"line_number":214,"context_line":"actually move an instance. Ironic is the clear case: one ``nova-compute``"},{"line_number":215,"context_line":"service fronts many compute nodes, and a bare metal instance cannot be live"},{"line_number":216,"context_line":"migrated at all. This spec targets the drivers ``zone_migration`` already"},{"line_number":217,"context_line":"works with, and offers no per-driver behaviour; exclude bare metal nodes with"},{"line_number":218,"context_line":"the audit scope. Defining what an AZ drain should mean for Ironic is left to"},{"line_number":219,"context_line":"a follow-up."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"If a zone pair is supplied and the configured Nova API microversion is below"},{"line_number":222,"context_line":"the one that accepts an AZ destination, the strategy raises ``StrategyError``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"d4bec418_75e73444","line":219,"range":{"start_line":213,"start_character":0,"end_line":219,"end_character":12},"in_reply_to":"7ce5723c_7f27870d","updated":"2026-11-03 13:27:47.000000000","message":"Done","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"27e936244f2d2c0654b4e0384b24e19393cbfc9a","unresolved":true,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"``attached_only`` narrows an entry to volumes attached to an instance this"},{"line_number":269,"context_line":"audit is migrating. ``attached_only`` and the existing"},{"line_number":270,"context_line":"``with_attached_volume`` read the same information in opposite directions,"},{"line_number":271,"context_line":"and the documentation must contrast them directly:"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":".. list-table:: Two attachment-driven options"},{"line_number":274,"context_line":"   :header-rows: 1"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9dc413d3_77b28f62","line":271,"range":{"start_line":270,"start_character":0,"end_line":271,"end_character":50},"updated":"2026-10-02 19:10:15.000000000","message":"This is a candidate for deprecation, this existing option doesn\u0027t guarantee the action order that is going to be defined in the planner, so it is a noop operation today.","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8d075c183196b9ab994402e124145550b50d5e14","unresolved":true,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"``attached_only`` narrows an entry to volumes attached to an instance this"},{"line_number":269,"context_line":"audit is migrating. ``attached_only`` and the existing"},{"line_number":270,"context_line":"``with_attached_volume`` read the same information in opposite directions,"},{"line_number":271,"context_line":"and the documentation must contrast them directly:"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":".. list-table:: Two attachment-driven options"},{"line_number":274,"context_line":"   :header-rows: 1"}],"source_content_type":"text/x-rst","patch_set":2,"id":"d7edb016_628ae583","line":271,"range":{"start_line":270,"start_character":0,"end_line":271,"end_character":50},"in_reply_to":"9dc413d3_77b28f62","updated":"2026-10-14 20:06:07.000000000","message":"Edit: jgilaber mentioned the case when the audit configures a maximum number of migrations, which could let a instance (which the volume is migrating) out of the solution.","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"``attached_only`` narrows an entry to volumes attached to an instance this"},{"line_number":269,"context_line":"audit is migrating. ``attached_only`` and the existing"},{"line_number":270,"context_line":"``with_attached_volume`` read the same information in opposite directions,"},{"line_number":271,"context_line":"and the documentation must contrast them directly:"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":".. list-table:: Two attachment-driven options"},{"line_number":274,"context_line":"   :header-rows: 1"}],"source_content_type":"text/x-rst","patch_set":2,"id":"f852aa0b_2c037750","line":271,"range":{"start_line":270,"start_character":0,"end_line":271,"end_character":50},"in_reply_to":"d7edb016_628ae583","updated":"2026-10-19 21:37:29.000000000","message":"Lets keep it then, thanks Joan","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"8eb612ec2bd1bc8eb82275e6f4ec9c64f1c1e74e","unresolved":true,"context_lines":[{"line_number":331,"context_line":"Clearing a pin overrides a placement constraint the end user asked for, and"},{"line_number":332,"context_line":"which may encode a locality or compliance requirement Watcher cannot see."},{"line_number":333,"context_line":"That is the operator\u0027s call to make, per entry:"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"``skip_pinned_instances: true``"},{"line_number":336,"context_line":"  The default. An instance whose ``pinned_availability_zone`` conflicts with"},{"line_number":337,"context_line":"  where the entry would send it is left out of the action plan and logged."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"``skip_pinned_instances: false``"},{"line_number":340,"context_line":"  The instance migrates, and its ``migrate`` action carries"}],"source_content_type":"text/x-rst","patch_set":2,"id":"47e46535_237984f8","line":337,"range":{"start_line":334,"start_character":1,"end_line":337,"end_character":74},"updated":"2026-10-07 16:19:29.000000000","message":"I\u0027m not entirely sure what\u0027s the best default. IMO, when using src_az and dst_az, the expected default would be `skip_pinned_instances: false` but i\u0027m not sure. I understand this option would also be valide for host based audits where src_host and dst_host are in different AZs, right?","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b0a040dab5818cdf0d1ed7629552e8709e523f24","unresolved":true,"context_lines":[{"line_number":331,"context_line":"Clearing a pin overrides a placement constraint the end user asked for, and"},{"line_number":332,"context_line":"which may encode a locality or compliance requirement Watcher cannot see."},{"line_number":333,"context_line":"That is the operator\u0027s call to make, per entry:"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"``skip_pinned_instances: true``"},{"line_number":336,"context_line":"  The default. An instance whose ``pinned_availability_zone`` conflicts with"},{"line_number":337,"context_line":"  where the entry would send it is left out of the action plan and logged."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"``skip_pinned_instances: false``"},{"line_number":340,"context_line":"  The instance migrates, and its ``migrate`` action carries"}],"source_content_type":"text/x-rst","patch_set":2,"id":"748d27f3_c292cd6c","line":337,"range":{"start_line":334,"start_character":1,"end_line":337,"end_character":74},"in_reply_to":"3c6ed9b1_da369797","updated":"2026-10-30 15:14:52.000000000","message":"One addition here, while implementing a PoC.\nThe new pin and unpin API in Nova does not emit any notification after a change, which means that current \u0027pinned_az\u0027 in the model may be outdated. Mainly if users proactively unpin instances, Watcher will still reference to the old pinned_az and may skip the instance.\nSo another idea here is to allow user to choose if they want to \"repin_az_pinned_instances\". And during the Migrate Action, we can retrieve instance info from Nova, check current pinned_az (and in case destination_az is set and different from the pinned_az) it could unpin, migrate and pin again, or SKIP the action if \"repin_az_pinned_instances\u003dFalse\".\nBut the SKIP will happen only at the Action Plan execution, not anymore in the strategy.","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"82de505c9a36eadc8d771ce197bb711c810a8b85","unresolved":true,"context_lines":[{"line_number":331,"context_line":"Clearing a pin overrides a placement constraint the end user asked for, and"},{"line_number":332,"context_line":"which may encode a locality or compliance requirement Watcher cannot see."},{"line_number":333,"context_line":"That is the operator\u0027s call to make, per entry:"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"``skip_pinned_instances: true``"},{"line_number":336,"context_line":"  The default. An instance whose ``pinned_availability_zone`` conflicts with"},{"line_number":337,"context_line":"  where the entry would send it is left out of the action plan and logged."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"``skip_pinned_instances: false``"},{"line_number":340,"context_line":"  The instance migrates, and its ``migrate`` action carries"}],"source_content_type":"text/x-rst","patch_set":2,"id":"abd55158_cd335968","line":337,"range":{"start_line":334,"start_character":1,"end_line":337,"end_character":74},"in_reply_to":"47e46535_237984f8","updated":"2026-10-09 00:15:44.000000000","message":"Sean wanted the default of false since they think if the user requests the AZ we shouldn\u0027t just override what they want when we do the migration. There could be a good reason for it if they want to ensure a VM doesn\u0027t cross a country border.\n\nI think the default of true is simpler since the AZ will be pinned if you pass `--availability-zone` when you schedule the VM and that will be the case for most VMs in deployments with \u003e1 AZ (which is where this spec applies). Thus, I think cloud admins might end up passing true a lot (unless they have a cloud that crosses borders or other reasons).\n\nAs a cloud admin, as long as I can override it though by setting it false, I\u0027ll be OK. I think I\u0027d always use that (and so would cloud admins with \u003e1 AZ since a lot of VMs will end up pinned) unless in my cloud I had reasons not to (the border or other reason).\n\nCan the default be configurable? We can ship with it false to cover Sean\u0027s concern, but the cloud admin can opt to configure it true so that every time they create a watcher policy they don\u0027t have to worry about overriding it?","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":331,"context_line":"Clearing a pin overrides a placement constraint the end user asked for, and"},{"line_number":332,"context_line":"which may encode a locality or compliance requirement Watcher cannot see."},{"line_number":333,"context_line":"That is the operator\u0027s call to make, per entry:"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"``skip_pinned_instances: true``"},{"line_number":336,"context_line":"  The default. An instance whose ``pinned_availability_zone`` conflicts with"},{"line_number":337,"context_line":"  where the entry would send it is left out of the action plan and logged."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"``skip_pinned_instances: false``"},{"line_number":340,"context_line":"  The instance migrates, and its ``migrate`` action carries"}],"source_content_type":"text/x-rst","patch_set":2,"id":"494e80df_897603f8","line":337,"range":{"start_line":334,"start_character":1,"end_line":337,"end_character":74},"in_reply_to":"748d27f3_c292cd6c","updated":"2026-11-11 22:10:40.000000000","message":"Done","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9242e8924af520be65b667b63aa6e11b0c35cd32","unresolved":true,"context_lines":[{"line_number":331,"context_line":"Clearing a pin overrides a placement constraint the end user asked for, and"},{"line_number":332,"context_line":"which may encode a locality or compliance requirement Watcher cannot see."},{"line_number":333,"context_line":"That is the operator\u0027s call to make, per entry:"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"``skip_pinned_instances: true``"},{"line_number":336,"context_line":"  The default. An instance whose ``pinned_availability_zone`` conflicts with"},{"line_number":337,"context_line":"  where the entry would send it is left out of the action plan and logged."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"``skip_pinned_instances: false``"},{"line_number":340,"context_line":"  The instance migrates, and its ``migrate`` action carries"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3c6ed9b1_da369797","line":337,"range":{"start_line":334,"start_character":1,"end_line":337,"end_character":74},"in_reply_to":"abd55158_cd335968","updated":"2026-10-29 19:20:05.000000000","message":"i was orginally suggeting ture not falsae to preserve the end users requested az\nhowever duing the ptg dicussion i was won over to false (incliding pined instas)\nbecuase of the upgrad impact of adding that parmter.\n\nsince right now watcher does not care or relaly know if its pined it shoudl maintain that behvior to be backward compatble\n\nthat means we can opt into skipping them but we shoudl includ them by default","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"82de505c9a36eadc8d771ce197bb711c810a8b85","unresolved":true,"context_lines":[{"line_number":344,"context_line":"than in actions of its own. The three steps are one operation: unpin, move,"},{"line_number":345,"context_line":"pin. An action that owns all three keeps them together whatever the planner"},{"line_number":346,"context_line":"does with the rest of the plan, and keeps the unpin from being applied to an"},{"line_number":347,"context_line":"instance whose migration never runs or that was eventually skipped."},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"**There is no revert for either half of the pin change, and the action is not"},{"line_number":350,"context_line":"atomic.** If the migration fails after the pin has been cleared, the instance"}],"source_content_type":"text/x-rst","patch_set":2,"id":"d3d27943_6abcd0ac","line":347,"updated":"2026-10-09 00:15:44.000000000","message":"agree","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":false,"context_lines":[{"line_number":344,"context_line":"than in actions of its own. The three steps are one operation: unpin, move,"},{"line_number":345,"context_line":"pin. An action that owns all three keeps them together whatever the planner"},{"line_number":346,"context_line":"does with the rest of the plan, and keeps the unpin from being applied to an"},{"line_number":347,"context_line":"instance whose migration never runs or that was eventually skipped."},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"**There is no revert for either half of the pin change, and the action is not"},{"line_number":350,"context_line":"atomic.** If the migration fails after the pin has been cleared, the instance"}],"source_content_type":"text/x-rst","patch_set":2,"id":"2ce54989_649956da","line":347,"in_reply_to":"d3d27943_6abcd0ac","updated":"2026-10-19 21:37:29.000000000","message":"Done","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"8eb612ec2bd1bc8eb82275e6f4ec9c64f1c1e74e","unresolved":true,"context_lines":[{"line_number":347,"context_line":"instance whose migration never runs or that was eventually skipped."},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"**There is no revert for either half of the pin change, and the action is not"},{"line_number":350,"context_line":"atomic.** If the migration fails after the pin has been cleared, the instance"},{"line_number":351,"context_line":"stays where it is with no pin at all, and Watcher does not put it back:"},{"line_number":352,"context_line":"restoring a pin is itself a Nova call that can fail, and the action has"},{"line_number":353,"context_line":"already failed."},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"Both behaviours depend on Watcher being able to *see* the pin."},{"line_number":356,"context_line":"``Instance.pinned_az`` is populated only when compute model extended"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f701a22_9b1ddf2b","line":353,"range":{"start_line":350,"start_character":10,"end_line":353,"end_character":15},"updated":"2026-10-07 16:19:29.000000000","message":"I think we could discuss this. Why not to try to repin in src_az if the migraion failed?","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":false,"context_lines":[{"line_number":347,"context_line":"instance whose migration never runs or that was eventually skipped."},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"**There is no revert for either half of the pin change, and the action is not"},{"line_number":350,"context_line":"atomic.** If the migration fails after the pin has been cleared, the instance"},{"line_number":351,"context_line":"stays where it is with no pin at all, and Watcher does not put it back:"},{"line_number":352,"context_line":"restoring a pin is itself a Nova call that can fail, and the action has"},{"line_number":353,"context_line":"already failed."},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"Both behaviours depend on Watcher being able to *see* the pin."},{"line_number":356,"context_line":"``Instance.pinned_az`` is populated only when compute model extended"}],"source_content_type":"text/x-rst","patch_set":2,"id":"d6c61a1d_394fdc57","line":353,"range":{"start_line":350,"start_character":10,"end_line":353,"end_character":15},"in_reply_to":"1f701a22_9b1ddf2b","updated":"2026-10-19 21:37:29.000000000","message":"Based on discussions during PTG, we agreed that we could try to repin in case of failure yes. That requires that all pin/unpin operation to live inside migrate action.","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"02d42c3a197afbbfb3a0b41ca9847218544c99d1","unresolved":true,"context_lines":[{"line_number":360,"context_line":"This spec therefore flips ``[compute_model] enable_extended_attributes`` to"},{"line_number":361,"context_line":"default ``True``."},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"Worked example"},{"line_number":364,"context_line":"--------------"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"The sections above describe each piece in isolation. This one walks the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"f9b244b8_7cca53da","line":363,"updated":"2026-10-09 20:18:54.000000000","message":"This worked example is good, but in order for it to cover the most likely case, could it be updated to describe volume migration instead of volume retype?\n\nI\u0027ll provide a suggested re-write if you agree.\n```\nWorked example\n--------------\n\nThe sections above describe each piece in isolation. This one walks the\nfully-specified case — source and destination zone, source and destination\nvolume type — end to end.\n\nThe audit template carries the goal, the strategy and the scope::\n\n    goal:     hardware_maintenance\n    strategy: zone_migration\n    scope:    exclude compute_node compute-a3\n\nThe audit carries the strategy parameters::\n\n    compute_nodes:\n      - src_az: az-a\n        dst_az: az-b\n        skip_pinned_instances: false\n        disable_source_nodes: true\n    storage_pools:\n      - src_type: ceph-a\n        dst_type: ceph-b\n\nTake a cluster where ``az-a`` holds ``compute-a1`` (instances ``i1``\nunpinned and ``i2`` pinned to ``az-a``), ``compute-a2`` (instance ``i3``),\n``compute-a4`` (no instances) and ``compute-a3``, which the audit scope\nexcludes. Volume ``v1`` of type ``ceph-a`` is attached to ``i1``, ``v2`` of\ntype ``ceph-a`` is unattached and sits in a different pool, and ``v3`` of\ntype ``ceph-x`` is attached to ``i3``. The volume type ``ceph-b`` carries\n``RESKEY:availability_zones`` naming the storage zone the operator is\ndraining into.\n\n#. **Schema validation**, before the strategy runs. The ``compute_nodes``\n   entry is a well-formed zone pair, the ``storage_pools`` entry a\n   well-formed type-only entry.\n#. **Gates**, in ``pre_execute``. ``az-a`` matches at least one node and\n   ``az-b`` is a known Nova zone. The configured Nova microversion accepts an\n   AZ destination, and it is at least the unpin microversion because the entry\n   sets ``skip_pinned_instances: false``. The Cinder collector is enabled, so\n   the storage model exists.\n#. **Targets.** Both parameters are supplied, so this audit drains instances\n   and volumes.\n#. **Source nodes.** Every node in the *scoped* compute model with\n   ``availability_zone \u003d\u003d az-a`` that is online: ``compute-a1``,\n   ``compute-a2`` and ``compute-a4``. ``compute-a3`` was removed by the audit\n   scope before the strategy saw the model, so it is not a source and produces\n   no actions.\n#. **Volumes**, selected by type across every pool: ``v1`` and ``v2`` are\n   ``ceph-a`` and each gets a retype to ``ceph-b``. ``v2`` being unattached\n   and in an unnamed pool makes no difference — the entry names a type, not a\n   pool. ``v3`` is ``ceph-x``, which no entry selects, so it is untouched.\n   Had the entry set ``attached_only``, ``v2`` would have been left out and\n   only ``v1`` retyped.\n#. **Instances**, in the order the existing priority filters impose and\n   subject to the existing ``parallel_*`` caps. Each gets a ``migrate``\n   with ``destination_az: az-b``: ``i1`` and ``i2`` from ``compute-a1``,\n   ``i3`` from ``compute-a2``. ``i2`` is pinned to ``az-a``, and the entry\n   opted out of skipping, so its ``migrate`` also carries\n   ``repin_availability_zone: true``. Under the default\n   ``skip_pinned_instances``, ``i2`` would have been logged and left on\n   ``compute-a1`` instead.\n#. **Source node disable**, because the entry sets ``disable_source_nodes``:\n   one ``change_nova_service_state`` for each of ``compute-a1``,\n   ``compute-a2`` and ``compute-a4``, so the scheduler does not refill a node\n   being drained. ``compute-a4`` is disabled despite holding nothing — an\n   enabled node in a zone being drained is a node the scheduler can fill.\n\nThe solution handed to the planner is unordered; the weights turn it into::\n\n    layer 60  volume_migrate(v1, retype ceph-a -\u003e ceph-b)\n              volume_migrate(v2, retype ceph-a -\u003e ceph-b)\n    layer 50  change_nova_service_state(compute-a1, disabled)\n              change_nova_service_state(compute-a2, disabled)\n              change_nova_service_state(compute-a4, disabled)\n    layer 30  migrate(i1, destination_az\u003daz-b)\n              migrate(i2, destination_az\u003daz-b, repin_availability_zone\u003dtrue)\n              migrate(i3, destination_az\u003daz-b)\n\n```","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":false,"context_lines":[{"line_number":360,"context_line":"This spec therefore flips ``[compute_model] enable_extended_attributes`` to"},{"line_number":361,"context_line":"default ``True``."},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"Worked example"},{"line_number":364,"context_line":"--------------"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"The sections above describe each piece in isolation. This one walks the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"25f900d2_f0481198","line":363,"in_reply_to":"6a05bb6a_cc55a15e","updated":"2026-10-19 21:37:29.000000000","message":"Done","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8d075c183196b9ab994402e124145550b50d5e14","unresolved":true,"context_lines":[{"line_number":360,"context_line":"This spec therefore flips ``[compute_model] enable_extended_attributes`` to"},{"line_number":361,"context_line":"default ``True``."},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"Worked example"},{"line_number":364,"context_line":"--------------"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"The sections above describe each piece in isolation. This one walks the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"6a05bb6a_cc55a15e","line":363,"in_reply_to":"f9b244b8_7cca53da","updated":"2026-10-14 20:06:07.000000000","message":"I will get back to this after ptg but I think that is feasible to extend the example to cover more cases yes, thanks","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"82de505c9a36eadc8d771ce197bb711c810a8b85","unresolved":true,"context_lines":[{"line_number":456,"context_line":"takes a volume type, so \"move to that zone\" would have to become \"pick a"},{"line_number":457,"context_line":"backend in that zone\", making Watcher the storage scheduler — the one thing"},{"line_number":458,"context_line":"this design sets out not to do on the compute side. The pool and type mapping"},{"line_number":459,"context_line":"the operator already writes expresses the same intent without either."},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"Data Model Impact"},{"line_number":462,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e6e8bb13_1180bc3b","line":459,"updated":"2026-10-09 00:15:44.000000000","message":"agree.","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6b7e660d84e3a70eaf57410a140db8eeec9e5bc1","unresolved":false,"context_lines":[{"line_number":456,"context_line":"takes a volume type, so \"move to that zone\" would have to become \"pick a"},{"line_number":457,"context_line":"backend in that zone\", making Watcher the storage scheduler — the one thing"},{"line_number":458,"context_line":"this design sets out not to do on the compute side. The pool and type mapping"},{"line_number":459,"context_line":"the operator already writes expresses the same intent without either."},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"Data Model Impact"},{"line_number":462,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"f4d91554_93025283","line":459,"in_reply_to":"e6e8bb13_1180bc3b","updated":"2026-10-19 21:37:29.000000000","message":"Done","commit_id":"36285d83869bff8bbde88675ee1d698347d15869"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9242e8924af520be65b667b63aa6e11b0c35cd32","unresolved":true,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/watcher/+spec/zone-migration-az-drain"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Operators performing maintenance on a whole compute availability zone need to"},{"line_number":14,"context_line":"move every workload out of it — the instances and the volumes  — before the"},{"line_number":15,"context_line":"zone can be taken down. Watcher\u0027s ``zone_migration`` strategy already drains"},{"line_number":16,"context_line":"operator-named compute nodes and storage pools, but it has no concept of a"},{"line_number":17,"context_line":"Nova availability zone: the operator must enumerate every source host by"}],"source_content_type":"text/x-rst","patch_set":4,"id":"cb1c91d9_53460e52","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":75},"updated":"2026-10-29 19:20:05.000000000","message":"```suggestion\nmove every workload out of it, the instances and the volumes, before the\n```\n\nhumans use commas llmes use dashses when you tell them that emdahses are not allwoed :)","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/watcher/+spec/zone-migration-az-drain"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Operators performing maintenance on a whole compute availability zone need to"},{"line_number":14,"context_line":"move every workload out of it — the instances and the volumes  — before the"},{"line_number":15,"context_line":"zone can be taken down. Watcher\u0027s ``zone_migration`` strategy already drains"},{"line_number":16,"context_line":"operator-named compute nodes and storage pools, but it has no concept of a"},{"line_number":17,"context_line":"Nova availability zone: the operator must enumerate every source host by"}],"source_content_type":"text/x-rst","patch_set":4,"id":"e9f34850_865f7e8e","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":75},"in_reply_to":"cb1c91d9_53460e52","updated":"2026-11-03 13:27:47.000000000","message":"Done","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5059bc2d6b38eb34922c56f9966a907da8c5c238","unresolved":true,"context_lines":[{"line_number":16,"context_line":"operator-named compute nodes and storage pools, but it has no concept of a"},{"line_number":17,"context_line":"Nova availability zone: the operator must enumerate every source host by"},{"line_number":18,"context_line":"hand, and nothing keeps the instances inside the intended destination zone."},{"line_number":19,"context_line":"This spec proposes a new compute AZ-to-AZ drain mechanism that can be added"},{"line_number":20,"context_line":"as part of ``zone_migration`` strategy or as a new ``hardware_maintenance``"},{"line_number":21,"context_line":"strategy."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dd41e8c4_8a0d88b6","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":9},"updated":"2026-10-29 20:54:33.000000000","message":"based on our side converation and the ptg session im going to premetively suggest we update this too\n\n\n\n```suggestion\nThis spec extends ``zone_migration`` to drain instances from one compute\navailability zone into another. Storage destinations remain specified\nseparately through pool and volume type mappings.\n```\n\na new stragiy is easier in that it mean we dont need to fix the upgrae issue before we can proceed but overall evloving the stragy will be better in the long run so given this is your prefence anyway i woudl suggest leadign with that and captureing the new stragy in teh allternivies section.\n\nill add a comment about that later","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":16,"context_line":"operator-named compute nodes and storage pools, but it has no concept of a"},{"line_number":17,"context_line":"Nova availability zone: the operator must enumerate every source host by"},{"line_number":18,"context_line":"hand, and nothing keeps the instances inside the intended destination zone."},{"line_number":19,"context_line":"This spec proposes a new compute AZ-to-AZ drain mechanism that can be added"},{"line_number":20,"context_line":"as part of ``zone_migration`` strategy or as a new ``hardware_maintenance``"},{"line_number":21,"context_line":"strategy."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":4,"id":"79210b91_ff3b9965","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":9},"in_reply_to":"dd41e8c4_8a0d88b6","updated":"2026-11-03 13:27:47.000000000","message":"Done","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5059bc2d6b38eb34922c56f9966a907da8c5c238","unresolved":true,"context_lines":[{"line_number":24,"context_line":"Problem Description"},{"line_number":25,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"``zone_migration`` today takes two static operator-supplied maps:"},{"line_number":28,"context_line":"``compute_nodes`` (a list of ``{src_node, dst_node}``) and ``storage_pools``"},{"line_number":29,"context_line":"(a list of ``{src_pool, dst_pool|dst_type, src_type}``). It emits ``migrate``"},{"line_number":30,"context_line":"actions for the instances found on each source node and ``volume_migrate``"},{"line_number":31,"context_line":"actions for the volumes found in each source pool."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Despite the strategy\u0027s name, \"zone\" here is not an availability zone at all."},{"line_number":34,"context_line":"The strategy documentation says so outright and warns that cross-AZ migration"},{"line_number":35,"context_line":"\"is not fully tested\"."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"There is no single OpenStack availability zone"},{"line_number":38,"context_line":"----------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"a86989dd_04352b5d","line":35,"range":{"start_line":27,"start_character":0,"end_line":35,"end_character":22},"updated":"2026-10-29 20:54:33.000000000","message":"this is a lttel hard to read.\n\n```suggestion\nThe existing ``zone_migration`` strategy selects source compute nodes and\nstorage pools by name. The ``compute_nodes`` parameter\nmaps source nodes to optional destination nodes. The ``storage_pools``\nparameter maps source pools to destination pools or volume types and can\nfilter volumes by their source type. The strategy creates ``migrate``\nactions for instances on the selected nodes and ``volume_migrate`` actions\nfor volumes in the selected pools.\n\nDespite the strategy\u0027s name, \"zone\" here refers to the operator-selected\nnodes and pools, not to an availability zone. The strategy documentation\nwarns that migration across availability zones \"is not fully tested\".\nIn practice this work if and only if the instance is not pinned to an AZ\nwhich watcher does not check.\n```","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Problem Description"},{"line_number":25,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"``zone_migration`` today takes two static operator-supplied maps:"},{"line_number":28,"context_line":"``compute_nodes`` (a list of ``{src_node, dst_node}``) and ``storage_pools``"},{"line_number":29,"context_line":"(a list of ``{src_pool, dst_pool|dst_type, src_type}``). It emits ``migrate``"},{"line_number":30,"context_line":"actions for the instances found on each source node and ``volume_migrate``"},{"line_number":31,"context_line":"actions for the volumes found in each source pool."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Despite the strategy\u0027s name, \"zone\" here is not an availability zone at all."},{"line_number":34,"context_line":"The strategy documentation says so outright and warns that cross-AZ migration"},{"line_number":35,"context_line":"\"is not fully tested\"."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"There is no single OpenStack availability zone"},{"line_number":38,"context_line":"----------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"47eac041_12d02bc3","line":35,"range":{"start_line":27,"start_character":0,"end_line":35,"end_character":22},"in_reply_to":"a86989dd_04352b5d","updated":"2026-11-03 13:27:47.000000000","message":"Done","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5059bc2d6b38eb34922c56f9966a907da8c5c238","unresolved":true,"context_lines":[{"line_number":34,"context_line":"The strategy documentation says so outright and warns that cross-AZ migration"},{"line_number":35,"context_line":"\"is not fully tested\"."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"There is no single OpenStack availability zone"},{"line_number":38,"context_line":"----------------------------------------------"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Nova and Cinder, as also Neutron and other services, define their own"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3e37a8f2_05c5f317","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":46},"updated":"2026-10-29 20:54:33.000000000","message":"OpenStack Availability Zones","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":34,"context_line":"The strategy documentation says so outright and warns that cross-AZ migration"},{"line_number":35,"context_line":"\"is not fully tested\"."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"There is no single OpenStack availability zone"},{"line_number":38,"context_line":"----------------------------------------------"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Nova and Cinder, as also Neutron and other services, define their own"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da403270_b2ad4ed0","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":46},"in_reply_to":"3e37a8f2_05c5f317","updated":"2026-11-03 13:27:47.000000000","message":"Done","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9242e8924af520be65b667b63aa6e11b0c35cd32","unresolved":true,"context_lines":[{"line_number":37,"context_line":"There is no single OpenStack availability zone"},{"line_number":38,"context_line":"----------------------------------------------"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Nova and Cinder, as also Neutron and other services, define their own"},{"line_number":41,"context_line":"availability zones, with their own semantics and their own APIs."},{"line_number":42,"context_line":"An AZ name in one service says nothing about an AZ of the same name in"},{"line_number":43,"context_line":"another. Operators may align the names, and may well have a reason to"},{"line_number":44,"context_line":"keep them apart; either way the alignment would be a local convention."}],"source_content_type":"text/x-rst","patch_set":4,"id":"466f5e35_ab80e1c2","line":41,"range":{"start_line":40,"start_character":0,"end_line":41,"end_character":64},"updated":"2026-10-29 19:20:05.000000000","message":"```suggestion\nNova, Cinder, Neutron and other services, define their own\navailability zones concept, with their diffent semantics and APIs.\n```","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":37,"context_line":"There is no single OpenStack availability zone"},{"line_number":38,"context_line":"----------------------------------------------"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Nova and Cinder, as also Neutron and other services, define their own"},{"line_number":41,"context_line":"availability zones, with their own semantics and their own APIs."},{"line_number":42,"context_line":"An AZ name in one service says nothing about an AZ of the same name in"},{"line_number":43,"context_line":"another. Operators may align the names, and may well have a reason to"},{"line_number":44,"context_line":"keep them apart; either way the alignment would be a local convention."}],"source_content_type":"text/x-rst","patch_set":4,"id":"c9369832_9eb6a00f","line":41,"range":{"start_line":40,"start_character":0,"end_line":41,"end_character":64},"in_reply_to":"466f5e35_ab80e1c2","updated":"2026-11-03 13:27:47.000000000","message":"Done","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9242e8924af520be65b667b63aa6e11b0c35cd32","unresolved":false,"context_lines":[{"line_number":41,"context_line":"availability zones, with their own semantics and their own APIs."},{"line_number":42,"context_line":"An AZ name in one service says nothing about an AZ of the same name in"},{"line_number":43,"context_line":"another. Operators may align the names, and may well have a reason to"},{"line_number":44,"context_line":"keep them apart; either way the alignment would be a local convention."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"This spec focus on compute availability zones. ``src_az`` and ``dst_az``"},{"line_number":47,"context_line":"are Nova AZs throughout. Watcher reads no Cinder AZ, correlates none,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a2c9cb8_a47d3936","line":44,"updated":"2026-10-29 19:20:05.000000000","message":"+1","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9242e8924af520be65b667b63aa6e11b0c35cd32","unresolved":false,"context_lines":[{"line_number":47,"context_line":"are Nova AZs throughout. Watcher reads no Cinder AZ, correlates none,"},{"line_number":48,"context_line":"and never derives a volume destination from a compute zone. Where"},{"line_number":49,"context_line":"volumes go is stated by the operator, by pool or by volume type, which is how"},{"line_number":50,"context_line":"``zone_migration`` already works today."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"No compute AZ awareness"},{"line_number":53,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"0f06072a_b64d6385","line":50,"updated":"2026-10-29 19:20:05.000000000","message":"+1 clear scopeing","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5059bc2d6b38eb34922c56f9966a907da8c5c238","unresolved":true,"context_lines":[{"line_number":48,"context_line":"and never derives a volume destination from a compute zone. Where"},{"line_number":49,"context_line":"volumes go is stated by the operator, by pool or by volume type, which is how"},{"line_number":50,"context_line":"``zone_migration`` already works today."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"No compute AZ awareness"},{"line_number":53,"context_line":"-----------------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* The compute cluster data model has no ``availability_zone`` on"}],"source_content_type":"text/x-rst","patch_set":4,"id":"aae89051_c0cc5c78","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":23},"updated":"2026-10-29 20:54:33.000000000","message":"can we use title case here and for all other section hearders?\n\n`No Compute AZ Awareness`","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":48,"context_line":"and never derives a volume destination from a compute zone. Where"},{"line_number":49,"context_line":"volumes go is stated by the operator, by pool or by volume type, which is how"},{"line_number":50,"context_line":"``zone_migration`` already works today."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"No compute AZ awareness"},{"line_number":53,"context_line":"-----------------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* The compute cluster data model has no ``availability_zone`` on"}],"source_content_type":"text/x-rst","patch_set":4,"id":"2eb2f943_e3081f67","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":23},"in_reply_to":"aae89051_c0cc5c78","updated":"2026-11-03 13:27:47.000000000","message":"Yep, sure","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9242e8924af520be65b667b63aa6e11b0c35cd32","unresolved":true,"context_lines":[{"line_number":52,"context_line":"No compute AZ awareness"},{"line_number":53,"context_line":"-----------------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* The compute cluster data model has no ``availability_zone`` on"},{"line_number":56,"context_line":"  ``ComputeNode``. Nova\u0027s host-to-zone data is already fetched during model"},{"line_number":57,"context_line":"  build via ``nova_helper.get_service_list()`` (``Service.zone``) and then"},{"line_number":58,"context_line":"  discarded — the zone is used to select hostnames for AZ-scoped audits but"},{"line_number":59,"context_line":"  never stored."},{"line_number":60,"context_line":"* The zone of an instance\u0027s host is only half the picture. Nova also exposes"},{"line_number":61,"context_line":"  ``pinned_availability_zone``, the zone constraint the instance itself"},{"line_number":62,"context_line":"  can carries. ``Instance.pinned_az`` exists in the compute model but is"}],"source_content_type":"text/x-rst","patch_set":4,"id":"17c22567_7d9ebe02","line":59,"range":{"start_line":55,"start_character":0,"end_line":59,"end_character":15},"updated":"2026-10-29 19:20:05.000000000","message":"yes this is valid\n\nso in nova a compute_node and compute service are 2 sepert things\n\na AZ is a metadata key on a nova host aggrates\n\nhost aggreates are groups of compute services not compute nodes\nyou add a service to an aggreate and you annotate a agggreate with an az_name metadta key\n\nso looking up the compute serice\u0027s aggreates adn selecting it az form the set of aggreates its a memeber of is correct\n\nwhile a compute service can be in many host aggreates it can only ever be in 1 az\n\none thing to note when its not a member of any az there is config option to name the default az shown in the api, this defaults to \"nova\" but that is not a real AZ its just the name we give it.\n\nthere isnt a host aggage with nova set as the az name in its metadta.\n\nwe should not pin vms to the nova az.\n\nwhile you can do that and hoizon does nova\u0027s docs explcitly say that you should never do that.\n\nhttps://docs.openstack.org/nova/latest/admin/availability-zones.html","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"d896c05efd089ec81f51885bdc402eb66c10f16b","unresolved":true,"context_lines":[{"line_number":52,"context_line":"No compute AZ awareness"},{"line_number":53,"context_line":"-----------------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* The compute cluster data model has no ``availability_zone`` on"},{"line_number":56,"context_line":"  ``ComputeNode``. Nova\u0027s host-to-zone data is already fetched during model"},{"line_number":57,"context_line":"  build via ``nova_helper.get_service_list()`` (``Service.zone``) and then"},{"line_number":58,"context_line":"  discarded — the zone is used to select hostnames for AZ-scoped audits but"},{"line_number":59,"context_line":"  never stored."},{"line_number":60,"context_line":"* The zone of an instance\u0027s host is only half the picture. Nova also exposes"},{"line_number":61,"context_line":"  ``pinned_availability_zone``, the zone constraint the instance itself"},{"line_number":62,"context_line":"  can carries. ``Instance.pinned_az`` exists in the compute model but is"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9cb76d98_7e9cb74e","line":59,"range":{"start_line":55,"start_character":0,"end_line":59,"end_character":15},"in_reply_to":"019ae877_b2b08738","updated":"2026-11-06 12:17:09.000000000","message":"IIUC, the idea on selecting host aggregates is to resolve them to an AZ, inside the strategy, and use the AZ as destination. But at this moment I am not planning to extend the scope, but can be extended in future.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":true,"context_lines":[{"line_number":52,"context_line":"No compute AZ awareness"},{"line_number":53,"context_line":"-----------------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* The compute cluster data model has no ``availability_zone`` on"},{"line_number":56,"context_line":"  ``ComputeNode``. Nova\u0027s host-to-zone data is already fetched during model"},{"line_number":57,"context_line":"  build via ``nova_helper.get_service_list()`` (``Service.zone``) and then"},{"line_number":58,"context_line":"  discarded — the zone is used to select hostnames for AZ-scoped audits but"},{"line_number":59,"context_line":"  never stored."},{"line_number":60,"context_line":"* The zone of an instance\u0027s host is only half the picture. Nova also exposes"},{"line_number":61,"context_line":"  ``pinned_availability_zone``, the zone constraint the instance itself"},{"line_number":62,"context_line":"  can carries. ``Instance.pinned_az`` exists in the compute model but is"}],"source_content_type":"text/x-rst","patch_set":4,"id":"a158911c_9d25623b","line":59,"range":{"start_line":55,"start_character":0,"end_line":59,"end_character":15},"in_reply_to":"17c22567_7d9ebe02","updated":"2026-11-03 13:27:47.000000000","message":"AS we defined that this strategy is operators driven, if the instance is pinned to any AZ and the dest_az is set to the default AZ (e.g. nova), we would not block that, but we can document that is not a good pattern to follow. \nThe repin strategy is that, if a instance is pinned to an AZ, it will be repinned to the destination az (if users enable that option), otherwise we don\u0027t pin at all. Makes sense?","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"007fab4ce05ac6458414d04231d9673fc0e0b075","unresolved":true,"context_lines":[{"line_number":52,"context_line":"No compute AZ awareness"},{"line_number":53,"context_line":"-----------------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* The compute cluster data model has no ``availability_zone`` on"},{"line_number":56,"context_line":"  ``ComputeNode``. Nova\u0027s host-to-zone data is already fetched during model"},{"line_number":57,"context_line":"  build via ``nova_helper.get_service_list()`` (``Service.zone``) and then"},{"line_number":58,"context_line":"  discarded — the zone is used to select hostnames for AZ-scoped audits but"},{"line_number":59,"context_line":"  never stored."},{"line_number":60,"context_line":"* The zone of an instance\u0027s host is only half the picture. Nova also exposes"},{"line_number":61,"context_line":"  ``pinned_availability_zone``, the zone constraint the instance itself"},{"line_number":62,"context_line":"  can carries. ``Instance.pinned_az`` exists in the compute model but is"}],"source_content_type":"text/x-rst","patch_set":4,"id":"31fcd882_5888ef03","line":59,"range":{"start_line":55,"start_character":0,"end_line":59,"end_character":15},"in_reply_to":"17c22567_7d9ebe02","updated":"2026-11-02 21:48:44.000000000","message":"Do we want to include migration sources and targets which are general host aggregates, not just AZs?\n\nI think this came up during the PTG. If it\u0027s an easy thing to add (since you\u0027re already dealing with AZ aggregates), it could be uesful.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":52,"context_line":"No compute AZ awareness"},{"line_number":53,"context_line":"-----------------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* The compute cluster data model has no ``availability_zone`` on"},{"line_number":56,"context_line":"  ``ComputeNode``. Nova\u0027s host-to-zone data is already fetched during model"},{"line_number":57,"context_line":"  build via ``nova_helper.get_service_list()`` (``Service.zone``) and then"},{"line_number":58,"context_line":"  discarded — the zone is used to select hostnames for AZ-scoped audits but"},{"line_number":59,"context_line":"  never stored."},{"line_number":60,"context_line":"* The zone of an instance\u0027s host is only half the picture. Nova also exposes"},{"line_number":61,"context_line":"  ``pinned_availability_zone``, the zone constraint the instance itself"},{"line_number":62,"context_line":"  can carries. ``Instance.pinned_az`` exists in the compute model but is"}],"source_content_type":"text/x-rst","patch_set":4,"id":"c57a3a05_1ff9d0b6","line":59,"range":{"start_line":55,"start_character":0,"end_line":59,"end_character":15},"in_reply_to":"7d3c214e_d9cc5bb1","updated":"2026-11-11 22:10:40.000000000","message":"ack, so even being possible to do this, i would consider out of the scope of this spec, and we can discuss more about as an extension.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b937dc170b501a621c56c5b22d6b0d66c37cfe0f","unresolved":true,"context_lines":[{"line_number":52,"context_line":"No compute AZ awareness"},{"line_number":53,"context_line":"-----------------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* The compute cluster data model has no ``availability_zone`` on"},{"line_number":56,"context_line":"  ``ComputeNode``. Nova\u0027s host-to-zone data is already fetched during model"},{"line_number":57,"context_line":"  build via ``nova_helper.get_service_list()`` (``Service.zone``) and then"},{"line_number":58,"context_line":"  discarded — the zone is used to select hostnames for AZ-scoped audits but"},{"line_number":59,"context_line":"  never stored."},{"line_number":60,"context_line":"* The zone of an instance\u0027s host is only half the picture. Nova also exposes"},{"line_number":61,"context_line":"  ``pinned_availability_zone``, the zone constraint the instance itself"},{"line_number":62,"context_line":"  can carries. ``Instance.pinned_az`` exists in the compute model but is"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7d3c214e_d9cc5bb1","line":59,"range":{"start_line":55,"start_character":0,"end_line":59,"end_character":15},"in_reply_to":"9cb76d98_7e9cb74e","updated":"2026-11-06 15:32:18.000000000","message":"so you can build an AZ out of mulitple host aggreate all with the same metadta key\n\nand you cna have a single host  that isn in many hostaggretes\nbut a signel host can only be in 1 AZ\n\nin other words reconstucting the mappign is not trivial\n\nif we want to supprot scopign by AZ then we have to extend the scop for that\n\nwe should not try and go gthe other wasy and fiutre out if a host aggante coresponed to a AZ because a signel host aggreate can have hosts in muliple AZs.\n\nim going to try and do a fressh review of this psec form top to bottom this  commitn just caught my eye when lookign at my email.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"41ccf6dbf3032d74737d9fb032c5a7dca4848302","unresolved":true,"context_lines":[{"line_number":52,"context_line":"No compute AZ awareness"},{"line_number":53,"context_line":"-----------------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* The compute cluster data model has no ``availability_zone`` on"},{"line_number":56,"context_line":"  ``ComputeNode``. Nova\u0027s host-to-zone data is already fetched during model"},{"line_number":57,"context_line":"  build via ``nova_helper.get_service_list()`` (``Service.zone``) and then"},{"line_number":58,"context_line":"  discarded — the zone is used to select hostnames for AZ-scoped audits but"},{"line_number":59,"context_line":"  never stored."},{"line_number":60,"context_line":"* The zone of an instance\u0027s host is only half the picture. Nova also exposes"},{"line_number":61,"context_line":"  ``pinned_availability_zone``, the zone constraint the instance itself"},{"line_number":62,"context_line":"  can carries. ``Instance.pinned_az`` exists in the compute model but is"}],"source_content_type":"text/x-rst","patch_set":4,"id":"019ae877_b2b08738","line":59,"range":{"start_line":55,"start_character":0,"end_line":59,"end_character":15},"in_reply_to":"a158911c_9d25623b","updated":"2026-11-05 09:41:22.000000000","message":"@fulton@redhat.com iirc, the blocker to extend this feature to general host aggregates is that there will not be something like `destination_host_aggregate` when calling migrations for nova to schedule the live migrations, only `destination_az` so we can only apply this approach to AZs, not to host aggregates. Was that the question?","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5059bc2d6b38eb34922c56f9966a907da8c5c238","unresolved":true,"context_lines":[{"line_number":67,"context_line":"* Consequently an operator cannot say \"drain az-a into az-b\". They must"},{"line_number":68,"context_line":"  enumerate hosts, and there is no validation that the hosts they name are"},{"line_number":69,"context_line":"  actually in the zones they think."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Use Cases"},{"line_number":72,"context_line":"---------"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"29897b93_c6a56d2f","line":70,"updated":"2026-10-29 20:54:33.000000000","message":"lets capture my comemnt above in a note\n```\n.. note::\n\n   Nova derives a compute service\u0027s availability zone from host aggregate\n   metadata. Services without explicit AZ membership use the configured\n   default availability zone, normally ``nova``. Nova recommends never\n   explicitly pinning instances to this default AZ. Watcher will identify\n   it through a new ``[nova] default_availability_zone`` option and will\n   not repin instances to it.\n```\n\nsince the nova defautl az is configurable we will need a config option in watcher that allwos use to know that the defautl is. we can defautl it to `nova` to match novas default.\n\nit may be better to never pin to nova but do unpin form it if it if a vm is pinned to it.\n\nthis happens by mistagke often bcause horizon does not by defualt allow you to create a vm without passing an az and it default to nova. i think that is configurable but i dont knwo if that jsut hides the dialong of if it actully dopts the pramter when it makes the vm create request.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":true,"context_lines":[{"line_number":67,"context_line":"* Consequently an operator cannot say \"drain az-a into az-b\". They must"},{"line_number":68,"context_line":"  enumerate hosts, and there is no validation that the hosts they name are"},{"line_number":69,"context_line":"  actually in the zones they think."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Use Cases"},{"line_number":72,"context_line":"---------"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"de87cc71_25248195","line":70,"in_reply_to":"29897b93_c6a56d2f","updated":"2026-11-03 13:27:47.000000000","message":"I understand the problem, but I am not sure if should be the Watcher service that should handle that. One possibility is to allow users to select if we should always repin an instance, or just unpin and migrate?","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":67,"context_line":"* Consequently an operator cannot say \"drain az-a into az-b\". They must"},{"line_number":68,"context_line":"  enumerate hosts, and there is no validation that the hosts they name are"},{"line_number":69,"context_line":"  actually in the zones they think."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Use Cases"},{"line_number":72,"context_line":"---------"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"04f22956_69390afe","line":70,"in_reply_to":"6eb01a02_f1839b8c","updated":"2026-11-11 22:10:40.000000000","message":"ok, so it seems that we agree on Not pinning to the default az. And this needs to be set via configuration, and defaults to \u0027nova\u0027.\nSince this will be treated only at Action level, I will add the info there, since it is an specific pinning","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":67,"context_line":"* Consequently an operator cannot say \"drain az-a into az-b\". They must"},{"line_number":68,"context_line":"  enumerate hosts, and there is no validation that the hosts they name are"},{"line_number":69,"context_line":"  actually in the zones they think."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Use Cases"},{"line_number":72,"context_line":"---------"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"6eb01a02_f1839b8c","line":70,"in_reply_to":"d4b33cd2_f3d3a355","updated":"2026-11-10 19:54:37.000000000","message":"the idea was that we woudl add\n`default_availability_zone \u003d nova` as a new config option\nand never pin to that value\n\nwe are aslo dicssing if we shoudl explcity reject that going forward.\n\nso you will nolonger be abel to pass the default az wehn booting a vm or for a migration dstination i.e. it will not be possible to ever pin to the defautl az.\n\n\nhttps://bugs.launchpad.net/nova/+bug/2173771\n\nso i think we need\n```\n[nova]\ndefault_availability_zone \u003d nova (default: nova)\n```\n\nand depending on how we close that bug in nova either with dans patch\n\nhttps://review.opendev.org/c/openstack/nova/+/1014772\n\nto make requesting it a hard error\n\nor  my spec https://review.opendev.org/c/openstack/nova-specs/+/1013094\n\nwhich make schduling actully work\n\nwe need watcher to work with that.\n\ntoday if you request the implict default az nova can boot you in a host that is not part of that and is in a diffent az\n\n\nthat is clearly a bug and one that would directly impafct this feature.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"d896c05efd089ec81f51885bdc402eb66c10f16b","unresolved":true,"context_lines":[{"line_number":67,"context_line":"* Consequently an operator cannot say \"drain az-a into az-b\". They must"},{"line_number":68,"context_line":"  enumerate hosts, and there is no validation that the hosts they name are"},{"line_number":69,"context_line":"  actually in the zones they think."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Use Cases"},{"line_number":72,"context_line":"---------"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"d4b33cd2_f3d3a355","line":70,"in_reply_to":"d4ea9279_4d3a5f4f","updated":"2026-11-06 12:17:09.000000000","message":"After discussing at irc meeting, I see that is possible to include that option yes, but I also see as low priority atm, since it will only cover the case where a Cloud has instances pinned to an AZ-x and will drain to the default nova AZ (default to \u0027nova\u0027)? Is that a common deployment?","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"41ccf6dbf3032d74737d9fb032c5a7dca4848302","unresolved":true,"context_lines":[{"line_number":67,"context_line":"* Consequently an operator cannot say \"drain az-a into az-b\". They must"},{"line_number":68,"context_line":"  enumerate hosts, and there is no validation that the hosts they name are"},{"line_number":69,"context_line":"  actually in the zones they think."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Use Cases"},{"line_number":72,"context_line":"---------"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"d4ea9279_4d3a5f4f","line":70,"in_reply_to":"de87cc71_25248195","updated":"2026-11-05 09:41:22.000000000","message":"If we give the possibility to users to select if we should always repin an instance, or just unpin and migrate that\u0027d affect all pinned instances, but the problem is specifically to the `nova` (or whatever default) az. We could do something like:\n\n```\n[nova]\ndefault_availability_zone \u003d nova\nunpin_only_default_availability_zone \u003d True\n```\n\nwhere unpin_only_default_availability_zone \u003d True means \"when you need to migrate an instance pinned to the default az, just unpin it and do not repin it\". Should be this done only when migrating to a different az or always?\n\nSaid so, if, as Sean mentioned, users should never pin to this default AZ, i\u0027m also fine with just doing it unconditionally.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9242e8924af520be65b667b63aa6e11b0c35cd32","unresolved":true,"context_lines":[{"line_number":71,"context_line":"Use Cases"},{"line_number":72,"context_line":"---------"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"* ``Deployer`` takes a compute availability zone out of service for hardware"},{"line_number":75,"context_line":"  refresh, and needs every instance moved to a replacement zone, along with"},{"line_number":76,"context_line":"  the volumes those instances depend on, with the source compute services"},{"line_number":77,"context_line":"  disabled so the scheduler does not refill them mid-drain."},{"line_number":78,"context_line":"* ``Deployer`` moves only the block storage — onto other pools, or onto"},{"line_number":79,"context_line":"  volume types served by other backends — while leaving the instances where"},{"line_number":80,"context_line":"  they are."},{"line_number":81,"context_line":"* ``Deployer`` moves only the instances, leaving their volumes untouched,"},{"line_number":82,"context_line":"  because the storage behind them is reachable from both compute zones."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Proposed Change"},{"line_number":85,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3ecf7fbb_5db89d7c","line":82,"range":{"start_line":74,"start_character":0,"end_line":82,"end_character":71},"updated":"2026-10-29 19:20:05.000000000","message":"i woudl prefer if you wrote his in the form of \n`As a \u003cpersona\u003e i would like to do \u003ccapablity\u003e because \u003creason\u003e`\n\ni get what your tryign to say here but these feel very aburpt and jaryign when i read them\n\n\n\n```suggestion\nAs a Deployer i would like to do a migration of every instance\nand its dependent volumes to a replacement zone with source\ncompute services disabled because the compute availability zone\nis being taken out of service for a hardware refresh and the\nscheduler must not refill it mid-drain.\n\nAs a Deployer i would like to do a migration of only the block\nstorage onto other pools or volume types served by other backends\nwhile leaving the instances where they are because the compute\ninstances do not need to be moved.\n\nAs a Deployer i would like to do a migration of only the\ninstances while leaving their volumes untouched because the\nstorage behind them is reachable from both compute zones.\n```","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":71,"context_line":"Use Cases"},{"line_number":72,"context_line":"---------"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"* ``Deployer`` takes a compute availability zone out of service for hardware"},{"line_number":75,"context_line":"  refresh, and needs every instance moved to a replacement zone, along with"},{"line_number":76,"context_line":"  the volumes those instances depend on, with the source compute services"},{"line_number":77,"context_line":"  disabled so the scheduler does not refill them mid-drain."},{"line_number":78,"context_line":"* ``Deployer`` moves only the block storage — onto other pools, or onto"},{"line_number":79,"context_line":"  volume types served by other backends — while leaving the instances where"},{"line_number":80,"context_line":"  they are."},{"line_number":81,"context_line":"* ``Deployer`` moves only the instances, leaving their volumes untouched,"},{"line_number":82,"context_line":"  because the storage behind them is reachable from both compute zones."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Proposed Change"},{"line_number":85,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"afb0d7f7_1d52df2d","line":82,"range":{"start_line":74,"start_character":0,"end_line":82,"end_character":71},"in_reply_to":"3ecf7fbb_5db89d7c","updated":"2026-11-03 13:27:47.000000000","message":"Works for me, current text is the outcome of a: \"make this spec more compact/brief\" command in the end.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9242e8924af520be65b667b63aa6e11b0c35cd32","unresolved":true,"context_lines":[{"line_number":84,"context_line":"Proposed Change"},{"line_number":85,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"A compute AZ drain expressed through two input parameters,"},{"line_number":88,"context_line":"``compute_nodes`` and ``storage_pools``. This spec does not prescribe"},{"line_number":89,"context_line":"which strategy implements them: extending the existing ``zone_migration``"},{"line_number":90,"context_line":"strategy is one path; introducing a dedicated new strategy is another."},{"line_number":91,"context_line":"Both paths share the input schema and action semantics described here;"},{"line_number":92,"context_line":"the implementation choice is left to the assignee."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"``compute_nodes`` accepts a second kind of entry, ``{src_az, dst_az}``,"},{"line_number":95,"context_line":"beside ``{src_node, dst_node}``, and two per-entry booleans:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"4d6ed03b_9bc6d326","line":92,"range":{"start_line":87,"start_character":0,"end_line":92,"end_character":50},"updated":"2026-10-29 19:20:05.000000000","message":"so we need to decide that in the spec up front and move one of the two option to the alternatives\n\nthis is not something that should be delegated to the implementation\n\nso -1 until we rewrite the spec to define which approch we actuly take.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Proposed Change"},{"line_number":85,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"A compute AZ drain expressed through two input parameters,"},{"line_number":88,"context_line":"``compute_nodes`` and ``storage_pools``. This spec does not prescribe"},{"line_number":89,"context_line":"which strategy implements them: extending the existing ``zone_migration``"},{"line_number":90,"context_line":"strategy is one path; introducing a dedicated new strategy is another."},{"line_number":91,"context_line":"Both paths share the input schema and action semantics described here;"},{"line_number":92,"context_line":"the implementation choice is left to the assignee."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"``compute_nodes`` accepts a second kind of entry, ``{src_az, dst_az}``,"},{"line_number":95,"context_line":"beside ``{src_node, dst_node}``, and two per-entry booleans:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"406d04a7_e85ffa23","line":92,"range":{"start_line":87,"start_character":0,"end_line":92,"end_character":50},"in_reply_to":"09600096_db7c7d07","updated":"2026-11-03 13:27:47.000000000","message":"Done","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b0a040dab5818cdf0d1ed7629552e8709e523f24","unresolved":true,"context_lines":[{"line_number":84,"context_line":"Proposed Change"},{"line_number":85,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"A compute AZ drain expressed through two input parameters,"},{"line_number":88,"context_line":"``compute_nodes`` and ``storage_pools``. This spec does not prescribe"},{"line_number":89,"context_line":"which strategy implements them: extending the existing ``zone_migration``"},{"line_number":90,"context_line":"strategy is one path; introducing a dedicated new strategy is another."},{"line_number":91,"context_line":"Both paths share the input schema and action semantics described here;"},{"line_number":92,"context_line":"the implementation choice is left to the assignee."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"``compute_nodes`` accepts a second kind of entry, ``{src_az, dst_az}``,"},{"line_number":95,"context_line":"beside ``{src_node, dst_node}``, and two per-entry booleans:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"09600096_db7c7d07","line":92,"range":{"start_line":87,"start_character":0,"end_line":92,"end_character":50},"in_reply_to":"4d6ed03b_9bc6d326","updated":"2026-10-30 15:14:52.000000000","message":"I will update the spec and define as an extension of zone_migration. I believe that is the best long term approach. A new strategy would work, but it would be two similar strategies to maintain, and next thing would be to deprecate one of them.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5059bc2d6b38eb34922c56f9966a907da8c5c238","unresolved":true,"context_lines":[{"line_number":84,"context_line":"Proposed Change"},{"line_number":85,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"A compute AZ drain expressed through two input parameters,"},{"line_number":88,"context_line":"``compute_nodes`` and ``storage_pools``. This spec does not prescribe"},{"line_number":89,"context_line":"which strategy implements them: extending the existing ``zone_migration``"},{"line_number":90,"context_line":"strategy is one path; introducing a dedicated new strategy is another."},{"line_number":91,"context_line":"Both paths share the input schema and action semantics described here;"},{"line_number":92,"context_line":"the implementation choice is left to the assignee."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"``compute_nodes`` accepts a second kind of entry, ``{src_az, dst_az}``,"},{"line_number":95,"context_line":"beside ``{src_node, dst_node}``, and two per-entry booleans:"},{"line_number":96,"context_line":"``skip_az_pinned_instances``, deciding what happens to instances carrying a"},{"line_number":97,"context_line":"zone pin, and ``disable_source_nodes``, disabling the entry\u0027s source nodes"},{"line_number":98,"context_line":"before the drain. ``storage_pools`` accepts a type-only entry, ``{src_type,"},{"line_number":99,"context_line":"dst_type}``, beside its pool-anchored entries, and an optional per-entry"},{"line_number":100,"context_line":"``attached_only`` flag."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Every new option is per entry. One audit can therefore drain two zones under"},{"line_number":103,"context_line":"different pin policies, or disable the source nodes of one entry and not"},{"line_number":104,"context_line":"another."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"What an audit drains follows from which parameters are supplied:"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"f46729dd_5d582bf7","line":104,"range":{"start_line":87,"start_character":0,"end_line":104,"end_character":8},"updated":"2026-10-29 20:54:33.000000000","message":"i have a hard time reading this without first lookign up the exsitng parmater so i have tried to capture that below\n\n```\nThis proposal extends ``zone_migration`` to support draining a compute\navailability zone. It builds on the existing ``compute_nodes`` and\n``storage_pools`` parameters.\n\nThe ``compute_nodes`` parameter currently selects source hosts through\n``src_node``. Each entry may also provide ``dst_node`` to select a\ndestination host. Without it, Nova chooses the destination.\n\nTo enable AZ selection, ``src_az`` and ``dst_az`` will be added to specify\nthe source and destination compute availability zones instead of host names.\nWatcher selects source hosts in ``src_az`` and requests migrations to\n``dst_az``, leaving Nova to choose destination hosts within that zone.\n\nSelecting a destination availability zone depends on a proposed Nova API\nchange to accept an AZ as the migration destination. This enhancement is\ncurrently tracked by the `Nova cross-cell live migration blueprint`_.\n\n.. _Nova cross-cell live migration blueprint:\n   https://blueprints.launchpad.net/nova/+spec/cross-cell-live-migration\n\nCompute entries also gain two optional booleans.\n``skip_az_pinned_instances`` controls whether to skip instances whose pins\nconflict with the requested destination. ``disable_source_nodes`` controls\nwhether to disable the selected source compute services before migrating\ninstances.\n\nThe ``storage_pools`` parameter currently requires a source pool, with an\noptional source type to narrow the selection. This change allows volumes to\nbe selected by ``src_pool`` or ``src_type``. Specifying both selects only\nvolumes of that type in that pool. Selecting by type alone includes matching\nvolumes across pools in the scoped storage model.\n\nFor either selection, the destination determines the operation. Specifying\n``dst_pool`` migrates volumes to that pool while preserving their original\ntype. Specifying ``dst_type`` retypes volumes and lets Cinder move them if\nthe new type requires it.\n\nA new ``attached_only`` option further restricts the selection to volumes\nattached to instances this audit is migrating.\n\nThe new options apply per entry. One audit can therefore drain two zones\nunder different pin policies, or disable the source nodes of one entry\nand not another.\n```","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Proposed Change"},{"line_number":85,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"A compute AZ drain expressed through two input parameters,"},{"line_number":88,"context_line":"``compute_nodes`` and ``storage_pools``. This spec does not prescribe"},{"line_number":89,"context_line":"which strategy implements them: extending the existing ``zone_migration``"},{"line_number":90,"context_line":"strategy is one path; introducing a dedicated new strategy is another."},{"line_number":91,"context_line":"Both paths share the input schema and action semantics described here;"},{"line_number":92,"context_line":"the implementation choice is left to the assignee."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"``compute_nodes`` accepts a second kind of entry, ``{src_az, dst_az}``,"},{"line_number":95,"context_line":"beside ``{src_node, dst_node}``, and two per-entry booleans:"},{"line_number":96,"context_line":"``skip_az_pinned_instances``, deciding what happens to instances carrying a"},{"line_number":97,"context_line":"zone pin, and ``disable_source_nodes``, disabling the entry\u0027s source nodes"},{"line_number":98,"context_line":"before the drain. ``storage_pools`` accepts a type-only entry, ``{src_type,"},{"line_number":99,"context_line":"dst_type}``, beside its pool-anchored entries, and an optional per-entry"},{"line_number":100,"context_line":"``attached_only`` flag."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Every new option is per entry. One audit can therefore drain two zones under"},{"line_number":103,"context_line":"different pin policies, or disable the source nodes of one entry and not"},{"line_number":104,"context_line":"another."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"What an audit drains follows from which parameters are supplied:"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"e5af4703_8f7d20b8","line":104,"range":{"start_line":87,"start_character":0,"end_line":104,"end_character":8},"in_reply_to":"f46729dd_5d582bf7","updated":"2026-11-03 13:27:47.000000000","message":"Ack, yeah i reduced the amount of lines to make it smaller, but it seems that become confusing for users to understand. I am ok with the more detailed explanation yes.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5059bc2d6b38eb34922c56f9966a907da8c5c238","unresolved":true,"context_lines":[{"line_number":102,"context_line":"Every new option is per entry. One audit can therefore drain two zones under"},{"line_number":103,"context_line":"different pin policies, or disable the source nodes of one entry and not"},{"line_number":104,"context_line":"another."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"What an audit drains follows from which parameters are supplied:"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":".. list-table:: What each combination drains"},{"line_number":109,"context_line":"   :header-rows: 1"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"   * - Parameters supplied"},{"line_number":112,"context_line":"     - Result"},{"line_number":113,"context_line":"   * - ``compute_nodes``"},{"line_number":114,"context_line":"     - instances only"},{"line_number":115,"context_line":"   * - ``storage_pools``"},{"line_number":116,"context_line":"     - volumes only"},{"line_number":117,"context_line":"   * - both"},{"line_number":118,"context_line":"     - instances ``and all volumes`` of the named types"},{"line_number":119,"context_line":"   * - both, with ``attached_only``"},{"line_number":120,"context_line":"     - instances and only the volumes attached to them"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"``storage_pools`` makes no zone claim. It maps pools and volume types onto"},{"line_number":123,"context_line":"pools and volume types, and the operator\u0027s mapping is the declaration of"}],"source_content_type":"text/x-rst","patch_set":4,"id":"c2d2cdfe_1fe98702","line":120,"range":{"start_line":105,"start_character":0,"end_line":120,"end_character":54},"updated":"2026-10-29 20:54:33.000000000","message":"if we make the chagne above i woudl also suggest updating this lilke this\n\n```\nThe supplied parameters determine which workloads an audit selects:\n\n.. list-table:: Workload selection\n   :header-rows: 1\n\n   * - Parameters supplied\n     - Selected workloads\n   * - ``compute_nodes`` only\n     - Instances selected by the compute entries.\n   * - ``storage_pools`` only, with ``attached_only`` disabled\n     - Volumes selected by the storage entries.\n   * - Both, with ``attached_only`` disabled\n     - Instances and volumes selected independently by their respective\n       entries.\n   * - Both, with ``attached_only`` enabled on a storage entry\n     - Instances selected by the compute entries. That storage entry selects\n       only matching volumes attached to instances this audit is migrating.\n\n``attached_only`` further filters an entry\u0027s source pool and type selection.\nIt does not select volumes outside those filters. Other storage entries\nwithout ``attached_only`` continue to select volumes independently.\n```","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":102,"context_line":"Every new option is per entry. One audit can therefore drain two zones under"},{"line_number":103,"context_line":"different pin policies, or disable the source nodes of one entry and not"},{"line_number":104,"context_line":"another."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"What an audit drains follows from which parameters are supplied:"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":".. list-table:: What each combination drains"},{"line_number":109,"context_line":"   :header-rows: 1"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"   * - Parameters supplied"},{"line_number":112,"context_line":"     - Result"},{"line_number":113,"context_line":"   * - ``compute_nodes``"},{"line_number":114,"context_line":"     - instances only"},{"line_number":115,"context_line":"   * - ``storage_pools``"},{"line_number":116,"context_line":"     - volumes only"},{"line_number":117,"context_line":"   * - both"},{"line_number":118,"context_line":"     - instances ``and all volumes`` of the named types"},{"line_number":119,"context_line":"   * - both, with ``attached_only``"},{"line_number":120,"context_line":"     - instances and only the volumes attached to them"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"``storage_pools`` makes no zone claim. It maps pools and volume types onto"},{"line_number":123,"context_line":"pools and volume types, and the operator\u0027s mapping is the declaration of"}],"source_content_type":"text/x-rst","patch_set":4,"id":"abf44482_b090a552","line":120,"range":{"start_line":105,"start_character":0,"end_line":120,"end_character":54},"in_reply_to":"c2d2cdfe_1fe98702","updated":"2026-11-03 13:27:47.000000000","message":"Done","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5059bc2d6b38eb34922c56f9966a907da8c5c238","unresolved":true,"context_lines":[{"line_number":122,"context_line":"``storage_pools`` makes no zone claim. It maps pools and volume types onto"},{"line_number":123,"context_line":"pools and volume types, and the operator\u0027s mapping is the declaration of"},{"line_number":124,"context_line":"where those volumes should end up. Watcher cannot make that declaration for"},{"line_number":125,"context_line":"them: a volume type is not an identifier for a backend or for a zone — one"},{"line_number":126,"context_line":"type can be served by several backends in several Cinder AZs, and one backend"},{"line_number":127,"context_line":"can be exposed through several types — so a destination volume type is not"},{"line_number":128,"context_line":"derivable from a compute zone, and neither is a destination pool."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Narrowing a drain is the ``audit scope``\u0027s job. The scope is applied before"}],"source_content_type":"text/x-rst","patch_set":4,"id":"100ba34c_946fd9af","line":127,"range":{"start_line":125,"start_character":69,"end_line":127,"end_character":39},"updated":"2026-10-29 20:54:33.000000000","message":"i would swap hte `-` for `,` in both places.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":122,"context_line":"``storage_pools`` makes no zone claim. It maps pools and volume types onto"},{"line_number":123,"context_line":"pools and volume types, and the operator\u0027s mapping is the declaration of"},{"line_number":124,"context_line":"where those volumes should end up. Watcher cannot make that declaration for"},{"line_number":125,"context_line":"them: a volume type is not an identifier for a backend or for a zone — one"},{"line_number":126,"context_line":"type can be served by several backends in several Cinder AZs, and one backend"},{"line_number":127,"context_line":"can be exposed through several types — so a destination volume type is not"},{"line_number":128,"context_line":"derivable from a compute zone, and neither is a destination pool."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Narrowing a drain is the ``audit scope``\u0027s job. The scope is applied before"}],"source_content_type":"text/x-rst","patch_set":4,"id":"a278dc0b_6a32ee3d","line":127,"range":{"start_line":125,"start_character":69,"end_line":127,"end_character":39},"in_reply_to":"100ba34c_946fd9af","updated":"2026-11-03 13:27:47.000000000","message":"ack","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5059bc2d6b38eb34922c56f9966a907da8c5c238","unresolved":true,"context_lines":[{"line_number":131,"context_line":"the strategy sees the cluster data model, so a node excluded there yields no"},{"line_number":132,"context_line":"source and no action. To drain ``az-a`` except for two hosts, supply the zone"},{"line_number":133,"context_line":"pair on the strategy and exclude those hosts in the audit template\u0027s scope."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"The central design decision is that"},{"line_number":136,"context_line":"``Watcher does not choose destination hosts``."},{"line_number":137,"context_line":"A separate Nova feature lets a migration request carry a destination"},{"line_number":138,"context_line":"*availability zone* instead of a destination host. The strategy emits"},{"line_number":139,"context_line":"that, and the Nova scheduler places the instance. This keeps the strategy"}],"source_content_type":"text/x-rst","patch_set":4,"id":"87c27243_59f004a6","line":136,"range":{"start_line":134,"start_character":0,"end_line":136,"end_character":46},"updated":"2026-10-29 20:54:33.000000000","message":"i woupd proably lead with this as the first sentance ot the propeose chages secion and dorp the rest of the paragrah\n\ni.e. \n\n```\nThe central design decision of this proposal is that Watcher does not\nchoose destination hosts, this is delegated to nova and depend on a\nnew feature tracked by the `Nova cross-cell live migration blueprint`_.\n\n.. _Nova cross-cell live migration blueprint:\n   https://blueprints.launchpad.net/nova/+spec/cross-cell-live-migration\n```\n\nif we put this up front it level set the dicussion.\n\nbecause without that feature wtacher could  selct form the subset of host in an az itself and we coudl implemnt that via the stragiey host filtierign feature you were also presentign at the ptg.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":131,"context_line":"the strategy sees the cluster data model, so a node excluded there yields no"},{"line_number":132,"context_line":"source and no action. To drain ``az-a`` except for two hosts, supply the zone"},{"line_number":133,"context_line":"pair on the strategy and exclude those hosts in the audit template\u0027s scope."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"The central design decision is that"},{"line_number":136,"context_line":"``Watcher does not choose destination hosts``."},{"line_number":137,"context_line":"A separate Nova feature lets a migration request carry a destination"},{"line_number":138,"context_line":"*availability zone* instead of a destination host. The strategy emits"},{"line_number":139,"context_line":"that, and the Nova scheduler places the instance. This keeps the strategy"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5e80ecb2_91fca7bc","line":136,"range":{"start_line":134,"start_character":0,"end_line":136,"end_character":46},"in_reply_to":"87c27243_59f004a6","updated":"2026-11-03 13:27:47.000000000","message":"Yeah,sounds better at the start of the section, not at the conclusion, for those that are reading for the first time","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5059bc2d6b38eb34922c56f9966a907da8c5c238","unresolved":true,"context_lines":[{"line_number":143,"context_line":"Input schema"},{"line_number":144,"context_line":"------------"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"A full zone drain reads::"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    {"},{"line_number":149,"context_line":"      \"compute_nodes\": ["}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a063390_edfbeaf6","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":25},"updated":"2026-10-29 20:54:33.000000000","message":"`An example of a request to drain an AZ is as follows::`\nor \n`A request to drain an az woudl look like this::`","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":143,"context_line":"Input schema"},{"line_number":144,"context_line":"------------"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"A full zone drain reads::"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    {"},{"line_number":149,"context_line":"      \"compute_nodes\": ["}],"source_content_type":"text/x-rst","patch_set":4,"id":"7ef293d6_be82e712","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":25},"in_reply_to":"7a063390_edfbeaf6","updated":"2026-11-03 13:27:47.000000000","message":"Done","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5059bc2d6b38eb34922c56f9966a907da8c5c238","unresolved":true,"context_lines":[{"line_number":163,"context_line":"  required. The two kinds are strictly either/or — an entry mixing keys from"},{"line_number":164,"context_line":"  both is rejected — and both may appear in the same array."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"  ``skip_az_pinned_instances`` is a boolean, default ``false``, valid on either"},{"line_number":167,"context_line":"  kind. It decides what happens to an instance whose"},{"line_number":168,"context_line":"  ``pinned_availability_zone`` conflicts with where the entry would send it."},{"line_number":169,"context_line":"  See `Pinned instances`_."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"  ``disable_source_nodes`` is a boolean, default ``false``, valid on either"},{"line_number":172,"context_line":"  kind. It disables the compute service of every source node the entry"}],"source_content_type":"text/x-rst","patch_set":4,"id":"d873c644_9ba8a461","line":169,"range":{"start_line":166,"start_character":1,"end_line":169,"end_character":26},"updated":"2026-10-29 20:54:33.000000000","message":"```\n``skip_az_pinned_instances`` is a boolean, default ``false``.\n  It controls whether a pinned instance is a candidate for inclusion\n  in the action plan when the destination AZ differs from its\n  ``pinned_availability_zone``. When ``true``, the instance is excluded;\n  when ``false``, it remains a candidate. When neither a destination host\n  nor a destination AZ is supplied, any existing pin is preserved.\n  See `Pinned instances`_.\n```","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"d896c05efd089ec81f51885bdc402eb66c10f16b","unresolved":true,"context_lines":[{"line_number":163,"context_line":"  required. The two kinds are strictly either/or — an entry mixing keys from"},{"line_number":164,"context_line":"  both is rejected — and both may appear in the same array."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"  ``skip_az_pinned_instances`` is a boolean, default ``false``, valid on either"},{"line_number":167,"context_line":"  kind. It decides what happens to an instance whose"},{"line_number":168,"context_line":"  ``pinned_availability_zone`` conflicts with where the entry would send it."},{"line_number":169,"context_line":"  See `Pinned instances`_."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"  ``disable_source_nodes`` is a boolean, default ``false``, valid on either"},{"line_number":172,"context_line":"  kind. It disables the compute service of every source node the entry"}],"source_content_type":"text/x-rst","patch_set":4,"id":"283e26f5_88c7d520","line":169,"range":{"start_line":166,"start_character":1,"end_line":169,"end_character":26},"in_reply_to":"1597fbb6_05d8a163","updated":"2026-11-06 12:17:09.000000000","message":"Using this thread to continue with the discussion. We also chat about it in the irc meeting (Nov 5th).\nSo skipping in the Action will have another Con: a continuous audit will always proposed again the Skipped instance for new APs, even if previous APs where executed. While skipping in the strategy will, at some point (after collector updates), change the solution based on model updates. By relying in the model we will have more chances to retrieve this info from future notifications, possibly.\nSo, yesterday I was leaning more to this sencond approach (Action) but today I am more in favor of continue in the Strategy.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"41ccf6dbf3032d74737d9fb032c5a7dca4848302","unresolved":true,"context_lines":[{"line_number":163,"context_line":"  required. The two kinds are strictly either/or — an entry mixing keys from"},{"line_number":164,"context_line":"  both is rejected — and both may appear in the same array."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"  ``skip_az_pinned_instances`` is a boolean, default ``false``, valid on either"},{"line_number":167,"context_line":"  kind. It decides what happens to an instance whose"},{"line_number":168,"context_line":"  ``pinned_availability_zone`` conflicts with where the entry would send it."},{"line_number":169,"context_line":"  See `Pinned instances`_."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"  ``disable_source_nodes`` is a boolean, default ``false``, valid on either"},{"line_number":172,"context_line":"  kind. It disables the compute service of every source node the entry"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1597fbb6_05d8a163","line":169,"range":{"start_line":166,"start_character":1,"end_line":169,"end_character":26},"in_reply_to":"1b34e8a5_d997b813","updated":"2026-11-05 09:41:22.000000000","message":"I think doing the skip in the migrate action when i.e. the instance it\u0027s not in the expected source_az is fine to manage any conflicting cases right before execution (i.e. a vm has been moved between the time when the AP was created and it is executed) but I don\u0027t like defer all that to the action execution. I think that also the strategy should manage the cases according to the last information in the model. We still have the periodic nova collection and we could also request nova to send a notification that we may process to update the model?","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"33038d61c1eb3ebd0ad84cde2e0e13275f4d1dd6","unresolved":true,"context_lines":[{"line_number":163,"context_line":"  required. The two kinds are strictly either/or — an entry mixing keys from"},{"line_number":164,"context_line":"  both is rejected — and both may appear in the same array."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"  ``skip_az_pinned_instances`` is a boolean, default ``false``, valid on either"},{"line_number":167,"context_line":"  kind. It decides what happens to an instance whose"},{"line_number":168,"context_line":"  ``pinned_availability_zone`` conflicts with where the entry would send it."},{"line_number":169,"context_line":"  See `Pinned instances`_."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"  ``disable_source_nodes`` is a boolean, default ``false``, valid on either"},{"line_number":172,"context_line":"  kind. It disables the compute service of every source node the entry"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7812d81e_989770e4","line":169,"range":{"start_line":166,"start_character":1,"end_line":169,"end_character":26},"in_reply_to":"283e26f5_88c7d520","updated":"2026-11-06 12:49:55.000000000","message":"Yes, that\u0027s correct. Actually, with the skip-in-action approach, using skip_az_pinned_instances\u003dtrue, even after all the non-pinned instances have been migrated, the audit would keep creating non-empty APs if there is any pinned instance. That\u0027d be confussing imo.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"9d3f900858f42f9587f158e72213f4039460e825","unresolved":false,"context_lines":[{"line_number":163,"context_line":"  required. The two kinds are strictly either/or — an entry mixing keys from"},{"line_number":164,"context_line":"  both is rejected — and both may appear in the same array."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"  ``skip_az_pinned_instances`` is a boolean, default ``false``, valid on either"},{"line_number":167,"context_line":"  kind. It decides what happens to an instance whose"},{"line_number":168,"context_line":"  ``pinned_availability_zone`` conflicts with where the entry would send it."},{"line_number":169,"context_line":"  See `Pinned instances`_."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"  ``disable_source_nodes`` is a boolean, default ``false``, valid on either"},{"line_number":172,"context_line":"  kind. It disables the compute service of every source node the entry"}],"source_content_type":"text/x-rst","patch_set":4,"id":"4fe2e861_a16d7641","line":169,"range":{"start_line":166,"start_character":1,"end_line":169,"end_character":26},"in_reply_to":"5f60fc9a_f3961383","updated":"2026-11-09 18:45:12.000000000","message":"I get back to original proposal, thanks for all your inputs here.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"ff9bb0ef84c2441c1a1baf1e3f3ccf3b6bd8a2ce","unresolved":true,"context_lines":[{"line_number":163,"context_line":"  required. The two kinds are strictly either/or — an entry mixing keys from"},{"line_number":164,"context_line":"  both is rejected — and both may appear in the same array."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"  ``skip_az_pinned_instances`` is a boolean, default ``false``, valid on either"},{"line_number":167,"context_line":"  kind. It decides what happens to an instance whose"},{"line_number":168,"context_line":"  ``pinned_availability_zone`` conflicts with where the entry would send it."},{"line_number":169,"context_line":"  See `Pinned instances`_."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"  ``disable_source_nodes`` is a boolean, default ``false``, valid on either"},{"line_number":172,"context_line":"  kind. It disables the compute service of every source node the entry"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f60fc9a_f3961383","line":169,"range":{"start_line":166,"start_character":1,"end_line":169,"end_character":26},"in_reply_to":"7812d81e_989770e4","updated":"2026-11-06 16:38:45.000000000","message":"Trying to wrap my head around the problem, IIUC we could have wrong action plans even checking both in the strategy and action:\n\nCDM has no pin but instance is pinned \u003d\u003e propose the migration and the action with updated information will do the right thing\n\nCDM has no pin and instance is not pinned \u003d\u003e migrate, this is correct\n\nCDM has instance pinned and instance is not pinned (`repin_az_pinned_instances` is True) \u003d\u003e migrate, the action with updated should detect that there is no pin and proceed correctly \n\nCDM has instance pinned and instance is not pinned (`repin_az_pinned_instances` is False) \u003d\u003e skip the migration incorrectly, this is the most problematic case, can be mitigated running a continuous audit (which is probably a good idea anyway if moving many vms)\n\nCDM has instance pinned and instance is pinned \u003d\u003e propose the migration or not according to `repin_az_pinned_instances`, this will be correct as well\n\nIMO even the problematic case is not that bad as long as we document the limitation well and users are aware that changes in instance pins will take some time to propagate to the CDM","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":true,"context_lines":[{"line_number":163,"context_line":"  required. The two kinds are strictly either/or — an entry mixing keys from"},{"line_number":164,"context_line":"  both is rejected — and both may appear in the same array."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"  ``skip_az_pinned_instances`` is a boolean, default ``false``, valid on either"},{"line_number":167,"context_line":"  kind. It decides what happens to an instance whose"},{"line_number":168,"context_line":"  ``pinned_availability_zone`` conflicts with where the entry would send it."},{"line_number":169,"context_line":"  See `Pinned instances`_."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"  ``disable_source_nodes`` is a boolean, default ``false``, valid on either"},{"line_number":172,"context_line":"  kind. It disables the compute service of every source node the entry"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1b34e8a5_d997b813","line":169,"range":{"start_line":166,"start_character":1,"end_line":169,"end_character":26},"in_reply_to":"d873c644_9ba8a461","updated":"2026-11-03 13:27:47.000000000","message":"I am proposing a new workflow for pinned instances, since we can\u0027t guarantee that current info in the model is the most recent one. In the new proposal, the decision around skipping or re-pin will be at Action Migrate time, when we can retrieve latest info from each instance and decide around pinned azs. The issue with checking the model\u0027s value is that we don\u0027t receive any update about req_spec changes in nova.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5059bc2d6b38eb34922c56f9966a907da8c5c238","unresolved":true,"context_lines":[{"line_number":168,"context_line":"  ``pinned_availability_zone`` conflicts with where the entry would send it."},{"line_number":169,"context_line":"  See `Pinned instances`_."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"  ``disable_source_nodes`` is a boolean, default ``false``, valid on either"},{"line_number":172,"context_line":"  kind. It disables the compute service of every source node the entry"},{"line_number":173,"context_line":"  resolves to, before the migrations. See `Disabling source nodes`_."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"``storage_pools``"}],"source_content_type":"text/x-rst","patch_set":4,"id":"88321327_176ec38a","line":172,"range":{"start_line":171,"start_character":59,"end_line":172,"end_character":8},"updated":"2026-10-29 20:54:33.000000000","message":"we do not need to repate valid on either kind just stat the defaut and data type\n\nsayign valid on either kidn make the read ready back up to know hwat kidn means in this context so its kind of distracting.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":168,"context_line":"  ``pinned_availability_zone`` conflicts with where the entry would send it."},{"line_number":169,"context_line":"  See `Pinned instances`_."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"  ``disable_source_nodes`` is a boolean, default ``false``, valid on either"},{"line_number":172,"context_line":"  kind. It disables the compute service of every source node the entry"},{"line_number":173,"context_line":"  resolves to, before the migrations. See `Disabling source nodes`_."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"``storage_pools``"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ac050bbb_dd95bc9b","line":172,"range":{"start_line":171,"start_character":59,"end_line":172,"end_character":8},"in_reply_to":"88321327_176ec38a","updated":"2026-11-03 13:27:47.000000000","message":"Done","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5059bc2d6b38eb34922c56f9966a907da8c5c238","unresolved":true,"context_lines":[{"line_number":173,"context_line":"  resolves to, before the migrations. See `Disabling source nodes`_."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"``storage_pools``"},{"line_number":176,"context_line":"  Each entry is one of three kinds: ``{src_pool, dst_pool}``,"},{"line_number":177,"context_line":"  ``{src_pool, dst_type}``, or ``{src_type, dst_type}``. The first two are"},{"line_number":178,"context_line":"  pool-anchored and may narrow their selection with ``src_type``. The third"},{"line_number":179,"context_line":"  selects every volume of that ``src_type``, in any pool, which extends"},{"line_number":180,"context_line":"  operator\u0027s possibilities when used together with storage scopes."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"  ``dst_pool`` and ``dst_type`` are two different destinations, not two ways"},{"line_number":183,"context_line":"  of naming one. ``dst_pool`` moves the volume to that pool and leaves its"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ae479ac4_24ca95c9","line":180,"range":{"start_line":176,"start_character":1,"end_line":180,"end_character":66},"updated":"2026-10-29 20:54:33.000000000","message":"```\n  Each entry requires at least one of ``src_pool`` or ``src_type``.\n  ``src_pool`` selects volumes in that pool; ``src_type`` selects volumes\n  of that type across pools in the scoped storage model. Supplying both\n  selects only volumes of that type in that pool.\n\n  Either source selection must be paired with exactly one destination,\n  ``dst_pool`` or ``dst_type``. An entry specifying both is rejected because\n  Cinder cannot migrate and retype the same volume at the same time. The\n  source fields only filter volumes and do not choose the API operation,\n  so specifying both ``src_pool`` and ``src_type`` is allowed. Type-only\n  entries support both ``{src_type, dst_pool}`` and\n  ``{src_type, dst_type}``.\n```","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":173,"context_line":"  resolves to, before the migrations. See `Disabling source nodes`_."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"``storage_pools``"},{"line_number":176,"context_line":"  Each entry is one of three kinds: ``{src_pool, dst_pool}``,"},{"line_number":177,"context_line":"  ``{src_pool, dst_type}``, or ``{src_type, dst_type}``. The first two are"},{"line_number":178,"context_line":"  pool-anchored and may narrow their selection with ``src_type``. The third"},{"line_number":179,"context_line":"  selects every volume of that ``src_type``, in any pool, which extends"},{"line_number":180,"context_line":"  operator\u0027s possibilities when used together with storage scopes."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"  ``dst_pool`` and ``dst_type`` are two different destinations, not two ways"},{"line_number":183,"context_line":"  of naming one. ``dst_pool`` moves the volume to that pool and leaves its"}],"source_content_type":"text/x-rst","patch_set":4,"id":"6d2f144d_d8d3f9dc","line":180,"range":{"start_line":176,"start_character":1,"end_line":180,"end_character":66},"in_reply_to":"ae479ac4_24ca95c9","updated":"2026-11-03 13:27:47.000000000","message":"Done","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5059bc2d6b38eb34922c56f9966a907da8c5c238","unresolved":true,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"  ``attached_only`` is an optional boolean, default ``false``, valid on any"},{"line_number":191,"context_line":"  entry. When true the entry selects only those volumes attached to an"},{"line_number":192,"context_line":"  instance ``this audit is migrating``. It therefore requires"},{"line_number":193,"context_line":"  ``compute_nodes``: without it nothing is migrating, the entry selects"},{"line_number":194,"context_line":"  nothing, and the audit is a silent no-op."},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"Everything expressible against the parameters alone is a schema error at"},{"line_number":197,"context_line":"audit creation. Keeping these rules in the schema is deliberate — it is the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"70ebc268_bcb8e5ee","line":194,"range":{"start_line":192,"start_character":40,"end_line":194,"end_character":43},"updated":"2026-10-29 20:54:33.000000000","message":"```\n If any storage entry enables it,\n  ``compute_nodes`` must contain at least one host-based or AZ-based entry.\n  Missing or empty compute selection is rejected with HTTP 400 Bad Request\n  when creating an audit or defining an audit template\u0027s\n  ``default_parameters``. If a valid compute selection yields no migrating\n  instances when the audit runs, the entry selects no volumes.\n```","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"  ``attached_only`` is an optional boolean, default ``false``, valid on any"},{"line_number":191,"context_line":"  entry. When true the entry selects only those volumes attached to an"},{"line_number":192,"context_line":"  instance ``this audit is migrating``. It therefore requires"},{"line_number":193,"context_line":"  ``compute_nodes``: without it nothing is migrating, the entry selects"},{"line_number":194,"context_line":"  nothing, and the audit is a silent no-op."},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"Everything expressible against the parameters alone is a schema error at"},{"line_number":197,"context_line":"audit creation. Keeping these rules in the schema is deliberate — it is the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"49c036ba_4cde285d","line":194,"range":{"start_line":192,"start_character":40,"end_line":194,"end_character":43},"in_reply_to":"70ebc268_bcb8e5ee","updated":"2026-11-03 13:27:47.000000000","message":"Ack, makes sense to validate that.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5059bc2d6b38eb34922c56f9966a907da8c5c238","unresolved":true,"context_lines":[{"line_number":193,"context_line":"  ``compute_nodes``: without it nothing is migrating, the entry selects"},{"line_number":194,"context_line":"  nothing, and the audit is a silent no-op."},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"Everything expressible against the parameters alone is a schema error at"},{"line_number":197,"context_line":"audit creation. Keeping these rules in the schema is deliberate — it is the"},{"line_number":198,"context_line":"only layer that answers at ``POST /v1/audits`` rather than when the audit"},{"line_number":199,"context_line":"runs. The rules that need the cluster data model are checked in"},{"line_number":200,"context_line":"``pre_execute`` and raise ``IllegalArgumentException``."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Instance flow"},{"line_number":203,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"299e0983_46925a94","line":200,"range":{"start_line":196,"start_character":1,"end_line":200,"end_character":55},"updated":"2026-10-29 20:54:33.000000000","message":"```\nInvalid parameter combinations will be rejected by schema validation with\nHTTP 400 Bad Request when creating an audit or defining an audit template\u0027s\n``default_parameters``. The decision engine will check runtime prerequisites\nin ``pre_execute``, including required Nova capabilities, extended-attribute\ncollection and values resolved through the cluster data model. If required\nextended information is not enabled on the deployment, the audit will fail\nwith a reason explaining that requirement.\n```","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":193,"context_line":"  ``compute_nodes``: without it nothing is migrating, the entry selects"},{"line_number":194,"context_line":"  nothing, and the audit is a silent no-op."},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"Everything expressible against the parameters alone is a schema error at"},{"line_number":197,"context_line":"audit creation. Keeping these rules in the schema is deliberate — it is the"},{"line_number":198,"context_line":"only layer that answers at ``POST /v1/audits`` rather than when the audit"},{"line_number":199,"context_line":"runs. The rules that need the cluster data model are checked in"},{"line_number":200,"context_line":"``pre_execute`` and raise ``IllegalArgumentException``."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Instance flow"},{"line_number":203,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"e3b58b25_d83d4296","line":200,"range":{"start_line":196,"start_character":1,"end_line":200,"end_character":55},"in_reply_to":"299e0983_46925a94","updated":"2026-11-03 13:27:47.000000000","message":"Done","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5059bc2d6b38eb34922c56f9966a907da8c5c238","unresolved":true,"context_lines":[{"line_number":199,"context_line":"runs. The rules that need the cluster data model are checked in"},{"line_number":200,"context_line":"``pre_execute`` and raise ``IllegalArgumentException``."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Instance flow"},{"line_number":203,"context_line":"-------------"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Destination resolution follows the kind of entry a source node came from. A"}],"source_content_type":"text/x-rst","patch_set":4,"id":"0aa1a3ac_439576de","line":202,"updated":"2026-10-29 20:54:33.000000000","message":"Title Case please :) \n\ni got as far as here today.\n\nsofare i think the desgin is sound.\n\nmost of my comment above are just wordign imporment and not matiral design changes\n\nill pick up form here tomorrow.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":true,"context_lines":[{"line_number":199,"context_line":"runs. The rules that need the cluster data model are checked in"},{"line_number":200,"context_line":"``pre_execute`` and raise ``IllegalArgumentException``."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Instance flow"},{"line_number":203,"context_line":"-------------"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Destination resolution follows the kind of entry a source node came from. A"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ecb97651_951cb4c2","line":202,"in_reply_to":"0aa1a3ac_439576de","updated":"2026-11-03 13:27:47.000000000","message":"TBH I think that both Instance Flow and Volume Flow are duplicating most of what was already said.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"9d3f900858f42f9587f158e72213f4039460e825","unresolved":false,"context_lines":[{"line_number":199,"context_line":"runs. The rules that need the cluster data model are checked in"},{"line_number":200,"context_line":"``pre_execute`` and raise ``IllegalArgumentException``."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Instance flow"},{"line_number":203,"context_line":"-------------"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Destination resolution follows the kind of entry a source node came from. A"}],"source_content_type":"text/x-rst","patch_set":4,"id":"09e198a7_4aefc6a3","line":202,"in_reply_to":"ecb97651_951cb4c2","updated":"2026-11-09 18:45:12.000000000","message":"Done","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"6058b51da35bcd803c0b27251146b14f6123de9c","unresolved":true,"context_lines":[{"line_number":347,"context_line":"  An instance whose ``pinned_availability_zone`` conflicts with"},{"line_number":348,"context_line":"  where the entry would send it is left out of the action plan and logged."},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"Clearing and restoring a pin belongs ``inside`` the ``Migrate`` action rather"},{"line_number":351,"context_line":"than in actions of its own. The three steps are one operation: unpin, move,"},{"line_number":352,"context_line":"pin. An action that owns all three keeps them together whatever the planner"},{"line_number":353,"context_line":"does with the rest of the plan, and keeps the unpin from being applied to an"},{"line_number":354,"context_line":"instance whose migration never runs or that was eventually skipped."},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"The action is not atomic, but the unpin is partially rolled back on failure."},{"line_number":357,"context_line":"If the migration fails after the pin has been cleared, the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5244ac37_a0271cfd","line":354,"range":{"start_line":350,"start_character":0,"end_line":354,"end_character":67},"updated":"2026-10-29 16:26:39.000000000","message":"In PTG it was mentioned that nova may still decide to do the unpin-migrate-pin part of the migration api call when setting an AZ as destination. Is that already decided or just taking the worst case here?","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":false,"context_lines":[{"line_number":347,"context_line":"  An instance whose ``pinned_availability_zone`` conflicts with"},{"line_number":348,"context_line":"  where the entry would send it is left out of the action plan and logged."},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"Clearing and restoring a pin belongs ``inside`` the ``Migrate`` action rather"},{"line_number":351,"context_line":"than in actions of its own. The three steps are one operation: unpin, move,"},{"line_number":352,"context_line":"pin. An action that owns all three keeps them together whatever the planner"},{"line_number":353,"context_line":"does with the rest of the plan, and keeps the unpin from being applied to an"},{"line_number":354,"context_line":"instance whose migration never runs or that was eventually skipped."},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"The action is not atomic, but the unpin is partially rolled back on failure."},{"line_number":357,"context_line":"If the migration fails after the pin has been cleared, the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"a1dd99b3_c50bd3b0","line":354,"range":{"start_line":350,"start_character":0,"end_line":354,"end_character":67},"in_reply_to":"5244ac37_a0271cfd","updated":"2026-11-03 13:27:47.000000000","message":"Spec isn\u0027t merged, but IIUC this is a part that they agree that Nova shouldn\u0027t handle. So it will be up to Watcher.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"41ccf6dbf3032d74737d9fb032c5a7dca4848302","unresolved":false,"context_lines":[{"line_number":347,"context_line":"  An instance whose ``pinned_availability_zone`` conflicts with"},{"line_number":348,"context_line":"  where the entry would send it is left out of the action plan and logged."},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"Clearing and restoring a pin belongs ``inside`` the ``Migrate`` action rather"},{"line_number":351,"context_line":"than in actions of its own. The three steps are one operation: unpin, move,"},{"line_number":352,"context_line":"pin. An action that owns all three keeps them together whatever the planner"},{"line_number":353,"context_line":"does with the rest of the plan, and keeps the unpin from being applied to an"},{"line_number":354,"context_line":"instance whose migration never runs or that was eventually skipped."},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"The action is not atomic, but the unpin is partially rolled back on failure."},{"line_number":357,"context_line":"If the migration fails after the pin has been cleared, the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"646517dd_23fc761e","line":354,"range":{"start_line":350,"start_character":0,"end_line":354,"end_character":67},"in_reply_to":"a1dd99b3_c50bd3b0","updated":"2026-11-05 09:41:22.000000000","message":"ack, good","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"6058b51da35bcd803c0b27251146b14f6123de9c","unresolved":true,"context_lines":[{"line_number":369,"context_line":"from an unpinned one, so the default would emit ``migrate`` actions without"},{"line_number":370,"context_line":"``repin_availability_zone`` and the drain would plan migrations Nova rejects"},{"line_number":371,"context_line":"at execution time."},{"line_number":372,"context_line":"This spec therefore flips ``[compute_model] enable_extended_attributes`` to"},{"line_number":373,"context_line":"default ``True``."},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"Extending zone_migration: parallelism counters"},{"line_number":376,"context_line":"----------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"f527af4e_73784bae","line":373,"range":{"start_line":372,"start_character":0,"end_line":373,"end_character":16},"updated":"2026-10-29 16:26:39.000000000","message":"+1","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"9d3f900858f42f9587f158e72213f4039460e825","unresolved":false,"context_lines":[{"line_number":369,"context_line":"from an unpinned one, so the default would emit ``migrate`` actions without"},{"line_number":370,"context_line":"``repin_availability_zone`` and the drain would plan migrations Nova rejects"},{"line_number":371,"context_line":"at execution time."},{"line_number":372,"context_line":"This spec therefore flips ``[compute_model] enable_extended_attributes`` to"},{"line_number":373,"context_line":"default ``True``."},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"Extending zone_migration: parallelism counters"},{"line_number":376,"context_line":"----------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"439412da_9c083b7a","line":373,"range":{"start_line":372,"start_character":0,"end_line":373,"end_character":16},"in_reply_to":"6813d0d1_e20a1963","updated":"2026-11-09 18:45:12.000000000","message":"Done","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":true,"context_lines":[{"line_number":369,"context_line":"from an unpinned one, so the default would emit ``migrate`` actions without"},{"line_number":370,"context_line":"``repin_availability_zone`` and the drain would plan migrations Nova rejects"},{"line_number":371,"context_line":"at execution time."},{"line_number":372,"context_line":"This spec therefore flips ``[compute_model] enable_extended_attributes`` to"},{"line_number":373,"context_line":"default ``True``."},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"Extending zone_migration: parallelism counters"},{"line_number":376,"context_line":"----------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"6813d0d1_e20a1963","line":373,"range":{"start_line":372,"start_character":0,"end_line":373,"end_character":16},"in_reply_to":"f527af4e_73784bae","updated":"2026-11-03 13:27:47.000000000","message":"Yeah, but at this moment I am conflicted that we really needed this. The pinned_az attributes is not something tha we can rely anymore, since Nova supports now pin and unpin without a notification of this change.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"6058b51da35bcd803c0b27251146b14f6123de9c","unresolved":true,"context_lines":[{"line_number":406,"context_line":"release once documentation and tooling give operators a clear path to"},{"line_number":407,"context_line":"explicit values."},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"``Disable actions count toward parallel_total and parallel_per_node``."},{"line_number":410,"context_line":"When an entry sets ``disable_source_nodes``, each emitted"},{"line_number":411,"context_line":"``change_nova_service_state`` action is included in both the"},{"line_number":412,"context_line":"``parallel_total`` budget and the per-node budget for its source node,"},{"line_number":413,"context_line":"alongside instance and volume actions. A disable action is operationally"},{"line_number":414,"context_line":"concurrent with migrations; counting it in both dimensions prevents either"},{"line_number":415,"context_line":"counter from under-representing the plan size when set to a finite value."},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"A dedicated section in the ``zone_migration`` strategy documentation will"},{"line_number":418,"context_line":"explain counter semantics, the interaction between the three limits, and"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5e6f3380_2131f5e2","line":415,"range":{"start_line":409,"start_character":0,"end_line":415,"end_character":72},"updated":"2026-10-29 16:26:39.000000000","message":"Although it\u0027s technically correct that a node disable is an Action in watcher, I have doubts about this. I understand the `parallel_*` counters were created because migration and volume_migration are long-asynchronous tasks that may end up in huge actionplans and it provides a way to limit that. Disable actions, are short actions, not affecting the running workloads and affecting to nodes, not volumes or instances, so the number of actions is much smaller. I think we may not cover the node disabling by any of the counter, tbh, or provide a parallel_disabled which -1 by default from the beginning that was not included in parallel_total. Said that, your proposal would also work as soon as it\u0027s documented properly.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"41ccf6dbf3032d74737d9fb032c5a7dca4848302","unresolved":true,"context_lines":[{"line_number":406,"context_line":"release once documentation and tooling give operators a clear path to"},{"line_number":407,"context_line":"explicit values."},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"``Disable actions count toward parallel_total and parallel_per_node``."},{"line_number":410,"context_line":"When an entry sets ``disable_source_nodes``, each emitted"},{"line_number":411,"context_line":"``change_nova_service_state`` action is included in both the"},{"line_number":412,"context_line":"``parallel_total`` budget and the per-node budget for its source node,"},{"line_number":413,"context_line":"alongside instance and volume actions. A disable action is operationally"},{"line_number":414,"context_line":"concurrent with migrations; counting it in both dimensions prevents either"},{"line_number":415,"context_line":"counter from under-representing the plan size when set to a finite value."},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"A dedicated section in the ``zone_migration`` strategy documentation will"},{"line_number":418,"context_line":"explain counter semantics, the interaction between the three limits, and"}],"source_content_type":"text/x-rst","patch_set":4,"id":"d9fb2390_9daf4b96","line":415,"range":{"start_line":409,"start_character":0,"end_line":415,"end_character":72},"in_reply_to":"16b3f9b6_e00b2208","updated":"2026-11-05 09:41:22.000000000","message":"ok, given that the current docs mentions conters of *actions* it\u0027s probably more correct to count them.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":true,"context_lines":[{"line_number":406,"context_line":"release once documentation and tooling give operators a clear path to"},{"line_number":407,"context_line":"explicit values."},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"``Disable actions count toward parallel_total and parallel_per_node``."},{"line_number":410,"context_line":"When an entry sets ``disable_source_nodes``, each emitted"},{"line_number":411,"context_line":"``change_nova_service_state`` action is included in both the"},{"line_number":412,"context_line":"``parallel_total`` budget and the per-node budget for its source node,"},{"line_number":413,"context_line":"alongside instance and volume actions. A disable action is operationally"},{"line_number":414,"context_line":"concurrent with migrations; counting it in both dimensions prevents either"},{"line_number":415,"context_line":"counter from under-representing the plan size when set to a finite value."},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"A dedicated section in the ``zone_migration`` strategy documentation will"},{"line_number":418,"context_line":"explain counter semantics, the interaction between the three limits, and"}],"source_content_type":"text/x-rst","patch_set":4,"id":"16b3f9b6_e00b2208","line":415,"range":{"start_line":409,"start_character":0,"end_line":415,"end_character":72},"in_reply_to":"5e6f3380_2131f5e2","updated":"2026-11-03 13:27:47.000000000","message":"I don\u0027t think that is useful in the end too. I propose this because it seems more aligned with current counter\u0027s naming. But not counting it, we would also need to properly document it. It would look weird too that parallel_total\u003d\u003d6 will end up with a AP with 6+ actions. In the end, setting the default to -1 and deprecating this option would be the best for this strategy. But I am also ok with any.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"d896c05efd089ec81f51885bdc402eb66c10f16b","unresolved":false,"context_lines":[{"line_number":406,"context_line":"release once documentation and tooling give operators a clear path to"},{"line_number":407,"context_line":"explicit values."},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"``Disable actions count toward parallel_total and parallel_per_node``."},{"line_number":410,"context_line":"When an entry sets ``disable_source_nodes``, each emitted"},{"line_number":411,"context_line":"``change_nova_service_state`` action is included in both the"},{"line_number":412,"context_line":"``parallel_total`` budget and the per-node budget for its source node,"},{"line_number":413,"context_line":"alongside instance and volume actions. A disable action is operationally"},{"line_number":414,"context_line":"concurrent with migrations; counting it in both dimensions prevents either"},{"line_number":415,"context_line":"counter from under-representing the plan size when set to a finite value."},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"A dedicated section in the ``zone_migration`` strategy documentation will"},{"line_number":418,"context_line":"explain counter semantics, the interaction between the three limits, and"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3abeff43_de3267a8","line":415,"range":{"start_line":409,"start_character":0,"end_line":415,"end_character":72},"in_reply_to":"d9fb2390_9daf4b96","updated":"2026-11-06 12:17:09.000000000","message":"Done","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"6058b51da35bcd803c0b27251146b14f6123de9c","unresolved":true,"context_lines":[{"line_number":628,"context_line":"Dependencies"},{"line_number":629,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"* ``Nova support for an availability zone as a migration destination``. A"},{"line_number":632,"context_line":"  hard dependency of the ``compute_nodes`` zone pair. Without it the strategy"},{"line_number":633,"context_line":"  fails the audit rather than degrading."},{"line_number":634,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"92ae486c_98dd9f08","line":631,"range":{"start_line":631,"start_character":4,"end_line":631,"end_character":68},"updated":"2026-10-29 16:26:39.000000000","message":"I\u0027d be explicit to mention that support for both *live and cold migrations* is required.","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"41ccf6dbf3032d74737d9fb032c5a7dca4848302","unresolved":false,"context_lines":[{"line_number":628,"context_line":"Dependencies"},{"line_number":629,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"* ``Nova support for an availability zone as a migration destination``. A"},{"line_number":632,"context_line":"  hard dependency of the ``compute_nodes`` zone pair. Without it the strategy"},{"line_number":633,"context_line":"  fails the audit rather than degrading."},{"line_number":634,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"155208d7_9b862719","line":631,"range":{"start_line":631,"start_character":4,"end_line":631,"end_character":68},"in_reply_to":"3959af59_1251d70d","updated":"2026-11-05 09:41:22.000000000","message":"Done","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"18ab4273eda0cb899a79b6b14df49df7bd6c4228","unresolved":true,"context_lines":[{"line_number":628,"context_line":"Dependencies"},{"line_number":629,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"* ``Nova support for an availability zone as a migration destination``. A"},{"line_number":632,"context_line":"  hard dependency of the ``compute_nodes`` zone pair. Without it the strategy"},{"line_number":633,"context_line":"  fails the audit rather than degrading."},{"line_number":634,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3959af59_1251d70d","line":631,"range":{"start_line":631,"start_character":4,"end_line":631,"end_character":68},"in_reply_to":"92ae486c_98dd9f08","updated":"2026-11-03 13:27:47.000000000","message":"Ack, wil add in the next PS, tahnks","commit_id":"eb4dde188c0819a7b2adca04a3567d0e39b25dd6"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"41ccf6dbf3032d74737d9fb032c5a7dca4848302","unresolved":true,"context_lines":[{"line_number":16,"context_line":"operator-named compute nodes and storage pools, but it has no concept of a"},{"line_number":17,"context_line":"Nova availability zone: the operator must enumerate every source host by"},{"line_number":18,"context_line":"hand, and nothing keeps the instances inside the intended destination zone."},{"line_number":19,"context_line":"This spec extends ``zone_migration`` to drain instances from one compute"},{"line_number":20,"context_line":"availability zone into another. Storage destinations remain specified"},{"line_number":21,"context_line":"separately through pool and volume type mappings."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":5,"id":"c00cb02c_adfa357b","line":20,"range":{"start_line":19,"start_character":9,"end_line":20,"end_character":31},"updated":"2026-11-05 09:41:22.000000000","message":"+1 to extend existing strategy.","commit_id":"3fd0f7ad46f55a87045a9cab93086b38765f8cdb"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"9d3f900858f42f9587f158e72213f4039460e825","unresolved":false,"context_lines":[{"line_number":16,"context_line":"operator-named compute nodes and storage pools, but it has no concept of a"},{"line_number":17,"context_line":"Nova availability zone: the operator must enumerate every source host by"},{"line_number":18,"context_line":"hand, and nothing keeps the instances inside the intended destination zone."},{"line_number":19,"context_line":"This spec extends ``zone_migration`` to drain instances from one compute"},{"line_number":20,"context_line":"availability zone into another. Storage destinations remain specified"},{"line_number":21,"context_line":"separately through pool and volume type mappings."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":5,"id":"b64de059_79ef824c","line":20,"range":{"start_line":19,"start_character":9,"end_line":20,"end_character":31},"in_reply_to":"c00cb02c_adfa357b","updated":"2026-11-09 18:45:12.000000000","message":"Done","commit_id":"3fd0f7ad46f55a87045a9cab93086b38765f8cdb"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"b3f3612990fa7701992ad7330fa48d0f08096fc8","unresolved":false,"context_lines":[{"line_number":108,"context_line":"Watcher selects source hosts in ``src_az`` and requests migrations to"},{"line_number":109,"context_line":"``dst_az``, leaving Nova to choose destination hosts within that zone."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Compute entries also gain two optional booleans."},{"line_number":112,"context_line":"``repin_az_pinned_instances`` controls whether instances whose pins conflict"},{"line_number":113,"context_line":"with the requested destination should be repinned or skipped."},{"line_number":114,"context_line":"``disable_source_nodes`` controls whether to disable the selected source"}],"source_content_type":"text/x-rst","patch_set":5,"id":"f1d3083d_4b8d4509","line":111,"updated":"2026-11-03 13:45:27.000000000","message":"The flag is introduced for \u0027Compute entries\u0027 generally - both the node-pair ({src_node, dst_node}) and zone-pair ({src_az, dst_az}) entry kinds - and work item 5 propagates it \u0027onto every ``migrate`` it produces\u0027. But all pin semantics are defined only against destination_az: the Migrate action\u0027s repin_availability_zone pins the instance to \u0027destination_az\u0027 after the move, and the pre_condition decision table tests a pin \u0027conflicting with ``destination_az``\u0027. For a node-pair entry the emitted migrate carries destination_node (or no destination at all), so neither what a conflicting pin means nor which pin the instance ends up with is defined - despite node pairs being able to cross AZ boundaries via dst_node, and dst_node-less entries letting Nova place anywhere.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: A supported input combination (node pair plus repin_az_pinned_instances, not rejected by the described schema) has no defined outcome. Implementers must invent behavior, and operators cannot predict whether a pinned instance on a node-pair drain is skipped, migrated, or left for Nova to reject at apply time - the exact failure mode the flag exists to prevent.\n\n**Suggestion**:\nState the scope explicitly: either restrict repin_az_pinned_instances to zone pairs (documenting it as rejected or a no-op on node pairs), or define pin handling for destination_node migrations, including which AZ the action repins to and how a conflict is detected when no destination_az is present.","commit_id":"3fd0f7ad46f55a87045a9cab93086b38765f8cdb"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"9d3f900858f42f9587f158e72213f4039460e825","unresolved":false,"context_lines":[{"line_number":108,"context_line":"Watcher selects source hosts in ``src_az`` and requests migrations to"},{"line_number":109,"context_line":"``dst_az``, leaving Nova to choose destination hosts within that zone."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Compute entries also gain two optional booleans."},{"line_number":112,"context_line":"``repin_az_pinned_instances`` controls whether instances whose pins conflict"},{"line_number":113,"context_line":"with the requested destination should be repinned or skipped."},{"line_number":114,"context_line":"``disable_source_nodes`` controls whether to disable the selected source"}],"source_content_type":"text/x-rst","patch_set":5,"id":"c1135b74_b66dcba9","line":111,"in_reply_to":"ed4dc628_95f5abae","updated":"2026-11-09 18:45:12.000000000","message":"Done, let me knwo if I missed some detail, thanks","commit_id":"3fd0f7ad46f55a87045a9cab93086b38765f8cdb"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"ff9bb0ef84c2441c1a1baf1e3f3ccf3b6bd8a2ce","unresolved":true,"context_lines":[{"line_number":108,"context_line":"Watcher selects source hosts in ``src_az`` and requests migrations to"},{"line_number":109,"context_line":"``dst_az``, leaving Nova to choose destination hosts within that zone."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Compute entries also gain two optional booleans."},{"line_number":112,"context_line":"``repin_az_pinned_instances`` controls whether instances whose pins conflict"},{"line_number":113,"context_line":"with the requested destination should be repinned or skipped."},{"line_number":114,"context_line":"``disable_source_nodes`` controls whether to disable the selected source"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ed4dc628_95f5abae","line":111,"in_reply_to":"f1d3083d_4b8d4509","updated":"2026-11-06 16:38:45.000000000","message":"This raises a valid point: are the new booleans applicable only to audits using the new `src_az` parameter? There are clear use cases for `disable_sources_nodes` to be used with `src_node` imo, the case for `repin_az_pinned_instances` is not as clear, but it could be useful as well. Regardless, I think we should call out explicitly whether they will be applicable to both AZ and nodes audits or only AZ ones.","commit_id":"3fd0f7ad46f55a87045a9cab93086b38765f8cdb"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"41ccf6dbf3032d74737d9fb032c5a7dca4848302","unresolved":true,"context_lines":[{"line_number":381,"context_line":"Whether to update a pin is the operator\u0027s call, taken per entry via"},{"line_number":382,"context_line":"``repin_az_pinned_instances``:"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"``repin_az_pinned_instances: false``"},{"line_number":385,"context_line":"  The default. All instances are included in the action plan regardless of"},{"line_number":386,"context_line":"  their pin, and no ``migrate`` carries ``repin_availability_zone``. An"},{"line_number":387,"context_line":"  instance found at execution time with a ``pinned_availability_zone`` that"},{"line_number":388,"context_line":"  conflicts with the destination AZ is ``skipped``, because a normal"},{"line_number":389,"context_line":"  ``migrate`` without special pin handling would be rejected by Nova."},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"``repin_az_pinned_instances: true``"},{"line_number":392,"context_line":"  Every ``migrate`` the entry produces carries"}],"source_content_type":"text/x-rst","patch_set":5,"id":"76b75735_d94946fb","line":389,"range":{"start_line":384,"start_character":0,"end_line":389,"end_character":69},"updated":"2026-11-05 09:41:22.000000000","message":"I understand this is in the action instead of the strategy because we lack notifications in nova pin/unpin. As written in another comment:\n\n\nI think doing the skip in the migrate action when i.e. the instance it\u0027s not in the expected source_az is fine to manage any conflicting cases right before execution (i.e. a vm has been moved between the time when the AP was created and it is executed) but I don\u0027t like defer all that to the action execution. I think that also the strategy should manage the cases according to the last information in the model. We still have the periodic nova collection and we could also request nova to send a notification that we may process to update the model?","commit_id":"3fd0f7ad46f55a87045a9cab93086b38765f8cdb"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"d896c05efd089ec81f51885bdc402eb66c10f16b","unresolved":false,"context_lines":[{"line_number":381,"context_line":"Whether to update a pin is the operator\u0027s call, taken per entry via"},{"line_number":382,"context_line":"``repin_az_pinned_instances``:"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"``repin_az_pinned_instances: false``"},{"line_number":385,"context_line":"  The default. All instances are included in the action plan regardless of"},{"line_number":386,"context_line":"  their pin, and no ``migrate`` carries ``repin_availability_zone``. An"},{"line_number":387,"context_line":"  instance found at execution time with a ``pinned_availability_zone`` that"},{"line_number":388,"context_line":"  conflicts with the destination AZ is ``skipped``, because a normal"},{"line_number":389,"context_line":"  ``migrate`` without special pin handling would be rejected by Nova."},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"``repin_az_pinned_instances: true``"},{"line_number":392,"context_line":"  Every ``migrate`` the entry produces carries"}],"source_content_type":"text/x-rst","patch_set":5,"id":"e87fcf04_746a727b","line":389,"range":{"start_line":384,"start_character":0,"end_line":389,"end_character":69},"in_reply_to":"76b75735_d94946fb","updated":"2026-11-06 12:17:09.000000000","message":"Ack, lets keep the discussion in the other thread.","commit_id":"3fd0f7ad46f55a87045a9cab93086b38765f8cdb"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"41ccf6dbf3032d74737d9fb032c5a7dca4848302","unresolved":true,"context_lines":[{"line_number":413,"context_line":"``destination_az`` after a completed migration."},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"Watcher captures ``pinned_availability_zone`` in the cluster data model at"},{"line_number":416,"context_line":"collection time, but Nova does not emit a notification when a pin changes."},{"line_number":417,"context_line":"An operator can update an instance\u0027s pin directly through Nova without"},{"line_number":418,"context_line":"Watcher being notified; the CDM value is refreshed only on the next periodic"},{"line_number":419,"context_line":"collector run and may be stale by the time an audit executes. Using a stale"}],"source_content_type":"text/x-rst","patch_set":5,"id":"2b28bd31_b24c39e0","line":416,"range":{"start_line":416,"start_character":22,"end_line":416,"end_character":74},"updated":"2026-11-05 09:41:22.000000000","message":"May we ask Nova to send a notification when updating the pinned_az?","commit_id":"3fd0f7ad46f55a87045a9cab93086b38765f8cdb"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"d896c05efd089ec81f51885bdc402eb66c10f16b","unresolved":true,"context_lines":[{"line_number":413,"context_line":"``destination_az`` after a completed migration."},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"Watcher captures ``pinned_availability_zone`` in the cluster data model at"},{"line_number":416,"context_line":"collection time, but Nova does not emit a notification when a pin changes."},{"line_number":417,"context_line":"An operator can update an instance\u0027s pin directly through Nova without"},{"line_number":418,"context_line":"Watcher being notified; the CDM value is refreshed only on the next periodic"},{"line_number":419,"context_line":"collector run and may be stale by the time an audit executes. Using a stale"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a44144f_3984a31f","line":416,"range":{"start_line":416,"start_character":22,"end_line":416,"end_character":74},"in_reply_to":"2b28bd31_b24c39e0","updated":"2026-11-06 12:17:09.000000000","message":"This info is part of the Request Spec object, and when updating it doesn\u0027t generate any notification. Req Spec notifications are sent only by the scheduler when selecting a destination. Since there is no \u0027instance\u0027 change/update, there is no intance.update notification sent, so we can rely only on the periodic collector (which can take an hour to run).","commit_id":"3fd0f7ad46f55a87045a9cab93086b38765f8cdb"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"9d3f900858f42f9587f158e72213f4039460e825","unresolved":false,"context_lines":[{"line_number":413,"context_line":"``destination_az`` after a completed migration."},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"Watcher captures ``pinned_availability_zone`` in the cluster data model at"},{"line_number":416,"context_line":"collection time, but Nova does not emit a notification when a pin changes."},{"line_number":417,"context_line":"An operator can update an instance\u0027s pin directly through Nova without"},{"line_number":418,"context_line":"Watcher being notified; the CDM value is refreshed only on the next periodic"},{"line_number":419,"context_line":"collector run and may be stale by the time an audit executes. Using a stale"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9256a052_b022cb37","line":416,"range":{"start_line":416,"start_character":22,"end_line":416,"end_character":74},"in_reply_to":"9a44144f_3984a31f","updated":"2026-11-09 18:45:12.000000000","message":"Done","commit_id":"3fd0f7ad46f55a87045a9cab93086b38765f8cdb"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"b3f3612990fa7701992ad7330fa48d0f08096fc8","unresolved":false,"context_lines":[{"line_number":527,"context_line":"   migrate to ``pool-b``. ``v3`` is in a different pool, which no entry"},{"line_number":528,"context_line":"   selects, so it is untouched. Had the entry set ``attached_only``, ``v2``"},{"line_number":529,"context_line":"   would have been left out and only ``v1`` migrated."},{"line_number":530,"context_line":"#. ``Instances``, in the order the existing priority filters impose and"},{"line_number":531,"context_line":"   subject to the existing ``parallel_*`` caps. Each gets a ``migrate``"},{"line_number":532,"context_line":"   with ``destination_az: az-b``: ``i1`` and ``i2`` from ``compute-a1``,"},{"line_number":533,"context_line":"   ``i3`` from ``compute-a2``. The entry sets"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9613fe91_924e355b","line":530,"updated":"2026-11-03 13:45:27.000000000","message":"The Parallelism Counters section sets all three counters\u0027 defaults to -1 (unlimited) so that \u0027an audit that does not mention them drains fully\u0027, and deprecates the parameters. Yet step 6 of the Worked Example describes the instance migrations as \u0027subject to the existing ``parallel_*`` caps\u0027, even though the example audit sets none of the three parameters. Under the semantics this same spec proposes, that example plan has no caps at all; describing it as capped contradicts the proposed behavior the walkthrough is meant to illustrate.\n\n**Severity**: WARNING | **Confidence**: 0.85\n\n**Impact**: Reviewers and implementers reading the end-to-end walkthrough may conclude plans are still truncated by default, implement or test cap behavior the spec actually removes, or misjudge the AZ-drain sizing argument that motivated deprecating the counters in the first place.\n\n**Suggestion**:\nReword step 6 to match the proposed semantics, e.g. \u0027in the order the existing priority filters impose; with the new unlimited defaults the plan contains every instance, and only an explicitly set positive cap would truncate it\u0027.","commit_id":"3fd0f7ad46f55a87045a9cab93086b38765f8cdb"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"ff9bb0ef84c2441c1a1baf1e3f3ccf3b6bd8a2ce","unresolved":true,"context_lines":[{"line_number":648,"context_line":"soft-deletes and recreates the strategy during sync and cancels ongoing audits"},{"line_number":649,"context_line":"and action plans that reference it. Operators should let in-flight"},{"line_number":650,"context_line":"``zone_migration`` plans finish before upgrading. Existing audit templates"},{"line_number":651,"context_line":"using the original node-pair and pool-pair entry forms remain valid."},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"Implementation"},{"line_number":654,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"997fe2b8_f143ba6f","line":651,"updated":"2026-11-06 16:38:45.000000000","message":"We should mention the `parallel_*` parameter deprecation and change of defaults here as well, since the new defaults will result in significantly different action plans","commit_id":"3fd0f7ad46f55a87045a9cab93086b38765f8cdb"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"9d3f900858f42f9587f158e72213f4039460e825","unresolved":false,"context_lines":[{"line_number":648,"context_line":"soft-deletes and recreates the strategy during sync and cancels ongoing audits"},{"line_number":649,"context_line":"and action plans that reference it. Operators should let in-flight"},{"line_number":650,"context_line":"``zone_migration`` plans finish before upgrading. Existing audit templates"},{"line_number":651,"context_line":"using the original node-pair and pool-pair entry forms remain valid."},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"Implementation"},{"line_number":654,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"0235b830_22a026a8","line":651,"in_reply_to":"997fe2b8_f143ba6f","updated":"2026-11-09 18:45:12.000000000","message":"Ack, done, thanks!","commit_id":"3fd0f7ad46f55a87045a9cab93086b38765f8cdb"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a925a6dd345b32825aa3b16c3ed917307d566111","unresolved":true,"context_lines":[{"line_number":766,"context_line":"* `Nova availability zones`_"},{"line_number":767,"context_line":"* `Cinder volume retype`_"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":".. _Nova cross-cell live migration spec:"},{"line_number":770,"context_line":"   https://review.opendev.org/c/openstack/nova-specs/+/1008081"},{"line_number":771,"context_line":".. _Nova availability zones:"},{"line_number":772,"context_line":"   https://docs.openstack.org/nova/latest/admin/availability-zones.html"},{"line_number":773,"context_line":".. _Cinder volume retype:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"deb3b54f_0a0bb05d","line":770,"range":{"start_line":769,"start_character":0,"end_line":770,"end_character":62},"updated":"2026-11-03 14:42:07.000000000","message":"Update to: https://review.opendev.org/c/openstack/nova-specs/+/1013094 since it is was moved out from live migration one.","commit_id":"3fd0f7ad46f55a87045a9cab93086b38765f8cdb"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"9d3f900858f42f9587f158e72213f4039460e825","unresolved":false,"context_lines":[{"line_number":766,"context_line":"* `Nova availability zones`_"},{"line_number":767,"context_line":"* `Cinder volume retype`_"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":".. _Nova cross-cell live migration spec:"},{"line_number":770,"context_line":"   https://review.opendev.org/c/openstack/nova-specs/+/1008081"},{"line_number":771,"context_line":".. _Nova availability zones:"},{"line_number":772,"context_line":"   https://docs.openstack.org/nova/latest/admin/availability-zones.html"},{"line_number":773,"context_line":".. _Cinder volume retype:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"e875874a_f16e853b","line":770,"range":{"start_line":769,"start_character":0,"end_line":770,"end_character":62},"in_reply_to":"deb3b54f_0a0bb05d","updated":"2026-11-09 18:45:12.000000000","message":"Done","commit_id":"3fd0f7ad46f55a87045a9cab93086b38765f8cdb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":253,"context_line":"to place."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"A zone pair expands to every node in the compute model whose"},{"line_number":256,"context_line":"``availability_zone`` equals ``src_az`` and whose state is online, with status"},{"line_number":257,"context_line":"either enabled or disabled. A ``src_az`` matching no node fails the audit,"},{"line_number":258,"context_line":"and so does a ``dst_az`` matching no node. Both read the scoped compute"},{"line_number":259,"context_line":"model, so an audit scope that excludes every node of the destination zone"}],"source_content_type":"text/x-rst","patch_set":6,"id":"d4db354a_66fb05bf","line":256,"range":{"start_line":256,"start_character":59,"end_line":256,"end_character":65},"updated":"2026-11-10 19:54:37.000000000","message":"you mena comptue node that are up or enabled?","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":253,"context_line":"to place."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"A zone pair expands to every node in the compute model whose"},{"line_number":256,"context_line":"``availability_zone`` equals ``src_az`` and whose state is online, with status"},{"line_number":257,"context_line":"either enabled or disabled. A ``src_az`` matching no node fails the audit,"},{"line_number":258,"context_line":"and so does a ``dst_az`` matching no node. Both read the scoped compute"},{"line_number":259,"context_line":"model, so an audit scope that excludes every node of the destination zone"}],"source_content_type":"text/x-rst","patch_set":6,"id":"e85f8376_97071e2e","line":256,"range":{"start_line":256,"start_character":59,"end_line":256,"end_character":65},"in_reply_to":"d4db354a_66fb05bf","updated":"2026-11-11 22:10:40.000000000","message":"yeah, the correct is \u0027up\u0027. Fixed other \u0027online\u0027 below too (L528)","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":259,"context_line":"model, so an audit scope that excludes every node of the destination zone"},{"line_number":260,"context_line":"fails the audit rather than draining into it."},{"line_number":261,"context_line":"Every instance found on those nodes gets a ``migrate`` carrying"},{"line_number":262,"context_line":"``destination_az`` set to that entry\u0027s ``dst_az``."},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"Expanding a zone to its nodes says nothing about whether those nodes can"},{"line_number":265,"context_line":"actually move an instance. Ironic is the clear case: one ``nova-compute``"}],"source_content_type":"text/x-rst","patch_set":6,"id":"a9cfc29c_04ca08cc","line":262,"updated":"2026-11-10 19:54:37.000000000","message":"i think this was perhasp mentioned before but we proably shoudl allow scoping an audit by a list of AZs in this spec or a followup\n\ni would susggest this spec to avoid a sperate microverson but we could defer that ot limit the scope of work","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":true,"context_lines":[{"line_number":259,"context_line":"model, so an audit scope that excludes every node of the destination zone"},{"line_number":260,"context_line":"fails the audit rather than draining into it."},{"line_number":261,"context_line":"Every instance found on those nodes gets a ``migrate`` carrying"},{"line_number":262,"context_line":"``destination_az`` set to that entry\u0027s ``dst_az``."},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"Expanding a zone to its nodes says nothing about whether those nodes can"},{"line_number":265,"context_line":"actually move an instance. Ironic is the clear case: one ``nova-compute``"}],"source_content_type":"text/x-rst","patch_set":6,"id":"53e3d633_bb9db7ed","line":262,"in_reply_to":"a9cfc29c_04ca08cc","updated":"2026-11-11 22:10:40.000000000","message":"You mean somthing different from: https://github.com/openstack/watcher/blob/28e511b7f6a05ea6bfa66e3cc8e65c08b1a93fe0/watcher/decision_engine/model/collector/nova.py#L61-L68 ?","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":262,"context_line":"``destination_az`` set to that entry\u0027s ``dst_az``."},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"Expanding a zone to its nodes says nothing about whether those nodes can"},{"line_number":265,"context_line":"actually move an instance. Ironic is the clear case: one ``nova-compute``"},{"line_number":266,"context_line":"service fronts many compute nodes, and a bare metal instance cannot be live"},{"line_number":267,"context_line":"migrated at all. This spec targets the drivers ``zone_migration`` already"},{"line_number":268,"context_line":"works with and offers no per-driver behaviour, so bare metal nodes have to"}],"source_content_type":"text/x-rst","patch_set":6,"id":"e0fd5118_62ce8a69","line":265,"range":{"start_line":265,"start_character":9,"end_line":265,"end_character":13},"updated":"2026-11-10 19:54:37.000000000","message":"host or accpet\n\ncompute nodes dont take actuions like moving an instnace.\n\ncompute service may but a compute node is a hunk of metal in a rack","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":true,"context_lines":[{"line_number":262,"context_line":"``destination_az`` set to that entry\u0027s ``dst_az``."},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"Expanding a zone to its nodes says nothing about whether those nodes can"},{"line_number":265,"context_line":"actually move an instance. Ironic is the clear case: one ``nova-compute``"},{"line_number":266,"context_line":"service fronts many compute nodes, and a bare metal instance cannot be live"},{"line_number":267,"context_line":"migrated at all. This spec targets the drivers ``zone_migration`` already"},{"line_number":268,"context_line":"works with and offers no per-driver behaviour, so bare metal nodes have to"}],"source_content_type":"text/x-rst","patch_set":6,"id":"e9ca651d_117a0a98","line":265,"range":{"start_line":265,"start_character":9,"end_line":265,"end_character":13},"in_reply_to":"e0fd5118_62ce8a69","updated":"2026-11-11 22:10:40.000000000","message":"makes sense.\n\u0027s/those nodes/their hosts/\u0027\nworks?","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f2898912de2e3adfca1f5bda217ccd7e23c8affd","unresolved":false,"context_lines":[{"line_number":262,"context_line":"``destination_az`` set to that entry\u0027s ``dst_az``."},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"Expanding a zone to its nodes says nothing about whether those nodes can"},{"line_number":265,"context_line":"actually move an instance. Ironic is the clear case: one ``nova-compute``"},{"line_number":266,"context_line":"service fronts many compute nodes, and a bare metal instance cannot be live"},{"line_number":267,"context_line":"migrated at all. This spec targets the drivers ``zone_migration`` already"},{"line_number":268,"context_line":"works with and offers no per-driver behaviour, so bare metal nodes have to"}],"source_content_type":"text/x-rst","patch_set":6,"id":"a84e9f5b_ea8bc846","line":265,"range":{"start_line":265,"start_character":9,"end_line":265,"end_character":13},"in_reply_to":"e9ca651d_117a0a98","updated":"2026-11-17 15:29:48.000000000","message":"Done","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":false,"context_lines":[{"line_number":266,"context_line":"service fronts many compute nodes, and a bare metal instance cannot be live"},{"line_number":267,"context_line":"migrated at all. This spec targets the drivers ``zone_migration`` already"},{"line_number":268,"context_line":"works with and offers no per-driver behaviour, so bare metal nodes have to"},{"line_number":269,"context_line":"be excluded with the audit scope. Defining what an AZ drain should mean for"},{"line_number":270,"context_line":"Ironic is left to a follow-up, alongside future improvements to instance and"},{"line_number":271,"context_line":"destination filtering."},{"line_number":272,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"69905b82_e4000150","line":269,"updated":"2026-11-10 19:54:37.000000000","message":"ya this is existing echnial debth\n\nin the future once we have your seperate filtering spec i think we can remove the ironic special casing and make this more capablitiy based i.e. if a stragy what to migrate instnace they can ask for the set of instnace on host that supprot migratoin rather then having to explcitly exclude ironic or zvm virt driver by name\n\nwe currntly dont have checks for zvm but we can put this out of scop fo the spec for now","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":false,"context_lines":[{"line_number":268,"context_line":"works with and offers no per-driver behaviour, so bare metal nodes have to"},{"line_number":269,"context_line":"be excluded with the audit scope. Defining what an AZ drain should mean for"},{"line_number":270,"context_line":"Ironic is left to a follow-up, alongside future improvements to instance and"},{"line_number":271,"context_line":"destination filtering."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"When a zone pair is supplied and the configured Nova API microversion is"},{"line_number":274,"context_line":"below ``2.105``, the one that accepts an AZ destination, the strategy will"}],"source_content_type":"text/x-rst","patch_set":6,"id":"46469874_e751a9b1","line":271,"updated":"2026-11-10 19:54:37.000000000","message":"+1 we technially dont really supprot AZ/host aggrate with ironic in nova anyway\nso it makes sense to draw this support bonadary.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":271,"context_line":"destination filtering."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"When a zone pair is supplied and the configured Nova API microversion is"},{"line_number":274,"context_line":"below ``2.105``, the one that accepts an AZ destination, the strategy will"},{"line_number":275,"context_line":"raise ``StrategyError`` naming the required microversion. This gate is"},{"line_number":276,"context_line":"implemented via a new ``nova_helper.is_destination_az_available()`` helper"},{"line_number":277,"context_line":"that mirrors the existing ``is_pinned_az_available()``, comparing"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1192d28d_9286e00a","line":274,"range":{"start_line":274,"start_character":6,"end_line":274,"end_character":15},"updated":"2026-11-10 19:54:37.000000000","message":"this may change for what its worth.\n\nif it does we woudl have to update this spec. we could leave the speciifc number out of hte spec but im ok to assuem this will be 2.105\n\nwe currently have 2 spec that want to use that\nthe cross cell spec and the az move opertions spec\n\none will get 2.105 the other will get 2.106 depending on merge order.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":271,"context_line":"destination filtering."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"When a zone pair is supplied and the configured Nova API microversion is"},{"line_number":274,"context_line":"below ``2.105``, the one that accepts an AZ destination, the strategy will"},{"line_number":275,"context_line":"raise ``StrategyError`` naming the required microversion. This gate is"},{"line_number":276,"context_line":"implemented via a new ``nova_helper.is_destination_az_available()`` helper"},{"line_number":277,"context_line":"that mirrors the existing ``is_pinned_az_available()``, comparing"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ede2319b_fa6685e1","line":274,"range":{"start_line":274,"start_character":6,"end_line":274,"end_character":15},"in_reply_to":"1192d28d_9286e00a","updated":"2026-11-11 22:10:40.000000000","message":"Ack, i will change to be generic.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":276,"context_line":"implemented via a new ``nova_helper.is_destination_az_available()`` helper"},{"line_number":277,"context_line":"that mirrors the existing ``is_pinned_az_available()``, comparing"},{"line_number":278,"context_line":"``CONF.nova.api_version`` against the required version using"},{"line_number":279,"context_line":"``microversion_parse``."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"The ``Migrate`` action gains a ``destination_az`` input parameter, mutually"},{"line_number":282,"context_line":"exclusive with ``destination_node``. Its ``pre_condition`` already guards the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"de6881c8_f2fd3779","line":279,"updated":"2026-11-10 19:54:37.000000000","message":"will this be checked when definign an audit or in the decsion engine\n\ni feel like this shoudl reslut in a 409 conclict error and be checked in teh api when creating an auidt or audit pipeline not just in the descion engine\n\ni.e. if nova is too old then we shoudl reject it in the api\nif nova is new enough but the decsion engin or applier has its microversion pinned belowe the value we need then that can be reflected in a failed audit or action execution.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":276,"context_line":"implemented via a new ``nova_helper.is_destination_az_available()`` helper"},{"line_number":277,"context_line":"that mirrors the existing ``is_pinned_az_available()``, comparing"},{"line_number":278,"context_line":"``CONF.nova.api_version`` against the required version using"},{"line_number":279,"context_line":"``microversion_parse``."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"The ``Migrate`` action gains a ``destination_az`` input parameter, mutually"},{"line_number":282,"context_line":"exclusive with ``destination_node``. Its ``pre_condition`` already guards the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"771f111c_2dd7bf5b","line":279,"in_reply_to":"de6881c8_f2fd3779","updated":"2026-11-11 22:10:40.000000000","message":"I guess that is valid to check in API, we would need to check it anyway, so returning 409 early is better yes.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":false,"context_lines":[{"line_number":278,"context_line":"``CONF.nova.api_version`` against the required version using"},{"line_number":279,"context_line":"``microversion_parse``."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"The ``Migrate`` action gains a ``destination_az`` input parameter, mutually"},{"line_number":282,"context_line":"exclusive with ``destination_node``. Its ``pre_condition`` already guards the"},{"line_number":283,"context_line":"destination-node existence and enabled checks behind ``if"},{"line_number":284,"context_line":"self.destination_node:``, and gains a parallel zone existence check for"},{"line_number":285,"context_line":"``destination_az``. A skip condition in ``pre_condition`` validates that the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1cb34342_188f1c59","line":282,"range":{"start_line":281,"start_character":66,"end_line":282,"end_character":35},"updated":"2026-11-10 19:54:37.000000000","message":"i think this makes sense for us to enfoce internally\n\nits tbd if this will be also enforced in the nova rest api.\n\nstephen and i have expressed a mild prefence for a mutaly exclsive group\n\ndan has expressed a prefence for allowing both to be sepcfied adn havignnova check if the host is in teh expect az.\n\nthat complcates the code in nvoa which is why i prefer not to do that and i think we can make the simplify assumtion in watcher that we wil only ever send oen or the other even if nova technilly allows both at the saem time\n\nagain the core design tenatn of this proposal is that nova select the destination not watcher so i dont see a case wehere we will want to pass both a host and az for a single insntace.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":288,"context_line":"It gains a second parameter, ``repin_availability_zone``, a boolean defaulting"},{"line_number":289,"context_line":"to ``false``, which makes the action clear the instance\u0027s zone pin before the"},{"line_number":290,"context_line":"move and set it to the destination zone after: ``destination_az`` when given,"},{"line_number":291,"context_line":"otherwise the zone ``destination_node`` sits in. See `Pinned instances`_."},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"Volume Flow"},{"line_number":294,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"94acb173_72362417","line":291,"updated":"2026-11-10 19:54:37.000000000","message":"this im unsure about.\n\ni need to read the pinned instnace section but if this is false will this also cause us to skip the pinned isntnace when we are asked to move to a different az?\n\nthe other way to interpet `repin_availability_zone` would be to only contol the post live migration pinning\n\ni.e. we would alwasy unpin so we can move the instnace and `repin_availability_zone` would only contol if we pin the instance to its new az or not.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":288,"context_line":"It gains a second parameter, ``repin_availability_zone``, a boolean defaulting"},{"line_number":289,"context_line":"to ``false``, which makes the action clear the instance\u0027s zone pin before the"},{"line_number":290,"context_line":"move and set it to the destination zone after: ``destination_az`` when given,"},{"line_number":291,"context_line":"otherwise the zone ``destination_node`` sits in. See `Pinned instances`_."},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"Volume Flow"},{"line_number":294,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"576d7b0c_047bfd95","line":291,"in_reply_to":"94acb173_72362417","updated":"2026-11-11 22:10:40.000000000","message":"SO the repin_az is being replaced with the az_pin_policy...","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":299,"context_line":"and an entry naming ``dst_type`` emits ``migration_type: \"retype\"`` and"},{"line_number":300,"context_line":"lets Cinder move the volume if the new type cannot be satisfied in place."},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"A type-only entry makes selection type-driven and global: every volume whose"},{"line_number":303,"context_line":"``volume_type`` equals ``src_type`` is a target, in whichever pool it sits,"},{"line_number":304,"context_line":"and is retyped to ``dst_type``. Pool-anchored entries keep selecting within"},{"line_number":305,"context_line":"their named pool. A selected volume for which no entry yields a destination"},{"line_number":306,"context_line":"is logged and skipped rather than dropped silently."},{"line_number":307,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"18e1e783_e8a74e9e","line":304,"range":{"start_line":302,"start_character":0,"end_line":304,"end_character":29},"updated":"2026-11-10 19:54:37.000000000","message":"so this woudl likely need to be combiend with the audit scope parmater to limit the impact or with the attached_only parmater.\n\nthe same is true fo the pool based migratoin but to a lesser degree","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":299,"context_line":"and an entry naming ``dst_type`` emits ``migration_type: \"retype\"`` and"},{"line_number":300,"context_line":"lets Cinder move the volume if the new type cannot be satisfied in place."},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"A type-only entry makes selection type-driven and global: every volume whose"},{"line_number":303,"context_line":"``volume_type`` equals ``src_type`` is a target, in whichever pool it sits,"},{"line_number":304,"context_line":"and is retyped to ``dst_type``. Pool-anchored entries keep selecting within"},{"line_number":305,"context_line":"their named pool. A selected volume for which no entry yields a destination"},{"line_number":306,"context_line":"is logged and skipped rather than dropped silently."},{"line_number":307,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"948d5a71_f3dbf90a","line":304,"range":{"start_line":302,"start_character":0,"end_line":304,"end_character":29},"in_reply_to":"18e1e783_e8a74e9e","updated":"2026-11-11 22:10:40.000000000","message":"Added that too.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":308,"context_line":"No availability zone is passed to Cinder in either form, because Cinder has"},{"line_number":309,"context_line":"no \"move this volume to that zone\" operation to pass one to."},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"A ``dst_type`` carrying ``RESKEY:availability_zones`` is the operator\u0027s"},{"line_number":312,"context_line":"declaration of a destination storage zone, and a form in which Cinder"},{"line_number":313,"context_line":"validates it. This spec adds no Watcher-side check of either: the strategy"},{"line_number":314,"context_line":"emits the action the operator described."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1e21a839_6247cf2b","line":311,"range":{"start_line":311,"start_character":26,"end_line":311,"end_character":33},"updated":"2026-11-10 19:54:37.000000000","message":"is this the prefix that cinder uses?\n\ni genera expect lower case only namespace prefixes.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":true,"context_lines":[{"line_number":308,"context_line":"No availability zone is passed to Cinder in either form, because Cinder has"},{"line_number":309,"context_line":"no \"move this volume to that zone\" operation to pass one to."},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"A ``dst_type`` carrying ``RESKEY:availability_zones`` is the operator\u0027s"},{"line_number":312,"context_line":"declaration of a destination storage zone, and a form in which Cinder"},{"line_number":313,"context_line":"validates it. This spec adds no Watcher-side check of either: the strategy"},{"line_number":314,"context_line":"emits the action the operator described."}],"source_content_type":"text/x-rst","patch_set":6,"id":"3d3ae045_4f2cba59","line":311,"range":{"start_line":311,"start_character":26,"end_line":311,"end_character":33},"in_reply_to":"1e21a839_6247cf2b","updated":"2026-11-11 22:10:40.000000000","message":"it looks like yes: https://docs.openstack.org/cinder/latest/admin/availability-zone-type.html#how-to-config-availability-zone-types","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":348,"context_line":"already uses::"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    {\u0027state\u0027: \u0027disabled\u0027,"},{"line_number":351,"context_line":"     \u0027disabled_reason\u0027: \u0027watcher_maintaining\u0027,"},{"line_number":352,"context_line":"     \u0027resource_name\u0027: node.hostname}"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"Disabling first is the point: it stops the scheduler refilling a node"}],"source_content_type":"text/x-rst","patch_set":6,"id":"c30ebdbb_3625c459","line":351,"range":{"start_line":351,"start_character":25,"end_line":351,"end_character":44},"updated":"2026-11-10 19:54:37.000000000","message":"watcher maintenance\n\nwe should avoid `maintaining`\n\nthe disabled reason is ment to be primarly a human facing explanation so we should use spaces not underscores we coudl optional store the audit uuid that disabled it in the message.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":348,"context_line":"already uses::"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    {\u0027state\u0027: \u0027disabled\u0027,"},{"line_number":351,"context_line":"     \u0027disabled_reason\u0027: \u0027watcher_maintaining\u0027,"},{"line_number":352,"context_line":"     \u0027resource_name\u0027: node.hostname}"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"Disabling first is the point: it stops the scheduler refilling a node"}],"source_content_type":"text/x-rst","patch_set":6,"id":"41ef59ce_c0160a29","line":351,"range":{"start_line":351,"start_character":25,"end_line":351,"end_character":44},"in_reply_to":"c30ebdbb_3625c459","updated":"2026-11-11 22:10:40.000000000","message":"It is here because it the existing one in current version. But I am ok with renaming things to be grammatically correct. It should not affect anything in the API or across strategies.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":353,"context_line":""},{"line_number":354,"context_line":"Disabling first is the point: it stops the scheduler refilling a node"},{"line_number":355,"context_line":"mid-drain. Nodes already disabled are skipped. Re-enabling stays manual."},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"For a zone pair this means"},{"line_number":358,"context_line":"``every node of the scoped source zone, including nodes holding no instances``."},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"``disable_source_nodes`` applies to node pairs too, where it resolves to the"},{"line_number":361,"context_line":"single ``src_node``, and it carries no dependency on the Nova AZ-destination"},{"line_number":362,"context_line":"feature."},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"``REASON_FOR_MAINTAINING`` currently lives on ``HostMaintenanceBaseStrategy``"},{"line_number":365,"context_line":"and moves up to ``BaseStrategy`` so both strategies can share it."}],"source_content_type":"text/x-rst","patch_set":6,"id":"8ce42f4c_f15b00e9","line":362,"range":{"start_line":356,"start_character":0,"end_line":362,"end_character":8},"updated":"2026-11-10 19:54:37.000000000","message":"this is a bit  confusing\n\nfirst terminology wise you cannot disabel compute nodes only compute servics\nbut second im not sure if you are saying that all compute services in  the souce zone will be dieabeld, includign ones that did not have isntnaces\nor only the the ndoes list in disabel_source_nodes\n\ni.e its not clear if this is a boolean or a list of nodes to disable","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":true,"context_lines":[{"line_number":353,"context_line":""},{"line_number":354,"context_line":"Disabling first is the point: it stops the scheduler refilling a node"},{"line_number":355,"context_line":"mid-drain. Nodes already disabled are skipped. Re-enabling stays manual."},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"For a zone pair this means"},{"line_number":358,"context_line":"``every node of the scoped source zone, including nodes holding no instances``."},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"``disable_source_nodes`` applies to node pairs too, where it resolves to the"},{"line_number":361,"context_line":"single ``src_node``, and it carries no dependency on the Nova AZ-destination"},{"line_number":362,"context_line":"feature."},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"``REASON_FOR_MAINTAINING`` currently lives on ``HostMaintenanceBaseStrategy``"},{"line_number":365,"context_line":"and moves up to ``BaseStrategy`` so both strategies can share it."}],"source_content_type":"text/x-rst","patch_set":6,"id":"e86fdf82_a618cee8","line":362,"range":{"start_line":356,"start_character":0,"end_line":362,"end_character":8},"in_reply_to":"8ce42f4c_f15b00e9","updated":"2026-11-11 22:10:40.000000000","message":"It is a boolean, and it will disable all compute services from src_az. Users can still skip any that they would like to avoid. But yeah, I can rename the option to other than Node that is not correct and may confuse users.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":360,"context_line":"``disable_source_nodes`` applies to node pairs too, where it resolves to the"},{"line_number":361,"context_line":"single ``src_node``, and it carries no dependency on the Nova AZ-destination"},{"line_number":362,"context_line":"feature."},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"``REASON_FOR_MAINTAINING`` currently lives on ``HostMaintenanceBaseStrategy``"},{"line_number":365,"context_line":"and moves up to ``BaseStrategy`` so both strategies can share it."},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"Pinned Instances"},{"line_number":368,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5025fca6_9411911e","line":365,"range":{"start_line":363,"start_character":0,"end_line":365,"end_character":35},"updated":"2026-11-10 19:54:37.000000000","message":"again you should avoid using MAINTAINING\n\nthat is not correct grammatically \n\nit shoudl be `REASON_FOR_MAINTENANCE` or preferable `MAINTENANCE_REASON`.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":360,"context_line":"``disable_source_nodes`` applies to node pairs too, where it resolves to the"},{"line_number":361,"context_line":"single ``src_node``, and it carries no dependency on the Nova AZ-destination"},{"line_number":362,"context_line":"feature."},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"``REASON_FOR_MAINTAINING`` currently lives on ``HostMaintenanceBaseStrategy``"},{"line_number":365,"context_line":"and moves up to ``BaseStrategy`` so both strategies can share it."},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"Pinned Instances"},{"line_number":368,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"05717e47_c0560aa7","line":365,"range":{"start_line":363,"start_character":0,"end_line":365,"end_character":35},"in_reply_to":"5025fca6_9411911e","updated":"2026-11-11 22:10:40.000000000","message":"ACk, added that it will be renamed to. thanks","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":374,"context_line":"can move to ``az-b`` freely. A pinned one cannot: Nova rejects the migration,"},{"line_number":375,"context_line":"so reading the host\u0027s zone alone is not enough."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"Whether a pinned instance is worth moving at all is the operator\u0027s call,"},{"line_number":378,"context_line":"taken per entry via ``skip_az_pinned_instances``. The strategy compares"},{"line_number":379,"context_line":"each instance\u0027s ``Instance.pinned_az`` against the destination zone of the"},{"line_number":380,"context_line":"entry the instance came from: ``dst_az`` for a zone pair, and the zone"},{"line_number":381,"context_line":"``dst_node`` sits in for a node pair, read from the compute model."}],"source_content_type":"text/x-rst","patch_set":6,"id":"c9fa255e_13cf3676","line":378,"range":{"start_line":377,"start_character":0,"end_line":378,"end_character":50},"updated":"2026-11-10 19:54:37.000000000","message":"i would not phase it that way\n\nthe host a instnace is schduled too, unless resticted by custom policy is an api contract between the end user and nova.\n\nits a choice they get to express, and violating that requirement may result in penalties for the operator.\n\nin a public cloud environment it would generally not be acceptable for a admin to ever change the AZ of a workload. in a private cloud it may be.\n\nespcially when AZ are used for geofencing there may even be leagl liablity to movign a worklaod acorss contry bondaries so over riding a vm pinned az is not a step to be taken lightly.\n\n\n\n```suggestion\nThe ``skip_az_pinned_instances`` parameter allows operators to express a policy over the inclusion of instances pined to an AZ in the audit. As the AZ is and end-user facing API contract operator should not assume its is correct or safe to\nmove AZ pinned instance and should assess there regulatory and other legal obligation when choosing to include pinned vms.\n```","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":374,"context_line":"can move to ``az-b`` freely. A pinned one cannot: Nova rejects the migration,"},{"line_number":375,"context_line":"so reading the host\u0027s zone alone is not enough."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"Whether a pinned instance is worth moving at all is the operator\u0027s call,"},{"line_number":378,"context_line":"taken per entry via ``skip_az_pinned_instances``. The strategy compares"},{"line_number":379,"context_line":"each instance\u0027s ``Instance.pinned_az`` against the destination zone of the"},{"line_number":380,"context_line":"entry the instance came from: ``dst_az`` for a zone pair, and the zone"},{"line_number":381,"context_line":"``dst_node`` sits in for a node pair, read from the compute model."}],"source_content_type":"text/x-rst","patch_set":6,"id":"935dc519_64947c40","line":378,"range":{"start_line":377,"start_character":0,"end_line":378,"end_character":50},"in_reply_to":"c9fa255e_13cf3676","updated":"2026-11-11 22:10:40.000000000","message":"Ack, replaced with your version.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":375,"context_line":"so reading the host\u0027s zone alone is not enough."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"Whether a pinned instance is worth moving at all is the operator\u0027s call,"},{"line_number":378,"context_line":"taken per entry via ``skip_az_pinned_instances``. The strategy compares"},{"line_number":379,"context_line":"each instance\u0027s ``Instance.pinned_az`` against the destination zone of the"},{"line_number":380,"context_line":"entry the instance came from: ``dst_az`` for a zone pair, and the zone"},{"line_number":381,"context_line":"``dst_node`` sits in for a node pair, read from the compute model."},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"``skip_az_pinned_instances: false``"},{"line_number":384,"context_line":"  The default. An instance whose pin conflicts with the destination zone"},{"line_number":385,"context_line":"  stays a candidate, and its ``migrate`` carries"},{"line_number":386,"context_line":"  ``repin_availability_zone: true`` so that the move can succeed. The"},{"line_number":387,"context_line":"  ``Migrate`` applier action clears the pin before the move and sets it to"},{"line_number":388,"context_line":"  the destination zone after, leaving the instance pinned to where it now"},{"line_number":389,"context_line":"  lives."},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"``skip_az_pinned_instances: true``"},{"line_number":392,"context_line":"  An instance whose pin conflicts with the destination zone is excluded"},{"line_number":393,"context_line":"  from the action plan, and no action is emitted for it. The operator"},{"line_number":394,"context_line":"  resolves the pin, or leaves the instance where it is."},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"Either way, an instance with no pin, or one already pinned to the"},{"line_number":397,"context_line":"destination zone, is a candidate and its ``migrate`` carries no"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7b3f22a5_c7105c14","line":394,"range":{"start_line":378,"start_character":50,"end_line":394,"end_character":55},"updated":"2026-11-10 19:54:37.000000000","message":"```suggestion\n\nThe strategy compares each instance\u0027s ``Instance.pinned_az`` against the destination zone of the entry: ``dst_az`` for a zone pair, and the zone\nof the ``dst_node`` for a node pair.\n\n``skip_az_pinned_instances: False``\n  An instance whose pin conflicts with the destination zone\n  stays a candidate, and its ``migrate`` carries\n  ``repin_availability_zone: true`` so that the move can succeed. The\n  ``Migrate`` applier action clears the pin before the move and sets it to\n  the destination zone after, leaving the instance pinned to where it now\n  lives.\n\n``skip_az_pinned_instances: True (DEFAULT)``\n  An instance whose pin conflicts with the destination zone is excluded\n  from the action plan, and no action is emitted for it. The operator\n  resolves the pin, or leaves the instance where it is.\n```\n\nI think we may actully need to revies this to make skipping the defautl\n\ni know we have gone back and forward between the two\nbut for a public cloud it woudl be incorrect to repin by defualt.\n\nfor a private cloud it might be ok but the more concervit choice is to not include pinned isntaces as changeing the az is not somethign a operator shoudl do lightly if the end user has pinned the instnace.\n\nit can break ha policies, it can break other integration like openshit/k8s cloud provider scheduler integration, or octivia/heats az expections.\n\n\nas such i think its proably better in the long run if we are conservistive and avoid breakign integrations unless a admin opts into that.\n\ngiven they can set a default via the audit tempelate that does not impact the overal ux if it is a private cloud.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f2898912de2e3adfca1f5bda217ccd7e23c8affd","unresolved":true,"context_lines":[{"line_number":375,"context_line":"so reading the host\u0027s zone alone is not enough."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"Whether a pinned instance is worth moving at all is the operator\u0027s call,"},{"line_number":378,"context_line":"taken per entry via ``skip_az_pinned_instances``. The strategy compares"},{"line_number":379,"context_line":"each instance\u0027s ``Instance.pinned_az`` against the destination zone of the"},{"line_number":380,"context_line":"entry the instance came from: ``dst_az`` for a zone pair, and the zone"},{"line_number":381,"context_line":"``dst_node`` sits in for a node pair, read from the compute model."},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"``skip_az_pinned_instances: false``"},{"line_number":384,"context_line":"  The default. An instance whose pin conflicts with the destination zone"},{"line_number":385,"context_line":"  stays a candidate, and its ``migrate`` carries"},{"line_number":386,"context_line":"  ``repin_availability_zone: true`` so that the move can succeed. The"},{"line_number":387,"context_line":"  ``Migrate`` applier action clears the pin before the move and sets it to"},{"line_number":388,"context_line":"  the destination zone after, leaving the instance pinned to where it now"},{"line_number":389,"context_line":"  lives."},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"``skip_az_pinned_instances: true``"},{"line_number":392,"context_line":"  An instance whose pin conflicts with the destination zone is excluded"},{"line_number":393,"context_line":"  from the action plan, and no action is emitted for it. The operator"},{"line_number":394,"context_line":"  resolves the pin, or leaves the instance where it is."},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"Either way, an instance with no pin, or one already pinned to the"},{"line_number":397,"context_line":"destination zone, is a candidate and its ``migrate`` carries no"}],"source_content_type":"text/x-rst","patch_set":6,"id":"c92c3aef_77b1027d","line":394,"range":{"start_line":378,"start_character":50,"end_line":394,"end_character":55},"in_reply_to":"5f01c0a3_a8473890","updated":"2026-11-17 15:29:48.000000000","message":"It seems that there is no best option here. If we set to False, we would change previous behavior that was selecting all instances regarless of their pin. I think that for a Drain operation and a Hardware Maintenance Goal, makes sense to be True by default.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":true,"context_lines":[{"line_number":375,"context_line":"so reading the host\u0027s zone alone is not enough."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"Whether a pinned instance is worth moving at all is the operator\u0027s call,"},{"line_number":378,"context_line":"taken per entry via ``skip_az_pinned_instances``. The strategy compares"},{"line_number":379,"context_line":"each instance\u0027s ``Instance.pinned_az`` against the destination zone of the"},{"line_number":380,"context_line":"entry the instance came from: ``dst_az`` for a zone pair, and the zone"},{"line_number":381,"context_line":"``dst_node`` sits in for a node pair, read from the compute model."},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"``skip_az_pinned_instances: false``"},{"line_number":384,"context_line":"  The default. An instance whose pin conflicts with the destination zone"},{"line_number":385,"context_line":"  stays a candidate, and its ``migrate`` carries"},{"line_number":386,"context_line":"  ``repin_availability_zone: true`` so that the move can succeed. The"},{"line_number":387,"context_line":"  ``Migrate`` applier action clears the pin before the move and sets it to"},{"line_number":388,"context_line":"  the destination zone after, leaving the instance pinned to where it now"},{"line_number":389,"context_line":"  lives."},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"``skip_az_pinned_instances: true``"},{"line_number":392,"context_line":"  An instance whose pin conflicts with the destination zone is excluded"},{"line_number":393,"context_line":"  from the action plan, and no action is emitted for it. The operator"},{"line_number":394,"context_line":"  resolves the pin, or leaves the instance where it is."},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"Either way, an instance with no pin, or one already pinned to the"},{"line_number":397,"context_line":"destination zone, is a candidate and its ``migrate`` carries no"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f01c0a3_a8473890","line":394,"range":{"start_line":378,"start_character":50,"end_line":394,"end_character":55},"in_reply_to":"7b3f22a5_c7105c14","updated":"2026-11-11 22:10:40.000000000","message":"Ack, moving back to be include: False by default. Unless someone objects against it.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":395,"context_line":""},{"line_number":396,"context_line":"Either way, an instance with no pin, or one already pinned to the"},{"line_number":397,"context_line":"destination zone, is a candidate and its ``migrate`` carries no"},{"line_number":398,"context_line":"``repin_availability_zone``. Where an entry supplies neither a destination"},{"line_number":399,"context_line":"host nor a destination AZ, there is no zone to compare against: every"},{"line_number":400,"context_line":"instance is a candidate and any existing pin is preserved."},{"line_number":401,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bb0f50f6_8fa141a5","line":398,"range":{"start_line":398,"start_character":0,"end_line":398,"end_character":27},"updated":"2026-11-10 19:54:37.000000000","message":"i was expecting this to be an input parmater to the strage not to the migrat action\n\nwe may also need to have it on the migrate action but if we do that im not sure that we shoudl have 1 repin option vs an unpin and pin\n\nideally i woudl prefer this to be 3 actions in the graph but if we are not adding dedicated az pin and az unpin actions and only have a singel migrate action then\n\nwe may want ot condier how we experss the policy.\n\nit would be incorrect to pin all instance after the move uncondtionally\nbut some may want that bevhior where as other may want leave them all unpined or use the orginal value per isntnace\nhave you condier replaceing \n\n`repin_availability_zone` with `avialablity_zone_pining_policy`\n\nand suprpot the following\n\n- pin (unpin and pin all moved instnaces)\n- unpin (unpin all isntnace and dont pin them after the mvoe)\n- auto/origin (pin if pined before move)","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f2898912de2e3adfca1f5bda217ccd7e23c8affd","unresolved":false,"context_lines":[{"line_number":395,"context_line":""},{"line_number":396,"context_line":"Either way, an instance with no pin, or one already pinned to the"},{"line_number":397,"context_line":"destination zone, is a candidate and its ``migrate`` carries no"},{"line_number":398,"context_line":"``repin_availability_zone``. Where an entry supplies neither a destination"},{"line_number":399,"context_line":"host nor a destination AZ, there is no zone to compare against: every"},{"line_number":400,"context_line":"instance is a candidate and any existing pin is preserved."},{"line_number":401,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"cad47da1_9d98b19c","line":398,"range":{"start_line":398,"start_character":0,"end_line":398,"end_character":27},"in_reply_to":"6d2f41ac_5dab5b74","updated":"2026-11-17 15:29:48.000000000","message":"Done","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":true,"context_lines":[{"line_number":395,"context_line":""},{"line_number":396,"context_line":"Either way, an instance with no pin, or one already pinned to the"},{"line_number":397,"context_line":"destination zone, is a candidate and its ``migrate`` carries no"},{"line_number":398,"context_line":"``repin_availability_zone``. Where an entry supplies neither a destination"},{"line_number":399,"context_line":"host nor a destination AZ, there is no zone to compare against: every"},{"line_number":400,"context_line":"instance is a candidate and any existing pin is preserved."},{"line_number":401,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"6d2f41ac_5dab5b74","line":398,"range":{"start_line":398,"start_character":0,"end_line":398,"end_character":27},"in_reply_to":"bb0f50f6_8fa141a5","updated":"2026-11-11 22:10:40.000000000","message":"the policy one makes sense, its is easier to extend and adds more possibilities. So we would add the same policy to the zone_migration parameters. Note that this affects all other strategies, which would fail today. If a instance is pinned to AZ and the selected destination node lives in a different AZ, the action fails today.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":399,"context_line":"host nor a destination AZ, there is no zone to compare against: every"},{"line_number":400,"context_line":"instance is a candidate and any existing pin is preserved."},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"Clearing and restoring a pin belongs ``inside`` the ``Migrate`` action rather"},{"line_number":403,"context_line":"than in actions of its own. The three steps are one operation: unpin, move,"},{"line_number":404,"context_line":"pin. An action that owns all three keeps them together whatever the planner"},{"line_number":405,"context_line":"does with the rest of the plan, and keeps the unpin from being applied to an"},{"line_number":406,"context_line":"instance whose migration never runs or that was eventually skipped."},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"The action is not atomic. If the migration fails after the pin has been"},{"line_number":409,"context_line":"cleared, the ``Migrate`` action attempts to restore the original"}],"source_content_type":"text/x-rst","patch_set":6,"id":"686d6399_dc04f3bd","line":406,"range":{"start_line":402,"start_character":0,"end_line":406,"end_character":67},"updated":"2026-11-10 19:54:37.000000000","message":"i still think this is a worse design then 3 actions with depencies for what its worth\n\nit can live there but i woudl be better to have a tripel of action with depencies IMO\n\nthat way we do not need to add parmaters to the existing migrate action and instead we can just add the actions when needed and track the depencies.\n\nbut as noted above if we keep it internal we shoudl decouple the unping and pinning rahter then having a single boolean for both either via sperate booleasn or the policy i suggest above.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":true,"context_lines":[{"line_number":399,"context_line":"host nor a destination AZ, there is no zone to compare against: every"},{"line_number":400,"context_line":"instance is a candidate and any existing pin is preserved."},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"Clearing and restoring a pin belongs ``inside`` the ``Migrate`` action rather"},{"line_number":403,"context_line":"than in actions of its own. The three steps are one operation: unpin, move,"},{"line_number":404,"context_line":"pin. An action that owns all three keeps them together whatever the planner"},{"line_number":405,"context_line":"does with the rest of the plan, and keeps the unpin from being applied to an"},{"line_number":406,"context_line":"instance whose migration never runs or that was eventually skipped."},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"The action is not atomic. If the migration fails after the pin has been"},{"line_number":409,"context_line":"cleared, the ``Migrate`` action attempts to restore the original"}],"source_content_type":"text/x-rst","patch_set":6,"id":"b19254f6_20cea927","line":406,"range":{"start_line":402,"start_character":0,"end_line":406,"end_character":67},"in_reply_to":"686d6399_dc04f3bd","updated":"2026-11-11 22:10:40.000000000","message":"yeah, that was my feeling at the beginning, but we don\u0027t have a planner that is ready to deal with these dependencies. We would need to extend the default planner to support it. It will also blocks us from reverting an pin if needed (we may not want to do that too), and it will increase the amount of actions in the AP. so there are pros and cons, but still, this operation is very tide to the migration operation. We may want in the future to split it, or create a base action that will be consumed by other operations like evacuate, etc.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":406,"context_line":"instance whose migration never runs or that was eventually skipped."},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"The action is not atomic. If the migration fails after the pin has been"},{"line_number":409,"context_line":"cleared, the ``Migrate`` action attempts to restore the original"},{"line_number":410,"context_line":"``pinned_availability_zone`` before reporting failure. The rollback is"},{"line_number":411,"context_line":"best-effort: if the re-pin Nova call itself fails, the instance is left"},{"line_number":412,"context_line":"unpinned and the failure is logged, but the action still reports the original"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3c3e57a9_fe472ddb","line":409,"range":{"start_line":409,"start_character":0,"end_line":409,"end_character":7},"updated":"2026-11-10 19:54:37.000000000","message":"approved?","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":406,"context_line":"instance whose migration never runs or that was eventually skipped."},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"The action is not atomic. If the migration fails after the pin has been"},{"line_number":409,"context_line":"cleared, the ``Migrate`` action attempts to restore the original"},{"line_number":410,"context_line":"``pinned_availability_zone`` before reporting failure. The rollback is"},{"line_number":411,"context_line":"best-effort: if the re-pin Nova call itself fails, the instance is left"},{"line_number":412,"context_line":"unpinned and the failure is logged, but the action still reports the original"}],"source_content_type":"text/x-rst","patch_set":6,"id":"e7eeac79_51afc011","line":409,"range":{"start_line":409,"start_character":0,"end_line":409,"end_character":7},"in_reply_to":"3c3e57a9_fe472ddb","updated":"2026-11-11 22:10:40.000000000","message":"cleared in the meaning of setting the pin to None, which is the unpin op. moving to \u0027removed\u0027.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":406,"context_line":"instance whose migration never runs or that was eventually skipped."},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"The action is not atomic. If the migration fails after the pin has been"},{"line_number":409,"context_line":"cleared, the ``Migrate`` action attempts to restore the original"},{"line_number":410,"context_line":"``pinned_availability_zone`` before reporting failure. The rollback is"},{"line_number":411,"context_line":"best-effort: if the re-pin Nova call itself fails, the instance is left"},{"line_number":412,"context_line":"unpinned and the failure is logged, but the action still reports the original"},{"line_number":413,"context_line":"migration error. There is no revert for a pin that was successfully set to"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1651af67_67d5d836","line":410,"range":{"start_line":409,"start_character":9,"end_line":410,"end_character":54},"updated":"2026-11-10 19:54:37.000000000","message":"this i disagree with it might be reason for nova to have the restore semantics but i dont think watcher shoudl try and fix it\nwe could, but that will also potentially fail depending on how it failed as you can only pin to the az the vm currently is in and we may not know wehre it is depening on how it failed.\nfor example if it times out we dont really knwo if the migration is still happening or where it is.\n\nwe should keep i very simple and determistic\n\nif the migrate fails we should lave the instance in whatever state its in and not attempt to fix it.\n\nthat is partly why i prefer havign 3 actions not one as it woudl be clear where we stoped.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":true,"context_lines":[{"line_number":406,"context_line":"instance whose migration never runs or that was eventually skipped."},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"The action is not atomic. If the migration fails after the pin has been"},{"line_number":409,"context_line":"cleared, the ``Migrate`` action attempts to restore the original"},{"line_number":410,"context_line":"``pinned_availability_zone`` before reporting failure. The rollback is"},{"line_number":411,"context_line":"best-effort: if the re-pin Nova call itself fails, the instance is left"},{"line_number":412,"context_line":"unpinned and the failure is logged, but the action still reports the original"},{"line_number":413,"context_line":"migration error. There is no revert for a pin that was successfully set to"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1bfa82d0_69dd9003","line":410,"range":{"start_line":409,"start_character":9,"end_line":410,"end_character":54},"in_reply_to":"1651af67_67d5d836","updated":"2026-11-11 22:10:40.000000000","message":"right, we can get a 409 trying to fix the pin, depending on which az is configured for the instance. I haven\u0027t tested this behavior yet. I may put that concern in the next ps.\nWe can also likely validate that in during the implementation and decide what would be the best, and update the spec if needed.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":415,"context_line":""},{"line_number":416,"context_line":"Watcher captures ``pinned_availability_zone`` in the cluster data model"},{"line_number":417,"context_line":"when extended attributes are collected, and the strategy reads it from"},{"line_number":418,"context_line":"there. Nova emits no notification when a pin changes, so the value is"},{"line_number":419,"context_line":"refreshed only on the next periodic collector run and an operator who"},{"line_number":420,"context_line":"repins an instance directly through Nova between collection and execution"},{"line_number":421,"context_line":"will have been selected against a stale pin. The consequence is bounded:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"8c78e5cc_549f82be","line":418,"range":{"start_line":418,"start_character":39,"end_line":418,"end_character":52},"updated":"2026-11-10 19:54:37.000000000","message":"are you shoure about this becasue it should emit a InstanceUpdateNotification\n\nhttps://github.com/openstack/nova/blob/master/nova/notifications/objects/instance.py#L646-L655\n\nits ture that that does not contin the requried field\n\nhttps://github.com/openstack/nova/blob/master/nova/notifications/objects/instance.py#L310-L341\n\nbut we can use that notificaion to do an api request (server show) to get the requried info form nova when an isntnace is updated.\n\nit woudl be nicer if nova just provided the data but we can use the notifcaion as a triger to update oru model instead of wating for the next collecter interval.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":413,"context_line":"migration error. There is no revert for a pin that was successfully set to"},{"line_number":414,"context_line":"``destination_az`` after a completed migration."},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"Watcher captures ``pinned_availability_zone`` in the cluster data model"},{"line_number":417,"context_line":"when extended attributes are collected, and the strategy reads it from"},{"line_number":418,"context_line":"there. Nova emits no notification when a pin changes, so the value is"},{"line_number":419,"context_line":"refreshed only on the next periodic collector run and an operator who"},{"line_number":420,"context_line":"repins an instance directly through Nova between collection and execution"},{"line_number":421,"context_line":"will have been selected against a stale pin. The consequence is bounded:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"4dd66bf5_98e6d2ff","line":418,"range":{"start_line":416,"start_character":0,"end_line":418,"end_character":6},"updated":"2026-11-10 19:54:37.000000000","message":"note given we drop and recreate the model every time the collector runs we cant rely on this later to make any descsion about what to restore too","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"2a53ab0a3b905f029e71e45f70b79e233cf72e1a","unresolved":true,"context_lines":[{"line_number":415,"context_line":""},{"line_number":416,"context_line":"Watcher captures ``pinned_availability_zone`` in the cluster data model"},{"line_number":417,"context_line":"when extended attributes are collected, and the strategy reads it from"},{"line_number":418,"context_line":"there. Nova emits no notification when a pin changes, so the value is"},{"line_number":419,"context_line":"refreshed only on the next periodic collector run and an operator who"},{"line_number":420,"context_line":"repins an instance directly through Nova between collection and execution"},{"line_number":421,"context_line":"will have been selected against a stale pin. The consequence is bounded:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"55f476fb_e70595af","line":418,"range":{"start_line":418,"start_character":39,"end_line":418,"end_character":52},"in_reply_to":"14b90123_fdece22b","updated":"2026-11-13 16:12:29.000000000","message":"It\u0027d be good to report a bug to nova, maybe?","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":true,"context_lines":[{"line_number":413,"context_line":"migration error. There is no revert for a pin that was successfully set to"},{"line_number":414,"context_line":"``destination_az`` after a completed migration."},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"Watcher captures ``pinned_availability_zone`` in the cluster data model"},{"line_number":417,"context_line":"when extended attributes are collected, and the strategy reads it from"},{"line_number":418,"context_line":"there. Nova emits no notification when a pin changes, so the value is"},{"line_number":419,"context_line":"refreshed only on the next periodic collector run and an operator who"},{"line_number":420,"context_line":"repins an instance directly through Nova between collection and execution"},{"line_number":421,"context_line":"will have been selected against a stale pin. The consequence is bounded:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"d48c4676_343803d3","line":418,"range":{"start_line":416,"start_character":0,"end_line":418,"end_character":6},"in_reply_to":"4dd66bf5_98e6d2ff","updated":"2026-11-11 22:10:40.000000000","message":"the pin/unpin is handled in the Migrate action, where we retrieve Instance\u0027s info at pre_execute() and cache it. So we rely on that info during AP execution. The stale info from the model is more at strategy execution time.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"bf14776572a132af787cdc849ee29618afbc5c98","unresolved":true,"context_lines":[{"line_number":415,"context_line":""},{"line_number":416,"context_line":"Watcher captures ``pinned_availability_zone`` in the cluster data model"},{"line_number":417,"context_line":"when extended attributes are collected, and the strategy reads it from"},{"line_number":418,"context_line":"there. Nova emits no notification when a pin changes, so the value is"},{"line_number":419,"context_line":"refreshed only on the next periodic collector run and an operator who"},{"line_number":420,"context_line":"repins an instance directly through Nova between collection and execution"},{"line_number":421,"context_line":"will have been selected against a stale pin. The consequence is bounded:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"14b90123_fdece22b","line":418,"range":{"start_line":418,"start_character":39,"end_line":418,"end_character":52},"in_reply_to":"6740014c_1f184b25","updated":"2026-11-13 13:07:39.000000000","message":"yeah but the scheduler notification is sent only when scheduler is called to find a destination for a server, for example. An update in the request spec does not trigger that. Maybe nova would need to send a simple Req Spec update notification when parameters change. We need to discuss this with the nova team.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":true,"context_lines":[{"line_number":415,"context_line":""},{"line_number":416,"context_line":"Watcher captures ``pinned_availability_zone`` in the cluster data model"},{"line_number":417,"context_line":"when extended attributes are collected, and the strategy reads it from"},{"line_number":418,"context_line":"there. Nova emits no notification when a pin changes, so the value is"},{"line_number":419,"context_line":"refreshed only on the next periodic collector run and an operator who"},{"line_number":420,"context_line":"repins an instance directly through Nova between collection and execution"},{"line_number":421,"context_line":"will have been selected against a stale pin. The consequence is bounded:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f86329d_ec51f30f","line":418,"range":{"start_line":418,"start_character":39,"end_line":418,"end_character":52},"in_reply_to":"8c78e5cc_549f82be","updated":"2026-11-11 22:10:40.000000000","message":"So with Claude\u0027s help, and followin the code, there is no noitifications sent, since the update_dict of the instance is empty, since pin updates the request_spec object.\n1) https://github.com/openstack/nova/blob/7f17f2ea5ecd29f97ebc42013b6f97a0a114d0c9/nova/api/openstack/compute/servers.py#L1040 gets an empty update_dict.\n2) https://github.com/openstack/nova/blob/7f17f2ea5ecd29f97ebc42013b6f97a0a114d0c9/nova/objects/instance.py#L856-L857 - returns and no notification sent.\n\nwe could indeed retrieve all info if we get any notification, but it is not the case.\nreq_spec notifications are also sent only by the scheduler.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"164133e18634fcb470a05a520c60f0f788d624a0","unresolved":true,"context_lines":[{"line_number":415,"context_line":""},{"line_number":416,"context_line":"Watcher captures ``pinned_availability_zone`` in the cluster data model"},{"line_number":417,"context_line":"when extended attributes are collected, and the strategy reads it from"},{"line_number":418,"context_line":"there. Nova emits no notification when a pin changes, so the value is"},{"line_number":419,"context_line":"refreshed only on the next periodic collector run and an operator who"},{"line_number":420,"context_line":"repins an instance directly through Nova between collection and execution"},{"line_number":421,"context_line":"will have been selected against a stale pin. The consequence is bounded:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"6740014c_1f184b25","line":418,"range":{"start_line":418,"start_character":39,"end_line":418,"end_character":52},"in_reply_to":"9f86329d_ec51f30f","updated":"2026-11-13 12:32:44.000000000","message":"we also consume notifications from the scheduler, but we are just not processing them. We could act upon them if needed.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":424,"context_line":"left out of a plan it could have joined. Re-running the audit after the"},{"line_number":425,"context_line":"next collection resolves either case."},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"``repin_availability_zone`` is a parameter of the ``Migrate`` action"},{"line_number":428,"context_line":"rather than a strategy concern, and it defaults to ``false``, so actions"},{"line_number":429,"context_line":"built by any other strategy are unaffected. ``zone_migration`` is its only"},{"line_number":430,"context_line":"consumer for now, and sets it only on the instances it keeps despite a"},{"line_number":431,"context_line":"conflicting pin."},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"Reading the pin at all depends on ``[compute_model]"},{"line_number":434,"context_line":"enable_extended_attributes``, which this spec changes to default ``true``."}],"source_content_type":"text/x-rst","patch_set":6,"id":"3affce85_78dde7fe","line":431,"range":{"start_line":427,"start_character":1,"end_line":431,"end_character":16},"updated":"2026-11-10 19:54:37.000000000","message":"as noted above.\ni thnk the strage need to have a policy and then it may be fine to have a parmter to the migrate action but we likely need to either make this contol only repinning the instance or have 2 parmaters to the action.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":424,"context_line":"left out of a plan it could have joined. Re-running the audit after the"},{"line_number":425,"context_line":"next collection resolves either case."},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"``repin_availability_zone`` is a parameter of the ``Migrate`` action"},{"line_number":428,"context_line":"rather than a strategy concern, and it defaults to ``false``, so actions"},{"line_number":429,"context_line":"built by any other strategy are unaffected. ``zone_migration`` is its only"},{"line_number":430,"context_line":"consumer for now, and sets it only on the instances it keeps despite a"},{"line_number":431,"context_line":"conflicting pin."},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"Reading the pin at all depends on ``[compute_model]"},{"line_number":434,"context_line":"enable_extended_attributes``, which this spec changes to default ``true``."}],"source_content_type":"text/x-rst","patch_set":6,"id":"52691b28_5e8ebf9c","line":431,"range":{"start_line":427,"start_character":1,"end_line":431,"end_character":16},"in_reply_to":"3affce85_78dde7fe","updated":"2026-11-11 22:10:40.000000000","message":"yeah, replacing this with a policy configuration","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"2e58dea1244a91ca75fb5e7e02450cc9058e34ef","unresolved":false,"context_lines":[{"line_number":432,"context_line":""},{"line_number":433,"context_line":"Reading the pin at all depends on ``[compute_model]"},{"line_number":434,"context_line":"enable_extended_attributes``, which this spec changes to default ``true``."},{"line_number":435,"context_line":"Left at ``false``, ``Instance.pinned_az`` is empty for every instance, so"},{"line_number":436,"context_line":"``skip_az_pinned_instances`` would silently match nothing and a drain would"},{"line_number":437,"context_line":"emit a plain ``migrate`` for each pinned instance for Nova to reject. A"},{"line_number":438,"context_line":"filter that quietly does nothing is worse than one that costs an extra"}],"source_content_type":"text/x-rst","patch_set":6,"id":"736ba7b0_8b32e1f4","line":435,"updated":"2026-11-09 18:55:37.000000000","message":"The Proposed Change states that the decision engine checks runtime prerequisites in pre_execute, \"including required Nova capabilities, extended-attribute collection and values resolved through the cluster data model\", and that \"If required extended information is not enabled on the deployment, the audit will fail with a reason explaining that requirement.\" The Pinned Instances section then justifies flipping enable_extended_attributes to true by saying that left at false, \"``skip_az_pinned_instances`` would silently match nothing and a drain would emit a plain ``migrate`` for each pinned instance for Nova to reject.\" Both passages are new behavior defined by this spec for the same condition (collection disabled plus an AZ drain), but they describe opposite failure modes: a loud audit failure with a reason versus silent per-instance migration failures at apply time.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: An operator who explicitly sets enable_extended_attributes\u003dfalse cannot tell whether a zone drain fails up front with an explanation or runs and fails per instance at apply time when Nova rejects the unrepinned migrations; implementers likewise cannot tell whether the pre_execute gate is meant to cover this case, which changes whether the silent failure mode remains reachable.\n\n**Suggestion**:\nReconcile the two passages: state explicitly that pre_execute fails the audit when a pin-aware entry runs with extended-attribute collection disabled, and rephrase the default-flip rationale accordingly (for example, the default change avoids a hard pre_execute failure for deployments that never set the option), or scope the gate so the silent path is genuinely reachable and documented.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":442,"context_line":"Parallelism Counters"},{"line_number":443,"context_line":"--------------------"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"``zone_migration`` exposes three input parameters that cap how many actions"},{"line_number":446,"context_line":"the planner receives in a single action plan:"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"* ``parallel_total`` — total actions across all nodes and pools combined."},{"line_number":449,"context_line":"* ``parallel_per_node`` — migrate actions per compute node."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9eb2f584_41003317","line":446,"range":{"start_line":445,"start_character":0,"end_line":446,"end_character":45},"updated":"2026-11-10 19:54:37.000000000","message":"```suggestion\nThe ``zone_migration`` stragey exposes three input parameters that cap how many actions the planner may generate in a single action plan:\n```","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":442,"context_line":"Parallelism Counters"},{"line_number":443,"context_line":"--------------------"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"``zone_migration`` exposes three input parameters that cap how many actions"},{"line_number":446,"context_line":"the planner receives in a single action plan:"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"* ``parallel_total`` — total actions across all nodes and pools combined."},{"line_number":449,"context_line":"* ``parallel_per_node`` — migrate actions per compute node."}],"source_content_type":"text/x-rst","patch_set":6,"id":"eee2431a_5bc23289","line":446,"range":{"start_line":445,"start_character":0,"end_line":446,"end_character":45},"in_reply_to":"9eb2f584_41003317","updated":"2026-11-11 22:10:40.000000000","message":"Done","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"2e58dea1244a91ca75fb5e7e02450cc9058e34ef","unresolved":false,"context_lines":[{"line_number":453,"context_line":"full AZ drain, where the source zone may hold tens of nodes and hundreds of"},{"line_number":454,"context_line":"instances, those caps silently truncate the plan: the operator expects a"},{"line_number":455,"context_line":"full drain, gets a partial one, and must re-trigger the audit repeatedly."},{"line_number":456,"context_line":"This spec therefore deprecates all three parameters outright and"},{"line_number":457,"context_line":"neutralises them in the meantime."},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"This spec makes three changes to the counter semantics:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"75470251_8c1729e5","line":456,"updated":"2026-11-09 18:55:37.000000000","message":"The intro of the Parallelism Counters section states the spec \"deprecates all three parameters outright and neutralises them in the meantime\". The very next bullet states \"The parameters keep working for operators who set an explicit positive integer\", the following bullet defines counting semantics \"when set to a finite value\", Upgrade Impact says an audit that sets any of the three explicitly \"keeps that value\", and the Documentation Impact section asks for \"guidance for choosing explicit positive values when a cap is desired\". Neutralised and keep-working are opposite behaviors for the same parameters, so implementers get conflicting requirements from one section of the spec.\n\n**Severity**: WARNING | **Confidence**: 0.85\n\n**Impact**: An implementer following the intro sentence would hard-ignore explicit positive values (full drain regardless), while one following the bullets and Upgrade Impact would honor them (partial drain); the two implementations produce observably different operator outcomes and the schema, documentation, and deprecation work items cannot be written consistently until the contradiction is resolved.\n\n**Suggestion**:\nReword the intro sentence to match the defined semantics, for example: \"This spec therefore deprecates all three parameters and makes them unlimited by default; explicit positive values keep working until the parameters are removed.\"","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":453,"context_line":"full AZ drain, where the source zone may hold tens of nodes and hundreds of"},{"line_number":454,"context_line":"instances, those caps silently truncate the plan: the operator expects a"},{"line_number":455,"context_line":"full drain, gets a partial one, and must re-trigger the audit repeatedly."},{"line_number":456,"context_line":"This spec therefore deprecates all three parameters outright and"},{"line_number":457,"context_line":"neutralises them in the meantime."},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"This spec makes three changes to the counter semantics:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"e3961fb8_a77c00f4","line":456,"in_reply_to":"00cf02d0_a1a36a68","updated":"2026-11-11 22:10:40.000000000","message":"updated,tks","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":453,"context_line":"full AZ drain, where the source zone may hold tens of nodes and hundreds of"},{"line_number":454,"context_line":"instances, those caps silently truncate the plan: the operator expects a"},{"line_number":455,"context_line":"full drain, gets a partial one, and must re-trigger the audit repeatedly."},{"line_number":456,"context_line":"This spec therefore deprecates all three parameters outright and"},{"line_number":457,"context_line":"neutralises them in the meantime."},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"This spec makes three changes to the counter semantics:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"00cf02d0_a1a36a68","line":456,"in_reply_to":"75470251_8c1729e5","updated":"2026-11-10 19:54:37.000000000","message":"ya this is better `neutralises` impleise that they would be inaffective and not work any more\n\nand that woudl actully be the equivlent of a removal\n\nwe can actully remove the ablity to pass these without having version straigies as that woudl be a backward incompatbale api change.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":false,"context_lines":[{"line_number":467,"context_line":"(unlimited), so an audit that does not mention them drains fully. The"},{"line_number":468,"context_line":"parameters keep working for operators who set an explicit positive integer,"},{"line_number":469,"context_line":"but are marked deprecated in the strategy schema and documentation from this"},{"line_number":470,"context_line":"release, and will be removed from ``zone_migration`` in a future release once"},{"line_number":471,"context_line":"documentation and tooling give operators another way to throttle a drain."},{"line_number":472,"context_line":"The old 6 / 2 / 2 defaults are not carried forward."},{"line_number":473,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"f17dda97_efda8e2d","line":470,"range":{"start_line":470,"start_character":9,"end_line":470,"end_character":53},"updated":"2026-11-10 19:54:37.000000000","message":"ya we still need to decied how to do this.\n\nwe cant do it until at least 2027.2 per our deprecation rules but even then i suspect it will be a couple of release before we have all the machinary rqrueid to proably make a backward incompatble schema change and we will evanutlly need to decied if we start coverging schema parmater by microversion rules or not","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":475,"context_line":"When an entry sets ``disable_source_nodes``, each emitted"},{"line_number":476,"context_line":"``change_nova_service_state`` action is included in both the"},{"line_number":477,"context_line":"``parallel_total`` budget and the per-node budget for its source node,"},{"line_number":478,"context_line":"alongside instance and volume actions. A disable action is operationally"},{"line_number":479,"context_line":"concurrent with migrations; counting it in both dimensions prevents either"},{"line_number":480,"context_line":"counter from under-representing the plan size when set to a finite value."},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"A dedicated section in the ``zone_migration`` strategy documentation will"}],"source_content_type":"text/x-rst","patch_set":6,"id":"0e18336f_0e46e559","line":479,"range":{"start_line":478,"start_character":39,"end_line":479,"end_character":27},"updated":"2026-11-10 19:54:37.000000000","message":"its not concurrent, it can fail indepently of the migraiton and it happens before deteministicly per the spec.\n\nit would be incorrect to exclude it form the counting in my view while we supprot these limtits.\n\n\nthe larger question is what ot do for pin and unpin\n\nthose are aslo seperate api actions on teh nova side and are not part of the migration but we excldue migrate/resize confirm/revert form the count\n\nso we can condier wehter we only count the nodes in our grap isntead fo the api action but disblign a node shoudl not be the sideeffect of a migration action\n\nso with it may be valid to fold int he pin/unpin under a single migrate action it is not ok to fold in the disbale of the souce host","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":true,"context_lines":[{"line_number":475,"context_line":"When an entry sets ``disable_source_nodes``, each emitted"},{"line_number":476,"context_line":"``change_nova_service_state`` action is included in both the"},{"line_number":477,"context_line":"``parallel_total`` budget and the per-node budget for its source node,"},{"line_number":478,"context_line":"alongside instance and volume actions. A disable action is operationally"},{"line_number":479,"context_line":"concurrent with migrations; counting it in both dimensions prevents either"},{"line_number":480,"context_line":"counter from under-representing the plan size when set to a finite value."},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"A dedicated section in the ``zone_migration`` strategy documentation will"}],"source_content_type":"text/x-rst","patch_set":6,"id":"60e3f622_5f6f593f","line":479,"range":{"start_line":478,"start_character":39,"end_line":479,"end_character":27},"in_reply_to":"0e18336f_0e46e559","updated":"2026-11-11 22:10:40.000000000","message":"I removed this entire sentence as it doesn\u0027t add anything to the text imho.\n\nAbout pin/unpin, I believe that since they are part of the migrate action, we would count them as a single operation. As Alfredo already mentioned in previous PS, both pin/unpin and disable source service are operations that don\u0027t take long, if we compare with migrations. We believe that this limits are more useful with long running tasks other than these new ones. In the end, the discussion about having the pin inside the Migrate action is more a dependency issue that we can\u0027t easily solve today with existing planners. We may want to discuss that in the irc or in another thread?","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":502,"context_line":"    compute_nodes:"},{"line_number":503,"context_line":"      - src_az: az-a"},{"line_number":504,"context_line":"        dst_az: az-b"},{"line_number":505,"context_line":"        skip_az_pinned_instances: false"},{"line_number":506,"context_line":"        disable_source_nodes: true"},{"line_number":507,"context_line":"    storage_pools:"},{"line_number":508,"context_line":"      - src_pool: pool-a"}],"source_content_type":"text/x-rst","patch_set":6,"id":"c4b17364_2830cf16","line":505,"range":{"start_line":505,"start_character":0,"end_line":505,"end_character":39},"updated":"2026-11-10 19:54:37.000000000","message":"i wonder if we shoudl avoid the double negations\n\n\n\n```suggestion\n        include_az_pinned_instances: true\n```","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":502,"context_line":"    compute_nodes:"},{"line_number":503,"context_line":"      - src_az: az-a"},{"line_number":504,"context_line":"        dst_az: az-b"},{"line_number":505,"context_line":"        skip_az_pinned_instances: false"},{"line_number":506,"context_line":"        disable_source_nodes: true"},{"line_number":507,"context_line":"    storage_pools:"},{"line_number":508,"context_line":"      - src_pool: pool-a"}],"source_content_type":"text/x-rst","patch_set":6,"id":"978e377c_58a50534","line":505,"range":{"start_line":505,"start_character":0,"end_line":505,"end_character":39},"in_reply_to":"c4b17364_2830cf16","updated":"2026-11-11 22:10:40.000000000","message":"Done","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":518,"context_line":"#. ``Schema validation``, before the strategy runs. The ``compute_nodes``"},{"line_number":519,"context_line":"   entry is a well-formed zone pair, the ``storage_pools`` entry a"},{"line_number":520,"context_line":"   well-formed pool pair."},{"line_number":521,"context_line":"#. ``Gates``, during strategy execution. ``az-a`` and ``az-b`` each match at"},{"line_number":522,"context_line":"   least one node in the compute model, and the configured Nova microversion"},{"line_number":523,"context_line":"   is at least ``2.105``. The Cinder collector is enabled, so the storage"},{"line_number":524,"context_line":"   model exists."}],"source_content_type":"text/x-rst","patch_set":6,"id":"056e3eb7_820c8855","line":521,"range":{"start_line":521,"start_character":5,"end_line":521,"end_character":10},"updated":"2026-11-10 19:54:37.000000000","message":"gates is not a term we use in watcher.\n\nthese are really pre-conditions","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":518,"context_line":"#. ``Schema validation``, before the strategy runs. The ``compute_nodes``"},{"line_number":519,"context_line":"   entry is a well-formed zone pair, the ``storage_pools`` entry a"},{"line_number":520,"context_line":"   well-formed pool pair."},{"line_number":521,"context_line":"#. ``Gates``, during strategy execution. ``az-a`` and ``az-b`` each match at"},{"line_number":522,"context_line":"   least one node in the compute model, and the configured Nova microversion"},{"line_number":523,"context_line":"   is at least ``2.105``. The Cinder collector is enabled, so the storage"},{"line_number":524,"context_line":"   model exists."}],"source_content_type":"text/x-rst","patch_set":6,"id":"caf0620a_8c983b56","line":521,"range":{"start_line":521,"start_character":5,"end_line":521,"end_character":10},"in_reply_to":"056e3eb7_820c8855","updated":"2026-11-11 22:10:40.000000000","message":"Agreed","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":522,"context_line":"   least one node in the compute model, and the configured Nova microversion"},{"line_number":523,"context_line":"   is at least ``2.105``. The Cinder collector is enabled, so the storage"},{"line_number":524,"context_line":"   model exists."},{"line_number":525,"context_line":"#. ``Targets``. Both parameters are supplied, so this audit drains instances"},{"line_number":526,"context_line":"   and volumes."},{"line_number":527,"context_line":"#. ``Source nodes``. Every node in the *scoped* compute model with"},{"line_number":528,"context_line":"   ``availability_zone \u003d\u003d az-a`` that is online: ``compute-a1``,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"307af1b5_3d191bd2","line":525,"range":{"start_line":525,"start_character":5,"end_line":525,"end_character":12},"updated":"2026-11-10 19:54:37.000000000","message":"Candiates?\n\ni woudl say scope but thats overloaded.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":522,"context_line":"   least one node in the compute model, and the configured Nova microversion"},{"line_number":523,"context_line":"   is at least ``2.105``. The Cinder collector is enabled, so the storage"},{"line_number":524,"context_line":"   model exists."},{"line_number":525,"context_line":"#. ``Targets``. Both parameters are supplied, so this audit drains instances"},{"line_number":526,"context_line":"   and volumes."},{"line_number":527,"context_line":"#. ``Source nodes``. Every node in the *scoped* compute model with"},{"line_number":528,"context_line":"   ``availability_zone \u003d\u003d az-a`` that is online: ``compute-a1``,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"676070e1_021e13d6","line":525,"range":{"start_line":525,"start_character":5,"end_line":525,"end_character":12},"in_reply_to":"307af1b5_3d191bd2","updated":"2026-11-11 22:10:40.000000000","message":"yeah, works for me.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":525,"context_line":"#. ``Targets``. Both parameters are supplied, so this audit drains instances"},{"line_number":526,"context_line":"   and volumes."},{"line_number":527,"context_line":"#. ``Source nodes``. Every node in the *scoped* compute model with"},{"line_number":528,"context_line":"   ``availability_zone \u003d\u003d az-a`` that is online: ``compute-a1``,"},{"line_number":529,"context_line":"   ``compute-a2`` and ``compute-a4``. ``compute-a3`` was removed by the audit"},{"line_number":530,"context_line":"   scope before the strategy saw the model, so it is not a source and produces"},{"line_number":531,"context_line":"   no actions."}],"source_content_type":"text/x-rst","patch_set":6,"id":"3987d2c0_0d31e686","line":528,"range":{"start_line":528,"start_character":41,"end_line":528,"end_character":47},"updated":"2026-11-10 19:54:37.000000000","message":"again online is not a term of art in nova and does nto apply to compute service  or compute ndoes\n\ndo you mean up or enabeld\n\nwhether a compute service is up or down (determine by a heatbeat)\nis tracked in the `state` field.\n\nif a comptue service is eligable for now worklaod si tracked in teh \n\nstatus field as enabled or disabled.\n\ni assume you meant compute service whoes state is up above when you say onlien\nwe shoudl use the correct terminology in the spec\n\ncompute service that are down are not reachable over RPC so all api actions against instance on that host will fail except evacuate","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":525,"context_line":"#. ``Targets``. Both parameters are supplied, so this audit drains instances"},{"line_number":526,"context_line":"   and volumes."},{"line_number":527,"context_line":"#. ``Source nodes``. Every node in the *scoped* compute model with"},{"line_number":528,"context_line":"   ``availability_zone \u003d\u003d az-a`` that is online: ``compute-a1``,"},{"line_number":529,"context_line":"   ``compute-a2`` and ``compute-a4``. ``compute-a3`` was removed by the audit"},{"line_number":530,"context_line":"   scope before the strategy saw the model, so it is not a source and produces"},{"line_number":531,"context_line":"   no actions."}],"source_content_type":"text/x-rst","patch_set":6,"id":"f4fbcef8_112b2683","line":528,"range":{"start_line":528,"start_character":41,"end_line":528,"end_character":47},"in_reply_to":"3987d2c0_0d31e686","updated":"2026-11-11 22:10:40.000000000","message":"fixed","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":false,"context_lines":[{"line_number":571,"context_line":"``zone_migration`` was chosen because the strategy already handles the node-"},{"line_number":572,"context_line":"and pool-level cases this spec generalises."},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"``Watcher picks destination hosts within the destination zone``. A round-robin"},{"line_number":575,"context_line":"across the enabled nodes of ``dst_az``. It needs no Nova feature, but it makes"},{"line_number":576,"context_line":"Watcher act as a scheduler for a strategy that deliberately does no capacity"},{"line_number":577,"context_line":"accounting, so it would overcommit hosts, and it is unaware of the"},{"line_number":578,"context_line":"placement constraints that would make those migrations likely to fail at"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dc9011ed_0cb30e45","line":575,"range":{"start_line":574,"start_character":65,"end_line":575,"end_character":40},"updated":"2026-11-10 19:54:37.000000000","message":"we woudl likely need to do somehtign better then that such as filterign by capsity and perhasp some of the logic of the worklaod stablisation or consolition stargies.\n\n\nby delegating to nova the operator can express there pack or spread prefence in the nova schduelr config via weigher multiplers.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":false,"context_lines":[{"line_number":574,"context_line":"``Watcher picks destination hosts within the destination zone``. A round-robin"},{"line_number":575,"context_line":"across the enabled nodes of ``dst_az``. It needs no Nova feature, but it makes"},{"line_number":576,"context_line":"Watcher act as a scheduler for a strategy that deliberately does no capacity"},{"line_number":577,"context_line":"accounting, so it would overcommit hosts, and it is unaware of the"},{"line_number":578,"context_line":"placement constraints that would make those migrations likely to fail at"},{"line_number":579,"context_line":"execution time."},{"line_number":580,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"e2bf9067_08d2ae3e","line":577,"range":{"start_line":577,"start_character":12,"end_line":577,"end_character":41},"updated":"2026-11-10 19:54:37.000000000","message":"for this to be a viable alternative we would need at least basic capacity planning which would chagne the scope of the feature","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":590,"context_line":"Data Model Impact"},{"line_number":591,"context_line":"-----------------"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"``ComputeNode`` gains an ``availability_zone`` string field, defaulting to"},{"line_number":594,"context_line":"empty. The Nova collector builds a host-to-zone dict once per model build from"},{"line_number":595,"context_line":"``nova_helper.get_service_list()`` and populates the field."},{"line_number":596,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"76335642_5c44f63a","line":593,"range":{"start_line":593,"start_character":2,"end_line":593,"end_character":13},"updated":"2026-11-10 19:54:37.000000000","message":"nit its techicnaly the comptue service that has the zone memebership but ya this is fine","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":590,"context_line":"Data Model Impact"},{"line_number":591,"context_line":"-----------------"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"``ComputeNode`` gains an ``availability_zone`` string field, defaulting to"},{"line_number":594,"context_line":"empty. The Nova collector builds a host-to-zone dict once per model build from"},{"line_number":595,"context_line":"``nova_helper.get_service_list()`` and populates the field."},{"line_number":596,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7552c8c4_0e03182e","line":593,"range":{"start_line":593,"start_character":2,"end_line":593,"end_character":13},"in_reply_to":"76335642_5c44f63a","updated":"2026-11-11 22:10:40.000000000","message":"ack, yeah, we can comment that in the code,","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":603,"context_line":""},{"line_number":604,"context_line":"None. The new parameters are strategy input parameters, validated by the"},{"line_number":605,"context_line":"existing strategy JSON schema mechanism and exposed through the existing"},{"line_number":606,"context_line":"audit template and audit APIs."},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"Security Impact"},{"line_number":609,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"f9346629_f93423a3","line":606,"updated":"2026-11-10 19:54:37.000000000","message":"technially adding the parmater to a strage is an api change\n\nwe are just not currenly versioning stragey parmaters\n\neventuly we likely will need to do that.\n\nwe can never removed allowed parmters without that meaning the new deprecated parmater can never be remvoed today bcuase we agreed backward compatible chagnes only meaning an existing auit with those parmaters must continue to work aproximatly forever.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":603,"context_line":""},{"line_number":604,"context_line":"None. The new parameters are strategy input parameters, validated by the"},{"line_number":605,"context_line":"existing strategy JSON schema mechanism and exposed through the existing"},{"line_number":606,"context_line":"audit template and audit APIs."},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"Security Impact"},{"line_number":609,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"982a3e66_08e7d9bb","line":606,"in_reply_to":"f9346629_f93423a3","updated":"2026-11-11 22:10:40.000000000","message":"Acknowledged, changing a bit this part.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":624,"context_line":"------------------"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"* One additional Nova ``get_service_list()`` call per compute model build for"},{"line_number":627,"context_line":"  deployments that do not already use AZ scoping."},{"line_number":628,"context_line":"* Volume selection becomes global rather than pool-anchored when a type-only"},{"line_number":629,"context_line":"  entry is used, so it scans every volume in the storage model instead of"},{"line_number":630,"context_line":"  stopping at the named pools."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ccae573b_8a25dd67","line":627,"updated":"2026-11-10 19:54:37.000000000","message":"we may also need to consdier doing a instance show whenever we resivce an instnace update notificion to get the az pining info and or fully update the current vm sate.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":true,"context_lines":[{"line_number":624,"context_line":"------------------"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"* One additional Nova ``get_service_list()`` call per compute model build for"},{"line_number":627,"context_line":"  deployments that do not already use AZ scoping."},{"line_number":628,"context_line":"* Volume selection becomes global rather than pool-anchored when a type-only"},{"line_number":629,"context_line":"  entry is used, so it scans every volume in the storage model instead of"},{"line_number":630,"context_line":"  stopping at the named pools."}],"source_content_type":"text/x-rst","patch_set":6,"id":"49c2ef9b_d5c9e15e","line":627,"in_reply_to":"ccae573b_8a25dd67","updated":"2026-11-11 22:10:40.000000000","message":"right, we can do that as an additional op, which would update the other attributes too. I may treat this as a isolated patch in the end.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":635,"context_line":"Other Deployer Impact"},{"line_number":636,"context_line":"---------------------"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"* ``CONF.nova.api_version`` must be raised to at least ``2.105`` for the"},{"line_number":639,"context_line":"  AZ destination. An audit that uses a zone pair without meeting the"},{"line_number":640,"context_line":"  minimum version fails with an explicit message rather than silently"},{"line_number":641,"context_line":"  migrating without an AZ constraint."},{"line_number":642,"context_line":"* ``CONF.nova.api_version`` must also be at least ``2.104``, the unpin"},{"line_number":643,"context_line":"  microversion, whenever an entry keeps pinned instances, which is the"},{"line_number":644,"context_line":"  default."}],"source_content_type":"text/x-rst","patch_set":6,"id":"dbda1b7d_b8d90d57","line":641,"range":{"start_line":638,"start_character":0,"end_line":641,"end_character":37},"updated":"2026-11-10 19:54:37.000000000","message":"so as part fo this work we shoudl not be using the configf option to set the microversion we use to talk to nova\n\nthis can set the max version but it would be incorrect to have this rasise the min verison\n\n\nwe have dicuss that in the past that a client of an api that supprot micoversion is expected to pass a diffent microverion per api endpoint.\n\nwe shoudl make sure wehn we add code that passes the az it expicltly passes 2.10x\n\nbut use the older microverson when az is not passed.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":635,"context_line":"Other Deployer Impact"},{"line_number":636,"context_line":"---------------------"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"* ``CONF.nova.api_version`` must be raised to at least ``2.105`` for the"},{"line_number":639,"context_line":"  AZ destination. An audit that uses a zone pair without meeting the"},{"line_number":640,"context_line":"  minimum version fails with an explicit message rather than silently"},{"line_number":641,"context_line":"  migrating without an AZ constraint."},{"line_number":642,"context_line":"* ``CONF.nova.api_version`` must also be at least ``2.104``, the unpin"},{"line_number":643,"context_line":"  microversion, whenever an entry keeps pinned instances, which is the"},{"line_number":644,"context_line":"  default."}],"source_content_type":"text/x-rst","patch_set":6,"id":"12ca388d_ab7d3039","line":641,"range":{"start_line":638,"start_character":0,"end_line":641,"end_character":37},"in_reply_to":"dbda1b7d_b8d90d57","updated":"2026-11-11 22:10:40.000000000","message":"ack, I can see what needs to be done around that.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":639,"context_line":"  AZ destination. An audit that uses a zone pair without meeting the"},{"line_number":640,"context_line":"  minimum version fails with an explicit message rather than silently"},{"line_number":641,"context_line":"  migrating without an AZ constraint."},{"line_number":642,"context_line":"* ``CONF.nova.api_version`` must also be at least ``2.104``, the unpin"},{"line_number":643,"context_line":"  microversion, whenever an entry keeps pinned instances, which is the"},{"line_number":644,"context_line":"  default."},{"line_number":645,"context_line":"* ``[compute_model] enable_extended_attributes`` changes its default from"}],"source_content_type":"text/x-rst","patch_set":6,"id":"377b66ca_1b4bfa0b","line":642,"range":{"start_line":642,"start_character":0,"end_line":642,"end_character":70},"updated":"2026-11-10 19:54:37.000000000","message":"really we shoudl be removing this config option sooner ratehr then later but yes. 2.104 added pin and unpine via the server update api.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":true,"context_lines":[{"line_number":639,"context_line":"  AZ destination. An audit that uses a zone pair without meeting the"},{"line_number":640,"context_line":"  minimum version fails with an explicit message rather than silently"},{"line_number":641,"context_line":"  migrating without an AZ constraint."},{"line_number":642,"context_line":"* ``CONF.nova.api_version`` must also be at least ``2.104``, the unpin"},{"line_number":643,"context_line":"  microversion, whenever an entry keeps pinned instances, which is the"},{"line_number":644,"context_line":"  default."},{"line_number":645,"context_line":"* ``[compute_model] enable_extended_attributes`` changes its default from"}],"source_content_type":"text/x-rst","patch_set":6,"id":"e11900dd_50b20158","line":642,"range":{"start_line":642,"start_character":0,"end_line":642,"end_character":70},"in_reply_to":"377b66ca_1b4bfa0b","updated":"2026-11-11 22:10:40.000000000","message":"yes, doesn\u0027t make too much sense keep this. So we should read the max supported version for nova, but we may need to cache it, to avoid calls inside strategies? Or maybe agreed that we could call nova api once in pre-execute and cache it?","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":640,"context_line":"  minimum version fails with an explicit message rather than silently"},{"line_number":641,"context_line":"  migrating without an AZ constraint."},{"line_number":642,"context_line":"* ``CONF.nova.api_version`` must also be at least ``2.104``, the unpin"},{"line_number":643,"context_line":"  microversion, whenever an entry keeps pinned instances, which is the"},{"line_number":644,"context_line":"  default."},{"line_number":645,"context_line":"* ``[compute_model] enable_extended_attributes`` changes its default from"},{"line_number":646,"context_line":"  ``false`` to ``true``, so deployments that never set it explicitly begin"},{"line_number":647,"context_line":"  collecting extended attributes, including ``pinned_availability_zone``."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1d8fac35_0f45fd16","line":644,"range":{"start_line":643,"start_character":17,"end_line":644,"end_character":10},"updated":"2026-11-10 19:54:37.000000000","message":"this is the microversion used to pin and unpine form an az the collection fo the pinign in uses 2.96\n\nyou only need 2.104 if you execute an audit that prodces a migration that would move the instnace across az and its is currently pinned.\n\nif operators do not use this feature they do not need to set this config opiton\n\n\n\"which is the default\" is kidn of confusing ans it snto clear what that is refering to\n\ni think you mena the default behvior woudl eb to unpin the instnace but you have not said that in this section","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":640,"context_line":"  minimum version fails with an explicit message rather than silently"},{"line_number":641,"context_line":"  migrating without an AZ constraint."},{"line_number":642,"context_line":"* ``CONF.nova.api_version`` must also be at least ``2.104``, the unpin"},{"line_number":643,"context_line":"  microversion, whenever an entry keeps pinned instances, which is the"},{"line_number":644,"context_line":"  default."},{"line_number":645,"context_line":"* ``[compute_model] enable_extended_attributes`` changes its default from"},{"line_number":646,"context_line":"  ``false`` to ``true``, so deployments that never set it explicitly begin"},{"line_number":647,"context_line":"  collecting extended attributes, including ``pinned_availability_zone``."}],"source_content_type":"text/x-rst","patch_set":6,"id":"c679365f_b7a348e5","line":644,"range":{"start_line":643,"start_character":17,"end_line":644,"end_character":10},"in_reply_to":"1d8fac35_0f45fd16","updated":"2026-11-11 22:10:40.000000000","message":"Ack, yeah, include pinned instances was the default, and it is not anymore. Updating the sentence to be more specific.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":645,"context_line":"* ``[compute_model] enable_extended_attributes`` changes its default from"},{"line_number":646,"context_line":"  ``false`` to ``true``, so deployments that never set it explicitly begin"},{"line_number":647,"context_line":"  collecting extended attributes, including ``pinned_availability_zone``."},{"line_number":648,"context_line":"  Reading ``pinned_availability_zone`` needs ``2.96``. An operator who"},{"line_number":649,"context_line":"  does not drain zones can set the option back to ``false``, at the cost of"},{"line_number":650,"context_line":"  ``skip_az_pinned_instances`` no longer having a pin to read."},{"line_number":651,"context_line":"* AZ drain is not defined for compute nodes whose driver cannot perform the"},{"line_number":652,"context_line":"  move, Ironic in particular. Exclude them with the audit scope."},{"line_number":653,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f6afada_d73a5ca6","line":650,"range":{"start_line":648,"start_character":55,"end_line":650,"end_character":62},"updated":"2026-11-10 19:54:37.000000000","message":"i dont hthink we can allow that.\n\nas noted above this si a corectness issue.\n\nwe need to have this information for this stragy to work and we likely shoudl be fixign other stragies with az awareness over time\n\n\nfor example the workload stabilization stragey should evernaly gain awareness such that it does nto apptemet to move instance across az, later it can gain that support for unpinned instance. it probably should never do it for pinned instances.\n\nim expecting that we will start adressing this technial debt as part fo the filtering proposals that are bing advanced serpatly in other specs.\n\nbut directionaly we shoudl eb moveign to a worl wehre watcher never knowingly generate a action plan that is invalide, and in genreal its not safe to change the az of an instnace that means watcher need to everntally never generate a action plan that woudl reqruie un pinning a pinned instnace and respect az in the other strages.\n\nthat somewhat out of scope but the imporant point is i dont think we shoudl allow thise stragy to be used with a souce or destiation AZ if the nova si too old or the pinned_availability_zone info is not collected.\n\nwe are not ment ot have config driver api behvoe and skip_az_pinned_instances behvior dependign on  ``CONF.nova.api_version`` would violate that\n\nwe shoudl eb returnign a  409 conflict or failing the audit because the minime requirements are not met","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":true,"context_lines":[{"line_number":645,"context_line":"* ``[compute_model] enable_extended_attributes`` changes its default from"},{"line_number":646,"context_line":"  ``false`` to ``true``, so deployments that never set it explicitly begin"},{"line_number":647,"context_line":"  collecting extended attributes, including ``pinned_availability_zone``."},{"line_number":648,"context_line":"  Reading ``pinned_availability_zone`` needs ``2.96``. An operator who"},{"line_number":649,"context_line":"  does not drain zones can set the option back to ``false``, at the cost of"},{"line_number":650,"context_line":"  ``skip_az_pinned_instances`` no longer having a pin to read."},{"line_number":651,"context_line":"* AZ drain is not defined for compute nodes whose driver cannot perform the"},{"line_number":652,"context_line":"  move, Ironic in particular. Exclude them with the audit scope."},{"line_number":653,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"b2953bf0_a630760f","line":650,"range":{"start_line":648,"start_character":55,"end_line":650,"end_character":62},"in_reply_to":"9f6afada_d73a5ca6","updated":"2026-11-11 22:10:40.000000000","message":"yeah, agree. We can check if configuration is invalid instead of producing an invalid action plane, that is likely to fail.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83c82df5742a480e4725376eeab4faa88803aca9","unresolved":true,"context_lines":[{"line_number":658,"context_line":""},{"line_number":659,"context_line":"Upgrade Impact"},{"line_number":660,"context_line":"--------------"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"Extending ``zone_migration`` changes its ``parameters_spec``, which"},{"line_number":663,"context_line":"soft-deletes and recreates the strategy during sync and cancels ongoing audits"},{"line_number":664,"context_line":"and action plans that reference it. Operators should let in-flight"},{"line_number":665,"context_line":"``zone_migration`` plans finish before upgrading. Existing audit templates"},{"line_number":666,"context_line":"using the original node-pair and pool-pair entry forms remain valid."},{"line_number":667,"context_line":""},{"line_number":668,"context_line":"Flipping the ``[compute_model] enable_extended_attributes`` default to"},{"line_number":669,"context_line":"``true`` changes behaviour on upgrade for deployments that never set the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5cb68529_be428433","line":666,"range":{"start_line":661,"start_character":0,"end_line":666,"end_character":68},"updated":"2026-11-10 19:54:37.000000000","message":"so we said we cant really proceed with this feature until we fix that\n\nthat was the trade off between extendign the existing stragy vs a new one\n\nbecause we have choseen to extend this feature will be blocked form mergin until \n\nhttps://review.opendev.org/c/openstack/watcher-specs/+/1012696\nis completed.\n\nthat need to be relrefted as a hard depency in this spec.","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"64bb256883bcc17232c7cdceb461ee6e492381b4","unresolved":false,"context_lines":[{"line_number":658,"context_line":""},{"line_number":659,"context_line":"Upgrade Impact"},{"line_number":660,"context_line":"--------------"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"Extending ``zone_migration`` changes its ``parameters_spec``, which"},{"line_number":663,"context_line":"soft-deletes and recreates the strategy during sync and cancels ongoing audits"},{"line_number":664,"context_line":"and action plans that reference it. Operators should let in-flight"},{"line_number":665,"context_line":"``zone_migration`` plans finish before upgrading. Existing audit templates"},{"line_number":666,"context_line":"using the original node-pair and pool-pair entry forms remain valid."},{"line_number":667,"context_line":""},{"line_number":668,"context_line":"Flipping the ``[compute_model] enable_extended_attributes`` default to"},{"line_number":669,"context_line":"``true`` changes behaviour on upgrade for deployments that never set the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"4bfed914_547c58f3","line":666,"range":{"start_line":661,"start_character":0,"end_line":666,"end_character":68},"in_reply_to":"5cb68529_be428433","updated":"2026-11-11 22:10:40.000000000","message":"Done","commit_id":"369fab8c82e552be74ec32a2a10586e135f254da"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"08f84cdb1e81d7e7c6fc0c36b8291033d574235b","unresolved":false,"context_lines":[{"line_number":184,"context_line":"      ]"},{"line_number":185,"context_line":"    }"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"``compute_nodes``"},{"line_number":188,"context_line":"  Each entry is either a ``node pair``, ``{src_node, dst_node}`` with"},{"line_number":189,"context_line":"  ``dst_node`` optional, or a ``zone pair``, ``{src_az, dst_az}`` with both"},{"line_number":190,"context_line":"  required. An entry mixing keys from both kinds is rejected, but a single"}],"source_content_type":"text/x-rst","patch_set":7,"id":"561fcc68_f34691fc","line":187,"updated":"2026-11-11 22:28:20.000000000","message":"The Input Schema section, which normatively defines the request schema, documents the compute_nodes entry keys (node pair / zone pair, include_az_pinned_instances, disable_source_services) but never defines availability_zone_pinning_policy as an accepted per-entry strategy parameter: neither its placement, its default, nor its accepted values appear in that section, and the section also never states which entry kinds (node pair, zone pair) accept each of the three new options.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: A developer implementing the strategy parameters_spec from the Input Schema section can omit availability_zone_pinning_policy, implement it as a top-level strategy parameter instead of per-entry, or reject node-pair entries carrying the new options. A top-level implementation would make draining two zones under different pin policies (a stated requirement, lines 134-136) impossible, and a missing schema key makes valid audits fail HTTP 400 validation.\n\n**Suggestion**:\nIn the Input Schema section, add availability_zone_pinning_policy to the compute_nodes entry definition (string, default relocate_pin, accepted values relocate_pin / always_pin / unpin_only, see AZ Pinning Policy), and state explicitly for each new option (include_az_pinned_instances, disable_source_services, availability_zone_pinning_policy) that it is accepted on both node-pair and zone-pair entries.","commit_id":"1c986b45723dbafe1fe8a34b518c97474ebf11ad"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f2898912de2e3adfca1f5bda217ccd7e23c8affd","unresolved":false,"context_lines":[{"line_number":184,"context_line":"      ]"},{"line_number":185,"context_line":"    }"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"``compute_nodes``"},{"line_number":188,"context_line":"  Each entry is either a ``node pair``, ``{src_node, dst_node}`` with"},{"line_number":189,"context_line":"  ``dst_node`` optional, or a ``zone pair``, ``{src_az, dst_az}`` with both"},{"line_number":190,"context_line":"  required. An entry mixing keys from both kinds is rejected, but a single"}],"source_content_type":"text/x-rst","patch_set":7,"id":"2106a848_5d23cbc5","line":187,"in_reply_to":"1cf08f7e_83f03483","updated":"2026-11-17 15:29:48.000000000","message":"Done","commit_id":"1c986b45723dbafe1fe8a34b518c97474ebf11ad"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"640ffe78a42633ea04a5f06763624247b34d911f","unresolved":true,"context_lines":[{"line_number":184,"context_line":"      ]"},{"line_number":185,"context_line":"    }"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"``compute_nodes``"},{"line_number":188,"context_line":"  Each entry is either a ``node pair``, ``{src_node, dst_node}`` with"},{"line_number":189,"context_line":"  ``dst_node`` optional, or a ``zone pair``, ``{src_az, dst_az}`` with both"},{"line_number":190,"context_line":"  required. An entry mixing keys from both kinds is rejected, but a single"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1cf08f7e_83f03483","line":187,"in_reply_to":"561fcc68_f34691fc","updated":"2026-11-11 23:57:42.000000000","message":"True, I can add the pinning policy here.","commit_id":"1c986b45723dbafe1fe8a34b518c97474ebf11ad"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"08f84cdb1e81d7e7c6fc0c36b8291033d574235b","unresolved":false,"context_lines":[{"line_number":441,"context_line":"migration error. There is no revert for a pin that was successfully set to"},{"line_number":442,"context_line":"the destination zone after a completed migration."},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"``availability_zone_pinning_policy`` is a parameter of the ``Migrate``"},{"line_number":445,"context_line":"action with ``relocate_pin`` as default, so actions built by any other"},{"line_number":446,"context_line":"strategy are unaffected unless they set it explicitly. ``zone_migration``"},{"line_number":447,"context_line":"passes its own ``availability_zone_pinning_policy`` through to every"}],"source_content_type":"text/x-rst","patch_set":7,"id":"69caa30c_49f6c58f","line":444,"updated":"2026-11-11 22:28:20.000000000","message":"The spec makes relocate_pin the default of the new Migrate action parameter availability_zone_pinning_policy and simultaneously claims this leaves actions built by any other strategy unaffected. Under the accepted-values definition, relocate_pin unpins pinned instances before the migration and re-pins them to the destination zone afterwards, which is not a no-op for existing migrate actions that carry destination_node or no destination at all, unless pin management is explicitly gated on destination_az being present. The spec never states that gate.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: If implemented literally, every migrate action Watcher emits (any strategy using the Migrate action) would unpin and re-pin AZ-pinned instances during ordinary migrations, silently changing placement-constraint behavior across all strategies. If instead implementers infer a gate, its exact condition (destination_az present vs destination of any kind) is left to guesswork and could differ from the intent that non-AZ migrations preserve pins.\n\n**Suggestion**:\nState explicitly that the pin-management steps apply only when the action carries destination_az (and define the behavior for destination_node-only or destinationless actions), so the relocate_pin default is inert for actions without an AZ destination and the unaffected claim in lines 444-446 holds.","commit_id":"1c986b45723dbafe1fe8a34b518c97474ebf11ad"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"603821cec00cbf1b6cd3751637b3f1d7223369a7","unresolved":false,"context_lines":[{"line_number":360,"context_line":"``host_maintenance`` already uses::"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    {\u0027state\u0027: \u0027disabled\u0027,"},{"line_number":363,"context_line":"     \u0027disabled_reason\u0027: \u0027watcher_maintenance\u0027,"},{"line_number":364,"context_line":"     \u0027resource_name\u0027: node.hostname}"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"Disabling first is the point: it stops the scheduler refilling a node"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1e72b5ab_4a8748b4","line":363,"updated":"2026-11-12 13:18:32.000000000","message":"The spec says the emitted change_nova_service_state actions use \u0027the same parameters host_maintenance already uses\u0027, but its example literal is \u0027watcher_maintenance\u0027 while the value host_maintenance actually uses is REASON_FOR_MAINTAINING \u003d \u0027watcher_maintaining\u0027. The spec itself plans to share that constant (renamed MAINTENANCE_REASON, spec lines 376-378), so the example contradicts both the current code and the spec\u0027s own sharing design.\n\n**Severity**: SUGGESTION | **Confidence**: 0.92\n\n**Impact**: A follow-on implementation that copies the literal instead of the shared constant would leave drain-disabled nodes with a disabled_reason that host_maintenance does not recognize, changing that strategy\u0027s node filtering (line 331) and confusing operators who key automation or re-enable decisions on the reason string.\n\n**Recommendation**:\nCorrect the example to \u0027watcher_maintaining\u0027 (the current REASON_FOR_MAINTAINING value) and note the action derives the reason from the shared MAINTENANCE_REASON constant after the rename, so the spec matches the code it claims to reuse.","commit_id":"d4ba36336a48983470f8421f703b26844c91eed4"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"2720a7f69b448970e8c7773a84c5333d2263fdcb","unresolved":true,"context_lines":[{"line_number":420,"context_line":"migration. The strategy carries the same parameter and passes it through to"},{"line_number":421,"context_line":"each ``migrate`` action it emits. The accepted values are:"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"``skip_conflicting`` *(default)*"},{"line_number":424,"context_line":"  Instances whose ``pinned_availability_zone`` conflicts with the destination"},{"line_number":425,"context_line":"  zone are skipped during action\u0027s pre-execution phase. This prevents migration"},{"line_number":426,"context_line":"  of pinned instances that were select as unpinned from a stale model. Unpinned"}],"source_content_type":"text/x-rst","patch_set":8,"id":"335e1948_f26feca1","line":423,"range":{"start_line":423,"start_character":2,"end_line":423,"end_character":18},"updated":"2026-11-12 14:45:33.000000000","message":"This would be the most similar behavior from today\u0027s Migrate. The difference is that, when we migrate a a pinned instance to a host in another AZ, we don\u0027t check anything and that will end with a failure. This one is proposing to not unpin and pin, but to skip them. Make sense?","commit_id":"d4ba36336a48983470f8421f703b26844c91eed4"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"2a53ab0a3b905f029e71e45f70b79e233cf72e1a","unresolved":true,"context_lines":[{"line_number":420,"context_line":"migration. The strategy carries the same parameter and passes it through to"},{"line_number":421,"context_line":"each ``migrate`` action it emits. The accepted values are:"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"``skip_conflicting`` *(default)*"},{"line_number":424,"context_line":"  Instances whose ``pinned_availability_zone`` conflicts with the destination"},{"line_number":425,"context_line":"  zone are skipped during action\u0027s pre-execution phase. This prevents migration"},{"line_number":426,"context_line":"  of pinned instances that were select as unpinned from a stale model. Unpinned"}],"source_content_type":"text/x-rst","patch_set":8,"id":"355281ce_d2e992cb","line":423,"range":{"start_line":423,"start_character":2,"end_line":423,"end_character":18},"in_reply_to":"0fb66eb6_94d821fb","updated":"2026-11-13 16:12:29.000000000","message":"\u003e But my idea is to have avilability_zone_pinning_policy \u003d [relocate_pin(default), always_pin, unpin_only], where policy only applies when user also defines include_az_pinned_instances\u003dTrue. While Migrate option would allow us to have the skip_conflicting additional policy, as the default behavior. \n\nJust note there may be cases where a policy may be desired in a case of include_az_pinned_instances\u003dFalse. i.e. a user with AZ1 creates a new AZ2 and wants to move all unpinned vms running in AZ1 to AZ2 and pinned there to make sure they are not moved back to AZ1. It\u0027s probably not a usual scenario but i think it\u0027s fine to support it.\n\nother than that, ltgm\n\n\u003e We can, based on your suggestion, include also a always_skip_pinned policy for the Migrate Action, instead of adding a new paramter?\n\nI\u0027m not following that. What\u0027d be the use case for that? if `include_az_pinned_instances: False`, the strategy should simply not create actions for pinned instances. We shouldn\u0027t need any config option for that, I\u0027d say.\n\n\u003e The stale model is just one scenario, but the same can happen between the time that a AP was created and when it is executed.\n\nActually, that\u0027s another stale model case that may be managed by comparing the vallue of pinned_az in pre_condition().\n\n\u003e The pin_destination_az that you mentioned does not cover the option to only unpin, which can be useful for users. Taking the example of having instances that were originally pinned to a default AZ and users don\u0027t want to pin anymore.\nI think that never is actually similar to the unpin_only. Never pin to a destination doesn\u0027t really mean that we will be allowed to unpin? Depending how we doc. In the end they are similar IMO :) \n\nfor me, if a user says `include_az_pinned_instances\u003dTrue` that implies that it is allowed to unpin whatever the policy for pinning is. Actually, that\u0027s my point with this config options, the user should care *only* about what\u0027s the desired behavior, \"i want all my instances in AZ1, including the pinned ones, to be moved to AZ2 and get the [pinned|unpinned|relocated]\". IMO, asking the user to also set a \"policy\" to allow to unpin once that he has specified `include_az_pinned_instances\u003dTrue` it\u0027s unneeded and just an internal implementation detail that the user should need to config. So, yes, for me  `pin_destination_az\u003dnever` would be similar to `avilability_zone_pinning_policy\u003dunpin_only` (but in a more clear language) :)","commit_id":"d4ba36336a48983470f8421f703b26844c91eed4"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"164133e18634fcb470a05a520c60f0f788d624a0","unresolved":true,"context_lines":[{"line_number":420,"context_line":"migration. The strategy carries the same parameter and passes it through to"},{"line_number":421,"context_line":"each ``migrate`` action it emits. The accepted values are:"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"``skip_conflicting`` *(default)*"},{"line_number":424,"context_line":"  Instances whose ``pinned_availability_zone`` conflicts with the destination"},{"line_number":425,"context_line":"  zone are skipped during action\u0027s pre-execution phase. This prevents migration"},{"line_number":426,"context_line":"  of pinned instances that were select as unpinned from a stale model. Unpinned"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fd5e3af7_d8832c00","line":423,"range":{"start_line":423,"start_character":2,"end_line":423,"end_character":18},"in_reply_to":"335e1948_f26feca1","updated":"2026-11-13 12:32:44.000000000","message":"I think the action must support these four behaviors. From the Action perspective, making the default to skip (instead of fail) a pinned instance to a different AZ seems safe to me as default value for backwards compatibility for other strategies. For the other options, unpin_only, relocate_pin and always_pin, sounds good to me as options required for the feature in this spec, and potentially for others in future.\n\nHowever, I see the manage of the stale model as a different topic and orthogonal to the policy behavior. if we want to explicitly manage the stale model case, i\u0027d propose a similar approach to how we do it for source_host. Pass the pinned_az from the strategy (optionally) and check if it matches the current value, otherwise, skip the action. That\u0027s what we do with source_host. Actually, we may want to skip stale-model cases where we need to set a different policy. Let\u0027s say we want to run an audit with ```source_az: az1, destination_az: az2, include_az_pinned_instances: false, availability_zone_pinning_policy: always```. In that case we want to set a particular policy but we still should skip an instance which has been pinned after the AP was created.\n\nMy other doubt is about how to handle the `availability_zone_pinning_policy` option in the strategy. imo, the best default for the strategy case would probably be `relocate` at least when the `include_az_pinned_instances\u003dTrue` (actually, for the case of `include_az_pinned_instances\u003dFalse`, `relocate` should not make any difference to `skip_conflicting` or `unpin_only`). I think users should not need to known the details of the action parameters (which is internal contract and may change to cover cases for other strategies), and the behaviour of the strategy would be more clear with its own parameter `pin_destination_az` with options `never`, `relocate (default)` and `always` that the strategy would explicitely map to the right value of the availability_zone_pinning_policy in the action.","commit_id":"d4ba36336a48983470f8421f703b26844c91eed4"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f2898912de2e3adfca1f5bda217ccd7e23c8affd","unresolved":false,"context_lines":[{"line_number":420,"context_line":"migration. The strategy carries the same parameter and passes it through to"},{"line_number":421,"context_line":"each ``migrate`` action it emits. The accepted values are:"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"``skip_conflicting`` *(default)*"},{"line_number":424,"context_line":"  Instances whose ``pinned_availability_zone`` conflicts with the destination"},{"line_number":425,"context_line":"  zone are skipped during action\u0027s pre-execution phase. This prevents migration"},{"line_number":426,"context_line":"  of pinned instances that were select as unpinned from a stale model. Unpinned"}],"source_content_type":"text/x-rst","patch_set":8,"id":"6c09c5c1_b0aeba02","line":423,"range":{"start_line":423,"start_character":2,"end_line":423,"end_character":18},"in_reply_to":"335e1948_f26feca1","updated":"2026-11-17 15:29:48.000000000","message":"Rename to None, the default.","commit_id":"d4ba36336a48983470f8421f703b26844c91eed4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c3e5a2abea0f0573fbc56e42eef67d4e554a4023","unresolved":true,"context_lines":[{"line_number":420,"context_line":"migration. The strategy carries the same parameter and passes it through to"},{"line_number":421,"context_line":"each ``migrate`` action it emits. The accepted values are:"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"``skip_conflicting`` *(default)*"},{"line_number":424,"context_line":"  Instances whose ``pinned_availability_zone`` conflicts with the destination"},{"line_number":425,"context_line":"  zone are skipped during action\u0027s pre-execution phase. This prevents migration"},{"line_number":426,"context_line":"  of pinned instances that were select as unpinned from a stale model. Unpinned"}],"source_content_type":"text/x-rst","patch_set":8,"id":"f0e352d8_1195d3a1","line":423,"range":{"start_line":423,"start_character":2,"end_line":423,"end_character":18},"in_reply_to":"355281ce_d2e992cb","updated":"2026-11-13 16:19:07.000000000","message":"your mixign up 2 thing\n\ninclude_az_pinned_instances: false measn skip vms that are pinned\ninclude_az_pinned_instances: ture request an unpin if a vm is pinned\n\n\n`availability_zone_pinning_policy` was ment to scontole the destiaotn pinnign only.\n\n\nits the policy that is applied to all moved itnsace if the migration succeeded\n\nalwasy, never and auto (pin if previously pinned)","commit_id":"d4ba36336a48983470f8421f703b26844c91eed4"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"bf14776572a132af787cdc849ee29618afbc5c98","unresolved":true,"context_lines":[{"line_number":420,"context_line":"migration. The strategy carries the same parameter and passes it through to"},{"line_number":421,"context_line":"each ``migrate`` action it emits. The accepted values are:"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"``skip_conflicting`` *(default)*"},{"line_number":424,"context_line":"  Instances whose ``pinned_availability_zone`` conflicts with the destination"},{"line_number":425,"context_line":"  zone are skipped during action\u0027s pre-execution phase. This prevents migration"},{"line_number":426,"context_line":"  of pinned instances that were select as unpinned from a stale model. Unpinned"}],"source_content_type":"text/x-rst","patch_set":8,"id":"0fb66eb6_94d821fb","line":423,"range":{"start_line":423,"start_character":2,"end_line":423,"end_character":18},"in_reply_to":"fd5e3af7_d8832c00","updated":"2026-11-13 13:07:39.000000000","message":"Yeah, I didn\u0027t properly represent the zone-migration parameter here. But my idea is to have `avilability_zone_pinning_policy \u003d [relocate_pin(default), always_pin, unpin_only]`, where policy only applies when user also defines `include_az_pinned_instances\u003dTrue`. While Migrate option would allow us to have the  `skip_conflicting` additional policy, as the default behavior. We can, based on your suggestion, include also a `always_skip_pinned` policy for the Migrate Action, instead of adding a new paramter?\n\nThe stale model is just one scenario, but the same can happen between the time that a AP was created and when it is executed.\n\nThe `pin_destination_az` that you mentioned does not cover the option to only unpin, which can be useful for users. Taking the example of having instances that were originally pinned to a default AZ and users don\u0027t want to pin anymore.\nI think that `never` is actually similar to the `unpin_only`. Never pin to a destination doesn\u0027t really mean that we will be allowed to unpin? Depending how we doc. In the end they are similar IMO :)","commit_id":"d4ba36336a48983470f8421f703b26844c91eed4"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"603821cec00cbf1b6cd3751637b3f1d7223369a7","unresolved":false,"context_lines":[{"line_number":423,"context_line":"``skip_conflicting`` *(default)*"},{"line_number":424,"context_line":"  Instances whose ``pinned_availability_zone`` conflicts with the destination"},{"line_number":425,"context_line":"  zone are skipped during action\u0027s pre-execution phase. This prevents migration"},{"line_number":426,"context_line":"  of pinned instances that were select as unpinned from a stale model. Unpinned"},{"line_number":427,"context_line":"  instances are migrated without touching their pin. This is the original"},{"line_number":428,"context_line":"  behavior of the ``Migrate`` action, with the addition of skipping actions"},{"line_number":429,"context_line":"  that Nova would reject and end as a failure."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fe7a7909_d3a7dc90","line":426,"updated":"2026-11-12 13:18:32.000000000","message":"Several grammar defects reduce the clarity of the permanent spec record: \u0027pinned instances that were select as unpinned\u0027 (missing \u0027ed\u0027), \u0027skipped during action\u0027s pre-execution phase\u0027 (missing \u0027the\u0027), a sentence fragment \u0027A boolean, when an entry sets ``disable_source_services`` to ``true``, the strategy emits...\u0027, and \u0027to include AZ pinned instances to the proposed solution\u0027 (wrong preposition).\n\n**Severity**: SUGGESTION | **Confidence**: 0.95\n\n**Impact**: The spec becomes the reference for implementers and reviewers; the fragment and typo force re-reading and, in the skip_conflicting paragraph, momentarily obscure whether the subject is the instance or the action.\n\n**Recommendation**:\nChange \u0027were select\u0027 to \u0027were selected\u0027, \u0027during action\u0027s\u0027 to \u0027during the action\u0027s\u0027, rewrite line 357 as \u0027When an entry sets ``disable_source_services`` to ``true``, the strategy emits...\u0027, and use \u0027instances in the proposed solution\u0027 at line 721-722.","commit_id":"d4ba36336a48983470f8421f703b26844c91eed4"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"1626b1207567f05fdeb74ca29015b44d63042020","unresolved":false,"context_lines":[{"line_number":204,"context_line":"  compute service of every source node the entry resolves to, before the"},{"line_number":205,"context_line":"  migrations. See `Disabling source services`_."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"  ``availability_zone_pinning_policy`` is a string, default"},{"line_number":208,"context_line":"  ``auto``. It controls how the instance\u0027s"},{"line_number":209,"context_line":"  ``pinned_availability_zone`` is handled during migration when a destination"},{"line_number":210,"context_line":"  is specified (either ``dst_node`` for a node pair or ``dst_az`` for a zone"}],"source_content_type":"text/x-rst","patch_set":9,"id":"77c13991_6ac49873","line":207,"updated":"2026-11-17 15:23:21.000000000","message":"The Input Schema states the strategy-level availability_zone_pinning_policy parameter defaults to \u0027auto\u0027 (lines 207-208). Three other newly-added passages state or rely on \u0027none\u0027 as the default: the AZ Pinning Policy section marks \u0027none\u0027 as (default) (line 425) and says \u0027none\u0027 is the default of the Migrate action and the behavior all strategies are expected to use by default (lines 460-462), and the worked example says that with the default availability_zone_pinning_policy (\u0027none\u0027) instance i2 would have been skipped (lines 604-605). Exactly one of these statements is wrong, and an implementer cannot tell which default to build. If \u0027auto\u0027 is implemented as the strategy default, then combined with include_az_pinned_instances defaulting to true (line 196), a plain AZ drain would unpin and re-pin every AZ-pinned instance by default - the outcome the spec itself warns operators not to assume is safe, because AZ membership is an end-user-facing API contract (lines 392-396).\n\n**Severity**: WARNING | **Confidence**: 0.95\n\n**Impact**: An implementer cannot determine the intended default for a safety-relevant parameter. Building \u0027auto\u0027 as the default silently unpins AZ-pinned instances on every plain AZ drain, contradicting the spec\u0027s own safety guidance and the \u0027behavior all other strategies are expected to use by default\u0027 statement; building \u0027none\u0027 diverges from the Input Schema. Reviewers of the future implementation get no authoritative answer from the spec.\n\n**Suggestion**:\nReconcile on one default. The worked example (604-605), the Migrate-action default (460), and the safety guidance (392-396) all point to \u0027none\u0027, so changing lines 207-208 to \u0027default ``none``\u0027 is the smallest fix. If a strategy-level default of \u0027auto\u0027 is genuinely intended, update lines 425, 460-464, and 604-605 instead, and state explicitly that zone_migration deliberately diverges from the Migrate action\u0027s \u0027none\u0027 default.","commit_id":"54d957b90d37a4f92534ecd2482049a11352bdcd"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"1626b1207567f05fdeb74ca29015b44d63042020","unresolved":false,"context_lines":[{"line_number":261,"context_line":"-------------"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"Destination resolution follows the kind of entry a source node came from. A"},{"line_number":264,"context_line":"node named directly by a node pair keeps today\u0027s behaviour: ``dst_node`` when"},{"line_number":265,"context_line":"the entry supplies one, otherwise a ``migrate`` with no destination for Nova"},{"line_number":266,"context_line":"to place."},{"line_number":267,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"78d778f0_194f127a","line":264,"updated":"2026-11-17 15:23:21.000000000","message":"The same document spells the same words two ways: \u0027behaviour\u0027 at lines 264, 281, 748, 757, and 780 versus \u0027behavior\u0027 at lines 429, 431, and 460, plus \u0027generalises\u0027 at line 638. The normative AZ Pinning Policy section consistently uses \u0027behavior\u0027 while the surrounding narrative sections use \u0027behaviour\u0027, so the inconsistency cuts across normative and descriptive text of the same feature. A single long-lived spec artifact should spell a word one way, especially since this spec mandates a documentation rewrite (lines 858-877) that would otherwise inherit the inconsistency.\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Impact**: Inconsistent spelling within one normative document reads as unfinished editing and propagates into the strategy documentation rewrite this spec requires; it also makes text search and future edits error-prone.\n\n**Recommendation**:\nNormalize to American English, matching the OpenStack documentation conventions and the normative sections already using \u0027behavior\u0027: replace \u0027behaviour\u0027 with \u0027behavior\u0027 (lines 264, 281, 748, 757, 780) and \u0027generalises\u0027 with \u0027generalizes\u0027 (line 638).","commit_id":"54d957b90d37a4f92534ecd2482049a11352bdcd"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"1626b1207567f05fdeb74ca29015b44d63042020","unresolved":false,"context_lines":[{"line_number":356,"context_line":"Disabling Source Services"},{"line_number":357,"context_line":"-------------------------"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"A boolean, when an entry sets ``disable_source_services`` to ``true``, the"},{"line_number":360,"context_line":"strategy emits one ``change_nova_service_state`` action per source node that"},{"line_number":361,"context_line":"entry resolves to, ordered before the migrations, with the same parameters"},{"line_number":362,"context_line":"``host_maintenance`` already uses::"}],"source_content_type":"text/x-rst","patch_set":9,"id":"50625915_3b390d36","line":359,"updated":"2026-11-17 15:23:21.000000000","message":"Three newly-added passages contain grammar defects that readers must work around: (1) line 359 opens the \u0027Disabling Source Services\u0027 section with \u0027A boolean, when an entry sets ``disable_source_services`` to ``true``, the strategy emits...\u0027 - the opening \u0027A boolean,\u0027 is a dangling fragment, and this sentence defines operational ordering (disable before migrate), so its first words carry weight; (2) lines 426-427 read \u0027are skipped during action\u0027s pre-execution phase\u0027, missing the article \u0027the\u0027 before \u0027action\u0027s\u0027; (3) line 719 reads \u0027whenever an operator decides to include AZ pinned instances to the proposed solution\u0027 - \u0027to\u0027 should be \u0027in\u0027.\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Impact**: Reduced clarity in normative sections that operators and implementers will follow, and the defects become part of the permanent spec history because no tooling would flag them.\n\n**Recommendation**:\nRewrite line 359 as \u0027When an entry sets ``disable_source_services`` to ``true``, the strategy emits...\u0027; insert \u0027the\u0027 at line 426 (\u0027during the action\u0027s pre-execution phase\u0027); change \u0027to\u0027 to \u0027in\u0027 at line 719.","commit_id":"54d957b90d37a4f92534ecd2482049a11352bdcd"}]}
