)]}'
{"specs/ocata/approved/watcher-versioned-objects.rst":[{"author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"change_message_id":"e153aede112cecc0e646a95b50b885ca75cb0a09","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Use Cases"},{"line_number":40,"context_line":"---------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Whenever an existing Watcher object gets modified by an upcoming blueprint"},{"line_number":43,"context_line":"trying to add a new feature, the concerned Watcher objects should see their"},{"line_number":44,"context_line":"version bumped whilst indicating the changes that occurred in order to ease"},{"line_number":45,"context_line":"retro-compatibility handling throughout the codebase."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_78bc6106","line":42,"range":{"start_line":42,"start_character":29,"end_line":42,"end_character":40},"updated":"2016-10-07 13:09:56.000000000","message":"\u0027bjects get\u0027 or ....","commit_id":"2ad10c6a0e618e369aa8ad3653d49560a082ae73"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"83c3a17f5654067280da3d127a27b3c429108536","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Use Cases"},{"line_number":40,"context_line":"---------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Whenever an existing Watcher object gets modified by an upcoming blueprint"},{"line_number":43,"context_line":"trying to add a new feature, the concerned Watcher objects should see their"},{"line_number":44,"context_line":"version bumped whilst indicating the changes that occurred in order to ease"},{"line_number":45,"context_line":"retro-compatibility handling throughout the codebase."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_b819898a","line":42,"range":{"start_line":42,"start_character":29,"end_line":42,"end_character":40},"in_reply_to":"1a95cdbc_78bc6106","updated":"2016-10-07 13:21:23.000000000","message":"Will make it plural","commit_id":"2ad10c6a0e618e369aa8ad3653d49560a082ae73"},{"author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"change_message_id":"e153aede112cecc0e646a95b50b885ca75cb0a09","unresolved":false,"context_lines":[{"line_number":40,"context_line":"---------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Whenever an existing Watcher object gets modified by an upcoming blueprint"},{"line_number":43,"context_line":"trying to add a new feature, the concerned Watcher objects should see their"},{"line_number":44,"context_line":"version bumped whilst indicating the changes that occurred in order to ease"},{"line_number":45,"context_line":"retro-compatibility handling throughout the codebase."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_d83d7590","line":43,"range":{"start_line":43,"start_character":51,"end_line":43,"end_character":75},"updated":"2016-10-07 13:09:56.000000000","message":"... \u0027object should see its\u0027","commit_id":"2ad10c6a0e618e369aa8ad3653d49560a082ae73"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"83c3a17f5654067280da3d127a27b3c429108536","unresolved":false,"context_lines":[{"line_number":40,"context_line":"---------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Whenever an existing Watcher object gets modified by an upcoming blueprint"},{"line_number":43,"context_line":"trying to add a new feature, the concerned Watcher objects should see their"},{"line_number":44,"context_line":"version bumped whilst indicating the changes that occurred in order to ease"},{"line_number":45,"context_line":"retro-compatibility handling throughout the codebase."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_b832690e","line":43,"range":{"start_line":43,"start_character":51,"end_line":43,"end_character":75},"in_reply_to":"1a95cdbc_d83d7590","updated":"2016-10-07 13:21:23.000000000","message":"I actually meant the plural since 1 feature may impact more than a single object at a time.","commit_id":"2ad10c6a0e618e369aa8ad3653d49560a082ae73"},{"author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"change_message_id":"e153aede112cecc0e646a95b50b885ca75cb0a09","unresolved":false,"context_lines":[{"line_number":60,"context_line":"in subsequent work about building versioned notifications as we will be most"},{"line_number":61,"context_line":"certainly will to notify a more complete set of information beyond the scope"},{"line_number":62,"context_line":"of any given Watcher object. This preliminary work will hence be tackled within"},{"line_number":63,"context_line":"this"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_d86495ba","line":63,"updated":"2016-10-07 13:09:56.000000000","message":"missing dot.","commit_id":"2ad10c6a0e618e369aa8ad3653d49560a082ae73"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"83c3a17f5654067280da3d127a27b3c429108536","unresolved":false,"context_lines":[{"line_number":60,"context_line":"in subsequent work about building versioned notifications as we will be most"},{"line_number":61,"context_line":"certainly will to notify a more complete set of information beyond the scope"},{"line_number":62,"context_line":"of any given Watcher object. This preliminary work will hence be tackled within"},{"line_number":63,"context_line":"this"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_98012d09","line":63,"in_reply_to":"1a95cdbc_d86495ba","updated":"2016-10-07 13:21:23.000000000","message":"Already fixed in the next PS.","commit_id":"2ad10c6a0e618e369aa8ad3653d49560a082ae73"},{"author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"change_message_id":"e153aede112cecc0e646a95b50b885ca75cb0a09","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Here below are the changes to be made:"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"- Enable database loading of ORM relationships in the case in the case of"},{"line_number":179,"context_line":"  One-to-One and One-to-Many foreign keys."},{"line_number":180,"context_line":"- Add the possibility to either eager load or not the newly added ORM"},{"line_number":181,"context_line":"  relationships for performance purposes."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_d8bc95bd","line":178,"range":{"start_line":178,"start_character":59,"end_line":178,"end_character":70},"updated":"2016-10-07 13:09:56.000000000","message":"doublon","commit_id":"2ad10c6a0e618e369aa8ad3653d49560a082ae73"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"83c3a17f5654067280da3d127a27b3c429108536","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Here below are the changes to be made:"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"- Enable database loading of ORM relationships in the case in the case of"},{"line_number":179,"context_line":"  One-to-One and One-to-Many foreign keys."},{"line_number":180,"context_line":"- Add the possibility to either eager load or not the newly added ORM"},{"line_number":181,"context_line":"  relationships for performance purposes."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_e32c469b","line":178,"range":{"start_line":178,"start_character":59,"end_line":178,"end_character":70},"in_reply_to":"1a95cdbc_d8bc95bd","updated":"2016-10-07 13:21:23.000000000","message":"Done","commit_id":"2ad10c6a0e618e369aa8ad3653d49560a082ae73"},{"author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"change_message_id":"54df631b75e6c39f1d5fac456061b2bc30c0f935","unresolved":false,"context_lines":[{"line_number":138,"context_line":"associated performance hit to areas where this eager loading is necessary."},{"line_number":139,"context_line":"Also note that this eager loading will not be recursive which means that"},{"line_number":140,"context_line":"eagerly loaded related objects will not be subject to eager loading themselves."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Other deployer impact"},{"line_number":143,"context_line":"---------------------"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_ddd24934","line":141,"updated":"2016-10-11 09:07:23.000000000","message":"Please add note about this new flag at API level. The API design will not be impacted by the flag eage. It means that object serialized data, returned into HTTP query response, will not contain \u0027eagering\u0027 data.","commit_id":"4cfbb6010818bb89853dfda84077f536ead90cb8"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"18ab64077486fd0acb0c2fe0c84733140af7c825","unresolved":false,"context_lines":[{"line_number":138,"context_line":"associated performance hit to areas where this eager loading is necessary."},{"line_number":139,"context_line":"Also note that this eager loading will not be recursive which means that"},{"line_number":140,"context_line":"eagerly loaded related objects will not be subject to eager loading themselves."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Other deployer impact"},{"line_number":143,"context_line":"---------------------"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_dde5d8a8","line":141,"in_reply_to":"fa6399be_ddd24934","updated":"2016-10-11 14:50:54.000000000","message":"Done","commit_id":"4cfbb6010818bb89853dfda84077f536ead90cb8"},{"author":{"_account_id":19214,"name":"Vincent Mahe","email":"vincent.mahe@b-com.com","username":"vmahe35"},"change_message_id":"61e04c0a357b4ca279980faa5823cef84d618f0c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"question of retro-compatibility. Other OpenStack projects already faced the"},{"line_number":15,"context_line":"problem before us and the community came up with a common answer which is"},{"line_number":16,"context_line":"object versioning."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Here below is a non-exhausting list of blueprint specifications written on the"},{"line_number":19,"context_line":"subject by other projects:"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa6399be_9db17c92","line":17,"updated":"2016-10-12 10:01:13.000000000","message":"versioning is also useful for ops when they need to analyze the reason of a bug. They can better know the current state of the database and the system at the time the bug occured.\nShouldn\u0027t we add a use case for this as well ?","commit_id":"512a8c825f35d1b7b7175316ef0b17e91f88b424"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"57323cff58d178c28b28a82fd654a8245f138714","unresolved":false,"context_lines":[{"line_number":14,"context_line":"question of retro-compatibility. Other OpenStack projects already faced the"},{"line_number":15,"context_line":"problem before us and the community came up with a common answer which is"},{"line_number":16,"context_line":"object versioning."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Here below is a non-exhausting list of blueprint specifications written on the"},{"line_number":19,"context_line":"subject by other projects:"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa6399be_0776ae05","line":17,"in_reply_to":"fa6399be_9db17c92","updated":"2016-10-13 15:33:19.000000000","message":"The object versions are not persisted. It is only present within the codebase and will also be transmitted in notification payloads.","commit_id":"512a8c825f35d1b7b7175316ef0b17e91f88b424"},{"author":{"_account_id":19214,"name":"Vincent Mahe","email":"vincent.mahe@b-com.com","username":"vmahe35"},"change_message_id":"646c02ed9e4713ed2f351ee03ca0f32aebd04ae3","unresolved":false,"context_lines":[{"line_number":15,"context_line":"problem before us and the community came up with a common answer which is"},{"line_number":16,"context_line":"object versioning."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Here below is a non-exhausting list of blueprint specifications written on the"},{"line_number":19,"context_line":"subject by other projects:"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":" - https://specs.openstack.org/openstack/oslo-specs/specs/kilo/adopt-oslo-versionedobjects.html"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa6399be_0d7d2c6e","line":18,"range":{"start_line":18,"start_character":27,"end_line":18,"end_character":30},"updated":"2016-10-12 14:18:20.000000000","message":"exhaustive","commit_id":"512a8c825f35d1b7b7175316ef0b17e91f88b424"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"57323cff58d178c28b28a82fd654a8245f138714","unresolved":false,"context_lines":[{"line_number":15,"context_line":"problem before us and the community came up with a common answer which is"},{"line_number":16,"context_line":"object versioning."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Here below is a non-exhausting list of blueprint specifications written on the"},{"line_number":19,"context_line":"subject by other projects:"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":" - https://specs.openstack.org/openstack/oslo-specs/specs/kilo/adopt-oslo-versionedobjects.html"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa6399be_4c844d5d","line":18,"range":{"start_line":18,"start_character":27,"end_line":18,"end_character":30},"in_reply_to":"fa6399be_0d7d2c6e","updated":"2016-10-13 15:33:19.000000000","message":"Done","commit_id":"512a8c825f35d1b7b7175316ef0b17e91f88b424"},{"author":{"_account_id":19214,"name":"Vincent Mahe","email":"vincent.mahe@b-com.com","username":"vmahe35"},"change_message_id":"61e04c0a357b4ca279980faa5823cef84d618f0c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"Use Cases"},{"line_number":38,"context_line":"---------"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Whenever existing Watcher objects will modified, the concerned Watcher objects"},{"line_number":41,"context_line":"should see their version bumped whilst indicating the changes that occurred in"},{"line_number":42,"context_line":"order to ease retro-compatibility handling throughout the codebase."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa6399be_1dd1ec57","line":40,"range":{"start_line":40,"start_character":39,"end_line":40,"end_character":47},"updated":"2016-10-12 10:01:13.000000000","message":"be created or modified (and even deleted, which is a special kind of modification)","commit_id":"512a8c825f35d1b7b7175316ef0b17e91f88b424"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"57323cff58d178c28b28a82fd654a8245f138714","unresolved":false,"context_lines":[{"line_number":37,"context_line":"Use Cases"},{"line_number":38,"context_line":"---------"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Whenever existing Watcher objects will modified, the concerned Watcher objects"},{"line_number":41,"context_line":"should see their version bumped whilst indicating the changes that occurred in"},{"line_number":42,"context_line":"order to ease retro-compatibility handling throughout the codebase."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa6399be_ac296939","line":40,"range":{"start_line":40,"start_character":39,"end_line":40,"end_character":47},"in_reply_to":"fa6399be_1dd1ec57","updated":"2016-10-13 15:33:19.000000000","message":"Done","commit_id":"512a8c825f35d1b7b7175316ef0b17e91f88b424"},{"author":{"_account_id":19214,"name":"Vincent Mahe","email":"vincent.mahe@b-com.com","username":"vmahe35"},"change_message_id":"61e04c0a357b4ca279980faa5823cef84d618f0c","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Besides, `oslo.versionedobjects`_ brings along many new field types, among"},{"line_number":56,"context_line":"which ``ObjectField`` can be found. This field can reveal itself useful in"},{"line_number":57,"context_line":"subsequent work about building versioned notifications as we will be most"},{"line_number":58,"context_line":"certainly be keen on to notifying a more complete set of information that would"},{"line_number":59,"context_line":"also include some data that are directly related to the given Watcher object."},{"line_number":60,"context_line":"This work will hence be tackled within this blueprint."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa6399be_3d3b109e","line":58,"range":{"start_line":57,"start_character":55,"end_line":58,"end_character":17},"updated":"2016-10-12 10:01:13.000000000","message":"something wrong in the structure of this sentence.","commit_id":"512a8c825f35d1b7b7175316ef0b17e91f88b424"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"57323cff58d178c28b28a82fd654a8245f138714","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Besides, `oslo.versionedobjects`_ brings along many new field types, among"},{"line_number":56,"context_line":"which ``ObjectField`` can be found. This field can reveal itself useful in"},{"line_number":57,"context_line":"subsequent work about building versioned notifications as we will be most"},{"line_number":58,"context_line":"certainly be keen on to notifying a more complete set of information that would"},{"line_number":59,"context_line":"also include some data that are directly related to the given Watcher object."},{"line_number":60,"context_line":"This work will hence be tackled within this blueprint."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa6399be_4c2d2dfd","line":58,"range":{"start_line":57,"start_character":55,"end_line":58,"end_character":17},"in_reply_to":"fa6399be_3d3b109e","updated":"2016-10-13 15:33:19.000000000","message":"Done","commit_id":"512a8c825f35d1b7b7175316ef0b17e91f88b424"},{"author":{"_account_id":19214,"name":"Vincent Mahe","email":"vincent.mahe@b-com.com","username":"vmahe35"},"change_message_id":"61e04c0a357b4ca279980faa5823cef84d618f0c","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"- The `AuditTemplate`_ will have two ORM relationship fields:"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  * A ``goal`` field reflecting the ``goal_id`` ForeignKey field"},{"line_number":81,"context_line":"  * A ``strategy`` field reflecting the ``strategy_id`` ForeignKey field"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"- The `Audit`_ will have two ORM relationship fields:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa6399be_dd04d4c1","line":80,"range":{"start_line":80,"start_character":4,"end_line":80,"end_character":64},"updated":"2016-10-12 10:01:13.000000000","message":"Why do we need both goal and strategy ?\nWhen we have the strategy id, can\u0027t we infer the related goal_id ?","commit_id":"512a8c825f35d1b7b7175316ef0b17e91f88b424"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"57323cff58d178c28b28a82fd654a8245f138714","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"- The `AuditTemplate`_ will have two ORM relationship fields:"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  * A ``goal`` field reflecting the ``goal_id`` ForeignKey field"},{"line_number":81,"context_line":"  * A ``strategy`` field reflecting the ``strategy_id`` ForeignKey field"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"- The `Audit`_ will have two ORM relationship fields:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa6399be_ca987d1e","line":80,"range":{"start_line":80,"start_character":4,"end_line":80,"end_character":64},"in_reply_to":"fa6399be_dd04d4c1","updated":"2016-10-13 15:33:19.000000000","message":"I agree, but the opposite is false, so because the strategy_id is optional, we cannot guarantee that we will always have the strategy_id to infer the goal, which is why we still need both fields.","commit_id":"512a8c825f35d1b7b7175316ef0b17e91f88b424"},{"author":{"_account_id":19214,"name":"Vincent Mahe","email":"vincent.mahe@b-com.com","username":"vmahe35"},"change_message_id":"61e04c0a357b4ca279980faa5823cef84d618f0c","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"- The `Audit`_ will have two ORM relationship fields:"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  * A ``goal`` field reflecting the ``goal_id`` ForeignKey field"},{"line_number":86,"context_line":"  * A ``strategy`` field reflecting the ``strategy_id`` ForeignKey field"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"- The `ActionPlan`_ will have two ORM relationship fields:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa6399be_7db828e6","line":85,"range":{"start_line":85,"start_character":4,"end_line":85,"end_character":64},"updated":"2016-10-12 10:01:13.000000000","message":"same comment as for AuditTemplate","commit_id":"512a8c825f35d1b7b7175316ef0b17e91f88b424"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"57323cff58d178c28b28a82fd654a8245f138714","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"- The `Audit`_ will have two ORM relationship fields:"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  * A ``goal`` field reflecting the ``goal_id`` ForeignKey field"},{"line_number":86,"context_line":"  * A ``strategy`` field reflecting the ``strategy_id`` ForeignKey field"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"- The `ActionPlan`_ will have two ORM relationship fields:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa6399be_2a8ad9bf","line":85,"range":{"start_line":85,"start_character":4,"end_line":85,"end_character":64},"in_reply_to":"fa6399be_7db828e6","updated":"2016-10-13 15:33:19.000000000","message":"ditto","commit_id":"512a8c825f35d1b7b7175316ef0b17e91f88b424"},{"author":{"_account_id":19214,"name":"Vincent Mahe","email":"vincent.mahe@b-com.com","username":"vmahe35"},"change_message_id":"61e04c0a357b4ca279980faa5823cef84d618f0c","unresolved":false,"context_lines":[{"line_number":137,"context_line":"Loading ``ObjectField`` data makes queries slower. This is the reason why the"},{"line_number":138,"context_line":"concept of eager loading is introduced alongside this blueprint to limit the"},{"line_number":139,"context_line":"associated performance hit to areas where this eager loading is necessary."},{"line_number":140,"context_line":"Also note that this eager loading will not be recursive which means that"},{"line_number":141,"context_line":"eagerly loaded related objects will not be subject to eager loading themselves."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa6399be_9d27bc11","line":140,"range":{"start_line":140,"start_character":46,"end_line":140,"end_character":55},"updated":"2016-10-12 10:01:13.000000000","message":"will not be \"cascaded\" ?","commit_id":"512a8c825f35d1b7b7175316ef0b17e91f88b424"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"57323cff58d178c28b28a82fd654a8245f138714","unresolved":false,"context_lines":[{"line_number":137,"context_line":"Loading ``ObjectField`` data makes queries slower. This is the reason why the"},{"line_number":138,"context_line":"concept of eager loading is introduced alongside this blueprint to limit the"},{"line_number":139,"context_line":"associated performance hit to areas where this eager loading is necessary."},{"line_number":140,"context_line":"Also note that this eager loading will not be recursive which means that"},{"line_number":141,"context_line":"eagerly loaded related objects will not be subject to eager loading themselves."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa6399be_ac0fa986","line":140,"range":{"start_line":140,"start_character":46,"end_line":140,"end_character":55},"in_reply_to":"fa6399be_9d27bc11","updated":"2016-10-13 15:33:19.000000000","message":"Done","commit_id":"512a8c825f35d1b7b7175316ef0b17e91f88b424"},{"author":{"_account_id":19214,"name":"Vincent Mahe","email":"vincent.mahe@b-com.com","username":"vmahe35"},"change_message_id":"61e04c0a357b4ca279980faa5823cef84d618f0c","unresolved":false,"context_lines":[{"line_number":143,"context_line":"Other deployer impact"},{"line_number":144,"context_line":"---------------------"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"None."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Developer impact"},{"line_number":149,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa6399be_9ddc1ce6","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":4},"updated":"2016-10-12 10:01:13.000000000","message":"Isn\u0027t there an impact on how database migration is done between 2 versions of Watcher ?","commit_id":"512a8c825f35d1b7b7175316ef0b17e91f88b424"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"57323cff58d178c28b28a82fd654a8245f138714","unresolved":false,"context_lines":[{"line_number":143,"context_line":"Other deployer impact"},{"line_number":144,"context_line":"---------------------"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"None."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Developer impact"},{"line_number":149,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa6399be_ea8381ca","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":4},"in_reply_to":"fa6399be_9ddc1ce6","updated":"2016-10-13 15:33:19.000000000","message":"At this point in time, we do not handle DB migrations so that\u0027s why I didn\u0027t mention anything about it.","commit_id":"512a8c825f35d1b7b7175316ef0b17e91f88b424"},{"author":{"_account_id":6437,"name":"Susanne Balle","email":"sleipnir012@gmail.com","username":"susanne-balle"},"change_message_id":"eaca35b93fa8c52097dd06a2db4bfe60d7e6a6ef","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/watcher/+spec/watcher-versioned-objects"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"As we are making Watcher more and more stable, we now have to tackle the"},{"line_number":14,"context_line":"question of retro-compatibility. Other OpenStack projects already faced the"},{"line_number":15,"context_line":"problem before us and the community came up with a common answer which is"},{"line_number":16,"context_line":"object versioning."}],"source_content_type":"text/x-rst","patch_set":6,"id":"fa6399be_70d96d83","line":13,"range":{"start_line":13,"start_character":30,"end_line":13,"end_character":38},"updated":"2016-10-17 18:29:57.000000000","message":"nit: I would say more stable and take out the \"more and\"","commit_id":"a7332d6c0b19cbde7a329ba578c66a66cd4af04c"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"09f3ca1514d00cfc0e163e53bf34527124338278","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/watcher/+spec/watcher-versioned-objects"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"As we are making Watcher more and more stable, we now have to tackle the"},{"line_number":14,"context_line":"question of retro-compatibility. Other OpenStack projects already faced the"},{"line_number":15,"context_line":"problem before us and the community came up with a common answer which is"},{"line_number":16,"context_line":"object versioning."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_ed3d8dbc","line":13,"range":{"start_line":13,"start_character":30,"end_line":13,"end_character":38},"in_reply_to":"fa6399be_70d96d83","updated":"2016-11-14 16:15:17.000000000","message":"Done","commit_id":"a7332d6c0b19cbde7a329ba578c66a66cd4af04c"},{"author":{"_account_id":6437,"name":"Susanne Balle","email":"sleipnir012@gmail.com","username":"susanne-balle"},"change_message_id":"eaca35b93fa8c52097dd06a2db4bfe60d7e6a6ef","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/watcher/+spec/watcher-versioned-objects"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"As we are making Watcher more and more stable, we now have to tackle the"},{"line_number":14,"context_line":"question of retro-compatibility. Other OpenStack projects already faced the"},{"line_number":15,"context_line":"problem before us and the community came up with a common answer which is"},{"line_number":16,"context_line":"object versioning."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"fa6399be_b0ba2509","line":14,"range":{"start_line":14,"start_character":72,"end_line":14,"end_character":75},"updated":"2016-10-17 18:29:57.000000000","message":"nit: change the to this","commit_id":"a7332d6c0b19cbde7a329ba578c66a66cd4af04c"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"09f3ca1514d00cfc0e163e53bf34527124338278","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/watcher/+spec/watcher-versioned-objects"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"As we are making Watcher more and more stable, we now have to tackle the"},{"line_number":14,"context_line":"question of retro-compatibility. Other OpenStack projects already faced the"},{"line_number":15,"context_line":"problem before us and the community came up with a common answer which is"},{"line_number":16,"context_line":"object versioning."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_ad72b5ab","line":14,"range":{"start_line":14,"start_character":72,"end_line":14,"end_character":75},"in_reply_to":"fa6399be_b0ba2509","updated":"2016-11-14 16:15:17.000000000","message":"Done","commit_id":"a7332d6c0b19cbde7a329ba578c66a66cd4af04c"},{"author":{"_account_id":6437,"name":"Susanne Balle","email":"sleipnir012@gmail.com","username":"susanne-balle"},"change_message_id":"eaca35b93fa8c52097dd06a2db4bfe60d7e6a6ef","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"As we are making Watcher more and more stable, we now have to tackle the"},{"line_number":14,"context_line":"question of retro-compatibility. Other OpenStack projects already faced the"},{"line_number":15,"context_line":"problem before us and the community came up with a common answer which is"},{"line_number":16,"context_line":"object versioning."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Here below is a non-exhaustive list of blueprint specifications written on the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"fa6399be_30ce15b5","line":15,"range":{"start_line":15,"start_character":8,"end_line":15,"end_character":17},"updated":"2016-10-17 18:29:57.000000000","message":"nit: I would delete \"before us\"","commit_id":"a7332d6c0b19cbde7a329ba578c66a66cd4af04c"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"09f3ca1514d00cfc0e163e53bf34527124338278","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"As we are making Watcher more and more stable, we now have to tackle the"},{"line_number":14,"context_line":"question of retro-compatibility. Other OpenStack projects already faced the"},{"line_number":15,"context_line":"problem before us and the community came up with a common answer which is"},{"line_number":16,"context_line":"object versioning."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Here below is a non-exhaustive list of blueprint specifications written on the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_6d9fbdb4","line":15,"range":{"start_line":15,"start_character":8,"end_line":15,"end_character":17},"in_reply_to":"fa6399be_30ce15b5","updated":"2016-11-14 16:15:17.000000000","message":"Done","commit_id":"a7332d6c0b19cbde7a329ba578c66a66cd4af04c"},{"author":{"_account_id":6437,"name":"Susanne Balle","email":"sleipnir012@gmail.com","username":"susanne-balle"},"change_message_id":"eaca35b93fa8c52097dd06a2db4bfe60d7e6a6ef","unresolved":false,"context_lines":[{"line_number":15,"context_line":"problem before us and the community came up with a common answer which is"},{"line_number":16,"context_line":"object versioning."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Here below is a non-exhaustive list of blueprint specifications written on the"},{"line_number":19,"context_line":"subject by other projects:"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":" - https://specs.openstack.org/openstack/oslo-specs/specs/kilo/adopt-oslo-versionedobjects.html"}],"source_content_type":"text/x-rst","patch_set":6,"id":"fa6399be_10403107","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":6},"updated":"2016-10-17 18:29:57.000000000","message":"nite Take out \"Here\" and replace with just \"Below\"","commit_id":"a7332d6c0b19cbde7a329ba578c66a66cd4af04c"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"09f3ca1514d00cfc0e163e53bf34527124338278","unresolved":false,"context_lines":[{"line_number":15,"context_line":"problem before us and the community came up with a common answer which is"},{"line_number":16,"context_line":"object versioning."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Here below is a non-exhaustive list of blueprint specifications written on the"},{"line_number":19,"context_line":"subject by other projects:"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":" - https://specs.openstack.org/openstack/oslo-specs/specs/kilo/adopt-oslo-versionedobjects.html"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_edabcdd4","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":6},"in_reply_to":"fa6399be_10403107","updated":"2016-11-14 16:15:17.000000000","message":"Done","commit_id":"a7332d6c0b19cbde7a329ba578c66a66cd4af04c"},{"author":{"_account_id":6437,"name":"Susanne Balle","email":"sleipnir012@gmail.com","username":"susanne-balle"},"change_message_id":"eaca35b93fa8c52097dd06a2db4bfe60d7e6a6ef","unresolved":false,"context_lines":[{"line_number":28,"context_line":"As of now, Watcher maintains some (but not all) building blocks previously used"},{"line_number":29,"context_line":"by other projects such as Nova in order to enable the versioning of objects."},{"line_number":30,"context_line":"As Watcher is now part of the Big Tent, we should start taking into account"},{"line_number":31,"context_line":"backwards compatibility. Moreover, we should tend towards standardization of"},{"line_number":32,"context_line":"the codebase wherever possible which hence makes the use of"},{"line_number":33,"context_line":"`oslo.versionedobjects`_ sensible."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"fa6399be_70d7adbf","line":31,"range":{"start_line":31,"start_character":45,"end_line":31,"end_character":76},"updated":"2016-10-17 18:29:57.000000000","message":"nit: I would just say: \"we should standardize the code and therefore make use of oslo.versionedobjects.","commit_id":"a7332d6c0b19cbde7a329ba578c66a66cd4af04c"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"09f3ca1514d00cfc0e163e53bf34527124338278","unresolved":false,"context_lines":[{"line_number":28,"context_line":"As of now, Watcher maintains some (but not all) building blocks previously used"},{"line_number":29,"context_line":"by other projects such as Nova in order to enable the versioning of objects."},{"line_number":30,"context_line":"As Watcher is now part of the Big Tent, we should start taking into account"},{"line_number":31,"context_line":"backwards compatibility. Moreover, we should tend towards standardization of"},{"line_number":32,"context_line":"the codebase wherever possible which hence makes the use of"},{"line_number":33,"context_line":"`oslo.versionedobjects`_ sensible."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_6d86dd66","line":31,"range":{"start_line":31,"start_character":45,"end_line":31,"end_character":76},"in_reply_to":"fa6399be_70d7adbf","updated":"2016-11-14 16:15:17.000000000","message":"Done","commit_id":"a7332d6c0b19cbde7a329ba578c66a66cd4af04c"},{"author":{"_account_id":6437,"name":"Susanne Balle","email":"sleipnir012@gmail.com","username":"susanne-balle"},"change_message_id":"eaca35b93fa8c52097dd06a2db4bfe60d7e6a6ef","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Proposed change"},{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"The focus of this blueprint is to overhaul the Watcher codebase to leverage"},{"line_number":54,"context_line":"`oslo.versionedobjects`_ library to enable the versioning of Watcher objects."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Besides, `oslo.versionedobjects`_ brings along many new field types, among"}],"source_content_type":"text/x-rst","patch_set":6,"id":"fa6399be_5001c938","line":53,"range":{"start_line":53,"start_character":34,"end_line":53,"end_character":42},"updated":"2016-10-17 18:29:57.000000000","message":"do you mean update? overhaul sounds very drastic.","commit_id":"a7332d6c0b19cbde7a329ba578c66a66cd4af04c"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"09f3ca1514d00cfc0e163e53bf34527124338278","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Proposed change"},{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"The focus of this blueprint is to overhaul the Watcher codebase to leverage"},{"line_number":54,"context_line":"`oslo.versionedobjects`_ library to enable the versioning of Watcher objects."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Besides, `oslo.versionedobjects`_ brings along many new field types, among"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_264ed196","line":53,"range":{"start_line":53,"start_character":34,"end_line":53,"end_character":42},"in_reply_to":"fa6399be_5001c938","updated":"2016-11-14 16:15:17.000000000","message":"This was actually quite a big change: https://review.openstack.org/#/q/status:merged+project:openstack/watcher+branch:master+topic:bp/watcher-versioned-objects\nwith more than a couple thousand lines of codes of refactoring","commit_id":"a7332d6c0b19cbde7a329ba578c66a66cd4af04c"},{"author":{"_account_id":11750,"name":"Antoine Cabot","email":"antoine.cabot@b-com.com","username":"antoinecabot"},"change_message_id":"2b4130978355a0c9e65ca89a31897720fbaeaba1","unresolved":false,"context_lines":[{"line_number":150,"context_line":"----------------"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"As objects are being versioned from now on, any modification of an existing"},{"line_number":153,"context_line":"Watcher should be directly translated into a version bump. Retro-compatible"},{"line_number":154,"context_line":"changes should see the minor version of the related object bumped whereas any"},{"line_number":155,"context_line":"disrupting changes should be translated by a transition to a new major version."},{"line_number":156,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"fa6399be_3785e106","line":153,"updated":"2016-10-19 09:48:22.000000000","message":"s/Watcher/Watcher object","commit_id":"a7332d6c0b19cbde7a329ba578c66a66cd4af04c"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"09f3ca1514d00cfc0e163e53bf34527124338278","unresolved":false,"context_lines":[{"line_number":150,"context_line":"----------------"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"As objects are being versioned from now on, any modification of an existing"},{"line_number":153,"context_line":"Watcher should be directly translated into a version bump. Retro-compatible"},{"line_number":154,"context_line":"changes should see the minor version of the related object bumped whereas any"},{"line_number":155,"context_line":"disrupting changes should be translated by a transition to a new major version."},{"line_number":156,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_edc02d7f","line":153,"in_reply_to":"fa6399be_3785e106","updated":"2016-11-14 16:15:17.000000000","message":"Done","commit_id":"a7332d6c0b19cbde7a329ba578c66a66cd4af04c"},{"author":{"_account_id":13227,"name":"Shaifali Agrawal","email":"agrawalshaifali09@gmail.com","username":"shaifali"},"change_message_id":"a7cf7b38bfc21d1c3c810be7625fabb8deeb17dd","unresolved":false,"context_lines":[{"line_number":28,"context_line":"As of now, Watcher maintains some (but not all) building blocks previously used"},{"line_number":29,"context_line":"by other projects such as Nova in order to enable the versioning of objects."},{"line_number":30,"context_line":"As Watcher is now part of the Big Tent, we should start taking into account"},{"line_number":31,"context_line":"backwards compatibility. Moreover, we should we should standardize the code and"},{"line_number":32,"context_line":"therefore make use of `oslo.versionedobjects`_."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. _oslo.versionedobjects: http://docs.openstack.org/developer/oslo.versionedobjects/"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a77a97e_bc4e2594","line":31,"range":{"start_line":31,"start_character":35,"end_line":31,"end_character":54},"updated":"2016-11-16 15:29:01.000000000","message":"Typo, \"we should\" got repeated twice.","commit_id":"53a7d06428f0416ae9a5b41224fd5cf79040c80a"},{"author":{"_account_id":11750,"name":"Antoine Cabot","email":"antoine.cabot@b-com.com","username":"antoinecabot"},"change_message_id":"9c9671f3e1bb7d4fbfc21f84d39c80080768dbeb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"As of now, Watcher maintains some (but not all) building blocks previously used"},{"line_number":29,"context_line":"by other projects such as Nova in order to enable the versioning of objects."},{"line_number":30,"context_line":"As Watcher is now part of the Big Tent, we should start taking into account"},{"line_number":31,"context_line":"backwards compatibility. Moreover, we should we should standardize the code and"},{"line_number":32,"context_line":"therefore make use of `oslo.versionedobjects`_."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. _oslo.versionedobjects: http://docs.openstack.org/developer/oslo.versionedobjects/"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a77a97e_a89e7f04","line":31,"range":{"start_line":31,"start_character":35,"end_line":31,"end_character":54},"in_reply_to":"7a77a97e_bc4e2594","updated":"2016-11-18 09:29:10.000000000","message":"Done","commit_id":"53a7d06428f0416ae9a5b41224fd5cf79040c80a"}]}