)]}'
{"specs/ocata/approved/audit-tag-vm-metadata.rst":[{"author":{"_account_id":19214,"name":"Vincent Mahe","email":"vincent.mahe@b-com.com","username":"vmahe35"},"change_message_id":"4ff7931a38ccf2cadb09441c516824dd2cf85ebc","unresolved":false,"context_lines":[{"line_number":23,"context_line":"critical for a large scale private cloud where there are several organizations"},{"line_number":24,"context_line":"running their applications in cloud and to mitigate any impacts due to action"},{"line_number":25,"context_line":"plan execution."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Use Cases"},{"line_number":28,"context_line":"----------"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_61c7b312","line":26,"updated":"2016-10-28 10:41:41.000000000","message":"we should maybe ask to public cloud providers using Watcher whether they are ok with tagging vms of their customers.\nWe should at least make this behavior optional and configurable in Watcher config file so that they can disable this tagging. Maybe we should add a use case about this:\nAs an admin, I should be able to disable tagging of vms by Watcher.\n\nIMHO opinion, this tagging makes more sense in the case of private cloud usage.","commit_id":"e31c797d09d66e9c0f1d9760e1326a228bb682b8"},{"author":{"_account_id":9392,"name":"Prashanth Hari","email":"hvprash@gmail.com","username":"hvprash"},"change_message_id":"c63baadcdc269e9c7d9b18835163e78f8d0e053a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"critical for a large scale private cloud where there are several organizations"},{"line_number":24,"context_line":"running their applications in cloud and to mitigate any impacts due to action"},{"line_number":25,"context_line":"plan execution."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Use Cases"},{"line_number":28,"context_line":"----------"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_701e34bc","line":26,"in_reply_to":"ba5da102_61c7b312","updated":"2016-11-17 15:54:52.000000000","message":"Agree. Will update.","commit_id":"e31c797d09d66e9c0f1d9760e1326a228bb682b8"},{"author":{"_account_id":19214,"name":"Vincent Mahe","email":"vincent.mahe@b-com.com","username":"vmahe35"},"change_message_id":"4ff7931a38ccf2cadb09441c516824dd2cf85ebc","unresolved":false,"context_lines":[{"line_number":30,"context_line":"As a tenant, I should be able to know if my virtual machine is audited by"},{"line_number":31,"context_line":"watcher and when action plan will be executed"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Project Priority"},{"line_number":36,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_c114fff6","line":33,"updated":"2016-10-28 10:41:41.000000000","message":"Maybe you should split this use case in two :\n-one related to knowing that a vm is audited\n-one related to knowing when action plan will be executed, in the case the triggering of action plan is automatic.","commit_id":"e31c797d09d66e9c0f1d9760e1326a228bb682b8"},{"author":{"_account_id":9392,"name":"Prashanth Hari","email":"hvprash@gmail.com","username":"hvprash"},"change_message_id":"c63baadcdc269e9c7d9b18835163e78f8d0e053a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"As a tenant, I should be able to know if my virtual machine is audited by"},{"line_number":31,"context_line":"watcher and when action plan will be executed"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Project Priority"},{"line_number":36,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_b390d644","line":33,"in_reply_to":"ba5da102_c114fff6","updated":"2016-11-17 15:54:52.000000000","message":"will do.","commit_id":"e31c797d09d66e9c0f1d9760e1326a228bb682b8"},{"author":{"_account_id":19214,"name":"Vincent Mahe","email":"vincent.mahe@b-com.com","username":"vmahe35"},"change_message_id":"4ff7931a38ccf2cadb09441c516824dd2cf85ebc","unresolved":false,"context_lines":[{"line_number":31,"context_line":"watcher and when action plan will be executed"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Project Priority"},{"line_number":36,"context_line":"-----------------"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_c12b1f2f","line":34,"updated":"2016-10-28 10:41:41.000000000","message":"Does it make sense also to address tagging of other types of resources (volumes, ...) ?","commit_id":"e31c797d09d66e9c0f1d9760e1326a228bb682b8"},{"author":{"_account_id":9392,"name":"Prashanth Hari","email":"hvprash@gmail.com","username":"hvprash"},"change_message_id":"c63baadcdc269e9c7d9b18835163e78f8d0e053a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"watcher and when action plan will be executed"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Project Priority"},{"line_number":36,"context_line":"-----------------"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_b305367b","line":34,"in_reply_to":"ba5da102_c12b1f2f","updated":"2016-11-17 15:54:52.000000000","message":"IMHO, for the current scope will just do computes.","commit_id":"e31c797d09d66e9c0f1d9760e1326a228bb682b8"},{"author":{"_account_id":19214,"name":"Vincent Mahe","email":"vincent.mahe@b-com.com","username":"vmahe35"},"change_message_id":"4ff7931a38ccf2cadb09441c516824dd2cf85ebc","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  \"watcher_optimizer\": {"},{"line_number":47,"context_line":"                \"audit_uuid\": \"7a8c767b-ec46-462e-9785-c87894e259ca\","},{"line_number":48,"context_line":"                \"created_at\": \"2016-10-26T09:05:42.255081\","},{"line_number":49,"context_line":"                \"action_plan_execution_time\": \"2016-10-30T09:05:42.255081\","},{"line_number":50,"context_line":"  }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_41e54f35","line":49,"range":{"start_line":49,"start_character":17,"end_line":49,"end_character":43},"updated":"2016-10-28 10:41:41.000000000","message":"Maybe we should also say in the spec. that this property is optional because not all action plans will be triggered automatically. In the case it is triggered manualy, we can not know the foreseen execution time.","commit_id":"e31c797d09d66e9c0f1d9760e1326a228bb682b8"},{"author":{"_account_id":9392,"name":"Prashanth Hari","email":"hvprash@gmail.com","username":"hvprash"},"change_message_id":"c63baadcdc269e9c7d9b18835163e78f8d0e053a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  \"watcher_optimizer\": {"},{"line_number":47,"context_line":"                \"audit_uuid\": \"7a8c767b-ec46-462e-9785-c87894e259ca\","},{"line_number":48,"context_line":"                \"created_at\": \"2016-10-26T09:05:42.255081\","},{"line_number":49,"context_line":"                \"action_plan_execution_time\": \"2016-10-30T09:05:42.255081\","},{"line_number":50,"context_line":"  }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_33604601","line":49,"range":{"start_line":49,"start_character":17,"end_line":49,"end_character":43},"in_reply_to":"ba5da102_41e54f35","updated":"2016-11-17 15:54:52.000000000","message":"During manual execution, think we should still look into the action plan execution time. If the action plan execution time is in the future and we trigger a manual action plan it should fail with an exception mesg.","commit_id":"e31c797d09d66e9c0f1d9760e1326a228bb682b8"},{"author":{"_account_id":19214,"name":"Vincent Mahe","email":"vincent.mahe@b-com.com","username":"vmahe35"},"change_message_id":"4ff7931a38ccf2cadb09441c516824dd2cf85ebc","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Performance Impact"},{"line_number":83,"context_line":"------------------"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Other deployer impact"},{"line_number":87,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_21f3fb9f","line":84,"updated":"2016-10-28 10:41:41.000000000","message":"we may say here that tagging of a high number of instances may take some time (because it is done via independent calls to the Nova APIs) and therefore the audit will seem to take longer, from the admin point of view.","commit_id":"e31c797d09d66e9c0f1d9760e1326a228bb682b8"},{"author":{"_account_id":9392,"name":"Prashanth Hari","email":"hvprash@gmail.com","username":"hvprash"},"change_message_id":"c63baadcdc269e9c7d9b18835163e78f8d0e053a","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Performance Impact"},{"line_number":83,"context_line":"------------------"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Other deployer impact"},{"line_number":87,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_932afa8e","line":84,"in_reply_to":"ba5da102_21f3fb9f","updated":"2016-11-17 15:54:52.000000000","message":"Agree","commit_id":"e31c797d09d66e9c0f1d9760e1326a228bb682b8"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"4e06333fa15577e627c9c1811ceadf5a82f69f65","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":".. _Audit: http://docs.openstack.org/developer/watcher/glossary.html#audit"},{"line_number":135,"context_line":".. _vm_metadata: http://developer.openstack.org/api-ref-compute-v2.1.html#createServerMetadata"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_47a6df53","line":135,"range":{"start_line":135,"start_character":17,"end_line":135,"end_character":94},"updated":"2016-11-10 08:13:27.000000000","message":"This link seems to be invalid.\nHow about http://developer.openstack.org/api-ref/compute/#server-metadata-servers-metadata ?","commit_id":"077005c4cf4d2b2850dbe193dc75d8c5fab46524"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"2025ca860bd07c9fe43e88d8a5776aa59c26892d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    {"},{"line_number":50,"context_line":"      \"infra-optim\": {"},{"line_number":51,"context_line":"        \"strategies\": {"},{"line_number":52,"context_line":"          \"7a8c767b-ec46-462e-9785-c87894e259ca\": {"},{"line_number":53,"context_line":"            \"created_at\": \"2016-10-26T09:05:42.255081\","},{"line_number":54,"context_line":"            \"actions\": ["},{"line_number":55,"context_line":"              {"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a3c09a3_ab6f30fa","line":52,"updated":"2017-01-18 08:09:39.000000000","message":"isn\u0027t it should be \u0027id\u0027:\u00277a8c767b-ec46-462e-9785-c87894e259ca\u0027?\nCan there be many strategies, if not then can we rename it to strategy?","commit_id":"6cfe779d2ed144ddd549228f999e9c600e9b8e7e"},{"author":{"_account_id":9392,"name":"Prashanth Hari","email":"hvprash@gmail.com","username":"hvprash"},"change_message_id":"7bca44920d181033242d5effd89aa13b7ef9eac8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    {"},{"line_number":50,"context_line":"      \"infra-optim\": {"},{"line_number":51,"context_line":"        \"strategies\": {"},{"line_number":52,"context_line":"          \"7a8c767b-ec46-462e-9785-c87894e259ca\": {"},{"line_number":53,"context_line":"            \"created_at\": \"2016-10-26T09:05:42.255081\","},{"line_number":54,"context_line":"            \"actions\": ["},{"line_number":55,"context_line":"              {"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a3905b3_e26cccd2","line":52,"in_reply_to":"7a3c09a3_ab6f30fa","updated":"2017-01-24 19:39:51.000000000","message":"Pradeep - There can be only one strategy at a time targeted to the VMs. In the next run if the strategy UUID is different then the metadata should be overwritten. If the strategy UUID matches in the next run then the \"execution_time\" will be verified to move the VM.","commit_id":"6cfe779d2ed144ddd549228f999e9c600e9b8e7e"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"b54384c40984cf298fa3b5ba33d66bcb7ea8fff2","unresolved":false,"context_lines":[{"line_number":280,"context_line":"      strategy is not deterministic?"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"* TODO: How do we intend to clean up old metadata?"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"Dependencies"},{"line_number":285,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a3c09a3_9f11ce06","line":283,"updated":"2017-01-18 09:22:50.000000000","message":"Security-wise: Should we put this information in plain text knowing that tenants will be able to access these information?","commit_id":"6cfe779d2ed144ddd549228f999e9c600e9b8e7e"},{"author":{"_account_id":9392,"name":"Prashanth Hari","email":"hvprash@gmail.com","username":"hvprash"},"change_message_id":"7bca44920d181033242d5effd89aa13b7ef9eac8","unresolved":false,"context_lines":[{"line_number":280,"context_line":"      strategy is not deterministic?"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"* TODO: How do we intend to clean up old metadata?"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"Dependencies"},{"line_number":285,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a3905b3_429200a1","line":283,"in_reply_to":"7a3c09a3_9f11ce06","updated":"2017-01-24 19:39:51.000000000","message":"Agree. We can put a plain text  to clean the VM metadata","commit_id":"6cfe779d2ed144ddd549228f999e9c600e9b8e7e"},{"author":{"_account_id":7664,"name":"Joe Cropper","email":"jwcroppe@us.ibm.com","username":"jwcroppe"},"change_message_id":"3a6fee7a4a8645751a98975b9215f9743804a9cb","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"When watcher runs audits to achieve a goal, there should be some way for the"},{"line_number":19,"context_line":"application/VM owners to know that their VMs are under audit and is flagged"},{"line_number":20,"context_line":"for action plan execution. We could store these information in VM metadata"},{"line_number":21,"context_line":"with a timestamp after which action plan will be executed. This is"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a461143_9d400f09","line":18,"range":{"start_line":18,"start_character":5,"end_line":18,"end_character":12},"updated":"2017-01-31 03:34:25.000000000","message":"Watcher","commit_id":"38b5a74a297058b099072bccfd1790d22b047f5c"},{"author":{"_account_id":7664,"name":"Joe Cropper","email":"jwcroppe@us.ibm.com","username":"jwcroppe"},"change_message_id":"3a6fee7a4a8645751a98975b9215f9743804a9cb","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"When watcher runs audits to achieve a goal, there should be some way for the"},{"line_number":19,"context_line":"application/VM owners to know that their VMs are under audit and is flagged"},{"line_number":20,"context_line":"for action plan execution. We could store these information in VM metadata"},{"line_number":21,"context_line":"with a timestamp after which action plan will be executed. This is"},{"line_number":22,"context_line":"critical for a large scale private cloud where there are several organizations"},{"line_number":23,"context_line":"running their applications in cloud and to mitigate any impacts due to action"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a461143_7d3d238e","line":20,"range":{"start_line":20,"start_character":42,"end_line":20,"end_character":47},"updated":"2017-01-31 03:34:25.000000000","message":"this","commit_id":"38b5a74a297058b099072bccfd1790d22b047f5c"},{"author":{"_account_id":22775,"name":"Prudhvi Rao Shedimbi","email":"prudhvi.rao.shedimbi@intel.com","username":"pshedimb"},"change_message_id":"67902dc0dc3ad0af83536bb4f5465b997fde53ba","unresolved":false,"context_lines":[{"line_number":21,"context_line":"with a timestamp after which action plan will be executed. This is"},{"line_number":22,"context_line":"critical for a large scale private cloud where there are several organizations"},{"line_number":23,"context_line":"running their applications in cloud and to mitigate any impacts due to action"},{"line_number":24,"context_line":"plan execution. This feature should be configurable in watcher and optional"},{"line_number":25,"context_line":"as this use case may work only in a private cloud setup."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a430d35_634a6f85","line":24,"range":{"start_line":24,"start_character":16,"end_line":24,"end_character":62},"updated":"2017-02-04 22:06:15.000000000","message":"If you want to make this configurable in watcher, you should include this part in Work Items section below.","commit_id":"38b5a74a297058b099072bccfd1790d22b047f5c"},{"author":{"_account_id":7664,"name":"Joe Cropper","email":"jwcroppe@us.ibm.com","username":"jwcroppe"},"change_message_id":"3a6fee7a4a8645751a98975b9215f9743804a9cb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Use Cases"},{"line_number":28,"context_line":"---------"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"As a tenant, I should know if my virtual machine is audited by watcher."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"As a tenant, I should know when the optimization action plan will be executed."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a461143_fd491332","line":30,"range":{"start_line":30,"start_character":63,"end_line":30,"end_character":71},"updated":"2017-01-31 03:34:25.000000000","message":"Watcher","commit_id":"38b5a74a297058b099072bccfd1790d22b047f5c"},{"author":{"_account_id":7664,"name":"Joe Cropper","email":"jwcroppe@us.ibm.com","username":"jwcroppe"},"change_message_id":"3a6fee7a4a8645751a98975b9215f9743804a9cb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"We should implement a new ``tag_instance`` action within Watcher that would"},{"line_number":44,"context_line":"add a new metatada section to the VM it targets by following the following"},{"line_number":45,"context_line":"schema:"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. code-block:: json"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a461143_dd237754","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":36},"updated":"2017-01-31 03:34:25.000000000","message":"Apologies if I overlooked it, but I assume you\u0027re keeping this within Nova\u0027s server.metadata key-value pairs?\n\nWhile I love the idea here, I think we should have this information in Watcher because:\n\n1) This could apply to any resource we optimize - e.g., VMs, volumes, networks, etc. and then it\u0027d be handled differently.\n2) We start to overload Nova with data that may be stale - e.g., what happens if Watcher tags a bunch of VMs with something and then something restarts Watcher or plans change, etc., ... do we have a reaper job that goes and cleans up all this data?\n3) Ideally you\u0027d want this to be immutable and anyone can edit the VM\u0027s metadata using those APIs.\n\nAgain, I love the concept, but I\u0027m just wondering if this is the best approach?","commit_id":"38b5a74a297058b099072bccfd1790d22b047f5c"}],"specs/pike/approved/audit-tag-vm-metadata.rst":[{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"671f27902d05c92499abfa1fbe64c0ecad5c3efe","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Audit tag in VM Metadata"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Include the URL of your launchpad blueprint:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/watcher/+spec/audit-tag-vm-metadata"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"da36d5c6_44bfa8a9","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":44},"updated":"2017-02-24 07:20:48.000000000","message":"please remove","commit_id":"ec2878d6cc194589b004bd340fc45761048b49ed"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"7d3ccb1c0654047cffa45034516efc718881e6ea","unresolved":false,"context_lines":[{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"We should implement a new ``tag_instance`` action within Watcher that would"},{"line_number":44,"context_line":"add a new metatada section to the VM it targets by following the following"},{"line_number":45,"context_line":"schema:"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. code-block:: json"}],"source_content_type":"text/x-rst","patch_set":11,"id":"da36d5c6_8a62deab","line":44,"range":{"start_line":44,"start_character":10,"end_line":44,"end_character":18},"updated":"2017-02-22 10:39:28.000000000","message":"s/metatada/metadata","commit_id":"ec2878d6cc194589b004bd340fc45761048b49ed"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"7d3ccb1c0654047cffa45034516efc718881e6ea","unresolved":false,"context_lines":[{"line_number":155,"context_line":"      }"},{"line_number":156,"context_line":"    }"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"The ``tag_instance`` action should also follow the following voluptuous schema"},{"line_number":159,"context_line":"for validating its parameters:"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":11,"id":"da36d5c6_aa45e270","line":158,"range":{"start_line":158,"start_character":61,"end_line":158,"end_character":71},"updated":"2017-02-22 10:39:28.000000000","message":"Yumen Bao proposed to replace voluptuous schema with JSONSchema validation tool here: https://review.openstack.org/#/c/425204/. What do you think about it?","commit_id":"ec2878d6cc194589b004bd340fc45761048b49ed"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"671f27902d05c92499abfa1fbe64c0ecad5c3efe","unresolved":false,"context_lines":[{"line_number":209,"context_line":"Data model impact"},{"line_number":210,"context_line":"-----------------"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"There will be changes to the cluster data model to include the VM metadata."},{"line_number":213,"context_line":""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":11,"id":"da36d5c6_44ede8b5","line":212,"range":{"start_line":212,"start_character":0,"end_line":212,"end_character":74},"updated":"2017-02-24 07:20:48.000000000","message":"why the cluster data model need to include VM metadata?","commit_id":"ec2878d6cc194589b004bd340fc45761048b49ed"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"671f27902d05c92499abfa1fbe64c0ecad5c3efe","unresolved":false,"context_lines":[{"line_number":223,"context_line":"content and use checksum to ensure it wasn\u0027t be modified. Use python"},{"line_number":224,"context_line":"cryptography and fernet key to encrypt and decrypt the metadata."},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"Also, the VM metadata should be cleaned after execution of an action plan."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"Notifications impact"},{"line_number":229,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"da36d5c6_e4709c0d","line":226,"range":{"start_line":226,"start_character":6,"end_line":226,"end_character":73},"updated":"2017-02-24 07:20:48.000000000","message":"The lifecycle of the metadata is from audit completion to actionplan being executed?","commit_id":"ec2878d6cc194589b004bd340fc45761048b49ed"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"671f27902d05c92499abfa1fbe64c0ecad5c3efe","unresolved":false,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"N/A"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":".. _Audit: http://docs.openstack.org/developer/watcher/glossary.html#audit"}],"source_content_type":"text/x-rst","patch_set":11,"id":"da36d5c6_c446387a","line":327,"range":{"start_line":327,"start_character":11,"end_line":327,"end_character":15},"updated":"2017-02-24 07:20:48.000000000","message":"https","commit_id":"ec2878d6cc194589b004bd340fc45761048b49ed"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"bd2dddf9bd9c9037e41f02062e33d8811fd1aaf4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Watcher optimizes workloads by live migrating VMs. This can be disruptive."},{"line_number":17,"context_line":"There should be a feature for tenants to opt-in/opt-out some or all of"},{"line_number":18,"context_line":"their VMs from optimization. The solution we propose is to set a VM"},{"line_number":19,"context_line":"metadata key \"Optimize\" and watcher strategies should check this key if the VM"},{"line_number":20,"context_line":"is OK for live migration. This feature should be configurable"},{"line_number":21,"context_line":"in watcher and disabled by default."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a30ddce_bde62ab2","line":19,"range":{"start_line":19,"start_character":14,"end_line":19,"end_character":22},"updated":"2017-03-08 10:59:00.000000000","message":"nit: should be lowercase","commit_id":"411be7b0d88da5fcebb3a123cb80451254a6886a"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"bd2dddf9bd9c9037e41f02062e33d8811fd1aaf4","unresolved":false,"context_lines":[{"line_number":17,"context_line":"There should be a feature for tenants to opt-in/opt-out some or all of"},{"line_number":18,"context_line":"their VMs from optimization. The solution we propose is to set a VM"},{"line_number":19,"context_line":"metadata key \"Optimize\" and watcher strategies should check this key if the VM"},{"line_number":20,"context_line":"is OK for live migration. This feature should be configurable"},{"line_number":21,"context_line":"in watcher and disabled by default."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a30ddce_e70c9096","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":5},"updated":"2017-03-08 10:59:00.000000000","message":"can you make it explicit that \"optimize\" is a flag?\n\nBTW, if it should be disabled by default, it means that this flag should be considered true by default which then means that the naming isn\u0027t so great or some sort of a global switch option is missing.\n\n  N/A \u003d\u003e optimize \u003d\u003d true\n  \"optimize\u003dtrue\" \u003d\u003e optimize \u003d\u003d true\n  \"optimize\u003dfalse\" \u003d\u003e optimize \u003d\u003d false","commit_id":"411be7b0d88da5fcebb3a123cb80451254a6886a"},{"author":{"_account_id":9392,"name":"Prashanth Hari","email":"hvprash@gmail.com","username":"hvprash"},"change_message_id":"a14a6c9469aaa1ba63f0949fb2753b5b844c7c22","unresolved":false,"context_lines":[{"line_number":17,"context_line":"There should be a feature for tenants to opt-in/opt-out some or all of"},{"line_number":18,"context_line":"their VMs from optimization. The solution we propose is to set a VM"},{"line_number":19,"context_line":"metadata key \"Optimize\" and watcher strategies should check this key if the VM"},{"line_number":20,"context_line":"is OK for live migration. This feature should be configurable"},{"line_number":21,"context_line":"in watcher and disabled by default."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a30ddce_40c98f25","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":5},"in_reply_to":"9a30ddce_e70c9096","updated":"2017-03-09 15:14:25.000000000","message":"Sorry, I should have made this more clear. \nThe config option should be something like \"check_optimize_metadata\". If \"check_optimize_metadata \u003d true\" then the strategy should lookup the \"optimize\" metadata flag in VM.\nIf \"check_optimize_metadata \u003d false\" (default option) then the strategy should not lookup the \"optimize\" metadata flag in VM.","commit_id":"411be7b0d88da5fcebb3a123cb80451254a6886a"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"bd2dddf9bd9c9037e41f02062e33d8811fd1aaf4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"The strategies should filter VMs by metadata key based on the Watcher"},{"line_number":37,"context_line":"configuration option."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"All existing strategies should also be modified."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Alternatives"},{"line_number":42,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a30ddce_3dd23ad3","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":47},"updated":"2017-03-08 10:59:00.000000000","message":"Can you explain what kind of modifications you expect here?","commit_id":"411be7b0d88da5fcebb3a123cb80451254a6886a"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"1163135ef1253547e506a7772a677afb095c2fc9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"The strategies should filter VMs by metadata key based on the Watcher"},{"line_number":37,"context_line":"configuration option."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"All existing strategies should also be modified."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Alternatives"},{"line_number":42,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a30ddce_204672bf","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":47},"updated":"2017-03-09 03:15:15.000000000","message":"Even if strategy does not want to use optimize metadata key, does the strategy have to be modified?","commit_id":"411be7b0d88da5fcebb3a123cb80451254a6886a"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"1163135ef1253547e506a7772a677afb095c2fc9","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Work Items"},{"line_number":95,"context_line":"----------"},{"line_number":96,"context_line":"* Platform owners or automations external to watcher will set the VM Metadata"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":".. code-block:: json"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a30ddce_03e97814","line":96,"range":{"start_line":96,"start_character":2,"end_line":96,"end_character":77},"updated":"2017-03-09 03:15:15.000000000","message":"It is written that only tenant set optimize metadata key in Use cases section. But this sentence means other than tenant such as administrator set optimize metadata key. If so, That should be added to use case.","commit_id":"411be7b0d88da5fcebb3a123cb80451254a6886a"},{"author":{"_account_id":9392,"name":"Prashanth Hari","email":"hvprash@gmail.com","username":"hvprash"},"change_message_id":"a14a6c9469aaa1ba63f0949fb2753b5b844c7c22","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Work Items"},{"line_number":95,"context_line":"----------"},{"line_number":96,"context_line":"* Platform owners or automations external to watcher will set the VM Metadata"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":".. code-block:: json"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a30ddce_40f0af67","line":96,"range":{"start_line":96,"start_character":2,"end_line":96,"end_character":77},"in_reply_to":"9a30ddce_03e97814","updated":"2017-03-09 15:14:25.000000000","message":"Will update the use case.","commit_id":"411be7b0d88da5fcebb3a123cb80451254a6886a"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"dafc9d3ae096d34686e02e7502bbb67d71b8118c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"We need to a have a configuration option \"check_optimize_metadata\" to enable"},{"line_number":38,"context_line":"this feature."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"If \"check_optimize_metadata\" configution option is enabled, strategy base class"},{"line_number":41,"context_line":"will include only those VMs that has optimize metadata. This will use the"},{"line_number":42,"context_line":"Audit Scope to exclude VMs by metadata."},{"line_number":43,"context_line":"Example -"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bff0334d_eb364803","line":40,"range":{"start_line":40,"start_character":29,"end_line":40,"end_character":40},"updated":"2017-04-12 07:22:25.000000000","message":"configuration","commit_id":"4be8c7aa5d8dd4dda1ff7cb30d99723a49d783ce"}]}