)]}'
{"specs/queens/approved/compute-cdm-include-all-instances.rst":[{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"99c40864ff601772a09dbeb5b180122f5efd9abd","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  class Instance(compute_resource.ComputeResource):"},{"line_number":46,"context_line":"    fields \u003d {"},{"line_number":47,"context_line":"        \"state\": wfields.StringField(default\u003dInstanceState.ACTIVE.value),"},{"line_number":48,"context_line":"        \"exclude\": wfields.BooleanField(default\u003dFalse),"},{"line_number":49,"context_line":"        ..."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_40bd6cd6","line":48,"range":{"start_line":48,"start_character":9,"end_line":48,"end_character":16},"updated":"2017-09-07 07:05:46.000000000","message":"I don\u0027t think \u0027exclude\u0027 exactly.\nMaybe \u0027is_audit\u0027 is better","commit_id":"af124ee05138d36af5b3ba70457acdec9cdabe38"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"c84b4d5b035d8813711191c6b50ac64010e645c4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  class Instance(compute_resource.ComputeResource):"},{"line_number":46,"context_line":"    fields \u003d {"},{"line_number":47,"context_line":"        \"state\": wfields.StringField(default\u003dInstanceState.ACTIVE.value),"},{"line_number":48,"context_line":"        \"exclude\": wfields.BooleanField(default\u003dFalse),"},{"line_number":49,"context_line":"        ..."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_65af36e3","line":48,"range":{"start_line":48,"start_character":9,"end_line":48,"end_character":16},"in_reply_to":"7f287b81_40bd6cd6","updated":"2017-09-08 08:59:06.000000000","message":"We can listen to what others prefer to.","commit_id":"af124ee05138d36af5b3ba70457acdec9cdabe38"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"99c40864ff601772a09dbeb5b180122f5efd9abd","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"None"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Data model impact"},{"line_number":70,"context_line":"-----------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_00b3e40b","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":17},"updated":"2017-09-07 07:05:46.000000000","message":"please update","commit_id":"af124ee05138d36af5b3ba70457acdec9cdabe38"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"c84b4d5b035d8813711191c6b50ac64010e645c4","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"None"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Data model impact"},{"line_number":70,"context_line":"-----------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_c5894a75","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":17},"in_reply_to":"7f287b81_00b3e40b","updated":"2017-09-08 08:59:06.000000000","message":"No changes to database, i think it is unnecessary to update.","commit_id":"af124ee05138d36af5b3ba70457acdec9cdabe38"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"99c40864ff601772a09dbeb5b180122f5efd9abd","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Primary assignee:"},{"line_number":115,"context_line":"sue"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Work Items"},{"line_number":118,"context_line":"----------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":" None"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_60c3c858","line":117,"range":{"start_line":117,"start_character":0,"end_line":117,"end_character":10},"updated":"2017-09-07 07:05:46.000000000","message":"please update","commit_id":"af124ee05138d36af5b3ba70457acdec9cdabe38"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"c84b4d5b035d8813711191c6b50ac64010e645c4","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Primary assignee:"},{"line_number":115,"context_line":"sue"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Work Items"},{"line_number":118,"context_line":"----------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":" None"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_a57abe73","line":117,"range":{"start_line":117,"start_character":0,"end_line":117,"end_character":10},"in_reply_to":"7f287b81_60c3c858","updated":"2017-09-08 08:59:06.000000000","message":"Done","commit_id":"af124ee05138d36af5b3ba70457acdec9cdabe38"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"766d3d14d12a5d84bad3fec911aa62bb724a6a02","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Testing"},{"line_number":126,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"None"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_e05d7879","line":127,"updated":"2017-09-07 07:24:27.000000000","message":"No test cases needs to updated or added??","commit_id":"af124ee05138d36af5b3ba70457acdec9cdabe38"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"c84b4d5b035d8813711191c6b50ac64010e645c4","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Testing"},{"line_number":126,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"None"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_25e36e36","line":127,"in_reply_to":"7f287b81_e05d7879","updated":"2017-09-08 08:59:06.000000000","message":"Not sure. When I finish the work, if it is necessary to add new unit tests, I will update this part.","commit_id":"af124ee05138d36af5b3ba70457acdec9cdabe38"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"766d3d14d12a5d84bad3fec911aa62bb724a6a02","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"References"},{"line_number":136,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"None"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"History"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_0059a48c","line":137,"updated":"2017-09-07 07:24:27.000000000","message":"Add reference to cdm https://docs.openstack.org/watcher/latest/glossary.html#cluster-data-model-definition","commit_id":"af124ee05138d36af5b3ba70457acdec9cdabe38"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"c84b4d5b035d8813711191c6b50ac64010e645c4","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"References"},{"line_number":136,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"None"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"History"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_857fc264","line":137,"in_reply_to":"7f287b81_0059a48c","updated":"2017-09-08 08:59:06.000000000","message":"Done","commit_id":"af124ee05138d36af5b3ba70457acdec9cdabe38"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"eaf3ae4e294325d99e6b9bbd64e7ffacdbafbb8c","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Use Cases"},{"line_number":28,"context_line":"---------"},{"line_number":29,"context_line":"As an end user, I want watcher to give a more reasonable optimization."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5f2577a7_2fe5c6a8","line":29,"range":{"start_line":29,"start_character":46,"end_line":29,"end_character":56},"updated":"2017-09-14 09:14:12.000000000","message":"it\u0027s too common. Wouldn\u0027t be better to say something like \"I want Watcher to take excluded resources into account during workload calculations\"?","commit_id":"ee5093c3dbaad629f00b21cc37e434a2c9902976"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"e2a4c8070c39b7218da720fdf3d28e7c3949820f","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Use Cases"},{"line_number":28,"context_line":"---------"},{"line_number":29,"context_line":"As an end user, I want watcher to give a more reasonable optimization."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5f2577a7_0569cb89","line":29,"range":{"start_line":29,"start_character":46,"end_line":29,"end_character":56},"in_reply_to":"5f2577a7_2fe5c6a8","updated":"2017-09-14 09:39:54.000000000","message":"Done","commit_id":"ee5093c3dbaad629f00b21cc37e434a2c9902976"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"eaf3ae4e294325d99e6b9bbd64e7ffacdbafbb8c","unresolved":false,"context_lines":[{"line_number":56,"context_line":"* Alternative solution, we keep a list of excluded instances in the compute"},{"line_number":57,"context_line":"  CDM."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"To workload balance and server consolidation, it should calculate the workload"},{"line_number":60,"context_line":"of nodes based on all instance on them. Moreover, it wouldn\u0027t migrate excluded"},{"line_number":61,"context_line":"instance in the solutions."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5f2577a7_8a49488c","line":61,"range":{"start_line":59,"start_character":0,"end_line":61,"end_character":26},"updated":"2017-09-14 09:14:12.000000000","message":"you have already described this problem, it shouldn\u0027t be here. whether move or remove it, please.","commit_id":"ee5093c3dbaad629f00b21cc37e434a2c9902976"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"e2a4c8070c39b7218da720fdf3d28e7c3949820f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"* Alternative solution, we keep a list of excluded instances in the compute"},{"line_number":57,"context_line":"  CDM."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"To workload balance and server consolidation, it should calculate the workload"},{"line_number":60,"context_line":"of nodes based on all instance on them. Moreover, it wouldn\u0027t migrate excluded"},{"line_number":61,"context_line":"instance in the solutions."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5f2577a7_e5059fc3","line":61,"range":{"start_line":59,"start_character":0,"end_line":61,"end_character":26},"in_reply_to":"5f2577a7_8a49488c","updated":"2017-09-14 09:39:54.000000000","message":"Done","commit_id":"ee5093c3dbaad629f00b21cc37e434a2c9902976"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"90cd7f0f7643652e4646225e1066c1355232b32a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Compute CDM in Watcher should has a whole scope, include all instances."},{"line_number":41,"context_line":"It needs to be clear which instances are exclude and which are not."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* We can add \"exclude\" field to \"Instance\" resource to distinguish them,"},{"line_number":44,"context_line":"  as following."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  class Instance(compute_resource.ComputeResource):"},{"line_number":47,"context_line":"    fields \u003d {"},{"line_number":48,"context_line":"        \"state\": wfields.StringField(default\u003dInstanceState.ACTIVE.value),"},{"line_number":49,"context_line":"        \"exclude\": wfields.BooleanField(default\u003dFalse),"},{"line_number":50,"context_line":"        ..."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  When building compute CDM, set the \u0027exclude\u0027 flag \u0027True\u0027 if the instance"},{"line_number":55,"context_line":"  is excluded by the scope."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* Alternative solution, we keep a list of excluded instances in the compute"},{"line_number":58,"context_line":"  CDM."}],"source_content_type":"text/x-rst","patch_set":9,"id":"7f515b1d_bd169054","line":55,"range":{"start_line":43,"start_character":0,"end_line":55,"end_character":27},"updated":"2017-09-27 08:38:05.000000000","message":"Ok, how can it be used in strategy? Could you please provide an example of code?","commit_id":"a26c524bf53fea1a6b70bc21c75f7422ec3d3fa4"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"83ab6b21a36ce60e34efefe1d91f6559585dd88e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Compute CDM in Watcher should has a whole scope, include all instances."},{"line_number":41,"context_line":"It needs to be clear which instances are exclude and which are not."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* We can add \"exclude\" field to \"Instance\" resource to distinguish them,"},{"line_number":44,"context_line":"  as following."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  class Instance(compute_resource.ComputeResource):"},{"line_number":47,"context_line":"    fields \u003d {"},{"line_number":48,"context_line":"        \"state\": wfields.StringField(default\u003dInstanceState.ACTIVE.value),"},{"line_number":49,"context_line":"        \"exclude\": wfields.BooleanField(default\u003dFalse),"},{"line_number":50,"context_line":"        ..."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  When building compute CDM, set the \u0027exclude\u0027 flag \u0027True\u0027 if the instance"},{"line_number":55,"context_line":"  is excluded by the scope."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* Alternative solution, we keep a list of excluded instances in the compute"},{"line_number":58,"context_line":"  CDM."}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f4e5783_c2a82721","line":55,"range":{"start_line":43,"start_character":0,"end_line":55,"end_character":27},"in_reply_to":"5f4e5783_16abbcd6","updated":"2017-10-16 07:16:20.000000000","message":"Maybe we need a new method such as \u0027get_node_all_instances\u0027.","commit_id":"a26c524bf53fea1a6b70bc21c75f7422ec3d3fa4"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"f0d7b283219730a0e5d01ef638bfa42531c028ba","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Compute CDM in Watcher should has a whole scope, include all instances."},{"line_number":41,"context_line":"It needs to be clear which instances are exclude and which are not."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* We can add \"exclude\" field to \"Instance\" resource to distinguish them,"},{"line_number":44,"context_line":"  as following."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  class Instance(compute_resource.ComputeResource):"},{"line_number":47,"context_line":"    fields \u003d {"},{"line_number":48,"context_line":"        \"state\": wfields.StringField(default\u003dInstanceState.ACTIVE.value),"},{"line_number":49,"context_line":"        \"exclude\": wfields.BooleanField(default\u003dFalse),"},{"line_number":50,"context_line":"        ..."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  When building compute CDM, set the \u0027exclude\u0027 flag \u0027True\u0027 if the instance"},{"line_number":55,"context_line":"  is excluded by the scope."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* Alternative solution, we keep a list of excluded instances in the compute"},{"line_number":58,"context_line":"  CDM."}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f4e5783_16abbcd6","line":55,"range":{"start_line":43,"start_character":0,"end_line":55,"end_character":27},"in_reply_to":"5f4e5783_bd7ccab5","updated":"2017-10-10 12:11:32.000000000","message":"I primitively thought to do so. There are two place to call method \u0027get_node_instances\u0027. The first, to caculate the node workload; the second, to choice instances to migrate. So the developers should know how to set \"exclude\" attribute when calling the method. That doesn\u0027t look obvious to new developers, too.\n\nI notice that we filter out not only excluded instances but also instance with special marks(such as metedata, project property...) or locked instances(implementing). It is better to combine them together in further. But for the spec, i think it\u0027s better not to change the method \u0027get_node_instances\u0027.","commit_id":"a26c524bf53fea1a6b70bc21c75f7422ec3d3fa4"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"4a6362b9f23bacaccc3a5c3066139cd09fec70f6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Compute CDM in Watcher should has a whole scope, include all instances."},{"line_number":41,"context_line":"It needs to be clear which instances are exclude and which are not."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* We can add \"exclude\" field to \"Instance\" resource to distinguish them,"},{"line_number":44,"context_line":"  as following."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  class Instance(compute_resource.ComputeResource):"},{"line_number":47,"context_line":"    fields \u003d {"},{"line_number":48,"context_line":"        \"state\": wfields.StringField(default\u003dInstanceState.ACTIVE.value),"},{"line_number":49,"context_line":"        \"exclude\": wfields.BooleanField(default\u003dFalse),"},{"line_number":50,"context_line":"        ..."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  When building compute CDM, set the \u0027exclude\u0027 flag \u0027True\u0027 if the instance"},{"line_number":55,"context_line":"  is excluded by the scope."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* Alternative solution, we keep a list of excluded instances in the compute"},{"line_number":58,"context_line":"  CDM."}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f4e5783_056e492e","line":55,"range":{"start_line":43,"start_character":0,"end_line":55,"end_character":27},"in_reply_to":"5f4e5783_c2a82721","updated":"2017-10-16 08:05:28.000000000","message":"The method \u0027get_node_instances\u0027 has the same function.\nIn one strategy, Watcher would filter out not only excluded instances , but also instance with special marks(such as metedata, project property...) or locked instances(implementing).It seems more reasonable to leave the job of filter out instnaces when migrating to the strategy to do.","commit_id":"a26c524bf53fea1a6b70bc21c75f7422ec3d3fa4"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"4b7fed035bc0e1cc0bec4a2a9f38bca1e61d1971","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Compute CDM in Watcher should has a whole scope, include all instances."},{"line_number":41,"context_line":"It needs to be clear which instances are exclude and which are not."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* We can add \"exclude\" field to \"Instance\" resource to distinguish them,"},{"line_number":44,"context_line":"  as following."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  class Instance(compute_resource.ComputeResource):"},{"line_number":47,"context_line":"    fields \u003d {"},{"line_number":48,"context_line":"        \"state\": wfields.StringField(default\u003dInstanceState.ACTIVE.value),"},{"line_number":49,"context_line":"        \"exclude\": wfields.BooleanField(default\u003dFalse),"},{"line_number":50,"context_line":"        ..."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  When building compute CDM, set the \u0027exclude\u0027 flag \u0027True\u0027 if the instance"},{"line_number":55,"context_line":"  is excluded by the scope."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* Alternative solution, we keep a list of excluded instances in the compute"},{"line_number":58,"context_line":"  CDM."}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f4e5783_bd7ccab5","line":55,"range":{"start_line":43,"start_character":0,"end_line":55,"end_character":27},"in_reply_to":"7f515b1d_24348e92","updated":"2017-10-10 10:10:48.000000000","message":"It doesn\u0027t look obvious for new strategy developers. Maybe we could add optional attribute \"exclude\" to method get_node_instances that would return list of instances in accordance with exclude attribute. What do you think?","commit_id":"a26c524bf53fea1a6b70bc21c75f7422ec3d3fa4"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"4864c5f608d93b79e71de3a04a312ac0a3753d51","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Compute CDM in Watcher should has a whole scope, include all instances."},{"line_number":41,"context_line":"It needs to be clear which instances are exclude and which are not."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* We can add \"exclude\" field to \"Instance\" resource to distinguish them,"},{"line_number":44,"context_line":"  as following."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  class Instance(compute_resource.ComputeResource):"},{"line_number":47,"context_line":"    fields \u003d {"},{"line_number":48,"context_line":"        \"state\": wfields.StringField(default\u003dInstanceState.ACTIVE.value),"},{"line_number":49,"context_line":"        \"exclude\": wfields.BooleanField(default\u003dFalse),"},{"line_number":50,"context_line":"        ..."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  When building compute CDM, set the \u0027exclude\u0027 flag \u0027True\u0027 if the instance"},{"line_number":55,"context_line":"  is excluded by the scope."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* Alternative solution, we keep a list of excluded instances in the compute"},{"line_number":58,"context_line":"  CDM."}],"source_content_type":"text/x-rst","patch_set":9,"id":"7f515b1d_24348e92","line":55,"range":{"start_line":43,"start_character":0,"end_line":55,"end_character":27},"in_reply_to":"7f515b1d_bd169054","updated":"2017-09-29 01:44:56.000000000","message":"please refer to this commit,\nhttps://review.openstack.org/#/c/508108/","commit_id":"a26c524bf53fea1a6b70bc21c75f7422ec3d3fa4"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"83ab6b21a36ce60e34efefe1d91f6559585dd88e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  When building compute CDM, set the \u0027exclude\u0027 flag \u0027True\u0027 if the instance"},{"line_number":55,"context_line":"  is excluded by the scope."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* Alternative solution, we keep a list of excluded instances in the compute"},{"line_number":58,"context_line":"  CDM."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f4e5783_a28c0bd7","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":6},"updated":"2017-10-16 07:16:20.000000000","message":"Please move to Alternatives","commit_id":"a26c524bf53fea1a6b70bc21c75f7422ec3d3fa4"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"4a6362b9f23bacaccc3a5c3066139cd09fec70f6","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  When building compute CDM, set the \u0027exclude\u0027 flag \u0027True\u0027 if the instance"},{"line_number":55,"context_line":"  is excluded by the scope."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* Alternative solution, we keep a list of excluded instances in the compute"},{"line_number":58,"context_line":"  CDM."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f4e5783_05d1a923","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":6},"in_reply_to":"5f4e5783_a28c0bd7","updated":"2017-10-16 08:05:28.000000000","message":"ok","commit_id":"a26c524bf53fea1a6b70bc21c75f7422ec3d3fa4"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"83ab6b21a36ce60e34efefe1d91f6559585dd88e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"Data model impact"},{"line_number":67,"context_line":"-----------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"None"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"REST API impact"},{"line_number":72,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f4e5783_e28683b9","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":4},"updated":"2017-10-16 07:16:20.000000000","message":"Your proposal will change the data model.","commit_id":"a26c524bf53fea1a6b70bc21c75f7422ec3d3fa4"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"4a6362b9f23bacaccc3a5c3066139cd09fec70f6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"Data model impact"},{"line_number":67,"context_line":"-----------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"None"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"REST API impact"},{"line_number":72,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f4e5783_65c29d5b","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":4},"in_reply_to":"5f4e5783_e28683b9","updated":"2017-10-16 08:05:28.000000000","message":"data model in this section means new data objects and/or database schema. Cluster data model is not included.\nsee the temlate: https://github.com/openstack/watcher-specs/blob/master/specs/queens-template.rst#data-model-impact","commit_id":"a26c524bf53fea1a6b70bc21c75f7422ec3d3fa4"}]}