)]}'
{"specs/queens/approved/exclude-locked-instances.rst":[{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"a81c2d6a6d8a7a9865c32b5c28318599650c6d34","unresolved":false,"context_lines":[{"line_number":34,"context_line":"In the compute CDM, Watcher should identify which instances are locked"},{"line_number":35,"context_line":"by end users and which are not."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"We can add \"locked\" field to \"Instance\" resource to distinguish them,"},{"line_number":38,"context_line":"as following."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  class Instance(compute_resource.ComputeResource):"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_674576b3","line":37,"range":{"start_line":37,"start_character":11,"end_line":37,"end_character":19},"updated":"2017-09-25 02:41:31.000000000","message":"Does locked field this spec is proposing synchronize with nova locked_by field of Instance Class? \nhttps://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L311\nif so please write in this spec.","commit_id":"b8488d02e4cddb0a0074914c69578c573b46dde0"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"6a294bad8c120e2d22aa08cba45684547dd48fb3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"In the compute CDM, Watcher should identify which instances are locked"},{"line_number":35,"context_line":"by end users and which are not."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"We can add \"locked\" field to \"Instance\" resource to distinguish them,"},{"line_number":38,"context_line":"as following."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  class Instance(compute_resource.ComputeResource):"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_3f1426a0","line":37,"range":{"start_line":37,"start_character":11,"end_line":37,"end_character":19},"in_reply_to":"7f515b1d_0dab8389","updated":"2017-09-25 07:29:23.000000000","message":"Could you please write it\u0027s synchronization?\n\n* Which nova object does locked field synchronized with?\n\n* How does locked field synchronized with nova object?\n  if synchronized with nova object by notification, consuming notification will be updated.\n\n* When does locked field synchronized with nova object?","commit_id":"b8488d02e4cddb0a0074914c69578c573b46dde0"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"726f4f4c67a6f92b4e42f2c6436a502185688eb2","unresolved":false,"context_lines":[{"line_number":34,"context_line":"In the compute CDM, Watcher should identify which instances are locked"},{"line_number":35,"context_line":"by end users and which are not."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"We can add \"locked\" field to \"Instance\" resource to distinguish them,"},{"line_number":38,"context_line":"as following."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  class Instance(compute_resource.ComputeResource):"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_18acb99e","line":37,"range":{"start_line":37,"start_character":11,"end_line":37,"end_character":19},"in_reply_to":"7f515b1d_3f1426a0","updated":"2017-09-26 08:48:29.000000000","message":"Done","commit_id":"b8488d02e4cddb0a0074914c69578c573b46dde0"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"082ac81a8a8f04befa4e5dc79c92175f527e0fa7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"In the compute CDM, Watcher should identify which instances are locked"},{"line_number":35,"context_line":"by end users and which are not."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"We can add \"locked\" field to \"Instance\" resource to distinguish them,"},{"line_number":38,"context_line":"as following."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  class Instance(compute_resource.ComputeResource):"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_0dab8389","line":37,"range":{"start_line":37,"start_character":11,"end_line":37,"end_character":19},"in_reply_to":"7f515b1d_674576b3","updated":"2017-09-25 05:44:37.000000000","message":"Yes, it is proposing synchronize with nova \u0027locked\u0027 field of Instance Class. The \u0027locked_by\u0027 seems of no use.","commit_id":"b8488d02e4cddb0a0074914c69578c573b46dde0"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"0bea9d4b08e2895fc40cdfde0744e9a838955d0e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"This field is synchronized with nova \u0027locked\u0027 field of Instance Class, when"},{"line_number":49,"context_line":"building compute CDM, and updated by \u0027instance.update\u0027 notifications."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"In one strategy, the admin can input a parameter (\u0027exclude_locked\u0027) to"},{"line_number":52,"context_line":"ensure whether to migrate the locked instances. Only if double check passes,"},{"line_number":53,"context_line":"the locked instance couldn\u0027t be migrated."},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_b28680b8","line":51,"range":{"start_line":51,"start_character":3,"end_line":51,"end_character":15},"updated":"2017-09-29 05:04:35.000000000","message":"Please show strategy name.","commit_id":"083caa766b527c78a807ab9c2a518a27c77ae52f"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"0a2d41f438019098d96608b4dcc8ec2d02495921","unresolved":false,"context_lines":[{"line_number":48,"context_line":"This field is synchronized with nova \u0027locked\u0027 field of Instance Class, when"},{"line_number":49,"context_line":"building compute CDM, and updated by \u0027instance.update\u0027 notifications."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"In one strategy, the admin can input a parameter (\u0027exclude_locked\u0027) to"},{"line_number":52,"context_line":"ensure whether to migrate the locked instances. Only if double check passes,"},{"line_number":53,"context_line":"the locked instance couldn\u0027t be migrated."},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f4e5783_e1cb7847","line":51,"range":{"start_line":51,"start_character":3,"end_line":51,"end_character":15},"in_reply_to":"7f515b1d_b28680b8","updated":"2017-10-12 05:09:47.000000000","message":"strategies for server_consolidation/workload_balancing/temp_optimization.","commit_id":"083caa766b527c78a807ab9c2a518a27c77ae52f"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"0bea9d4b08e2895fc40cdfde0744e9a838955d0e","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Work Items"},{"line_number":111,"context_line":"----------"},{"line_number":112,"context_line":"* Identify excluded instances in compute CDM"},{"line_number":113,"context_line":"* Adjust existing strategies to exclude locked instances when optimizing"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_52986c1a","line":112,"range":{"start_line":112,"start_character":2,"end_line":112,"end_character":44},"updated":"2017-09-29 05:04:35.000000000","message":"Two items are better.\n* Add locked field to Instance resource.\n* Add locked field to NovaNotification class to update locked field in Instance resource","commit_id":"083caa766b527c78a807ab9c2a518a27c77ae52f"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"0a2d41f438019098d96608b4dcc8ec2d02495921","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Work Items"},{"line_number":111,"context_line":"----------"},{"line_number":112,"context_line":"* Identify excluded instances in compute CDM"},{"line_number":113,"context_line":"* Adjust existing strategies to exclude locked instances when optimizing"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f4e5783_a1eea0b1","line":112,"range":{"start_line":112,"start_character":2,"end_line":112,"end_character":44},"in_reply_to":"7f515b1d_52986c1a","updated":"2017-10-12 05:09:47.000000000","message":"ok","commit_id":"083caa766b527c78a807ab9c2a518a27c77ae52f"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"0bea9d4b08e2895fc40cdfde0744e9a838955d0e","unresolved":false,"context_lines":[{"line_number":110,"context_line":"Work Items"},{"line_number":111,"context_line":"----------"},{"line_number":112,"context_line":"* Identify excluded instances in compute CDM"},{"line_number":113,"context_line":"* Adjust existing strategies to exclude locked instances when optimizing"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Dependencies"},{"line_number":116,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_929144f4","line":113,"range":{"start_line":113,"start_character":9,"end_line":113,"end_character":28},"updated":"2017-09-29 05:04:35.000000000","message":"Please show strategy names.","commit_id":"083caa766b527c78a807ab9c2a518a27c77ae52f"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"0a2d41f438019098d96608b4dcc8ec2d02495921","unresolved":false,"context_lines":[{"line_number":110,"context_line":"Work Items"},{"line_number":111,"context_line":"----------"},{"line_number":112,"context_line":"* Identify excluded instances in compute CDM"},{"line_number":113,"context_line":"* Adjust existing strategies to exclude locked instances when optimizing"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Dependencies"},{"line_number":116,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f4e5783_01fa1474","line":113,"range":{"start_line":113,"start_character":9,"end_line":113,"end_character":28},"in_reply_to":"7f515b1d_929144f4","updated":"2017-10-12 05:09:47.000000000","message":"strategies for server_consolidation/workload_balancing/temp_optimization.","commit_id":"083caa766b527c78a807ab9c2a518a27c77ae52f"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"0bea9d4b08e2895fc40cdfde0744e9a838955d0e","unresolved":false,"context_lines":[{"line_number":125,"context_line":"Documentation Impact"},{"line_number":126,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"None"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"References"},{"line_number":131,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_52c18ce4","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":4},"updated":"2017-09-29 05:04:35.000000000","message":"Strategy documentation will be updated.\nhttps://docs.openstack.org/watcher/latest/strategies/index.html","commit_id":"083caa766b527c78a807ab9c2a518a27c77ae52f"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"0a2d41f438019098d96608b4dcc8ec2d02495921","unresolved":false,"context_lines":[{"line_number":125,"context_line":"Documentation Impact"},{"line_number":126,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"None"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"References"},{"line_number":131,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f4e5783_812ba4e9","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":4},"in_reply_to":"7f515b1d_52c18ce4","updated":"2017-10-12 05:09:47.000000000","message":"yes","commit_id":"083caa766b527c78a807ab9c2a518a27c77ae52f"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"88147f8ca39160272bdfe45673751f6c3007110c","unresolved":false,"context_lines":[{"line_number":111,"context_line":"Work Items"},{"line_number":112,"context_line":"----------"},{"line_number":113,"context_line":"* Add locked field to Instance resource."},{"line_number":114,"context_line":"* Add locked field to NovaNotification class to update locked field in Instance resource."},{"line_number":115,"context_line":"* Adjust strategies for server_consolidation/workload_balancing/temp_optimization\u0027"},{"line_number":116,"context_line":"  to exclude locked instances when optimizing."},{"line_number":117,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f4e5783_93c63a9a","line":114,"updated":"2017-10-13 04:57:04.000000000","message":"False is not true : specs/queens/approved/exclude-locked-instances.rst:114: Line limited to a maximum of 79 characters.","commit_id":"0079f5285fd48114ef0f752319ef84b617c48341"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"a5229e790b1913572c488562297b11971cc455d7","unresolved":false,"context_lines":[{"line_number":111,"context_line":"Work Items"},{"line_number":112,"context_line":"----------"},{"line_number":113,"context_line":"* Add locked field to Instance resource."},{"line_number":114,"context_line":"* Add locked field to NovaNotification class to update locked field in Instance resource."},{"line_number":115,"context_line":"* Adjust strategies for server_consolidation/workload_balancing/temp_optimization\u0027"},{"line_number":116,"context_line":"  to exclude locked instances when optimizing."},{"line_number":117,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f4e5783_de4f1290","line":114,"in_reply_to":"5f4e5783_93c63a9a","updated":"2017-10-13 08:59:16.000000000","message":"Done","commit_id":"0079f5285fd48114ef0f752319ef84b617c48341"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"e194a965cf97032062495624f91763f3ea9e9297","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Use Cases"},{"line_number":27,"context_line":"---------"},{"line_number":28,"context_line":"As an end user, I don\u0027t want Watcher to migrate my locked instances."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f4e5783_dc8b4cc0","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":67},"updated":"2017-10-17 09:18:23.000000000","message":"We can put these instances in exclude of audit scope to get the same goal.\nI don\u0027t think it\u0027s necessary to add a new filed.","commit_id":"767924ce7d955fc69b23085e55573f98ef5b6d12"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"5c39b3807503abac57fe724c2e6e40030f3444c5","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Use Cases"},{"line_number":27,"context_line":"---------"},{"line_number":28,"context_line":"As an end user, I don\u0027t want Watcher to migrate my locked instances."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff82abbf_025caa49","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":67},"in_reply_to":"5f4e5783_7b10c357","updated":"2017-11-20 02:54:31.000000000","message":"agreed with licanwei\u0027s comment, using exclude to strategy input parameters is not the justified solution.\nwhy scope can\u0027t filter new created instances?? can\u0027t we make it doing so??","commit_id":"767924ce7d955fc69b23085e55573f98ef5b6d12"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"7206af1ca374e7afba76653fcf7c136a4ef88630","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Use Cases"},{"line_number":27,"context_line":"---------"},{"line_number":28,"context_line":"As an end user, I don\u0027t want Watcher to migrate my locked instances."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f4e5783_f0be12d3","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":67},"in_reply_to":"5f4e5783_daf6acd7","updated":"2017-10-18 01:17:41.000000000","message":"1,If you need input a parameter(\u0027exclude_locked\u0027) when creating audit, It\u0027s better to use scope.\n2,If you want filter some instances, pls refer to:https://github.com/openstack/watcher-specs/blob/master/specs/pike/implemented/audit-tag-vm-metadata.rst\nWe had add too many fields in the CDM.\nI don\u0027t think this \u0027locked\u0027 filed is necessary.","commit_id":"767924ce7d955fc69b23085e55573f98ef5b6d12"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"58b97ef0f96519cfb4cc9277d4941b80fd2ac1e3","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Use Cases"},{"line_number":27,"context_line":"---------"},{"line_number":28,"context_line":"As an end user, I don\u0027t want Watcher to migrate my locked instances."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f4e5783_ff5b9af2","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":67},"in_reply_to":"5f4e5783_dc8b4cc0","updated":"2017-10-17 09:38:51.000000000","message":"The locked instances is in end users\u0027 view, while the exclude is in administrator\u0027s view. They are not the same. The exclude instances is filter out by default when migration, while the locked is not always filter out, which need double check.","commit_id":"767924ce7d955fc69b23085e55573f98ef5b6d12"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"ecb870a201e31670ab969324860c055474121126","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Use Cases"},{"line_number":27,"context_line":"---------"},{"line_number":28,"context_line":"As an end user, I don\u0027t want Watcher to migrate my locked instances."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f4e5783_7b10c357","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":67},"in_reply_to":"5f4e5783_f0be12d3","updated":"2017-10-18 02:28:56.000000000","message":"1.As I said above, scope can\u0027t filter new created instances during optimization.\n\n2.I know \u0027audit-tag-vm-metadata\u0027. But \u0027locked\u0027 is inherent from instance resource. The purpose of the \u0027locked\u0027 is to avoid misoperation. It is easier to use.\nplease refer to https://github.com/openstack/nova/blob/master/api-guide/source/server_concepts.rst\n\n\u0027audit-tag-vm-metadata\u0027 looks more like a makeshift. For now, they can work together.","commit_id":"767924ce7d955fc69b23085e55573f98ef5b6d12"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"508441fa7c105bc1850e8a1965737ab0c7d5ff3a","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Use Cases"},{"line_number":27,"context_line":"---------"},{"line_number":28,"context_line":"As an end user, I don\u0027t want Watcher to migrate my locked instances."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f4e5783_daf6acd7","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":67},"in_reply_to":"5f4e5783_ff5b9af2","updated":"2017-10-17 10:08:23.000000000","message":"Another consideration, Watcher filter out exsiting instances by exclude scope, but it can\u0027t filter out new created instances. So to the new created instances, if we want to filter out them when migration, just lock them.","commit_id":"767924ce7d955fc69b23085e55573f98ef5b6d12"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"d3c3676748a97137c0e41880408dd9f43d5b26e3","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Use Cases"},{"line_number":27,"context_line":"---------"},{"line_number":28,"context_line":"As an end user, I don\u0027t want Watcher to migrate my locked instances."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff82abbf_d631a4ee","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":67},"in_reply_to":"ff82abbf_025caa49","updated":"2017-11-20 07:29:55.000000000","message":"Watcher builds the compute CDM, and update by notifications. But if new instances are created after the compute CDM built, how to exclude the new instances by scope? The scope is ascertained at the begining, and it is specific for Watcher, no notications to update it.\n\u0027audit-tag-vm-metadata\u0027 and \u0027locked\u0027 can deal with such case. Because they are inherent from nova, Watcher can update the fileds by \u0027instance.update\u0027 notifications from nova during optimization. But unfortunately, nova only send \u0027instance.update\u0027 notifications when state or task state of the instances changes, so it need some work in nova to make them complete.","commit_id":"767924ce7d955fc69b23085e55573f98ef5b6d12"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"5c8f58575d6ea47bc7a631f9682f78889e18dc48","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Use Cases"},{"line_number":27,"context_line":"---------"},{"line_number":28,"context_line":"As an end user, I don\u0027t want Watcher to migrate my locked instances."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff82abbf_05003434","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":67},"in_reply_to":"ff82abbf_025caa49","updated":"2017-11-20 04:09:27.000000000","message":"liwanwei, aditi sharma: I am favor of adding locked field.\nRegardless our favor, Lock/UNLOCK exists apart from metadata in Nova and user executes its API.","commit_id":"767924ce7d955fc69b23085e55573f98ef5b6d12"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"fa52064d4bab8b4b67ca66794c3f6b09bf706a1c","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Use Cases"},{"line_number":27,"context_line":"---------"},{"line_number":28,"context_line":"As an end user, I don\u0027t want Watcher to migrate my locked instances."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff82abbf_0847eb1f","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":67},"in_reply_to":"ff82abbf_05003434","updated":"2017-11-20 04:37:15.000000000","message":"Hidekazu: i am also ok to add locked field in compute CDM, but not in favor of adding exclude in strategy input parameters.","commit_id":"767924ce7d955fc69b23085e55573f98ef5b6d12"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"08a40b22efb8165c7e888fcd13b5fbeb8a7ec5cd","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Use Cases"},{"line_number":27,"context_line":"---------"},{"line_number":28,"context_line":"As an end user, I don\u0027t want Watcher to migrate my locked instances."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff82abbf_eb75e1cd","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":67},"in_reply_to":"ff82abbf_0847eb1f","updated":"2017-11-20 06:39:08.000000000","message":"Oh, i see. i am not in favor of adding exclude in input parameters,too.\n\"Unlock will unlock a server in locked state so additional operations can be performed on the server.\"\nhttps://github.com/openstack/nova/blob/master/api-guide/source/server_concepts.rst\n\nIf administrator can not migrate locked instance, we should eliminate locked instance at first without choice.","commit_id":"767924ce7d955fc69b23085e55573f98ef5b6d12"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"08a40b22efb8165c7e888fcd13b5fbeb8a7ec5cd","unresolved":false,"context_lines":[{"line_number":49,"context_line":"building compute CDM, and updated by \u0027instance.update\u0027 notifications."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"In strategies for server_consolidation/workload_balancing/temp_optimization,"},{"line_number":52,"context_line":"the admin can input a parameter (\u0027exclude_locked\u0027) to ensure whether to"},{"line_number":53,"context_line":"migrate the locked instances. Only if double check passes, the locked instance"},{"line_number":54,"context_line":"couldn\u0027t be migrated."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff82abbf_36081027","line":54,"range":{"start_line":52,"start_character":0,"end_line":54,"end_character":21},"updated":"2017-11-20 06:39:08.000000000","message":"Can administrator migrate locked instance?\n\"Unlock will unlock a server in locked state so additional operations can be performed on the server.\"\nhttps://github.com/openstack/nova/blob/master/api-guide/source/server_concepts.rst\n\nIf administrator can not migrate locked instance, we should eliminate locked instance from candicate for migrating at first without choice.","commit_id":"767924ce7d955fc69b23085e55573f98ef5b6d12"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"d3c3676748a97137c0e41880408dd9f43d5b26e3","unresolved":false,"context_lines":[{"line_number":49,"context_line":"building compute CDM, and updated by \u0027instance.update\u0027 notifications."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"In strategies for server_consolidation/workload_balancing/temp_optimization,"},{"line_number":52,"context_line":"the admin can input a parameter (\u0027exclude_locked\u0027) to ensure whether to"},{"line_number":53,"context_line":"migrate the locked instances. Only if double check passes, the locked instance"},{"line_number":54,"context_line":"couldn\u0027t be migrated."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff82abbf_56bcb468","line":54,"range":{"start_line":52,"start_character":0,"end_line":54,"end_character":21},"in_reply_to":"ff82abbf_36081027","updated":"2017-11-20 07:29:55.000000000","message":"The administrator has large privileges. Watcher has the admin role, so it can migrate locked instance.\nThe disputation is not whether it can or not, just whether it should or not. In my opinion, Wather should have diffrent tolerance when migration for diffrent goals. Like exclude instances in scope or locked instances, to achieve the goal, Watcher would filter out them when migration for workload balance, but it shouldn\u0027t filter out them for maintenance.\nWe can care about the requirement of both administrator and end users by \u0027exclude_locked\u0027(precise word \u0027filter_locked\u0027) inpute_parameter. But it is ok without this input_parameter.","commit_id":"767924ce7d955fc69b23085e55573f98ef5b6d12"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"9b06f68db844cac80b4b46e5cb508398717443eb","unresolved":false,"context_lines":[{"line_number":49,"context_line":"building compute CDM, and updated by \u0027instance.update\u0027 notifications."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"In strategies for server_consolidation/workload_balancing/temp_optimization,"},{"line_number":52,"context_line":"the admin can input a parameter (\u0027exclude_locked\u0027) to ensure whether to"},{"line_number":53,"context_line":"migrate the locked instances. Only if double check passes, the locked instance"},{"line_number":54,"context_line":"couldn\u0027t be migrated."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff82abbf_9805827d","line":54,"range":{"start_line":52,"start_character":0,"end_line":54,"end_character":21},"in_reply_to":"ff82abbf_56bcb468","updated":"2017-11-20 13:43:34.000000000","message":"I suggest to use config parameter for each strategy. Because excluding locked instance or not depends on strategy not on audit.","commit_id":"767924ce7d955fc69b23085e55573f98ef5b6d12"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"02e20615334b1f17fbda4456b3127d0b9ae3f82a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"building compute CDM, and updated by \u0027instance.update\u0027 notifications."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"In strategies for server_consolidation/workload_balancing/temp_optimization,"},{"line_number":52,"context_line":"the admin can input a parameter (\u0027exclude_locked\u0027) to ensure whether to"},{"line_number":53,"context_line":"migrate the locked instances. Only if double check passes, the locked instance"},{"line_number":54,"context_line":"couldn\u0027t be migrated."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff82abbf_4707001e","line":54,"range":{"start_line":52,"start_character":0,"end_line":54,"end_character":21},"in_reply_to":"ff82abbf_9805827d","updated":"2017-11-21 07:54:26.000000000","message":"Ok. Not expose this parameter to admin, and leave the decision wether to migrate locked instances to the strategies.\nNow it doesn\u0027t migrate locked instances in \u0027server_consolidation/workload_balancing/temp_optimization\u0027.","commit_id":"767924ce7d955fc69b23085e55573f98ef5b6d12"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"5c39b3807503abac57fe724c2e6e40030f3444c5","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Alternatives"},{"line_number":58,"context_line":"------------"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"None"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff82abbf_62301609","line":59,"updated":"2017-11-20 02:54:31.000000000","message":"Please add the alternatives in this section, as it seems to have many alternatives from above discussion, and please add the cons of not using the alternatives.","commit_id":"767924ce7d955fc69b23085e55573f98ef5b6d12"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"9b06f68db844cac80b4b46e5cb508398717443eb","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Alternatives"},{"line_number":58,"context_line":"------------"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"None"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff82abbf_982a62e5","line":59,"in_reply_to":"ff82abbf_56827451","updated":"2017-11-20 13:43:34.000000000","message":"Strategy checks each instance is locked or not by Nova API. If instance is locked, strategy exclude the instance to be migrated.","commit_id":"767924ce7d955fc69b23085e55573f98ef5b6d12"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"d3c3676748a97137c0e41880408dd9f43d5b26e3","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Alternatives"},{"line_number":58,"context_line":"------------"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"None"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff82abbf_56827451","line":59,"in_reply_to":"ff82abbf_62301609","updated":"2017-11-20 07:29:55.000000000","message":"There is no alternatives, just compared with existing  mechanisms.","commit_id":"767924ce7d955fc69b23085e55573f98ef5b6d12"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"02e20615334b1f17fbda4456b3127d0b9ae3f82a","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Alternatives"},{"line_number":58,"context_line":"------------"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"None"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff82abbf_e73f34d4","line":59,"in_reply_to":"ff82abbf_982a62e5","updated":"2017-11-21 07:54:26.000000000","message":"An alternative, but not recommend. It would bring more pressure to Nova-api if there are amount of instances.","commit_id":"767924ce7d955fc69b23085e55573f98ef5b6d12"}]}