)]}'
{"specs/rocky/approved/enhance-watcher-applier-engine.rst":[{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"73d254caadcf3c44753b2f5267bfaddb31e6cf79","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Enhance Watcher Applier Engine"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/watcher/+spec/enhance-watcher-applier-engine"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_1ee249a1","line":8,"range":{"start_line":8,"start_character":16,"end_line":8,"end_character":30},"updated":"2018-03-13 06:44:19.000000000","message":"This is confusing applier with workflow engine.\nWorkflow engine is better than applier because more strict meaning.","commit_id":"73545c037f92051f8d37a09857fdebd6bdd922b2"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"f00182de82070943bd91606f31e0cfc9fdcc8dba","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Enhance Watcher Applier Engine"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/watcher/+spec/enhance-watcher-applier-engine"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_ba4c69c8","line":8,"range":{"start_line":8,"start_character":16,"end_line":8,"end_character":30},"in_reply_to":"df7087c5_1ee249a1","updated":"2018-03-14 02:51:33.000000000","message":"Done","commit_id":"73545c037f92051f8d37a09857fdebd6bdd922b2"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"37ffa21c71f33ff4d0a2bd4abde621c9adf5d91f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"If execution_rule is EITHER, the return depends on the result of previous"},{"line_number":46,"context_line":"action execution."},{"line_number":47,"context_line":"The default value is ALWAYS."},{"line_number":48,"context_line":"If exception is throwing out during the action execution, reverting will"},{"line_number":49,"context_line":"be triggered by taskflow. To continue executing the next action,"},{"line_number":50,"context_line":"we return False instead of throwing an exception."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Alternatives"},{"line_number":53,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df7087c5_bc92b74a","line":50,"range":{"start_line":48,"start_character":0,"end_line":50,"end_character":49},"updated":"2018-03-19 07:53:31.000000000","message":"Does this sentence apply for EITHER?\nIf this is the case for EITHER, please move between line 46 and line 47.","commit_id":"3ae915a1999c8d7e3f51ba68fc5eda0ff2125ee8"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"43a0e5f781481fe3b99717e4f46a182f3ca29478","unresolved":false,"context_lines":[{"line_number":45,"context_line":"If execution_rule is EITHER, the return depends on the result of previous"},{"line_number":46,"context_line":"action execution."},{"line_number":47,"context_line":"The default value is ALWAYS."},{"line_number":48,"context_line":"If exception is throwing out during the action execution, reverting will"},{"line_number":49,"context_line":"be triggered by taskflow. To continue executing the next action,"},{"line_number":50,"context_line":"we return False instead of throwing an exception."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Alternatives"},{"line_number":53,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df7087c5_2c12d9b2","line":50,"range":{"start_line":48,"start_character":0,"end_line":50,"end_character":49},"in_reply_to":"df7087c5_bc92b74a","updated":"2018-03-20 03:44:20.000000000","message":"yes, will fix","commit_id":"3ae915a1999c8d7e3f51ba68fc5eda0ff2125ee8"},{"author":{"_account_id":27947,"name":"Egor Panfilov","email":"edpanfilov@sbcloud.ru","username":"erakli"},"change_message_id":"a640ddc68cb87f8da2b3febb9936ccd35a936c19","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/watcher/+spec/enhance-watcher-workflow-engine"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"`Taskflow`_ is the default workflow engine for Watcher Applier."},{"line_number":14,"context_line":"The flow pattern for linked actions is Graph flow. For parent action A"},{"line_number":15,"context_line":"and child action B, this means B depends on A and that the execution of"},{"line_number":16,"context_line":"B must wait until A finished. Taskflow has a callback function to decide"},{"line_number":17,"context_line":"at runtime whether B should be allowed to execute. The callback function"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf659307_6e41fea8","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":50},"updated":"2018-04-03 13:47:44.000000000","message":"This is also true for Linear pattern in TaskFlow. I think that it should be noted that Graph flow, \"that used in Watcher\", or something like that.","commit_id":"a8b20e618e7920a64e5ea6cdd961925bee735244"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"0841564d10ca1a2e9f91a95afbf93d5fc940ac58","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/watcher/+spec/enhance-watcher-workflow-engine"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"`Taskflow`_ is the default workflow engine for Watcher Applier."},{"line_number":14,"context_line":"The flow pattern for linked actions is Graph flow. For parent action A"},{"line_number":15,"context_line":"and child action B, this means B depends on A and that the execution of"},{"line_number":16,"context_line":"B must wait until A finished. Taskflow has a callback function to decide"},{"line_number":17,"context_line":"at runtime whether B should be allowed to execute. The callback function"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf659307_1e92df57","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":50},"in_reply_to":"bf659307_6e41fea8","updated":"2018-04-04 05:40:34.000000000","message":"Done","commit_id":"a8b20e618e7920a64e5ea6cdd961925bee735244"},{"author":{"_account_id":27947,"name":"Egor Panfilov","email":"edpanfilov@sbcloud.ru","username":"erakli"},"change_message_id":"a640ddc68cb87f8da2b3febb9936ccd35a936c19","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"We want the callback function returns True or False depending on the"},{"line_number":26,"context_line":"result of previous action A execution. Action B should be executed"},{"line_number":27,"context_line":"unless action A failed. If action A executes success, The execution"},{"line_number":28,"context_line":"of action B should be ignored."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf659307_ce47ea76","line":28,"range":{"start_line":26,"start_character":39,"end_line":28,"end_character":30},"updated":"2018-04-03 13:47:44.000000000","message":"Previously, you wrote example with successive actions (lines 14-16), here you talking about parallel actions, where only one need to be finished. I\u0027m not sure that it\u0027s clear way of explanation.","commit_id":"a8b20e618e7920a64e5ea6cdd961925bee735244"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"0841564d10ca1a2e9f91a95afbf93d5fc940ac58","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"We want the callback function returns True or False depending on the"},{"line_number":26,"context_line":"result of previous action A execution. Action B should be executed"},{"line_number":27,"context_line":"unless action A failed. If action A executes success, The execution"},{"line_number":28,"context_line":"of action B should be ignored."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf659307_1e53bf6c","line":28,"range":{"start_line":26,"start_character":39,"end_line":28,"end_character":30},"in_reply_to":"bf659307_ce47ea76","updated":"2018-04-04 05:40:34.000000000","message":"Here still talking about linked actions, not parallel actions.\nI\u0027ll update the explanation.","commit_id":"a8b20e618e7920a64e5ea6cdd961925bee735244"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"46f01543169c9150fe69ba859769f4d77189b852","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"----------"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"For example, if we want to live migrate a VM, there are two potential"},{"line_number":34,"context_line":"target nodes and no more information to select one, we can make two"},{"line_number":35,"context_line":"actions for the two targets. If first action executes success, then"},{"line_number":36,"context_line":"the second action will be ignored. Otherwise continue to execute the"},{"line_number":37,"context_line":"second one."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf659307_fabaf76b","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":28},"updated":"2018-03-29 09:13:00.000000000","message":"at least workload_stabilization, basic_consolidation and some other strategies should be reworked to include more interchangeable actions. Is it True?","commit_id":"a8b20e618e7920a64e5ea6cdd961925bee735244"},{"author":{"_account_id":27947,"name":"Egor Panfilov","email":"edpanfilov@sbcloud.ru","username":"erakli"},"change_message_id":"a640ddc68cb87f8da2b3febb9936ccd35a936c19","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"----------"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"For example, if we want to live migrate a VM, there are two potential"},{"line_number":34,"context_line":"target nodes and no more information to select one, we can make two"},{"line_number":35,"context_line":"actions for the two targets. If first action executes success, then"},{"line_number":36,"context_line":"the second action will be ignored. Otherwise continue to execute the"},{"line_number":37,"context_line":"second one."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf659307_cc529313","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":28},"in_reply_to":"bf659307_0b0cffa2","updated":"2018-04-03 13:47:44.000000000","message":"You propose this option as default behavior for all strategies or as per-strategy option?","commit_id":"a8b20e618e7920a64e5ea6cdd961925bee735244"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"9e105ae9d8d72d739204a6337df96207f8ca7315","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"----------"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"For example, if we want to live migrate a VM, there are two potential"},{"line_number":34,"context_line":"target nodes and no more information to select one, we can make two"},{"line_number":35,"context_line":"actions for the two targets. If first action executes success, then"},{"line_number":36,"context_line":"the second action will be ignored. Otherwise continue to execute the"},{"line_number":37,"context_line":"second one."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf659307_19c3238b","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":28},"in_reply_to":"bf659307_b21a026c","updated":"2018-04-12 02:17:45.000000000","message":"I need to think about it again, maybe it\u0027s a good idea to set execution_rule based on strategy.","commit_id":"a8b20e618e7920a64e5ea6cdd961925bee735244"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"0841564d10ca1a2e9f91a95afbf93d5fc940ac58","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"----------"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"For example, if we want to live migrate a VM, there are two potential"},{"line_number":34,"context_line":"target nodes and no more information to select one, we can make two"},{"line_number":35,"context_line":"actions for the two targets. If first action executes success, then"},{"line_number":36,"context_line":"the second action will be ignored. Otherwise continue to execute the"},{"line_number":37,"context_line":"second one."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf659307_de48e7b3","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":28},"in_reply_to":"bf659307_cc529313","updated":"2018-04-04 05:40:34.000000000","message":"for all strategies","commit_id":"a8b20e618e7920a64e5ea6cdd961925bee735244"},{"author":{"_account_id":27947,"name":"Egor Panfilov","email":"edpanfilov@sbcloud.ru","username":"erakli"},"change_message_id":"8e3e3e75ee56af54e8a1ad1dc27be3605dc8ba21","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"----------"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"For example, if we want to live migrate a VM, there are two potential"},{"line_number":34,"context_line":"target nodes and no more information to select one, we can make two"},{"line_number":35,"context_line":"actions for the two targets. If first action executes success, then"},{"line_number":36,"context_line":"the second action will be ignored. Otherwise continue to execute the"},{"line_number":37,"context_line":"second one."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf659307_b21a026c","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":28},"in_reply_to":"bf659307_de48e7b3","updated":"2018-04-04 06:23:32.000000000","message":"So I continue question that asked Alexander. What if we set execution_rule to ANY in config but there still persist strategies that need rework, how we manage this situation? Do we need change these strategies?","commit_id":"a8b20e618e7920a64e5ea6cdd961925bee735244"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"b429ba5b63df2da51d30cdfe9ec18497ed7d88b5","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"----------"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"For example, if we want to live migrate a VM, there are two potential"},{"line_number":34,"context_line":"target nodes and no more information to select one, we can make two"},{"line_number":35,"context_line":"actions for the two targets. If first action executes success, then"},{"line_number":36,"context_line":"the second action will be ignored. Otherwise continue to execute the"},{"line_number":37,"context_line":"second one."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf659307_0b0cffa2","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":28},"in_reply_to":"bf659307_fabaf76b","updated":"2018-04-03 05:17:58.000000000","message":"Refer to \u0027Proposed change\u0027 section, we have a config option,\nby default the applier works as usual, so all the existing strategies aren\u0027t affected.But if execution_rule is ANY,\nwe need new strategy or update the existing strategy.","commit_id":"a8b20e618e7920a64e5ea6cdd961925bee735244"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"46f01543169c9150fe69ba859769f4d77189b852","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"For example, if we want to live migrate a VM, there are two potential"},{"line_number":34,"context_line":"target nodes and no more information to select one, we can make two"},{"line_number":35,"context_line":"actions for the two targets. If first action executes success, then"},{"line_number":36,"context_line":"the second action will be ignored. Otherwise continue to execute the"},{"line_number":37,"context_line":"second one."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf659307_dd0ccded","line":36,"range":{"start_line":35,"start_character":29,"end_line":36,"end_character":34},"updated":"2018-03-29 09:13:00.000000000","message":"Watcher Planner builds a graph model with actions as nodes. How do you plan to implement it in a graph context?","commit_id":"a8b20e618e7920a64e5ea6cdd961925bee735244"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"b429ba5b63df2da51d30cdfe9ec18497ed7d88b5","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"For example, if we want to live migrate a VM, there are two potential"},{"line_number":34,"context_line":"target nodes and no more information to select one, we can make two"},{"line_number":35,"context_line":"actions for the two targets. If first action executes success, then"},{"line_number":36,"context_line":"the second action will be ignored. Otherwise continue to execute the"},{"line_number":37,"context_line":"second one."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf659307_b17f8064","line":36,"range":{"start_line":35,"start_character":29,"end_line":36,"end_character":34},"in_reply_to":"bf659307_dd0ccded","updated":"2018-04-03 05:17:58.000000000","message":"It\u0027s based graph model, this feature is for linked actions.","commit_id":"a8b20e618e7920a64e5ea6cdd961925bee735244"},{"author":{"_account_id":27947,"name":"Egor Panfilov","email":"edpanfilov@sbcloud.ru","username":"erakli"},"change_message_id":"4be313d0790e2b4aa1e690a6526ff8cff1e2372b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"For example, we want to live migrate a VM, if there are two potential"},{"line_number":27,"context_line":"target nodes that meet the requirements. However, we don\u0027t know which"},{"line_number":28,"context_line":"one will definitely be able to migrate successfully. The existing"},{"line_number":29,"context_line":"strategy will select one to create a action and the action may fail"},{"line_number":30,"context_line":"if the destination node can\u0027t migrate VM."},{"line_number":31,"context_line":"A solution is that we can make two linked actions for the two"},{"line_number":32,"context_line":"potential targets. If first action succeeded, then the second action"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9f6a8fd7_7d7dd4af","line":29,"range":{"start_line":29,"start_character":35,"end_line":29,"end_character":43},"updated":"2018-04-17 20:13:09.000000000","message":"an action","commit_id":"46a3678d203561e23d3d38ef0c479ee554bdfca9"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"02bad8ff116194febcd3cf7ec3234483745c4972","unresolved":false,"context_lines":[{"line_number":26,"context_line":"For example, we want to live migrate a VM, if there are two potential"},{"line_number":27,"context_line":"target nodes that meet the requirements. However, we don\u0027t know which"},{"line_number":28,"context_line":"one will definitely be able to migrate successfully. The existing"},{"line_number":29,"context_line":"strategy will select one to create a action and the action may fail"},{"line_number":30,"context_line":"if the destination node can\u0027t migrate VM."},{"line_number":31,"context_line":"A solution is that we can make two linked actions for the two"},{"line_number":32,"context_line":"potential targets. If first action succeeded, then the second action"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9f6a8fd7_8d7b9579","line":29,"range":{"start_line":29,"start_character":35,"end_line":29,"end_character":43},"in_reply_to":"9f6a8fd7_7d7dd4af","updated":"2018-04-20 03:16:45.000000000","message":"Done","commit_id":"46a3678d203561e23d3d38ef0c479ee554bdfca9"},{"author":{"_account_id":27947,"name":"Egor Panfilov","email":"edpanfilov@sbcloud.ru","username":"erakli"},"change_message_id":"4be313d0790e2b4aa1e690a6526ff8cff1e2372b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"target nodes that meet the requirements. However, we don\u0027t know which"},{"line_number":28,"context_line":"one will definitely be able to migrate successfully. The existing"},{"line_number":29,"context_line":"strategy will select one to create a action and the action may fail"},{"line_number":30,"context_line":"if the destination node can\u0027t migrate VM."},{"line_number":31,"context_line":"A solution is that we can make two linked actions for the two"},{"line_number":32,"context_line":"potential targets. If first action succeeded, then the second action"},{"line_number":33,"context_line":"will be ignored. Otherwise continue to execute the second one."}],"source_content_type":"text/x-rst","patch_set":7,"id":"9f6a8fd7_9d2468c8","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":41},"updated":"2018-04-17 20:13:09.000000000","message":"Probably, you talk about failure of migration? Or there should be something like \"destination node can\u0027t accept VM\"?","commit_id":"46a3678d203561e23d3d38ef0c479ee554bdfca9"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"02bad8ff116194febcd3cf7ec3234483745c4972","unresolved":false,"context_lines":[{"line_number":27,"context_line":"target nodes that meet the requirements. However, we don\u0027t know which"},{"line_number":28,"context_line":"one will definitely be able to migrate successfully. The existing"},{"line_number":29,"context_line":"strategy will select one to create a action and the action may fail"},{"line_number":30,"context_line":"if the destination node can\u0027t migrate VM."},{"line_number":31,"context_line":"A solution is that we can make two linked actions for the two"},{"line_number":32,"context_line":"potential targets. If first action succeeded, then the second action"},{"line_number":33,"context_line":"will be ignored. Otherwise continue to execute the second one."}],"source_content_type":"text/x-rst","patch_set":7,"id":"9f6a8fd7_edefb11b","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":41},"in_reply_to":"9f6a8fd7_9d2468c8","updated":"2018-04-20 03:16:45.000000000","message":"Done","commit_id":"46a3678d203561e23d3d38ef0c479ee554bdfca9"},{"author":{"_account_id":27947,"name":"Egor Panfilov","email":"edpanfilov@sbcloud.ru","username":"erakli"},"change_message_id":"4be313d0790e2b4aa1e690a6526ff8cff1e2372b","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Now the callback function, named decider, always returns True. We propose"},{"line_number":50,"context_line":"to add a new config option \u0027action_execution_rule\u0027 which is a dict type."},{"line_number":51,"context_line":"Its key field is strategy name and the value is \u0027ALWAYS\u0027 or \u0027ANY\u0027."},{"line_number":52,"context_line":"\u0027ALWAYS\u0027 means the callback function returns True as usual."},{"line_number":53,"context_line":"\u0027ANY\u0027 means the return depends on the result of previous action execution."},{"line_number":54,"context_line":"The callback returns True if previous action gets failed, and the engine"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9f6a8fd7_98aeb6e5","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":30},"updated":"2018-04-17 20:13:09.000000000","message":"Why you decide to store this information as a separate option? Doesn\u0027t this option coupled with Strategy enough to add it as a class\u0027 property? \n\nI\u0027m not sure, is it right design approach, but I think it should highlighted.","commit_id":"46a3678d203561e23d3d38ef0c479ee554bdfca9"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"02bad8ff116194febcd3cf7ec3234483745c4972","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Now the callback function, named decider, always returns True. We propose"},{"line_number":50,"context_line":"to add a new config option \u0027action_execution_rule\u0027 which is a dict type."},{"line_number":51,"context_line":"Its key field is strategy name and the value is \u0027ALWAYS\u0027 or \u0027ANY\u0027."},{"line_number":52,"context_line":"\u0027ALWAYS\u0027 means the callback function returns True as usual."},{"line_number":53,"context_line":"\u0027ANY\u0027 means the return depends on the result of previous action execution."},{"line_number":54,"context_line":"The callback returns True if previous action gets failed, and the engine"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9f6a8fd7_2d1609f3","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":30},"in_reply_to":"9f6a8fd7_98aeb6e5","updated":"2018-04-20 03:16:45.000000000","message":"Workflow engine is selectable and separate from strategy. This feature is only for Taskflow workflow. I don\u0027t think it\u0027s a good idea to add this into strategy.","commit_id":"46a3678d203561e23d3d38ef0c479ee554bdfca9"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"3eb64d3ae8c019ae906b52e2fc35e929bcf4d120","unresolved":false,"context_lines":[{"line_number":47,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Now the callback function, named decider, always returns True. We propose"},{"line_number":50,"context_line":"to add a new config option \u0027action_execution_rule\u0027 which is a dict type."},{"line_number":51,"context_line":"Its key field is strategy name and the value is \u0027ALWAYS\u0027 or \u0027ANY\u0027."},{"line_number":52,"context_line":"\u0027ALWAYS\u0027 means the callback function returns True as usual."},{"line_number":53,"context_line":"\u0027ANY\u0027 means the return depends on the result of previous action execution."}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f6a8fd7_b602666e","line":50,"updated":"2018-04-20 07:10:21.000000000","message":"Is it necessary to expose this as a configuration option?\nIMHO configuration options are for users not developers,\nThis way if a developer has written strategy keeping ANY config option in mind and a user changed it to ALWAYS, the applier won\u0027t be able to execute it correctly.\nI think This options should be exposed internally via properties or some other thing.","commit_id":"c0b81d9a6a0e54ed6f1a508b5be69f5ed1b3920e"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"bb9274eeea52138224738091d8113ae26915a546","unresolved":false,"context_lines":[{"line_number":47,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Now the callback function, named decider, always returns True. We propose"},{"line_number":50,"context_line":"to add a new config option \u0027action_execution_rule\u0027 which is a dict type."},{"line_number":51,"context_line":"Its key field is strategy name and the value is \u0027ALWAYS\u0027 or \u0027ANY\u0027."},{"line_number":52,"context_line":"\u0027ALWAYS\u0027 means the callback function returns True as usual."},{"line_number":53,"context_line":"\u0027ANY\u0027 means the return depends on the result of previous action execution."}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_68ea820e","line":50,"in_reply_to":"5f7c97a3_67dcc3e0","updated":"2018-07-18 08:55:51.000000000","message":"ok, got it","commit_id":"c0b81d9a6a0e54ed6f1a508b5be69f5ed1b3920e"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"547b8789409c4a04f13ccd6db6a541e38b578623","unresolved":false,"context_lines":[{"line_number":47,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Now the callback function, named decider, always returns True. We propose"},{"line_number":50,"context_line":"to add a new config option \u0027action_execution_rule\u0027 which is a dict type."},{"line_number":51,"context_line":"Its key field is strategy name and the value is \u0027ALWAYS\u0027 or \u0027ANY\u0027."},{"line_number":52,"context_line":"\u0027ALWAYS\u0027 means the callback function returns True as usual."},{"line_number":53,"context_line":"\u0027ANY\u0027 means the return depends on the result of previous action execution."}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_67dcc3e0","line":50,"in_reply_to":"9f6a8fd7_b602666e","updated":"2018-06-13 08:39:03.000000000","message":"Yes, it is good that each strategy has it\u0027s property and applier engine gets them, but applier can not see properties of strategy. So we add a new config option like https://review.openstack.org/#/c/554765/6/watcher/applier/workflow_engine/default.py.","commit_id":"c0b81d9a6a0e54ed6f1a508b5be69f5ed1b3920e"}]}
