)]}'
{"id":"openstack%2Fwatcher-specs~653344","triplet_id":"openstack%2Fwatcher-specs~master~Ib88d1041dbb976a9c7a42b33114851f3ece37759","project":"openstack/watcher-specs","branch":"master","topic":"bp/formal-datasource-interface","hashtags":[],"change_id":"Ib88d1041dbb976a9c7a42b33114851f3ece37759","subject":"Formalize DataSourceBase interface","status":"MERGED","created":"2019-04-17 08:02:24.000000000","updated":"2019-04-30 07:28:53.000000000","submitted":"2019-04-30 07:28:53.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"653344-1556609333532-fc2ab011","meta_rev_id":"6e85a8bada446eef683e8faf357bc988d9fe5b80","_number":653344,"virtual_id_number":653344,"owner":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":5575,"name":"Jose Castro Leon","email":"jose.castro.leon@cern.ch","username":"jose-castro-leon"},{"value":0,"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},{"value":2,"date":"2019-04-30 07:28:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"all":[{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":5575,"name":"Jose Castro Leon","email":"jose.castro.leon@cern.ch","username":"jose-castro-leon"},{"value":0,"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-04-30 07:23:03.000000000","_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":2,"date":"2019-04-26 03:11:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"all":[{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":5575,"name":"Jose Castro Leon","email":"jose.castro.leon@cern.ch","username":"jose-castro-leon"},{"value":0,"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-04-30 07:23:03.000000000","_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":5575,"name":"Jose Castro Leon","email":"jose.castro.leon@cern.ch","username":"jose-castro-leon"},{"value":0,"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5575,"name":"Jose Castro Leon","email":"jose.castro.leon@cern.ch","username":"jose-castro-leon"},{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-17 08:12:52.000000000","updated_by":{"_account_id":5575,"name":"Jose Castro Leon","email":"jose.castro.leon@cern.ch","username":"jose-castro-leon"},"reviewer":{"_account_id":5575,"name":"Jose Castro Leon","email":"jose.castro.leon@cern.ch","username":"jose-castro-leon"},"state":"REVIEWER"},{"updated":"2019-04-17 08:12:57.000000000","updated_by":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"reviewer":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"state":"REVIEWER"},{"updated":"2019-04-26 03:11:39.000000000","updated_by":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"reviewer":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"state":"REVIEWER"},{"updated":"2019-04-30 07:23:03.000000000","updated_by":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"reviewer":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"state":"REVIEWER"},{"updated":"2019-04-30 07:28:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"fd079d4abb31298f6705c7cfaf45e9b520fcd163","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-04-17 08:02:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f5b02d6cf631312700db542a6871e927c7649262","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-17 08:28:08.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/44/653344/1/check/openstack-tox-docs/73fdce9/ : FAILURE in 6m 31s","accounts_in_message":[],"_revision_number":1},{"id":"b22d2797cc56281482bb5466943a323bc3b65476","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-04-17 08:31:03.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6c5dae841611d7cf684a56379b1a4703b1fc2e1e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-17 08:42:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/44/653344/2/check/openstack-tox-docs/768ab72/html/ : SUCCESS in 4m 51s","accounts_in_message":[],"_revision_number":2},{"id":"498f25ac3cd9dfdc4eafde0bea82bdffd10177e1","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-04-19 03:12:52.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"21e91cdac32d235c4fd04cf53146922d8ee324a6","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-04-19 14:00:46.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"3b5dbc6adcf7e7cf7eb79213a81d297854c799a4","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-04-19 14:07:13.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"3acfd6e3e142b9cb237372ab23bab1487d653afc","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-04-19 14:08:10.000000000","message":"Patch Set 4:\n\n(2 comments)\n\nI have added why the resource_type is needed to access relevant attributes from objects.","accounts_in_message":[],"_revision_number":4},{"id":"228bd5b1a49137e879fd8b72d2123d12ba9022f5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-19 14:15:02.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/44/653344/4/check/openstack-tox-docs/fe63a46/html/ : SUCCESS in 4m 54s","accounts_in_message":[],"_revision_number":4},{"id":"5758fdb60a12aa843eeb379db6f643d0f76a705e","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-04-25 06:48:06.000000000","message":"Patch Set 4: Code-Review+2\n\nLGTM, thanks!","accounts_in_message":[],"_revision_number":4},{"id":"1ccfc6d91780072ec8f4ca7a845102011563a34f","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-04-25 12:48:24.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"581173ffbd16cb62303fd2f763d1fbdb6c460e71","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-04-25 12:49:53.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"a7cf25efb6c26a3c5dcbd0d162dd52faa6944d93","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-04-25 15:54:51.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"b977617257d6e57b7c7616ea1b7a58a11f9256c5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-25 16:06:09.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/44/653344/5/check/openstack-tox-docs/f97e98d/html/ : SUCCESS in 4m 44s","accounts_in_message":[],"_revision_number":5},{"id":"cf38d468bbc0042f433ee8b92debeeb2d90efcc4","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-04-26 03:11:39.000000000","message":"Patch Set 5: Code-Review+2\n\nnice spec","accounts_in_message":[],"_revision_number":5},{"id":"776b2e28f4985876c30a6c817ebe4e123057ff9b","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-04-30 07:23:03.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":5},{"id":"afd700913d0b13eead368b70d50683a0ccac175c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-30 07:23:14.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"025ce9d0da8659bdd5f86d503e2a33b06bffaf53","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-30 07:28:53.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/44/653344/5/gate/openstack-tox-docs/a1cec83/html/ : SUCCESS in 4m 45s","accounts_in_message":[],"_revision_number":5},{"id":"4bb0e0c73e52d35744b274fe9b1713edc2a8c475","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-30 07:28:53.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"b4fafe6d16c17ec53e0e73305a5bc69e133f4dab","revisions":{"56c9731bd591820d33c3025e416061a690492a7b":{"kind":"REWORK","_number":1,"created":"2019-04-17 08:02:24.000000000","uploader":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"ref":"refs/changes/44/653344/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher-specs","ref":"refs/changes/44/653344/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher-specs refs/changes/44/653344/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher-specs refs/changes/44/653344/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher-specs refs/changes/44/653344/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher-specs refs/changes/44/653344/1"}}},"commit":{"parents":[{"commit":"8ebf6afb98e044fcdef187a2e11cd55da9e5e22a","subject":"Merge \"Add spec for file based metric map\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-specs/commit/8ebf6afb98e044fcdef187a2e11cd55da9e5e22a"}]}],"author":{"name":"Dantali0n","email":"info@dantalion.nl","date":"2019-04-17 07:26:36.000000000","tz":120},"committer":{"name":"Dantali0n","email":"info@dantalion.nl","date":"2019-04-17 07:26:36.000000000","tz":120},"subject":"Formalize DataSourceBase interface","message":"Formalize DataSourceBase interface\n\nThe methods of the DataSourceBase are changed to improve compatibility\nwith all the datasources. The parameters and their respected values\nwill be documented as well as the return types of methods.\n\nWith this changes the unit tests should be changed to match the new\ninterface accordingly.\n\nChange-Id: Ib88d1041dbb976a9c7a42b33114851f3ece37759\nImplements: blueprint formal-datasource-interface\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-specs/commit/56c9731bd591820d33c3025e416061a690492a7b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-specs/commit/56c9731bd591820d33c3025e416061a690492a7b"}]},"branch":"refs/heads/master"},"edba1ac85d4165f6cd09a4813742c19654dad33b":{"kind":"REWORK","_number":2,"created":"2019-04-17 08:31:03.000000000","uploader":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"ref":"refs/changes/44/653344/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher-specs","ref":"refs/changes/44/653344/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher-specs refs/changes/44/653344/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher-specs refs/changes/44/653344/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher-specs refs/changes/44/653344/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher-specs refs/changes/44/653344/2"}}},"commit":{"parents":[{"commit":"8ebf6afb98e044fcdef187a2e11cd55da9e5e22a","subject":"Merge \"Add spec for file based metric map\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-specs/commit/8ebf6afb98e044fcdef187a2e11cd55da9e5e22a"}]}],"author":{"name":"Dantali0n","email":"info@dantalion.nl","date":"2019-04-17 07:26:36.000000000","tz":120},"committer":{"name":"Dantali0n","email":"info@dantalion.nl","date":"2019-04-17 08:35:35.000000000","tz":120},"subject":"Formalize DataSourceBase interface","message":"Formalize DataSourceBase interface\n\nThe methods of the DataSourceBase are changed to improve compatibility\nwith all the datasources. The parameters and their respected values\nwill be documented as well as the return types of methods.\n\nWith this changes the unit tests should be changed to match the new\ninterface accordingly.\n\nChange-Id: Ib88d1041dbb976a9c7a42b33114851f3ece37759\nImplements: blueprint formal-datasource-interface\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-specs/commit/edba1ac85d4165f6cd09a4813742c19654dad33b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-specs/commit/edba1ac85d4165f6cd09a4813742c19654dad33b"}]},"branch":"refs/heads/master"},"b9a9a831da17a51481dadedc8d3fde4be78ddd08":{"kind":"REWORK","_number":3,"created":"2019-04-19 14:00:46.000000000","uploader":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"ref":"refs/changes/44/653344/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher-specs","ref":"refs/changes/44/653344/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher-specs refs/changes/44/653344/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher-specs refs/changes/44/653344/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher-specs refs/changes/44/653344/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher-specs refs/changes/44/653344/3"}}},"commit":{"parents":[{"commit":"8ebf6afb98e044fcdef187a2e11cd55da9e5e22a","subject":"Merge \"Add spec for file based metric map\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-specs/commit/8ebf6afb98e044fcdef187a2e11cd55da9e5e22a"}]}],"author":{"name":"Dantali0n","email":"info@dantalion.nl","date":"2019-04-17 07:26:36.000000000","tz":120},"committer":{"name":"Dantali0n","email":"info@dantalion.nl","date":"2019-04-19 14:05:08.000000000","tz":120},"subject":"Formalize DataSourceBase interface","message":"Formalize DataSourceBase interface\n\nThe methods of the DataSourceBase are changed to improve compatibility\nwith all the datasources. The parameters and their respected values\nwill be documented as well as the return types of methods.\n\nWith this changes the unit tests should be changed to match the new\ninterface accordingly.\n\nChange-Id: Ib88d1041dbb976a9c7a42b33114851f3ece37759\nImplements: blueprint formal-datasource-interface\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-specs/commit/b9a9a831da17a51481dadedc8d3fde4be78ddd08"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-specs/commit/b9a9a831da17a51481dadedc8d3fde4be78ddd08"}]},"branch":"refs/heads/master"},"694100d86bf8be6c1ac180f08d743e2e7ae89a2a":{"kind":"REWORK","_number":4,"created":"2019-04-19 14:07:13.000000000","uploader":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"ref":"refs/changes/44/653344/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher-specs","ref":"refs/changes/44/653344/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher-specs refs/changes/44/653344/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher-specs refs/changes/44/653344/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher-specs refs/changes/44/653344/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher-specs refs/changes/44/653344/4"}}},"commit":{"parents":[{"commit":"8ebf6afb98e044fcdef187a2e11cd55da9e5e22a","subject":"Merge \"Add spec for file based metric map\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-specs/commit/8ebf6afb98e044fcdef187a2e11cd55da9e5e22a"}]}],"author":{"name":"Dantali0n","email":"info@dantalion.nl","date":"2019-04-17 07:26:36.000000000","tz":120},"committer":{"name":"Dantali0n","email":"info@dantalion.nl","date":"2019-04-19 14:11:46.000000000","tz":120},"subject":"Formalize DataSourceBase interface","message":"Formalize DataSourceBase interface\n\nThe methods of the DataSourceBase are changed to improve compatibility\nwith all the datasources. The parameters and their respected values\nwill be documented as well as the return types of methods.\n\nWith this changes the unit tests should be changed to match the new\ninterface accordingly.\n\nChange-Id: Ib88d1041dbb976a9c7a42b33114851f3ece37759\nImplements: blueprint formal-datasource-interface\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-specs/commit/694100d86bf8be6c1ac180f08d743e2e7ae89a2a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-specs/commit/694100d86bf8be6c1ac180f08d743e2e7ae89a2a"}]},"branch":"refs/heads/master"},"b4fafe6d16c17ec53e0e73305a5bc69e133f4dab":{"kind":"REWORK","_number":5,"created":"2019-04-25 15:54:51.000000000","uploader":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"ref":"refs/changes/44/653344/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher-specs","ref":"refs/changes/44/653344/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher-specs refs/changes/44/653344/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher-specs refs/changes/44/653344/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher-specs refs/changes/44/653344/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher-specs refs/changes/44/653344/5"}}},"commit":{"parents":[{"commit":"8ebf6afb98e044fcdef187a2e11cd55da9e5e22a","subject":"Merge \"Add spec for file based metric map\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-specs/commit/8ebf6afb98e044fcdef187a2e11cd55da9e5e22a"}]}],"author":{"name":"Dantali0n","email":"info@dantalion.nl","date":"2019-04-17 07:26:36.000000000","tz":120},"committer":{"name":"Dantali0n","email":"info@dantalion.nl","date":"2019-04-25 15:54:42.000000000","tz":120},"subject":"Formalize DataSourceBase interface","message":"Formalize DataSourceBase interface\n\nThe methods of the DataSourceBase are changed to improve compatibility\nwith all the datasources. The parameters and their respected values\nwill be documented as well as the return types of methods.\n\nWith this changes the unit tests should be changed to match the new\ninterface accordingly.\n\nChange-Id: Ib88d1041dbb976a9c7a42b33114851f3ece37759\nImplements: blueprint formal-datasource-interface\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-specs/commit/b4fafe6d16c17ec53e0e73305a5bc69e133f4dab"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher-specs/commit/b4fafe6d16c17ec53e0e73305a5bc69e133f4dab"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}