)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"590916a0802b7caaa121731a3ae3475804444735","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d976b9da_d1603a59","updated":"2024-10-28 21:03:36.000000000","message":"Marios, thanks for getting this spec lais out. Some comments in line.","commit_id":"53a6be28ce915aeebb467d0283c577d8d1e6ee71"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"61eb1fb79f082e1a73d5e012a07fd978d3413d9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"435d5edc_e2cd5a3b","updated":"2024-10-30 10:17:58.000000000","message":"thanks for the review Dan, I am sending v4 with updates for your comments please have a look again when you next have time","commit_id":"3be576d9b5c804adc68ef715dc6a7cfff1b5608a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"90330f353b8b7d7441c35b4ef40d79122e4058d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c08402ed_6ec43048","updated":"2024-10-31 15:41:17.000000000","message":"No need to respin just to remove me from the assignees list, but if you do respin for another reason, it might be good.\n\nHoping @chenker will be able to have a look at this. In the meantime, I think it\u0027s worth getting started on PoC code at least.\n\nThanks Marios!","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"52f041f0e77e29db37234efc9373b3219e9a0813","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fcfee328_392f877a","updated":"2024-11-01 10:54:12.000000000","message":"Thanks for the review and all the suggestions Sean o/\n\nplease have another look when you next have time for reviews","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a1fd82d844d98bd88ae48bec76fea77a8c9eaf2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1380002f_f4c7d294","updated":"2024-10-31 18:44:47.000000000","message":"overall im happy with the content but i have done some wordsmith to reformat it into how i would expect to present this in a nova spec.","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"931cf403b31810a95f8d38314b20bd1e3d973813","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6ef6941b_4d773d88","updated":"2024-11-04 19:34:02.000000000","message":"Still LGTM","commit_id":"fe6895c7c227a071717d84250cb1edaf846a11e6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"25bbd1f27c9545afedabf708de56d97c0567f149","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"827dd13b_41652c48","updated":"2024-11-04 19:25:28.000000000","message":"i think im largely happy with this proposal\nwe could ad a little more detail but i think at this point i think we need to start POCing the work to in form any gaps we may have in the spec.\n\nwhile we wait for feedback form @chenker on the direction of this proposal i think we shoudl start on the workitmes using the \"prometheus-datasource\" topic in gerrit.\n\nthere are a number of parallel paths that can be taken such as adding support for deploying prometheus and node-exportor in devstack.\n\nwe may be able to levergae\nhttps://github.com/infrawatch/sg-core/blob/master/devstack/plugin.sh\n\nim a little reluctant to do that given its not an openstack deliverable however\nthe sg-core proejct is the upstream of the compoent we use in redhat to forward ceilometer metrics to prometius and it is tested in teh ceilometer repo jobs\nvia the telemetry tempest plugin repo.\n\nhttps://github.com/openstack/telemetry-tempest-plugin/blob/master/.zuul.yaml#L2-L53\n\nso we can start a parallel conversation with the openstack telemetry team about how best to enable prometheus in upstream devstack and wether or not sg core is applicable to the watcher prometheus integration work.","commit_id":"fe6895c7c227a071717d84250cb1edaf846a11e6"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"d3611d400db1765fea9cdb75e8fbbb74c03899c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"14fcd826_b9839f58","updated":"2024-11-18 08:01:37.000000000","message":"seems we can merged this.","commit_id":"fe6895c7c227a071717d84250cb1edaf846a11e6"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"18373d06b6dd621424709d8517efa4c8023dbed6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9d8622fb_fec93ae9","in_reply_to":"827dd13b_41652c48","updated":"2024-11-04 19:32:19.000000000","message":"Agree. Thanks","commit_id":"fe6895c7c227a071717d84250cb1edaf846a11e6"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c75db3569e10e9e2b45a469772748eae85938c10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d9b4a684_4cb5e2bd","in_reply_to":"9d8622fb_fec93ae9","updated":"2024-11-11 08:35:06.000000000","message":"thanks for reviews. fyi i have posted the wip for the implementation of this spec at https://review.opendev.org/c/openstack/watcher/+/934423","commit_id":"fe6895c7c227a071717d84250cb1edaf846a11e6"}],"specs/2025.1/approved/prometheus-datasource.rst":[{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"590916a0802b7caaa121731a3ae3475804444735","unresolved":true,"context_lines":[{"line_number":22,"context_line":"\u0027native\u0027 as both are CNCF projects and Prometheus is included as part of"},{"line_number":23,"context_line":"Kubernetes distributions."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Adding the ability for watcher to interact with a Prometheus data source"},{"line_number":26,"context_line":"will increase the potential user base for Watcher and especially to those"},{"line_number":27,"context_line":"operators that are familiar with or already using Prometheus."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7b0b25bd_428a0271","line":25,"updated":"2024-10-28 21:03:36.000000000","message":"Looks like you have Capitalized in other places - we should be consistent \u0027Watcher\u0027.","commit_id":"53a6be28ce915aeebb467d0283c577d8d1e6ee71"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9ad92db25d868bdbe17f2ac675eebd07de5da9f8","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u0027native\u0027 as both are CNCF projects and Prometheus is included as part of"},{"line_number":23,"context_line":"Kubernetes distributions."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Adding the ability for watcher to interact with a Prometheus data source"},{"line_number":26,"context_line":"will increase the potential user base for Watcher and especially to those"},{"line_number":27,"context_line":"operators that are familiar with or already using Prometheus."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"0eb39cb7_0cc6448a","line":25,"in_reply_to":"7b0b25bd_428a0271","updated":"2024-10-29 11:14:46.000000000","message":"Acknowledged","commit_id":"53a6be28ce915aeebb467d0283c577d8d1e6ee71"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"590916a0802b7caaa121731a3ae3475804444735","unresolved":true,"context_lines":[{"line_number":33,"context_line":"metrics: Ceilometer, Gnocchi and Grafana. Prometheus is a widely adopted"},{"line_number":34,"context_line":"metric collection system that fetches and stores time/series tagged data from"},{"line_number":35,"context_line":"exposed metrics API endpoints (prometheus \u0027targets\u0027). Besides being able to"},{"line_number":36,"context_line":"expose any arbitrary metric an operator cares to setup, the scraped \u0027targets\u0027"},{"line_number":37,"context_line":"are simple HTTP endpoints and so the backend implementation of those can be in"},{"line_number":38,"context_line":"any language/platform. This extensibility is one of the reasons for Prometheus"},{"line_number":39,"context_line":"popularity."}],"source_content_type":"text/x-rst","patch_set":1,"id":"66d532bf_f282d989","line":36,"updated":"2024-10-28 21:03:36.000000000","message":"set up","commit_id":"53a6be28ce915aeebb467d0283c577d8d1e6ee71"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9ad92db25d868bdbe17f2ac675eebd07de5da9f8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"metrics: Ceilometer, Gnocchi and Grafana. Prometheus is a widely adopted"},{"line_number":34,"context_line":"metric collection system that fetches and stores time/series tagged data from"},{"line_number":35,"context_line":"exposed metrics API endpoints (prometheus \u0027targets\u0027). Besides being able to"},{"line_number":36,"context_line":"expose any arbitrary metric an operator cares to setup, the scraped \u0027targets\u0027"},{"line_number":37,"context_line":"are simple HTTP endpoints and so the backend implementation of those can be in"},{"line_number":38,"context_line":"any language/platform. This extensibility is one of the reasons for Prometheus"},{"line_number":39,"context_line":"popularity."}],"source_content_type":"text/x-rst","patch_set":1,"id":"77f403c9_42fe560f","line":36,"in_reply_to":"66d532bf_f282d989","updated":"2024-10-29 11:14:46.000000000","message":"Acknowledged","commit_id":"53a6be28ce915aeebb467d0283c577d8d1e6ee71"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"590916a0802b7caaa121731a3ae3475804444735","unresolved":true,"context_lines":[{"line_number":35,"context_line":"exposed metrics API endpoints (prometheus \u0027targets\u0027). Besides being able to"},{"line_number":36,"context_line":"expose any arbitrary metric an operator cares to setup, the scraped \u0027targets\u0027"},{"line_number":37,"context_line":"are simple HTTP endpoints and so the backend implementation of those can be in"},{"line_number":38,"context_line":"any language/platform. This extensibility is one of the reasons for Prometheus"},{"line_number":39,"context_line":"popularity."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"By providing the ability to couple the efficient and highly customizable"}],"source_content_type":"text/x-rst","patch_set":1,"id":"68742926_fb807847","line":38,"updated":"2024-10-28 21:03:36.000000000","message":"Prometheus\u0027s","commit_id":"53a6be28ce915aeebb467d0283c577d8d1e6ee71"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9ad92db25d868bdbe17f2ac675eebd07de5da9f8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"exposed metrics API endpoints (prometheus \u0027targets\u0027). Besides being able to"},{"line_number":36,"context_line":"expose any arbitrary metric an operator cares to setup, the scraped \u0027targets\u0027"},{"line_number":37,"context_line":"are simple HTTP endpoints and so the backend implementation of those can be in"},{"line_number":38,"context_line":"any language/platform. This extensibility is one of the reasons for Prometheus"},{"line_number":39,"context_line":"popularity."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"By providing the ability to couple the efficient and highly customizable"}],"source_content_type":"text/x-rst","patch_set":1,"id":"43ef7799_e972cc64","line":38,"in_reply_to":"68742926_fb807847","updated":"2024-10-29 11:14:46.000000000","message":"Acknowledged","commit_id":"53a6be28ce915aeebb467d0283c577d8d1e6ee71"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"590916a0802b7caaa121731a3ae3475804444735","unresolved":true,"context_lines":[{"line_number":53,"context_line":"Proposed change"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Will need to add the Prometheus client and mappings for the collected data."},{"line_number":57,"context_line":"Devstack integration for the prometheus collector (enable_plugin watcher_prometheus)"},{"line_number":58,"context_line":"As a first implementation, it is not expected that we would extend the DataSource"},{"line_number":59,"context_line":"METRIC_MAP beyond the existing set (host/instance cpu/ram etc). That could be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3d8c8bca_cb9ed044","line":56,"updated":"2024-10-28 21:03:36.000000000","message":"We will","commit_id":"53a6be28ce915aeebb467d0283c577d8d1e6ee71"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9ad92db25d868bdbe17f2ac675eebd07de5da9f8","unresolved":false,"context_lines":[{"line_number":53,"context_line":"Proposed change"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Will need to add the Prometheus client and mappings for the collected data."},{"line_number":57,"context_line":"Devstack integration for the prometheus collector (enable_plugin watcher_prometheus)"},{"line_number":58,"context_line":"As a first implementation, it is not expected that we would extend the DataSource"},{"line_number":59,"context_line":"METRIC_MAP beyond the existing set (host/instance cpu/ram etc). That could be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6f82f78b_953ab31f","line":56,"in_reply_to":"3d8c8bca_cb9ed044","updated":"2024-10-29 11:14:46.000000000","message":"Acknowledged","commit_id":"53a6be28ce915aeebb467d0283c577d8d1e6ee71"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"590916a0802b7caaa121731a3ae3475804444735","unresolved":true,"context_lines":[{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Will need to add the Prometheus client and mappings for the collected data."},{"line_number":57,"context_line":"Devstack integration for the prometheus collector (enable_plugin watcher_prometheus)"},{"line_number":58,"context_line":"As a first implementation, it is not expected that we would extend the DataSource"},{"line_number":59,"context_line":"METRIC_MAP beyond the existing set (host/instance cpu/ram etc). That could be"},{"line_number":60,"context_line":"considered as future work depending on the success of this proposal."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9d8fa02a_6bb05e6b","line":57,"updated":"2024-10-28 21:03:36.000000000","message":"Prometheus","commit_id":"53a6be28ce915aeebb467d0283c577d8d1e6ee71"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9ad92db25d868bdbe17f2ac675eebd07de5da9f8","unresolved":false,"context_lines":[{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Will need to add the Prometheus client and mappings for the collected data."},{"line_number":57,"context_line":"Devstack integration for the prometheus collector (enable_plugin watcher_prometheus)"},{"line_number":58,"context_line":"As a first implementation, it is not expected that we would extend the DataSource"},{"line_number":59,"context_line":"METRIC_MAP beyond the existing set (host/instance cpu/ram etc). That could be"},{"line_number":60,"context_line":"considered as future work depending on the success of this proposal."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7c8941e0_542202cf","line":57,"in_reply_to":"9d8fa02a_6bb05e6b","updated":"2024-10-29 11:14:46.000000000","message":"Acknowledged","commit_id":"53a6be28ce915aeebb467d0283c577d8d1e6ee71"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"590916a0802b7caaa121731a3ae3475804444735","unresolved":true,"context_lines":[{"line_number":94,"context_line":"Other end user impact"},{"line_number":95,"context_line":"---------------------"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Users can leverage Prometheus as datasource for Watcher deployments."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Performance Impact"},{"line_number":100,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b2ef997a_d354ff9f","line":97,"updated":"2024-10-28 21:03:36.000000000","message":"Is this other impact - its the main impact?","commit_id":"53a6be28ce915aeebb467d0283c577d8d1e6ee71"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9ad92db25d868bdbe17f2ac675eebd07de5da9f8","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Other end user impact"},{"line_number":95,"context_line":"---------------------"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Users can leverage Prometheus as datasource for Watcher deployments."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Performance Impact"},{"line_number":100,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"35d201ec_f7f0f255","line":97,"in_reply_to":"b2ef997a_d354ff9f","updated":"2024-10-29 11:14:46.000000000","message":"ack lets remove this altogether","commit_id":"53a6be28ce915aeebb467d0283c577d8d1e6ee71"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"590916a0802b7caaa121731a3ae3475804444735","unresolved":true,"context_lines":[{"line_number":119,"context_line":"Assignee(s)"},{"line_number":120,"context_line":"-----------"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Sean, Marios, who else here?"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Work Items"},{"line_number":125,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9e6c6282_042dbcdd","line":122,"updated":"2024-10-28 21:03:36.000000000","message":"Dan, Martin - were added to the DPL list: https://review.opendev.org/c/openstack/governance/+/933018/4/reference/projects.yaml","commit_id":"53a6be28ce915aeebb467d0283c577d8d1e6ee71"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9ad92db25d868bdbe17f2ac675eebd07de5da9f8","unresolved":true,"context_lines":[{"line_number":119,"context_line":"Assignee(s)"},{"line_number":120,"context_line":"-----------"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Sean, Marios, who else here?"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Work Items"},{"line_number":125,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a4cc4ef2_78d2b04f","line":122,"in_reply_to":"9e6c6282_042dbcdd","updated":"2024-10-29 11:14:46.000000000","message":"sure but this is more like who is interested and wants to work on this in particular. I\u0027ll add those names but it would be better if the people themselves ack that (obviously they may not be aware of this spec)","commit_id":"53a6be28ce915aeebb467d0283c577d8d1e6ee71"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"590916a0802b7caaa121731a3ae3475804444735","unresolved":true,"context_lines":[{"line_number":133,"context_line":"the Prometheus instance under"},{"line_number":134,"context_line":"[conf](https://github.com/openstack/watcher/tree/master/watcher/conf)."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"* Extend devstack to setup prometheus as a data source for watcher."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Dependencies"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b12c6b9b_d744c947","line":136,"updated":"2024-10-28 21:03:36.000000000","message":"Tempest extension/work?","commit_id":"53a6be28ce915aeebb467d0283c577d8d1e6ee71"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0f908e9932c6c3bf457f7d42a7d0d5347c89bf6a","unresolved":false,"context_lines":[{"line_number":133,"context_line":"the Prometheus instance under"},{"line_number":134,"context_line":"[conf](https://github.com/openstack/watcher/tree/master/watcher/conf)."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"* Extend devstack to setup prometheus as a data source for watcher."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Dependencies"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9d442ac0_8294196d","line":136,"in_reply_to":"b12c6b9b_d744c947","updated":"2024-10-30 14:40:16.000000000","message":"Done","commit_id":"53a6be28ce915aeebb467d0283c577d8d1e6ee71"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"590916a0802b7caaa121731a3ae3475804444735","unresolved":true,"context_lines":[{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"The devstack integration that is part of this proposal should be utilized in a"},{"line_number":151,"context_line":"CI job against the watcher code repo."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Documentation Impact"},{"line_number":154,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f09b1cc_c88da633","line":151,"updated":"2024-10-28 21:03:36.000000000","message":"Worth mentioning Tempest here?","commit_id":"53a6be28ce915aeebb467d0283c577d8d1e6ee71"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9ad92db25d868bdbe17f2ac675eebd07de5da9f8","unresolved":true,"context_lines":[{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"The devstack integration that is part of this proposal should be utilized in a"},{"line_number":151,"context_line":"CI job against the watcher code repo."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Documentation Impact"},{"line_number":154,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"db686ea0_246bb184","line":151,"in_reply_to":"3f09b1cc_c88da633","updated":"2024-10-29 11:14:46.000000000","message":"ack","commit_id":"53a6be28ce915aeebb467d0283c577d8d1e6ee71"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0f908e9932c6c3bf457f7d42a7d0d5347c89bf6a","unresolved":false,"context_lines":[{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"The devstack integration that is part of this proposal should be utilized in a"},{"line_number":151,"context_line":"CI job against the watcher code repo."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Documentation Impact"},{"line_number":154,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6a2a961c_027f5868","line":151,"in_reply_to":"db686ea0_246bb184","updated":"2024-10-30 14:40:16.000000000","message":"Done","commit_id":"53a6be28ce915aeebb467d0283c577d8d1e6ee71"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8d684e39c4a42f71d016c7fc9a107f2cb593f921","unresolved":true,"context_lines":[{"line_number":53,"context_line":"Proposed change"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"We will need to add the Prometheus client and mappings for the collected data."},{"line_number":57,"context_line":"This work aims to also address the Devstack integration for the Prometheus"},{"line_number":58,"context_line":"collector (e.g., \"enable_plugin watcher_prometheus\" in devstack local.conf)."},{"line_number":59,"context_line":"As a first implementation, we are note expecting to extend the DataSource"}],"source_content_type":"text/x-rst","patch_set":3,"id":"534091a1_8975a532","line":56,"updated":"2024-10-29 14:37:41.000000000","message":"Python client? Is that already in our global requirements? I was thinking that one of the benefits of prometheus was an easy-to-consume API that would be suitable for just using something like `requests`, no? Or are you referencing just adding an internal client class type thing?","commit_id":"3be576d9b5c804adc68ef715dc6a7cfff1b5608a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0f908e9932c6c3bf457f7d42a7d0d5347c89bf6a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"Proposed change"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"We will need to add the Prometheus client and mappings for the collected data."},{"line_number":57,"context_line":"This work aims to also address the Devstack integration for the Prometheus"},{"line_number":58,"context_line":"collector (e.g., \"enable_plugin watcher_prometheus\" in devstack local.conf)."},{"line_number":59,"context_line":"As a first implementation, we are note expecting to extend the DataSource"}],"source_content_type":"text/x-rst","patch_set":3,"id":"0082698a_13222e72","line":56,"in_reply_to":"251ba903_0fa043f3","updated":"2024-10-30 14:40:16.000000000","message":"Acknowledged","commit_id":"3be576d9b5c804adc68ef715dc6a7cfff1b5608a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"61eb1fb79f082e1a73d5e012a07fd978d3413d9f","unresolved":true,"context_lines":[{"line_number":53,"context_line":"Proposed change"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"We will need to add the Prometheus client and mappings for the collected data."},{"line_number":57,"context_line":"This work aims to also address the Devstack integration for the Prometheus"},{"line_number":58,"context_line":"collector (e.g., \"enable_plugin watcher_prometheus\" in devstack local.conf)."},{"line_number":59,"context_line":"As a first implementation, we are note expecting to extend the DataSource"}],"source_content_type":"text/x-rst","patch_set":3,"id":"251ba903_0fa043f3","line":56,"in_reply_to":"534091a1_8975a532","updated":"2024-10-30 10:17:58.000000000","message":"yeah i was referring to \"internal client class type thing\" - the thing we\u0027ll use to talk to the prometheus API - for example under https://github.com/openstack/watcher/tree/master/watcher/conf there is grafana_client.py and others","commit_id":"3be576d9b5c804adc68ef715dc6a7cfff1b5608a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8d684e39c4a42f71d016c7fc9a107f2cb593f921","unresolved":true,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"We will need to add the Prometheus client and mappings for the collected data."},{"line_number":57,"context_line":"This work aims to also address the Devstack integration for the Prometheus"},{"line_number":58,"context_line":"collector (e.g., \"enable_plugin watcher_prometheus\" in devstack local.conf)."},{"line_number":59,"context_line":"As a first implementation, we are note expecting to extend the DataSource"},{"line_number":60,"context_line":"METRIC_MAP beyond the existing set (host/instance cpu/ram etc). That could be"},{"line_number":61,"context_line":"considered as future work depending on the success of this proposal."}],"source_content_type":"text/x-rst","patch_set":3,"id":"03c396c8_f391663d","line":58,"updated":"2024-10-29 14:37:41.000000000","message":"So create a new devstack plugin called `watcher_prometheus`? I also thought Sean had indicated that it was really as simple as installing the distro package and enabling the service and I thought in the PTG session we discussed just doing that in base devstack. Martin seemed to agree with that. Is this a departure and for some reason?","commit_id":"3be576d9b5c804adc68ef715dc6a7cfff1b5608a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"61eb1fb79f082e1a73d5e012a07fd978d3413d9f","unresolved":true,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"We will need to add the Prometheus client and mappings for the collected data."},{"line_number":57,"context_line":"This work aims to also address the Devstack integration for the Prometheus"},{"line_number":58,"context_line":"collector (e.g., \"enable_plugin watcher_prometheus\" in devstack local.conf)."},{"line_number":59,"context_line":"As a first implementation, we are note expecting to extend the DataSource"},{"line_number":60,"context_line":"METRIC_MAP beyond the existing set (host/instance cpu/ram etc). That could be"},{"line_number":61,"context_line":"considered as future work depending on the success of this proposal."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5b88ac0d_62bbdb77","line":58,"in_reply_to":"03c396c8_f391663d","updated":"2024-10-30 10:17:58.000000000","message":"so mostly yes the devstack setup worked for me too - though there is some work needed around dependencies to enable the horizon bits (`enable_plugin watcher-dashboard` is broken).\n\nthinking about this some more though I think you\u0027re right; at the devstack level the plugin will be just to enable watcher. Any needed configuration values/username/pass etc to setup the prometheus collector backend will come from the watcher service config itself, not via devstack. \n\nI\u0027ll reword or possibly remove this bit","commit_id":"3be576d9b5c804adc68ef715dc6a7cfff1b5608a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"444f8d7291c7019d07745da83b3584aa6479de89","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"We will need to add the Prometheus client and mappings for the collected data."},{"line_number":57,"context_line":"This work aims to also address the Devstack integration for the Prometheus"},{"line_number":58,"context_line":"collector (e.g., \"enable_plugin watcher_prometheus\" in devstack local.conf)."},{"line_number":59,"context_line":"As a first implementation, we are note expecting to extend the DataSource"},{"line_number":60,"context_line":"METRIC_MAP beyond the existing set (host/instance cpu/ram etc). That could be"},{"line_number":61,"context_line":"considered as future work depending on the success of this proposal."}],"source_content_type":"text/x-rst","patch_set":3,"id":"dd3a0e6f_016fb20d","line":58,"in_reply_to":"3403f345_dd269ecb","updated":"2024-10-31 10:40:30.000000000","message":"Acknowledged","commit_id":"3be576d9b5c804adc68ef715dc6a7cfff1b5608a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0f908e9932c6c3bf457f7d42a7d0d5347c89bf6a","unresolved":true,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"We will need to add the Prometheus client and mappings for the collected data."},{"line_number":57,"context_line":"This work aims to also address the Devstack integration for the Prometheus"},{"line_number":58,"context_line":"collector (e.g., \"enable_plugin watcher_prometheus\" in devstack local.conf)."},{"line_number":59,"context_line":"As a first implementation, we are note expecting to extend the DataSource"},{"line_number":60,"context_line":"METRIC_MAP beyond the existing set (host/instance cpu/ram etc). That could be"},{"line_number":61,"context_line":"considered as future work depending on the success of this proposal."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3403f345_dd269ecb","line":58,"in_reply_to":"5b88ac0d_62bbdb77","updated":"2024-10-30 14:40:16.000000000","message":"Cool, but to be clear: I think there *is* devstack work to do, I just think it need not be in a new/separate plugin. Since you\u0027re going to respin this for something else, I think you should just add something to the work items like:\n\n- Make watcher/devstack plugin able to deploy prometheus instead of gnocchi/ceilometer","commit_id":"3be576d9b5c804adc68ef715dc6a7cfff1b5608a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8d684e39c4a42f71d016c7fc9a107f2cb593f921","unresolved":true,"context_lines":[{"line_number":56,"context_line":"We will need to add the Prometheus client and mappings for the collected data."},{"line_number":57,"context_line":"This work aims to also address the Devstack integration for the Prometheus"},{"line_number":58,"context_line":"collector (e.g., \"enable_plugin watcher_prometheus\" in devstack local.conf)."},{"line_number":59,"context_line":"As a first implementation, we are note expecting to extend the DataSource"},{"line_number":60,"context_line":"METRIC_MAP beyond the existing set (host/instance cpu/ram etc). That could be"},{"line_number":61,"context_line":"considered as future work depending on the success of this proposal."},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"8c077225_efedd410","line":59,"range":{"start_line":59,"start_character":34,"end_line":59,"end_character":38},"updated":"2024-10-29 14:37:41.000000000","message":"\"not\" ?","commit_id":"3be576d9b5c804adc68ef715dc6a7cfff1b5608a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"61eb1fb79f082e1a73d5e012a07fd978d3413d9f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"We will need to add the Prometheus client and mappings for the collected data."},{"line_number":57,"context_line":"This work aims to also address the Devstack integration for the Prometheus"},{"line_number":58,"context_line":"collector (e.g., \"enable_plugin watcher_prometheus\" in devstack local.conf)."},{"line_number":59,"context_line":"As a first implementation, we are note expecting to extend the DataSource"},{"line_number":60,"context_line":"METRIC_MAP beyond the existing set (host/instance cpu/ram etc). That could be"},{"line_number":61,"context_line":"considered as future work depending on the success of this proposal."},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"77c51817_2d40c8fa","line":59,"range":{"start_line":59,"start_character":34,"end_line":59,"end_character":38},"in_reply_to":"8c077225_efedd410","updated":"2024-10-30 10:17:58.000000000","message":"Acknowledged","commit_id":"3be576d9b5c804adc68ef715dc6a7cfff1b5608a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8d684e39c4a42f71d016c7fc9a107f2cb593f921","unresolved":true,"context_lines":[{"line_number":133,"context_line":"    [conf](https://github.com/openstack/watcher/tree/master/watcher/conf),"},{"line_number":134,"context_line":"  * Extend devstack to setup Prometheus as a data source for Watcher,"},{"line_number":135,"context_line":"  * Extend the scenario/client testing for the Prometheus integration"},{"line_number":136,"context_line":"    ([watcher-tempest-plugin](https://github.com/openstack/watcher-tempest-plugin))."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Dependencies"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"41aadb75_336d7806","line":136,"updated":"2024-10-29 14:37:41.000000000","message":"Can you add the zuul job mentioned below to this list? I consider that part of the \"definition of done\" and it\u0027s easier to check things off a list if it\u0027s complete.","commit_id":"3be576d9b5c804adc68ef715dc6a7cfff1b5608a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0f908e9932c6c3bf457f7d42a7d0d5347c89bf6a","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    [conf](https://github.com/openstack/watcher/tree/master/watcher/conf),"},{"line_number":134,"context_line":"  * Extend devstack to setup Prometheus as a data source for Watcher,"},{"line_number":135,"context_line":"  * Extend the scenario/client testing for the Prometheus integration"},{"line_number":136,"context_line":"    ([watcher-tempest-plugin](https://github.com/openstack/watcher-tempest-plugin))."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Dependencies"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"8df9f1a4_dffee927","line":136,"in_reply_to":"3a44f931_b947b57a","updated":"2024-10-30 14:40:16.000000000","message":"Right, I was just asking for \"a new job with watcher configured for prometheus instead of gnocchi/ceilometer\". I think what you added is good enough.","commit_id":"3be576d9b5c804adc68ef715dc6a7cfff1b5608a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"61eb1fb79f082e1a73d5e012a07fd978d3413d9f","unresolved":true,"context_lines":[{"line_number":133,"context_line":"    [conf](https://github.com/openstack/watcher/tree/master/watcher/conf),"},{"line_number":134,"context_line":"  * Extend devstack to setup Prometheus as a data source for Watcher,"},{"line_number":135,"context_line":"  * Extend the scenario/client testing for the Prometheus integration"},{"line_number":136,"context_line":"    ([watcher-tempest-plugin](https://github.com/openstack/watcher-tempest-plugin))."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Dependencies"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a44f931_b947b57a","line":136,"in_reply_to":"41aadb75_336d7806","updated":"2024-10-30 10:17:58.000000000","message":"there is no job currently that tests deploying watcher and prometheus and setting them up to talk to each other.\ni was thinking something along the lines of [watcher-tempest-strategies](https://zuul.opendev.org/t/openstack/builds?job_name\u003dwatcher-tempest-strategies\u0026project\u003dopenstack/watcher) but with the setup including prometheus\n\nfor the watcher-tempest-plugin I am not sure and only added/looked at this after review comments here. looking at the existing jobs like [watcherclient-tempest-functional](https://zuul.opendev.org/t/openstack/builds?job_name\u003dwatcherclient-tempest-functional\u0026project\u003dopenstack/watcher) they seem to only exercise the API get/show functions currently e.g. https://a65de62f895e9b75f152-d7c64d5cc1a44543d079c27b7a0817ec.ssl.cf1.rackcdn.com/932963/5/check/watcherclient-tempest-functional/e1af2c4/testr_results.html \n\nPerhaps the watcher-tempest-plugin is not really a valid concern here, but adding testing for the integration with the new data source should be I think? Which would mean a new zuul job.","commit_id":"3be576d9b5c804adc68ef715dc6a7cfff1b5608a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8d684e39c4a42f71d016c7fc9a107f2cb593f921","unresolved":true,"context_lines":[{"line_number":150,"context_line":"The devstack integration that is part of this proposal should be utilized in a"},{"line_number":151,"context_line":"CI job against the Watcher code repo. Another consideration is to expand the"},{"line_number":152,"context_line":"[watcher-tempest-plugin](https://github.com/openstack/watcher-tempest-plugin)"},{"line_number":153,"context_line":"to add appropriate scenario testing the Watcher and Prometheus integration."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Documentation Impact"},{"line_number":156,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"158be524_79f6a460","line":153,"updated":"2024-10-29 14:37:41.000000000","message":"What tempest changes would there be? I wouldn\u0027t expect that tempest would know/care or even be able to tell what backend data sources are being used for a given action.","commit_id":"3be576d9b5c804adc68ef715dc6a7cfff1b5608a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"61eb1fb79f082e1a73d5e012a07fd978d3413d9f","unresolved":true,"context_lines":[{"line_number":150,"context_line":"The devstack integration that is part of this proposal should be utilized in a"},{"line_number":151,"context_line":"CI job against the Watcher code repo. Another consideration is to expand the"},{"line_number":152,"context_line":"[watcher-tempest-plugin](https://github.com/openstack/watcher-tempest-plugin)"},{"line_number":153,"context_line":"to add appropriate scenario testing the Watcher and Prometheus integration."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Documentation Impact"},{"line_number":156,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"67b8d561_582268ac","line":153,"in_reply_to":"158be524_79f6a460","updated":"2024-10-30 10:17:58.000000000","message":"thanks, as written above indeed I am not sure about that one. Current tempest tests in the existing jobs are only really executing API get/show calls (exception is the -strategies job which seems to execute a test strategy). Probably we won\u0027t need any changes in the watcher-tempest-plugin as part of this work I\u0027ll reword or remove this","commit_id":"3be576d9b5c804adc68ef715dc6a7cfff1b5608a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0f908e9932c6c3bf457f7d42a7d0d5347c89bf6a","unresolved":false,"context_lines":[{"line_number":150,"context_line":"The devstack integration that is part of this proposal should be utilized in a"},{"line_number":151,"context_line":"CI job against the Watcher code repo. Another consideration is to expand the"},{"line_number":152,"context_line":"[watcher-tempest-plugin](https://github.com/openstack/watcher-tempest-plugin)"},{"line_number":153,"context_line":"to add appropriate scenario testing the Watcher and Prometheus integration."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Documentation Impact"},{"line_number":156,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"8937e303_6b21cc4b","line":153,"in_reply_to":"67b8d561_582268ac","updated":"2024-10-30 14:40:16.000000000","message":"Acknowledged","commit_id":"3be576d9b5c804adc68ef715dc6a7cfff1b5608a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a1fd82d844d98bd88ae48bec76fea77a8c9eaf2","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Include the URL of your launchpad blueprint:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/watcher/+spec/example"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Watcher currently supports a small number of data sources for collection of"},{"line_number":16,"context_line":"metrics: Ceilometer, Gnocchi and Grafana. Prometheus is a widely adopted"}],"source_content_type":"text/x-rst","patch_set":6,"id":"6cfb42a8_94efa548","line":13,"updated":"2024-10-31 18:44:47.000000000","message":"nit: this should be \nhttps://blueprints.launchpad.net/watcher/+spec/prometheus-datasource\n\nthe file name - the file format extension.","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"52f041f0e77e29db37234efc9373b3219e9a0813","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Include the URL of your launchpad blueprint:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/watcher/+spec/example"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Watcher currently supports a small number of data sources for collection of"},{"line_number":16,"context_line":"metrics: Ceilometer, Gnocchi and Grafana. Prometheus is a widely adopted"}],"source_content_type":"text/x-rst","patch_set":6,"id":"55c8b5e8_f0cf97e9","line":13,"in_reply_to":"6cfb42a8_94efa548","updated":"2024-11-01 10:54:12.000000000","message":"thanks, and you just reminded me to actually go register it ;) so now it is actually a thing: https://blueprints.launchpad.net/watcher/+spec/prometheus-datasource","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a1fd82d844d98bd88ae48bec76fea77a8c9eaf2","unresolved":true,"context_lines":[{"line_number":26,"context_line":"will increase the potential user base for Watcher and especially to those"},{"line_number":27,"context_line":"operators that are familiar with or already using Prometheus."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Problem description"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Watcher currently supports a small number of data sources for collection of"}],"source_content_type":"text/x-rst","patch_set":6,"id":"b84299b7_1662849d","line":29,"updated":"2024-10-31 18:44:47.000000000","message":"so this secation shoudl be \"the what\" it should not try and motivate \"why\" a change should be made form the perspective of an end user, it should describe what the deficiency in the projects current capablities are and why adressign that is benifical to the proejct adn in its scope.","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"52f041f0e77e29db37234efc9373b3219e9a0813","unresolved":false,"context_lines":[{"line_number":26,"context_line":"will increase the potential user base for Watcher and especially to those"},{"line_number":27,"context_line":"operators that are familiar with or already using Prometheus."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Problem description"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Watcher currently supports a small number of data sources for collection of"}],"source_content_type":"text/x-rst","patch_set":6,"id":"0bb87209_afd80be3","line":29,"in_reply_to":"b84299b7_1662849d","updated":"2024-11-01 10:54:12.000000000","message":"Acknowledged","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a1fd82d844d98bd88ae48bec76fea77a8c9eaf2","unresolved":true,"context_lines":[{"line_number":29,"context_line":"Problem description"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Watcher currently supports a small number of data sources for collection of"},{"line_number":33,"context_line":"metrics: Ceilometer, Gnocchi and Grafana. Prometheus is a widely adopted"},{"line_number":34,"context_line":"metric collection system that fetches and stores time/series tagged data from"},{"line_number":35,"context_line":"exposed metrics API endpoints (Prometheus \u0027targets\u0027). Besides being able to"},{"line_number":36,"context_line":"expose any arbitrary metric an operator cares to set up, the scraped \u0027targets\u0027"},{"line_number":37,"context_line":"are simple HTTP endpoints and so the backend implementation of those can be in"},{"line_number":38,"context_line":"any language/platform. This extensibility is one of the reasons for the wide"},{"line_number":39,"context_line":"adoption of Prometheus for metering."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"By providing the ability to couple the efficient and highly customizable"},{"line_number":42,"context_line":"Prometheus collector with the Watcher project operators can achieve a powerful"},{"line_number":43,"context_line":"optimization solution for their OpenStack deployments. There is currently no"},{"line_number":44,"context_line":"way to use Prometheus as a data source for Watcher."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Use Cases"},{"line_number":47,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"57fb948b_d2768489","line":44,"range":{"start_line":32,"start_character":0,"end_line":44,"end_character":51},"updated":"2024-10-31 18:44:47.000000000","message":"some of this is duplicating the initial summary so i would rewrite this as follows.\n\n\n```suggestion\nWatcher currently supports a small number of data sources.\nSeveral of the current options are no longer actively developed\nand integrated with OpenStack distributions limiting the ability\nto deploy watcher.\n\nAs Prometheus becomes the de facto standard metrics store in the Kubernetes\necosystem and OpenStack is increasingly deployed on Kubernetes,\nwatchers\u0027 inability to consume metrics from Prometheus\nlimits the project\u0027s reach.\n```","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"52f041f0e77e29db37234efc9373b3219e9a0813","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Problem description"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Watcher currently supports a small number of data sources for collection of"},{"line_number":33,"context_line":"metrics: Ceilometer, Gnocchi and Grafana. Prometheus is a widely adopted"},{"line_number":34,"context_line":"metric collection system that fetches and stores time/series tagged data from"},{"line_number":35,"context_line":"exposed metrics API endpoints (Prometheus \u0027targets\u0027). Besides being able to"},{"line_number":36,"context_line":"expose any arbitrary metric an operator cares to set up, the scraped \u0027targets\u0027"},{"line_number":37,"context_line":"are simple HTTP endpoints and so the backend implementation of those can be in"},{"line_number":38,"context_line":"any language/platform. This extensibility is one of the reasons for the wide"},{"line_number":39,"context_line":"adoption of Prometheus for metering."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"By providing the ability to couple the efficient and highly customizable"},{"line_number":42,"context_line":"Prometheus collector with the Watcher project operators can achieve a powerful"},{"line_number":43,"context_line":"optimization solution for their OpenStack deployments. There is currently no"},{"line_number":44,"context_line":"way to use Prometheus as a data source for Watcher."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Use Cases"},{"line_number":47,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9df256c1_e7866af3","line":44,"range":{"start_line":32,"start_character":0,"end_line":44,"end_character":51},"in_reply_to":"57fb948b_d2768489","updated":"2024-11-01 10:54:12.000000000","message":"Acknowledged","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a1fd82d844d98bd88ae48bec76fea77a8c9eaf2","unresolved":true,"context_lines":[{"line_number":43,"context_line":"optimization solution for their OpenStack deployments. There is currently no"},{"line_number":44,"context_line":"way to use Prometheus as a data source for Watcher."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Use Cases"},{"line_number":47,"context_line":"----------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This will allow operators that are familiar with or already deploy Prometheus"}],"source_content_type":"text/x-rst","patch_set":6,"id":"edc08337_b5af8786","line":46,"updated":"2024-10-31 18:44:47.000000000","message":"this is the why","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"52f041f0e77e29db37234efc9373b3219e9a0813","unresolved":false,"context_lines":[{"line_number":43,"context_line":"optimization solution for their OpenStack deployments. There is currently no"},{"line_number":44,"context_line":"way to use Prometheus as a data source for Watcher."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Use Cases"},{"line_number":47,"context_line":"----------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This will allow operators that are familiar with or already deploy Prometheus"}],"source_content_type":"text/x-rst","patch_set":6,"id":"a75c4d9b_23f98f9e","line":46,"in_reply_to":"edc08337_b5af8786","updated":"2024-11-01 10:54:12.000000000","message":"Done","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a1fd82d844d98bd88ae48bec76fea77a8c9eaf2","unresolved":true,"context_lines":[{"line_number":46,"context_line":"Use Cases"},{"line_number":47,"context_line":"----------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This will allow operators that are familiar with or already deploy Prometheus"},{"line_number":50,"context_line":"as a metrics collector in their OpenStack environments to leverage the power"},{"line_number":51,"context_line":"of Watcher as an optimization engine for their cloud."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Proposed change"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"b8c3df9b_e64c1622","line":51,"range":{"start_line":49,"start_character":0,"end_line":51,"end_character":53},"updated":"2024-10-31 18:44:47.000000000","message":"```suggestion\nAs an operator with existing knowledge of Prometheus, I would like to\nleverage the power of Watcher as an optimization engine, by using it as a data source.\n\nAs a deplorer with existing Kubernetes infrastructure, I would like to reuse the same metrics storage solution across my OpenStack and Kubernetes deployments.\n\nAs a developer of watcher, I want to allow it to be deployed in more OpenStack clouds, leveraging popular open-source tools to increase the project\u0027s reach and adoption.\n```","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"52f041f0e77e29db37234efc9373b3219e9a0813","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Use Cases"},{"line_number":47,"context_line":"----------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This will allow operators that are familiar with or already deploy Prometheus"},{"line_number":50,"context_line":"as a metrics collector in their OpenStack environments to leverage the power"},{"line_number":51,"context_line":"of Watcher as an optimization engine for their cloud."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Proposed change"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"0166720a_f3561931","line":51,"range":{"start_line":49,"start_character":0,"end_line":51,"end_character":53},"in_reply_to":"b8c3df9b_e64c1622","updated":"2024-11-01 10:54:12.000000000","message":"Acknowledged","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a1fd82d844d98bd88ae48bec76fea77a8c9eaf2","unresolved":true,"context_lines":[{"line_number":50,"context_line":"as a metrics collector in their OpenStack environments to leverage the power"},{"line_number":51,"context_line":"of Watcher as an optimization engine for their cloud."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Proposed change"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"We will need to add the Prometheus client and mappings for the collected data."}],"source_content_type":"text/x-rst","patch_set":6,"id":"f122c749_d82c21c2","line":53,"updated":"2024-10-31 18:44:47.000000000","message":"and this is the how.","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"52f041f0e77e29db37234efc9373b3219e9a0813","unresolved":false,"context_lines":[{"line_number":50,"context_line":"as a metrics collector in their OpenStack environments to leverage the power"},{"line_number":51,"context_line":"of Watcher as an optimization engine for their cloud."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Proposed change"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"We will need to add the Prometheus client and mappings for the collected data."}],"source_content_type":"text/x-rst","patch_set":6,"id":"f83c811f_66441842","line":53,"in_reply_to":"f122c749_d82c21c2","updated":"2024-11-01 10:54:12.000000000","message":"Done","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a1fd82d844d98bd88ae48bec76fea77a8c9eaf2","unresolved":true,"context_lines":[{"line_number":53,"context_line":"Proposed change"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"We will need to add the Prometheus client and mappings for the collected data."},{"line_number":57,"context_line":"As a first implementation, we are not expecting to extend the DataSource"},{"line_number":58,"context_line":"METRIC_MAP beyond the existing set (host/instance cpu/ram etc). That could be"},{"line_number":59,"context_line":"considered as future work depending on the success of this proposal."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Alternatives"},{"line_number":62,"context_line":"------------"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"a3fecc99_57d6be38","line":60,"range":{"start_line":56,"start_character":0,"end_line":60,"end_character":1},"updated":"2024-10-31 18:44:47.000000000","message":"```suggestion\nA new Prometheus module will be added to watcher.decision_engine.datasources\nwhich will leverage the https://opendev.org/openstack/python-observabilityclient\nalready used by AODH to retrieve metrics from Prometheus.\n\nhttps://github.com/openstack/aodh/commit/f932265290a4e923eac6111eb28578489c7dce33\n\nAs a first implementation, we are not expecting to extend the DataSource\nMETRIC_MAP beyond the existing set (host/instance cpu/ram etc). That could be\nconsidered future work depending on the success of this proposal.\n\nThe new Prometheus client will provide a default set of mappings to enable a subset of strategies and goals to function by normalising the Prometheus metric names and units to align with the existing values supported by other data sources.\n\n\nThis initial work will not utilise Prometheus alert to enable triggering audits and instead will build on AODH\u0027s existing integration to fulfil that use case.\n\n```","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"52f041f0e77e29db37234efc9373b3219e9a0813","unresolved":false,"context_lines":[{"line_number":53,"context_line":"Proposed change"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"We will need to add the Prometheus client and mappings for the collected data."},{"line_number":57,"context_line":"As a first implementation, we are not expecting to extend the DataSource"},{"line_number":58,"context_line":"METRIC_MAP beyond the existing set (host/instance cpu/ram etc). That could be"},{"line_number":59,"context_line":"considered as future work depending on the success of this proposal."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Alternatives"},{"line_number":62,"context_line":"------------"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"a4af0b4b_59828a11","line":60,"range":{"start_line":56,"start_character":0,"end_line":60,"end_character":1},"in_reply_to":"a3fecc99_57d6be38","updated":"2024-11-01 10:54:12.000000000","message":"Acknowledged","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a1fd82d844d98bd88ae48bec76fea77a8c9eaf2","unresolved":true,"context_lines":[{"line_number":82,"context_line":"Security impact"},{"line_number":83,"context_line":"---------------"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"There will need to be authentication handled by the prometheus_client.py"},{"line_number":86,"context_line":"against the Prometheus instance."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Notifications impact"},{"line_number":89,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"c10be683_94d32a20","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":32},"updated":"2024-10-31 18:44:47.000000000","message":"This may or may not be true. to me that tis more a \"Other deployer impact\"\nas its really a constraint of the installer or deployer to secure the Prometheus instance appropriately.\n\nso i think it fair to say no impact as there is no impact to the security posture of watcher.","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"52f041f0e77e29db37234efc9373b3219e9a0813","unresolved":false,"context_lines":[{"line_number":82,"context_line":"Security impact"},{"line_number":83,"context_line":"---------------"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"There will need to be authentication handled by the prometheus_client.py"},{"line_number":86,"context_line":"against the Prometheus instance."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Notifications impact"},{"line_number":89,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"52859344_034ced39","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":32},"in_reply_to":"c10be683_94d32a20","updated":"2024-11-01 10:54:12.000000000","message":"Acknowledged (moved into other deployer)","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a1fd82d844d98bd88ae48bec76fea77a8c9eaf2","unresolved":true,"context_lines":[{"line_number":104,"context_line":"Other deployer impact"},{"line_number":105,"context_line":"---------------------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"No anticipated impact besides the ability to integrate with a new data source."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Developer impact"},{"line_number":110,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"32060314_f53e2bb6","line":107,"updated":"2024-10-31 18:44:47.000000000","message":"a new optional dependency on python-observabilityclient will be introduced which may require changes to packaging and instllers.\n\nthis is out of the scope of the spec.","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"52f041f0e77e29db37234efc9373b3219e9a0813","unresolved":false,"context_lines":[{"line_number":104,"context_line":"Other deployer impact"},{"line_number":105,"context_line":"---------------------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"No anticipated impact besides the ability to integrate with a new data source."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Developer impact"},{"line_number":110,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"035cee49_4141225b","line":107,"in_reply_to":"32060314_f53e2bb6","updated":"2024-11-01 10:54:12.000000000","message":"Acknowledged","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"90330f353b8b7d7441c35b4ef40d79122e4058d3","unresolved":true,"context_lines":[{"line_number":118,"context_line":"Assignee(s)"},{"line_number":119,"context_line":"-----------"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Dan Smith, Sean Mooney, Marios Andreou, Martin Kopec (who else here?)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Work Items"},{"line_number":124,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5c404447_c9674742","line":121,"updated":"2024-10-31 15:41:17.000000000","message":"I didn\u0027t notice this before, but probably best not to put my name here. I\u0027ll be glad to help review, but I\u0027m not planning to actually do this work. I assume Marios, you would be the primary assignee?\n\nIn nova, we have a \"reviewers\" section here, and you can certainly put my name down for that :)","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a1fd82d844d98bd88ae48bec76fea77a8c9eaf2","unresolved":true,"context_lines":[{"line_number":118,"context_line":"Assignee(s)"},{"line_number":119,"context_line":"-----------"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Dan Smith, Sean Mooney, Marios Andreou, Martin Kopec (who else here?)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Work Items"},{"line_number":124,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bfe4811f_2395f979","line":121,"in_reply_to":"5c404447_c9674742","updated":"2024-10-31 18:44:47.000000000","message":"yes Marios will likely take the lead on the implementation but ill\nassist both in review and testing or as needed.","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"52f041f0e77e29db37234efc9373b3219e9a0813","unresolved":true,"context_lines":[{"line_number":118,"context_line":"Assignee(s)"},{"line_number":119,"context_line":"-----------"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Dan Smith, Sean Mooney, Marios Andreou, Martin Kopec (who else here?)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Work Items"},{"line_number":124,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"4f5307da_f806ab06","line":121,"in_reply_to":"bfe4811f_2395f979","updated":"2024-11-01 10:54:12.000000000","message":"ack Dan I will add a Reviewers section\n\nI am definitely happy to work here but I don\u0027t know if i can take the lead.. I\u0027ll update the names for now and keep me and Sean and lets see who else is interested, i know Doug was asking yesterday about tasks here","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a1fd82d844d98bd88ae48bec76fea77a8c9eaf2","unresolved":true,"context_lines":[{"line_number":153,"context_line":"(e.g. authentication against Prometheus works, metrics can be received"},{"line_number":154,"context_line":"correctly etc) ideally this should include functional testing similar to the"},{"line_number":155,"context_line":"existing watcher-tempest-strategies job that has execution of strategies."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Documentation Impact"},{"line_number":158,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"2ee0d04c_eaf6fdc5","line":156,"updated":"2024-10-31 18:44:47.000000000","message":"i think we shoudl remove the refence to auth as at least initially it think we will start without configuring auth for Prometious.\n\ni do not believe https://opendev.org/openstack/python-observabilityclient has support for authentication and that is a general gap in  Prometheus in general so we should take this in a phased approach.\n\nlets enable the integration, then build on it to secure later and initally document that access to Prometheus should be restricted by the installer.","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"52f041f0e77e29db37234efc9373b3219e9a0813","unresolved":false,"context_lines":[{"line_number":153,"context_line":"(e.g. authentication against Prometheus works, metrics can be received"},{"line_number":154,"context_line":"correctly etc) ideally this should include functional testing similar to the"},{"line_number":155,"context_line":"existing watcher-tempest-strategies job that has execution of strategies."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Documentation Impact"},{"line_number":158,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"0f45c441_e97bd667","line":156,"in_reply_to":"2ee0d04c_eaf6fdc5","updated":"2024-11-01 10:54:12.000000000","message":"Acknowledged","commit_id":"fb91245be654ea7c7d900eae3b858b83643d8b90"}]}