)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"49eb9f16da3141437a36ca64f2f7c3eb329cba23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7fddc366_c85ea3df","updated":"2025-10-31 14:19:34.000000000","message":"Thanks for this, I can we can proceed with this spec and start moving ahead.","commit_id":"20a02c39ad55f1820454624795bfeecba6ba2378"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"25f0c5bfcde2c88aaaae97ff2cbfb2f02144b8cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"543caf1f_a12a88c2","updated":"2025-11-04 09:53:21.000000000","message":"the proposal looks great, thanks Sean! I think we only need to fix the release name in the `History` section and it\u0027s good to go","commit_id":"20a02c39ad55f1820454624795bfeecba6ba2378"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4bcb71dc10862b02804e62b00dd3ec12650ed165","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8140726c_4dd91723","updated":"2025-11-13 19:11:35.000000000","message":"@viroel@gmail.com ill leave this open for another week for you or others to review but if there is no additional feedback ill assume we agree to proceed with this at a high level and we can update it if there are any concerns.\n\nill add this to the irc meeting review list for next week.","commit_id":"4df03bcd22d12dfb1cdf15c1143d9e17136197b2"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"21c623b76956c60cd6d17000aab161d8db7d9d2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"376e49f0_50e624c1","updated":"2025-11-17 19:30:00.000000000","message":"lgtm, I was only reading through this spec and not considering the references that have much more content.\nThe spec has enough approvals from other reviewers, so going to W+1\nThanks!","commit_id":"4df03bcd22d12dfb1cdf15c1143d9e17136197b2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aa2e60b99dc7a434a23db661da7abcdf327a7f6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0ad83441_e0fdbfbe","in_reply_to":"8140726c_4dd91723","updated":"2025-11-13 19:15:44.000000000","message":"we are not in a huge rush but i want to see if we can get this landed before the end of the month","commit_id":"4df03bcd22d12dfb1cdf15c1143d9e17136197b2"}],"specs/2026.1/approved/functional-testing.rst":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"681b86f249dd1e9d413c44cff62c4a97655a7443","unresolved":true,"context_lines":[{"line_number":104,"context_line":"    │   │   └── ..."},{"line_number":105,"context_line":"    │   └── regressions/          # Bug-specific tests"},{"line_number":106,"context_line":"    │       └── test_bug_*.py"},{"line_number":107,"context_line":"    ├── local_fixtures/            # Shared fixtures"},{"line_number":108,"context_line":"    │   ├── conf.py               # Configuration fixture"},{"line_number":109,"context_line":"    │   ├── database.py           # Database fixture"},{"line_number":110,"context_line":"    │   ├── rpc.py                # RPC fixtures"}],"source_content_type":"text/x-rst","patch_set":1,"id":"243ce60c_b4337ff4","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":2},"updated":"2025-10-31 10:21:17.000000000","message":"These local_fixtures would be only for functional tests, right? I\u0027d use a more clear name functional_fixtures or something like that.","commit_id":"20a02c39ad55f1820454624795bfeecba6ba2378"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"61b656a2bf4fff45ba5d4dab3077ac2d4a5a51f2","unresolved":true,"context_lines":[{"line_number":104,"context_line":"    │   │   └── ..."},{"line_number":105,"context_line":"    │   └── regressions/          # Bug-specific tests"},{"line_number":106,"context_line":"    │       └── test_bug_*.py"},{"line_number":107,"context_line":"    ├── local_fixtures/            # Shared fixtures"},{"line_number":108,"context_line":"    │   ├── conf.py               # Configuration fixture"},{"line_number":109,"context_line":"    │   ├── database.py           # Database fixture"},{"line_number":110,"context_line":"    │   ├── rpc.py                # RPC fixtures"}],"source_content_type":"text/x-rst","patch_set":1,"id":"69e270e2_4b5fcecb","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":2},"in_reply_to":"243ce60c_b4337ff4","updated":"2025-10-31 11:58:00.000000000","message":"no ideally the unit test can use them too\nit depend on what the fixtre does but our base test case that woudl be comon between the unit and fucntion tests shoud use tehse fixtures as appropriate.\n\nbasiclay if oslo test and oslo config did not alreayd provde loging and cofnig fixture we woudl put those in this folder and use them for both unit and fuctionl tests\n\nif we have anything that shoudl be set up for all test regardless we can create a fixture for that and invoke it form the common base test case\n\nmost unit test will not enable the fixtures but they could if it made sene to do so\n\nfor example a unit test that jsut applies the alembic migraiton and assert it successed coudl use ad basic db fixture\n\nWe would want a more advanced db fixture that also did the migration but those are the type of seams we can create\n\nBaseDBFixture \u003c-- just createa an empty db and configure watcher to use it\nDBFixture(BaseDBFixture) auto applies the almenbic migration so that we start from a vaild schema.\n\nthe unit test coudl use the former the functional test would use the latter\n\nthat why i comemned that its for shared fixtures nto jsut functional fixutres","commit_id":"20a02c39ad55f1820454624795bfeecba6ba2378"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"49eb9f16da3141437a36ca64f2f7c3eb329cba23","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    │   │   └── ..."},{"line_number":105,"context_line":"    │   └── regressions/          # Bug-specific tests"},{"line_number":106,"context_line":"    │       └── test_bug_*.py"},{"line_number":107,"context_line":"    ├── local_fixtures/            # Shared fixtures"},{"line_number":108,"context_line":"    │   ├── conf.py               # Configuration fixture"},{"line_number":109,"context_line":"    │   ├── database.py           # Database fixture"},{"line_number":110,"context_line":"    │   ├── rpc.py                # RPC fixtures"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d059b25a_9e6d86c8","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":2},"in_reply_to":"69e270e2_4b5fcecb","updated":"2025-10-31 14:19:34.000000000","message":"Understood, thanks for the explanation.","commit_id":"20a02c39ad55f1820454624795bfeecba6ba2378"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"681b86f249dd1e9d413c44cff62c4a97655a7443","unresolved":true,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"None. Functional tests validate existing notification behavior. The"},{"line_number":165,"context_line":"notification fixture captures emitted notifications for verification but"},{"line_number":166,"context_line":"does not change notification emission logic."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Other end user impact"},{"line_number":169,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e1b5e0ab_dd31285e","line":166,"updated":"2025-10-31 10:21:17.000000000","message":"I understand we will not simulate nova and cinder notifications in the services fixtures, that would be a limitation of functional testing, at least in a first phase, right? Would it be worthy to document this limitation in the spec?","commit_id":"20a02c39ad55f1820454624795bfeecba6ba2378"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"49eb9f16da3141437a36ca64f2f7c3eb329cba23","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"None. Functional tests validate existing notification behavior. The"},{"line_number":165,"context_line":"notification fixture captures emitted notifications for verification but"},{"line_number":166,"context_line":"does not change notification emission logic."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Other end user impact"},{"line_number":169,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"58852197_cdd52ee9","line":166,"in_reply_to":"52cd33e8_c94293de","updated":"2025-10-31 14:19:34.000000000","message":"got it.","commit_id":"20a02c39ad55f1820454624795bfeecba6ba2378"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5af8ffca64a6a8bcb628906ba3ddba3087a60cd0","unresolved":true,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"None. Functional tests validate existing notification behavior. The"},{"line_number":165,"context_line":"notification fixture captures emitted notifications for verification but"},{"line_number":166,"context_line":"does not change notification emission logic."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Other end user impact"},{"line_number":169,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"52cd33e8_c94293de","line":166,"in_reply_to":"e1b5e0ab_dd31285e","updated":"2025-10-31 11:59:22.000000000","message":"no that not what htis is saying\nthis is sayign that we hafe no change to the notification of the production watcher code\n\ni expect to simulate the nova/cidner notifcation in the fixtures as required\nbut that will only impact the funtional test that use them so we dont call it out here.","commit_id":"20a02c39ad55f1820454624795bfeecba6ba2378"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"25f0c5bfcde2c88aaaae97ff2cbfb2f02144b8cf","unresolved":true,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"   * - Release Name"},{"line_number":293,"context_line":"     - Description"},{"line_number":294,"context_line":"   * - 2025.2"},{"line_number":295,"context_line":"     - Introduced"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"77e80700_4decb446","line":294,"updated":"2025-11-04 09:53:21.000000000","message":"```suggestion\n   * - 2026.1\n```","commit_id":"20a02c39ad55f1820454624795bfeecba6ba2378"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ce9ffc5b7deaec908a5b8f74734a4ac3209014a3","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"   * - Release Name"},{"line_number":293,"context_line":"     - Description"},{"line_number":294,"context_line":"   * - 2025.2"},{"line_number":295,"context_line":"     - Introduced"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"4e59977f_dfdb4a7a","line":294,"in_reply_to":"77e80700_4decb446","updated":"2025-11-04 11:00:54.000000000","message":"lol yes this is incorrect","commit_id":"20a02c39ad55f1820454624795bfeecba6ba2378"}]}